Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Feb 6, 2019

Needed for nextcloud/android#894 and nextcloud/android#3574

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypeMasterPR
Warnings00
Errors00

FindBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings5
Malicious code vulnerability Warnings9
Multithreaded correctness Warnings3
Performance Warnings19
Security Warnings29
Dodgy code Warnings86
Total203

FindBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings5
Malicious code vulnerability Warnings9
Multithreaded correctness Warnings3
Performance Warnings19
Security Warnings29
Dodgy code Warnings86
Total203

@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #235 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   11.64%   11.64%           
=======================================
  Files         117      117           
  Lines        5573     5573           
  Branches      725      725           
=======================================
  Hits          649      649           
  Misses       4818     4818           
  Partials      106      106
Impacted Files Coverage Δ
...d/lib/common/operations/RemoteOperationResult.java 29.84% <0%> (ø) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #235 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   11.64%   11.64%           
=======================================
  Files         117      117           
  Lines        5573     5573           
  Branches      725      725           
=======================================
  Hits          649      649           
  Misses       4818     4818           
  Partials      106      106
Impacted Files Coverage Δ
...d/lib/common/operations/RemoteOperationResult.java 29.84% <0%> (ø) ⬆️

@AndyScherzinger AndyScherzinger added this to the NC lib 1.4.0 milestone Feb 6, 2019
@AndyScherzinger AndyScherzinger merged commit 3ea146f into master Feb 6, 2019
@AndyScherzinger AndyScherzinger deleted the serverUnavailable branch February 6, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants