Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #282

tobiasKaminsky
tobiasKaminsky previously approved these changes May 6, 2019
…ote path

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-1.4PR
Warnings00
Errors00

FindBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings86
Total189

FindBugs (stable-1.4)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings86
Total189

@nextcloud nextcloud deleted a comment May 6, 2019
@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #288 into stable-1.4 will increase coverage by 4.43%.
The diff coverage is 60%.

@@              Coverage Diff               @@
##           stable-1.4     #288      +/-   ##
==============================================
+ Coverage       12.59%   17.03%   +4.43%     
==============================================
  Files             120      120              
  Lines            5311     5314       +3     
  Branches          739      740       +1     
==============================================
+ Hits              669      905     +236     
+ Misses           4534     4282     -252     
- Partials          108      127      +19
Impacted Files Coverage Δ
...oid/lib/resources/files/SearchRemoteOperation.java 56.99% <60%> (+56.99%) ⬆️
...om/owncloud/android/lib/common/OwnCloudClient.java 39.56% <0%> (+0.54%) ⬆️
...cloud/android/lib/common/network/NetworkUtils.java 51.56% <0%> (+1.56%) ⬆️
...d/lib/common/operations/RemoteOperationResult.java 32.59% <0%> (+2.84%) ⬆️
...lib/resources/files/ReadFolderRemoteOperation.java 70.49% <0%> (+6.55%) ⬆️
...android/lib/common/OwnCloudCredentialsFactory.java 53.33% <0%> (+6.66%) ⬆️
...ncloud/android/lib/common/network/WebdavUtils.java 55.55% <0%> (+15.55%) ⬆️
...ncloud/android/lib/common/network/WebdavEntry.java 69.69% <0%> (+17.57%) ⬆️
.../android/lib/resources/files/model/RemoteFile.java 40.56% <0%> (+19.81%) ⬆️
... and 2 more

1 similar comment
@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #288 into stable-1.4 will increase coverage by 4.43%.
The diff coverage is 60%.

@@              Coverage Diff               @@
##           stable-1.4     #288      +/-   ##
==============================================
+ Coverage       12.59%   17.03%   +4.43%     
==============================================
  Files             120      120              
  Lines            5311     5314       +3     
  Branches          739      740       +1     
==============================================
+ Hits              669      905     +236     
+ Misses           4534     4282     -252     
- Partials          108      127      +19
Impacted Files Coverage Δ
...oid/lib/resources/files/SearchRemoteOperation.java 56.99% <60%> (+56.99%) ⬆️
...om/owncloud/android/lib/common/OwnCloudClient.java 39.56% <0%> (+0.54%) ⬆️
...cloud/android/lib/common/network/NetworkUtils.java 51.56% <0%> (+1.56%) ⬆️
...d/lib/common/operations/RemoteOperationResult.java 32.59% <0%> (+2.84%) ⬆️
...lib/resources/files/ReadFolderRemoteOperation.java 70.49% <0%> (+6.55%) ⬆️
...android/lib/common/OwnCloudCredentialsFactory.java 53.33% <0%> (+6.66%) ⬆️
...ncloud/android/lib/common/network/WebdavUtils.java 55.55% <0%> (+15.55%) ⬆️
...ncloud/android/lib/common/network/WebdavEntry.java 69.69% <0%> (+17.57%) ⬆️
.../android/lib/resources/files/model/RemoteFile.java 40.56% <0%> (+19.81%) ⬆️
... and 2 more

@tobiasKaminsky tobiasKaminsky merged commit 62add08 into stable-1.4 May 6, 2019
@tobiasKaminsky tobiasKaminsky deleted the backport/282/stable-1.4 branch May 6, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants