Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #384

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-2.0PR
Warnings00
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings58
Total145

SpotBugs (stable-2.0)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings58
Total145

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #385 into stable-2.0 will increase coverage by 0.11%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##           stable-2.0     #385      +/-   ##
==============================================
+ Coverage       34.37%   34.49%   +0.11%     
==============================================
  Files             133      133              
  Lines            5728     5729       +1     
  Branches          751      751              
==============================================
+ Hits             1969     1976       +7     
+ Misses           3486     3481       -5     
+ Partials          273      272       -1
Impacted Files Coverage Δ
...tediting/DirectEditingOpenFileRemoteOperation.java 80% <100%> (+13.33%) ⬆️
...wncloud/android/lib/resources/files/FileUtils.java 71.42% <0%> (-14.29%) ⬇️
...d/lib/common/operations/RemoteOperationResult.java 36.58% <0%> (+0.6%) ⬆️
...d/lib/resources/files/ReadFileRemoteOperation.java 79.31% <0%> (+10.34%) ⬆️

@AndyScherzinger AndyScherzinger merged commit 7998579 into stable-2.0 Jan 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the backport/384/stable-2.0 branch January 24, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants