-
Notifications
You must be signed in to change notification settings - Fork 2.3k
go.mod: bump up deps; CI: remove appveyor, add macOS #1460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
https://ci.appveyor.com/project/sirupsen/logrus/builds/52271745 Appveyor seems to still use Go 1.13? |
GHA should suffice for running tests on Windows Signed-off-by: Akihiro Suda <[email protected]>
Yes, makes sense to me. Less to maintain! |
|
I guess we could (should?) add macOS as well |
The minimum Go version is now bumped up from 1.13 to 1.17. Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I'm assuming AppVeyor will disappear after this, but we could probably do a test PR after this to see if it stops complaining (or if changes to the repo settings are needed)
|
Appveyor is failing for the master: https://ci.appveyor.com/project/sirupsen/logrus/builds/52271891 @thaJeztah Could you update the repo setting? |
|
😢 unfortunately I don't have access to settings; perhaps @sirupsen is able to (or to grant access). If possible, I also would not mind having @AkihiroSuda as co-maintainer. Alternatively, we could add a stub AppVeyor config as a temporary workaround |
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) | `v1.9.3` -> `v1.9.4` |  |  | --- ### Release Notes <details> <summary>sirupsen/logrus (github.com/sirupsen/logrus)</summary> ### [`v1.9.4`](https://github.com/sirupsen/logrus/releases/tag/v1.9.4) [Compare Source](sirupsen/logrus@v1.9.3...v1.9.4) #### Notable changes - go.mod: update minimum supported go version to v1.17 [#​1460](sirupsen/logrus#1460) - go.mod: bump up dependencies [#​1460](sirupsen/logrus#1460) - Touch-up godoc and add "doc" links. - README: fix links, grammar, and update examples. - Add GNU/Hurd support [#​1364](sirupsen/logrus#1364) - Add WASI wasip1 support [#​1388](sirupsen/logrus#1388) - Remove uses of deprecated `ioutil` package [#​1472](sirupsen/logrus#1472) - CI: update actions and golangci-lint [#​1459](sirupsen/logrus#1459) - CI: remove appveyor, add macOS [#​1460](sirupsen/logrus#1460) **Full Changelog**: <sirupsen/logrus@v1.9.3...v1.9.4> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi43OC4xIiwidXBkYXRlZEluVmVyIjoiNDIuNzguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiS2luZC9EZXBlbmRlbmN5VXBkYXRlIiwicnVuLWVuZC10by1lbmQtdGVzdHMiXX0=--> Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1306 Reviewed-by: Mathieu Fenniak <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
The minimum Go version is now bumped up from 1.13 to 1.17. (Corresponds to the Go version tested on GHA)