Skip to content

Conversation

@AkihiroSuda
Copy link
Contributor

@AkihiroSuda AkihiroSuda commented Jun 20, 2025

@AkihiroSuda
Copy link
Contributor Author

https://ci.appveyor.com/project/sirupsen/logrus/builds/52271745

[Console](https://ci.appveyor.com/project/sirupsen/logrus/builds/52271745) [Messages ](https://ci.appveyor.com/project/sirupsen/logrus/builds/52271745/messages) [Tests ](https://ci.appveyor.com/project/sirupsen/logrus/builds/52271745/tests) Artifacts
Build started
git clone -q https://github.com/sirupsen/logrus.git c:\gopath\src\github.com\sirupsen\logrus
git fetch -q origin +refs/pull/1460/merge:
git checkout -qf FETCH_HEAD
Running Install scripts
set PATH=%GOPATH%\bin;c:\go\bin;%PATH%
go version
go version go1.13.3 windows/amd64
go get -t
go: downloading golang.org/x/sys v0.13.0
go: downloading github.com/stretchr/testify v1.10.0
go: extracting github.com/stretchr/testify v1.10.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading gopkg.in/yaml.v3 v3.0.1
go: extracting gopkg.in/yaml.v3 v3.0.1
go: extracting github.com/pmezard/go-difflib v1.0.0
go: extracting github.com/davecgh/go-spew v1.1.1
go: extracting golang.org/x/sys v0.13.0
go: finding golang.org/x/sys v0.13.0
# golang.org/x/sys/windows
c:\gopath\pkg\mod\golang.org\x\[email protected]\windows\env_windows.go:47:12: undefined: unsafe.Add
c:\gopath\pkg\mod\golang.org\x\[email protected]\windows\exec_windows.go:163:20: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\[email protected]\windows\security_windows.go:1342:9: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\[email protected]\windows\security_windows.go:1349:9: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\[email protected]\windows\syscall.go:84:16: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\[email protected]\windows\syscall_windows.go:129:29: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\[email protected]\windows\syscall_windows.go:1030:20: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\[email protected]\windows\syscall_windows.go:1671:11: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\[email protected]\windows\syscall_windows.go:1695:11: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\[email protected]\windows\syscall_windows.go:1748:9: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\[email protected]\windows\syscall_windows.go:1748:9: too many errors
note: module requires Go 1.17

Appveyor seems to still use Go 1.13?
But I guess we can just remove Appveyor, as we now have Windows on GHA?

@AkihiroSuda AkihiroSuda changed the title go.mod: bump up deps go.mod: bump up deps; CI: remove appveyor Jun 20, 2025
GHA should suffice for running tests on Windows

Signed-off-by: Akihiro Suda <[email protected]>
@thaJeztah
Copy link
Collaborator

But I guess we can just remove Appveyor, as we now have Windows on GHA

Yes, makes sense to me. Less to maintain!

@thaJeztah
Copy link
Collaborator

I guess we could (should?) add macOS as well

The minimum Go version is now bumped up from 1.13 to 1.17.

Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda changed the title go.mod: bump up deps; CI: remove appveyor go.mod: bump up deps; CI: remove appveyor, add macOS Jun 20, 2025
Copy link
Collaborator

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I'm assuming AppVeyor will disappear after this, but we could probably do a test PR after this to see if it stops complaining (or if changes to the repo settings are needed)

@thaJeztah thaJeztah merged commit 70b8093 into sirupsen:master Jun 20, 2025
11 of 12 checks passed
@AkihiroSuda
Copy link
Contributor Author

Appveyor is failing for the master: https://ci.appveyor.com/project/sirupsen/logrus/builds/52271891

@thaJeztah Could you update the repo setting?

@thaJeztah
Copy link
Collaborator

😢 unfortunately I don't have access to settings; perhaps @sirupsen is able to (or to grant access). If possible, I also would not mind having @AkihiroSuda as co-maintainer.

Alternatively, we could add a stub AppVeyor config as a temporary workaround

arthurzam pushed a commit to gentoo-golang-dist/forgejo-runner that referenced this pull request Jan 18, 2026
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) | `v1.9.3` -> `v1.9.4` | ![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsirupsen%2flogrus/v1.9.4?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsirupsen%2flogrus/v1.9.3/v1.9.4?slim=true) |

---

### Release Notes

<details>
<summary>sirupsen/logrus (github.com/sirupsen/logrus)</summary>

### [`v1.9.4`](https://github.com/sirupsen/logrus/releases/tag/v1.9.4)

[Compare Source](sirupsen/logrus@v1.9.3...v1.9.4)

#### Notable changes

- go.mod: update minimum supported go version to v1.17 [#&#8203;1460](sirupsen/logrus#1460)
- go.mod: bump up dependencies  [#&#8203;1460](sirupsen/logrus#1460)
- Touch-up godoc and add "doc" links.
- README: fix links, grammar, and update examples.
- Add GNU/Hurd support [#&#8203;1364](sirupsen/logrus#1364)
- Add WASI wasip1 support [#&#8203;1388](sirupsen/logrus#1388)
- Remove uses of deprecated `ioutil` package [#&#8203;1472](sirupsen/logrus#1472)
- CI: update actions and golangci-lint [#&#8203;1459](sirupsen/logrus#1459)
- CI: remove appveyor, add macOS  [#&#8203;1460](sirupsen/logrus#1460)

**Full Changelog**: <sirupsen/logrus@v1.9.3...v1.9.4>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi43OC4xIiwidXBkYXRlZEluVmVyIjoiNDIuNzguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiS2luZC9EZXBlbmRlbmN5VXBkYXRlIiwicnVuLWVuZC10by1lbmQtdGVzdHMiXX0=-->

Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1306
Reviewed-by: Mathieu Fenniak <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update stretchr/testify to 1.9.0 to resolve 2 High sev Vulnerabilities found in go yaml lib from current version Bump version of stretchr/testify?

2 participants