chore(boundaries): Allow packages to import themselves #10202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
anthonyshew
approved these changes
Mar 20, 2025
Contributor
There was a problem hiding this comment.
Additional Comments:
turborepo-tests/integration/tests/command-boundaries.t (line 13):
The test file was not updated after the fixture was modified to include a self-import, causing hardcoded git object hashes and expected diff output to be stale and incorrect.
View Details
📝 Patch Details
diff --git a/turborepo-tests/integration/tests/command-boundaries.t b/turborepo-tests/integration/tests/command-boundaries.t
index a93dcbc13..1934e6c2f 100644
--- a/turborepo-tests/integration/tests/command-boundaries.t
+++ b/turborepo-tests/integration/tests/command-boundaries.t
@@ -10,7 +10,7 @@ Ignore all errors
$ git diff
diff --git a/apps/my-app/index.ts b/apps/my-app/index.ts
- index 6baec29..d4c7af6 100644
+ index 41f5d9c..81fb062 100644
--- a/apps/my-app/index.ts
+++ b/apps/my-app/index.ts
@@ -1,9 +1,13 @@
Analysis
Stale git object hashes in command-boundaries.t test after fixture modification
What fails: Test file turborepo-tests/integration/tests/command-boundaries.t on line 13 contains hardcoded git object hash 6baec29 that doesn't match the current fixture file turborepo-tests/integration/fixtures/boundaries/apps/my-app/index.ts
How to reproduce:
cd turborepo-tests/integration/fixtures/boundaries
git hash-object apps/my-app/index.ts
# Returns: 41f5d9c2d90976132b9eb36486423526d06d86ce
# Test expects: 6baec29605d51c498e0f4c0880e8cb48d155bb19Result: Test expects git hash 6baec29 (old fixture without self-import on lines 26-27) but fixture now produces hash 41f5d9c. Similarly, the expected hash after applying @boundaries-ignore comments is d4c7af6 but should be 81fb062.
Expected: Test should use git hashes that match current fixture content: 41f5d9c (before) and 81fb062 (after adding ignore comments).
Root cause: Fixture was modified to add self-import import { walkThePlank } from "my-app"; on lines 26-27 (per comment "Allow importing own package"), but test's hardcoded git hashes weren't updated to reflect the new fixture content.
ch4og
pushed a commit
to csmplay/mapban
that referenced
this pull request
Dec 23, 2025
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [turbo](https://turborepo.com) ([source](https://github.com/vercel/turborepo)) | [`2.6.3` -> `2.7.1`](https://renovatebot.com/diffs/npm/turbo/2.6.3/2.7.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turborepo (turbo)</summary> ### [`v2.7.1`](https://github.com/vercel/turborepo/releases/tag/v2.7.1): Turborepo v2.7.1 [Compare Source](vercel/turborepo@v2.7.0...v2.7.1) <!-- Release notes generated using configuration in .github/release.yml at v2.7.1 --> #### What's Changed ##### Docs - docs: Release post for 2.7 by [@​anthonyshew](https://github.com/anthonyshew) in [#​11272](vercel/turborepo#11272) ##### Examples - fix: Typo in example with-solid README.md description by [@​jack-dev-crypto](https://github.com/jack-dev-crypto) in [#​11287](vercel/turborepo#11287) ##### Changelog - fix: Correctly validate workspace root as package by [@​anthonyshew](https://github.com/anthonyshew) in [#​11284](vercel/turborepo#11284) - fix: Overly aggressive path checking in microfrontends loading by [@​anthonyshew](https://github.com/anthonyshew) in [#​11286](vercel/turborepo#11286) - chore(boundaries): Allow packages to import themselves by [@​NicholasLYang](https://github.com/NicholasLYang) in [#​10202](vercel/turborepo#10202) - feat(query): Provide query for external dependencies by [@​chris-olszewski](https://github.com/chris-olszewski) in [#​9929](vercel/turborepo#9929) - fix: Correct version mismatch causing noUpdateNotifier to fail by [@​DevaanshKathuria](https://github.com/DevaanshKathuria) in [#​11133](vercel/turborepo#11133) - chore: Format version printing similar to rest of prelude by [@​anthonyshew](https://github.com/anthonyshew) in [#​11289](vercel/turborepo#11289) #### New Contributors - [@​jack-dev-crypto](https://github.com/jack-dev-crypto) made their first contribution in [#​11287](vercel/turborepo#11287) **Full Changelog**: <vercel/turborepo@v2.7.0...v2.7.1> ### [`v2.7.0`](https://github.com/vercel/turborepo/releases/tag/v2.7.0): Turborepo v2.7.0 [Compare Source](vercel/turborepo@v2.6.3...v2.7.0) <!-- Release notes generated using configuration in .github/release.yml at v2.7.0 --> #### What's Changed ##### Docs - docs(security): Update Next.js by [@​anthonyshew](https://github.com/anthonyshew) in [#​11208](vercel/turborepo#11208) - docs: Remove flags code by [@​anthonyshew](https://github.com/anthonyshew) in [#​11209](vercel/turborepo#11209) - docs: Cleanup Sentry from gitignore by [@​anthonyshew](https://github.com/anthonyshew) in [#​11210](vercel/turborepo#11210) - docs: Comment out Tinybird by [@​anthonyshew](https://github.com/anthonyshew) in [#​11211](vercel/turborepo#11211) - docs(fix): Sitemap by [@​anthonyshew](https://github.com/anthonyshew) in [#​11207](vercel/turborepo#11207) - docs: Revert "Comment out Tinybird" by [@​anthonyshew](https://github.com/anthonyshew) in [#​11223](vercel/turborepo#11223) - docs: Move search to built-in by [@​anthonyshew](https://github.com/anthonyshew) in [#​11224](vercel/turborepo#11224) - docs: fix typo in design-system.css comment by [@​YASHRDX0001](https://github.com/YASHRDX0001) in [#​11231](vercel/turborepo#11231) - chore: Upgrade pnpm to 9 by [@​anthonyshew](https://github.com/anthonyshew) in [#​11226](vercel/turborepo#11226) - chore: Update pnpm to version 10 by [@​anthonyshew](https://github.com/anthonyshew) in [#​11237](vercel/turborepo#11237) - fix: React Server Components CVE vulnerabilities by [@​vercel](https://github.com/vercel)\[bot] in [#​11245](vercel/turborepo#11245) - docs: Add `turboExtendsKeyword` future flag and `$TURBO_EXTENDS$` microsyntax by [@​anthonyshew](https://github.com/anthonyshew) in [#​11246](vercel/turborepo#11246) - docs: Fix Bun filtered install commands by [@​anthonyshew](https://github.com/anthonyshew) in [#​11260](vercel/turborepo#11260) - docs: Add `turbo.json` composition docs by [@​anthonyshew](https://github.com/anthonyshew) in [#​11247](vercel/turborepo#11247) - feat: Turborepo Devtools by [@​anthonyshew](https://github.com/anthonyshew) in [#​11263](vercel/turborepo#11263) - fix: Improve layouts and task graph sourcing for devtools" by [@​anthonyshew](https://github.com/anthonyshew) in [#​11269](vercel/turborepo#11269) - docs: Devtools by [@​anthonyshew](https://github.com/anthonyshew) in [#​11270](vercel/turborepo#11270) - chore: Remove future flags for nonRootExtends and turboExtendsKeyword in preparation for stable release by [@​anthonyshew](https://github.com/anthonyshew) in [#​11280](vercel/turborepo#11280) ##### create-turbo - fix(cli): Preserve exit codes in notifyUpdate functions by [@​pyrytakala](https://github.com/pyrytakala) in [#​11153](vercel/turborepo#11153) ##### turbo-ignore - fix: Quoting in turbo-ignore commands by [@​anthonyshew](https://github.com/anthonyshew) in [#​11239](vercel/turborepo#11239) ##### eslint - fix: Upgrade Next.js to 15.5.7 (CVE-2025-55182) by [@​ctate](https://github.com/ctate) in [#​11232](vercel/turborepo#11232) ##### [@​turbo/repository](https://github.com/turbo/repository) - chore: Update to Rust 1.92.0 by [@​ognevny](https://github.com/ognevny) in [#​11250](vercel/turborepo#11250) ##### Examples - examples(dev-deps): bump turbo from 2.6.1 to 2.6.3 in /examples/with-shell-commands by [@​dependabot](https://github.com/dependabot)\[bot] in [#​11217](vercel/turborepo#11217) - examples(dev-deps): bump the basic group in /examples/basic with 2 updates by [@​dependabot](https://github.com/dependabot)\[bot] in [#​11218](vercel/turborepo#11218) - examples(dev-deps): bump the with-svelte group in /examples/with-svelte with 3 updates by [@​dependabot](https://github.com/dependabot)\[bot] in [#​11219](vercel/turborepo#11219) - examples: Use slim image (debian) for prepare and builder stage, use latest no… by [@​mrr11k](https://github.com/mrr11k) in [#​11228](vercel/turborepo#11228) - examples(dev-deps): bump the with-svelte group in /examples/with-svelte with 2 updates by [@​dependabot](https://github.com/dependabot)\[bot] in [#​11254](vercel/turborepo#11254) - examples(dev-deps): bump typescript-eslint from 8.48.1 to 8.49.0 in /examples/basic in the basic group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​11253](vercel/turborepo#11253) - examples(deps): bump react from 19.2.0 to 19.2.3 in /examples/non-monorepo by [@​dependabot](https://github.com/dependabot)\[bot] in [#​11255](vercel/turborepo#11255) ##### Changelog - fix(turbo-utils): Add test for conflicting configs and remove stale TODO by [@​deepakpathik](https://github.com/deepakpathik) in [#​11201](vercel/turborepo#11201) - feat: Yarn 4 catalogs by [@​anthonyshew](https://github.com/anthonyshew) in [#​11115](vercel/turborepo#11115) - fix: Add Windows-specific env var to default passthroughs by [@​anthonyshew](https://github.com/anthonyshew) in [#​11233](vercel/turborepo#11233) - fix: Add fine grained interruptible task restarts in watch mode by [@​johnpyp](https://github.com/johnpyp) in [#​11135](vercel/turborepo#11135) - perf: Find tasks impacted by packages faster by [@​anthonyshew](https://github.com/anthonyshew) in [#​11235](vercel/turborepo#11235) - ci: Fix release pipeline by [@​anthonyshew](https://github.com/anthonyshew) in [#​11240](vercel/turborepo#11240) - ci: Fix release pipeline by [@​anthonyshew](https://github.com/anthonyshew) in [#​11241](vercel/turborepo#11241) - fix: Compose tasks when composing turbo.json by [@​anthonyshew](https://github.com/anthonyshew) in [#​11248](vercel/turborepo#11248) - chore: Run pre-commit fmt on all files by [@​anthonyshew](https://github.com/anthonyshew) in [#​11261](vercel/turborepo#11261) - feat: Task-level `extends` field by [@​anthonyshew](https://github.com/anthonyshew) in [#​11259](vercel/turborepo#11259) - fix: Allow root microfrontends.json config for [@​vercel/microfrontends](https://github.com/vercel/microfrontends) by [@​anthonyshew](https://github.com/anthonyshew) in [#​11264](vercel/turborepo#11264) - chore: Fix lint-staged and orphan GitHub Action by [@​anthonyshew](https://github.com/anthonyshew) in [#​11275](vercel/turborepo#11275) - chore: Remove coverage tooling by [@​anthonyshew](https://github.com/anthonyshew) in [#​11276](vercel/turborepo#11276) - chore: Clear false positive unused warnings by [@​anthonyshew](https://github.com/anthonyshew) in [#​11277](vercel/turborepo#11277) - ci: Fix flaky test (hopefully) by [@​anthonyshew](https://github.com/anthonyshew) in [#​11278](vercel/turborepo#11278) #### New Contributors - [@​deepakpathik](https://github.com/deepakpathik) made their first contribution in [#​11201](vercel/turborepo#11201) - [@​YASHRDX0001](https://github.com/YASHRDX0001) made their first contribution in [#​11231](vercel/turborepo#11231) - [@​ctate](https://github.com/ctate) made their first contribution in [#​11232](vercel/turborepo#11232) - [@​johnpyp](https://github.com/johnpyp) made their first contribution in [#​11135](vercel/turborepo#11135) - [@​vercel](https://github.com/vercel)\[bot] made their first contribution in [#​11245](vercel/turborepo#11245) **Full Changelog**: <vercel/turborepo@v2.6.3...v2.7.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4xNC4yIiwidXBkYXRlZEluVmVyIjoiNDIuMTQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://git.csmpro.ru/csmpro/mapban/pulls/77 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Packages can import themselves for testing purposes.
Testing Instructions
Added a self import to fixture.