fix: Command injection in turbo-ignore
#11154
Merged
+143
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a test that verifies malicious refs are handled safely by checking that no arbitrary commands are executed. This test would fail if the old vulnerable execSync code (or any vulnerable variant) were used. The test includes both behavior checks (verifying no file is created) and pattern checks (verifying execFileSync is called with array arguments).
Contributor
|
@pyrytakala is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
turbo-ignore
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
turbo-ignoreturbo-ignore
ch4og
pushed a commit
to csmplay/mapban
that referenced
this pull request
Dec 4, 2025
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [turbo](https://turborepo.com) ([source](https://github.com/vercel/turborepo)) | [`2.6.2` -> `2.6.3`](https://renovatebot.com/diffs/npm/turbo/2.6.2/2.6.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turborepo (turbo)</summary> ### [`v2.6.3`](https://github.com/vercel/turborepo/releases/tag/v2.6.3): Turborepo v2.6.3 [Compare Source](vercel/turborepo@v2.6.2...v2.6.3) <!-- Release notes generated using configuration in .github/release.yml at v2.6.3 --> #### What's Changed ##### turbo-ignore - fix: Command injection in `turbo-ignore` by [@​pyrytakala](https://github.com/pyrytakala) in [#​11154](vercel/turborepo#11154) ##### Examples - examples(security): Upgrade `Next.js` versions by [@​2qp](https://github.com/2qp) in [#​11195](vercel/turborepo#11195) ##### Changelog - fix: Prevent vt100 TUI crash during column wrap by [@​neel3o115](https://github.com/neel3o115) in [#​11170](vercel/turborepo#11170) - feat: Add GitHub Actions environment variable as default passthrough by [@​louis-bompart](https://github.com/louis-bompart) in [#​10740](vercel/turborepo#10740) - docs: Updating READMEs by [@​anthonyshew](https://github.com/anthonyshew) in [#​11190](vercel/turborepo#11190) - fix: Handle pidlock AlreadyOwned without failing init in LSP by [@​AryanBagade](https://github.com/AryanBagade) in [#​10831](vercel/turborepo#10831) - ci: Fix integration test logging style by [@​anthonyshew](https://github.com/anthonyshew) in [#​11194](vercel/turborepo#11194) - fix: Normalize config dir env vars to absolute by [@​Vansh0204](https://github.com/Vansh0204) in [#​11146](vercel/turborepo#11146) - fix(vercel-api): Add `VIEWER_FOR_PLUS` and `SECURITY` role variants by [@​amondnet](https://github.com/amondnet) in [#​11169](vercel/turborepo#11169) #### New Contributors - [@​neel3o115](https://github.com/neel3o115) made their first contribution in [#​11170](vercel/turborepo#11170) - [@​louis-bompart](https://github.com/louis-bompart) made their first contribution in [#​10740](vercel/turborepo#10740) - [@​AryanBagade](https://github.com/AryanBagade) made their first contribution in [#​10831](vercel/turborepo#10831) - [@​Vansh0204](https://github.com/Vansh0204) made their first contribution in [#​11146](vercel/turborepo#11146) - [@​amondnet](https://github.com/amondnet) made their first contribution in [#​11169](vercel/turborepo#11169) - [@​pyrytakala](https://github.com/pyrytakala) made their first contribution in [#​11154](vercel/turborepo#11154) **Full Changelog**: <vercel/turborepo@v2.6.2...v2.6.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4xNC4yIiwidXBkYXRlZEluVmVyIjoiNDIuMTQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://git.csmpro.ru/csmpro/mapban/pulls/66 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
1 task
anthonyshew
added a commit
that referenced
this pull request
Dec 11, 2025
### Description #11154 changed `turbo-ignore` from exec() to execFile() for security, but getTask() still wrapped task names in quotes ("build"). With execFile(), these quotes are passed literally, causing turbo to fail finding a task named "build" (with quotes). ### Testing Instructions Updated test and hand-tested it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a command injection vulnerability in
turbo-ignoreby replacingexecSyncwithexecFileSyncwhen validating git refs. The old implementation used shell command strings. The fix ensures that user-controlled input (like git refs from environment variables) is passed as literal arguments rather than being interpreted by a shell.Testing Instructions
Run the security test:
pnpm test security.test.tsinpackages/turbo-ignore