Skip to content

Conversation

@jacekkarczmarczyk
Copy link
Member

Motivation and Context

#13812 was not enough

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@KaelWD
Copy link
Member

KaelWD commented Jun 23, 2021

Why would you need to import this separately? It's already on the vuetify instance.

@jacekkarczmarczyk
Copy link
Member Author

So that I don't need to import vuetify instance, mainly for composition api
Anyway feel free to close if using $vuetify.goTo is obligatory

@zoton2
Copy link

zoton2 commented Jun 23, 2021

Another point to make is that the documentation example for using "use with router" also won't resolve types with the current setup either: https://vuetifyjs.com/en/features/scrolling/#use-with-router

Quick edit: Also of note is you can resolve it from various places, like the example uses vuetify/es5/services/goto while this PR uses vuetify/lib/services/goto, I'm not sure of the differences myself but I assume the types are identical? And are there any more cases of this?

@KaelWD
Copy link
Member

KaelWD commented Jun 23, 2021

OK I wasn't aware we were documenting it that way, if that's the case then this should probably go in.

/es5 is legacy, we do have some type definitions for it but it was mostly kept to ease the 2.0 upgrade slightly.

@KaelWD KaelWD changed the title fix(types); declare vuetify/lib/services/goto module fix(types): declare vuetify/lib/services/goto module Jun 23, 2021
@KaelWD KaelWD merged commit 4537798 into master Jun 23, 2021
@KaelWD KaelWD deleted the fix/more-goto-types branch June 23, 2021 14:09
@johnleider johnleider added E: goTo GoTo composable and removed goTo labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

E: goTo GoTo composable typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants