Bug #14890
closed
test/ruby/test_time_tz.rb - Skip on Windows (mswin|mingw)?
Description
Should the test file test/ruby/test_time_tz.rb be skipped on Windows?
ruby-loco has some additional reporting features, and until r63823, none of the asserts were actually running (see with_tz definition).
Since no asserts are run, including the tests in the 'tests' count is misleading.
I'd do a PR, but wasn't sure whether to use a top-level return or a conditional after the class end statement.
Greg
Updated by naruse (Yui NARUSE) almost 7 years ago
- Status changed from Open to Closed
- Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: REQUIRED, 2.4: REQUIRED, 2.5: REQUIRED
Fixed by r 63839
Updated by MSP-Greg (Greg L) almost 7 years ago
I'm sorry, maybe I should have been clearer. This isn't the same as r63839.
For platforms that don't support ENV['TZ'], the code in the test file doesn't yield to the blocks passed by all the tests, as you noticed with the recently added test that r63839 addressed.
So, all the tests are counted and shown as passing, but they don't run any asserts. That's why I suggested this solution. IOW, don't define the class for mswin, mingw, solaris, etc.
Thanks, Greg
Updated by usa (Usaku NAKAMURA) over 6 years ago
- Backport changed from 2.3: REQUIRED, 2.4: REQUIRED, 2.5: REQUIRED to 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED
Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago
- Backport changed from 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED to 2.3: DONTNEED, 2.4: DONTNEED, 2.5: DONE
ruby_2_5 r66780 merged revision(s) 63823,63839.