Project

General

Profile

Activity

From 11/23/2013 to 11/29/2013

11/29/2013

11:23 PM Feature #9179 (Closed): MatchData#values_at should support named capture
=begin
Using (({MatchData#[]})), we can access a named capture by its name.
/(?<a>...)/.match("foo")[:a] #=> "foo"
/(?<a>...)/.match("foo")["a"] #=> "foo"
But (({MatchData#values_at})) accepts only Integer and refuses Symbol...
vzvu3k6k (vzvu3k6k _)
11:11 PM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
eweb (Eamonn Webster) wrote:
> Ever asked someone 'Do you know the time?' and they answer 'Yes'. So you ask 'What time is it?' and mutter 'Jerk!' under your breath.
> ...
Between `#know_time?` and `#time_now!`, i would prefer the secon...
alexeymuranov (Alexey Muranov)
10:22 PM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
Humans don't have to ask if a number is not a zero :) rosenfeld (Rodrigo Rosenfeld Rosas)
10:00 PM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
Ever asked someone 'Do you know the time?' and they answer 'Yes'. So you ask 'What time is it?' and mutter 'Jerk!' under your breath.
Ruby is a friendly language, let's not turn it into a jerk.
eweb (Eamonn Webster)
09:25 PM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
Just for the record, I only said I can see how this behavior can be useful in cases you want to consider 0 (zero) as falsey. But I do actually prefer that boolean methods (those ending with a question mark) do always returned strict bool... rosenfeld (Rodrigo Rosenfeld Rosas)
03:07 AM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
There is no use-case for this request and it would cause many incompatibilities (e.g. in rake, thor, ruby itself, ...):
https://github.com/jimweirich/rake/blob/bfafc3a0/lib/rake/application.rb#L300
https://github.com/ruby/ruby/blob/8...
marcandre (Marc-Andre Lafortune)
10:08 PM Bug #9177: Can't exit curses program and retain screen contents
You can use Process.exit! in such a situation.
Try appending "Process.exit!(0)" at the end of your code.
phasis68 (Heesob Park)
09:36 PM Bug #9177 (Third Party's Issue): Can't exit curses program and retain screen contents
Hi!
Please try the attached program.
Expected result:
* After you hit some key, the program should quit and the "Hit any key" message should still be visible on screen
Current result:
* When the program exits, the screen conte...
walles (Johan Walles)
09:59 PM Bug #9178: Segfault when misusing Enumerable#chunk with #to_enum and #with_index
does also crash on
ruby 2.0.0p299 (2013-08-29) [x86_64-linux-gnu]
ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux]
Hanmac (Hans Mackowiak)
09:52 PM Bug #9178 (Closed): Segfault when misusing Enumerable#chunk with #to_enum and #with_index
[1].to_enum(:chunk).with_index {|c,i| i == 5}.to_a
does not crash on "ruby 2.0.0p0 (2013-02-24 revision 39474) [i686-linux]"
-- Control frame information -----------------------------------------------
c:0026 p:---- s:0089 e:00008...
Hanmac (Hans Mackowiak)
09:14 PM Bug #9176 (Closed): test_gc_reason failed.
=begin
test_gc_reason failed always at 'make test-all' In my environment.
1) Failure:
TestGc#test_gc_reason [.../test/ruby/test_gc.rb:84]:
<{:gc_by=>:newobj}> expected but was
<{:major_by=>:nofree, :gc_by=>:method, :immediate_...
tarui (Masaya Tarui)
07:49 PM Bug #8711 (Closed): 最近NoMemoryErrorが多い
ちょっと正確なrevisionは出ませんが、最近の笹田さんと樽家さんの変更で
問題が出なくなったんじゃないかと。
一応閉じておきます。
usa (Usaku NAKAMURA)
07:42 PM Bug #8711 (Feedback): 最近NoMemoryErrorが多い
こちらどうでしょう。時間経っていますが引き続き調査します? hsbt (Hiroshi SHIBATA)
07:44 PM Bug #8794 (Feedback): Ruby on Rails
Please try 1.9.3-p484 hsbt (Hiroshi SHIBATA)
07:43 PM Bug #8737 (Feedback): [BUG] Bus Error
hsbt (Hiroshi SHIBATA)
07:42 PM Bug #8803 (Closed): Another buffer overflow
hsbt (Hiroshi SHIBATA)
07:36 PM Bug #8674 (Feedback): [patch] unused-parameter warning in ruby/ruby.h
>Linda_pp
shyouhei さんと kosaki さんのコメントに関して何か意見ありましたらお願いします。
hsbt (Hiroshi SHIBATA)
07:18 PM Bug #8547 (Feedback): FileUtils.chmod("a+r", "foobar", verbose: true) crashes
hsbt (Hiroshi SHIBATA)
07:08 PM Bug #9013 (Feedback): Crash on start
hsbt (Hiroshi SHIBATA)
07:06 PM Bug #9125: Net::SMTP - invalid method raised when attempting to connect using STARTTLS
Could you review this? hsbt (Hiroshi SHIBATA)
06:47 PM Feature #9171: [patch] use fstrings for symbol table
ko1: Could you review this? hsbt (Hiroshi SHIBATA)
06:13 PM Revision ef510b4f (git): * lib/drb/ssl.rb: [DOC] Fix typo
s/currenly/currently/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43924 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
matsuda (Akira Matsuda)
03:44 PM Revision b72256f9 (git): * ext/tk/lib/tkextlib/tktable/tktable.rb: fix bug on arguments for Proc object.
* ext/tk/sample/scrollframe.rb: forgot a Module definition.
* ext/tk/extconf.rb: check unsupported version of tclConfig.sh/tkConfig.sh. It is because current Ruby/Tk doesn't support Tcl/Tk8.6.
* ext/tk/extconf.rb: change search step of...
nagai (Hidetoshi Nagai)
03:39 PM Bug #6986: Inconsistent result of BigDecimal#power
There is still NoMemoryError on Windows with trunk.
C:\Users\phasis>ruby -v -rbigdecimal -e "p BigDecimal('1e-10').power(1e8)"
ruby 2.1.0dev (2013-11-28 trunk 43886) [i386-mingw32]
-e:1:in `power': failed to allocate memory (NoMemor...
phasis68 (Heesob Park)
03:22 PM Bug #6986 (Closed): Inconsistent result of BigDecimal#power
I think it is fixed in bigdecimal version 1.2.3.
mrkn (Kenta Murata)
03:29 PM Revision 2fd4dec9 (git): fix typos
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43922 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
03:29 PM Revision 6552f8b8 (git): fix indent
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43921 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
03:21 PM Revision e65cb023 (git): * 2013-11-30
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43920 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:21 PM Revision 53ba345c (git): * ChangeLog: fix ticket number at r43913.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43919 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nagachika (Tomoyuki Chikanaga)
03:19 PM Bug #8401 (Closed): BigDecimal.new("2").power(1e20) is zero.
It is corrected in 1.2.3.
$ ruby -ve 'gem "bigdecimal", "1.2.3"; require "bigdecimal"; puts BigDecimal(2).power(1e20)'
ruby 1.9.3p484 (2013-11-22) [x86_64-darwin12.5.0]
Infinity
$ ruby -ve 'gem "bigdecimal", "1.2.3"; require "big...
mrkn (Kenta Murata)
02:43 PM Revision 214aacff (git): * lib/uri/generic.rb: [DOC] Fix typo
s/arguement/argument/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
matsuda (Akira Matsuda)
02:03 PM Revision 0c85ffd8 (git): * lib/webrick/httpauth/digestauth.rb: Fix typo in an error message.
* test/ruby/test_parse.rb: Fix typo in a test name.
s/allowd/allowed/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
matsuda (Akira Matsuda)
12:01 PM Revision 44cb6eae (git): * vm_dump.c (rb_vmdebug_debug_print_pre): Bugfix. Get PC directly.
PC is cached into local stack and cfp->pc is incorrent at next of
branch or jump.
* vm_exec.h (DEBUG_ENTER_INSN): catch up this change.
* vm_core.h: update signature of rb_vmdebug_debug_print_pre.
git-svn-id: ...
Masaya Tarui
11:45 AM Revision 511cc1db (git): * compile.c : Bugsfix for dump_disasm_list.
rb_inspect denies a hidden object. So, insert rapper that creates
the unhidden one.
adjust->label is null sometimes.
insn_data_line_no makes no sense at all.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tru...
Masaya Tarui
11:34 AM Bug #8326: Running Redmine unter Ruby 2.0.0 produces an "Illegal instruction(coredump)" under AIX 7.1
This turns out to be issue related to optimization, we were able to workaround this using ruby compiled with xlc flags "-O -qhot". Hope it helps someone. Thanks!! kaustubh (Kaustubh D)
09:08 AM Revision 14361a72 (git): * test/ruby/test_case.rb (test_method_missing): Test for r43913.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43914 b2dd03c8-39d4-4d8f-98ff-823fe69b080e sorah (Sorah Fukumori)
08:57 AM Revision 205399b0 (git): * vm_insnhelper.c (check_match): Fix SEGV with VM_CHECKMATCH_TYPE_CASE
and class of `pattern` has `method_missing`
[Bug #8882] [ruby-core:58606]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
sorah (Sorah Fukumori)
08:06 AM Revision 92b4a05e (git): vm_eval.c: rb_yield_block
* vm_eval.c (rb_yield_block): yield block with rb_block_call_func
arguments.
* range.c (range_each): use rb_yield_block.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43912 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
08:02 AM Revision 58553ca1 (git): ruby/ruby.h, enum.c, vm_eval.c: constify argv
* include/ruby/ruby.h (RB_BLOCK_CALL_FUNC_ARGLIST): constify argv.
* enum.c (rb_enum_values_pack): ditto.
* vm_eval.c (rb_block_call, rb_check_block_call): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43911 b2dd03c8-39d4-4d8...
nobu (Nobuyoshi Nakada)
07:59 AM Revision 7566c490 (git): ruby/ruby.h: RB_BLOCK_CALL_FUNC_ARGLIST
* include/ruby/ruby.h (RB_BLOCK_CALL_FUNC_ARGLIST): for declaration
argument list of rb_block_call_func.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
07:55 AM Revision f0e73fc9 (git): ruby/ruby.h: rb_block_call_func_t
* include/ruby/ruby.h (rb_block_call_func_t): strict check for
rb_block_call_func* if RB_BLOCK_CALL_FUNC_STRICT is set.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43909 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
07:45 AM Revision 32145ebf (git): array.c, enum.c, range.c: rb_block_call_func compatible
* array.c (take_i), range.c (first_i): make rb_block_call_func
compatible.
* enum.c (collect_all, DEFINE_ENUMFUNCS): add blockarg.
* enum.c ({min,max,minmax,chunk,slicebefore}_ii): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/...
nobu (Nobuyoshi Nakada)
07:04 AM Feature #8998: string keys for hash literals should use fstrings
Oops, @ko1 is right.
The issue at hand is that fstrings were allowed to be shared strings. With rb_gc_mark(), the shared string was more likely to get marked (due to the mark_stack addition). But there were still cases where the share...
tmm1 (Aman Karmani)
06:33 AM Feature #9174 (Open): value receiving block for Hash#has_key?
Seems useful to be able to check for presence (as opposed to falsyness) and receive the value
class Hash
def has_key?(key, &block)
val = fetch(key){return false}
block.(val) if block
true
end
end
if h.has_k...
rits (First Last)
05:00 AM Bug #9173: rb_sprintf %li format specifier does not work correctly with long values and can cause Ruby to crash
This is now expected behavior. %i starting in 2.0 means you need to provide a ruby object (VALUE) argument, not an integer. You need to switch from %li to %ld. jeremyevans0 (Jeremy Evans)
03:09 AM Bug #9173 (Rejected): rb_sprintf %li format specifier does not work correctly with long values and can cause Ruby to crash
There is additional handling of %i versus %d in BSD_vfprintf (>= 2.0). When l (long) is specified as the length, %li, the additional handling is triggered.
Note: %ld works fine, %li and %ld work in Ruby 1.9.3
Sample Code:
## spri...
bladenkerst (Brad Sumersford)
04:55 AM Bug #9124: TestSocket errors in test-all on Arch 64-bit
normalperson (Eric Wong) wrote:
> Linux patch to fix this:
> ...
Ah, I see. I'll check again when Arch pushes an update to 3.12.1-3-ARCH. Thank you for the info.
jonforums (Jon Forums)
02:26 AM Revision 9f450816 (git): ruby/ruby.h: add blockarg to rb_block_call_func
* include/ruby/ruby.h (rb_block_call_func): add blockarg. block
function can take block argument, e.g., proc {|&blockarg| ...}.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:57 AM Revision 93bfdb9d (git): * 2013-11-29
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43906 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:57 AM Revision 19c9a70a (git): * lib/racc/parser.rb: Fix typo
s/Extentions/Extensions/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43905 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
matsuda (Akira Matsuda)

11/28/2013

10:53 PM Bug #9172: siphash faulty on arm little endian with word align - missing code
I confirmed the issue on my BeagleBone Black.
$ ./miniruby -ve 'p ["discoverer".hash, "sub-setter".hash]'
ruby 2.1.0dev (2013-11-28 trunk 43540) [armv7l-linux-eabihf]
[-51053038, -51053038]
I think this is a bug of th...
mame (Yusuke Endoh)
09:26 PM Bug #9172 (Assigned): siphash faulty on arm little endian with word align - missing code
nobu what do you think?
what is "collision.rb"?
zzak (zzak _)
09:01 PM Bug #9172 (Closed): siphash faulty on arm little endian with word align - missing code
siphash.c check for "little endian+unaligned word access" and
"bigendian". But my arch : armv7-a cortex a9 is little endian word
aligned. This discard the loop that reduce the input below 8 bytes and a
case when the leftover is four b...
prahal (Alban Browaeys)
09:05 PM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
Now I finally understand the purpose of nonzero? :) In several languages, including Perl and JavaScript, 0 is a falsy value, but this is not the case for Ruby. So it's kind of a hack to make 0 be treated as a falsy value :) Indeed, now t... rosenfeld (Rodrigo Rosenfeld Rosas)
03:11 PM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
nonzero? returning the number is useful; I used this recently:
t '.items_count', count: items_count.nonzero? || t(.'no')
It returns the number or, if it's zero, the proper translation for no (generating a "no items" message).
I ...
fuadksd (Fuad Saud)
07:44 PM Feature #8998: string keys for hash literals should use fstrings
> The regression was indeed caused by r43718, and has been resolved with r43887.
No. Before r43718, it works accidentally.
ko1 (Koichi Sasada)
04:42 PM Feature #8998: string keys for hash literals should use fstrings
The regression was indeed caused by r43718, and has been resolved with r43887. tmm1 (Aman Karmani)
04:55 PM Feature #9171 (Closed): [patch] use fstrings for symbol table
Here is a simple patch to use fstrings for the table backing symbols.
Unfortunately it causes a segfault in test/rdoc/test_rdoc_parser_ruby.rb. Maybe someone wants to investigate.
~~~diff
diff --git a/parse.y b/parse.y
index 8207...
tmm1 (Aman Karmani)
03:31 PM Revision dd7ec71b (git): merge revision(s) 43888: [Backport #9169]
* common.mk (Doxyfile): tool/file2lastrev.rb needs running with
BASERUBY since r43617. [ruby-dev:47823] [Bug #9169]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@43904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nagachika (Tomoyuki Chikanaga)
02:36 PM Revision 2e9230c4 (git): * lib/gserver.rb: [DOC] Fix typo
s/FixNum/Fixnum/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43903 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
matsuda (Akira Matsuda)
12:44 PM Revision 7d4fa2f2 (git): * doc/dtrace_probes.rdoc: [DOC] Import dtrace probes doc from wiki
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43902 b2dd03c8-39d4-4d8f-98ff-823fe69b080e zzak (zzak _)
12:18 PM Revision 6bea00dc (git): * doc/contributing.rdoc: [DOC] Add heading above ChangeLog tips to
setup entry for commits, its not required. Actually easier if
contributors don't include a ChangeLog entry.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43901 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
zzak (zzak _)
12:17 PM Revision 8274df3e (git): * doc/contributing.rdoc: [DOC] Add coding style heading for patch
rules
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43900 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
zzak (zzak _)
12:15 PM Revision f1ea832f (git): * doc/contributing.rdoc: [DOC] Add notes about deciding what to patch
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e zzak (zzak _)
11:55 AM Bug #9170 (Closed): Math.sqrt returns different types when mathn is included; breaks various gems - this bug can be reproduced in Ruby 1.8 as well
Math.sqrt() usually returns a Float or throws an exception. Some gems rely on this behaviour (e.g. by calling nan? on the results of a calculation that includes a sqrt).
After requiring mathn, Math.sqrt() returns an Integer in some ca...
kranzky (Jason Hutchens)
11:10 AM Bug #9166 (Third Party's Issue): Installation halted by: Error running '__rvm_make -j 1', please read /usr/local/rvm/log/1385553502_ruby-2.0.0-p353/make.log There has been an error while running make.
Please report to rvm issue before ruby-core issue. hsbt (Hiroshi SHIBATA)
10:50 AM Revision 2fbe9eac (git): * benchmark/bm_hash_flatten.rb: added. r43896 is about 4 times faster
than 2.0.0p353.
* benchmark/bm_hash_keys.rb: added. r43896 is about 5 times faster
than 2.0.0p353.
* benchmark/bm_hash_values.rb: added. r43896 is about 5 times faster
than 2.0.0p353.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr...
Glass_saga (Masaki Matsushita)
10:29 AM Revision 85076c01 (git): * doc/contributing.rdoc: [DOC] Add notes about slideshow proposals
from wiki page: HowToRequestFeatures
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
zzak (zzak _)
08:46 AM Revision 74330541 (git): * ChangeLog: fix typo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43896 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Glass_saga (Masaki Matsushita)
08:45 AM Bug #9164 (Rejected): IO::foreach incorrect work for binary file on windows platform
kosaki (Motohiro KOSAKI)
08:39 AM Revision 79e63364 (git): * st.c: add st_values() and st_values_check().
* include/ruby/st.h: add prototypes for above.
* hash.c (rb_hash_values): use st_values_check() for performance
improvement if VALUE and st_data_t are compatible.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43895 b2dd03c8-39d4-4...
Glass_saga (Masaki Matsushita)
08:15 AM Revision 78cfcbc6 (git): * st.c (st_keys): fix not to use Qundef in st.c.
* include/ruby/st.h: define modified prototype.
* hash.c (rb_hash_keys): use modified st_keys().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43894 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Glass_saga (Masaki Matsushita)
07:43 AM Bug #9114: InstructionSequence.compile w/tailcall_optimization: true, trace_instruction: false not working as expected
Eric,
My apologizes as I probably wasted your time with that. The problem with the code you posted is that for TCO you still have to specify trace_instruction: false. If you execute the following, it is fine in Ruby 2.0.0p247 at least, ...
garysweaver (Gary Weaver)
07:40 AM Revision d7009f76 (git): * gc.c: Expose details about last garbage collection via GC.stat.
* gc.c (gc_stat): Add :last_collection_flags for reason/trigger/type of
last GC run.
* gc.c (gc_prof_sweep_timer_stop): Record HAVE_FINALIZE GPR even
without GC_PROFILE_MORE_DETAIL.
* gc.c (gc_profile_flags): Add GC::Profiler.decode_...
tmm1 (Aman Karmani)
07:34 AM Revision 6de07f1f (git): version.c: EXIT_SUCCESS
* version.c (ruby_show_copyright): use EXIT_SUCCESS instead of magic
number 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43892 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
07:34 AM Revision c26bc976 (git): optparse.rb: regexp at lhs
* lib/optparse.rb (OptionParser::Switch#compsys): regexp literal
should be lhs of =~.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43891 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
07:15 AM Revision 21f81885 (git): win32.c: rb_w32_dup2
* win32/win32.c (rb_w32_dup2): extract from rb_cloexec_dup2() and
redirect_dup2().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43890 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
05:44 AM Revision b3ffb68b (git): * lib/drb/ssl.rb: [Doc] Fix typo
s/Confg/Config/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
matsuda (Akira Matsuda)
04:56 AM Revision 72807178 (git): common.mk: use BASERUBY
* common.mk (Doxyfile): tool/file2lastrev.rb needs running with
BASERUBY since r43617. [ruby-dev:47823] [Bug #9169]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43888 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:53 AM Bug #9124: TestSocket errors in test-all on Arch 64-bit
Linux patch to fix this:
http://mid.gmane.org/[email protected]
I think Ruby can remain unchanged.
normalperson (Eric Wong)
02:09 AM Bug #9157: rb_readlink() calls rb_str_modify_expand() too early
does it deserves a CVE? vpereira (Victor Pereira)
12:22 AM Revision d7df3e28 (git): * string.c (rb_fstring): fstrings should be ELTS_SHARED.
If we resurrect dying objects (non-marked, but not swept yet),
pointing shared string can be collected.
To avoid such issue, fstrings (recorded to fstring_table)
should not be ELTS_SHARED (should not have a shared string).
git-s...
ko1 (Koichi Sasada)

11/27/2013

09:49 PM Bug #9167 (Closed): Segmentation fault in cleanup
I don't know whether it is the interpreters fault or mine.
This is what I do:
- Subclassing StandardError in C
- Encapsulating some data into it using Data_Make_Struct
- Raising this exception
- Not catching it by "rescue"...
BertramScharpf (Bertram Scharpf)
09:48 PM Bug #9101 (Assigned): Reference to unset variable
luislavena (Luis Lavena)
07:20 PM Bug #9101: Reference to unset variable
Reminder: Not one single reaction in more than two weeks. BertramScharpf (Bertram Scharpf)
09:16 PM Bug #9166 (Third Party's Issue): Installation halted by: Error running '__rvm_make -j 1', please read /usr/local/rvm/log/1385553502_ruby-2.0.0-p353/make.log There has been an error while running make.
Installation halted by:
Error running '__rvm_make -j 1', please read /usr/local/rvm/log/1385553502_ruby-2.0.0-p353/make.log There has been an error while running make.
[2013-11-27 19:58:45] __rvm_make
__rvm_make ()
{
\m...
hazelyuan (Hazel Yuan)
08:23 PM Bug #9124: TestSocket errors in test-all on Arch 64-bit
This looks to be a problem of Linux 3.12 and later

commit 1661bf364ae9c506bc8795fef70d1532931be1e8
Author: Dan Carpenter <[email protected]>
Date: Thu Oct 3 00:27:20 2013 +0300

net: heap overflow in __audi...
normalperson (Eric Wong)
07:53 PM Feature #8998: string keys for hash literals should use fstrings
"tmm1 (Aman Gupta)" <[email protected]> wrote:
> Seeing some occasional segfaults in CI after this change. Not quite
> sure what's up yet.
>
> http://c5632.rubyci.org/~chkbuild/ruby-trunk/log/20131127T070302Z.log.html.gz
>
> #3...
normalperson (Eric Wong)
05:12 PM Feature #8998: string keys for hash literals should use fstrings
Seeing some occasional segfaults in CI after this change. Not quite sure what's up yet.
http://c5632.rubyci.org/~chkbuild/ruby-trunk/log/20131127T070302Z.log.html.gz
#3 0x0063fb97 in rb_bug (fmt=0x67363d "Segmentation fault") at e...
tmm1 (Aman Karmani)
04:23 PM Feature #8998: string keys for hash literals should use fstrings
"tmm1 (Aman Gupta)" <[email protected]> wrote:
> Issue #8998 has been updated by tmm1 (Aman Gupta).

Cool, I didn't check object lifetimes.
Any measurable impact on speed?

> >+ if (!OBJ_FROZEN(str))
> >+ *key = rb_fstring...
normalperson (Eric Wong)
02:29 PM Feature #8998 (Closed): string keys for hash literals should use fstrings
This issue was solved with changeset r43870.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* hash.c (hash_aset_str): Use rb_fstring() to de-duplicate hash s...
tmm1 (Aman Karmani)
01:01 PM Feature #8998: string keys for hash literals should use fstrings
>+ if (!OBJ_FROZEN(str))
> ...
Do you know why the OBJ_FROZEN check is required here?
I tried to investigate and it appears this function is sometimes invoked with symbols.
tmm1 (Aman Karmani)
01:00 PM Feature #8998: string keys for hash literals should use fstrings
I didn't realize MRI already froze string keys in hashes.
Your patch reduces long-lived strings in our rails app by ~11%:
$ ruby -rconfig/environment -e' GC.start; p ObjectSpace.count_objects[:T_STRING] '
173956

$ ruby ...
tmm1 (Aman Karmani)
07:29 PM Bug #9164: IO::foreach incorrect work for binary file on windows platform
phasis68 (Heesob Park) wrote:
> On Windows, "\x1A"(Control+Z) means end of file.
> ...
Thank you.
Sorry, my problem, it isn't a bug.
windwiny (wind winy)
04:05 PM Bug #9164: IO::foreach incorrect work for binary file on windows platform
On Windows, "\x1A"(Control+Z) means end of file.
You must use binary read mode.
p File.foreach('1.txt',mode:'rb').to_a => ["123\n", "\x1A\xE8\xBA\b\n", "789\n"]
phasis68 (Heesob Park)
03:25 PM Bug #9164 (Rejected): IO::foreach incorrect work for binary file on windows platform
d2 = "123\n".b + "\x1a\xe8\xba\b".b + "\n789\n".b

File.binwrite('1.txt', d2)

p File.binread('1.txt').each_line.to_a # => ["123\n", "\x1A\xE8\xBA\b\n", "789\n"]



p File.foreach('1.txt').to_a...
windwiny (wind winy)
06:30 PM Bug #9150: Segfault in case statement execution, possibly related to refinements
I've not investigated this problem yet, but Matz said implicit method calls should not honor refinements, so r42869 might be an undesirable change. shugo (Shugo Maeda)
05:21 PM Bug #9150 (Assigned): Segfault in case statement execution, possibly related to refinements
@nagachika What do you think? zzak (zzak _)
06:12 PM Bug #9165 (Closed): IRBのコード中にtypo
Fixed via r43880 matsuda (Akira Matsuda)
05:53 PM Bug #9165: IRBのコード中にtypo
けいじゅ@いしつかです.

matsuda (Akira Matsuda) <[email protected]> wrote:

> Issue #9165 has been reported by matsuda (Akira Matsuda).
>
> IRBのコード内にtypoを見つけました。
> 明らかにケアレスミスっぽいので添付のパッチをコミットしちゃって良いでしょうか?

あらま.
よろしくお願いします(__;

...
keiju (Keiju Ishitsuka)
05:46 PM Bug #9165 (Closed): IRBのコード中にtypo
IRBのコード内にtypoを見つけました。
明らかにケアレスミスっぽいので添付のパッチをコミットしちゃって良いでしょうか?
matsuda (Akira Matsuda)
04:36 PM Revision 8c91dfb9 (git): * st.c (st_keys): fix to use st_index_t for size of hash.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Glass_saga (Masaki Matsushita)
04:07 PM Revision b426e1b1 (git): * st.c (st_keys): define st_keys(). it writes each key to buffer.
* hash.c (rb_hash_keys): use st_keys() for performance improvement
if st_data_t and VALUE are compatible.
* st.h: define macro ST_DATA_COMPATIBLE_P() to predicate whether
st_data_t and passed type are compatible.
* configure.in: ch...
Glass_saga (Masaki Matsushita)
03:13 PM Revision 88468275 (git): * 2013-11-28
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43884 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:13 PM Revision 3ff90426 (git): * ruby_atomic.h: remove duplicate definisions between ATOMIC_XXX
and ATOMIC_SIZE_XXX.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Glass_saga (Masaki Matsushita)
02:57 PM Revision b9835112 (git): * ruby_atomic.h: define ATOMIC_SIZE_CAS() with
__atomic_compare_exchange_n() and refactoring.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Glass_saga (Masaki Matsushita)
02:50 PM Bug #9163: Rinda::RingServer can't announce locally
Committed per http://twitter.com/m_seki/status/405573265139044352 drbrain (Eric Hodel)
02:50 PM Bug #9163 (Closed): Rinda::RingServer can't announce locally
This issue was solved with changeset r43872.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/rinda/ring.rb: Announce RingServer for the same process.
...
drbrain (Eric Hodel)
02:37 PM Bug #9163 (Closed): Rinda::RingServer can't announce locally
Rinda::RingServer#do_reply takes tuples of the form [:lookup_ring, DRbObject]. For remote processes looking for a ring server this works fine as the callback proc in the second slot of the tuple will be a DRbObject.
When a process is...
drbrain (Eric Hodel)
02:46 PM Bug #9063: irb crashes when #backtrace of raised Exception is nil
ping? sorah (Sorah Fukumori)
12:56 PM Revision da666770 (git): * lib/irb/notifier.rb: [Doc] Fix typo
* ext/json/lib/json/common.rb: Ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43881 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
matsuda (Akira Matsuda)
12:41 PM Bug #9106: 'gem install' doesn't copy .so files of ext libs
Hrm, I will check it. drbrain (Eric Hodel)
12:19 PM Bug #9149 (Feedback): rb-appscript crash
It's #9142.
I couldn't reproduce it.
Maybe related to rvm?
nobu (Nobuyoshi Nakada)
12:13 PM Bug #8874 (Feedback): libruby.so.2.0 variable.c segmentation faults in production with rails (ruby-2.0.0-p247)
Please feedback to run your code with ruby-trunk. hsbt (Hiroshi SHIBATA)
12:09 PM Bug #9133: logger rotates log files more than expected
> No needs to compare with @filename?
645 File.open(@filename, File::WRONLY | File::APPEND) do |lock|
646 lock.flock(File::LOCK_EX) # inter-process locking. will be unlocked at closing file
647 ...
no6v (Nobuhiro IMAI)
11:59 AM Feature #9162 (Rejected): Read/Write operations in Tracepoint
> Is there a way to access when variables are read/assigned in Tracepoint?
No. I reject this approach because of performance (without enabling these trace).
But there is no proof of my assumption. Please try and measure.
> ...
I...
ko1 (Koichi Sasada)
11:15 AM Feature #9162 (Assigned): Read/Write operations in Tracepoint
nobu (Nobuyoshi Nakada)
05:22 AM Feature #9162 (Rejected): Read/Write operations in Tracepoint
Is there a way to access when variables are read/assigned in Tracepoint? Specifically, I'm interested in creating a tool which does dynamic, threading analysis of Ruby code to find atomicity violations, dead-locks and race conditions. ... davidann (David Weiser)
10:43 AM Bug #9142 (Feedback): Ruby 2.0.0 crash in Rake/mysql2
mrkn (Kenta Murata)
10:32 AM Bug #9135 (Rejected): ruby 2.0.0p247 [BUG] Bus Error
You can use byebug to debug your code with this command line: `bundle exec rspec -rbyebug`.
FYI, `--debug` option of rspec has been removed in 3.0.0.beta1 of rspec-core.
Please see rspec-core's Changelog.md: https://github.com/rspec/...
mrkn (Kenta Murata)
09:05 AM Revision 0d72c665 (git): * lib/irb/notifier.rb: Fix typo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43880 b2dd03c8-39d4-4d8f-98ff-823fe69b080e matsuda (Akira Matsuda)
08:56 AM Revision 9e733b90 (git): * gc.c (gc_mark_stacked_objects): check only when check_mode > 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ko1 (Koichi Sasada)
08:53 AM Bug #9159: [patch] use rb_fstring for internal strings
Can somebody following this thread check out my patch for
https://bugs.ruby-lang.org/issues/8998

Theoretically it should be better than nothing (but not ideal), but I
don't think any of my code uses string hash keys enough to m...
normalperson (Eric Wong)
08:30 AM Bug #9159 (Closed): [patch] use rb_fstring for internal strings
This issue was solved with changeset r43866.
Aman, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* compile.c: Use rb_fstring() to de-duplicate string literals in ...
tmm1 (Aman Karmani)
08:26 AM Bug #9159: [patch] use rb_fstring for internal strings
Seeing similar results for Discourse:
https://gist.github.com/SamSaffron/7668043
sam.saffron (Sam Saffron)
07:33 AM Bug #7239: Can't read from subprocess when run with rubyw on windows
Please backport this to Ruby 1.9.3. ryanatball (Ryan Melton)
07:07 AM Revision f8994603 (git): * test/ruby/test_gc.rb (class TestGc): Fix warning in
test_expand_heap.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tmm1 (Aman Karmani)
06:57 AM Revision 0094b7bb (git): * gc.c (Init_GC): Add new GC::INTERNAL_CONSTANTS for information about
GC heap/page/slot sizing.
* test/ruby/test_gc.rb (class TestGc): test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tmm1 (Aman Karmani)
06:24 AM Revision 23178d10 (git): * gc.c (gc_page_sweep): Fix compile warning from last commit.
* hash.c (hash_aset_str): Re-use existing variable to avoid
unnecessary pointer dereferencing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tmm1 (Aman Karmani)
06:13 AM Revision da65a3d9 (git): * gc.c (gc_page_sweep): disable debug print.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ko1 (Koichi Sasada)
06:09 AM Revision 5993c141 (git): * gc.c (gc_stat): add new information heap_eden_page_length and
heap_tomb_page_length.
* test/ruby/test_gc.rb: fix to use GC.stat[:heap_eden_page_length]
instead of GC.stat[:heap_length].
This test expects `heap_eden_page_length' (used pages size).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/t...
ko1 (Koichi Sasada)
06:03 AM Bug #9157: rb_readlink() calls rb_str_modify_expand() too early
nobu (Nobuyoshi Nakada) wrote:
> This issue was solved with changeset r43853.
Ah, I didn't realize that rb_str_modify_expand() takes a difference as its argument, not the total buffer length. This works because the function doubles t...
nowacki (Maciek Nowacki)
06:03 AM Revision 53f3ddfe (git): * test/ruby/test_eval.rb (class TestEval): Use assert_same instead of
assert_equal.
* test/ruby/test_hash.rb (class TestHash): ditto.
* test/ruby/test_iseq.rb (class TestISeq): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tmm1 (Aman Karmani)
05:57 AM Feature #8257: Exception#cause to carry originating exception along with new one
I think we still need to add Exception.new(:cause => ex) to allow constructing an exception with a *specific* cause. The $! capturing is great but often there may be more than one exception in play.
This needs to happen before 2.1 final.
headius (Charles Nutter)
05:50 AM Revision 9c8f03fa (git): * lib/rinda/ring.rb: Announce RingServer for the same process.
[ruby-trunk - Bug #9163]
* test/rinda/test_rinda.rb: Tests for the above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43872 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
drbrain (Eric Hodel)
05:39 AM Revision fdcc476e (git): * test/ruby/test_eval.rb (class TestEval): Add test for shared eval
filenames via rb_fstring().
* test/ruby/test_iseq.rb (class TestISeq): Add test for shared
iseq labels via rb_fstring(). [Bug #9159]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43871 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tmm1 (Aman Karmani)
05:28 AM Revision 0c3b3e92 (git): * hash.c (hash_aset_str): Use rb_fstring() to de-duplicate hash string
keys. Patch by Eric Wong. [Bug #8998] [ruby-core:57727]
* test/ruby/test_hash.rb (class TestHash): test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tmm1 (Aman Karmani)
03:28 AM Revision 26e96918 (git): * test/ruby/test_string.rb: Add test for error when appending a
Symbol into a String.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43869 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
headius (Charles Nutter)
01:42 AM Revision 5080a756 (git): * gc.c: Rename rb_heap_t members:
used -> page_length
limit -> total_slots
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tmm1 (Aman Karmani)
01:20 AM Bug #9160 (Closed): configureに--with-rubylibprefixを指定するとrbconfigのprefixが空文字になる
=begin
== 現象
configureに--with-rubylibprefixを指定したとき、
RbConfig::CONFIG['prefix']および関連するbindirなどのprefixが空文字になってしまいます。
% ruby -rrbconfig -e 'p RbConfig::CONFIG["prefix"]'
""
% ruby -rrbconfig -e 'p RbConfig::CONFIG["bin...
kimuraw (Wataru Kimura)
12:32 AM Revision c38b4a9b (git): test_bug_reporter.rb: remove core
* test/-ext-/bug_reporter/test_bug_reporter.rb (test_bug_reporter_add):
remove expected core file to get rid of false error in chkbuild.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43867 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)

11/26/2013

11:30 PM Revision cbb56e30 (git): * compile.c: Use rb_fstring() to de-duplicate string literals in code. [ruby-core:58599] [Bug #9159] [ruby-core:54405]
* iseq.c (prepare_iseq_build): De-duplicate iseq labels and source locations.
* re.c (rb_reg_initialize): Use rb_fstring() for regex string.
* string.c (rb_fstring): Handle non-string and already-fstr arguments.
* vm_eval.c (eval_string_...
tmm1 (Aman Karmani)
10:43 PM Bug #9151 (Closed): Segfault in Ruby head
This issue was solved with changeset r43859.
Sam, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
hash.c: cut off if recursion
* hash.c (rb_hash): cut off if recur...
nobu (Nobuyoshi Nakada)
07:26 PM Bug #9151: Segfault in Ruby head
@nobu running in ubuntu latest x64 sam.saffron (Sam Saffron)
06:58 PM Bug #9151: Segfault in Ruby head
its a similar error to #9003
p a.hash # raises Stack Error
p b.hash # Segmentation fault: 11
happens for:
ruby 2.1.0dev (2013-11-26 trunk 43854) [x86_64-darwin12.0]
does not happen for:
ruby 2.1.0dev (2013-09-22 trunk 43011...
Hanmac (Hans Mackowiak)
02:06 PM Bug #9151: Segfault in Ruby head
It's a simple machine stack overflow.
What's your platform?
nobu (Nobuyoshi Nakada)
10:23 PM Bug #9133: logger rotates log files more than expected
(13/11/26 19:23), no6v (Nobuhiro IMAI) wrote:
> File.open(@filename, File::WRONLY | File::APPEND) do |lock|
> lock.flock(File::LOCK_EX) # inter-process locking. will be unlocked at closing file
> - ...
nobu (Nobuyoshi Nakada)
07:23 PM Bug #9133: logger rotates log files more than expected
Thanks for your suggestion. I feel this simple condition seems looking good.
I updated a patch using `File.identical?`.
diff --git a/lib/logger.rb b/lib/logger.rb
index c70b091..f1c6cbe 100644
--- a/lib/logger.rb
+++ b/lib/logger....
no6v (Nobuhiro IMAI)
12:05 PM Bug #9133: logger rotates log files more than expected
Probably, you can use `File.identical?` instead of comparison of ino. nobu (Nobuyoshi Nakada)
10:14 PM Revision 599c3a92 (git): * ext/psych/lib/psych.rb: psych version 2.0.2
* ext/psych/psych.gemspec: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlovemaking (Aaron Patterson)
09:41 PM Revision 079ff69c (git): * ext/psych/lib/psych/scalar_scanner.rb: fix support for negative
years.
* ext/psych/lib/psych/visitors/yaml_tree.rb: ditto
* test/psych/test_date_time.rb: test for change.
Fixes: https://github.com/tenderlove/psych/issues/168
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43864 b2dd03c8-39d4-4d8...
tenderlovemaking (Aaron Patterson)
08:04 PM Feature #9120 (Closed): [PATCH] Tests for a_call + a_return
This issue was solved with changeset r43858.
Brandur, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* test/ruby/test_settracefunc.rb: add tests for a_call/a_retur...
ko1 (Koichi Sasada)
07:48 PM Revision 725d6f49 (git): * ext/psych/lib/psych/scalar_scanner.rb: fix regexp for matching TIME
strings.
* test/psych/test_date_time.rb: test for change.
Fixes: https://github.com/tenderlove/psych/issues/171
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlovemaking (Aaron Patterson)
06:56 PM Bug #9159: [patch] use rb_fstring for internal strings
> if (nd_type(node) == NODE_STR) {
> ...
Some internal strings are no longer hidden with this patch, since the underlying T_STRING object can be shared via the fstr table.
Since the object is already marked immutable (via the frozen ...
tmm1 (Aman Karmani)
06:54 PM Bug #9159: [patch] use rb_fstring for internal strings
One example of strings de-duplicated by this patch are iseq labels. Before:
irb(main):001:0> mm = "method_missing"
irb(main):002:0> GC.start; ObjectSpace.each_object(String).select{ |o| o == mm }.size
=> 77
After:
irb(...
tmm1 (Aman Karmani)
06:30 PM Bug #9159 (Closed): [patch] use rb_fstring for internal strings
I added rb_fstring wrappers around internal strings generated by iseqs, regexps and eval:
https://github.com/tmm1/ruby/commit/9587fae171835ccf013661ba837f097754f170ef
In our rails app, this reduces the number of long-lived string...
tmm1 (Aman Karmani)
05:27 PM Revision 4760b982 (git): string.c: fix memsize of frozen shared string
* string.c (str_new4): copy the original capacity so that memsize of
frozen shared string returns correct size.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
05:20 PM Revision faaec02a (git): * 2013-11-27
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:20 PM Revision 94f01c55 (git): should not ignore the rest of recursive constructs
* array.c (rb_ary_hash): should not ignore the rest of recursive
constructs.
* hash.c (rb_hash_hash): ditto.
* range.c (range_hash): ditto.
* struct.c (rb_struct_hash): ditto.
* test/-ext-/test_recursion.rb (TestRecursion): separate fr...
nobu (Nobuyoshi Nakada)
04:30 PM Bug #9157 (Closed): rb_readlink() calls rb_str_modify_expand() too early
This issue was solved with changeset r43853.
Maciek, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
file.c: fix buffer overflow
* file.c (rb_readlink): fix buffer...
nobu (Nobuyoshi Nakada)
03:12 PM Bug #9157 (Closed): rb_readlink() calls rb_str_modify_expand() too early
If rb_readlink() (file.c) is called on a long symlink, Ruby tends to crash. This is present in -trunk. The problem is that the rb_str_modify_expand() statement is incorrectly placed before the statement 'size*=2'. Here is a patch:
---...
nowacki (Maciek Nowacki)
03:57 PM Bug #8623: Make stable Gem::Specification.files in default .gemspecs
nagachika (Tomoyuki Chikanaga) wrote:
> I've overlooked this ticket.
> ...
That would be sweet if you can backport. One less patch I need to maintain for Fedora.
vo.x (Vit Ondruch)
11:10 AM Bug #8623: Make stable Gem::Specification.files in default .gemspecs
I've overlooked this ticket.
Hello vit, r43587 should be backported to ruby_2_0_0, doesn't it?
nagachika (Tomoyuki Chikanaga)
03:53 PM Feature #7274: UnboundMethods should be bindable to any object that is_a?(owner of the UnboundMethod)
unsubscribe Anonymous
03:41 PM Feature #7274: UnboundMethods should be bindable to any object that is_a?(owner of the UnboundMethod)
matz (Yukihiro Matsumoto) wrote:
> OK, I misunderstood something.
> ...
I discovered the current behavior while playing around, learning about method binding in ruby, not via a bug in my code. I noticed in irb (to_s) that an unbound m...
rits (First Last)
02:47 PM Feature #7274: UnboundMethods should be bindable to any object that is_a?(owner of the UnboundMethod)
OK, I misunderstood something.
In case foo is implemented in Base as in the original example, I admit that it will not cause any serious problem.
But I still have small concern.
If you are sure foo is implemented in Base, you can ...
matz (Yukihiro Matsumoto)
02:04 PM Feature #7274: UnboundMethods should be bindable to any object that is_a?(owner of the UnboundMethod)
to continue, the above:
we are binding a method from Base to an instance of Base, and it's failing. Why? How can that possibly be unsafe? What difference does it make that the method was requested from a subclass of Base? It certai...
rits (First Last)
01:26 PM Feature #7274: UnboundMethods should be bindable to any object that is_a?(owner of the UnboundMethod)
matz (Yukihiro Matsumoto) wrote:
> @rits You haven't read my message above, have you?
> ...
Neither I nor marcandre understood what you were alluding to and asked for a clarification, but you just repeated without clarifying.
You appear...
rits (First Last)
12:54 PM Feature #7274: UnboundMethods should be bindable to any object that is_a?(owner of the UnboundMethod)
@rits You haven't read my message above, have you?
>It is due to implementation limitation of CRuby.
> ...
Matz.
matz (Yukihiro Matsumoto)
12:34 PM Feature #7274: UnboundMethods should be bindable to any object that is_a?(owner of the UnboundMethod)
matz (Yukihiro Matsumoto) wrote:
> @rits Yes, basically. Method transplanting from modules is already allowed though.
> ...
ok, but you never really explained what purpose this restriction serves, it seems pretty arbitrary and illogical
rits (First Last)
12:25 PM Feature #7274: UnboundMethods should be bindable to any object that is_a?(owner of the UnboundMethod)
@rits Yes, basically. Method transplanting from modules is already allowed though.
Matz.
matz (Yukihiro Matsumoto)
03:23 PM Bug #9158 (Closed): bug in rb_readlink() in file.c (fixed)
Hello,

Here is a cute bug that has existed for a little while in file.c . Ruby will tend to crash when File.readlink() is called on a symlink with a long target. Fix:

--- - 2013-11-25 22:10:59.694183795 -0700
+++ file.c 2013...
nowacki (Maciek Nowacki)
03:07 PM Bug #9106 (Assigned): 'gem install' doesn't copy .so files of ext libs
nagachika (Tomoyuki Chikanaga)
03:05 PM Bug #9106: 'gem install' doesn't copy .so files of ext libs
This problem is reproduced on ruby 2.1.0-preview2 on Linux/OSX.
'msgpack' gem cannot be loaded (LoadError) and 'ext/msgpack/msgpack.so' (or .bundle) is not copied to 'lib/msgpack/msgpack.so'.
About other library (ex: cool.io), binary f...
tagomoris (Satoshi Tagomori)
02:25 PM Bug #9156 (Feedback): Not able to get tmp dir to work with Ruby 2.0.0
It's by a security reason.
What's your platform?
nobu (Nobuyoshi Nakada)
10:01 AM Bug #9156 (Closed): Not able to get tmp dir to work with Ruby 2.0.0
I just migrated to Ruby 2.0.0 from 1.9.2 and I'm getting errors when trying to handle files because I can't get tmp directories to work.
If you check this file and look at line 29 you'll see that a check on world_writable? has been ad...
saipas (B L)
02:18 PM Bug #9149: rb-appscript crash
I think I've seen very similar report in these days, but I can't find it now...
7 libruby.2.0.0.dylib 0x00000001027af9ca st_init_strcasetable + 16
8 libruby.2.0.0.dylib 0x00000001026eb9a5 rb_enc_init + 29
9...
nobu (Nobuyoshi Nakada)
01:43 PM Revision d503381c (git): hash.c: cut off if recursion
* hash.c (rb_hash): cut off if recursion detected to get rid of stack
overflow. [ruby-core:58567] [Bug #9151]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43859 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
11:40 AM Bug #9119: TestTime#test_marshal_broken_offset broken under MinGW
I noticed the attached patch has problems with mingw.org 32bit toolchain.
The updated patch is only affects for MINGW64 toolchain.
Refer to https://groups.google.com/forum/#!topic/rubyinstaller/zNNccqwWMsA for more information.
phasis68 (Heesob Park)
11:03 AM Revision a4b0c3c2 (git): * test/ruby/test_settracefunc.rb: add tests for a_call/a_return
by Brandur <[email protected]> [Feature #9120]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43858 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
10:30 AM Revision be26a374 (git): * common.mk: add useful config "set breakpoint pending on"
for run.gdb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43857 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
10:26 AM Revision 8ca8d7af (git): * ext/objspace/object_tracing.c (newobj_i): skip class_path if class
is frozen.
rb_class_path() can modify frozen classes (and causes errors).
This patch is temporary. We need no-modification/no-allocation
class path function.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43856 b2dd03c8-39d4-...
ko1 (Koichi Sasada)
09:42 AM Revision bd26be2b (git): * vm_trace.c: skip "exception check" and "reentrant check (only normal
events) for internal events.
Reentrant check for internal events are remaining.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43855 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
08:41 AM Revision 5b40cb6a (git): * vm_trace.c: prohibit to specify normal events and internal events
simultaneously.
I will introduce special care for internal events later.
* ext/-test-/tracepoint/tracepoint.c: test this behavior.
* test/-ext-/tracepoint/test_tracepoint.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@...
ko1 (Koichi Sasada)
07:45 AM Bug #9155: DelegateClass - ArgumentError: not delegated
@hsbt yep that's where I found the issue - I thought I'd make it easier to replicate with the above code :) rhs (Russell Smith)
07:34 AM Bug #9155: DelegateClass - ArgumentError: not delegated
It happened will_paginate too. follow code.
https://github.com/mislav/will_paginate/blob/master/lib/will_paginate/page_number.rb
hsbt (Hiroshi SHIBATA)
05:33 AM Bug #9155 (Closed): DelegateClass - ArgumentError: not delegated
Running the attached code gives ArgumentError: not delegated. It's unexpected as it worked on preview 1 and in 2.0.0. Error pasted below. https://gist.github.com/ukd1/9293c419a080d034f4bb - has sample code plus runs on 2.0.0p247 + 2.1.0-... rhs (Russell Smith)
07:30 AM Revision 079009fb (git): file.c: fix buffer overflow
* file.c (rb_readlink): fix buffer overflow on a long symlink. since
rb_str_modify_expand() expands from its length but not its capacity,
need to set the length properly for each expansion.
[ruby-core:58592] [Bug #9157]
git-svn-id...
nobu (Nobuyoshi Nakada)
05:27 AM Revision adcd0174 (git): * ext/objspace/objspace_dump.c (dump_append_string_value): Escape
control characters for strict json parsers.
* ext/objspace/objspace_dump.c (objspace_dump): Document File/IO
output option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43852 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tmm1 (Aman Karmani)
02:45 AM Revision 0791c940 (git): * ruby_atomic.h: use __atomic builtin functions supported by GCC.
__sync family are legacy functions now and it is recommended
that new code use the __atomic functions.
http://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html
* configure.in: check existence of __atomic functions.
git-svn-...
Glass_saga (Masaki Matsushita)
02:23 AM Revision 6295a023 (git): * properties: ext/bigdecimal/bigdecimal.gemspec
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43850 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:20 AM Revision d473aff6 (git): * properties: ext/bigdecimal/bigdecimal.gemspec
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:57 AM Revision 78acdaca (git): bigdecimal.gemspec: date
* ext/bigdecimal/bigdecimal.gemspec: revert Gem::Specification#date
for snapshot/release tarballs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43848 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:29 AM Bug #9154 (Closed): Support for OpenSSL with MD5 disabled for certificate verification
=begin
In Fedora Rawhide, there was disable support for verification of certificate, CRL, and OCSP signatures using MD5 in OpenSSL [1, 2], therefore I observe following test errors:
7) Error:
test_sign_and_verify(OpenSSL::TestX5...
vo.x (Vit Ondruch)

11/25/2013

11:17 PM Bug #9153 (Closed): IO#flush causes unnecessary fsync on Windows
On Windows calling IO#flush is effectively identical to calling IO#fsync, i.e. contents of the file are committed to disk platters instead of just being flushed. I traced it back to bug #776 where the original "bug" was worked around by ... snaury (Alexey Borzenkov)
10:23 PM Misc #9148 (Closed): Fix broken url in lib/xmlrpc.rb documentation
This issue was solved with changeset r43844.
Giorgos, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/xmlrpc.rb: [DOC] Fix link to xmlrpc4r site [Bug #9148]
...
zzak (zzak _)
10:54 AM Misc #9148 (Assigned): Fix broken url in lib/xmlrpc.rb documentation
Thank you for the patch, I will commit this soon! zzak (zzak _)
04:52 AM Misc #9148 (Closed): Fix broken url in lib/xmlrpc.rb documentation
giorgostsiftsis (Giorgos Tsiftsis)
10:22 PM Bug #9152 (Assigned): Relic documentation in lib/xmlrpc/client.rb
Thanks for the report! zzak (zzak _)
07:49 PM Bug #9152 (Closed): Relic documentation in lib/xmlrpc/client.rb
In line 80
# Note, that you need the SSL package from RAA installed.
I could provide a fix but I am not sure exactly about the solution.
giorgostsiftsis (Giorgos Tsiftsis)
09:46 PM Revision 302743d3 (git): * NEWS: Add ObjectSpace.after_gc_{start,end}_hook=
* ext/objspace/objspace_dump.c: [DOC] catch up dump/dump_all to r43679
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tmm1 (Aman Karmani)
07:15 PM Bug #9151 (Closed): Segfault in Ruby head
Following code causes a segfault in ruby head on x64:
class A
attr_accessor :b
def hash
[b,""].hash
end
end
class B
attr_accessor :a
def hash
[a,""].hash
end
end
a = A.new
b = B.new
a.b = b
...
sam.saffron (Sam Saffron)
07:14 PM Revision c21f62d0 (git): * 2013-11-26
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43846 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
07:14 PM Revision 04817ae6 (git): * lib/rubygems: Update to RubyGems master 612f85a. Notable changes:
Fixed installation and activation of git: and path: gems via
Gem.use_gemdeps
Improved documentation coverage
* test/rubygems: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43845 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
drbrain (Eric Hodel)
05:12 PM Bug #9119: TestTime#test_marshal_broken_offset broken under MinGW
After applying above patch, TestTime#test_marshal_broken_offset test passes.
But TestTime#test_marshal_zone test fails on UTC-5 timezone.
I inspected this issue and found that it is a mingw 32-bit compiler specific issue.
The MSVC a...
phasis68 (Heesob Park)
05:08 PM Misc #8741: email notification on bugs.ruby-lang.org is broken
A have newer received any email notification, i do not know why. alexeymuranov (Alexey Muranov)
09:52 AM Misc #8741: email notification on bugs.ruby-lang.org is broken
Our redmine's notification seems buggy.
Contribution is welcome.
https://github.com/asakusarb/redmine4ruby-lang/issues/28
naruse (Yui NARUSE)
07:43 AM Misc #8741 (Feedback): email notification on bugs.ruby-lang.org is broken
ok, I restart to investigation. hsbt (Hiroshi SHIBATA)
05:24 AM Misc #8741: email notification on bugs.ruby-lang.org is broken
Why is this closed? rits (First Last)
03:17 PM Feature #9145: Queue#pop(true) return nil if empty instead of raising ThreadError
Note that the current behavior allows you to distinguish between a nil in the queue (returns nil) and no value in the queue (raises ThreadError) drbrain (Eric Hodel)
11:59 AM Feature #9145: Queue#pop(true) return nil if empty instead of raising ThreadError
On 11/23/2013 08:30 PM, Glass_saga (Masaki Matsushita) wrote:
> I think we can't change default behavior of Queue#pop(true) because some code expects ThreadError to be raised.
> However, it may be possible to introduce new keyword a...
Anonymous
09:13 AM Feature #9145: Queue#pop(true) return nil if empty instead of raising ThreadError
Glass_saga (Masaki Matsushita) wrote:
> I think we can't change default behavior of Queue#pop(true) because some code expects ThreadError to be raised.
> ...
That would work for me.
jsc (Justin Collins)
02:58 PM Bug #9150 (Closed): Segfault in case statement execution, possibly related to refinements
This code consistently segfaults in 2.0.0p353:
require 'active_support/all'
case 3600
when 1.week then true
end
This is after `gem install activesupport --version=3.2.13`. The code works fine in 2.0.0p247.
I ran a git bisec...
bradleybuda (Bradley Buda)
01:23 PM Revision c1073725 (git): * lib/xmlrpc.rb: [DOC] Fix link to xmlrpc4r site [Bug #9148]
Patch by Giorgos Tsiftsis
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
zzak (zzak _)
10:49 AM Bug #9149 (Closed): rb-appscript crash
a simple script as :
#! /usr/bin/env ruby
# encoding: utf-8
require 'rubygems'
require 'appscript'
include Appscript
selected = app('Finder').selection.get(:result_type => :alias)
selected.each do |file|
puts file.to_s
end...
unbewusst (Yvon Thoraval)
10:49 AM Revision 217d37a6 (git): * lib/uri/common.rb: [DOC] typo fixes by @vipulnsward [Fixes GH-456]
https://github.com/ruby/ruby/pull/456
* lib/uri/generic.rb: [DOC] ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
zzak (zzak _)
09:24 AM Bug #9133: logger rotates log files more than expected
no6v (Nobuhiro IMAI) wrote:
> After that, the @logdev.dev of process A is "log.0", so #9133 happens.
> ...
Both 9133 above are #9130, sorry.
no6v (Nobuhiro IMAI)
09:23 AM Bug #9133: logger rotates log files more than expected
After that, the @logdev.dev of process A is "log.0", so #9133 happens.
I wrote a test for this issue, also fixes #9133.
diff --git a/lib/logger.rb b/lib/logger.rb
index c70b091..071594d 100644
--- a/lib/logger.rb
+++ b/lib/logger....
no6v (Nobuhiro IMAI)
05:35 AM Revision b5147423 (git): * ext/bigdecimal/bigdecimal.gemspec: bump BigDecimal to 1.2.3 for
proper release date in RubyGems
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43842 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
zzak (zzak _)
05:25 AM Revision a7925537 (git): * ext/bigdecimal/bigdecimal.gemspec: Remove Gem::Specification#date
We should rely on rubygems to create the date the gem was released
for each version.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43841 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
zzak (zzak _)
05:11 AM Feature #7511: short-circuiting logical implication operator
mame (Yusuke Endoh) wrote:
> Please show a more concrete example.
> ...
logical implication is a core operation of boolean algebra, do you also need concrete examples for || ?
ok if you insist, lets say your code needs to perform so...
rits (First Last)
04:22 AM Revision 336eb217 (git): fix typos
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43840 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
04:18 AM Bug #8418: when all params are optional, named arg hash maps to the first available param
but isn't it good to have correspondence between keyword args and keyword hash?
when keyword args are used explicitly at invocation (foo a: 1, foo **hash) but the method signature does not use keyword params, it seems natural to bind ...
rits (First Last)
04:02 AM Feature #7274: UnboundMethods should be bindable to any object that is_a?(owner of the UnboundMethod)
is this rejected? rits (First Last)
01:13 AM Revision 2bfd722d (git): * internal.h: do not use ruby_sized_xrealloc() and ruby_sized_xfree()
if HAVE_MALLOC_USABLE_SIZE (or _WIN32) is defined.
We don't need these function if malloc_usable_size() is available.
* gc.c: catch up this change.
* gc.c: define HAVE_MALLOC_USABLE_SIZE on _WIN32.
* array.c (ary_resize_capa): do not u...
ko1 (Koichi Sasada)

11/24/2013

11:41 PM Feature #9147 (Closed): CSV.new option skip_lines should escape String before convert to Regexp
After r43823, the following script ignore all lines.
== test_csv.rb ==
```
require "csv"
csv = CSV.new(<<-EOL, skip_lines: ".")
1,foo
.2,bar
3,baz
EOL
p csv.each.to_a # => []
```
I think String value for skip_lines o...
nagachika (Tomoyuki Chikanaga)
08:06 PM Revision 84b7d6d5 (git): * test/-ext-/tracepoint/test_tracepoint.rb: catch up GC.stat changes
at r43835.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
07:49 PM Revision 30e88ca8 (git): * gc.c: continue to change OLDSPACE -> OLDMALLOC.
RGENGC_ESTIMATE_OLDSPACE -> RGENGC_ESTIMATE_OLDMALLOC.
* gc.c: add a new major GC reason GPR_FLAG_MAJOR_BY_OLDMALLOC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43837 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
07:24 PM Misc #9146 (Closed): Update documentation for lib/abbrev.rb
giorgostsiftsis (Giorgos Tsiftsis)
07:18 PM Revision a87eaf88 (git): * gc.c: change terminlogy "..._num" to "..._slots" about slot opetaion.
* final_num -> final_slots
* objspace_live_num() -> objspace_live_slots()
* objspace_limit_num() -> objspace_limit_slots()
* objspace_free_num() -> objspace_free_slots()
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43836 b2...
ko1 (Koichi Sasada)
07:08 PM Revision f0600220 (git): * gc.c (gc_stat): add internal information.
* heap_swept_slot
* malloc_increase
* malloc_limit
* remembered_shady_object
* remembered_shady_object_limit
* old_object
* old_object_limit
* oldmalloc_increase
* oldmalloc_limit
* gc.c (gc_stat): rename names.
* heap_...
ko1 (Koichi Sasada)
07:01 PM Revision 15bbf34c (git): * test/ruby/test_gc.rb: catch up last commit.
Now RUBY_GC_OLDSPACE_LIMIT(...) is RUBY_GC_OLDMALLOC_LIMIT(...).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43834 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
06:13 PM Revision c1382f3a (git): * gc.c: change terminology OLDSPACE -> OLDMALLOC.
(oldspace -> oldmalloc for variable names)
OLDSPACE is confusing because it is not includes slots.
To more clearly, rename such as (oldspace_limit -> oldmalloc_limit).
It is clear that it measures (estimates) malloc()'ed size.
g...
ko1 (Koichi Sasada)
04:03 PM Revision 9465475e (git): * 2013-11-25
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43832 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:03 PM Revision b25a6494 (git): * internal.h: use __builtin_bswap16() if possible.
* configure.in: check existence of __builtin_bswap16().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43831 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Glass_saga (Masaki Matsushita)
01:55 PM Feature #8509: Use 128 bit integer type in Bignum
I decided to disable __int128 for Bignum because it is not always faster.
__int128 is still be usable by specifying CPPFLAGS for configure as:
configure CPPFLAGS='-DBDIGIT=uint64_t -DSIZEOF_BDIGITS=8 -DBDIGIT_DBL=uint128_t -DBDIGIT_D...
akr (Akira Tanaka)
01:53 PM Feature #9145: Queue#pop(true) return nil if empty instead of raising ThreadError
"Glass_saga (Masaki Matsushita)" <[email protected]> wrote:
> I think we can't change default behavior of Queue#pop(true) because some code expects ThreadError to be raised.
> However, it may be possible to introduce new keyword ...
normalperson (Eric Wong)
01:30 PM Feature #9145 (Feedback): Queue#pop(true) return nil if empty instead of raising ThreadError
I think we can't change default behavior of Queue#pop(true) because some code expects ThreadError to be raised.
However, it may be possible to introduce new keyword argument like following:
q = Queue.new
while next_item = q.pop(true...
Glass_saga (Masaki Matsushita)
12:42 PM Feature #9145 (Open): Queue#pop(true) return nil if empty instead of raising ThreadError
I propose the non-blocking form of Queue#pop behave like Array#pop and return nil when empty.
Current behavior is to raise a ThreadError, with a message indicating the queue is empty.
For example:
q = Queue.new
begin
loop do...
jsc (Justin Collins)
01:27 PM Revision bc65d709 (git): * bignum.c (bigxor_int): Apply BIGLO for long in a BDIGIT expression.
(bigor_int): Ditto.
(bigand_int): Ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43830 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
akr (Akira Tanaka)
09:47 AM Feature #9143 (Closed): Optimize CSV to share hash key objects between rows
JEG2 (James Gray)
09:01 AM Feature #9143 (Assigned): Optimize CSV to share hash key objects between rows
nobu (Nobuyoshi Nakada)
09:01 AM Feature #9143: Optimize CSV to share hash key objects between rows
assert_predicate(string_key, :frozen?) will show better message when it fails. nobu (Nobuyoshi Nakada)
08:35 AM Feature #9143: Optimize CSV to share hash key objects between rows
Thanks nobu, I write too much RSpec lately.
Updated patch attached: I also added freeze in Row#initialize, not sure if both places are needed, or which is better. Please review.
avit (Andrew Vit)
12:56 AM Feature #9143: Optimize CSV to share hash key objects between rows
=begin
You can use (({assert_instance_of})) and (({assert_same})).
=end
nobu (Nobuyoshi Nakada)
09:15 AM Revision 0224b515 (git): * include/ruby/defines.h (SIZEOF_ACTUAL_BDIGIT): Defined.
* include/ruby/ruby.h (RBIGNUM_EMBED_LEN_MAX): Use
SIZEOF_ACTUAL_BDIGIT instead of SIZEOF_BDIGITS.
SIZEOF_BDIGITS can be different to sizeof(BDIGIT).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43829 b2dd03c8-39d4-4d8f-98ff-...
akr (Akira Tanaka)
08:14 AM Bug #8560 (Closed): CSV, skip_lines option causes error when passing a string
JEG2 (James Gray)
04:08 AM Bug #8560: CSV, skip_lines option causes error when passing a string
Attached is a patch that converts skip_lines to a Regexp if it's a string. Also see pull request on GitHub: https://github.com/ruby/ruby/pull/455
kstevens715 (Kyle Stevens)
07:17 AM Revision 8835b1fb (git): * ChangeLog: adjust timezone and encoding.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43828 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
06:23 AM Bug #9144: ptys on AIX version 4 through 7
Doing more research, the existing ruby code is 99% there.

I got it to work by changing line 248 of ext/pty/pty.c from:

#if defined(I_PUSH) && !defined(__linux__)

to

#if defined(I_PUSH) && !defined(__linux__) && !defined(_AIX...
Anonymous
04:14 AM Bug #9144 (Closed): ptys on AIX version 4 through 7
The best way to open a pty on AIX version 4 through 7 is using what they call "AT&T" mode. The steps are to first open "/dev/ptc" which opens the master side. Then to a ttyname on the file descriptor and open the string that is returne... pedz (Perry Smith)
04:51 AM Revision d3354100 (git): * include/ruby/defines.h: Don't use int128_t for Bignum.
It's not always faster.
* bignum.c: Ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43827 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
akr (Akira Tanaka)
03:50 AM Misc #8741: email notification on bugs.ruby-lang.org is broken
Maybe it is all about missing SPF record for the server bugs.ruby-lang.org to send emails in name of ruby-lang.org => https://support.google.com/a/answer/33786 mpapis (Michal Papis)
02:11 AM Feature #9140 (Rejected): Allow each_with_index to get start index
kosaki (Motohiro KOSAKI)
02:05 AM Feature #9140: Allow each_with_index to get start index
There's no bug. Just reject this feature request. rosenfeld (Rodrigo Rosenfeld Rosas)
01:48 AM Feature #9099: Train emoji lambda operator
@mame: OMG there are crazier people than me out there. Anonymous
01:34 AM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
BertramScharpf (Bertram Scharpf) wrote:
>
> ...
I do not understand what is a matter of taste here. Everybody seems to agree that the only problem is the compatibility. How would the following be less beautiful or clear?
a.so...
alexeymuranov (Alexey Muranov)
01:31 AM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
alexeymuranov (Alexey Muranov) wrote:
> In my opinion, it is because code is intended mostly for reading, not for writing.
> ...
That's a matter of taste. In my eyes, this code example is beautiful and clear.
It could be more efficien...
BertramScharpf (Bertram Scharpf)
01:20 AM Revision 4ef2f0d2 (git): * NEWS: Add details about new debugging features and APIs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43826 b2dd03c8-39d4-4d8f-98ff-823fe69b080e tmm1 (Aman Karmani)
12:44 AM Revision 895e9b0a (git): * lib/csv.rb: Optimize header hashes by freezing string keys.
[ruby-core:58510]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43825 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
James Edward Gray II
12:22 AM Revision 34176b02 (git): * ext/objspace/objspace_dump.c: test fixes and win32 compatibility
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43824 b2dd03c8-39d4-4d8f-98ff-823fe69b080e tmm1 (Aman Karmani)

11/23/2013

11:12 PM Revision 80c4b4b3 (git): * lib/csv.rb: If skip_lines is set to a String, convert it to a Regexp
to prevent the alternative, which is that each line in the CSV gets
converted to a Regexp when calling skip_lines#match.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43823 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
James Edward Gray II
10:44 PM Feature #9121: [PATCH] Remove rbtree implementation of SortedSet due to performance regression
Maybe. And I noticed the second preview (not RC though) of 2.1.0 was out, so I'll postpone any change to SortedSet to the next major. knu (Akinori MUSHA)
10:07 PM Feature #9121: [PATCH] Remove rbtree implementation of SortedSet due to performance regression
zzak (Zachary Scott) wrote:
> See #7698 and https://github.com/seki/Drip/issues/4
Thank you, but it works now for me.
$ ruby -v
ruby 2.0.0p353 (2013-11-22 revision 43784) [x86_64-linux]
$ gem -v
2.1.11
$ gem install ...
mame (Yusuke Endoh)
10:01 PM Feature #9121: [PATCH] Remove rbtree implementation of SortedSet due to performance regression
I wrote:
> ... and the point of this issue is that we should not depend on it any more, so I'll go ahead anyway.
Oops, I mistook this issue for something else, I just thought that's another reason to ditch the rbtree dependency albei...
knu (Akinori MUSHA)
09:53 PM Feature #9121: [PATCH] Remove rbtree implementation of SortedSet due to performance regression
mame (Yusuke Endoh) wrote:
> knu (Akinori MUSHA) wrote:
> ...
Try it yourself and you'll see. It relies on the internal data structure of RHash at some point of Ruby that lasted until 1.9.3.
> I'm afraid it is a more serious proble...
knu (Akinori MUSHA)
09:23 PM Feature #9121: [PATCH] Remove rbtree implementation of SortedSet due to performance regression
See #7698 and https://github.com/seki/Drip/issues/4

> On Nov 23, 2013, at 6:09 PM, "mame (Yusuke Endoh)" <[email protected]> wrote:
>
>
> Issue #9121 has been updated by mame (Yusuke Endoh).
>
>
> knu (Akinori MUSHA) w...
zzak (zzak _)
06:09 PM Feature #9121: [PATCH] Remove rbtree implementation of SortedSet due to performance regression
knu (Akinori MUSHA) wrote:
> rbtree is seemingly broken for the latest version of ruby.
What do you mean? What broke rbtree?
I'm afraid it is a more serious problem than this ticket itself.
--
Yusuke Endoh <[email protected]>
mame (Yusuke Endoh)
05:51 PM Feature #9121: [PATCH] Remove rbtree implementation of SortedSet due to performance regression
Thanks for your input, guys.
I think I'll drop the optional rbtree version of SortedSet for now, since rbtree is seemingly broken for the latest version of ruby.
knu (Akinori MUSHA)
09:23 PM Bug #9142: Ruby 2.0.0 crash in Rake/mysql2
Can you also include an example to reproduce?

> On Nov 23, 2013, at 4:43 AM, "mlarocque (Michael Larocque)" <[email protected]> wrote:
>
>
> Issue #9142 has been reported by mlarocque (Michael Larocque).
>
> ----...
zzak (zzak _)
04:43 AM Bug #9142 (Closed): Ruby 2.0.0 crash in Rake/mysql2
Hi folks,
I've spent the past couple of days trying to decipher a ruby crash. I've googled, etc and followed the 'How to Report bugs in Ruby' page. I'm looking for any advice to try to track this down.
Here's the relevant data:
...
mlarocque (Michael Larocque)
09:23 PM Feature #9140: Allow each_with_index to get start index
So is this a doc bug?

> On Nov 23, 2013, at 12:05 AM, "rosenfeld (Rodrigo Rosenfeld Rosas)" <[email protected]> wrote:
>
>
> Issue #9140 has been updated by rosenfeld (Rodrigo Rosenfeld Rosas).
>
>
> By the way, fe...
zzak (zzak _)
12:05 AM Feature #9140: Allow each_with_index to get start index
By the way, feel free to reject this ticket then. I only created it because I thought it would be backwards compatible. rosenfeld (Rodrigo Rosenfeld Rosas)
12:02 AM Feature #9140: Allow each_with_index to get start index
Actually, it explains but I missed an example :) I do example driven development ;) rosenfeld (Rodrigo Rosenfeld Rosas)
07:55 PM Feature #6857 (Assigned): bigdecimal/math BigMath.E/BigMath.exp R. P. Feynman inspired optimization
The optimization of BigMath.log is remaining. mrkn (Kenta Murata)
07:52 PM Feature #6857 (Closed): bigdecimal/math BigMath.E/BigMath.exp R. P. Feynman inspired optimization
This issue was solved with changeset r43817.
Rafał, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* ext/bigdecimal/lib/bigdecimal/math.rb (BigMath.E): Use BigMath...
mrkn (Kenta Murata)
07:03 PM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
fuadksd (Fuad Saud) wrote:
> I don't understand why we would want to be so strict about types on this
> ...
In my opinion, it is because code is intended mostly for reading, not for writing.
a.sort {|a,b| (a.downcase <=> b.downc...
alexeymuranov (Alexey Muranov)
11:23 AM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
I don't understand why we would want to be so strict about types on this
case. Having some arbitrary value being returned is useful and it doesn't
hurt any good practices. Ensuring predicates return true or false feels
useless for...
fuadksd (Fuad Saud)
10:14 AM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
avit (Andrew Vit) wrote:
> 42.nonzero? #=> 42
> ...
In fact, the first version of nonzero? returned self or false.
Inaba, in [ruby-dev:6417] (22 Mar 1999), suggested a convention about the usage
of nil and false.
* if a me...
mame (Yusuke Endoh)
09:14 AM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
avit (Andrew Vit) wrote:
> Also, why should we return nil in any case? I think the correct return value should be false, not nil. (nil implies an unknown or unavailable answer, but we *do* know if the number is 0 or not.) In other words...
alexeymuranov (Alexey Muranov)
04:01 AM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
The history on this is interesting. I would agree with the consistency idea of nonzero = (nil | 1) and nonzero? = (false | true) but I don't know if this could be changed now.
Also, why should we return nil in any case? I think the co...
avit (Andrew Vit)
12:54 AM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
mame (Yusuke Endoh) wrote:
> By the way, I investigated the early history of nonzero?.
Very interesting, thank you a lot for reporting it!
Personally I do sometimes use #nonzero? semantics when I want an Integer, but another val...
Eregon (Benoit Daloze)
04:08 PM Revision 10ca8a4b (git): * ext/bigdecimal/bigdecimal.c (BigDecimal_power): Use FIX2LONG instead
of FIX2INT to avoid conversion error.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43822 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Kenta Murata
03:53 PM Feature #9047: Alternate hash key syntax for symbols
@matz -- sorry, I didn't receive an email notification, so I didn't realize you had responded.
This isn't MRI, I realize, but in RubyMotion this notation would come in handy.
https://github.com/clearsightstudio/ProMotion/issues/345#iss...
jamonholmgren (Jamon Holmgren)
03:44 PM Revision 4efba669 (git): ruby.h: define RBIGNUM_EMBED_LEN_MAX by macros
* include/ruby/ruby.h (RBIGNUM_EMBED_LEN_MAX): define by macros
defined in defines.h, instead of complex and repeated expression.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
03:35 PM Revision b28608f7 (git): * 2013-11-24
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43820 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:35 PM Revision 81f4262e (git): * ChangeLog: fix a typo at r43744.
* gc.c (is_mark_stack_empty): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43819 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nagachika (Tomoyuki Chikanaga)
01:25 PM Revision 6bcb8edb (git): * include/ruby/ruby.h (RBIGNUM_EMBED_LEN_MAX): Limit the value to
less than 8.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
akr (Akira Tanaka)
11:34 AM Bug #8995: バイナリデータを文字列として encode! すると readbyte の結果が変化する
workaroundが入ったようですが、元々UTF-8ではないバイナリデータが壊れないということは、裏を返せばmalformed UTF-8の攻撃文字列も破棄されないということです。
つまり、脆弱性はそのまま残っているわけなので、何らかの対策が必要であろうことだけは警告しておきます。
nobu (Nobuyoshi Nakada)
11:09 AM Bug #9119: TestTime#test_marshal_broken_offset broken under MinGW
Finally, I found the reason why I cannot reproduce the same result with Rubyinstaller test.
The timezone of Rubyinstaller test server is UTC-3 and my timezone is UTC+9.
The localtime(3) overflow check code returns yes for timezone fr...
phasis68 (Heesob Park)
10:52 AM Revision b8bbc1a3 (git): * ext/bigdecimal/lib/bigdecimal/math.rb (BigMath.E): Use BigMath.exp.
[Feature #6857] [ruby-core:47130]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43817 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Kenta Murata
10:49 AM Revision b09f4158 (git): exp
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43816 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Kenta Murata
10:41 AM Bug #9124: TestSocket errors in test-all on Arch 64-bit
No failure on 64bit ubuntu server 13.10 with glibc 2.17 and gcc 4.8.1. Failure only on arch 64bit with glibc 2.18 and gcc 4.8.2 jonforums (Jon Forums)
10:36 AM Revision 926960b0 (git): * ext/bigdecimal/bigdecimal.c (BigDecimal_div2): The signature was
changed to allow us to pass arguments directly.
* ext/bigdecimal/bigdecimal.c (BigDecimal_div3): Added for the role of
the old BigDecimal_div2.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43815 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Kenta Murata
05:41 AM Feature #9143: Optimize CSV to share hash key objects between rows
Note, this can be worked around by doing `csv.header_converters << proc{|h| h.freeze }` but I think there should be some built-in optimization for this. avit (Andrew Vit)
05:05 AM Feature #9143 (Closed): Optimize CSV to share hash key objects between rows
Currently, when CSV headers are strings, then each row receives a copy of the strings for hash keys. This patch is an optimization to share the same frozen string keys between all rows.
Please verify: in the implementation of `Hash::[...
avit (Andrew Vit)
04:51 AM Revision c5a919fb (git): * append newline at EOF.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
04:46 AM Revision fe398529 (git): add NEWS about rb_gc_set_params() and rb_gc_count()
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e authorNari (Narihiro Nakamura)
03:58 AM Misc #9136: Deprecated Enumerator.new(object, method) bad for BasicObject
@nobu I found that out but it seems kind of hackish way to have to do it. (Also a little counter-intuitive since Kernel is not in BasicObject). I ended up with:
def to_enum(meth=:each)
Enumerator.new{ |y| __send__(meth) { |...
atlas (Atlas Prime)
03:40 AM Revision 7ae8d789 (git): fix typo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43812 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Masaya Tarui
03:33 AM Revision dbe9e6a5 (git): * gc.c: fix gloval variable name.
Now we have following environments (and related variable names).
* RUBY_GC_HEAP_INIT_SLOTS
* RUBY_GC_HEAP_FREE_SLOTS
* RUBY_GC_HEAP_GROWTH_FACTOR (new from 2.1)
* RUBY_GC_HEAP_GROWTH_MAX_SLOTS (new from 2.1)
* obsolete
* RU...
ko1 (Koichi Sasada)
12:46 AM Revision 65a56437 (git): * marshal.c (w_object): Use HASH_PROC_DEFAULT directly from internal.h
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43810 b2dd03c8-39d4-4d8f-98ff-823fe69b080e tmm1 (Aman Karmani)
12:29 AM Bug #9141: define_singleton_method creates private method
This is probably related to #9005. jeremyevans0 (Jeremy Evans)
 

Also available in: Atom