Activity
From 07/27/2015 to 08/02/2015
08/02/2015
-
11:24 PM Bug #11383: Infinite loop in str_buf_cat triggered by str_gsub
- Nobu,
Thanks for fixing this issue.
On our side, the issue reproduced, not with the same arguments though. Anyway, I was able to get the value of *(struct RString *)str.
~~~
(gdb) display *(struct RString *)str
1: *(struct RSt... -
10:26 PM Bug #11411 (Closed): Crash in rb_gc_mark() during Rails app boot with GC.stress=1
- Seems same as #11352.
-
07:09 PM Bug #11411 (Closed): Crash in rb_gc_mark() during Rails app boot with GC.stress=1
- When booting a newly-initialized Rails 4.2.1 app under Ruby 2.2.2 with `GC.stress` enabled, I get a repeatable crash. The same crash happens at least as far back as 2.1.4 (haven't tried any earlier versions).
Steps to reproduce:
1.... -
08:29 PM Bug #11412 (Rejected): The default filename encoding causes errors on Windows
- Ruby is apparently unable to find files it just told me are there (containing japanese characters).
Demo code:
Dir.foreach('.') do |entry|
puts "#{entry} exists? " + File.exist?(entry).to_s
end
Output:
C:\tmp\test\filenames>C:\t... -
07:27 PM Bug #11410: Win32 Registry enumeration performs unnecessary string re-encoding which cause UndefinedConversionError exceptions
- I realized that I should have included some sample code demonstrating the problem:
~~~ruby
require 'win32/registry'
ENDASH_UTF_16 = [0x2013]
TM_UTF_16 = [0x2122]
endash_utf_16_str = ENDASH_UTF_16.pack('s*').force_encoding(Enco... -
- When enumerating keys with `Win32::Registry#each_key` / `Win32::Registry#keys` or values with `Win32::Registry#each_value` / `Win32::Registry#values`, Ruby will take a `UTF-16LE` string returned from the Windows API and convert it to the...
-
- Yui NARUSE wrote:
> ruby_2_2 r49622 merged revision(s) 49542.
I would like to see this backported to Ruby 2.1 as well. Without it, registry keys and values cannot be deleted at all. This is a fairly large issue on Windows.
Comme... -
12:29 PM Bug #11407: Net::FTP nlst method return wrong data and don't raise Error when path is wrong
- Damian Giebas wrote:
> When ftp server is on Linux all is fine. Problem is when FTP is on IIS Server 8.0 (and probably with other version of IIS).
I think it's more likely a server-side problem.
Do you any other FTP client which wor... -
08:41 AM Bug #11409 (Closed): {instance,module}_eval(&:foo) segfaults since r51243.
- The segfault only occurs when the argument is a `#to_proc`'d Symbol, and the receiver needn't actually respond to the named method.
This bug was introduced in [a rather large patch](http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev... -
- * win32/file.c (rb_freopen): convert path name into allocv buffer
and get rid of conversion failure in the case non-terminated
string. [ruby-core:69780] [Bug #11320]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51469 b2dd03c8-... -
- * ext/tk/tcltklib.c (ip_cancel_eval_core): check argument type and
length.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51468 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/01/2015
-
10:08 PM
Bug #11400 (Closed): IO.gets(/\x0d?\x0a\x0d?\x0a/, 4096) raises comparison of Fixnum with nil failed
- Applied in changeset r51466.
----------
openssl/buffering: fix gets on EOF with limit
* ext/openssl/lib/openssl/buffering.rb (gets):
avoid comparing fixnum with nil
* test/openssl/test_pair.rb: test gets with limit when EOF is hit
... - 10:08 PM Revision 03fcd385 (git): * 2015-08-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51467 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:08 PM Revision 1e5a40ff (git): openssl/buffering: fix gets on EOF with limit
- * ext/openssl/lib/openssl/buffering.rb (gets):
avoid comparing fixnum with nil
* test/openssl/test_pair.rb: test gets with limit when EOF is hit
Thanks to Bar Hofesh <[email protected]> for the bug report
and testing.
[ruby-c... -
08:23 AM Revision 9cf11b70 (git): * lib/net/http/response.rb (Net::HTTPResponse::Inflater#finish):
- fix a bug that empty gzipped response body causes Zlib::BufError.
[ruby-core:68846] [Bug #11058]
* test/net/http/test_httpresponse.rb: tests for the above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51465 b2dd03c8-39d4-4d8f-98... -
- Applied in changeset r51464.
----------
* lib/net/http/response.rb (Net::HTTPResponse#inflater):
fix TypeError. An exception object might be nil.
[ruby-core:68846] [Bug #11058] -
- fix TypeError. An exception object might be nil.
[ruby-core:68846] [Bug #11058]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51464 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread.c (thread_shield_get_mutex): explicitly check if
destroyed already.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51463 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:14 AM Bug #11393: segfault on trivial application, embedding in C app.
- Thanks!
That didn't AV.
I guess I misunderstood what `rb_load_file` meant. I couldn't find a definitive reference, and there are no comments in the code.
It seems like rb_require is the correct thing to use to run a script.
I... -
- In short; use `rb_protect()`.
Ruby interpreter can't deal with exceptions raised outside its scope.
So you **must do it by yourself** instead.
~~~c
#include <ruby.h>
static VALUE
load_file(VALUE name)
{
return (VALUE)rb... -
12:12 AM Revision d8225d9f (git): * ext/openssl/ossl_ssl.c (ossl_sslctx_setup): Implement
- SSLContext#options and options= using SSL_CTX_set_options and
SSL_CTX_get_options. This reduces the number of ivars we need and
simplifies `ossl_sslctx_setup`.
* ext/openssl/lib/openssl/ssl.rb (module OpenSSL): Default `options`
t...
07/31/2015
-
- constants as longs, so we should follow that and use LONG2NUM.
http://git.io/vOqxD
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51461 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:08 PM Bug #11336: TestProcess#test_exec_fd_3_redirect failed on Solaris 10
- [email protected] wrote:
> I'm sorry too late.
No worries, I don't have much time for ruby these few weeks, either.
> On Solaris 10, the patch works fine, with no error/failure during make test-all (with r51450).
>
> > I'm... -
01:29 PM Bug #11336: TestProcess#test_exec_fd_3_redirect failed on Solaris 10
- I'm sorry too late.
On Solaris 10, the patch works fine, with no error/failure during make test-all (with r51450).
> I'm not seeing it, did you notice/reproduce this failure?
No.
It seems the patch works correctly as you descri... -
- to return the Ruby dh (or ecdh) object that the caller cares about
instead of doing rb_iv_get / set to communicate. This means we can
remove an rb_iv_get call, and only use the set calls for their
intended purpose (to prevent the ... -
- tmp_ecdh_callback, the SSLSocket instance always holds a reference
to the SSLContext object (it's always set in `initialize`). The
SSLContext holds a reference to the tmp_dh_callback. Ask the
context for the callback instead of s... -
- and use `rb_apply` to clean up calls to `rb_protect`.
* ext/openssl/ossl_ssl.c (ossl_tmp_dh_callback): ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51458 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- always holds a reference to the SSLContext object, which will have
the callback object. Ask the context for the callback instead of
storing the callback in two places.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51457 b2dd03c... - 06:20 PM Revision fa204023 (git): * 2015-08-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51456 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `tmp_dh_callback` to Ruby, and call it when setting up an SSL
connection. This allows us to move the "default" behavior to the
reader method.
* ext/openssl/ossl_ssl.c: call the tmp_dh_callback instead of
accessing the SSLContext'... -
- Thanks. I've applied the patch and the build is green now.
-
11:01 AM Bug #10910: NoMethodError when opening SSL connection with OpenSSL::SSL::VERIFY_PEER set and anonymous ciphers allowed
- Turns out Travis ships an old, apparently broken version of `libssl`. I've attached a patch which updates it before running the build. You can see the patch running on this build: https://travis-ci.org/Sinjo/ruby/builds/73534479
- 02:38 PM Revision af13f15b (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51454 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51453 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:35 PM Revision d1cfb475 (git): * 2015-07-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51452 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * load.c (rb_require_internal): use rb_load_internal0 not to raise
a exception to be caught.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51451 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:41 AM Bug #11407: Net::FTP nlst method return wrong data and don't raise Error when path is wrong
- When ftp server is on Linux all is fine. Problem is when FTP is on IIS Server 8.0 (and probably with other version of IIS).
-
07:41 AM Bug #11402: Seg Fault on intensive numeric calculation
- Kenta Murata wrote:
> Alexey, please give me your script to produce this issue.
It is a part of production ready app and has too many local dependencies. I have no short script to reproduce that ( -
- Nobuyoshi Nakada wrote:
> You load bigdecimal-1.2.5, which is out-of-date.
> ...
Ok, thanks. I'll try to update bigdecimal -
04:59 AM Bug #10892: Deadlock in autoload
- That broken rubyspec was written by me. The problem lies with repeatedly `autoload`ing the same `.rb` file, since this should be impossible, the spec manually deletes the loaded path from `$LOADED_FEATURES` and then re-declares the `auto...
-
- Maybe https://github.com/pbhogan/scrypt/issues/28 ?
07/30/2015
-
08:00 PM Bug #11408 (Third Party's Issue): Segmentation fault with SCrypt and Ruby 2.2.2p95
- I'm working on using SCrypt to generate a password salt and hash, but while generating the salt I get a segmentation fault.
My local code (fails on line 1):
~~~ruby
password_salt = SCrypt::Engine.generate_salt
password_... -
- Thanks, I'm taking a look.
On Thu, Jul 30, 2015 at 09:17:38AM +0000, [email protected] wrote:
> Issue #10910 has been updated by Nobuyoshi Nakada.
>
> Status changed from Closed to Open
>
> This has failed on travis.
>
> h... -
- This has failed on travis.
https://travis-ci.org/ruby/ruby/builds/72882783 -
- Damian Giebas wrote:
> I found bug in nlst function. When we have situatiuon on ftp like this
> ...
I couldn't reproduce the problem....
```ruby
require "net/ftp"
ftp = Net::FTP.new("ftp.ruby-lang.org")
ftp.passive = true
ftp.... -
- I found bug in nlst function. When we have situatiuon on ftp like this
/
my_folder/
some_file.txt
some_another_file.txt
and we go to "my_folder"
ftp_handler.chdir("my_folder")
and use nlst from this folder on file "s... -
01:45 PM Bug #11402: Seg Fault on intensive numeric calculation
- Alexey, please give me your script to produce this issue.
-
- You load bigdecimal-1.2.5, which is out-of-date.
Can't you try recent version? -
10:45 AM Bug #10969: public_send in combination with method_missing raises NameError instead of NoMethodError
- Thank you Nobuyoshi Nakada and Koichi Sasada! 💛
-
10:01 AM Bug #11400: IO.gets(/\x0d?\x0a\x0d?\x0a/, 4096) raises comparison of Fixnum with nil failed
- Small and elegant fix, after a few hours of testings (stress and SSL errors), it seems that your patch is working and isn't breaking anything I can see.
Thanks -
- [email protected] wrote:
> Looking at the code it's clear the offending line is https://github.com/ruby/ruby/blob/trunk/ext/openssl/lib/openssl/buffering.rb#L216
> Where sometimes size would be nil, and because of "size = [size, l... -
09:57 AM Feature #11390: Allow symbols starting with numbers
- Sameer Deshmukh wrote:
> But it goes against the principle of least surprise that ruby follows throughout the language. It's counter-intuitive and IMO from a layman ruby programmer's point of view the solution you propose does not confi... -
- * test/ruby/test_settracefunc.rb (test_isolated_raise_in_trace):
check outputs.
* test/ruby/test_settracefunc.rb (test_recursive): method name
which is internally called by TracePoint is now skipped.
git-svn-id: svn+ssh://ci.ruby-l... -
- * thread.c (rb_uninterruptible): use identity hash for masking.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51449 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51448 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * common.mk (PHONY): should not depend on any real files, not to
make those dependencies inadvertently.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51447 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/openssl/test_pair.rb (test_ecdh_callback): join client
thread only when it started.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51446 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/envutil.rb (assert_separately): always add -w option
for warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51445 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r51444.
----------
variable.c: Module#deprecate_constant
* variable.c (rb_const_get_0): warn deprecated constant reference.
* variable.c (rb_mod_deprecate_constant): mark constants to be
warned as deprecated. [F... -
- * variable.c (rb_const_get_0): warn deprecated constant reference.
* variable.c (rb_mod_deprecate_constant): mark constants to be
warned as deprecated. [Feature #11398]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51444 b2dd03c8... -
- * NEWS (Core classes updates): sort classes/modules in
alphabetical order.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51443 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (clean-local): version.i is no longer generated
automatically.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51442 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread.c (rb_thread_s_handle_interrupt): make identical hash,
to compare masking classes just by their IDs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51441 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * load.c (rb_load_internal0): stop separating exits at loading
from exits from execution. TAG_FATAL is the only case that
`errinfo` is a Fixnum, and should continue to exit by JUMP_TAG
but not raising as an ordinary exception.
[... -
- Oops, forgot to attach patch. Not committed, yet. Not urgent, I think.
-
- Already committed?
-
- Applied in changeset r51439.
----------
load.c: avoid segfault when 'throw' occurs in the middle of rb_load_file_str
How can a 'throw' happen while the current thread is reading a Ruby source file
from disk and parsing it? It can happe... -
- How can a 'throw' happen while the current thread is reading a Ruby source file
from disk and parsing it? It can happen if another thread calls Thread#raise,
and passes an Exception object which responds to #exception, and the custom #ex... -
- It's not inconsistent, but derived from the behavior of `String#succ`.
~~~ruby
p "foo9".succ #=> "fop0"
~~~
And it ended with "zzzz9", or exceeds the length of "foo10".
I agree that the current behavior is less convenient in s... -
12:41 AM Bug #11406 (Closed): Inconsistent behavior when creating a range of strings which end in an integer greater than 10
- # Steps to Reproduce
In Ruby v2.2.2
1. Create a range of strings using 'foo1' up to 'foo9':
~~~ruby
('foo1'..'foo9').to_a
=> ["foo1", "foo2", "foo3", "foo4", "foo5", "foo6", "foo7", "foo8", "foo9"]
~~~
...
07/29/2015
- 11:55 PM Revision d0240cbb (git): st.c: constify st_table* in private functions
- Minor size reduction on 32-bit x86:
text data bss dec hex filename
13742 24 0 13766 35c6 st.o
14166 24 0 14190 376e st-orig.o
Public API change to be proposed separately.
* st.c (f... -
- Noticed with [ruby-core:70159] [Bug #11396]
The low bits of Ruby object IDs are rarely populated in the current
implementation, so ensure the get used.
Early versions of this patch redundantly shifted static symbols in
`any_hash`... - 07:55 PM Revision 669a2a35 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51437 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:54 PM Revision cc7c75ce (git): * 2015-07-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51436 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:54 PM Revision cb87005f (git): new benchmarks for hashing dsyms and fixnums
- * benchmark/bm_hash_aref_dsym.rb: new benchmark
* benchmark/bm_hash_aref_dsym_long.rb: ditto
* benchmark/bm_hash_aref_fix.rb: ditto
[ruby-core:70129] [Bug #11396] pointed out we need to consider
more cases for hashing.
git-svn-id: svn+... -
06:43 PM Feature #11258: add 'x' mode character for O_EXCL
- Nobuyoshi Nakada wrote:
> > ~~~diff
> ...
Yes, MODE_BINARY confused me (it uses it arguments in reverse order). I think `MODE_BINARY_EXCL` is a bad idea anyway. In V2 an ArgumentError is raised by `rb_io_oflags_modestr()` when `O_EXCL`... -
- Oops, I overlooked Inflate#total_in.
Thank you for your reviewing. -
- .crash file from ~/Library/Logs/DiagnosticReports/ attached
-
- Please show Crash Report log file.
-
05:30 AM Bug #11402: Seg Fault on intensive numeric calculation
- Alexey Chernenkov wrote:
> Occur several times:
> ...
Hi Alexey,
Do you think #9657 (calling `Float#to_d`) can be related ? -
- * test/openssl/test_pair.rb (test_ecdh_callback): join client
thread before closing sockets.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51434 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/openssl/test_pair.rb (test_ecdh_callback): fix thread leak.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51433 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * hash.c (any_hash), symbol.c (dsymbol_alloc): fix dynamic symbol
hash value by restricting in Fixnum range, that is `long`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51432 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_hash.rb (test_label_syntax): pass assertion
message and suppress warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51431 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:39 AM Bug #9381: 2.1.0 Regression. Hash lookup with #hash and #eql?
- I re-fill Backport field for r51425. I'm not sure if this is bugfix or feature change though.
-
- Looking at the code it's clear the offending line is https://github.com/ruby/ruby/blob/trunk/ext/openssl/lib/openssl/buffering.rb#L216
Where sometimes size would be nil, and because of "size = [size, limit].min" or more specifically "si... -
- Eric Wong wrote:
> Since you're using SSLSocket, I recommend dumping a backtrace when you
> ...
Error Reading Aware: comparison of Fixnum with nil failed
Error Reading Aware: ["/usr/local/rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/openssl/b... -
08:30 AM Bug #11404 (Closed): Segfault when 'throw' occurs while loading a Ruby source file [PATCH]
- Dear Ruby people,
Here is a fix for a segfault which can occur when requiring a Ruby source file inside a Timeout.timeout {} block. This may seem like a strange thing
to do, but it can easily happen unintentionally if you use librari... -
- * hash.c (rb_obj_hash): move in order to share with rb_any_hash.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51430 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/fiddle/extconf.rb: revert part of r51401 and expand
$LOCAL_LIBS as it will be extracted and copied to exts.mk.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51429 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r51428.
----------
string.c: empty non-embed case
* string.c (str_buf_cat): consider empty non-embed string case,
not to loop infinitely. [ruby-core:70074] [Bug #11383] -
- * string.c (str_buf_cat): consider empty non-embed string case,
not to loop infinitely. [ruby-core:70074] [Bug #11383]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51428 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- Athar Hussain wrote:
> I have newly installed ruby and rails in my new MAC 10.10
> ...
Hi Athar,
For some reason you have a setup that is using RVM on 2.2.1 and rbenv on 2.2.2. You might want to drop one of them and reinstall your... -
05:49 AM Bug #11403 (Rejected): Segmentation fault when running Rails Server
- I have newly installed ruby and rails in my new MAC 10.10
But when I am trying to run am rails application its showing this segmentation fault
~~~
qaz admin$ rails server
Warning: Running `gem pristine --all` to regenerate your i... -
- Applied in changeset r51427.
----------
vm_eval.c: set method_missing_reason
* vm_eval.c (send_internal): set method_missing_reason before
invoking overriding method_missing method so that the default
method_missing can achieve it ... -
- * vm_eval.c (send_internal): set method_missing_reason before
invoking overriding method_missing method so that the default
method_missing can achieve it properly.
[ruby-core:68515] [Bug #10969]
git-svn-id: svn+ssh://ci.ruby-lang.... -
- * hash.c (rb_sym_hash): return same value as rb_any_hash() of
Symbol. [Bug #9381]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51426 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * hash.c (rb_any_hash): fix Float hash. rb_dbl_hash() returns a
Fixnum, but not a long. [Bug #9381]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51425 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:32 AM Revision 8e613749 (git): * test/ruby/test_io.rb (TestIO#test_open_flag_binary): typo of method name (test method itself, and calling method).
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51424 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_hash.rb (test_wrapper_of_special_const): test
other special obejcts. [Bug #9381]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51423 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:10 AM Revision 9ca6e622 (git): open the path instead of tempfile object
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51422 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * internal.h (LIKELY, UNLIKELY): inverted conditions generate
wrong code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51421 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * internal.h (LIKELY, UNLIKELY): make a boolean to enforce 1 or 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51420 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk ($(arch)-fake.rb): read from STDIN instead of creating
version.i, to get rid of conflict with tool/update-deps.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51419 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:44 AM Revision c02ffd9a (git): * gc.c: document argument passed to finalizer proc.
- [fix GH-976][ci skip] Patch by @alexdowad
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51418 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r51416.
----------
* io.c (rb_io_extract_modeenc): add option parameter `flags'
to append extra oflags to normal mode.
[Feature #11253] [ruby-core:69539] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51417 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- to append extra oflags to normal mode.
[Feature #11253] [ruby-core:69539]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51416 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/28/2015
-
- Eric Wong <[email protected]> wrote:
> I am also working on more improvements, rb_objid_hash seems weak.
Maybe this:
http://80x24.org/spew/m/88e7b6dcf59adf35c5c292c91c54cb7b986bd4a4.txt
+ Benchmarks:
http://80x24.org/spew/m... -
- Thanks for testing. A backporter will backport it to 2.2 since this
is a regression.
I am also working on more improvements, rb_objid_hash seems weak. -
03:13 PM Bug #11396: Bad performance in ruby >= 2.2 for Hash with many symbol keys
- I can report patch is functional and seems to be working also on current ruby_2_2 branch [ruby 2.2.3p147 (2015-07-04 revision 51143)] .
What about pushing commit also to this branch ? More testing needed ?
The speed-up is drastic, te... -
- Almost are ok.
One thing in 0002-lib-net-http-response.rb-Net-HTTPResponse-Inflater.patch, use @inflate.total_in instead of @bytes_read.
After fix that, please commit them by yourself -
- Since you're using SSLSocket, I recommend dumping a backtrace when you
rescue since gets is implemented in Ruby in the OpenSSL::Buffering module
(ext/openssl/lib/openssl/buffering.rb in the Ruby source) -
- Further Testing show that this happens (less so) when Regexp is not used, as in IO.gets("\r\n\r\n")
-
- This is my code, "socket" is a SSLSocket this is why it allows a Regexp in gets
`begin
http_response[:http_headers] = WEBrick::Utils.timeout(3){
socket.gets(/\x0d?\x0a\x0d?\x0a/, 4096) #\r?\n\r?\n
}
rescue Errno::E... -
08:03 PM
Bug #11397 (Closed): rubygems tests slow after r51384
- Applied in changeset r51414.
----------
test/rubygems/test_gem_remote_fetcher.rb: pre-generate test key
OpenSSL::PKey::DH.new(2048) takes forever, and we pre-generate
test keys for other SSL-using tests anyways.
* test/rubygems/test_g... -
- Thank you Eric.
We discussed this issue today.
Your solution is good to me.
Please commit it. -
- Attached is a proposed patch to memoize the tmp_dh_callback result for RubyGems,
similar to what existing OpenSSL, DRb, Net::HTTP tests already do.
Without this patch,
make test-all TESTS='test/rubygems/ -v -j4'
Runs for seve... - 08:02 PM Revision de816650 (git): * 2015-07-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51415 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:02 PM Revision 83fc43f8 (git): test/rubygems/test_gem_remote_fetcher.rb: pre-generate test key
- OpenSSL::PKey::DH.new(2048) takes forever, and we pre-generate
test keys for other SSL-using tests anyways.
* test/rubygems/test_gem_remote_fetcher.rb: pre-generate test key
[ruby-core:70151] [Bug #11397]
git-svn-id: svn+ssh://ci.rub... -
- Occur several times:
~~~
[BUG] Segmentation fault at 0x00000000000000
ruby 2.1.4p265 (2014-10-27 revision 48166) [x86_64-darwin13.0]
-- Crash Report log information --------------------------------------------
See Crash Repor... -
- Could you report to upstream?
https://github.com/flori/json -
-
11:44 AM Bug #11401 (Closed): Net::HTTP SSL session resumption does not send SNI
- See https://github.com/ruby/ruby/pull/964
## Problem
When an initial SSL request is done, Net::HTTP stores the OpenSSL::SSL::Session object in @ssl_session.
When (after the http-keep-alive timeout has expired, or the connection ... -
09:22 AM Bug #11399 (Rejected): Regexp's free-spacing mode adding whitespace to character classes
- The *free-spacing* mode (x-option) does not ignore whitespace within character classes:
~~~
r = /[a
# comment
b]/x
" \nab".scan(r)
#=> [" ", "\n", "a", "b"]
~~~
I would expect a regular expression that's equivalent to `/[... -
07:57 AM Feature #11398: deprecate constants
- It seems a good idea, for example, we have TimeoutError (instead of Timeout::Error).
Matz.
-
- Sometimes old constants are deprecated but still remained for backward compatibilities.
It is not noticed and will be kept forever, with no warnings, though.
So I propose a method `Module#deprecate_constant` to mark a constant obsolete... -
- It changes the concept of private methods a little. It's OK to merge the patch if the document is updated at the same time..
Matz.
-
- It looks good to me.
Matz.
-
- It looks good to me.
Matz.
-
02:16 AM Bug #9244: unexpected behaviour of 'require' when $LOAD_PATH gets changed
- ~~~
$ ruby -v
ruby 2.1.6p336 (2015-04-13 revision 50298) [x86_64-darwin14.0]
$ cat test.rb
$LOAD_PATH.unshift File.join(Dir.pwd, 'a')
require 'test.rb'
$LOAD_PATH.unshift File.join(Dir.pwd, 'b')
require 'test.rb'
$ ruby te... -
- * internal.h (struct RClass): moved from ruby/ruby.h to hide the
internals.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51413 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/27/2015
-
- * configure.in (RUBY_TYPE_ATTRIBUTE): attribute declaration for
types.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51412 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/test/unit.rb (Test::Unit::Parallel::Worker#died): show
terminated signal when a worker died.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51411 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thanks for testing, committed as r51410 and 2.2 backport requested.
The only downside is slightly increased dynamic symbol registration
time because of the redundant call to rb_str_hash, but I doubt anybody
would notice. There's n... -
10:26 PM
Bug #11396 (Closed): Bad performance in ruby >= 2.2 for Hash with many symbol keys
- Applied in changeset r51410.
----------
symbol.h: memoize hashval for RSymbol
This speeds up the hash function for dynamic symbols.
[ruby-core:70129] [Bug #11396], nearly up to Ruby 2.1 levels
Power-of-two hash sizing [Feature #9425] ... -
07:51 PM Bug #11396: Bad performance in ruby >= 2.2 for Hash with many symbol keys
- Eric Wong wrote:
> Possible fix is to memoize hashval inside struct RSymbol:
> ...
Hi Eric, I compiled the ruby_2_2 branch with your patch and got the following results
ruby 2.1.6p336 (2015-04-13 revision 50298) [x86_64-darwin14.0]
... -
- Possible fix is to memoize hashval inside struct RSymbol:
http://80x24.org/spew/m/[email protected]
Much better than before, but still slower than 2.1, I think.
Only lightly-tested, and on hardwa... - 10:25 PM Revision 442b77e7 (git): symbol.h: memoize hashval for RSymbol
- This speeds up the hash function for dynamic symbols.
[ruby-core:70129] [Bug #11396], nearly up to Ruby 2.1 levels
Power-of-two hash sizing [Feature #9425] speeds up cases where we
have a good hash, but this means we can no longer hide ... -
08:52 PM Bug #11048: blocks raise on missing and extra keyword args
- another use case for this is hash destructuring
```
array_of_hashes.each do |key1:, key2:|
end
```
it would be much better if this code did not raise on extra or missing keys, otherwise this type of destructuring is almost compl... -
06:29 PM
Bug #10910 (Closed): NoMethodError when opening SSL connection with OpenSSL::SSL::VERIFY_PEER set and anonymous ciphers allowed
- Applied in changeset r51409.
----------
* ext/openssl/lib/openssl/ssl.rb (module OpenSSL): raise a more
helpful exception when verifying the peer connection and an
anonymous cipher has been selected. [ruby-core:68330] [Bug #10910]
... -
- helpful exception when verifying the peer connection and an
anonymous cipher has been selected. [ruby-core:68330] [Bug #10910]
Thanks to Chris Sinjakli <[email protected]> for the patch.
* test/openssl/test_ssl.rb (class OpenSSL)... - 03:18 PM Revision 6d98fba2 (git): * 2015-07-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51408 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:17 PM Revision 41b6c0aa (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51407 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51406 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/lib/test/unit.rb (MiniTest::Unit::TestCase.test_order): get
rid of warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51405 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/test/unit.rb (setup_options): add --test-order option
to override the test order.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51404 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:25 AM Revision 747b7b73 (git): * template/id.h.tmpl (ID2ATTRSET): remove an unused macro.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51403 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/fiddle/depend (distclean-libffi): clean dot directory too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51402 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/fiddle/extconf.rb: use LIBFFI_DIR instead of expanding it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51401 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (distclean-local): clean preludes in the build
diretory, not by realclean.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51400 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (clean, distclean): clean local files before platform
directory, some files may exist there.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51399 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (clean-local): remove added files and a directory.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51398 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:22 AM Revision 08be34a9 (git): commit miss
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51397 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:21 AM Revision f294fe3d (git): * test/openssl/tset_ssl.rb: run tests on non-Unix platforms.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51396 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/io/console/extconf.rb: fix typo, $nmake is "m" for MS, not
"n". check sys/ioctl.h iff necessary for tty.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51395 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:56 AM Revision cf337a62 (git): * 2015-07-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51394 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * win32/Makefile.sub (clean-ext): fix usage of for /R, and adjust
messages as other platforms.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51393 b2dd03c8-39d4-4d8f-98ff-823fe69b080e