Activity
From 06/17/2017 to 06/23/2017
06/23/2017
-
09:28 PM Bug #11033: OpenSSL related threading issues in Ruby 2.1 and 2.2
- Thank you @rhenium - I had not realized that openssl is packaged differently for Ruby 2.4
I have a pull request op... -
08:59 PM Misc #13673 (Closed): minor correction to Queue docs
- Applied in changeset trunk|r59165.
----------
thread_sync.c: fix documentation for Queue#close
When Queue#closed? i... -
09:59 AM Misc #13673 (Closed): minor correction to Queue docs
- When Queue#closed? is true, using push/enq/<< will raise an exception. Not return nil.
- 08:59 PM Revision b11350d6 (git): thread_sync.c: fix documentation for Queue#close
- When Queue#closed? is true, using push/enq/<< will raise an
exception, and not return nil.
* thread_sync.c: fix docu... -
04:51 PM Feature #13677 (Feedback): Add more details to error "Name or service not known (SocketError)"
- ruby version: `ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux]`
ruby script:
~~~ ruby
require 'socket'... -
03:57 PM Bug #13675: Should Zlib::GzipReader#ungetc accept nil?
- I like symmetry. :)
-
12:42 PM Bug #13675 (Closed): Should Zlib::GzipReader#ungetc accept nil?
- IO#ungetc accepts nil and just does nothing:
p File.new(__FILE__).ungetc(nil)
But on a GzipReader it fails:... -
03:55 PM Feature #13676: to_s method is not overriden for Set
- I have no pro or con opinion. I did however had want to compare Set to Array and the two behave differently.
```ru... -
01:57 PM Feature #13676: to_s method is not overriden for Set
- > What do you want to do?
> If you want a list of the elements, use to_a.
> If you want to see what elements it has... -
01:47 PM Feature #13676: to_s method is not overriden for Set
- nobu (Nobuyoshi Nakada) wrote:
> What do you want to do?
> If you want a list of the elements, use `to_a`.
> If yo... -
01:17 PM Feature #13676 (Feedback): to_s method is not overriden for Set
- What do you want to do?
If you want a list of the elements, use `to_a`.
If you want to see what elements it has, us... -
01:09 PM Feature #13676 (Closed): to_s method is not overriden for Set
- When I call
~~~ ruby
s1 = Set.new
s1<<'tic'<<'tac'
s1.to_s
~~~
I'd expect ['tic', 'tac'] values being print... - 03:08 PM Revision 88c3bc2c (git): * 2017-06-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59164 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:08 PM Revision ebf1da9d (git): test_command_processor.rb: add suffix
- * test/shell/test_command_processor.rb (test_option_type): Windows
needs a suffix to execute.
git-svn-id: svn+ssh:... -
12:21 PM Bug #13674 (Closed): BigDecimal comparison with Float::INFINITY is erroneous in 2.2.x and 2.3.x
- BigDecimal("-0.2E5556") > -Float::INFINITY
returns wrong results in MRI 2.2.x and 2.3.x:
for ruby in 2.... -
11:56 AM Revision af4ba5c1 (git): parse.y: should not warn op method call
- * parse.y (void_expr_gen): should warn operator expression style
calls only, but not method style calls. [Fix GH-1... -
11:47 AM Bug #13663: `String#upto` doesn't work as expected
- I'm not asking for consistency between `String#succ` and `String#<=>` (although that would be desirable). I do unders...
-
11:20 AM Bug #13672 (Closed): Garbage input hangs ruby (not responding ^C)
- Applied in changeset trunk|r59161.
----------
parse.y: check multibyte char
* parse.y (parser_precise_mbclen): chec... -
08:30 AM Bug #13672 (Closed): Garbage input hangs ruby (not responding ^C)
- Passing the attached file makes hang.
```
ruby hang.rb
``` -
11:20 AM Revision d3916973 (git): parse.y: check multibyte char
- * parse.y (parser_precise_mbclen): check invalid multibyte char at
skipping strings following `?x` literal string, ... -
11:15 AM Revision f61e8084 (git): vm_core.h: sandwich jmpbuf
- * vm_core.h (rb_vm_tag): move jmpbuf which should be stored at the
last in TH_PUSH_TAG, between tag and state so en... -
09:43 AM Revision 4a4627fb (git): move "state" to rb_vm_tag.
- * vm_core.h (rb_thread_t::tag_state): move to "rb_vm_tag::state".
Lifetime of "state" should be same as current tag... -
08:49 AM Bug #13671: Regexp with lookbehind and case-insensitivity raises RegexpError only on strings with certain characters
- did some checks on my windows system to check how deep the problem is.
i used "ä" as variable.
the same problem h... -
08:48 AM Revision a64801c1 (git): rename th->state to th->tag_state.
- * vm_core.h (rb_thread_t): rename rb_thread_t::state to tag_state
to make it clear.
git-svn-id: svn+ssh://ci.ruby... -
08:48 AM Bug #13155: Segfault testing Pry
- This was triggered again during automatic rebuild of Fedora's Pry package
https://apps.fedoraproject.org/koschei/b... -
08:24 AM Revision a90c696b (git): rb_catch_protect() accepts enum ruby_tag_type *.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59157 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:53 AM Revision 769ef81a (git): thread.c: suppress warning
- * thread.c (exec_recursive): rb_catch_protect() uses `int*` as
well as rb_protect.
git-svn-id: svn+ssh://ci.ruby-l... -
07:25 AM Revision 2108e55c (git): use "enum ruby_tag_type" and TAG_NONE.
- Return value of EXEC_TAG() is saved by "int state".
Instead of "int", use "enum ruby_tag_type". First EXEC_TAG()
valu... -
05:55 AM Revision 1d248f04 (git): use NULL instead of 0.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59154 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:52 AM Revision 931cc441 (git): skip on other threads (again).
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:50 AM Revision 23206859 (git): revert r59151 which introduce failures.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59152 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:45 AM Revision 25566b05 (git): skip on other threads.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59151 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:20 AM Feature #2631: Allow IO#reopen to take a block
- It was thoughtless. Let me revert it.
-
03:38 AM Feature #2631 (Assigned): Allow IO#reopen to take a block
-
03:38 AM Feature #2631 (Closed): Allow IO#reopen to take a block
-
04:19 AM Revision 2fd3a2e2 (git): Revert "Allow IO#reopen to take a block"
- This reverts r59142.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:43 AM Revision 02fa3456 (git): vm_insnhelper.c: vm_stack_consistency_error
- * vm_insnhelper.c (vm_stack_consistency_error): extracted from
insns.def for further info in the future.
git-svn-i... - 12:29 AM Revision 83d1fdee (git): * 2017-06-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59148 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:29 AM Revision 6dc924b6 (git): refinements.rdoc: [DOC] improved [Fix GH-1659]
- * doc/syntax/refinements.rdocrefinements.rdoc: grammatical
correction and code highlighting improved
* doc/syntax/...
06/22/2017
-
11:28 PM Bug #13671 (Assigned): Regexp with lookbehind and case-insensitivity raises RegexpError only on strings with certain characters
- Here is a test program:
~~~ ruby
def test(description)
begin
yield
puts "#{description} is OK"
re... -
06:02 PM Bug #13670 (Closed): [BUG] Bus Error at 0xefce7b (armv7l) (ruby 2.3.4p301)
- On using the library bootsnap the error occurred (see attachment). The developer of the library suggested to report t...
-
12:53 PM Revision ae6ebbb3 (git): fix mortal_dynamic_symbol count
- * test/objspace/test_objspace.rb (test_count_symbols): exclude a
dynamic symbol which has been turned into immortal... -
10:56 AM Revision b906f788 (git): Fix exception type in option type checker
- * lib/shell/system-command.rb (SystemCommand#initialize):
`def_e2message` wraps error message, but does not define ... -
08:37 AM Revision eb3ca699 (git): use --dump option for parse rule.
- * common.mk: use --dump=--dump=parsetree_with_comment,insns
instead of tool/parse.rb. maybe nobody use this option ... -
08:35 AM Feature #2631 (Open): Allow IO#reopen to take a block
- 匿名ユーザー wrote:
> Applied in changeset trunk|r59142.
>
> ----------
> Allow IO#reopen to take a block
>
> * io.... -
06:50 AM Feature #2631 (Closed): Allow IO#reopen to take a block
- Applied in changeset trunk|r59142.
----------
Allow IO#reopen to take a block
* io.c (rb_io_reopen): take a block a... -
08:33 AM Revision dc44df8a (git): try to fix symbol duplication.
- * test/objspace/test_objspace.rb (test_count_symbols): make more complex dynamic
symbols to avoid conflict with oth... -
07:51 AM Feature #9145: Queue#pop(true) return nil if empty instead of raising ThreadError
- [email protected] wrote:
> Issue #9145 has been updated by Glass_saga (Masaki Matsushita).
>
> Status changed... -
07:23 AM Feature #9145 (Closed): Queue#pop(true) return nil if empty instead of raising ThreadError
- Currently, Queue#pop takes non_block flag.
-
07:01 AM Feature #6129 (Closed): String#each_lineにおけるmemmem()の利用
- trunkでは既にrb_memsearch()を利用するようになっているため、このチケットは閉じます。
-
06:50 AM Revision f1b7003f (git): Allow IO#reopen to take a block
- * io.c (rb_io_reopen): take a block and ensure the IO closed
[Feature #2631]
* test/ruby/test_io.rb: add a test
*... - 06:42 AM Revision 2a46ba94 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:42 AM Revision de2ae27b (git): introduce heap_allocatable_pages_set().
- * gc.c (heap_allocatable_pages_set): added. This function set
heap_allocatable_pages and sorted_list atomically.
... -
05:51 AM Revision a48fecd3 (git): catch up frozen_string_literal: true.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59139 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:03 AM Revision f736cf32 (git): introduce GC_ASSERT().
- * gc.c (GC_ASSERT()): added. GC_ASSERT() is similar to VM_ASSERT in
vm_core.h but turn on by RGENGC_CHECK_MODE.
g... -
01:18 AM Feature #12733: Bundle bundler to ruby core
- > the test suite also needs connection to internet to succeed
The Bundler test suite no longer requires an interne... -
01:00 AM Bug #12670 (Closed): Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- Applied in changeset trunk|r59136.
----------
gc.c: expand sorted pages
* gc.c (heap_page_allocate): expand sorted ... - 12:59 AM Revision d0b8fa73 (git): * 2017-06-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59137 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:59 AM Revision 7a1c10ba (git): gc.c: expand sorted pages
- * gc.c (heap_page_allocate): expand sorted pages before inserting
allocated new page. [Bug #12670]
git-svn-id: sv...
06/21/2017
-
12:51 PM Revision ea57d846 (git): gc.c: FL_CHECK2
- * gc.c (FL_TEST2, FL_SET2, FL_UNSET2): make error messages
consitent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
10:06 AM Revision 5dc1055a (git): * NEWS: Fix typo.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59134 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:42 AM Feature #13665: String#delete_suffix
- I think the method's functionality is good to have.
-
07:43 AM Feature #12694 (Closed): Want a String method to remove heading substr
- Applied in changeset trunk|r59132.
----------
string.c: add String#delete_prefix and String#delete_prefix!
to remove... -
07:43 AM Revision 0d036505 (git): test/ruby/test_string.rb: add tests to chomp substr
- * test/ruby/test_string.rb (TestString#test_chomp): add tests
to chomp substr
* test/ruby/test_string.rb (TestStri... -
07:43 AM Revision 10082360 (git): string.c: add String#delete_prefix and String#delete_prefix!
- to remove leading substr [Feature #12694] [fix GH-1632]
* string.c (rb_str_delete_prefix_bang): add a new method
t... -
04:34 AM Revision 6af65025 (git): RUBY_DEVEL flag
- * configure.in: define RUBY_DEVEL only in the trunk.
* gc.c: enable runtime rgengc debug if RUBY_DEVEL
* ruby.c (de... -
03:27 AM Revision 5682bfe2 (git): configure.in: use AS_IF
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59130 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:44 AM Revision 793f5d8f (git): ruby.c: debug options in command line
- * ruby.c (debug_option): parse options in --debug command line
option same as RUBY_DEBUG env. available only in th... -
02:25 AM Bug #13669 (Closed): Enumerable#uniq is ignoring second and following block arguments
- Applied in changeset trunk|r59128.
----------
Fix Enumerable#uniq with non single yield arguments
* enum.c (uniq_fu... -
02:25 AM Revision 9cacc53d (git): Fix Enumerable#uniq with non single yield arguments
- * enum.c (uniq_func, uniq_iter): need packed value as the unique
key. [ruby-core:81734] [Bug #13669] [Fix GH-1658]... -
02:03 AM Revision 5eec76bc (git): KNOWNBUGS.rb: hung up on linux
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59127 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:34 AM Revision ed908e5c (git): KNOWNBUGS.rb: deferred free
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59126 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:34 AM Revision 477d1159 (git): bootstraptest/runner.rb: keyword argument
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59125 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
06/20/2017
-
07:17 PM Bug #13669 (Closed): Enumerable#uniq is ignoring second and following block arguments
- github: https://github.com/ruby/ruby/pull/1658
```ruby
enum = Object.new.to_enum
class << enum
def each
... -
07:11 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- [email protected] wrote:
> I appreciate what you said about multi-thread multi-fiber
> execution using your... - 03:23 PM Revision 1530dce8 (git): * 2017-06-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59124 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:23 PM Revision 6f199eb8 (git): Use a file under tmp for File.real{,dir}path specs on Windows
- * The source file path could have pre-existing symlinks.
* See https://github.com/ruby/spec/issues/445.
git-svn-id: ... -
11:43 AM Revision 8ae9de37 (git): Fixed missing handling for frozen object at r59121.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59122 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:10 AM Revision d5f86e83 (git): Specify frozen_string_literal: true.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59121 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:23 AM Revision b589c478 (git): gc.c: add newline to report [ci skip]
- * gc.c (gc_sweep_finish): gc_report format should end with a
newline, as gc_report_body does not append it.
git-sv... -
05:51 AM Feature #13434: better method definition in C API
- [email protected] wrote:
> I don't like "mini-language" which needs a parser.
OK, what about an API similar to ... - 05:34 AM Revision 90846d7f (git): * 2017-06-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59119 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:34 AM Revision 4d932a68 (git): skip unresolved issue.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59118 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:30 AM Feature #13668 (Third Party's Issue): Show / log test-all skips in CI here or at http://rubyci.org/ ?
- Maybe consideration could be given to having CI here or at http://rubyci.org/ show/log skips. Skip logs led me to an...
-
12:08 AM Feature #13667 (Assigned): Add Coverage.running? to quickly check if Coverage is enabled.
06/19/2017
-
10:46 PM Feature #13657: Simplify usage of Enumerable#reject
- I guess this request is a variant of https://bugs.ruby-lang.org/issues/11286 (if not identical). You would like to jo...
-
03:28 PM Feature #13657: Simplify usage of Enumerable#reject
- Great! You're right, that will accomplish this _exactly_.
Do you see any hope in adding this functionality to `#re... -
10:32 PM Feature #11105: ES6-like hash literals
- +1
While it might be odd or new for some, using this in ES6 has been very nice. I am often wishing this was suppo... -
07:39 PM Feature #13667 (Closed): Add Coverage.running? to quickly check if Coverage is enabled.
- Since we can't `RubyVM::InstructionSequence#to_binary` when `Coverage` is running, it is useful to be able to ask rub...
-
03:37 PM Bug #11033: OpenSSL related threading issues in Ruby 2.1 and 2.2
- rhenium (Kazuki Yamaguchi) wrote:
> 2.3 stable maintainer: I've attached a patch that applies on top of ruby_2_3.
... -
03:26 PM Bug #11033: OpenSSL related threading issues in Ruby 2.1 and 2.2
- Now that openssl is a default gem, you can just update it before running 'bundle install':
gem install openssl... -
01:41 PM Bug #11033: OpenSSL related threading issues in Ruby 2.1 and 2.2
- This ticket is marked as closed - but I only see OpenSSL 2.0.4 in the trunk branch on GitHub per https://github.com/r...
-
02:40 PM Bug #12670 (Assigned): Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
-
02:36 PM Bug #12670 (Closed): Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- Applied in changeset trunk|r59116.
----------
test for [Bug #12670]
heap corruption by deferred free. -
02:36 PM Revision 22c8dcff (git): debug.c: rgengc debug option
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59117 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:36 PM Revision 263a0f7f (git): test for [Bug #12670]
- heap corruption by deferred free.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59116 b2dd03c8-39d4-4d8f-98ff-82... -
01:17 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- Ruby Fibers as they currently stand are perfect and making them more complex is a mistake IMHO.
Let's be clear on ... -
01:03 PM Revision 0a907a37 (git): Make string literal to frozen object on gemspec of defulte gems.
- Added following gemspecs.
* extensions: date, dbm, etc, fiddle, gdbm, sdbm, stringio, strscan, zlib
* pure r... -
01:02 PM Bug #13591: spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ']
- Fixed in r59113.
I split the spec to only include cases that seem to work on Windows according Greg's tests.
This t... -
01:00 PM Bug #13591 (Closed): spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ']
- Applied in changeset trunk|r59113.
----------
Adapt Time#zone spec to deal with differences of TZ validation on Wind... - 01:00 PM Revision 79f85571 (git): * 2017-06-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59114 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:00 PM Revision d404e271 (git): Adapt Time#zone spec to deal with differences of TZ validation on Windows
- * [Bug #13591] [ruby-core:81347]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59113 b2dd03c8-39d4-4d8f-98ff-823... -
10:19 AM Feature #13666 (Closed): Development: Writing test code for new features/bug fixes can be done as specs under spec/rubyspec instead of tests under test/
- Dear CRuby committers,
I would like to reach an agreement with the ruby core team on a subject that was once highl... -
08:34 AM Bug #13635: ruby and linux-pf or linux-zen kernels
- allencch (Allen Choong) wrote:
> I have similar issue to compile ruby-2.3.3 on Arch Linux lts.
>
> For the OpenSS... -
08:34 AM Bug #13635: ruby and linux-pf or linux-zen kernels
- nobu (Nobuyoshi Nakada) wrote:
> Try more recent versions, 2.3.4, 2.4.1, and the trunk if possible.
So, the ruby ...
06/18/2017
-
04:38 AM Revision f5052d45 (git): string.c: check just before modification
- * string.c (rb_str_chomp_bang): check if modifiable after checking
an argument and just before modification, as it ... -
04:29 AM Revision 80aa1e62 (git): test_string.rb: chomp! frozen string
- * test/ruby/test_string.rb (TestString#test_chomp): should raise
if frozen.
git-svn-id: svn+ssh://ci.ruby-lang.org... -
04:29 AM Revision b89367d6 (git): test/unit.rb: close jobserver
- * test/lib/test/unit.rb (Test::Unit::Parallel#flush_job_tokens):
close jobserver auth fds aflter flush, not to rel... -
01:15 AM Revision bc08e666 (git): capi/spec_helper.rb: suppress logo
- * spec/rubyspec/optional/capi/spec_helper.rb (compile_extension):
suppress logo of nmake.exe to stderr. we want to... - 01:15 AM Revision de4f844b (git): * 2017-06-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59108 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:15 AM Revision d4aad43f (git): appveyor.yml: num of jobs
- * appveyor.yml (test_script): stop running too many workers to get
rid of sporadic NoMemoryError.
git-svn-id: svn+...
06/17/2017
-
12:18 AM Revision 3947382b (git): capi/spec_helper.rb: pass jobserver fds
- * spec/mspec/lib/mspec/commands/mspec.rb (MSpecMain#multi_exec):
do not close GNU make jobserver auth fds.
* spec/... -
12:10 AM Revision 0955d910 (git): capi/spec_helper.rb: use MAKE env
- * spec/rubyspec/optional/capi/spec_helper.rb (compile_extension):
prefer MAKE environment variable to hardcoded nam...
Also available in: Atom