Activity
From 12/22/2017 to 12/28/2017
12/28/2017
-
11:11 PM Bug #14257 (Closed): the chomp option removes newlines in additon to the provided separator for String#each_line and String#lines
- I'm not entirely sure this is a bug but I had a hard time finding anything that indicated that the change was on purpose.
The `chomp` option would remove the provided separator from each line. Now it does that and it also removes newl... -
10:45 PM Feature #14022: String#surround
- > But for this really frequent case surround() still feels more elegant.
Agreed. It is not so frequent for my case, to be honest; but I like
the use case that sawa described since that is similar to ones I
experienced too, in regard... -
10:31 PM Feature #14235: Merge MJIT infrastructure with conservative JIT compiler
- Eregon (Benoit Daloze) wrote:
> Merging the MJIT infrastructure means choosing MJIT as the MRI JIT, right?
Taking a closer look at the PR, it seems mostly infrastructure for a MJIT-like JIT.
On the other hand, mjit_compile.c is co... -
- Should the performance of MJIT be evaluated in more details before merging?
Merging the MJIT infrastructure means choosing MJIT as the MRI JIT, right?
If so, it would be good to have performance numbers on other larger benchmarks, no... -
08:09 PM Feature #14250 (Closed): Make `$SAFE` process global state and allow to set 0 again
- Applied in changeset trunk|r61510.
----------
`$SAFE` as a process global state. [Feature #14250]
* vm_core.h (rb_vm_t): move `rb_execution_context_t::safe_level` to
`rb_vm_t::safe_level_` because `$SAFE` is a process (VM) global sta... -
02:32 AM Feature #14250: Make `$SAFE` process global state and allow to set 0 again
- FYI: by using [gem-codesearch](https://github.com/akr/gem-codesearch), I have briefly searched the gems using $SAFE:
```
$ csearch -f '.*\.rb' '^\s*[^\s#].*\$SAFE *=' | wc -l
147
```
Much less than I thought... The full list is... - 08:09 PM Revision ccbd6ee5 (git): * 2017-12-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61511 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_core.h (rb_vm_t): move `rb_execution_context_t::safe_level` to
`rb_vm_t::safe_level_` because `$SAFE` is a process (VM) global state.
* vm_core.h (rb_proc_t): remove `rb_proc_t::safe_level` because `Proc`
objects don't need to ... -
04:40 PM Bug #13774: for methods defined from procs, the binding of the resulting bound_method.to_proc does not have access to the original proc's closure environment
- nobu (Nobuyoshi Nakada) wrote:
> I think it is not a bug.
> ...
You are accessing a local variable in the method (which does not exist until the method is invoked), whereas I am accessing a variable outside the method, captured by the ... -
08:21 AM Bug #13774: for methods defined from procs, the binding of the resulting bound_method.to_proc does not have access to the original proc's closure environment
- I think it is not a bug.
Local variables are not set up in the context of a binding from a method.
```ruby
$ ruby -e 'def m(v=12);v;end; p method(:m).to_proc.binding.eval("v")'
Traceback (most recent call last):
2: from -e:1:in... -
- * proc.c (proc_binding): unified the name and realpath of an empty
iseq.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61509 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:53 AM Feature #14255 (Closed): Deprecate $SAFE support in ERB
- Changed from ruby-dev to ruby-core https://bugs.ruby-lang.org/issues/14256
-
- See https://bugs.ruby-lang.org/issues/14250.
Proc-level $SAFE change does no longer make sense. This should be deprecated and then removed. But the problem is that the position of safe_level argument is in the middle of argument list ... -
- See https://bugs.ruby-lang.org/issues/14250.
Proc-level $SAFE change does no longer make sense. This should be deprecated and then removed. But the problem is that the position of safe_level argument is in the middle of argument list ... -
- (r59497).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61508 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:27 AM Bug #14254 (Closed): vagrant add box not working
- i tried running the following command (vagrant box add centos65-base centos65.box) but encountered the error below. I have reinstall Vagrant, VirtualBox and Ruby but no success. Any help would be really useful.
λ vagrant box add cento... -
03:05 AM Bug #14252: Refined Method Visibility Lost with Dynamic Dispatch and Reflection
- I, personally, do not care so much about the reflection APIs, as I was just using them to confirm what I thought was happening, but I would like to at least see `Kernel#public_send` act similarly to `Kernel#send`, so I think it makes sen...
-
02:28 AM Bug #14252: Refined Method Visibility Lost with Dynamic Dispatch and Reflection
- sonnym (Sonny Michaud) wrote:
> This works perfectly well for the static `Protected.print` call, but has a number of surprises when trying to do anything more advanced. Namely:
> ...
Reflection APIs do not honor refinements.
If you b... -
- Consider the following simple objects, one with a protected class method and another with a public class method calling on the protected method. This is accomplished using a refinement that marks the method as public on the singleton cl...
-
03:01 AM Bug #14251 (Rejected): String insert changing value of other string
- This behavior is expected. Except for purely functional programming languages, the difference between references and values is important to understand in every programming language, even if at first, it may be surprising.
-
12:58 AM Bug #14251: String insert changing value of other string
- I advise you to put this “issues” you find as questions in ruby talk before opening ruby core bugs.
In ruby objects are mutable and passed by reference.
When you do `bar = bar + 'ccc'`
you are allocating a new reference to bar obj... -
12:47 AM Bug #14251: String insert changing value of other string
- Because if you do
~~~ ruby
foo = 'aaa'
bar = foo
bar = bar + 'ccc' #here references of foo doesn't changes
puts foo #aaa
pubs bar #aaaccc
~~~
As I can see, ruby only for string as reference when I call string methods, like:... -
02:55 AM Bug #14253 (Closed): CSV.generate doesn't wrap a string anymore
- linking with: https://github.com/ruby/csv/pull/13/files
-
12:00 AM
Bug #14247 (Closed): Thread#fetch raise KeyError without key and receiver
- Applied in changeset trunk|r61507.
----------
Fix KeyError#{key,receiver} of Thread#fetch
[ruby-core:84508] [Bug #14247] -
12:00 AM Revision 220d2a71 (git): Fix KeyError#{key,receiver} of Thread#fetch
- [ruby-core:84508] [Bug #14247]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61507 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/27/2017
-
- Here is a blog entry that may be useful for ricardo:
https://aaronlasseigne.com/2014/07/20/know-ruby-clone-and-dup/ -
11:19 PM Bug #14251: String insert changing value of other string
- All Ruby variables are by-reference. To create a new object, use #dup
~~~ruby
foo = 'abc'
bar = foo.dup
bar.insert(1, 'd')
~~~
-
- ~~~ ruby
foo = 'abc'
bar = foo
bar.insert(1, d)
puts foo 'adbc'
puts bar 'adbc'
~~~
The example above should only affect bar variable. It leads to an error by programmer.
A bypass that I found is to do:
~~~ ruby
foo = '... -
11:51 PM Bug #14219: package size of Ruby 2.5 is larger than 2.4
- [email protected] wrote:
> Could someone remove spec/rubyspec in SVN? (it's still present in the 2.5.0 tarball)
Done in r61506
> I did a "git mv" if I recall correctly, but it seems git-svn did not handle this case correctly.
... -
- Could someone remove spec/rubyspec in SVN? (it's still present in the 2.5.0 tarball)
I did a "git mv" if I recall correctly, but it seems git-svn did not handle this case correctly.
I think it makes sense to keep spec/mspec and spec/... -
- [email protected] wrote:
> Issue #14225 has been updated by Eregon (Benoit Daloze).
>
>
> I think we should remove tainting as a whole along with $SAFE.
Agreed.
> Untainting automatically seems bad practice and counter-intu... -
- I think we should remove tainting as a whole along with $SAFE.
Untainting automatically seems bad practice and counter-intuitive. - 11:40 PM Revision 5b94fc96 (git): remove empty spec/rubyspec directory
- * spec/rubyspec: remove empty directory trees
[ruby-core:84533]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61506 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61505 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > Leaving aside the issue of semantics for a moment, can anyone provide a real, concrete example of a situation where symbols could not trivially be replaced with strings without negatively impacting the functionality of the surrounding ...
-
08:28 PM Feature #7792: Make symbols and strings the same thing
- Leaving aside the issue of semantics for a moment, can anyone provide a real, concrete example of a situation where symbols could not trivially be replaced with strings without negatively impacting the functionality of the surrounding co...
-
- > I think it's far more common to use symbols correctly than incorrectly. The only time I see confusion is when using things like HashWithIndifferentAccess.
Let me give you just this example to show you how things are out of control:
... -
05:35 PM Feature #7792: Make symbols and strings the same thing
- dsferreira (Daniel Ferreira) wrote:
> > But Strings and Symbols represent different concepts and should be treated differently.
> ...
I think it's far more common to use symbols correctly than incorrectly. The only time I see confusio... -
- [email protected] wrote:
> Could MRI simply use the self-pipe trick or similar internally, and execute signal handlers on the main thread by using Ruby's interrupts? (RUBY_VM_CHECK_INTS)
> A bit like Thread#raise except it would exec... -
- Could MRI simply use the self-pipe trick or similar internally, and execute signal handlers on the main thread by using Ruby's interrupts? (RUBY_VM_CHECK_INTS)
A bit like Thread#raise except it would execute the signal handler instead o... -
08:00 PM Bug #14248: configure fails to detect fd_mask type on OS X
- Would you mind back porting the fix to the 2.5 branch?
-
- Applied in changeset trunk|r61500.
----------
fix fd mask detection on os x
This was broken in r59440 (3215b27a9abd8de793cf517f32d8901fd421eb1c)
[Bug #14248]
From: Stefan Kaes <[email protected]> -
- Proposed patch:
https://github.com/skaes/rvm-patchsets/blob/master/patches/ruby/2.5.0/railsexpress/04-fix-fd-mask-detection-on-os-x.patch -
- When running configure on trunk and/or 2.5.0, configure fails to detect that the type fd_mask exists.
As a consequence, HAVE_RB_FD_INIT gets no set to 1, which leads to rb_fdset_t not being defined.
The bug was introduced with this... -
- Can not comment on $SAFE but I personally have not used $SAFE so far in
like +10 years or so. I can only remember the pickaxe mentioning it, but
I have not used it in any of my ruby code.
A bit off-topic but does anyone remember if ... -
- `$SAFE > 1` is removed from Ruby 2.3 and there are some opinion to remove `$SAFE` feature ([Feature #5455]).
There are several reason, but the biggest reason I think is nobody use `$SAFE` correctly.
Also current `$SAFE` is thread/pro... -
- Indeed. I actually had to look twice to see the error. :)
-
- Update patch.
```
% ruby -e 'th=Thread.current;th[:foo]=1;th.fetch(:fooo)'
Traceback (most recent call last):
1: from -e:1:in `<main>'
-e:1:in `fetch': key not found: :fooo (KeyError)
Did you mean? :foo
% ruby -e 'th=Th... -
- The given key is `:fooo` symbol, so the message should be `:fooo` but not `"fooo"`.
Use `"%+"PRIsVALUE` instead of `"\"%"PRIsVALUE"\""` for inspection. -
- I found this by message without `Did you mean?`.
expected:
```
% ruby -e 'th=Thread.current;th[:foo]=1;th.fetch(:fooo)'
Traceback (most recent call last):
1: from -e:1:in `<main>'
-e:1:in `fetch': key not found: "fooo" ... -
- ```ruby
def foo
o = Object.new
local_var = 'has access to captured variable'
original_proc = ->{local_var}
o.define_singleton_method(:method_from_proc, &original_proc)
method_proc = o.method(:method_from_proc).to_... -
04:14 PM Bug #14243: Comments inside ERB tags broken
- Thank you for reverting even though previous behavior was not 100% "correct".
-
- As I don't have strong motivation to change the behavior, I fixed the behavior to be the same as Ruby 2.4 in r61497. Please use "<%#" for Ruby 2.5.0 and wait for Ruby 2.5.1.
-
- Applied in changeset trunk|r61497.
----------
erb.rb: preserve the behavior for invalid syntax
comment. Fix regression at r58948.
I even don't want to deprecate it because deprecation needs to lex all
embedded Ruby script using Ripper... -
-
- [email protected] wrote:
> Status changed from Assigned to Rejected
>
> https://github.com/ruby/ruby/commit/abbfc048c5890e8017360bbc845062ea1585e155#diff-e1ea8366d3ac334deab7e0d25309be03 does trigger this behavior, but ERB does ... -
- https://github.com/ruby/ruby/commit/abbfc048c5890e8017360bbc845062ea1585e155#diff-e1ea8366d3ac334deab7e0d25309be03 does trigger this behavior, but ERB does not support "<% #" syntax. Do you think the code generated at "Before:" is correc...
-
12:05 AM Bug #14243 (Assigned): Comments inside ERB tags broken
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61504 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:12 PM Feature #14249: Remove str[match_str]
- Use Hash#dig instead.
-
01:17 PM Feature #14249 (Open): Remove str[match_str]
- I wonder if `str[match_str]` makes sense.
``` Ruby
"ana"['a'] => "a"
```
I would say this is not expected and it brings problems, for example when accessing nested hashes. For example:
``` Ruby
params = { "user" => "Nicolas... - 04:12 PM Revision 0f989b87 (git): * 2017-12-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61503 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61502 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/rubygems/test_require.rb (test_concurrent_require):
Synchronizations should be in ensure clause. Sometimes
`require` fails (not sure why) and latch is not released.
Such case introduces unlimited awaiting.
This patch solev... -
- This was broken in r59440 (3215b27a9abd8de793cf517f32d8901fd421eb1c)
[Bug #14248]
From: Stefan Kaes <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61500 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- on the end of retry failure.
Fixed mistake in r61498
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61499 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- because it's randomly failing on CI like
https://ci.appveyor.com/project/ruby/ruby/build/1.0.6724
Actually I'm not sure whether the exception class is Errno::ECONNREFUSED
or not. Please change the rescued exception to the correct one if... -
- @jeremyevans0
> Note that the following core classes also use ^ for exclusive-or:
> ...
That's a good point. Maybe we should consider adding the alias to the 4 classes. My idea with this was trying to make it more readable and easy t... -
- I couldn't find a bison API to get the detail of the syntax error, such as what kind of tokens was expected, and what token was actually occurred. Bison just provide us a string of the error message, like 'syntax error, unexpected end-o...
-
- Would be nice.
My current "strategy" is to make mostly small changes and see what/if anything breaks.
This is not very sophisticated but it works, sort of.
Reminds me of tenderlove's blog entry about being a puts-debugger; in my c... -
- At the party at Speee yesterday, @mame explained that one of his contributions to Ruby 2.5 was to make available information about on which lines code blocks would start and end.
This reminded me of one (actually two) of what I think ... -
- comment. Fix regression at r58948.
I even don't want to deprecate it because deprecation needs to lex all
embedded Ruby script using Ripper and it would be slow. So Let me just
keep this behavior of Ruby 2.4. No change is the best comp... -
- [email protected] wrote:
> I'm all for better consistency. I thought there were clear
> guidelines for Ruby, and (almost) everybody was following
> them. I didn't know it was that bad.
Right, I remember it being 4 spaces per-... -
- I'm all for better consistency. I thought there were clear guidelines for Ruby, and (almost) everybody was following them. I didn't know it was that bad.
But fixing spacing will obscure where the code originally came from. I don't rea... -
09:22 AM Bug #14246 (Closed): Inconsistent C source code indentation
- I would like to focus on following 238 C source codes in our repository.
```
% git ls-files | grep '\.\(c\|h\|def\)$' | grep -v 'ext|spec|test' | wc -l
238
```
Here, in these 238 files, 10 files are indented using spaces only.
... -
- These are great news for ruby and it’s community. Thank you both for your great work.
Things can only get better! Long live ruby! -
- Thank you for sharing your thoughts and support.
> So I support your proposal but I guess you should get other ruby developer opinions, especially Koichi's one. I did not check your code.
Today I got code review from Koichi-san an... -
- > Code like File.read(filename) is considered to
> ...
When added, the documentation should also
briefly mention the reference to pipes.
For example, a few months ago I did not even know
about the leading '|' character - I first s... -
10:01 AM Feature #14245: Add File.read etc.
- If I understand this proposal correctly,
this proposal means that adding File.read method and
doesn't change IO.read method?
I.e. IO.read("|command") is works as now?.
I think it is possible direction.
Apart from that, we should... -
- Some people use File.open without knowing that it's defined in IO and pipes can be opened.
```
p File.read("|echo hello") #-> "hello"
```
How about to add File.read, File.binread, File.foreach etc. (similar version to File.open)?... -
- ruby_2_5 r61496 merged revision(s) 61478.
-
- prelude.c.tmpl: get rid of errors with old gcc
* template/prelude.c.tmpl: moved diagnostic pragmas outside
prelude_eval() for very old gcc. [ruby-core:84449] [Bug #14234]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/b... -
- normalperson (Eric Wong) wrote:
> I like that idea, I've been rewriting some stuff to use
> ...
Thanks for your suggestion.
I've created a new ticket #14245.
-
- [email protected] wrote:
> How about to add File.read etc. (similar to File.open) in 2.6?
> Code like `File.read(filename)` is considered to have no intention to open pipes.
I like that idea, I've been rewriting some stuff to use... -
- normalperson (Eric Wong) wrote:
> Agreed. I assume this includes IO.read/binread/readlines/...?
I intent this ticket is just for the open method.
For other methods, nobu already added warnings for
File.read("|echo a"), etc.
... -
- matz (Yukihiro Matsumoto) wrote:
> Agreed for warnings.
> ...
How about to add File.read etc. (similar to File.open) in 2.6?
Code like `File.read(filename)` is considered to have no intention to open pipes.
-
- * spec/ruby/optional/capi/spec_helper.rb (compile_extension):
search libruby.so only when enable-shared.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61495 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61494 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_eval.c (eval_string_with_cref): split into cref and scope
modes, which are exclusive.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61493 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_eval.c (eval_make_iseq): moved preparations of location and
debug print.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61492 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * spec/ruby/optional/capi/spec_helper.rb (compile_extension): if
libruby.so should have been built but is not found, fail early.
get mtime of the library just once.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61491 b2dd03c8-39... -
- * tool/fake.rb: set "libdir" to build directory too, so that
spec/ruby/optional/capi/spec_helper.rb can find libruby_so.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61490 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- It's duplicated with #14234
- 12:04 AM Revision 79487218 (git): * 2017-12-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61489 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61488 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/26/2017
-
- > But Strings and Symbols represent different concepts and should be treated differently.
Jeremy I agree with you on this and that is one of the reasons, possibly the biggest reason, why I think it will make a huge difference if we st... -
- I'm 100% against merging Symbols and Strings. Symbols and Strings have always represented different concepts. Symbols are a simple way to get a unique named identifier, and Strings represent arbitrary data/text. In some cases, you nee...
-
- Hi Koichi.
I’ve been thinking about the challenge you put me.
What if we add as a transition path the method:
`String#old_symbol`.
Then we could use it in the `Symbol::===(var)`
and we would warn if `var.is_a?(String) && var.old... -
- > I was wondering if it wouldn’t be possible to use some kind of transitional flag like:
Please consider transition path for users who are using symbol and string difference like:
```
key = ...
...
when key
case String
...
... -
- > If we need to breaking compatibility, we need to make transition path
Thanks Koichi.
I totally agree with you and Eric about worries on breaking backwards compatibility.
I was wondering if it wouldn’t be possible to use some kind ... -
- > It seems that what is in question to be removed in ruby 3.0 is the pipe feature associated to Kernel#open and related API not the all method.
> ...
Important point is, we can know the breaking compatibility with exceptions. If we remo... -
- Daniel Ferreira <[email protected]> wrote:
> Why isn’t your reply on the issue tracker?
It should be, I see it. Might take some minutes for mail to propagate. -
- It seems that what is in question to be removed in ruby 3.0 is the pipe feature associated to Kernel#open and related API not the all method.
Still breaking backwards compatibility though.
Sorry for misreading it and thanks Eric fo... -
- [email protected] wrote:
> If we are considering breaking backwards compatibility in ruby
> 3.0 with removal of API like IO.read which is all over let’s
Removal of IO.read? I hope you're not misinterpreting my [ruby-... -
- If we do want to keep symbols as part of ruby API what about considering a new syntax for symbols and leave the current symbol syntax to be identified as string literals or just strings?
-
- If we are considering breaking backwards compatibility in ruby 3.0 with removal of API like IO.read which is all over let’s fix this symbol vs string issue once and for all shall we?
Ruby programmers will be much happier.
Why don’t we... -
- I agree.
These global variables can only be useful in tiny scripts,
and even then I believe none of them are idiomatic Ruby code.
All of these are shortcuts saving at best a couple characters,
but also threaten any usage of gets/pr... -
- Tanaka Akira <[email protected]> wrote:
> >> Besides that, we should warn for `$=` and `$.`, I think.
> 2017-12-26 17:55 GMT+09:00 Eric Wong <[email protected]>:
> > I find $., $\, and $/ useful for oneliners, at least. $.
> > esp... -
- Tanaka Akira <[email protected]> wrote:
> >> Besides that, we should warn for `$=` and `$.`, I think.
> 2017-12-26 17:55 GMT+09:00 Eric Wong <[email protected]>:
> > I find $., $\, and $/ useful for oneliners, at least. $.
> > esp... -
- By the way, the awk-inspired names such as $NR, $ORS, $RS,
also do not tell me anything. :-)
In fairness, I also have to admit that the english names also
do not always tell me that much more. Depends on the name.
http://ruby-doc... -
- 2017-12-26 17:55 GMT+09:00 Eric Wong <[email protected]>:
> Shouldn't English posts be on ruby-core instead of ruby-dev?
Oops. Sorry.
>> Besides that, we should warn for `$=` and `$.`, I think.
>
> I find $., $\, and $/ us... -
- 2017-12-26 17:55 GMT+09:00 Eric Wong <[email protected]>:
> Shouldn't English posts be on ruby-core instead of ruby-dev?
Oops. Sorry.
>> Besides that, we should warn for `$=` and `$.`, I think.
>
> I find $., $\, and $/ us... -
- Shouldn't English posts be on ruby-core instead of ruby-dev?
[email protected] wrote:
> Agreed.
>
> Besides that, we should warn for `$=` and `$.`, I think.
I find $., $\, and $/ useful for oneliners, at least. $.
e... -
- Shouldn't English posts be on ruby-core instead of ruby-dev?
[email protected] wrote:
> Agreed.
>
> Besides that, we should warn for `$=` and `$.`, I think.
I find $., $\, and $/ useful for oneliners, at least. $.
e... -
08:13 AM Feature #14240: warn four special variables: $; $, $/ $\
- Agreed.
Besides that, we should warn for `$=` and `$.`, I think.
Matz.
-
- I think the four special variables for separators should be deprecated.
```
$/ input record separator (default argument for "gets")
$\ output record separator ("print" prints it at last)
$, default separator for Array#join... -
08:19 PM Feature #12589: VM performance improvement proposal
- k0kubun (Takashi Kokubun) wrote:
> Happy Holidays, Vladimir. As our work has many duplicated things, I'm proposing to partially merge your work to upstream at https://bugs.ruby-lang.org/issues/14235. I would like your opinion on it.
... -
- Happy Holidays, Vladimir. As our work has many duplicated things, I'm proposing to partially merge your work to upstream at https://bugs.ruby-lang.org/issues/14235. I would like your opinion on it.
-
07:37 PM
Bug #14241: Time.strptime() doesn't support the directive "%W".
- To add to the report, the Time.strptime doesn't support any of the following directives
~~~ ruby
%w %W %j %u
~~~
basically, it doesn't support anything outputted from the Date._strptim that is not in the following hash keys
(ht... -
10:10 AM Bug #14241 (Closed): Time.strptime() doesn't support the directive "%W".
- According to reference manual, Time.strptime() accepts the directive "%W" in a format string, but it seems not to be worked.
On the other hand, Date.strptime() accepts "%W" correctly.
C:\>ruby -v
ruby 2.3.3p222 (2016-11-21 revision ... -
- A backwards-incompatible change was introduced with https://github.com/ruby/ruby/commit/abbfc048c5890e8017360bbc845062ea1585e155#diff-e1ea8366d3ac334deab7e0d25309be03
**Example:**
~~~ ruby
require "erb"
input = "<% # comment %>\n... -
- We discussed this issue at today's Ruby committer's meeting. We can't change the behavior soon because of compatibility issue, so we need a transition path.
After r61483, a warning is now printed when `eval` receives only `binding` a... -
01:16 PM Bug #14242 (Rejected): Fails to build ruby 2.5.0 on CentOS 6
- kimura@www10268uf[2018]% cat /etc/redhat-release
CentOS release 6.9 (Final)
kimura@www10268uf[2019]% gcc -v
Using built-in specs.
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man --info... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61487 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61486 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61485 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r61484.
----------
vm_method.c: fix super in refined module
* vm_method.c (rb_method_entry_complement_defined_class): clone
the original method entry of refined module instance method with
the active ICLA... -
- * vm_method.c (rb_method_entry_complement_defined_class): clone
the original method entry of refined module instance method with
the active ICLASS, to track super method chain.
[ruby-dev:50390] [Bug #14232]
git-svn-id: svn+ssh://c... -
- * parse.y (gettable_gen): warn for __FILE__/__LINE__ when eval
with binding only. promote use of Binding#source_location
instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61483 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:05 AM Bug #14188 (Third Party's Issue): With install Ruby 2.4.3 and Passenger 5.1.12 ALL sites will fail to open
- The SEGV point is therubyracer's `script.Run()` at https://github.com/cowboyd/therubyracer/blob/master/lib/v8/context.rb#L99 , furthermore, in V8 engine of therubyracer.
Sorry to send you around, but please report this issue to therub... -
- Applied in changeset trunk|r61482.
----------
vm_eval.c: strange message in eval
* vm_eval.c (eval_string_with_cref): remove unnecessary location
from exception backtrace in eval.
[ruby-core:84434] [Bug #14229] -
- It was https://bugs.ruby-lang.org/issues/12338#change-58690
-
- I think I've filed this issue already (and discussed at a developers' meeting), but I can't remember the number.
-
- * vm_eval.c (eval_string_with_cref): remove unnecessary location
from exception backtrace in eval.
[ruby-core:84434] [Bug #14229]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61482 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61481 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Are we relying on rubocop as ruby’s official linter?
This question comes inline with my recent previous comment around core functionalities that I believe should be better managed as part of ruby API.
Debugger, Coverage, Unit tests, ... -
- At least, I don't like the name `warn_past_code`. It's not intuitive.
And it may be better to be handled by Rubocop as Marc-Andre said.
Matz.
-
- 賛成です。
できれば不要なインデントの変更などは混ぜないでください。 -
- Applied in changeset trunk|r61480.
----------
proc.c (bind_location): Add Binding#source_location
Fixes #14230 -
- Agreed.
Matz.
-
- Fixes #14230
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61480 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Agreed for warnings.
For removing, I think we have to wait for 3.0.
Matz.
-
- [email protected] wrote:
> Recently we found open("|...") is tend to be misused.
>
> Many people uses this method without concerning that it can run a process.
>
> I think it should be deprecated.
>
> So, I propose that ruby warns ... -
- Recently we found open("|...") is tend to be misused.
Many people uses this method without concerning that it can run a process.
I think it should be deprecated.
So, I propose that ruby warns open("|...").
(and remove this proc... -
- We are discussing removing those weird global variables (for Ruby3).
Even if we cannot remove them, we'd like to provide the alternative way to access the info (e.g. `Regexp.last_match` for `$~`). If any of those variables will survive,... -
08:06 AM Bug #14238: With install Ruby 2.5.0 and Passenger 5.1.12 ALL sites will fail to open
- Sega100500 (Сергей Е) wrote:
> Problem still exists:
> ...
-
- Problem still exists:
https://bugs.ruby-lang.org/issues/14188
With install **Ruby 2.5.0** and **Passenger 5.1.12** ALL sites will fail to open
application out:
**Incomplete response received from application** -
- The names (or APIs) suggested so far:
```
executed?
required?
main?
first_script?
main_script?
run_script?
is_executed?
is_program?
defined?(__MAIN__)
__FILE__.main?
FILE.executed?
directly_executed?
standalone?
loaded?
... -
-
- I looked at this directly with Nobu today. I had to remove ext/bigdecimal/extconf.h ext/bigdecimal/exts.mk, and ext/configure-ext.mk, and then run make again. This finally solved this issue.
-
- First patch is prepatory, second patch uses IO.copy_stream:
https://80x24.org/spew/[email protected]/raw
https://80x24.org/spew/[email protected]/raw
It should support Content-Range in a 3rd (to-be-... -
- Applied in changeset trunk|r61479.
----------
variable.c: public rb_autoload
* variable.c (rb_autoload): restore the visibility for backward
compatibility. [ruby-core:84454] [Bug #14236] -
-
04:30 AM Bug #14236 (Closed): rb_autoload の可視性が変更された結果、特定のgemを使用するとランタイム時に落ちるようになった
- nmコマンドから見える `rb_autoload` の可視性は従来 `T` でしたが、以下の変更により `t` になっています。
https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/57675
これにより以下の事象が発生しています。
stackprof v0.2.9 などの、 `rb_autoload` を使っている gem について、
インストール時のビルドはできるが実... -
- * variable.c (rb_autoload): restore the visibility for backward
compatibility. [ruby-core:84454] [Bug #14236]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61479 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- ## Background
In [Feature#12589](https://bugs.ruby-lang.org/issues/12589), Vladimir Makarov proposed to improve VM performance by replacing VM instructions
to RTL and introduce method JIT compiler based on those instructions.
Whil... -
- Applied in changeset trunk|r61478.
----------
prelude.c.tmpl: get rid of errors with old gcc
* template/prelude.c.tmpl: moved diagnostic pragmas outside
prelude_eval() for very old gcc. [ruby-core:84449] [Bug #14234]
12/25/2017
-
- * template/prelude.c.tmpl: moved diagnostic pragmas outside
prelude_eval() for very old gcc. [ruby-core:84449] [Bug #14234]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61478 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Does not work for me on 2.4.3:
syntax error, unexpected '{', expecting end-of-input
3.step by: 3, to: 9 {|i| p i}
Are you sure that this has worked before? -
09:38 PM Bug #14233 (Rejected): syntax error caused by paren-less method call with kwargs and block
- Example:
~~~ ruby
3.step by: 3, to: 9 {|i| p i}
~~~
Expected result (before 2.5.0):
~~~
3
6
9
~~~
Actual result (2.5.0):
~~~
a.rb:1: syntax error, unexpected '{', expecting end-of-input
3.step by: 3, to: 9 {|i| p i... -
- [email protected] wrote:
> normalperson (Eric Wong) wrote:
> > In fact, it is never safe to
> > use locking such as `pthread_mutex_lock` inside a signal handler.
>
> Do you think it's likely that your work towards Mutex that
> does ... -
10:41 PM Misc #14222: Mutex.lock is not safe inside signal handler: what is?
- normalperson (Eric Wong) wrote:
> In fact, it is never safe to
> ...
Do you think it's likely that your work towards Mutex that does not rely on threads (r13517) would allow us to use Ruby Mutex from a signal trap? As far as I understa... -
11:40 PM Bug #14234 (Closed): Failed to build on CentOS 6.9
- CentOS 6.9（gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)） にてrbenv - ruby-buildを使ってRuby 2.5.0のビルドを試みると失敗します。
~~~ text
[~]$ rbenv install 2.5.0
Downloading ruby-2.5.0.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.5/ruby-2.5.0.ta... -
- パッチ自体は適用不能だと思いますが、全シンボルに対応する文字列オブジェクトはいまでも作られているので、最適化の選択肢として残ってるという認識です。効果は減ってるかもしれませんが。
近いうちに検証したいと思っていたのでしばらく残しておいてもらっていいですか。（数年放置のフラグ） -
- これもうobsoleteですよね
- 11:33 PM Revision fff3fd9a (git): * 2017-12-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61477 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61476 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- phluid61 (Matthew Kerwin) wrote:
> shevegen (Robert A. Heiler) wrote:
> ...
Sorry it was buggy. phluid61 is correct. -
- shevegen (Robert A. Heiler) wrote:
>
> ...
begin
eval("raise")
rescue => e
p e.message
end -
- Is this only with miniruby?
I get "undefined local variable or method `e' for main:Object"
for a newly created "test.rb" file.
The e.message part confuses me, was this part of a larger code
snippet? -
- Is this intentional? If so, I'm curious what purpose it is for.
begin
eval("raise")
rescue
p e.message #=> "(eval):1:in `<main>'"
end
This leads to progressive backtrace message:
$ ./miniruby -e... -
- saved_thread was renamed to saved_ec in r59831 [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61475 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61474 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I like introspection so I am usually in agreement with all ways
to inspect ruby's behaviour.
+1
I also agree that eval-binding is not pretty. -
- How about providing `Binding#source_location`?
b = binding
p binding.source_location #=> ["test.rb", 1]
To fetch the information, people uses a dirty idiom: `eval("[__FILE__, __LINE__]", binding)`.
* https://github.com/... -
- * hash.c (prime2): turned into a uint32_t prime, as the lower
32bits, non-prime part only was used always.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61473 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Given the following t.rb:
```
module A
def foo
puts "A#foo"
super
end
end
class B
def foo
puts "B#foo"
end
end
class C < B
include A
def foo
puts "C#foo"
super
end
end
modul... -
- Applied in changeset trunk|r61471.
----------
Use UINT128_T support flag from configure
Current check for __uint128_t in hash.c is not valid, since it ignores
compilers other than gcc. We hit this on lcc on e2k platform.
Configure scr... -
- Does this mean something is broken, or just performance improvement?
-
11:26 AM Bug #14231: __uint128_t check in hash.c is broken, use
- Looks like this version affects all ruby versions, though I tested only on 2.4.2 and trunk.
-
- Current check for __uint128_t in hash.c is not valid, since it ignores
compilers other than gcc. We hit this on lcc on e2k platform.
Configure script properly checks from 128-bit data types support and
sets HAVE_UINT128_T accordingl... -
- * hash.c (mult_and_mix): use uint128_t instead of __uint128_t.
[ruby-core:84438] [Bug #14231]
From: Nobuyoshi Nakada <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61472 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Current check for __uint128_t in hash.c is not valid, since it ignores
compilers other than gcc. We hit this on lcc on e2k platform.
Configure script properly checks from 128-bit data types support and
sets HAVE_UINT128_T accordingly. T... -
- matz (Yukihiro Matsumoto) wrote:
> I agree with the rationale behind the proposal. I am slightly concerned about incompatibility.
> ...
I tried the change, and found some projects actually use the idiom, `eval("[__FILE__, __LINE__]", b... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61470 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/irb.rb (IRB::Irb#eval_input): fix highlight for multiple
lines exception messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61469 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@61467 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@61466 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/rubygems/command.rb (Gem::Command#invoke_with_build_args):
restore UI and close the created SilentUI.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61465 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * mswin32 and Symbian OS are no longer supported
* Mac OS X was renamed
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61464 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * iseq.c (iseq_inspect): show also code range information.
Note that `iseq_inspect` is used only for header of disasm.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61463 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * prelude.rb (Thread.exclusive): pass the block as a block
argument.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61462 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61461 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * template/prelude.c.tmpl (PRELUDE_STR): make string objects with
static literals not to copy them.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61460 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * template/prelude.c.tmpl (prelude_eval): fix optimization
options. trace_instruction member has been removed. filled
coverage_enabled and debug_level members instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61459 b2dd03... -
-
01:39 AM Bug #14228: mswin build - ruby 2.5.0dev (2017-12-25 trunk 61451) [x64-mingw32] test-all failure
- I just built `2.5.0dev (2017-12-25 trunk 61458) [x64-mswin64_140]` locally, and using `nmake` or `runner.rb`, `ruby/test_syntax.rb` generated:
112 tests, 5163 assertions, 0 failures, 0 errors, 0 skips
I got the same results using `... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61458 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_compile_each): for empty method, block and so on,
`last_line` is not set so that line number of `putnil` instruction
will be zero. This patch set `first_lineno` for such `putnil`.
Problem is reported by deivid-ro...
12/24/2017
-
08:07 PM Bug #13957: readline が SHARABLE_MIDDLE_SUBSTRING=1 を考慮していない
- ruby_2_4 r61456 merged revision(s) 60071.
-
- ruby_2_4 r61456 merged revision(s) 60071.
-
- ruby_2_4 r61456 merged revision(s) 60071.
-
- ruby_2_4 r61456 merged revision(s) 60071.
-
- ext: check if null byte is contained
[ruby-dev:50267] [Bug #13953]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@61456 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r61455 merged revision(s) 60066.
-
- string.c: fix ASCII-only on succ
* string.c (str_succ): clear coderange cache when no alpha-numeric
character case, carried part may become ASCII-only.
[ruby-core:83062] [Bug #13952]
git-svn-id: svn+ssh://ci... -
- ruby-loco (MinGW) is passing. Since I'm test focused, I can generate a log of test-all failures and errors while parallel testing. Most often these pass in retry. Below is the log for December:
From the log, I'm guessing the issue ... -
- ruby_2_4 r61454 merged revision(s) 60059.
-
- pack.c: unpack "M" may be ASCII only
* pack.c (pack_unpack_internal): set ASCII only properly on "M",
may be ASCII only. [ruby-core:83055] [Bug #13949]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@61... -
- ruby_2_4 r61453 merged revision(s) 60060.
-
- string.c: ASCII-incompatible is not ASCII only
* string.c (tr_trans): ASCII-incompatible encoding strings cannot
be ASCII-only even if valid. [ruby-core:83056] [Bug #13950]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby... -
05:55 PM Revision 7361587f (git): NEWS: use of copy_file_range(2) isn't a new method
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61452 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I heard that notable performance improvements should be written to
"Implementation Improvements". So I put the sentence here.
Also, the sentence itself is fixed to be the same as Ruby 2.5 release
note draft's one.
git-svn-id: svn+ssh:/... -
- * iseq.h (rb_compile_option_struct): trace instruction is removed so that
remove the trace_instruction compile option.
Don't show warning (just ignore) for Ruby 2.5.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61450 b2dd03c8-... - 04:43 PM Revision 973e39a3 (git): * 2017-12-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61449 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- improvement.
There is no specific ticket for it, but improving the ERB's performance
was my largest passion that made me a Ruby committer.
See r58735, r58842, r58904, r58905, r58916.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6... -
03:09 PM Feature #8661: Add option to print backtrace in reverse order (stack frames first and error last)
- Although I am not a Ruby committer, IMHO, I do not think the current implementation
is the best way to fully address the reporter's concern.
As written in this issue's description section, reversing the backtrace is a
solution which... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61447 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61446 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:45 AM Revision 5461fa37 (git): NEWS: updates for WEBrick [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61445 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:40 AM Revision acdbb5c0 (git): NEWS: fix typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61444 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:38 AM Revision 7d10b978 (git): webrick 1.4.2
- This release removes uses of Kernel#open to avoid unintended
behaviors and make future auditing easier. [Misc #14216]
6 changes since 1.4.1:
webrick: httpauth requires regular files
webrick/httpservlet/cgi_runner.rb: remove... - 06:24 AM Revision 1b0b42db (git): NEWS: update for bigdecimal 1.3.4
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61442 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:22 AM Revision ea68278f (git): bigdecimal: version 1.3.4
- Import bigdecimal version 1.3.4. The full commit log is here:
https://github.com/ruby/bigdecimal/compare/v1.3.3...v1.3.4
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61441 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r61440 merged revision(s) 60024.
-
- vm.c: fetch retval iff necessary
* vm.c (rb_vm_make_jump_tag_but_local_jump): get rid of fetching
retval when it is not used. it is necessary for local jump
state only.
git-svn-id: svn+ssh://ci.ruby-lang.or... -
- ruby_2_4 r61439 merged revision(s) 60099,60100.
-
- compile.c: fix stack consitency error
* compile.c (iseq_compile_each0): fix stack consitency error on
attr-assign with safe navigation operator when the receiver is
nil, should pop it too. [ruby-core:83078] ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61438 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (compile_return): evaluate arguments to top-level
return but ignore the results.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61437 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r61436 merged revision(s) 59444,59445.
-
- adjust indent [ci skip]
* vm_insnhelper.c (vm_call_method_each_type): adjust indent of a
block in switch.
visibility of inherited method
* vm_insnhelper.c (vm_call_method_each_type): honor the origina... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61435 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I think this is a spec change because of existence of the test in rubyspec about this behavior.
I will change WONTFIX for 2.4. Please tell us if there are any real world application suffered with this issue. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61434 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61433 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/23/2017
-
- It fixes an installation error of activerecord.
https://github.com/ruby/rdoc/issues/571
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61432 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:20 PM Bug #13754: bigdecimal with lower precision that Float
- https://github.com/ruby/bigdecimal/issues/94
-
- [email protected] wrote:
> Denying ownership permissions to the owner seems bogus.
s/ownership/write/ :x -
- ```
Denying write permissions to the owner seems bogus.
Oddly, this problem only manifests in the "ruby_2_4" branch when
installing bundled gems (rake and friends). It does not happen
with "ruby_2_3" or "trunk", so it might be rel... -
- [Feature #8861]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61431 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r61429.
----------
undef HAVE_BUILTIN___BUILTIN_CHOOSE_EXPR_CONSTANT_P on GCC 4.8
GCC 4.8 with optimization causes error if it compiles following code.
[Bug #14221]
```c
__builtin_choose_expr(__builtin_const... - 04:17 PM Revision 953385c6 (git): * 2017-12-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61430 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- GCC 4.8 with optimization causes error if it compiles following code.
[Bug #14221]
```c
__builtin_choose_expr(__builtin_constant_p(b),0,1)
```
https://github.com/ruby/ruby/pull/1778
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61428 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * iseq.c (iseqw_trace_points): add `RubyVM::InstructionSequence#trace_points`
method for tools which want to manipulate ISeq (and traces).
* test/ruby/test_iseq.rb: add a test for this method.
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
- * test/io/console/test_io_console.rb (test_getpass): try to get
rid of timing issues.
* test/io/console/test_io_console.rb (test_ioflush2): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61426 b2dd03c8-39d4-4d8f-98ff-823fe6... -
- * iseq.c (iseqw_each_child): add RubyVM::InstructionSequence#each_child
method for tools which want to manipulate ISeq.
* test/ruby/test_iseq.rb: add a test for this method.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61425 b2... -
- I take the chance to ask here about something I have been thinking for a very long time.
Doesn’t it make sense to have the debugger API in ruby core instead of a gem?
We already got debugger gems broken in the past due to ruby core cha... -
- Modify title.
Not "c-return" but "end" (end of class/module statements) event.
-
- [Feature #14104] changes line numbers of several events,
> Line numbers on :return/:b_return events show the last executed lines, instead of end lines (without return statement).
But byebug, a well-known debugger depends on this be... -
-
- * compile.c (rb_iseq_compile_node): line number spec of :return, :b_return
and :end events of 'TracePoint` is changed for [Feature #14104].
Quoted from [Feature #14104]:
> Line numbers on :return/:b_return events show the last exe... -
- My motivation was to improve the output of `ruby --dump=insns xxx.rb`.
When one file has many iseqs, it's hard to find the one I want to read.
So I wanted `iseq_disasm` to show first_lineno. I unified the behavior
of `iseqw_disasm` for ... -
- [email protected] wrote:
> `Thread.handle_interrupt` doesn't work.
Oops, the main thread may already have a Mutex locked, right?
> You can use `Queue` inside trap context.
Since 2.1 when Queue was reimplemented in C. Old (pu... -
- `Thread.handle_interrupt` doesn't work.
You can use `Queue` inside trap context.
```ruby
require 'logger'
LOG = Queue.new
Thread.start {
log = Logger.new(STDOUT)
log.info "Now logging!"
nil while log.info(LOG.pop) ... -
- [email protected] wrote:
> As mentioned in #7917, Mutex.lock is not safe inside signal
> handler. As mentioned in #6416, neither is Thread.join. But
> there seem to be no documentation about what IS safe to do
> inside signal han... -
- Eric Wong <[email protected]> wrote:
> [email protected] wrote:
> > Windows is kind of crashing & burning with the recent changes
> > to WEBrick, etc. I haven't really looked at them, but thought
> > the logs might be helpful... -
- This was already discussed and rejected in #12515.
-
- Since we are working on deprecating and removing $SAFE for [Feature #5455],
I propose untainting all string keys used for hashes in Ruby 2.6.
It will make implementing [Feature #13725] (fstring dedupe of hash keys) easier.
Further... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61422 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [email protected] wrote:
> What IS the recommended way to fix this if Mutex nor Thread
> are safe in signal handler? Also created question for what is
> safe in signal handler in general as #14222
See my response for [ruby-core:844... -
- * iseq.c (rb_insn_operand_intern): simplified the condition for
local variable names, assume TS_LINDEX and TS_NUM combinations
are only for local variables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61421 b2dd03c8-39d4-4d8f-... -
- * insns.def (checkkeyword): adjust argument type to
vm_check_keyword as lindex_t.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61420 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61419 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I postpone merging bundler to stdlib.
I reverted this feature ar r61416 - 12:30 AM Revision d783148c (git): * 2017-12-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61418 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/enc/test_regex_casefold.rb: fix searching unicode data
directory, like as test_case_comprehensive.rb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61417 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/22/2017
-
- I faced a big issue about Bundler with ruby core.
I have no time to resolve it issue before 2.5 final release.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61416 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:10 PM Feature #14224 (Rejected): Boolean class
- Suggestion: TrueClass and FalseClass inheriting from Boolean (new superclass).
This would make true/false checking easier, like:
```
unless value.is_a?(Boolean)
raise "Non-boolean value"
end
```
Currently we have to check ... -
05:07 PM Feature #14217: Expose RUBY_PATCHLEVEL_STR or similar with patch level info for rc/preview as a constant
- Agreed that it may appear as long. I chose this as a proposal, because it was already defined and was simpler to expose. Example:
~~~ diff
From 8cef26bbdf314dccf1d36984a49c35f0a815bbea Mon Sep 17 00:00:00 2001
From: Shayon Mukherj... -
- I can't say whether the name that you haved picked for the constant is good or bad - it seems a
bit long. But I agree on the general problem mentioned, so I am all for more fine-tuned control.
The ruby core team may have decide on th... -
- I am happy to a patch/create a Github PR, if this sounds like a good option.
-
- ## Problem
When ruby is in release candidate or preview, `RUBY_PATCHLEVEL` is `-1`. Without parsing `RUBY_DESCRIPTION`, its hard to tell using constant the right and absolute ruby version.
## Proposal
Expose `RUBY_PATCHLEVEL_STR` as... -
04:46 PM Feature #14223 (Closed): Refinements で定義した #to_proc が &hoge 時に呼ばれないのを緩和する提案
- Refinements に関する提案です。
現行の仕様では Refinements で定義された `#to_proc` は `&hoge` 時に暗黙的に呼びだされません。
```ruby
using Module.new {
refine String do
def to_proc
proc { |it| it.send self }
end
def refine_method
"X#refine_method... -
02:03 PM Bug #14207: Failed to build 2.5.0-rc1 on CircleCI
- ありがとうございます。
CircleCIのDocker上で最新の trunk をビルドできることと、
2.5.0-rc1 に r61412 のパッチを当てる方法でもビルドできることを確認しました。
-
08:52 AM Bug #14207: Failed to build 2.5.0-rc1 on CircleCI
- バグレポートありがとうございます。
copy_file_range(2)でerrnoがEPERMだった場合は、sendfile(2)またはread/writeにフォールバックする実装にしました。
これで修正できているかと思います。 -
08:47 AM
Bug #14207 (Closed): Failed to build 2.5.0-rc1 on CircleCI
- Applied in changeset trunk|r61412.
----------
io.c: ignore EPERM
* io.c (nogvl_copy_file_range): ignore EPERM and fallback to
sendfile(2) or read/write. copy_file_range(2) may not exist
even if __NR_copy_file_range is defined in th... -
-
01:11 PM Misc #14222: Mutex.lock is not safe inside signal handler: what is?
- Few more questions: is adding key to hash safe? Pushing variable to array as used in http://www.mikeperham.com/2013/02/23/signal-handling-with-ruby/ ?
-
- As mentioned in #7917, Mutex.lock is not safe inside signal handler. As mentioned in #6416, neither is Thread.join. But there seem to be no documentation about what IS safe to do inside signal handler. In C, it is not safe to just modify...
-
- What IS the recommended way to fix this if Mutex nor Thread are safe in signal handler? Also created question for what is safe in signal handler in general as #14222
-
- * test/ruby/enc/test_case_comprehensive.rb: search ucd directory
first if exists.
* test/ruby/enc/test_regex_casefold.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61415 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r61414 merged revision(s) 57971.
-
- Fix a consistency bug of ISEQ_COVERAGE [Bug #13305]
There is an invariant that ISEQ_COVERAGE(iseq) must be Qnil if and only
if option->coverage_enabled is false. This invariant was broken by
NODE_PRELUDE which u... -
10:42 AM Bug #14221 (Closed): Fix ruby.h behaviour in old compilers: __builtin_choose_expr is different before 4.8.5
- Link to GH PR: https://github.com/ruby/ruby/pull/1778
When trying to install some native gems in a ruby-25-rc1 compiled using 4.8.5 (Centos 7 or Ubuntu 14.04) you get this error related to new functions in ruby.h
gem install nokogi... -
- Applied in changeset trunk|r61413.
----------
force hash values fixable
* include/ruby/ruby.h (RB_ST2FIX): force fixable on LLP64 environment.
* hash.c (any_hash): ditto.
[ruby-core:84395] [Bug #14218] -
-
01:11 AM Bug #14218 (Closed): Addition of negative Object#hash values can overflow
- Script to reproduce:
~~~ ruby
p 1_000_000.times.count{a=Object.new.hash; b=Object.new.hash; a < 0 && b < 0 && a + b > 0}
p 1_000_000.times.count{a=Object.new.hash; b=Object.new.hash; 0 + a + b != 0 + b + a}
~~~
Expected value: A... - 08:52 AM Revision 52220154 (git): force hash values fixable
- * include/ruby/ruby.h (RB_ST2FIX): force fixable on LLP64 environment.
* hash.c (any_hash): ditto.
[ruby-core:84395] [Bug #14218]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61413 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * io.c (nogvl_copy_file_range): ignore EPERM and fallback to
sendfile(2) or read/write. copy_file_range(2) may not exist
even if __NR_copy_file_range is defined in the build environment.
[Bug #14207]
git-svn-id: svn+ssh://ci.ruby-... -
- Applied in changeset trunk|r61411.
----------
erb.rb: shadow by keys
* lib/erb.rb (ERB#new_toplevel): shadow already defined local
variables by block local variabes, not to overwrite them.
[ruby-core:84390] [Bug #14215] -
- * lib/erb.rb (ERB#new_toplevel): shadow already defined local
variables by block local variabes, not to overwrite them.
[ruby-core:84390] [Bug #14215]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61411 b2dd03c8-39d4-4d8f-98ff-8... -
- Added `FileUtils::VERSION` const variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61410 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [email protected] wrote:
> Eric,
>
> > Hopefully this isn't controversial
>
> What? If someone thinks it is, maybe they can volunteer to
> maintain everything you said you'd help with... Anyway,
> thanks for all the time yo... -
05:59 AM
Bug #14220 (Closed): WEBrick changes - failures on MSWIN, MinGW
- Applied in changeset trunk|r61409.
----------
webrick/httpservelet/cgi_runner: avoid IO#reopen on pathname
IO#reopen seems to behave strangely on Win32 based on the logs
posted by Greg for [Bug #14420]. Lets try to fix the issue by
us... -
- @normalperson
Eric,
> Hopefully this isn't controversial
What? If someone thinks it is, maybe they can volunteer to maintain everything you said you'd help with... Anyway, thanks for all the time you've put in already.
Wind... - 05:59 AM Revision 0d92f156 (git): webrick/httpservelet/cgi_runner: avoid IO#reopen on pathname
- IO#reopen seems to behave strangely on Win32 based on the logs
posted by Greg for [Bug #14420]. Lets try to fix the issue by
using File.open explicitly (but not Kernel#open).
* lib/webrick/httpservelet/cgi_runner: use File.open explici... -
- * test/rdoc/test_rdoc_markup_pre_process.rb: show
`RDoc::Markup::PreProcess.post_processors` as a failure message
for debugging.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61408 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [email protected] wrote:
> Bug #14219: package size of Ruby 2.5 is larger than 2.4
> https://bugs.ruby-lang.org/issues/14219
>
> * ruby-2.4.3.tar.xz: 9.6M
> * ruby-2.5.0-rc1.tar.xz: 25M
>
> It was caused by `spec` directory.
... -
- A package of Ruby 2.5 was increased file size (about 15MB) from Ruby 2.4.
* ruby-2.4.3.tar.xz: 9.6M
* ruby-2.5.0-rc1.tar.xz: 25M
It was caused by `spec` directory.
```
~/D/ruby-2.4.3 > du -md 1 | sort -rn | head
79 .
26 ./e... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61407 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61406 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61405 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/socket/ifaddr.c (get_ifaddrs): extract ifaddrs from
Socket::Ifaddr.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61404 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61403 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:08 AM Revision f2aa7f40 (git): webrick/httputils: note Kernel#open behavior
- I don't know who uses the load_mime_types method; but it is
conceivable that a user would want to read the results of a
command instead of reading a regular file to load MIME types.
None of the WEBrick-related code in Ruby or default/bu... - 01:08 AM Revision 1ad355bd (git): webrick/httpservlet/*handler: use File.open
- This makes future code audits easier. None of these changes
fix realistic remote code execution vulnerabilities because
we stat(2) before attempting Kernel#open.
* lib/webrick/httpservlet/erbhandler.rb (do_GET): use File.open
* lib/web... - 01:07 AM Revision 1989371d (git): webrick: WEBrick::Log requires path arg when given string
- Allowing a user to specify "| command" via Kernel#open is
nonsensical since we never read from the resultant IO.
* lib/webrick/log.rb (initialize): replace Kernel#open with File.open
[Misc #14216]
git-svn-id: svn+ssh://ci.ruby-lang.o... - 01:07 AM Revision 1895a488 (git): webrick: add test for WEBrick::HTTPServlet::ERBHandler
- This previously had no coverage.
* test/webrick/test_filehandler.rb (test_erbhandler): new test
* test/webrick/webrick.rhtml: new file for test
[Misc #14216]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61399 b2dd03c8-39d4-4d8f-... - 01:07 AM Revision 646b83af (git): webrick/httpservlet/cgi_runner.rb: remove unnecessary open
- IO#reopen already takes string path names as well as IO objects
(but not "| command" strings)
This makes further auditing for inadvertant code execution
easier. There's no actual bugfix or behavior change here,
as no external data is p... -
01:07 AM
Misc #14216 (Closed): webrick: audit and fix Kernel#open misuse
- Applied in changeset trunk|r61397.
----------
webrick: httpauth requires regular files
Be sure we do not try to open a pipe to read from, since we care
about mtime in all cases.
* lib/webrick/httpauth/htdigest.rb: use File.open
* lib/... - 01:07 AM Revision edddc28f (git): webrick: httpauth requires regular files
- Be sure we do not try to open a pipe to read from, since we care
about mtime in all cases.
* lib/webrick/httpauth/htdigest.rb: use File.open
* lib/webrick/httpauth/htgroup.rb: ditto
* lib/webrick/httpauth/htpasswd.rb: ditto
[Misc #142... -
- * string.c (str_undump): use rb_enc_find_index2 to find encoding
by unterminated string. check the format before encoding name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61396 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * iseq.c (rb_insn_operand_intern): improve operands of defined
instruction.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61395 b2dd03c8-39d4-4d8f-98ff-823fe69b080e