Activity
From 07/30/2018 to 08/05/2018
08/05/2018
-
11:37 PM Bug #14966 (Closed): 2.5 branch - Appveyor failures - backport missed line
- A while ago, @hsbt committed r62990, and the following line was in `test\test_tmpdir.rb`:
```
TRAVERSAL_PATH.delete!(':') if /mswin|mingw/ =~ RUBY_PLATFORM
```
When it was backported to 2.5 (r62971), the line was omitted. I beli... -
10:53 PM Feature #14869: Proposal to add Hash#===
- I recently got permission to repurpose the `Any` gem, which gives us this:
```
require 'any'
case {id: 1, name: 'foo', age: 42}
when {id: Any, name: /^f/, age: Any} then true
else false
end
# => true
case {id: 1, name: 'foo... -
10:16 PM Bug #14964: [MJIT] missing builtin methods
- Could you test configuring ARCH_FLAG instead of CFLAGS/CXXFLAGS? I'm not sure which variable should be used for -mtune, but it seems that at least -march=barcelona is expected to be set as ARCH_FLAG like ARCH_FRAG="-march=barcelona". I e...
-
03:57 PM Bug #14964: [MJIT] missing builtin methods
- after some investigation, I found the problem is my build options
this builds successfully
```
rb_mjit_header_ok.h
"CXXFLAGS='-O3'",
"CFLAGS='-O3'"
```
but if I add march/mtune it fails
```
rb_mjit_header_fail.h
"CXXFLAGS='... -
- > Is it a known problem?
No, thanks to report.
> ...
I intend to support at least gcc on msys2/MinGW in MJIT and sometimes check if it works.
> Windows 10 64bit, x86_64-w64-mingw32
> ...
I'm using Windows 10 64bit too, and:
... -
- I'm using MSYS1 that could be a problem, but I don't see any difference or a reason why it shouldn't work. You don't pass any additional flags in ruby loco, also you have some patches, but none of them seem to be related to this error. M...
-
- @ahorek
The most recent ruby-loco build (MinGW) passed all tests and had the following output when running test_jit.rb locally:
```
Finished tests in 279.718157s, 0.2789 tests/s, 1.7696 assertions/s.
78 tests, 495 assertions, 0 f... -
12:32 PM Bug #14964: [MJIT] missing builtin methods
- > [...] I can compile the lastest Ruby 2.5.1 with the same options.
> ...
I assume that k0kubun is working on the mjit-component right now (possibly
excluding Sundays :D) - he is like super-busy changing mjit code almost
every day. :)... -
- I'm having trouble building Ruby 2.6 on Windows.
this is the first error:
```
building rb_mjit_header.h
rb_mjit_header.h updated
building .ext/include/x64-mingw32/rb_mjit_min_header-2.6.0.h
./miniruby.exe -I../ruby_2_6/lib -I. -I... - 09:27 PM Revision 217bdd77 (git): process.c (rb_waitpid): reduce sigwait_fd bouncing
- Once a thread has acquired sigwait_fd, hold onto it until
waitpid is complete. This prevents unnecessary migration
and atomic operations.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64200 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:06 PM Misc #14962 (Closed): [PATCH] thread_pthread: stop trying to deal with cancellation
- Applied in changeset trunk|r64197.
----------
thread_pthread: stop trying to deal with cancellation
We don't use pthreads cancellation ourselves and it's painful to
use correctly. Any cancelled threads would break
vm->living_threads, ... - 08:06 PM Revision 9f395f11 (git): test/ruby/test_thread.rb (test_thread_timer_and_interrupt): add timeouts
- Trying to diagnose CI failures from i686-linux on Debian 7.
This also fixes a potential GC problem with Thread.start or
IO#read potentially closing the write-end of the pipe due
to allocation.
cf. http://www.rubyist.net/~akr/chkbuild/d... - 08:06 PM Revision d17c7ba3 (git): * 2018-08-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:06 PM Revision 2ba640f3 (git): thread_pthread: stop trying to deal with cancellation
- We don't use pthreads cancellation ourselves and it's painful to
use correctly. Any cancelled threads would break
vm->living_threads, GVL, thread_sync.c, autoload, etc...
So don't bother caring; because we can't stop rogue extensions
f... -
06:25 PM Bug #14965 (Third Party's Issue): Segmentation fault at 0x0000000000000000
- I had installed rabbit (`$ gem install rabbit`) and created this file
```Markdown
# NES
```
I then run `$ rabbit --type file presentation.md` and it crashed. :´(
-
- @h.shirosaki, thanks for your work on this. I tested your patch 0001-dir.c-performance-fix-with-braces.patch (ruby head + braces) based on the current trunk https://github.com/ruby/ruby/pull/1864
environment:
```
Samsung 850 Pro 250... -
- This option makes sure that the argument is C source file.
Probably this is not needed, but since I'm debugging it, I want to
exclude any failure possibility for now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64196 b2dd03c8-39d4... -
11:00 AM Bug #14350: Strange behavior for Array.min in ruby 2.5.0
- ruby_2_5 r64195 merged revision(s) 61766.
-
- vm_insnhelper.c: search in the indexing order
* vm_insnhelper.c (vm_opt_newarray_max, vm_opt_newarray_min):
search in the indexing order, as well as usual methods.
[ruby-core:84821] [Bug #14350]
git-svn-id: ... - 08:56 AM Revision 14d13bc1 (git): test/ruby/test_process.rb (test_wait_and_sigchld): allow extra SIGCHLD
- MJIT way generate an extra SIGCHLD, so we'll have to deal with it.
Any realistic Ruby program may hit unexpected SIGCHLD, too,
since any spawned subprocess could have extra grandchildren
which get reaped by the main Ruby process, and SI... - 08:56 AM Revision b3aa256c (git): thread_pthread.c (native_sleep): reduce ppoll sleeps
- By holding into sigwait_fd until after we acquire GVL, we can
hit the faster native_cond_sleep path instead of ppoll when
another thread wants to start sleeping. ppoll-ing on sigwait_fd
isn't really useful in program where GVL is conten... -
06:30 AM Misc #14921: DevelopersMeeting20180809Japan
- I am in Narita and I will try to come to the meeting. The only reason why I won't make it is because I get lost on the way :)
I would like to discuss the following issues:
https://bugs.ruby-lang.org/issues/14736
https://bugs.rub... -
- This is needed to resolve:
"error LNK2011: precompiled object not linked in; image may not run"
win32/Makefile.sub: Use the same flags as ones for precompiled header.
This is needed to resolve:
"error C2855: command-line option '/Z7' i... -
- Just moved make_pch into `#else` of `#ifdef _MSC_VER`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64191 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- on mswin properly.
Deleted code to attempt make_pch for mswin, since it won't be needed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64190 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- file name correctly. This allows to use the header installed by r64188.
win32/Makefile.sub: define prebuilt precompiled header path instead of
unused min header path
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64189 b2dd03c8-39d4...
08/04/2018
-
- See the comment in win32/Makefile.sub.
Not only .pch, but also .obj needs to be installed and used on runtime.
.gitignore: ignore .pch that will be built by this.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64188 b2dd03c8-39d4-4d... - 11:33 PM Revision ff1e6657 (git): test/ruby/test_io.rb (test_select_leak): speedup and reduce memory use
- We can reuse the sub-thread and exception with Thread#raise to
reproduce the old memory leak with less overhead. This allows
us to to run more iterations and improve reliability of the
actual test, particularly on platforms without USE_... - 10:58 PM Revision 80e973f0 (git): test/ruby/test_thread.rb (test_thread_interrupt_for_killed_thread): conserve resources
- Use Thread.pass to let the sub-thread finish. This should avoid
running out of memory on resource-constrained systems.
(We don't want to use Thread#join to hit the exception)
This results in a significant memory usage reduction in this... - 08:38 PM Revision 291a82f7 (git): thread.c (consume_communication_pipe): do not retry after short read
- Saves a syscall and slightly improves vm_thread_condvar1
benchmark slightly (more improvements on the way):
r64170 this patch
vm_thread_condvar1 0.917 1.065
git-svn-id: svn+ssh://ci.ruby-la... - 08:34 PM Revision 3dbd8d1f (git): test/ruby/test_io.rb (test_race_gets_and_close): timeout each thread
- Still looking into CI failures on P895 (and seemingly no other boxes):
http://ci.rvm.jp/results/trunk@P895/1190369
:<
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64184 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I recently got permission to repurpose the `Any` gem, which gives us this:
```
require 'any'
case ['Foo', 25]
when [/^F/, Any] then true
else false
end
# => true
```
That should make this even more flexible, and eliminate ... -
- I would agree with `===` being more useful than `<=`, as `case`, `all?`, `grep`, and other methods use it implicitly.
This would be an amazing addition for Ruby, and would bring us closer to pattern matching syntax.
The great part ... - 03:12 PM Revision 32d6becb (git): * 2018-08-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64183 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Since it's impossible to leave macro when preprocessing C source file
with cl.exe, I decided to create precompiled header on Ruby's build time
instead.
We're not doing it for non-mswin environment for 2 reasons:
1) Precompiled header ma...
08/03/2018
- 09:53 PM Revision 81f1285b (git): spec/ruby/library/socket/socket/getaddrinfo_spec.rb: avoid nonsensical lookup
- "http" is a TCP service, so /etc/services on typical GNU/Linux systems
only specify a TCP port for it. Use "discard" since it seems
used for other specs and is specified as both TCP and UDP.
This caused many CI failures like the follow... -
04:19 PM Revision b53cf149 (git): Update to ruby/spec@9be7c7e
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64180 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64179 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Clarify logic and add spec.
* Now passes test-all with the JSON fix.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64178 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * See https://github.com/flori/json/issues/342
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64177 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:11 PM Revision 27f34274 (git): * 2018-08-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64176 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64175 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:49 PM Bug #14963 (Closed): Since r64107, on Solaris, spec test of rb_io_wait_readable hangs up
- Since r64107 (removal of timer thread), on Solaris (both on Solaris 10 and Solaris 11, both on x86 and sparc),
`make test-rubyspec` never ends in the test of rb_io_wait_readable in spec/ruby/optional/capi/io_spec.rb.
~~~
C-API IO fu... -
- * This reverts commit fb253d2032e51f333e6577aa4fcf0c03f9c6fc02.
* The CI is failing, this seems a bug in the JSON C extension.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64174 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * Clarify logic and add spec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * Add spec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64172 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:13 AM Revision a3549926 (git): random.c: fix fallback value
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64171 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:52 AM Feature #14473: Add Range#subrange?
- Great, thank you tarui
-
03:04 AM Feature #14473: Add Range#subrange?
- I am happy that match opinion with you.
I will commit based on your patch. It'll take a little while.
-
- [email protected] wrote:
> https://bugs.ruby-lang.org/issues/14961
queue_sleep. Is that combined with fork? Could be [Bug #14634]
(fixed in trunk, not in 2.5 branch, yet). -
- No clue other than that it crashed in this thread.
```
Thread 5 Crashed:: server.rb:286
0 libsystem_kernel.dylib 0x00007fffa8689d42 __pthread_kill + 10
1 libsystem_pthread.dylib 0x00007fffa8777457 pthread_kill + ... -
-
- Thank you, @rafaelfranca.
It a fixed bug in the trunk, but doesn't seem backported to 2.5 yet. -
01:21 AM Bug #14959: Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
- also see: https://bugs.ruby-lang.org/issues/14894 probably the same issue.
-
- thread_pthread: stop trying to deal with cancellation
We don't use pthreads cancellation ourselves and it's painful to
use correctly. Any cancelled threads would break
vm->living_threads, GVL, thread_sync.c, autoload, etc...
So ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64170 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * random.c (rand_range): moved call of domain_error(), not to
raise an exception in range_values().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64169 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ast.c (Init_ast): undefine allocator of Node, as a method call
on an uninitialized Node causes segfault.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64168 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r64167.
----------
random.c: endless range random
* random.c (range_values): cannot determine the domain of an endless
range. [ruby-core:88261] [Bug #14958] -
- * random.c (range_values): cannot determine the domain of an endless
range. [ruby-core:88261] [Bug #14958]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64167 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:11 AM Revision 4cef2c8d (git): thread_pthread.c: add a macro guard for PTHREAD_CANCEL_ENABLE
- It seems to be unavailable on some platforms including my Android phone.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64166 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Done some more investigating. The following code I've run four ways.
Using two versions of ruby 2.6.0dev (2018-08-03 trunk 64164) [x64-mingw32], one built with gcc 7.3.0, and one with gcc 8.2.0. I've run the same code on Appveyor & ...
08/02/2018
-
10:11 PM Bug #14961 (Closed): Segfault when running RSpec / Capybara / Rails
- After upgrading to 2.5.1, we consistently see a segfault when running RSpec + Capybara against a Rails application.
-
- http://ci.rvm.jp/results/trunk_clang_38@silicon-docker/1185552
:<
> [email protected] wrote:
> > http://ci.rvm.jp/results/trunk-test@frontier/1153126
ko1: is frontier also on Docker? I seem to remember hearing of
some UDP problems... -
- [email protected] wrote:
> http://ci.rvm.jp/results/trunk-test@frontier/1153126
Oh, different test, that is test_timestampns getting stuck.
Trying r64157:
test/socket/test_socket.rb (test_timestampns): retry send
It looks like we... -
- Applied in changeset trunk|r64157.
----------
test/socket/test_socket.rb (test_timestampns): retry send
It looks like we need to retry test_timestampns in addition
to test_timestamp; so share some code while we're at it.
cf. http://ci... - 09:13 PM Revision 8c2ae6e3 (git): thread_pthread.c (gvl_acquire_common): persist timeout across calls
- Reuse old expiration time if the previous native_cond_timedwait
did not return ETIMEDOUT. This should improve timeslice
accuracy for Timeout.timeout rubyspec without causing excessive
wakeups on uncontended GVL acquisition.
cf. http://... -
07:46 PM Bug #14959: Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
- Minimal reproduction steps.
~~~ruby
code = <<~CODE
module ApplicationHelper
def broken_helper_in_application_helper
if true
else
link_to 'somewhere', some_view_path(foo: 'false')
end
end
end
CODE
RubyV... -
07:00 PM Bug #14959 (Closed): Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
- # Disclaimer
Sorry about the problem being rails, and not ruby specific. I couldn't narrow down the problem and wording it correctly.
As it turns out that the problem derived from the ruby vm used in my Rails application, I decided to... -
07:38 PM Bug #14960 (Closed): Segmentation fault
- rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/bootsnap-1.3.0/lib/bootsnap/compile_cache/iseq.rb:12: [BUG] Segmentation fault at 0x0000000000000000
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin17] -
04:13 PM Bug #11370 (Closed): Use slightly less strict test for heap_eden_pages
- Closing this as it doesn't seem to be an issue in recent Ruby/OpenBSD versions.
-
- I changed the failing test from test_unload_units to test_compile_insn_putspecialobject_putiseq in r64163 because unload_units is actually working fine and the bad one is putiseq.
-
- Yeah, the status is intentional. I checked many things for linking `rb_mRubyVMFrozenCore` properly but still no luck.
We may be able to avoid referring to `rb_mRubyVMFrozenCore`, but we have no confidence on performing link and load o... -
- @k0kubun
Re above message, after r64161, JIT tests are working again. I tried test_unload_units, and that is still failing. Also, the build was using gcc 8.2.0.
Thanks for the work, and I'll run r64162 soon, Greg - 03:35 PM Revision 0a03394b (git): * 2018-08-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64164 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Actually unload_units is working on MinGW, but putiseq is behaving
badly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64163 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- because linking multiple .o files is problematic without having `static`
to the same function definitions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64162 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- is specified.
This is needed for MinGW because MJIT_BUILD_DIR doesn't prefix path
like "C:\msys64", so it can't be read without msys2's conversion.
The workaround is not needed for Windows (LOAD_RELATIVE looks defined by
default) anywa... -
- on MinGW with __atomic_exchange_n(). It returns the previous pointer value but
obviously it's not needed in MJIT's usage.
mjit.c: In function 'compact_all_jit_code':
ruby_atomic.h:11:36: warning: value computed is not used [-Wunused-val... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64159 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:16 AM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
- After getting the feedback here, I no longer support my original proposal. But I would be happy if something like `Object#iff?` existed instead. I think logical equivalence is a legitimate use case. And alternaive expressions for logical...
- 06:09 AM Revision 6f7b3de1 (git): * 2018-08-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64158 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:09 AM Revision 12f11714 (git): test/socket/test_socket.rb (test_timestampns): retry send
- It looks like we need to retry test_timestampns in addition
to test_timestamp; so share some code while we're at it.
cf. http://ci.rvm.jp/results/trunk-test@frontier/1153126
[ruby-core:88104] [Bug #14898]
git-svn-id: svn+ssh://ci.ruby-... -
- Wow awesome news @normalperson this is going to make a massive difference with Ruby 2.6!
08/01/2018
-
- I agree that the max performance issue is likely to be a rare case; I am happy to leave it as-is.
Apologies on the second issue - I originally misunderstood "ignore" to mean "don't rescue".
I've attached another updated patch - it ... -
10:54 PM Bug #14716: SecureRandom throwing an error in Ruby 2.5.1
- We also got this error after upgrading to 2.5.1 (we had been on 2.4.2). We're also on a v3.13 kernel (3.13.0-24-generic). `cat /dev/urandom` produces output, and the errors are intermittent. Over the past day, `failed to get urandom` was...
-
- normalperson (Eric Wong) wrote:
> We will probably match arenas to Guild count dynamically;
> ...
Ah, great to know! I have no objection then.
> I don't know about ko1's timeline, but glibc releases every
> ...
It sounds like th... -
- [email protected] wrote:
> The question then becomes: What happens when Guilds land?
We will probably match arenas to Guild count dynamically;
depending on whether the program uses Guilds or not.
glibc checks arena_max whenever... -
- The question then becomes: What happens when Guilds land?
It will be a hard choice to have slow allocations when there are many guilds,
or remove this behavior and regress on existing programs not using guilds.
What does @ko1 think ... -
- > https://bugs.ruby-lang.org/issues/14759#change-73263
Btw, has anybody tested this patch with various allocators
to ensure it doesn't trigger a conflict (resulting in a
segfault) when using the other allocator via LD_PRELOAD?
jem... -
- > https://bugs.ruby-lang.org/issues/14759#change-73263
Another followup on this, current glibc 2.28 still creates
arenas without checking for contention, first. It can create
(nproc * 8) arenas on 64-bit and (nproc * 2) on 32-bit.... -
- Koichi / Nobu
Is there any chance we can merge this in and even backport to 2.4/2.5.
It is a very safe change for now and users can override the behavior if they need to using ENV (rare cases where you say host a ton of V8 runtim... -
03:21 PM Bug #14958 (Closed): rand(endless_range) raises TypeError (no implicit conversion of Range into Integer)
- I think TypeError message is a bit strange.
```console
$ ruby -v
ruby 2.6.0dev (2018-08-01 trunk 64154) [x86_64-linux]
$ ruby -e 'p rand(1..1)'
1
$ ruby -e 'rand(1..)'
Traceback (most recent call last):
1: from -e:1:in ... -
- Very recently MSYS/MinGW updated gcc from 7.3.0 to 8.2.0. For the most part, every test suite runs fine except the bootstraptest test, which has a single failure on Appveyor:
```
#1379 test_thread.rb:
Thread.new("foo", &Objec... -
- [email protected] wrote:
> As much as we like to think of jemalloc as a silver bullet of
> sorts... there are problems... In particular if you have THP
> enabled which most people do out of the box its behavior is
> not ideal de... -
03:41 AM Feature #14718: Use jemalloc by default?
- sam.saffron (Sam Saffron) wrote:
> After spending a bit too much time thinking about this, I would like to recommend **against** any jemalloc related changes and instead to double down on Eric's https://bugs.ruby-lang.org/issues/14759 f... -
- > Are you using LD_PRELOAD instead?
Yes that is how we deploy PRD we compile without jemalloc and then just ld preload various libs via environment depending on what we are testing.
btw... jemalloc with THP off is really good, its... -
- > Testing the following patch with
> "MALLOC_ARENA_MAX=1 MALLOC_ARENA_TEST=1 make gcbench-rdoc"
> seems show a small improvement in VmHWM across repeated
> runs, but the results aren't stable...
>
> https://80x24.org/spew/2... -
12:55 AM Feature #14718: Use jemalloc by default?
- Sam, I'm ok with your suggestion, any progress here is welcome. The main issue with tcmalloc is that Ruby doesn't support it out of the box with a `--with-tcmalloc` flag. Are you using LD_PRELOAD instead?
-
- After spending a bit too much time thinking about this, I would like to recommend **against** any jemalloc related changes and instead to double down on Eric's https://bugs.ruby-lang.org/issues/14759 for the next release of Ruby (which I...
-
09:58 AM Bug #7750 (Rejected): ＧＣ中にオブジェクトが割り当てられる
- 1.9.3 はすでにサポートを終了しているバージョン、かつ現在の安定バージョンの Ruby では GC の仕組みを大きく変わっているのでクローズします。
-
- 1.9.3 is already EOL status. If you have the same issue with the latest stable version of Ruby, Please report again.
Thanks. -
- [email protected] wrote:
> It causes system call and extra overhead so that I'm not sure
> it is acceptable.
> On previous proposal I could measure some performance down on
> fine-grain madvise.
OK. I am worried about that, too.
... -
06:53 AM Feature #14955: [PATCH] gc.c: use MADV_FREE to release most of the heap page body
- It causes system call and extra overhead so that I'm not sure it is acceptable.
On previous proposal I could measure some performance down on fine-grain madvise.
https://bugs.ruby-lang.org/issues/12236
I assume that we need to mak... -
- gc.c: use MADV_FREE to release most the heap page body
On x86 and x86-64 Linux and FreeBSD (at least), we can release
most of the heap page body (12k of nearly 16k). This is better
than causing malloc fragmentation with free(3) on ... -
06:20 AM Misc #14921: DevelopersMeeting20180809Japan
- sam.saffron (Sam Saffron) wrote:
> really hoping we can make a call on:
> ...
@sam.saffron: Please follow the format; not everybody can remember numbers. So this should be
* [Feature #14759] set M_ARENA_MAX for glibc malloc
> I... -
- really hoping we can make a call on:
https://bugs.ruby-lang.org/issues/14759
I would also very much like to see it backported 2.4 and 2.5. It is of enormous value to the ecosystem
-
- * [Feature #14869] Proposal to add Hash#=== (nobu)
* [Feature #14916] Proposal to add Array#=== (aycabta)
* [Feature #14912] Introduce pattern matching syntax
I believe that these three items are related, and personally I could do a... -
03:54 AM Misc #14956: Remove staled branches in svn repository
- v1_* branches are just like ruby_2_* branches.
Please keep them. -
- the ruby svn repository has a lot of staled branches.
I will remove the following branches for migrating git.
```
half-baked-1.9
KEIJU
KOSAKO
matzruby
mvm
new_gc
rexml_adds_tests
ricsin
RUBY
ruby_m17n
SER
SHIGEO
SPCOLT... -
-
03:40 AM Revision e62214be (git): move atomic logic from mjit.c from ruby_atomic.h
- This macro shall be shared among other files, not just for mjit.c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64156 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64155 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- There was a previous discussion on this which had many good details and discussion:
https://bugs.ruby-lang.org/issues/14709
@zverok and I had done some work and writing on this which may yield some new ideas.
07/31/2018
-
- Eric, thanks to the header information, I could fix at least the RubyCI's Debian 7.11 i686.
-
- Applied in changeset trunk|r64138.
----------
transform_mjit_header.rb: accept having attribute
between a type of return value and function identifier. Like:
```
rb_control_frame_t *
__attribute__ ((__fastcall__)) rb_vm_opt_struct_are... -
- jeremyevans0 (Jeremy Evans) wrote:
> sawa (Tsuyoshi Sawada) wrote:
> ...
I agree. Because of the existing mixed semantics, and predicates returning `Integer`s, I'm wary of using `^` as a general purpose logical operator. However, `!a ^... -
- danga (Dan Garubba) wrote:
> Sure. In my day job, I write testing code. So I've written an expression like:
> ...
The code and the explanation differ.
If the former is correct, the latter should be:
"raise an error unless the actio... -
- sawa (Tsuyoshi Sawada) wrote:
> I propose to extend the exclusive or operator `^` to be defined on `Object`. For `Integer`, the method would be overwritten by the current bitwise operator, and it would not benefit from the extension, bu... -
07:28 AM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
- I propose to extend the exclusive or operator `^` to be defined on `Object`. For `Integer`, the method would be overwritten by the current bitwise operator, and it would not benefit from the extension, but making it available for other c...
-
- Thanks. Essentially, this helper is a form of the boolean singleton normalization I apply at the application level.
I understand there should be a high threshold for introducing new operators into a language, so I wanted to see if an... -
- How about defining a helper function for your assertions?
```
def assert_same_as_boolean(x, y)
raise MyError unless !x == !y
end
assert_same_as_boolean(in_scenario_x?, actions_performed_for_scenario_x?)
```
It would be a g... -
- @k0kubun
I just built ruby 2.6.0dev (2018-08-01 trunk 64153) [x64-mingw32], and every JIT test is showing stderr as:
```
Failure in MJIT header file name initialization
```
The previous build was r64137. If you need an interm... -
- [Fix GH-1923]
From: Andrea Gómez <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64154 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64152 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:02 PM Revision e4aca224 (git): * 2018-08-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64151 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- If you want to suppress warnings, you can use `undef_method` instead of `remove_method` for the time being.
```ruby
module M
def foo; end
end
class C
include M
undef_method(:foo) if method_defined?(:foo)
define_method(:... - 02:21 PM Revision 8b310ae7 (git): merge revision(s) 60011:
- test_gc.rb: relax criterion
* test/ruby/test_gc.rb (TestGc#test_expand_heap): relax the
criterion and compare by epsilon.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@64149 b2dd03c8-39d4-4d8f-98ff-823... -
- ruby_2_4 r64148 merged revision(s) 63512,63514.
- 02:12 PM Revision 9f86a436 (git): merge revision(s) 63512,63514: [Backport #14790]
- time.rb: fix parsing time zone in iso8601
* lib/time.rb (Time.xmlschema): a colon in time zone designator
can be omitted. [ruby-core:87277] [Bug #14790]
time.rb: fix parsing time zone in iso8601
* li... -
- ruby_2_4 r64147 merged revision(s) 63417.
- 02:01 PM Revision 607d93b9 (git): merge revision(s) 63417: [Backport #14756]
- error.c: check redefined backtrace result
* error.c (rb_get_backtrace): check the result of `backtrace` even
if the method is redefined. [ruby-core:87013] [Bug #14756]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/bran... - 01:54 PM Revision 312de7a9 (git): backport openssl v2.0.8 [Backport #14754]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@64146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64145 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- to reduce "SKIPPED" logs on MJIT header build.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64144 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- when $MJIT_SEARCH_BUILD_DIR is set.
If prefix path is owned by root, `make install` needs to be run by root.
But in general we don't want to run `make test-all`, and also running
`make test-all` currently fails due to permission tests o... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64142 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64140 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64139 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- between a type of return value and function identifier. Like:
```
rb_control_frame_t *
__attribute__ ((__fastcall__)) rb_vm_opt_struct_aref(rb_execution_context_t *ec, rb_control_frame_t *reg_cfp)
{
...
}
```
[Bug #14949]
git-svn-... -
- * [Feature #14954] Add :wait option to RubyVM::MJIT.pause
* Since it's not released even in preview2 yet, is it okay to change the behavior?
* Is there any objection for having the option or the option name? -
- ## Problem
To measure an MJIT-generated code's performance, currently we need to do `sleep ...; RubyVM::MJIT.pause` and it's hard to decide an appropriate sleep seconds.
## Solution
Add an :wait option (default: true) and:
~~~ ru... -
- Wrongly created in ruby-dev... I'll re-create this on ruby-core.
-
- ## Problem
To measure an MJIT-generated code's performance, currently we need to do `sleep ...; RubyVM::MJIT.pause` and it's hard to decide an appropriate sleep seconds.
## Solution
Add an :wait option (default: true) and:
~~~ ru... -
- * test/ruby/test_thread_{cv,queue}.rb: Move under the test/ruby directory.
and rename TestThread* from Test*.
* test/test_sync.rb: Move toplevel of test diretory because sync is still
standard library.
git-svn-id: svn+ssh://ci... -
01:52 AM
Feature #14473: Add Range#subrange?
- Thank you for the new patch.
At the first issue, I understood max method has performance issue at that case.
But how often will we encounter it? I think it is a very rare case.
Or please show the application.
At the second issue... -
- Hi tarui, thank you for reviewing and your suggestion/question.
In fact, with my v4 patch in the case you describe there is a bug: `(1..3).cover?(1.0...4.0)` is `true` not `false`. This is prevented using `b >= (c...d).max` as you su... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64136 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:33 AM Revision 931cda4d (git): test/ruby/test_io.rb (test_race_gets_and_close): use SIGABRT on timeout
- I can't reproduce the test failure and I'm still not sure what's
wrong, but maybe we can get a core dump from P895:
http://ci.rvm.jp/results/trunk@P895/1174672
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64135 b2dd03c8-39d4-4d8f-9... -
- davidtgoldblatt (David Goldblatt) wrote:
> I don't think this benchmark is a useful way to compare performance between versions 3 and 5 of jemalloc. In between them was the advent of time-based purging, where the allocator waits for a w...
07/30/2018
-
- I'm investigating this. It looks like a symbol (of rb_mRubyVMFrozenCore) referred from /tmp/_ruby_mjit_pXXXuYYY.so is resolved to an address which is different from the address in ruby.exe. `rb_class_of((VALUE)rb_mRubyVMFrozenCore)` beco...
-
- > yet, sky3 had a failure at
> http://ci.rvm.jp/results/trunk-test@ruby-sky3/1173398 and it
> might be related. Investigating...
I thought r64133 fixed it, but I still saw this failure:
http://ci.rvm.jp/results/trunk@P895/11739... -
- [email protected] wrote:
> Congrats to achieve this. I think this should be a notable
> change written in NEWS :)
Thanks, I plan to :> I don't think we're out of the woods,
yet, sky3 had a failure at
http://ci.rvm.jp/result... -
- Congrats to achieve this. I think this should be a notable change written in NEWS :)
-
10:46 PM Feature #14718: Use jemalloc by default?
- davidtgoldblatt (David Goldblatt) wrote:
> I don't think this benchmark is a useful way to compare performance between versions 3 and 5 of jemalloc. In between them was the advent of time-based purging, where the allocator waits for a w... -
08:27 PM Feature #14718: Use jemalloc by default?
- I don't think this benchmark is a useful way to compare performance between versions 3 and 5 of jemalloc. In between them was the advent of time-based purging, where the allocator waits for a while (by default, around 10 seconds) before ...
-
- Got it, thanks @fweimer.
I did run a test with **jemalloc 5.1** and I've got the same results as you did.
```
Min. :242.9
1st Qu.:1593.5
Median :1737.7
Mean :1691.5
3rd Qu.:1860.0
Max. :2127.9
```
Remembering my pre... -
01:20 PM Feature #14718: Use jemalloc by default?
- andresakata (André Guimarães Sakata) wrote:
> Hello @fewimer, very interesting.
> ...
In the first test, yes, but I did not quote those numbers. The first quoted numbers are for untuned glibc 2.26.
-
- Hello @fewimer, very interesting.
Just to understand one thing, were you using MALLOC_ARENA_MAX=2 in your first test? -
- I can reproduce your MALLOC_ARENA_MAX=2 number.
But my untuned glibc 2.26 numbers are slightly worse (presumably due to the thread cache, which delays coalescing even further):
~~~
count 5000.000000
mean 2299.963311
std ... -
- [email protected] wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=14581
> The Ruby allocator calls posix_memalign (16384, 16344), and
> unfortunately, such allocations, when freed, can not always be
> reused for subseque... - 09:48 PM Revision 86d35a6b (git): thread_pthread.c (unregister_ubf_list): assert unblock.func is unset
- We must not allow reentry into ubf_list_head once we delete
ourselves, otherwise we could hang in there forever.
[ruby-core:88218] [Bug #14945]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64134 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > https://bugs.ruby-lang.org/issues/14945
Actually, r64083 may not be completely safe, either, as
the list_empty checks are dangerous, at least w/o GVL.
However, this order must be enforced:
unblock_function_clear
unregiste... -
09:16 PM Bug #14952 (Closed): [Docs] Backport r64057 to ruby 2.5
- Please backport r64057 (https://github.com/ruby/ruby/commit/ac1193d38f12e6ce5106f5413bcc57b6f585a2a1) since the bug also applies to ruby-2.5 documentation.
-
- I'm also seeing a lot of error text, 395 items in the errs array. Asserts pass up to the assert_equal at line 562. The matches on errs[10] & errs[11] exist, but they're at 201 & 202 respectively.
I've got `rb_mjit_min_header-2.6.0.h... -
- Header from native 32-bit machine (can't attach multiple files
w/o JS, it seems)
-
- Attached is rb_mjit_header.h from a 32-bit userspace on 64-bit kernel/HW
and mjit_header_i686_native.h from a 32-bit machine
-
- Eric, thanks to notify this. To fix it, I want to know the content of MJIT header files. I could see debian i686-linux on rubyci was failing in the same reason, but it looks a little hard to know the path of MJIT header from test_jit.rb ...
-
- Sure. In my day job, I write testing code. So I've written an expression like:
~~~ ruby
raise MyError unless in_scenario_x? == actions_performed_for_scenario_x?
~~~
To express: "raise an error unless the actions are performed for... -
02:31 PM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
- Can you show me examples of concrete usage of the proposed operator?
Your explanation is a bit vague.
Matz.
-
- I am not sure if the trade off of adding a new operator is worth it in
this case, even well aside from backwards compatibility here.
But that's just my personal opinion. -
- It conflicts with the existing syntax, `a=?b`.
-
- I propose adding a new operator for truthy/falsy equivalence, similar to what was proposed on https://bugs.ruby-lang.org/issues/13067, but with new syntax. The main purpose would be for writing expressions for logical equivalence (i.e., ...
- 06:53 PM Revision 508f0031 (git): thread_pthread.c (gvl_yield): do ubf wakeups when uncontended
- Not having contention for GVL could mean everybody else is stuck
in blocking region without GVL, so we kick the ubf list in that
case.
I expect this to fix test_thread_fd_close timeout:
http://ci.rvm.jp/results/trunk-test@ruby-sky3/1173... -
04:35 PM Bug #14009: macOS High Sierra and “fork” compatibility
- nagachika (Tomoyuki Chikanaga) wrote:
> ruby_2_4 r61358 merged revision(s) 60182.
With 2.4.4 (ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-darwin17]), I am still seeing
09:27:49 processor.1 | objc[44872]: +[__NSCFConstantS... -
- It is now registered for the next upcoming developer meeting at:
https://bugs.ruby-lang.org/issues/14921
(I think nobu added it to the developer meeting recently; it was most likely
forgotten for some time).
Hopefully future pa... -
- Sorry, it was my mistake.
-
- It still happens at `TestOpen3#test_pipeline_start`.
And it seems less frequently with -O0 than with -O3.
-
- normalperson (Eric Wong) wrote:
> I wrote:
> ...
It seems fixed, thanks.
> (Maybe reverting r64123 helps, too)
The crash had happened since r64110, I don't think it would help.
-
- I wrote:
> I wonder if condvars on OSX has a "memory" of which mutexes
> are associated with it. If so, that would be a problem with
> the rewritten GVL. So maybe a second condvar is necessary
> in native_thread_data.
Maybe usi... -
- [email protected] wrote:
> normalperson (Eric Wong) wrote:
> > [email protected] wrote:
> > > Since r64107, `make test-all` crashes by EINVAL at `pthread_cond_timedwait`.
> > > Attached logs at r64113.
> >
> > I think r6411... -
- normalperson (Eric Wong) wrote:
> [email protected] wrote:
> ...
It still happens at r64123.
> If not, we can try using:
> ...
It didn't help unfortunately.
Other than `[BUG]`, drb/ut_large.rb can hang forever. -
- [email protected] wrote:
> Since r64107, `make test-all` crashes by EINVAL at `pthread_cond_timedwait`.
> Attached logs at r64113.
I think r64117 will solve this (can't reproduce the problem, but
I understand it).
("process.c ... -
-
- Since r64107, `make test-all` crashes by EINVAL at `pthread_cond_timedwait`.
Attached logs at r64113. -
- @normalperson
Eric, r64111 passed Appveyor mswin & MingW (ruby-loco). Travis also.
Thanks, Greg -
- [email protected] wrote:
> 1) Failure:
> TestQueue#test_thr_kill [/home/travis/build/ruby/ruby/test/thread/test_queue.rb:153]:
> only 0/250 done in 60 seconds.
Yep r64109 wasn't sufficient; but I'm working on it. -
- @normalperson Eric,
Thanks. mswin passed, I haven't checked MinGW yet. Bad news is the Travis build had the following error in test-all:
```
1) Failure:
TestQueue#test_thr_kill [/home/travis/build/ruby/ruby/test/thread/test_q... -
- OK, r64110 should work. I mangled #ifdef nesting in r64109 :x
-
- Applied in changeset trunk|r64110.
----------
thread.c: move ppoll wrapper into thread_pthread.c
thread_pthread.c relies on ppoll for rb_sigwait_sleep, so ensure
the compatibility wrapper is available for it.
[Bug #14950]
Reported-by... -
- I got another error with macOS.
- 03:21 PM Revision 2a4e8c17 (git): * 2018-07-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64132 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * thread_pthread.c (USE_NATIVE_SLEEP_COND): revised wrongly removed
line with the ifndef guard.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64131 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r64130 merged revision(s) 63741.
- 02:15 PM Revision 8f2e9879 (git): merge revision(s) 63741: [Backport #14868]
- process.c (ruby_fork_ruby): fix race in signal handling
We must block signals before stopping timer-thread, otherwise
signal handing may be delayed until (and if) another signal
is received after timer-thread is ... -
- ruby_2_4 r64129 merged revision(s) 63727.
- 02:11 PM Revision cd5c3d12 (git): merge revision(s) 63727: [Backport #14865]
- vm.c: fix infinite loop
* vm.c: use EXEC_EVENT_HOOK_AND_POP_FRAME. While exception handling, if an exception
is raised in hooks, need to pop current frame and raise this raised exception by hook.
[ruby-dev:505... -
- ruby_2_4 r64128 merged revision(s) 63698.
- 02:06 PM Revision 5b5739df (git): merge revision(s) 63698: [Backport #14856]
- lib/drb/extservm.rb (service): do not return `false'
invoke_service_command may set entries in @servers to `false',
making it incompatible with the intended use of the
safe navigation operator.
This caus... -
- ruby_2_4 r64127 merged revision(s) 63112.
- 02:00 PM Revision 08c74b75 (git): merge revision(s) 63112: [Backport #14818]
- Remove outdated example from Numeric documentation
Since 2.5, Numeric instances can be cloned and duplicated.
[Fix GH-1850]
From: Miguel Landaeta <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- ruby_2_4 r64126 merged revision(s) 63571,63572.
- 01:57 PM Revision b6ab48d8 (git): merge revision(s) 63571,63572: [Backport #14816]
- `int isnan(double)` is a POSIXism
- `isnan` is something relatively new. We need to provide one for
those systems without it. However:
- X/Open defines `int isnan(double)`. Note the `int`.
- C99 defin... -
- ruby_2_4 r64125 merged revision(s) 63549,63551,63554.
- 01:54 PM Revision 7367d5db (git): merge revision(s) 63549,63551,63554: [Backport #14805]
- memo->u3.cnt is long not int [Bug #14805]
enum.c: mitigate overflows
* enum.c (enum_count): convert counters to Integer as unsigned
long, instead of long, to mitigate overflows.
[ruby-core:87348] [Bu... - 09:54 AM Revision a038bf23 (git): thread_pthread.h (native_thread_data): split condvars on some platforms
- Maybe some platforms have strange condition variable implementations
which have a "memory" of which mutexes they're associated with.
In any case, it makes documentation easier even on GNU/Linux and
FreeBSD.
git-svn-id: svn+ssh://ci.rub... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64123 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64122 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64121 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:13 AM Feature #6284: Add composition for procs
- matz (Yukihiro Matsumoto) wrote:
> Considering the combination of OOP and FP, it seems a good idea to adding both forward and reverse combination of procs. So we pick Groovy way (adding `<<` and `>>` methods to `Proc`).
What do you t... - 08:05 AM Revision ebfc4485 (git): bootstraptest/runner.rb: speed up assert_finish with IO.select (take #2)
- Resurrect r63754 in a 1.8-compatible way. While we're at it,
add a note to maintain 1.8 compatibility (cf. r63757).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64120 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18) reportedly fails to compile
cf: https://rubyci.org/logs/rubyci.s3.amazonaws.com/centos6/ruby-trunk/log/20180726T093003Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64119 b2... -
Thank you for your patch owst.
I reviewed it and feel the behavior below is strange.
~~~
$ ruby -e 'p (1..3.1).cover?(1...3)'
true
$ ruby -e 'p (1..3.1).cover?(1...4)'
Traceback (most recent call last):
1: from -e:1:i...-
- We see several occurrence of "diagnostic push/pop" so why not
make them macros. Tested on GCC8 / Clang 6.
Note that ruby.h is intentionally left untouched because we don't
want to introduce new public macros.
git-svn-id: svn+ssh://ci... - 06:35 AM Revision 7018acc9 (git): process.c (waitpid_nogvl): prevent conflicting use of sleep_cond
- We reuse sleep_cond for waitpid notifications as well as GVL
waiting. So we must take care to not hold onto sleep_cond
when we try to reacquire GVL.
[ruby-core:88183]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64117 b2dd03c8-39... - 06:02 AM Revision 56491afc (git): thread_pthread.c (rb_sigwait_sleep): th may be 0 from MJIT
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64116 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:51 AM Revision ab47a57a (git): thread*.c: waiting on sigwait_fd performs periodic ubf wakeups
- We need to be able to perform periodic ubf_list wakeups when a
thread is sleeping and waiting on signals.
[ruby-core:88088] [Misc #14937] [Bug #5343]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64115 b2dd03c8-39d4-4d8f-98ff-823fe... - 05:51 AM Revision 95cae748 (git): thread_pthread.c (gvl_destroy): make no-op on GVL bits
- It's possible for another thread to take vm->gvl.lock
during gvl_release at the end of thread_start_func_2
during VM shutdown, at least.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64114 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:28 AM Revision 45143629 (git): thread_pthread.c (rb_sigwait_sleep): fix uninitialized poll set in UBF case
- [ruby-core:88088] [Misc #14937] [Bug #5343]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64113 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64112 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:28 AM Revision 26b8a70b (git): thread_pthread.c (rb_sigwait_sleep): re-fix [Bug #5343] harder
- We can't always designate a timer thread, so any sleepers must
also perform ubf wakeups. Note: a similar change needs to be
made for rb_thread_fd_select and rb_wait_for_single_fd.
[ruby-core:88088] [Misc #14937] [Bug #5343]
git-svn-id... -
- mtsmfm (Fumiaki Matsushima) wrote:
> ~~~ruby
> ...
This warning dispatches `on_arg_ambiguous` method.
> - How can I get the range of code instead of lineno and column only?
No way right now.
I think you can propose new methods f... - 12:31 AM Revision 3dc7727d (git): thread.c: move ppoll wrapper into thread_pthread.c
- thread_pthread.c relies on ppoll for rb_sigwait_sleep, so ensure
the compatibility wrapper is available for it.
[Bug #14950]
Reported-by: SHIBATA Hiroshi <[email protected]>
Reported-by: Greg L <[email protected]>
git-svn-id: svn+s...