Activity
From 10/27/2021 to 11/02/2021
11/02/2021
-
06:52 PM Revision 4b248e79 (git): string.c: Follow up to ae2359f602bb467ca755eef02d73d361d35eaed7
- * Mention `\0`
* Make the example of hash replacement meaningful -
- > we ran into this issue on one of our internal testing applications.
Let me confirm: you are facing this issue whe... -
03:53 PM Feature #18285: NoMethodError#message uses a lot of CPU/is really expensive to call
- If applicable, I suggest to do what we do in Rails: https://github.com/rails/rails/blob/f95c0b7e96eb36bc3efc0c5beffbb...
-
02:32 PM Feature #18285: NoMethodError#message uses a lot of CPU/is really expensive to call
- Yeah, I think it's useful to include the object class and possibly its id, but with the default `#inspect` behavior o...
-
12:50 PM Feature #18285: NoMethodError#message uses a lot of CPU/is really expensive to call
- I think we've had this report multiple times, it's a trade-off between efficiency and useful information being shown....
-
- Hello there! I'm working at Datadog on the ddtrace gem -- https://github.com/DataDog/dd-trace-rb and we ran into this...
- 06:05 PM Revision a4f834c4 (git): * 2021-11-03 [ci skip]
-
06:04 PM Revision ae2359f6 (git): Enhanced RDoc for String (#5060)
- Treated:
#slice!
#sub
#sub!
#gsub
#gsub! -
- The check had not work because "headers" were not passed.
-
12:46 PM Bug #18284: Macosx M1
- Although we have received several reports that `pod` did crash on M1 Mac (see e.g. #17922, #17988, #18043), I cannot ...
-
09:32 AM Bug #18284 (Rejected): Macosx M1
- crash at pod update
`{"app_name":"ruby","timestamp":"2021-11-02 10:17:47.00 +0100","app_version":"","slice_uuid":"72... -
- @mame ah you beat me to it, I use a different approach but I don't know if it's any better than yours: https://github...
-
- I've created a PR: https://github.com/ruby/ruby/pull/5070
-
- Okay I cloud create a small repro case:
```
class C
end
100000.times { Class.new(C) }
p C.descendants
```... -
07:46 AM Bug #18282: Rails CI raises Segmentation fault with ruby 3.1.0dev supporting `Class#descendants`
- Thanks for working this issue. Glad to hear that it reproduces.
-
- Argh, the message seems just a warning. I could run `bundle exec rake test` and reproduce the issue. Sorry for the no...
-
- Thank you for the information, but neither works. How did you setup ruby and bundler? I just did:
```
git clone h... -
- Thanks for taking care of it. In my environment `bundle install` just works fine.
then, how about using `bundle upda... -
- Thanks for the detailed report. Maybe this is a newbie question of bundler, but `bundle install` failed as follows on...
-
- This report was originally reported at Rails https://github.com/rails/rails/issues/43574
then moved to bugs.ruby-lan... -
10:17 AM Revision e0915ba6 (git): Fix typos in ChangeLog files [ci skip]
-
- 10:12 AM Revision c2dcaa73 (git): [rubygems/rubygems] Use OpenSSL constants for error codes.
- This fixes the following test error testing against OpenSSL 3.x:
~~~
2) Failure:
TestGemRequest#test_verify_certif... -
09:34 AM Revision 83704a28 (git): remove the repeat 'the'
-
- ```
$ ruby -e 'class C;end; (1..10).map { Ractor.new { 100000.times { Class.new(C) } } }.each {|r| r.take }'
<inter... -
- Readline seems to emit an escape sequence `"\e[?1034h` at an
unpredictable timing when `TERM=xterm` or something.
Thi... -
02:05 AM Feature #18280: Allow rb_utf8_str_new_cstr(NULL)
- Hmm, looking at the source code there are those functions that thoughtlessly pass their arguments to `strlen()` witho...
-
- Hello, I'm the one who wrote the comment in string.h.
- OK to remove `__attribute__((__nonnull__))` to revive `mus... - 01:24 AM Revision 38785aa3 (git): Update licenses= documentation
- 01:24 AM Revision 17f8fd65 (git): Allow custom LicenseRef
-
01:22 AM Revision b74385e7 (git): Remove SimpleCov at all.
-
01:19 AM Revision 4a391672 (git): Removed the related code of `gem server`
11/01/2021
-
11:08 PM Bug #18281: Ruby 3.1.0: gem uninstall -aIx fails to uninstall debug
- Oh also, interesting.. if I `gem install debug` and re-run `gem uninstall -aIx` it works!
```
gem uninstall -aIx
... -
- 👋 So I'm not sure this is a bug with `debug` or rubygems, but thought I'd start here.
When running `gem uninstall... -
- IMHO the gem should be fixed so it doesn't call `rb_utf8_str_new_cstr()` with NULL.
-
- ukolovda (Dmitry Ukolov) wrote in #note-4:
> I'm afraid, we got many errors with other gems, which use clang and giv... -
03:04 PM Feature #18280: Allow rb_utf8_str_new_cstr(NULL)
- That documentation was recently added: https://github.com/ruby/ruby/pull/4815 (hasn't been part of a release yet AFAICT)
-
01:39 PM Feature #18280 (Feedback): Allow rb_utf8_str_new_cstr(NULL)
-
- It is documented that the parameter for `rb_utf8_str_new_cstr` (and also for its friends) [must not be a null pointer...
-
01:08 PM Feature #18280: Allow rb_utf8_str_new_cstr(NULL)
- Thank you!
I've got this error when test gem `addressable` + `idn-ruby`.
See https://github.com/ukolovda/addressa... -
12:58 PM Feature #18280: Allow rb_utf8_str_new_cstr(NULL)
- Compiling with `-fno-delete-null-pointer-checks` prevents this check from being optimised away. Using the test script...
-
- `rb_str_new_cstr` seems to be attributed as `nonnull` since commit:091faca99ca92cb1146b3c4d8ebba67f4822561c. Thus it ...
-
- The SEGV reproduces for me with the following test case:
```ruby
require "fiddle"
include Fiddle
h = dlopen... -
- Ruby process crushed.
`
Addressable::URI when parsed from 'http://example.com/%E8'
/home/ukolovda/RubymineProjec... -
- Dan0042 (Daniel DeLorme) wrote in #note-7:
> It's not uncommon for a proc to have behavior that is independent of `s... -
02:14 AM Bug #18243: Ractor.make_shareable does not freeze the receiver of a Proc but allows accessing ivars of it
- It's not uncommon for a proc to have behavior that is independent of `self`. Let's say:
Ractor.make_shareable... - 03:28 PM Revision 1d88eec8 (git): * 2021-11-02 [ci skip]
-
03:28 PM Revision ed0f326e (git): [rubygems/rubygems] Leave ":" after MANPATH when not set
- So that system man pages still work after a gem with man pages overrides
it.
https://github.com/rubygems/rubygems/co... -
02:54 PM Revision 2fa51c70 (git): YJIT: Support kwargs sends with all defaults (#5067)
- * YJIT: Support kwargs sends with all defaults
Previously keyword argument methods were only compiled by YJIT when a... -
08:48 AM Revision b474049c (git): [ruby/openssl] x509name: improve docs for X509::Name
- Add docs for X509::Name.parse_openssl and X509::Name.parse_rfc2253,
which are currently undocumented despite being wi... -
- OpenSSL::SSL::SSLSocket allowed #read and #write to be called before an
SSL/TLS handshake is completed. They passed u... -
07:32 AM Feature #15667: Introduce malloc_trim(0) in full gc cycles
- Wouldn't that be a good feature in combination with GC auto_compaction? First run the auto_compaction against memory ...
- 07:07 AM Revision f0226f9a (git): Update bundled_gems at 2021-11-01
-
-
- Why not `proc.bind(obj).call` ? It seems a more "proper" API, more composable. You can bind once and then call multip...
10/31/2021
- 05:01 PM Revision 266c90ea (git): * 2021-11-01 [ci skip]
-
- Calling `Bundler.definition.specs` will memoize materialized specs.
However, requiring `bundler/setup` will end up ma... -
- Applied in changeset commit:git|13a9597c7ca83fced5738e9345660ae6aef87eb7.
----------
Argument forwarding definition ... -
- 06:16 AM Revision 7da6e9b3 (git): * 2021-10-31 [ci skip]
-
-
-
04:29 AM Revision b1696c87 (git): test_gc.rb: relax criterion
-
10/30/2021
-
- Indeed, it looks related, thanks.
I did a quick google search before but didn't find it.
The advantage of this repr... -
- I believe it's a duplicate of [Bug #18058]
-
- I also tried with latest master as of today:
`ruby 3.1.0dev (2021-10-30T10:24:41Z master a46c220320) +JIT [x86_64-li... -
- To repro:
```
$ git clone https://github.com/Shopify/yjit-bench.git
$ cd yjit-bench
$ ruby --jit -I./harness benc... -
05:00 PM Feature #18279 (Closed): ENV.merge! support multiple arguments as Hash.merge!
- I give a useful example for this.
```rb
require 'yaml'
env_files = ['config.yml', 'config.local']
envs = env_fi... -
- According to the log, it is very likely to be a problem with gtk3. Could you contact on the author of the gem?
I g... -
04:14 PM Bug #18278 (Third Party's Issue): SegFault on exit from gtk3 app
- I try to implement my gtk3-based app to organize my books/music/etc.
After adding the autocompletion feature the app... -
-
- https://github.com/ruby/drb/commit/7edf67654c
-
- https://github.com/ruby/fcntl/commit/0bcc0c4518
-
-
- 11:22 AM Revision 7388a4b7 (git): * 2021-10-30 [ci skip]
-
- Bring the local copy of ruby/openssl in sync with the upstream gem
release v2.2.1. The commits happened in the upstre... -
10:24 AM Revision a46c2203 (git): Add `rb_mod_exc_raise` function and replace duplicate code
-
-
01:23 AM Revision 1d0ce1a3 (git): [DOC] Fix `TracePoint.trace` format [ci skip]
- Signed-off-by: Ulysse Buonomo <[email protected]>
-
01:18 AM Revision 4e0747a8 (git): Allow the thread-model to be switched by configure option
- This change adds --with-thread=IMPL option to the configure. If not
supplied, default implementation for each platfor... -
-
- This is a first step to allow the thread-model implementation to be
switched by configure's option -
-
01:16 AM Bug #14743 (Closed): Some links broken in README
- Applied in changeset commit:git|2898805535104c330e1e5c64c8065a108f1f2895.
----------
Use rdoc-ref to fix a few links... -
- This may break linking on GitHub, but it's more important for the
links to work in the documentation generated by rdo... -
12:59 AM Revision 09bdb435 (git): Clarify docs about magic comments placement
- Magic comments like `frozen_string_literal` may appear everywhere
within the first comment section while `encoding` h...
10/29/2021
-
- https://github.com/rubygems/rubygems/commit/28f4842196
-
- I don't like the idea to alter the semantics of Proc methods just for Ractor though (also it costs extra checks on ev...
-
- jhawthorn (John Hawthorn) wrote in #note-2:
> In Rails we use `obj.instance_exec(&proc_obj)` in a few places. One of ... -
- vinistock (Vinicius Stock) wrote in #note-3:
> Indeed I haven't thought about using `Ractor.make_shareable` in the pr... -
01:21 PM Feature #18275: Add an option to define_method to not capture the surrounding environment
- > I can't get your point.
> Methods are unrelated to Ractor.
If we create a method using `define_method`, it only... -
- Maybe it's orthogonal, but what if `define_method` accepted any object responding to `call`?
e.g.
```
class So... -
- vinistock (Vinicius Stock) wrote in #note-3:
> Indeed I haven't thought about using `Ractor.make_shareable` in the p... -
- * Make the supported check more obvious.
-
- * See https://github.com/ruby/spec/pull/891
-
06:58 PM Revision 2e14fb7d (git): Add comments about send method types (#5059)
-
- Since these regexps are used at build/installation, they are not
vulnerabilities. -
- jeremyevans0 (Jeremy Evans) wrote in #note-12:
> @matz pretty much rejected `using do` as well (https://bugs.ruby-lan... -
02:27 PM Feature #11919: Passing a module directly
- Dan0042 (Daniel DeLorme) wrote in #note-11:
> @jeremyevans0 may I ask why you closed this? Matz has not rejected thi... -
- @jeremyevans0 may I ask why you closed this? Matz has not rejected this idea. He only rejected `refine X do` (#14344)...
- 03:58 PM Revision 6cee10d8 (git): * 2021-10-30 [ci skip]
-
- Previously obj_free returned true when it could not free a slot because
of a finalizer, and false when it successfull... -
-
- In the case of read-only but refering an unshareable object.
-
-
- The ArgumentError should raise in `isolate`.
-
- https://github.com/rubygems/rubygems/commit/a77061d4e9
-
- - this exception differs across Ruby versions.
https://github.com/rubygems/rubygems/commit/38c6927a5f -
- - previously it was required already by net/http, but it is not anymore using ruby-trunk
- https://github.com/ruby/ne... -
- - latest ruby adds error_highlight gem introducing backtrace into exception message
https://github.com/rubygems/ruby... -
- - latest ruby is shipped with racc 1.6 making this spec failing
- this spec is related to platform locking, changing ... - 09:00 AM Revision 17fb785d (git): [rubygems/rubygems] Vendor tsort into rubygems
- So that it loads a consistent version of the library and `rubygems` is
never affected by gem activation conflicts rel... - 08:32 AM Revision f45af5f0 (git): Support gemification of tsort
- Co-authored-by: Frederik Dudzik <[email protected]>
Co-authored-by: Jacques Chester <jacques.chester@shopif... -
- - error_highlight was introduced at https://github.com/ruby/ruby/commit/e94604966572bb43fc887856d54aa54b8e9f7719
or... -
- https://github.com/rubygems/rubygems/commit/a81d4421b4
- 08:13 AM Revision 2a90ad7a (git): [rubygems/rubygems] use Rubocop Lint/Debugger check rather than custom spec
- We have a quality spec that check for debugger statements. Rubocop has a
cop that tests for the same thing. As such i... -
-
01:58 AM Revision ffd8592e (git): Update stdlib version
-
- This caused Bus error on 32 bit Solaris
-
- On GitHub Actions, the macOS runners seem much more expensive than
Ubuntu, and its limit is the most significant bott... -
- * The worker timeouts seem working for test-all.
* The bundled gems have increased. -
01:26 AM Feature #18020: Introduce `IO::Buffer` for fiber scheduler.
- @matz you said you are positive on this feature. Can you confirm that we can merge this PR? Even we can mark it as ex...
10/28/2021
-
- Mostly adding blank line before and after code segment, to improve compliance with doc\documentation_guide.rdoc.
-
- Looks like @matz approved this, but it was never committed. I've submitted a pull request for this that is based on ...
-
-
- Treats:
#eql?
#<+>
#floor
#ceil
#round
#truncate
#step -
- Regarding the examples, they are over simplified for the sake of understanding. Sure, you wouldn't need `define_metho...
-
- In general if `define_method` takes an existing Proc, it should IMHO behave exactly like calling that Proc.
If we do... -
- Can you tell us why you cannot define your methods using normal `def` statements? As far as I read your proposal the...
-
05:43 PM Revision e53d07f5 (git): Rename ::YJIT to RubyVM::YJIT
- Since the YJIT Ruby module is CRuby specific and not meant for general
use, it should live under RubyVM instead of at... -
- Rescuing all errors here might end up hiding other errors if the
deletion of the cached gem itself raises an error fo... -
05:00 PM Revision cbf2078a (git): need to mark script_lines
-
-
-
- In Rails we use `obj.instance_exec(&proc_obj)` in a few places. One of the downsides `instance_exec` has is that it c...
-
- I'm in favor of adding this method, and would like to see it support the following:
```ruby
pr = ->(*a, **kw, &bl... -
- `Proc#bind_call(obj)` same as `obj.instance_exec(..., &proc_obj)`
```ruby
proc_obj = proc{|params...| ...}
obj.i... - 03:28 PM Revision 3bf36979 (git): * 2021-10-29 [ci skip]
-
-
03:01 PM Feature #11919: Passing a module directly
- jeremyevans0 thanks for taking up the issue, anyway.
-
- Eregon (Benoit Daloze) wrote in #note-8:
> I guess we need to persuade matz then: https://bugs.ruby-lang.org/issues/... -
- I guess we need to persuade matz then: https://bugs.ruby-lang.org/issues/14344#note-15 (https://bugs.ruby-lang.org/is...
-
11:07 AM Feature #11919: Passing a module directly
- Discussed here, also: #16241
Copying my comment from there:
> I believe that is really a super-good thing. As I'... -
- I'm rather neutral about this.
On one hand, I think `using Module.new {` is clearer that there is a module involved ... -
- chucke (Tiago Cardoso) wrote in #note-12:
> Thx for the reply. Is import_methods a new ruby 3.1 feature?
Yes. See... -
10:47 AM Feature #12533: Refinements: allow modules inclusion, in which the module can call internal methods which it defines.
- Thx for the reply. Is import_methods a new ruby 3.1 feature?
-
- After some discussion with @ko1, it seems there are different cases.
Sharing `self` is the only way to preserve the P... -
- Sorry, I missed to paste some part of the snippet, fixed now.
-
- Relevant related discussion: https://bugs.ruby-lang.org/issues/18137#note-2
-
- I took a stab at it: https://github.com/ruby/ruby/pull/5045
-
- +1 for Class#subclasses, I think it makes sense since we have Class#descendants.
`Class#subclasses` is then also t... -
- IMHO it'd be good to rediscuss this at a dev meeting.
It seems most people agree that `Method#visibility` would be b... -
- jeremyevans0 (Jeremy Evans) wrote in #note-15:
> I've submitted a pull request that implements @matz's idea of `publi... -
- :+1:
Note there is some inconsistency with e.g. `attr_reader` always returning an array (#6470):
```ruby
class F... -
07:45 AM Feature #12495: Make "private" return the arguments again, for chaining
- I stumbled several times upon this issue. The semantics as described above are OK, IMHO. It would be nice if the patc...
-
09:21 AM Revision d51ba1e1 (git): Add changes Enumerable#each_cons and each_slice in NEWS [ci skip]
-
- zlib.net rarely returns the current time in RFC 2616 noncompliant
format in the response header, and the checksum doe... -
- Applied in changeset commit:git|1d666ed50f8b4b3779583381882a0b3edd3cff0e.
----------
Fix leap day with UTC offset [B... -
- `struct vtm::year` is a Ruby integer instance, but not a C integer
type. -
- it's start irb on built ruby (not installed ruby).
-
-
-
- ```
../gc.c:2342:45: warning: comparison of integers of different signs: 'short' and 'size_t' (aka 'unsigned long') [... -
- +1 to replace unsafe use of SHA-1, if any, to something more secure. That shall be a good thing.
-1 for its removal. -
- ```
../gc.c:2342:25: warning: array subscript is of type 'char' [-Wchar-subscripts]
GC_ASSERT(size_pools[pool_id]...
10/27/2021
-
- Since 46b66eb9e8e6de2d5750591e532310e8f8599d90, already `ary` has
been enclosed in `embed`. -
- I've submitted a pull request that implements @matz's idea of `public?`, `private?`, and `protected?`: https://github...
-
- I think this feature would be useful, and submitted a pull request to implement it: https://github.com/ruby/ruby/pull...
-
-
-
- I think it makes sense to modify private/protected/public/module_function to be like `def` and return the receiver. ...
-
- This appears to be caused by commit:bf789af28a3b7108186743f3cb4fd2f649afdd20. Reverting the commit fixes the issue. ...
-
07:05 PM Bug #18274 (Closed): Time.new initializes the date incorrectly after a leap day with a positive UTC offset
- With 3.1.0dev revision 30942c19c0, `Time.new` can initialize the date incorrectly on the day following a leap day. Th...
-
- Invoking `define_method` will capture the surrounding environment, making sure we have access to anything defined in ...
-
06:05 PM Bug #16936: `make test-all TESTS="-n !/Foo#method/"` not skipping the test case
- Setting the backport flag, because it is useful to disable some test cases in Fedora package, if needed (and it will ...
-
10:56 AM
Bug #16936 (Closed): `make test-all TESTS="-n !/Foo#method/"` not skipping the test case
- Applied in changeset commit:git|5086c25f6015558877f85c3f1c014780b08fd3ce.
----------
Properly exclude test cases.
L... - 05:00 PM Revision 30942c19 (git): * 2021-10-28 [ci skip]
-
- This change fixes `-v --yjit-stats`. Previously in this situation,
YJIT._print_stats wasn't defined as yjit.rb is not... -
- On -DRUBY_DEVEL builds, `ruby -v` can print extra info about the last
commit on a separate line, breaking some tests ... -
-
- `Refinement#include` has been deprecated. `Refinement#import_methods` can now be used to handle this use case:
```... -
-
-
-
-
- `$1` is global variable, `"#{$1}"` is evaluated BEFORE the method call, making a string "whatever was in `$1` at that...
-
11:45 AM Bug #18271 (Closed): Regexp inconsistency (repeatable)
- han:~/au> irb ...
-
- We still support `digest/md5` and `digest/rmd160`, and I doubt those are more secure than SHA-1. If the operating sy...
-
- AFAIK SHA-1 is used in Bundler/RubyGems only to hash filepath for gem clones and could be replaced in the future. It ...
-
12:00 PM Feature #18272 (Third Party's Issue): Please replace unsafe SHA1 with another digest algorithm
- ## Context
When working on a new version of RHEL (with Ruby 3.0), the requirement is to have a better security (remo... -
- * rb_bug should be variadic
* Prefer ANSI-style prototypes over old K&R-style definitions
* Add missing argument types -
- * YJIT: Implement newhash with values
* YJIT: Add test of duphash
* Fix compilation on macos/clang -
- FWIW, current usage in gems is consistent with Hash, but I did find one incompatibility in fugit-1.3.3.
actionpack-... -
- I think it's ok that we don't have some particular rules for Enumerables to return their own class. Rather than consi...
-
- I am afraid we don't have some particular rules for Enumerables to return their own class:
```ruby
Set[*1..8].selec... -
- Ref: https://github.com/rails/rails/pull/43481
Something we forgot to mention in [Feature #14394], is either a par... -
- Just realized, another way to write that roll method (without deprecation) is:
```ruby
def roll rnd = Random
rnd... - 10:56 AM Revision 5086c25f (git): Properly exclude test cases.
- Lets consider the following scenario:
~~~
irb(#<Test::Unit::AutoRunner::Runner:0x0000560f68afc3c8>):001:0> p suite
O... -
-
- I'm afraid that we can define "Isolated Proc".
As I know there are several versions.
1) self
a: self is sharea... -
- `Ractor.shareable?(proc_object)` is not enough?
-
-
-
07:13 AM Revision 489e5e3a (git): the core problem is the Proc is not shareable
-
- This is a follow-up for commit 265c0022390e ("Do not allocate
ractor-local storage in dfree function during GC", 2021... -
- Even if it's newer than the running versions. Dev versions are not
released to rubygems.org, so the warning message s... -
- Now the formatter configuration is per Ractor. DefaultFormatter is used
if not set.
DefaultFormatter#message_for is ... -
Also available in: Atom