Activity
From 08/21/2022 to 08/27/2022
08/27/2022
-
10:47 PM Revision 111b69e8 (git): Pass wait: false to avoid a timeout
-
10:13 PM Feature #18959: Handle gracefully nil kwargs eg. **nil
- > I also tend to do `**(options || {})` and I don’t write hard-to-read code like `**({id: id, name: name} if id.present?)`.
That's interesting, that you are ok for
```ruby
**(options || {})
```
but not ok for
```ruby
**(options ... -
03:16 AM Feature #18959: Handle gracefully nil kwargs eg. **nil
- It seems that `foo(*arguments)` will call `arguments.to_a` rather than `arguments.to_ary`. However, I also noticed `foo(*Object.new)` works as a single argument, which honestly seems a bit odd to me.
So:
> If we want to allow **nil, th... -
12:21 AM Feature #18959: Handle gracefully nil kwargs eg. **nil
- LevLukomskyi (Lev Lukomskyi) wrote in #note-19:
> > Both @sawa and I have provided better options than your examples.
> ...
Not at all. I’ve used `**` for a *very* long time (since kwargs were introduced). But I also tend to do `**(opt... -
- 09:42 PM Revision a797ded8 (git): typos
-
-
- http://ci.rvm.jp/results/trunk-mjit@phosphorus-docker/4213386
It's failing with:
rm: cannot remove '/tmp/ruby/v3/build/trunk-mjit/tmp/test_rubygems_20220827-13666-ii8lcp': Directory not empty
rm: cannot remove '/tmp/ruby/v3/build/trunk-... - 05:04 PM Revision 4de09574 (git): * 2022-08-28 [ci skip]
- 05:04 PM Revision 381d8e43 (git): [rubygems/rubygems] Bundler: make to_lock consistent between Gem::Dependency and Bundler::Dependency
- https://github.com/rubygems/rubygems/commit/971d57cf5a
-
04:34 PM Feature #16122: Data: simple immutable value object
- Disregard that, looked in the wrong place.
~~Hmm, folks, working on implementation on the weekend, I am a bit confused. I believe I _saw_ that in 3.2 we decided to make `Struct` more flexible, but accepting positional OR keyword args re... -
03:21 PM Feature #18951: Object#with to set and restore attributes around a block
- > But WITH is also SQL keyword and was recently added to ActiveRecord
It was added to `ActiveRecord::Relation`, which doesn't have any setters in its public API, and even if it did it still wouldn't be a concern in my opinion.
Sin... -
03:14 PM Feature #18951: Object#with to set and restore attributes around a block
- There are similar methods (`with_*`) across various popular gems. For example `I18n.with_locale(locale)`. But `WITH` is also SQL keyword and was recently added to `ActiveRecord` (https://github.com/rails/rails/commit/098b0eb5dbcf1a942c4e...
-
- > sole with feels vague a little, to me.
Well, the argument is that it's not alone, since it is used with at list one keyword argument.
`something.with` is vague I agree, but I believe that e.g.:
```ruby
GC.with(stress: true) d... -
02:58 PM Feature #18951: Object#with to set and restore attributes around a block
- I think this would be nice to have, indeed spelling it out manually is quite verbose and then we tend to have lots of helper methods for this.
For the name, `with` seems natural to me, and it's also the name of the keyword in Python use... -
02:37 PM Feature #18951: Object#with to set and restore attributes around a block
- I agree with the concept, but wonder about these names.
The meaning of `with_something_enabled` is obvious, but sole `with` feels vague a little, to me.
And `old_values` should be initialized as an empty hash, I think. -
- headius (Charles Nutter) wrote in #note-10:
> Late to the party, but why was `RegQueryInfoKey` also update to use `W`?
It seems unneeded because not using any `WCHAR` arguments.
> ...
It's done by fiddle.
https://github.com/ruby/... -
- I think those issues are revealing real problems which are worth investigating and fixing.
For instance if files are created and deleted in parallel in the same directory that seems like a good source of transient bugs waiting to happen... -
11:40 AM Feature #18784: `FileUtils.rm_f` and `FileUtils.rm_rf` should not mask exceptions
- deivid (David Rodríguez) wrote in #note-13:
> Yet this exception is showing the error when trying to remove the root directory, and not the real culprit of failing to remove one file inside. Do you know why is that?
I have no idea. P... -
11:24 AM Feature #18784: `FileUtils.rm_f` and `FileUtils.rm_rf` should not mask exceptions
- Alright, I guess it makes sense to leave things as they are.
One question I have is: I though we had removed an `ensure` that prevented the original exception from being displayed and would instead show the error when removing the roo... -
- We faced another problem on Linux.
A rubygems test uses `FileUtils.rm_rf` in `teardown`. But it randomly fails for an unknown reason (mysteriously, only on MJIT test?). This makes the `teardown` method fail to restore the environment ... -
- I think the underlying issue is we want a string append method which does not change the receiver's encoding (and instead raises an EncodingError if it would need to change it).
-
- > I hope I have not demanded anything
Yes, sorry, not what I meant, it's one of these words that has similar meaning in French, yet a radically different connotation. -
- Just to clarify I hope I have not demanded anything. "But if you want to have a go at it, that would be awesome" was all I said.
I have been trying the `buffer.force_encoding(Encoding::BINARY)` followed by `slice!` but you are right i... -
- Right, and I agree with matz that modifying ivars as the match is evaluated is problematic, I would even say it's unsound for pattern matching to have such side effects.
Testing a pattern should as much as feasible not have side effects... -
03:18 AM Feature #18408: Allow pattern match to set instance variables
- @eregon I understand what you're saying, but my statement was based on the premise "if you don't want ivars to change during match". In the PR prepared by @palkan, ivars are modified as the match is evaluated, just like local vars, and t...
-
09:04 AM Feature #18980: `it` as a default block parameter
- I also avoid using solo `_1` as I have to search for `_2` when I see `_1` in a block. It's not because of a feeling caused by the number but because the behavior of `_1` changes depending on the occurrence of `_2`.
Given that we have ... -
- FileUtils.rm_rf started to randomly fail on http://ci.rvm.jp/results/trunk-mjit@phosphorus-docker
since around https://github.com/ruby/fileutils/pull/99. - 03:56 AM Revision f97af5cd (git): * 2022-08-27 [ci skip]
-
08/26/2022
-
- > because it’s (1) wasteful
It wastes what? I don't understand this argument
> ...
This I can understand because indeed sometimes programmers can put too much in one line. However there are only two operators in that line – `if` an... -
- LevLukomskyi (Lev Lukomskyi) wrote in #note-17:
> @austin your latest example has 110 symbols, the condition should be duplicated for each new hash key, as well as the ternary operator, so it's not good. Previous example has 294 symbols... -
- Currently:
```ruby
"xyz".sub(/y/, nil) #=> TypeError: no implicit conversion of nil into String
def nil.to_hash; {} end
"xyz".sub(/y/, nil) #=> "xz"
```
Ok, the behavior is different, but it doesn't mean that we cannot implement the fea... -
- > > Currently, nobody is using `**nil` because it throws an error because `nil.to_hash` is not defined. So I don't see how adding such feature would lead to _"high probability of compatibility issues"_.
> ...
Yes, there are problems wit... -
- LevLukomskyi (Lev Lukomskyi) wrote in #note-14:
> @austin, your example is a perfect example of "overengineering".
On this, we disagree. I find the number of sigils required for `**({ id: id, name: name } if id.present?)` to be a sur... -
11:32 PM Feature #18980: `it` as a default block parameter
- If we are considering an alternative to `_1`, I'm going to vote again for `@` (bare at sign) (originally proposed in https://bugs.ruby-lang.org/issues/4475#note-10). This is currently invalid syntax, so there is no possibility of backwa...
-
- > This is a good argument, I think it would be good to add to the issue description.
I'm glad it made sense to you. Sure, I updated the issue description to include that.
> ...
I'm not sure if it's too difficult to distinguish "a metho... -
- > innocuous word
I misused `innocuous` here. I want to mean a "common word", and it's hard to notice because it's the same syntax as a local variable or method call. -
- k0kubun (Takashi Kokubun) wrote in #note-8:
> What do you mean? I thought we were talking about `_1`, not `_`. If this feature were introduced as `_`, I would use it much more often than `_1`, but [Matz finds `_` confusing](https://bugs... -
- > I regularly use _1, _2, maybe it's question of habit and getting used to it?
Matz also made that argument in the Ruby Committers vs the World 2019, saying many people started using `-> {}` after almost 100% of the people objected to t... -
- I regularly use `_1`, `_2`, maybe it's question of habit and getting used to it?
`_1` seems already used in many gems (`gem-codesearch '\b_1\b' | grep '\.rb:\s'`).
It's also a syntax used in other languages, and `_` is already establishe... -
- ## Problem
Numbered parameters (`_1`, `_2`, ...) look like unused local variables and I don't feel motivated to use them, even though I need this feature very often and always come up with `_1`.
```rb
[1, 2, 3].each { puts _1 }
```... -
- austin (Austin Ziegler) wrote in #note-55:
> Why not `Data.defclass` or `Data.deftype` or even `Data.defshape`?
Because those do not use a proper Ruby naming (no _ to separate words, aside: looks like Python matplotlib methods), they... -
- Eregon (Benoit Daloze) wrote in #note-54:
> I like `Data.define` as well, we are "defining a new subclass of Data".
> ...
Elixir uses `defmodule` for module declarations. Why not `Data.defclass` or `Data.deftype` or even `Data.defshape`? -
- I like `Data.define` as well, we are "defining a new subclass of Data".
`def` makes me thing to "define a method" since that's what the keyword of the same name does, but `Data.def` does not define a method but a class. -
- Dan0042 (Daniel DeLorme) wrote in #note-20:
> But if you don't want ivars to change during match, this *can* be fixed, for example by using temporary local vars like I suggested in #note-11. I don't think this is a fundamental problem w... -
- > it is intentional. Unsuccessful matches remain the assignment result from the internal matches
I think everyone here understood the current behavior is intentional, but the more important question would be "is it beneficial?"
> .... -
- > Why not exception: false which seems more standard and established
So after working more on using a SizedQueue in statsd-instrument, I now think `exception: false` might actually be better.
The reason is that `SizedQueue#push(ite... -
01:01 PM Bug #18899: Inconsistent argument handling in IO#set_encoding
- I ran my test against your branch, and it addresses this issue. I hope it can be incorporated soon. Thanks!
-
- Another observation is: could we opt-out of this strict behavior only on Windows, given how picky it is about deleting used files? So far the only issues found in the realworld are under Windows I believe. Fileutils already has several s...
-
- In my opinion, this is ok. I also encountered some issues in RubyGems test suite when I first enabled this behavior that led me to correct some bad tests. And it also helped me figure out realworld bugs. I understand that sometimes it ma...
-
05:34 AM Feature #18784: `FileUtils.rm_f` and `FileUtils.rm_rf` should not mask exceptions
- I also encountered a possibly related `Errno::EACCES` error on Windows (mingw) of GitHub Actions.
```
Errno::EACCES:
Permission denied @ apply2files - D:/a/_temp/d20220824-1696-gdx8qj/path/does/not/exist
```
Below are the back... -
- Unfortunately, this change affected mkmf on Appveyor (Windows).
https://ci.appveyor.com/project/ruby/ruby/builds/44579924/job/n81xmb2mqs6no7dm#L23792
```
2) Error:
TestMkmfTryConstant#test_simple:
Errno::EACCES: Permission denie... -
- catch_excep_t is a field that exists for MJIT. In the process of
rewriting MJIT in Ruby, I added API to convert 1/0 of _Bool to
true/false, and it seemed confusing and hard to maintain if you
don't use _Bool for *_p fields. -
- * [Feature #18784] `FileUtils.rm_f` and `FileUtils.rm_rf` should not mask exceptions (mame)
* I changed FileUtils.rm_f/rm_rf so that it raises a SystemCallError but Errno::ENOENT.
* But it seemed to affect mkmf on Windows. mkmf use... -
03:15 AM Revision 098a3cfa (git): Fixed typo
-
-
-
-
-
-
-
- 12:57 AM Revision 3504be1b (git): [ruby/irb] Require RDoc in `input-method.rb` again in a limited scope.
- RDoc is implemented as soft dependency in IRB. See how the rdoc is required in
the files. I reverted the commit below.
```
$ grep -ril rdoc lib/
lib/irb/cmd/help.rb
lib/irb/completion.rb
lib/irb/easter-egg.rb
lib/irb/input-method.rb
```...
08/25/2022
-
- `Data.new` aside, `Data.def` and `Data.define` are my current top-2 preferences. I'd be happy with either of these at this point.
But thinking about this further, I might like `Data.define` slightly more. It's a trade-off with shortn... -
-
01:34 PM Feature #16122: Data: simple immutable value object
- 1. I slightly regretted to make `Struct.new` to create a subclass, not an instance. So this time I didn't choose `new`. `create` or `generate` would have a similar issue with `new`. `define` might be a candidate. But I still prefer short...
-
- @matz Thanks for the decisions!
A few questions:
1. I am a bit concerned about using `def`, which is strongly associated with defining methods. I wouldn't want it to be a blocker (it would be really cool to have `Data` by the 3.2),... -
- We are going to implement Data class in the following spec:
* `D = Data.def(:foo, :bar)` to define a data class (subclass of Data)
* `Data.new` raises exception (unlike Struct)
* `d = D.new(1,2)` to create Data instance
* Or `d = ... -
- @austin, your example is a perfect example of "overengineering".
We could argue about "clearness", although about "conciseness" it's easy to check – option 1: 72 characters, option 2: 62 characters, so option 2 is 15% more concise, cl... -
- LevLukomskyi (Lev Lukomskyi) wrote in #note-10:
> ```ruby
> ...
I do not find the second option clearer or more concise in any way. It feels much more of line-noise.
In my code, I would opt for an explicit function that does the log... -
- I'm not that much concerned about the performance but about readability. Your solution with `compact` is probably good for that particular case but it cannot solve all other cases with an arbitrary hash plugged into the main hash on an a...
-
12:14 PM Feature #18959: Handle gracefully nil kwargs eg. **nil
- LevLukomskyi (Lev Lukomskyi) wrote in #note-10:
> If use `compact!` as a different statement then you need to make a variable, you have to make a mental effort to make up the name for that variable and repeat its name to use `compact!`. ... -
- > I meant to simply use compact! in a different statement, not in a chain.
If use `compact!` as a different statement then you need to make a variable, you have to make a mental effort to make up the name for that variable and repeat ... -
- LevLukomskyi (Lev Lukomskyi) wrote in #note-8:
> 2. => more specifically `.tap(&:compact!)` since `compact!` may return `nil` if nothing changed.
I think `tap(&:foo)` is actually not that much efficient, and `tap(&:compact!)` could be s... -
08:36 PM Bug #18767 (Closed): IO.foreach hangs up when passes limit=0
- Applied in changeset commit:git|21cac42385e1a116d287e155e461453b830640d2.
----------
Raise ArgumentError for IO.foreach with limit of 0
Makes behavior consistent with IO.readlines.
Fixes [Bug #18767] -
- OK, let's make it raise exceptions for zero length.
Matz.
-
- Makes behavior consistent with IO.readlines.
Fixes [Bug #18767] -
- matz (Yukihiro Matsumoto) wrote in #note-1:
> This is indeed an obsolete feature for long time. And the third argument is ignored (IIRC).
Unfortunately, the third argument is not ignored:
```ruby
p Regexp.new("\u1234", nil, "n").... -
- This is indeed an obsolete feature for long time. And the third argument is ignored (IIRC).
Some (old) gems still use it because they are not updated for long time. Warnings should not improve the situation (since most of them are unmai... -
- It hangs even after a retry
https://github.com/ruby/ruby/runs/7966439530?check_suite_focus=true
We contacted GitHub Suppport about this before, and we concluded that
the problem is on our end. Unfortunately we don't have a bandwidth to
... -
-
- It seems like TestMkmfTryConstant started to randomly fail, maybe
related to 96562a517d3373466ec306b5f821a41f4758d2a6 or 073f3b7e0ad94657c04573983affb9d66e6bff2c.
Some of them seem to have failed even after retries, so it feels like
the... -
06:02 PM Revision 8706b74b (git): [DOC] Enhanced RDoc for Time (#6277)
- Deletes the :include: files in doc/time, which became no longer workable when @nobu pointed out that some (but not all) creator methods accept string values as well as integer-like values.
Changes to methods:
Time.utc
Time.local... -
- Ref: bfa6a8ddc84fffe0aef5a0f91b417167e124dbbf
Ref: [Bug #18826] -
03:31 PM Feature #18979 (Open): Kernel#sprintf formatting BigDecimal without the loss of precision
- Recently I stumbled upon a quirk with `Kernel#sprintf`'s `f` modifier behavior with `BigDecimal`. It seems to be not documented neither in `Kernel` documentation nor in `BegDecimal` one. Also, I didn't find previous discussions about it ...
- 03:08 PM Revision c2daa056 (git): * 2022-08-26 [ci skip]
-
- Since RDoc C parser cannot capture aliases which are using an
expression other than a single variable as the class, use an
intermediate variable for the singleton class. -
- MSP-Greg (Greg L) wrote in #note-12:
> Windows bash file 'top'
> ...
I'm not sure where the header came from.
`rbinstall.rb` doesn't use `dirname` command.
Maybe [here](https://github.com/MSP-Greg/ruby-loco-test/blob/master/mswin/cop... -
- Recently a changed was introduced to update the resolver platforms after
it has been created, in order to remove the "ruby" platform from it if
it's to be removed from the lockfile. However, it did not update the
`@resolving_only_for_rub... -
01:41 PM Bug #18978 (Feedback): Unexpected behaviour in Time.utc and Time.local when 8 arguments are passed in
- GitHub PR: https://github.com/ruby/ruby/pull/6281
Time.utc and Time.local produce inconsistent and unexpected behaviour when 8 arguments is passed in.
For example, consider the following code:
```ruby
Time.utc(2000, 1, 1, 2, 3,... -
- # The next dev meeting
**Date: 2022/09/22 13:00-17:00** (JST)
Log: https://github.com/ruby/dev-meeting-log/blob/master/DevMeeting-2022-09-22.md
- Dev meeting *IS NOT* a decision-making place. All decisions should be done at the bu... -
-
- We brielfly discussed this issue at the dev meeting. @naruse said it should behave like `String#<<` as follows. @nobu said he would try to implement this.
```ruby
s = "".force_encoding("US-ASCII")
s << 128
p s #=> "\x80"
... -
- Confirmed. Thank you for helping us @k0kubun and @st0012.
If you have any concern, please tell us here.
Matz.
-
- We discussed this at today's developers meeting. We recognize two different challenges here.
1. @st0012 and @k0kubun want to introduce IRB features that are relatively easy to maintain, such as adding or modifying IRB commands.
2. We ha... -
- We have discussed with @ktsj about the issue, and concluded it is intentional. Unsuccessful matches remain the assignment result from the internal matches, e.g.,
```
case [1,2,3]
in [a,2,3,4]
# unmatch
else
p a #=> 1 (from pa... -
- I agree with MatchData. And I think `deconstruct` for the class should be an alias to `captures` instead of `to_a`.
Matz. -
- Although not so elegant, I was thinking to add "precheck" to enumerators.
https://github.com/nobu/ruby/tree/lazy_take0 -
- The mail archive server named `blade.nagaokaut.ac.jp` is down now.
blade had some hardware issues. Prof. Hara tries to salvage mail data and rebuild blade. But It's difficult status.
I have a plan to migrate Ruby mail server includ...
08/24/2022
-
-
10:42 PM Bug #18932: Ruby 3.1 - Allow building with VS 2022
- I just built ruby_3_1 branch with VS 2022, and it built and passed all tests. So, no patches needed for Ruby 3.1. Please close.
-
- Yes. The Visual Studio bug has been fixed. I'll try a build see what's needed.
-
- Can you point out which commits are needed for backporting to allow Ruby 3.1 to work better with VS 2022? Then we could mark those commits for backporting. However, the decision of whether to backport is always made by the branch maint...
-
- Requested by matz in comment on #18435.
-
- I've submitted a pull request to fix this issue: https://github.com/ruby/ruby/pull/6283
-
10:22 AM Bug #18974 (Closed): Wrong line number in the rescue iseq for the exception matching code
- Script for demonstration:
```
def foo
begin
raise 'error'
rescue => e
puts e.message
end
end
puts RubyVM::InstructionSequence.of(method :foo).disasm
```
Disasm for the catch table:
```
| catch type: rescue ... -
08:48 PM Misc #18975: Propose Stan Lo (@st0012) as an IRB maintainer
- It'll be my honor to help the team maintain IRB. Thank you for nominating me for this important role.
-
- ## Background
Looking at @aycabta 's GitHub activity, he's been inactive on the Internet for 6~7 months, which means that IRB hasn't had the maintainer during that period of time. While I managed to sneak in some IRB changes when he was... -
- 2. => more specifically `.tap(&:compact!)` since `compact!` may return `nil` if nothing changed.
3. there might be also a case when you want to merge another hash under some conditions, eg.:
```ruby
{
some: 'value',
**({ id: id, na... -
- LevLukomskyi (Lev Lukomskyi) wrote in #note-6:
> `compact` way looks good indeed, although:
> ...
I think such use case would be a design failure. `nil` generally represents absence of a valid value. Sometimes having `nil` and sometime... -
- `compact` way looks good indeed, although:
1. it removes all `nil`s from the hash, which might be undesired in some cases
2. it creates hash duplicate each time, while kwargs way creates temporary hash only if a condition is met, though ... -
- I am concerned about compatibility to change this. @naruse proposed to return an ASCII-8BIT string instead of raising an exception.
-
- @nobu Looks good to me, could you commit it?
(ARG_UNUSED is not needed on `code` I think) -
- Sorry, this.
```diff
diff --git a/enc/us_ascii.c b/enc/us_ascii.c
index 08f9072c435..9d854b12245 100644
--- a/enc/us_ascii.c
+++ b/enc/us_ascii.c
@@ -7,6 +7,12 @@
# define ENCINDEX_US_ASCII 0
#endif
+static int
+us_ascii_c... -
- ```diff
diff --git a/regenc.c b/regenc.c
index 16d62fdf409..5cc3b778351 100644
--- a/regenc.c
+++ b/regenc.c
@@ -627,6 +627,10 @@ onigenc_single_byte_mbc_to_code(const UChar* p, const UChar* end ARG_UNUSED,
extern int
onigenc_single_by... -
- I submitted a pull request to always raise an exception for rstrip strings with broken coderange: https://github.com/ruby/ruby/pull/6282
That may not match the lstrip behavior exactly, as it complains about cases where the broken code... -
- After giving this some more thought, I am fairly sure this is not a bug, and I'm rejecting this. @zverok is correct, a trailing comma is an implicit splat, and you cannot have multiple splats in a multiple assignment, so a syntax error ...
-
- I agree that we should remove the restriction. I submitted a pull request for that: https://github.com/ruby/net-http/pull/66
-
05:54 PM Revision 28a34346 (git): Disable Ractor check on 32bit architectures
- Ractor verification requires storing the ractor id in the top 32 bits of
the object header. Unfortunately 32 bit machines only have 32 bits in
the object header. The verification code has a 32 bit left shift which
doesn't work on i686 ... - 05:43 PM Revision fa9f4d38 (git): * 2022-08-25 [ci skip]
-
05:42 PM Revision b4be3c00 (git): add --yjit-dump-iseqs param (https://github.com/Shopify/ruby/pull/332)
-
- The Ruby build linked to above had incorrect bash scripts. Fixed as of now. Sorry, bad day yesterday, too many interruptions...
-
- Pull requested merged at commit:c69ad738dc7c713df547a51607917ca78df6b793
-
- Fixed by commit:5bbba76489628f4509495ebf4ba0a7aad4c0b560
-
- https://github.com/rubygems/rubygems/commit/703373b41f
Co-authored-by: Loic Nageleisen <[email protected]> -
- I had a quick chat with @ko1, he plans to try a better implementation after RubyKaigi (mid-september).
I'll hold on this. -
08/23/2022
-
11:00 PM Bug #18937: Inconsistent definitions of Complex#<=> and Numeric#<=> with others
- nobu (Nobuyoshi Nakada) wrote in #note-4:
> I agree that `Complex#<=>` should coerce the argument as well as other methods/classes.
> ...
Thanks @nobu .
But `#coerce` is not called when a custom numeric class has `def real? = false` f... -
- @nobu & @Eregon
I just tried the prolog_script script branch. Wondering if the following example would be fine with everyone? It seems to work for me locally. If they're run as 'in path' commands, they work, if they're run from the f... -
- I also noticed `which rake` does not work on Ruby 2.5+, but it does work on Ruby < 2.5:
https://github.com/ruby/setup-ruby/runs/7938245817?check_suite_focus=true
austin (Austin Ziegler) wrote in #note-10:
> Do we need the multi-language... -
- I think it is a bug. I submitted a pull request to fix it: https://github.com/ruby/ruby/pull/6280. Not sure if the approach taken is the best way, though.
- 09:28 PM Revision feff6833 (git): * 2022-08-24 [ci skip]
-
09:27 PM Revision 60c900f4 (git): Add @k0kubun to CODEOWNERS for YJIT
-
- I submitted a pull request to fix this: https://github.com/ruby/ruby/pull/6276
-
- I noticed https://github.com/ruby/ruby/blob/master/benchmark/app_aobench.rb seems to rely on this behavior.
But that is easily fixed by using `# coding: BINARY` instead of `# coding: US-ASCII`.
I think it would be good to fix this is... -
02:42 PM Bug #18973 (Closed): Kernel#sprintf: %c allows codepoints above 127 for 7-bits ASCII encoding
- I've noticed the following behavior:
```ruby
sprintf("%c".encode("US-ASCII"), 128)
=> "\x80"
sprintf("%c".encode("US-ASCII"), 128).valid_encoding?
=> false
```
Specifying codepoints 128-255 for ASCII encoded formatting seque... -
- Ok, I suppose your point of view make sense, and either way the backward compatibility concern is just too big.
Closing. -
- I think the current behavior is better, `String#byteslice` is not only used for BINARY strings.
In fact for binary strings (and other fixed-width encodings), there is no point to use byteslice over slice/[].
For instance, one might w... -
- While working on implementing https://bugs.ruby-lang.org/issues/13626, I noticed `byteslice` assign the receiver encoding to the returned String.
I believe this is incorrect, as since you are doing a byte based operation, you do expec... -
- The PR is here in case someone feels like reviewing: https://github.com/ruby/ruby/pull/6275
As for the recently raised concerns, I don't really have any strong opinion. I implemented this on @ioquatix 's demand, I personally believe t... -
- I think there is a misunderstand of what `byte*` methods are for.
`byte*` methods are for dealing with byte indices and avoid the conversion between byte and character indices (which can be expensive for UTF-8).
`byte*` methods are n... -
- Why not simply `String#slice!` if the string encoding is BINARY?
```ruby
result = @read_buffer.slice!(size) # @read_buffer must be in the BINARY encoding
```
For IO buffers, I think it's reasonable to ensure every string appended i... -
- `TestProcess#test_daemon_noclose` passed with `export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES` from https://github.com/rails/rails/issues/38560
- 09:01 AM Revision 46c3a939 (git): [ruby/irb] Drop hard dependency on RDoc.
- This has been introduced in https://github.com/ruby/irb/commit/026700499dfd,
but it seems that this is just be mistake, otherwise the later handling
of `LoadError` would not be needed.
https://github.com/ruby/irb/commit/54c8df06ff -
- ... instead of any StandardError.
To behave like the standard `rm` command, it should only ignore
exceptions about not existing files, not every exception. This should
make debugging some errors easier, because the expectation is that `... -
- The ensure in postorder_traverse was added for [Bug #6756].
The intention was to try to delete the parent directory if it failed to
get the children. (It may be possible to delete the directory if it is
empty.)
However, the ensure regio... -
- The test was added for [Bug #6756]. The ticket insisted
`FileUtils.rm_rf` should delete an empty directory even if its
permission is 000. However, the test tried to delete a directory with
permission 700.
https://github.com/ruby/fileuti... -
06:44 AM Bug #18971: Enumerator::Lazy.take(0) leaks first element into next operation
- You're right. I just tested again and apparently even 3.1.2p20 has this issue.
-
- Are you sure this has been fixed? I tried with Ruby 2.7-3.1 and current master and did not get all `[]` results on any Ruby version I tested.
There is specific code to deal with an argument of 0, though I don't understand what it doe... -
- Upon more testing apparently this has been fixed in `3.0.2p107 (2021-07-07 revision 0db68f0233)`.
However I can't find a commit between p0 and p107 related to this change. -
- These results with lazy enumerators are as expected:
``` ruby
(2..10).take(0).to_a # => []
(2..10).take(0).map(:&itself).to_a # => []
(2..10).lazy.take(0).to_a # => []
```
However, once another operation is added after `take(0)... - 06:33 AM Revision 7c784f0a (git): [rubygems/rubygems] Bundler: avoid use of "can not" in spec literals
- Signed-off-by: Takuya Noguchi <[email protected]>
https://github.com/rubygems/rubygems/commit/73b5cf9bd1 - 05:28 AM Revision 22a416a3 (git): [rubygems/rubygems] Bundler: update the link suggested on error with the new one
- Also typo is fixed.
Signed-off-by: Takuya Noguchi <[email protected]>
https://github.com/rubygems/rubygems/commit/9c1ea52ddf -
- https://github.com/actions/runner-images/issues/6002
-
-
- https://github.com/ruby/ruby/commit/70f69f85395f5735429cd45136d7de2742f08b72
-
-
- I was thinking about making it internal/mjit.h, but didn't.
-
-
- Pick from https://github.com/rubygems/rubygems/commit/6b3a5a9ab0453463381a8164efb6298ea9eb776f
-
- When `--conservative` is passed, explicit unlocks are set for top level
gems via `@unlock[:gems]`, so that only those particular gems are
allowed to be updated.
When we compute the "base resolve" from the lockfile (the set of gems
whose... -
- https://github.com/rubygems/rubygems/commit/fa60f1fe43
-
- The compact index should not request any marshaled gemspecs whatsoever.
https://github.com/rubygems/rubygems/commit/6dbd44d0c0 -
- It's already included by the parent.
https://github.com/rubygems/rubygems/commit/3ffe389c44 -
- It's explicitly loaded when monkeypatching RubyGems, which we do very
early. So neither autoloading it, nor explicitly loading it anywhere
else is necessary.
https://github.com/rubygems/rubygems/commit/fbc7a57161 -
08/22/2022
-
- https://github.com/rubygems/rubygems/commit/7e976d790a
-
- https://github.com/rubygems/rubygems/commit/1b9f7f50a5
-
- https://github.com/rubygems/rubygems/commit/b5e0c683d9
-
- Attempting to install a gem published as both *-linux and *-linux-musl
results in the incorrect gem being picked up, causing build failures due
to binary incompatibility. This is caused by the `nil` wildcard
swallowing the libc informati... -
08:50 PM Revision f254b673 (git): [rubygems/rubygems] Test platform parsing stability
- On past versions there were observed cases of inconsistencies when some
platforms were re-parsed.
Ensure that a platform's string representation parses again in a
platform object equal to the original.
https://github.com/rubygems/rubyg... -
- The symmetry with the "for command line" case is made more apparent.
https://github.com/rubygems/rubygems/commit/ab85d3558f - 07:40 PM Revision 085790bd (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.29 to 0.9.30.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.29...v0.9.30)
---
updated-depende... -
- MSP-Greg (Greg L) wrote in #note-9:
> @nobu - I will try that build, but I can't until later.
> ...
Do we need the multi-language header anymore with `ruby -S binary`? It seems to me that `bin/bundle` could be what it is now with *only... -
- @nobu - I will try that build, but I can't until later.
I don't know what the best approach is for Windows binstubs. Ruby-loco and RubyInstaller2 have always supplied 'portable' builds, not sure if that should be the case for a stand... -
- Unfortunately I can't build ruby from source on Windows myself to test, maybe @MSP-Greg can test that?
From above:
> rake has the header on 2.6-3.0 though and is seen as executable:
Specifically:
```
$ cat rubyinstaller-3.0.4-1-... -
- Does this work?
https://github.com/nobu/ruby/tree/prolog_script -
- Addition to section 'Related Methods': suggests adding differentiators to the names of related methods.
- 05:26 PM Revision a9ee1336 (git): [rubygems/rubygems] Bump rb-sys in /test/rubygems/test_gem_ext_cargo_builder/custom_name
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.29 to 0.9.30.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.29...v0.9.30)
---
updated-depende... -
- byroot (Jean Boussier) wrote in #note-8:
> The fix is here: https://github.com/tmm1/stackprof/pull/186 I'll try to get a release soon.
> ...
I merged it and shipped 0.2.21. Thanks! -
- The fix is here: https://github.com/tmm1/stackprof/pull/186 I'll try to get a release soon.
@RubyBugs in the meantime I suggest sticking to `0.2.19`.
-
11:18 AM Bug #18967: Segmentation fault in stackprof with Ruby 2.7.6
- As pointed by @eregon I planned experimenting with this and raising it at some point -- the change in https://github.com/ruby/ruby/commit/0e276dc458f94d9d79a0f7c7669bde84abe80f21 did reorder things as far as the C source goes, but as far...
-
- i.e., rb_profile_frames is called at a random place and that's not supported on < 3.0.
(TBH even on >= 3.0 I wonder if it's truly supported, it seems pretty dangerous to call rb_profile_frames()/anything not-async-signal-safe from a sig... -
- I found the bug: https://github.com/tmm1/stackprof/pull/180/files#r951294711
-
- Thank you for providing the full stack trace. In conclusion, I couldn't find the cause, sorry.
Ruby 2.7 is under the security maintenance phase (maybe EOL next March), so I'd recommend to use Ruby 3.0 or later as soon as possible.
Ma... - 04:22 PM Revision c96ffec9 (git): * 2022-08-23 [ci skip]
-
- Treats:
#utc
#getlocal
#getutc
#ctime
#to_s
#inspect -
-
-
09:52 AM Revision 13d31331 (git): Reuse `nonlocal_var` patterns
-
-
- Applied in changeset commit:git|d5f50463c2b5c5263aa45c58f3f4ec73de8868d5.
----------
[Bug #18937] Coerce non-Numeric into Complex at comparisons -
- I agree that `Complex#<=>` should coerce the argument as well as other methods/classes.
https://github.com/ruby/ruby/pull/6269 -
- [Misc #18362] is fixed at cl.exe 19.33.31629.
-
07:48 AM Bug #18960: Module#using raises RuntimeError when called at toplevel from wrapped script
- @jeremyevans0
> I'm not sure whether this issue should be considered a bug, but it may be safe not to backport the fix to stable versions.
Yes, that's what I had originally, in review I changed it to `ruby_bug`. Happy to put it back.
... -
06:19 AM Bug #18960: Module#using raises RuntimeError when called at toplevel from wrapped script
- shioyama (Chris Salzberg) wrote in #note-3:
> @jeremyevans0 You [most recently contributed to the `wrap` option](https://bugs.ruby-lang.org/issues/6210), what do you think about this? Am I correct to consider this a bug, and [this](http... -
- shioyama (Chris Salzberg) wrote in #note-3:
> @jeremyevans0 You [most recently contributed to the `wrap` option](https://bugs.ruby-lang.org/issues/6210), what do you think about this? Am I correct to consider this a bug, and [this](http... -
- I'm new to contributing to Ruby, but I haven't gotten a response on this in a couple weeks so wondering if maybe this requires more context.
For reference, here are the docs on the `wrap` parameter to [`Kernel#load`](https://ruby-doc.or... -
- Fixed this issue itself, but turned out Psych had a related issue.
The YAML spec doesn’t considered the calendar systems.
Although I [reported], as it hasn’t been concluded yet, the failing test is excluded now at commit:git|79fdf9712d... -
-
-
-
03:18 AM Revision 954f709f (git): NEWS.md: sort [ci skip]
-
-
- I finished promoting @schneems to Ruby committer.
-
- https://github.com/ruby/fileutils/commit/9cc6a082d7
08/21/2022
-
07:23 PM Bug #18967: Segmentation fault in stackprof with Ruby 2.7.6
- Per @eregon on https://github.com/tmm1/stackprof/issues/182#issuecomment-1221274946 -
It appears that the stackprof gem may have been segfaulting in CI for some time: https://github.com/tmm1/stackprof/actions/workflows/ci.yml -
- mame (Yusuke Endoh) wrote in #note-1:
> Thank you for your report. At least we need the full trace, especially. "C level backtrace information" section. Can you provide it?
Hello! Thank you. I have captured the full trace, and attach... -
- Now that mjit_exec doesn't exist, those files feel old. I'll probably
change how I benchmark it when I add benchmarks for it again. -
- I'm planning to introduce mjit_compiler.rb, and I want to make this
consistent with it. Consistency with compile.c doesn't seem important
for MJIT anyway. -
06:22 PM Feature #12075: some container#nonempty?
- I am assuming you do not want to use each which does correct thing if container is non empty . I assume you want map method that return same type of container. Why not just add a new map method?
Hash#fmap>. Hash
Array#fmap -> Array
O... - 04:36 PM Revision 73f8027a (git): * 2022-08-22 [ci skip]
-
- Treats:
#utc
#hash
#localtime -
- Can anyone confirm if this is a bug or intended behavior? I've taken a look at the code that implements this, and there are 2 pretty independent code paths for handling the single string argument case and the multiple argument case. If...
-
- byroot (Jean Boussier) wrote in #note-10:
> Is it true for both push and pop? I can see the issue for push, but no so much for pop.
Interesting, for `LinkedBlockingQueue` there is `java.util.concurrent.BlockingQueue#drainTo(java.util... -
- I also noted from the run above, on 2.6-3.0:
```
# Output from 2.6
$ ls -l $(dirname $(which ruby))
total 3627
-rw-r--r-- 1 runneradmin None 672 Apr 19 20:27 bundle.cmd
-rw-r--r-- 1 runneradmin None 674 Apr 19 20:27 bundler... -
- Here is another run, where none of the Rubies does a `gem install Bundler`.
https://github.com/eregon/setup-ruby/runs/7938431059?check_suite_focus=true
2.6, 2.7 and 3.0 all fail `bundle install` in bash with `bundle: command not foun... -
- Another thought, maybe `-ls -l` in bash shows the `x` bit if the file starts with a shebang or is a native executable, but due to this header it's neither?
-
- @nobu Thank you for the explanation, quite clever code.
I think it is still an issue due to being fragile/inconsistent that this header only exists for bin/* files shipped with Ruby but not for bin/* files installed by RubyGems later.... -
- Eregon (Benoit Daloze) wrote in #note-1:
> Ah, maybe this cryptic header actually works for Bash too?
The header is polyglot (triglot?) code.
For `/bin/sh`, the first `:""` successes and the block after `||` is not executed, then in th... -
-
-
- If the application has the `no_install` setting set for `bundle
package`, then `bundler/inline` would silently skip installing any gems.
https://github.com/rubygems/rubygems/commit/7864f49b27 -
- https://github.com/rubygems/rubygems/commit/49fc54e87d
-
- In my opinion, putting the whole subhash `{id: id}` within a condition like that is redundant and ugly.
That is one (but not the only) reason that I had asked for `Hash#compact`in #11818 (which is available). Using this, your code ca... -
-
-
- The current MJIT relies on SIGCHLD and fork(2) to be performant, and
it's something mswin can't offer. You could run Linux MJIT on WSL
instead.
[Misc #18968]