Activity
From 05/14/2024 to 05/20/2024
05/20/2024
-
08:33 PM Revision 86cf074f (git): Avoid array allocation for empty ruby2_keywords flagged keyword hash
- If the method being called does not have a positional splat
parameter, there is no point in allocating the array, as
... -
- If the method being called does not have a keyword splat parameter,
there is no point in allocating the hash, because... -
- This tests ruby2_keywords flagged methods, as well as passing
ruby2_keywords flagged hashes to other methods.
Some o... -
07:39 PM Revision 7c2c528d (git): [ruby/prism] Fix up regexp escapes with control/meta
- https://github.com/ruby/prism/commit/8a7afa6988
-
- https://github.com/ruby/prism/commit/1dbbbedf55
-
05:23 PM Bug #20499 (Closed): Ruby builds on macOS store absolute paths for AR and NM in rbconfig since Ruby 3.2.3/3.3.0
- This is a regression introduced by https://github.com/ruby/ruby/commit/038f9ade3c4d965415e4956561975454cf9eeb21 and c...
-
-
-
-
-
03:14 PM Bug #20494: Non-default directories are not searched when checking for a gmp header
- @nobu
I just realized, isn't it necessary to backport this change to 3.2.x?
Since this bug seems to be present sinc... -
- @nobu
Thank you for your quick fix! -
07:40 AM Bug #20494: Non-default directories are not searched when checking for a gmp header
- >Specifying --with-gmp-dir=/opt/homebrew does not work
Ah, sorry. I skipped to read above report. It seems not onl... -
- What's your ruby-build version? ruby-build already have auto-detect feature for gmp provided by homebrew
https://g... -
04:54 AM Bug #20494 (Closed): Non-default directories are not searched when checking for a gmp header
- Applied in changeset commit:git|18eaf0be905e3e251423b42d6f4e56b7cae1bc3b.
----------
[Bug #20494] Search non-default... -
- Made a separate macro.
```diff
commit a0d3cda4b54ce3eb9e77a450462a47fc3944d93c
Author: Nobuyoshi Nakada <nob... -
03:04 PM Revision 1ba93c2c (git): Upload cores to AWS S3 (if any)
-
-
-
- https://github.com/ruby/prism/commit/dddaf67c34
-
- Just to check back in @mame because it's only the `first_lineno` field, is that okay to change?
-
- @nobu another option would be to delete those tests and leave it up to the parser instead of forcing parse.y to imple...
-
- https://github.com/ruby/prism/commit/6258c3695f
-
01:41 PM Feature #20498: Negated method calls
- For `foo&.!empty?`, the result would be `nil` if `foo` is `nil`. This is not handled by the prototype.
The alterna... -
01:26 PM Feature #20498: Negated method calls
- MaxLap (Maxime Lapointe) wrote in #note-7:
> @nobu: I'd say it's both syntax sugar and an operator, just like `&.`.
... -
- Thanks for the feedback. I updated the gist to have an example with arguments in the call:
```ruby
puts A.new.!ex... -
08:42 AM Feature #20498: Negated method calls
- I saw such a proposal before and I thought of some syntax and implementation, but I didn't submit that in the previou...
-
08:04 AM Feature #20498: Negated method calls
- I wonder how wild it would be to make `!` accept an optional block. That way we could write:
```ruby
must_create_us... -
05:57 AM Feature #20498: Negated method calls
- We can use `foo.!`.
```
must_create_user = User.where(somelong: :condition, even_more: "thing").exists?.!
``` -
- In your prototype, `foo . ! exist?` was transpiled to `!(foo . exist?)`.
Your proposal is not a new operator, but a... -
03:23 AM Feature #20498: Negated method calls
- I think defining an explicit method for this purpose (on `Object`, I guess) would be better, because it wouldn't add ...
- 09:10 AM Revision 82482684 (git): Update bundled gems list at 7f0e26b7f99bf76408569892ce2031 [ci skip]
-
-
-
08:17 AM Bug #20496 (Assigned): Segfault when enabling YJIT
-
05:59 AM Revision 0b384033 (git): Fix incorrect assertion in TestThreadInstrumentation
- The test meant to assert the thread is suspended at least once,
but was actually asserting to it to be suspected at l... -
-
-
- Co-Authored-by: lish82 (Hiroki Katagiri)
-
- I'm not sure how it works, but I seem to get an error
`undefined method 'formatter' for module DidYouMean` in paralle... -
- I thought about this more at Kaigi, maybe avoiding the false positive on the `str.dup if str.frozen?` pattern isn't w...
-
- https://github.com/rubygems/rubygems/commit/7d2c4cf364
05/19/2024
-
- I want to propose the following syntax: `foo.!bar`. I know it's already valid syntax, but please read on for details....
-
- I propose Tempfile.create_io.
It is similar to Tempfile.create but the actual file is unlinked before returning the ... -
- At 7afc16aa48beb093b06eb978bc430f90dd771690, now `BLOCKING_REGION`
contains `setjmp` call in `RB_VM_SAVE_MACHINE_CONT... -
02:24 PM Revision 48ebd77e (git): Fix comment: Buffer.for(string) without block returns readonly buffer
-
-
-
11:59 AM Bug #20496 (Closed): Segfault when enabling YJIT
- I installed Ruby 3.4-dev via rbenv to see how the improvements in YJIT with 3.4-dev (after reading https://speakerdec...
-
- Fix test failures since 7afc16aa48beb093b06eb978bc430f90dd771690.
Why crash after reported compile error properly. -
- This has been plaguing people developing on MacOS (and I suppose any case insensitive file system) for months. Maxime...
-
08:02 AM Bug #20495: Running "make clean" deletes critical "coroutine/amd64/Context.S" file and causes "make" to fail
- I guess it happens when building in-place on case-insensitive fs platform due to this line: https://github.com/ruby/r...
-
- For now, `make clean` is for those who "git clone" the repository. Don't use it for tarball package.
-
04:41 AM Bug #20495 (Closed): Running "make clean" deletes critical "coroutine/amd64/Context.S" file and causes "make" to fail
- When attempting to build v3.4.0-preview1 from source, we discovered that `make clean` will delete `coroutine/amd64/Co...
-
10:07 AM Bug #20493: Segfault on rb_io_getline_fast
- Awesome! I was about to ask what was the plan for having this change in ruby 3.2/3.3.
I've submitted the patches t... -
03:20 AM Bug #20493 (Closed): Segfault on rb_io_getline_fast
-
- Closed by merging https://github.com/ruby/ruby/pull/10795
I opened two PR's to backport this to 3.2 & 3.3 (I think... -
- I too have wanted to do this multiple times. However, I am also a little concerned about the possibility of security ...
-
- There's an exhaustive explanation of this in the linked redmine bug, but
the short version is as follows:
blocking_r... -
03:08 AM Revision ad636033 (git): Update to ruby/spec@6b04c1d
-
- Looks good to me. I found no other AC_CHECK_HEADERS that might want to find non-system header files. @nobu What do yo...
-
- This is my very first issue submission
I would be happy to know if I missed anything
---
I found that the ruby...
05/18/2024
-
-
-
- I don't think I quite understand what exactly the right course of action here is.
> Would it make sense to check i... -
- You're welcome, thank you for posting such a detailed and actionable report. You're exactly right; your patch deals w...
-
- Thanks for this extremely detailed explanation!
Just for my own understanding [I'm not as proficient in low level ... -
- After applying that fix to the RPM spec file in https://build.opensuse.org/package/show/devel:languages:ruby/ruby3.3,...
-
- I opened https://github.com/ruby/ruby/pull/10795 as a proposed fix for this. Let's see what other people (and CI) thi...
-
- OK, I believe I've worked out what's wrong here.
The BLOCKING_REGION macro is used to release the GVL, run some co... -
- Thank you for your bug report and excellent reproduction! I've had a look at this today - I haven't reached a conclus...
-
11:10 AM Bug #19753: IO::Buffer#get_string can't handle negative offset
- Backported by https://github.com/ruby/ruby/pull/10778
- 11:09 AM Revision 0e664ebc (git): Fix `io_buffer_get_string` default length computation. (#8427)
- * Fix `io_buffer_get_string` default length computation.
When an offset bigger than the size is given, the resulting... - 11:09 AM Revision 67d499a7 (git): Improvements to `IO::Buffer` `read`/`write`/`pread`/`pwrite`. (#7826)
- - Fix IO::Buffer `read`/`write` to use a minimum length.
- 11:09 AM Revision 359e40e3 (git): Rename `data` -> `buffer` for better readability. (#7836)
-
-
- * Add types to `tLAMBDA` and `tSTRING_DBEG` to store corresponding
information when returning these tokens.
* Add `... -
- Since you say you're OK with solutions requiring modifying the program though, have you tried doing something like th...
-
06:44 AM Revision ac85eef1 (git): Fix links
-
02:26 AM Revision 55c62e67 (git): No need to specify tags anymore
- In the past, these codes were used by both parser and ripper.
On ripper, the type of LHS is `<val>` then type cast wa...
05/17/2024
-
- Thanks for the research. So, `TracePoint.new(:branch)` seems good enough for the use case of fuzzer, right?
But wi... -
06:37 PM Feature #20448: Make coverage event hooking C API public
- **TL;DR: I've been further researching how fuzzers gather coverage information, and what types of coverage are most u...
-
-
- We've spotted a consistent segfault when running bundle install with `--jobs 4`
When running: `bundle install -j 4... -
03:37 PM Bug #20218: aset/masgn/op_asgn with keyword arguments
- In this issue there's no consideration of compatibility or utility. This is a breaking change. The ability to pass kw...
-
-
-
- https://github.com/ruby/prism/commit/31ef81fd06
-
02:45 PM Revision aed93ba1 (git): [ruby/prism] Replace and Use PM_LOCATION_NULL_VALUE macro
- https://github.com/ruby/prism/commit/50e188b168
-
-
- https://github.com/ruby/ruby/actions/runs/9125437794/job/25091614796#step:11:272
- 08:40 AM Revision 8acec5b6 (git): Update bundled gems list at 10d02e71d1f57b68f530c0e669e444 [ci skip]
- 08:26 AM Revision cbc84b80 (git): * 2024-05-17 [ci skip]
-
- 08:25 AM Revision 5db59cd5 (git): [ruby/openssl] test_asn1.rb: Remove the assertions of the time string format without second.
- This commit fixes the following errors in the tests.
Because the OpenSSL project changed the code to make the time st... -
08:25 AM Revision 89574f02 (git): [ruby/openssl] test/openssl/test_asn1.rb: skip failing tests on LibreSSL 3.6.0
- LibreSSL 3.6.0 expects the seconds part in UTCTime and GeneralizedTime
to be always present. LibreSSL 3.6.0 release n... - 08:25 AM Revision 10f4e4d9 (git): [ruby/net-http] Skip test_session_reuse_but_expire with OpenSSL 3.3
- OpenSSL 3.3.0 9 Apr 2024 is also broken.
Signed-off-by: Xi Ruoyao <[email protected]>
https://github.com/ruby/net-... -
- 02:50 AM Revision 534f1c37 (git): Bump actions/checkout in /.github/actions/setup/directories
- Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.5 to 4.1.6.
- [Release notes](https://github.c... - 02:50 AM Revision 0f8f0386 (git): Bump actions/checkout from 4.1.5 to 4.1.6
- Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.5 to 4.1.6.
- [Release notes](https://github.c... -
- (https://github.com/ruby/irb/pull/956)
When a syntax error includes multiple error messages, we want to
check for un... -
-
02:05 AM Revision b90ea8ae (git): [ruby/find] find.gemspec: Drop executables dir config
- This gem contains no executables.
https://github.com/ruby/find/commit/7bd452155e -
01:18 AM Misc #20407: Question about applying encoding modifier to an interpolated Regexp
- I checked the related source code especially about rb_reg_preprocess_dregexp. It wrongly calls rb_reg_preprocess with...
-
- +1 for extracting GC implementation of `gc.c` into a separate `gc_impl.c` file.
My motivation: Some of the use cases...
05/16/2024
-
-
- https://github.com/ruby/prism/commit/72518f5716
-
- https://github.com/ruby/prism/commit/ab43b3ab66
-
-
-
05:43 PM Feature #20492 (Open): Debug option for tempfile
- Hi,
the ruby lib tempfile is quite useful, but since it always deletes files once the object is garbage collected... -
- https://github.com/ruby/prism/commit/2a43b4f55c
-
04:43 PM Feature #20484: A new pragma for eager resolution of classes referenced in rescue clauses.
- zverok (Victor Shepelev) wrote in #note-3:
> Honestly, it is no different than any name used in a branch that wasn’t... -
-
-
-
-
-
03:15 PM Bug #19753: IO::Buffer#get_string can't handle negative offset
- Thanks so much, I will review it.
-
- I have cherry-picked some additional refactoring commits and open pull request https://github.com/ruby/ruby/pull/1077...
-
- https://github.com/nagachika/ruby/commit/7d325d1b2ea7b6ef7debd6a29ad97c93311ed9b5 Here is the changeset to backport i...
-
- https://github.com/ruby/prism/commit/0ef5658dcc
-
- https://github.com/ruby/prism/commit/8d4c5c2bca
-
- https://github.com/ruby/prism/commit/178d4f66fd
-
- https://github.com/ruby/prism/commit/863197629c
-
- https://github.com/ruby/prism/commit/57d5c9be2c
-
- https://github.com/ruby/prism/commit/33d12afa60
-
01:34 PM Revision c55c11d7 (git): [rubygems/rubygems] Fix binstubs sometimes not getting regenerated when `--destdir` is given
- This was only working for gems also installed in the default gem home.
https://github.com/rubygems/rubygems/commit/4... -
- So that it can also be delegated to `Gem::SpecificationRecord`.
https://github.com/rubygems/rubygems/commit/1407807a99 -
-
- https://github.com/rubygems/rubygems/commit/7f0706a897
-
- Tests have two copies of b-2 installed, one in default home and another
in user home. But only the one in default hom... -
- https://github.com/rubygems/rubygems/commit/5fbe5e43d6
-
- If `cache_all_platforms` setting is enabled, the secondary source was
no longer considering cached gems.
That means ... -
- https://github.com/rubygems/rubygems/commit/6166e4bce1
-
- https://github.com/rubygems/rubygems/commit/5d03a346ab
-
- https://github.com/rubygems/rubygems/commit/535c83d5be
-
- Applied in changeset commit:git|2dd46bb82ffc4dff01d7ea70922f0e407acafb4e.
----------
[Bug #20468] Fix safe navigatio... -
- I talked with k0kubun and disscussed about multiple options as below.
I understand the background and agree to go ah... -
- I think it's obviously a bug, but I'm concerned that changing the behavior might cause FrozenError in applications. T...
-
-
- > leaving the files after gem rebuild was intentional, for local
> inspection, but the test suite should be made to c... -
-
- Thank you for your report. I will look the PRs.
I will set the status of this ticket because of this is a backport t... -
- Thank you. I'll do my best.
-
04:28 AM Misc #20491: Proposal for new branch maintainers
- I think this is a good idea. Approved.
Matz -
- Note: I confirmed this proposal with @k0kubun and @usa
-
- Since this was a long standing bug, I won't backport it to stable branch in general. If you know any real application...
-
- ruby_3_2 2d686e1019414f6bbb7ccbfa897b7b665250743d merged revision(s) ae8990aef098410ecc2b5f48fea9d7d171a3c5f6.
-
- Alias init functions
The extension library has each initialization function named "Init_" +
basename... -
12:06 AM Feature #16461: Proc#using
- Sorry for the delay.
Eregon (Benoit Daloze) wrote in #note-10:
> Reading #12086 again, I feel #12281 is a much si...
05/15/2024
-
11:41 PM Feature #19840 (Feedback): [Proposal] Expand Find pattern to Multiple Find
- Sorry for late response.
I disagree with this suggestion.
I implemented this feature in the [pattern-match](htt... -
- I've updated the message to say:
```
'when' clause on line 4 duplicates 'when' clause on line 2 and is ignored
`... -
-
-
-
-
-
- https://github.com/ruby/prism/commit/89d0d9851a
-
- https://github.com/ruby/prism/commit/dd532ded95
-
- It is saved in `setup` and restored in `teardown`.
https://github.com/rubygems/rubygems/commit/880c5de667 -
- In RubyKaigi 2024, I, naruse and nagachika discussed about maintaining stable branches. We propose the following memb...
-
04:21 AM Bug #20490: Process.waitpid2(-1, Process::WNOHANG) misbehaves on Ruby 3.1 & 3.2 with detached process
- I've opened fixes here:
* 3.2: https://github.com/ruby/ruby/pull/10771
* 3.1: https://github.com/ruby/ruby/pull/1... -
- I think this patch in the `ruby_3_2` branch fixes the problem:
```diff
diff --git a/process.c b/process.c
index 354e... -
- This is a follow-up issue for a bug that I thought was fixed in https://bugs.ruby-lang.org/issues/19837 and duplicate...
-
05/14/2024
-
09:51 PM Bug #20424: ZLib::GZipReader always double allocates strings when passed outbuf, significantly increasing memory usage
- [zlib #61 was merged](https://github.com/ruby/zlib/pull/61#event-12808578072). It seems like we can consider this tic...
-
09:44 PM Revision e3e1e530 (git): [ruby/zlib] Avoid double copying into provided outbuf
- https://github.com/ruby/zlib/commit/07f44b7546
-
- This accounts for a significant number of string allocations when reading rubygems, but we can avoid that in many pla...
- 09:43 PM Revision cb1a574e (git): Bump github/codeql-action from 3.25.4 to 3.25.5
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.4 to 3.25.5.
- [Release notes](https:... -
08:37 PM Bug #20489: Ractor behavior strange in ruby master
- Thank you. I'll investigate it.
-
09:00 AM Bug #20489 (Closed): Ractor behavior strange in ruby master
- This is a tarai program
Run`./ruby tarai_ractor.rb 2 8` is to use 2 thread to run 8 times tarai function total, that... -
07:41 PM Feature #6648: Provide a standard API for retrieving all command-line flags passed to Ruby
- nobu (Nobuyoshi Nakada) wrote in #note-15:
> `RbConfig` is for build time informations, and does not look a right pl... -
07:49 AM Feature #6648: Provide a standard API for retrieving all command-line flags passed to Ruby
- Note that for this to be most effective it would be the arguments unprocessed as they appear on the command line, but...
-
- `RbConfig` is for build time informations, and does not look a right place for runtime informations.
-
- If `RbConfig` is a convenient place for you, it is OK to add `ruby_args`.
Matz.
-
07:23 AM Feature #6648: Provide a standard API for retrieving all command-line flags passed to Ruby
- @matz Do you agree with `RbConfig.ruby_args`, is it OK to add it?
-
- When `gem uninstall <gem> --install-dir <dir>` is run, if the version
removed had a plugin, and that same version hap... -
- This class handles all logic to handle the list of specifications, given
a set of GEM_PATH directories. Makes `Gem::S... -
- https://github.com/rubygems/rubygems/commit/8c9807092c
-
- Other analog methods are documented, so document this one too.
https://github.com/rubygems/rubygems/commit/76da34d44d -
- I don't think this method is any worse than others, let's only document
what it does.
https://github.com/rubygems/ru... -
- https://github.com/rubygems/rubygems/commit/b545daa95d
-
- If we move test directory removal to the very end, I think we should not
leak anything.
https://github.com/rubygems/... -
- https://github.com/rubygems/rubygems/commit/7b71965a70
-
09:56 AM
Feature #15554: warn/error passing a block to a method which never use a block
- `--warn-unused-block`/`:warn_unused_block`?
-
- We are discussing how to make opt-in.
Because relaxed mode can miss cases (e.g. for methods with a common name), and... -
09:00 AM Feature #20437: Could the licensing conditions be made less ambiguous?
- > The Ruby License is a dual license with 2-clause BSDL and the "conditions below". Your proposal is the proposal to ...
-
- > lib/net/protocol.rb
The description is obsoleted.
The license of the code is the same as Ruby
> racc
Racc... - 08:22 AM Revision 41e6fd06 (git): [DOC] Fix typo in example code for `String#encode` method
- The example code in the documentation for the `String#encode` method has
a typo in the `fallback` option. The example... - 08:19 AM Revision 44f50f41 (git): Update default gems list at 4a1e4436a99c5794b022f03e8c0589 [ci skip]
-
08:18 AM Revision 4a1e4436 (git): [ruby/reline] Bump version to 0.5.7
- (https://github.com/ruby/reline/pull/704)
https://github.com/ruby/reline/commit/b9b3d392ff -
- Thank you for the PR. I agree that the patch is good to backport. PR merged at 449899b38314d0ecbe61e42d34398bdf2561b8e9.
-
- [Bug #20421]
The bug was fixed in Ruby 3.3 via 9dcdffb8bf8a3654fd78bf1a58b30c8e13888a7a -
- As long as the pluggable GC issue is clearly stated somewhere, I have no objection.
Matz.
-
07:01 AM Feature #20470: Extract Ruby's Garbage Collector
- I think the risk is fairly low, since the user has to compile Ruby with `--with-shared-gc` to enable this feature. Si...
-
- My concern is that a part of this feature, adding a new environment variable that loads a shared object implicitly, c...
-
- Before the change `C.keys` returned keys captured in some previous test case that by chance captured `nil` value what...
-
- (https://github.com/ruby/reline/pull/701)
* Refactor send
* Implement the undo command
* Fix @past_lines initializ...
Also available in: Atom