Activity
From 09/11/2024 to 09/17/2024
09/17/2024
-
11:49 PM Bug #20751 (Closed): Regression in Prism related to use of return in default argument values
- kddnewton (Kevin Newton) wrote in #note-2:
> I believe this was fixed this morning. Could you double-check that this... -
11:37 PM Bug #20751: Regression in Prism related to use of return in default argument values
- I believe this was fixed this morning. Could you double-check that this is still an issue?
-
11:19 PM Bug #20751 (Closed): Regression in Prism related to use of return in default argument values
- All versions of parse.y dating at least back to Ruby 1.8.7, and Prism in both Ruby 3.3.5 and 3.4.0preview1, correctly...
-
10:34 PM Feature #20750: Allow rb_thread_call_with_gvl to work when thread already has GVL
- Hello Benoit,
Thank you for your question.
Eregon (Benoit Daloze) wrote in #note-1:
> This seems like a strang... -
08:03 PM Feature #20750: Allow rb_thread_call_with_gvl to work when thread already has GVL
- Note that the majority of the search results are just CRuby using it, and GitHub not detecting it's effectively copie...
-
04:52 PM Feature #20750 (Open): Allow rb_thread_call_with_gvl to work when thread already has GVL
- Hello All,
I'm hoping we can make `ruby_thread_has_gvl_p` a public method and no longer experimental.
I saw the... -
10:12 PM Revision 39679d7f (git): [ruby/uri] Fix spelling of "cannot"
- https://github.com/ruby/uri/commit/77241d6508
-
08:35 PM Revision 5307c65c (git): Make rb_gc_impl_set_measure_total_time return void
-
08:09 PM Revision b203e667 (git): [rubygems/rubygems] Fix spelling, it's "cannot" rather than "can not"
- https://github.com/rubygems/rubygems/commit/3434f094a2
-
07:22 PM Revision dc61c7fc (git): Rename rb_gc_impl_get_profile_total_time to rb_gc_impl_get_total_time
-
07:22 PM Revision 2af080bd (git): Change rb_gc_impl_get_profile_total_time to return unsigned long long
-
07:22 PM Revision 5de7517b (git): Use unsigned long long for marking and sweeping time
-
06:47 PM Revision 748933aa (git): [ruby/prism] Accept "do" blocks in some parameter default values
- https://github.com/ruby/prism/commit/6d7b734dbe
-
02:39 PM Feature #20742: Trying to assign to a variable in statement modifier should emit a warning
- Earlopain (A S) wrote in #note-5:
> Should this just work? If I do:
>
> ```rb
> if a = 0.zero?
> p a
> end
... -
09:00 AM Feature #20742: Trying to assign to a variable in statement modifier should emit a warning
- Should this just work? If I do:
```rb
if a = 0.zero?
p a
end
```
it has no problem with it. I would expec... -
02:34 PM Revision 0160dafc (git): Replace all GC.disable with EnvUtil.without_gc
-
02:07 PM Revision 82151a86 (git): Fix a typo, sorry!
-
01:52 PM Revision fd5e5839 (git): Prevent two warnings
- ```
/home/chkbuild/chkbuild/tmp/build/20240917T123003Z/ruby/test/ruby/test_case.rb:73: warning: 'when' clause on line... -
12:40 PM Bug #20749: Error message not shown in output with prism
- This was an issue with the error_highlight gem. I made a PR here: https://github.com/ruby/error_highlight/pull/48
-
12:37 PM Feature #20309: Bundled gems for Ruby 3.5
- vo.x (Vit Ondruch) wrote in #note-35:
> I don't think it is bad idea to start using `bundle install --local`, i.e. us... -
09:40 AM Feature #20309: Bundled gems for Ruby 3.5
- > I don't think so. Bundler should provide that feature for like debug, stackprof and irb. I and @mame (Yusuke Endoh)...
-
08:53 AM Feature #20309: Bundled gems for Ruby 3.5
- >The fact that we want binding.irb to work regardless of being in a bundle exec context or not feels like a sign that...
-
11:10 AM Revision cf063c00 (git): [rubygems/rubygems] Bump rubies in CI to 3.3.5
- A spec needed changes because now loading the default `json` prints a
warning about `ostruct` getting loaded although... -
08:48 AM Bug #20734: Test failure at FreeBSD 14.1
- I could build 4ca588eede and `git clean -fxd`.
But Ruby CI is still stopped from Sep 5th.
https://rubyci.s3.am... -
08:37 AM Bug #20631: Build failure with Xcode 16 beta and macOS 15 (Sequoia) Beta
- `Process.daemon` is working fine at macOS 15.1 beta3 and Xcode 16 RC.
I enabled `TestProcess#test_daemon_noclose` ... -
07:16 AM Revision 1ecac5d4 (git): TestProcess#test_daemon_noclose is working fine with macOS 15.1 beta3 and Xcode 16 RC
-
06:44 AM Revision 95f08f2b (git): Skip failing examples related with https://github.com/ruby/ruby/commit/d81b0588bb3c97167d1f7e2d2a74185e0c19b68c
-
06:37 AM Revision c0116860 (git): Removed accidentally commit for snapshot file of prism
-
06:12 AM Revision d81b0588 (git): [ruby/strscan] Accept String as a pattern at non head
- (https://github.com/ruby/strscan/pull/106)
It supports non-head match cases such as StringScanner#scan_until.
If we... -
05:41 AM Revision 7d80c139 (git): Unlock parallel_tests
-
05:39 AM Revision 80e934c2 (git): [rubygems/rubygems] Fix `--local` hitting the network when default gems are included
- https://github.com/rubygems/rubygems/commit/b9a2d4d539
-
05:39 AM Revision 335d6309 (git): [rubygems/rubygems] Improve spec
- The behavior it's testing is independent from the bundle path being
used.
https://github.com/rubygems/rubygems/commi... -
05:39 AM Revision 166cde7d (git): [rubygems/rubygems] Fix spec to setup a default gem correctly
- Looking at the description is something that used to be done a long time
ago.
https://github.com/rubygems/rubygems/c... -
05:39 AM Revision 7428709d (git): [rubygems/rubygems] Inline a private method
- Removes an (in my opinion) excessive indirection and handles options
more consistently.
https://github.com/rubygems/... -
05:39 AM Revision 7e0934d3 (git): [rubygems/rubygems] Consistently access install options through symbol keys
- https://github.com/rubygems/rubygems/commit/7ddf1dc70a
-
05:15 AM Revision 70111fcc (git): Prevent a warning due to error recovery of prism
-
05:10 AM Revision d90da940 (git): Prevent warnings for RubyVM::AbstractSyntaxTree.parse in test_ast.rb
-
04:56 AM Revision d84b062b (git): Prevent warning: assigned but unused variable - message
- 03:54 AM Revision 4ca588ee (git): Bump github/codeql-action from 3.26.6 to 3.26.7
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.6 to 3.26.7.
- [Release notes](https:... -
03:52 AM Revision bb2d2473 (git): [DOC] Fix autoload method formatting
-
03:46 AM Revision bb7025b7 (git): Activate irb if irb is bundled gems
-
03:44 AM Revision 76d927f8 (git): Prevent prism warnings in syntax exhaustive tests
- [Bug #20736]
-
12:28 AM Revision 4e59e7d3 (git): [Bug #20737] Do not warn default gems to be promoted in Ruby 3.5 (#11613)
-
12:11 AM Bug #20723 (Closed): `IO#close` is broken on Ruby 3.3+ when using the Fiber scheduler.
- Applied in changeset commit:git|e08d5239b68ad61a731f4938cf963e37a5e88c25.
----------
Ensure fiber scheduler is woken... -
12:11 AM Revision e08d5239 (git): Ensure fiber scheduler is woken up when close interrupts read
- If one thread is reading and another closes that socket, the close
blocks waiting for the read to abort cleanly. This...
09/16/2024
-
08:35 PM Feature #20309: Bundled gems for Ruby 3.5
- Eregon (Benoit Daloze) wrote in #note-34:
> There is an additional issue with making fiddle a bundled gem: it means ... -
10:27 AM Feature #20309: Bundled gems for Ruby 3.5
- There is an additional issue with making fiddle a bundled gem: it means any usage now must have libffi headers availa...
-
07:58 PM Revision 50d4840b (git): Move desired_compaction_pages_i inside of GC_CAN_COMPILE_COMPACTION
- Fixes the following warning on WebAssembly:
gc/default.c:7306:1: warning: unused function 'desired_compaction_pa... -
07:55 PM Bug #20747 (Closed): [prism] regression in retry precedence
-
07:28 PM Bug #20747: [prism] regression in retry precedence
- I have opened a PR to fix this: https://github.com/ruby/prism/pull/3073.
-
08:26 AM Bug #20747 (Closed): [prism] regression in retry precedence
- Since prism has been made the default, our test suite now fail to boot with the following error:
```ruby
syntax e... -
07:55 PM Revision 7e2ae30f (git): [ruby/prism] Handle retry doubly nested under rescue
- Fixes [Bug #20747]
https://github.com/ruby/prism/commit/d3194715a9 -
06:58 PM Bug #20744 (Closed): syntax error found (SyntaxError) `UTF-8 mixed within US-ASCII source` reported Ruby with Prism parser
- Applied in changeset commit:git|2ea1950510003dbce5a761a712039ed69fa499f2.
----------
[ruby/prism] Do not leak explic... -
06:41 PM Bug #20744: syntax error found (SyntaxError) `UTF-8 mixed within US-ASCII source` reported Ruby with Prism parser
- I have opened a PR to fix this.
https://github.com/ruby/prism/pull/3071 -
12:49 PM Bug #20744: syntax error found (SyntaxError) `UTF-8 mixed within US-ASCII source` reported Ruby with Prism parser
- Thank you for the report, I will take a look.
-
07:07 AM Bug #20744: syntax error found (SyntaxError) `UTF-8 mixed within US-ASCII source` reported Ruby with Prism parser
- I'm unsure if this is the same case as Rails, but I found a reproduce code.
``` ruby
# encoding: US-ASCII
str ... -
04:33 AM Bug #20744 (Closed): syntax error found (SyntaxError) `UTF-8 mixed within US-ASCII source` reported Ruby with Prism parser
- I'm reporting this issue based on Rails Nightly CI against Ruby 3.4.0dev.
https://buildkite.com/rails/rails-nightly... -
06:57 PM Revision 2ea19505 (git): [ruby/prism] Do not leak explicit encoding
- Fixes [Bug #20744]
https://github.com/ruby/prism/commit/f1b8b1b2a2 -
06:38 PM Revision 1e53e462 (git): Don't export unnecessary string functions
- These functions are not used publicly, so we don't need to export them.
-
06:31 PM Bug #20741 (Closed): RubyVM::InstructionSequence.compile emits a wrong warning (prism?)
-
03:04 PM Bug #20741: RubyVM::InstructionSequence.compile emits a wrong warning (prism?)
- I have submitted a PR that will fix this https://github.com/ruby/ruby/pull/11632.
-
06:31 PM Revision 2beb4c6e (git): [PRISM] Assume an eval context for RubyVM::ISEQ compile
- Fixes [Bug #20741]
-
05:36 PM Revision 6c4ce726 (git): [ruby/irb] Use InstructionSequence#script_lines to get method source
- (https://github.com/ruby/irb/pull/1005)
It works with both prism and parse.y
https://github.com/ruby/irb/commit/bcf... -
04:33 PM Revision 1c3981cb (git): [DOC] Tweaks for Array#select!
-
04:33 PM Revision 4e17fa29 (git): Tweaks or Array#select
-
04:14 PM Misc #20717: DevMeeting-2024-10-03
- * [Misc #20728] Add eileencodes as a core committer
* She's made many useful contributions
* She's currently help... -
08:05 AM Misc #20717: DevMeeting-2024-10-03
- * [Misc #20746] Request to migrate the `json` gem from `flori/json` repository to `ruby/json` (byroot)
* Current m... -
03:54 PM Feature #20742: Trying to assign to a variable in statement modifier should emit a warning
- Actually, the pattern is fairly common, I should have searched for `unless` usage in addition to `if`:
```
lib/rd... -
03:48 PM Feature #20742: Trying to assign to a variable in statement modifier should emit a warning
- Eregon (Benoit Daloze) wrote in #note-2:
> jeremyevans0 (Jeremy Evans) wrote in #note-1:
> > Assigning in post-cond... -
11:42 AM Feature #20742: Trying to assign to a variable in statement modifier should emit a warning
- jeremyevans0 (Jeremy Evans) wrote in #note-1:
> Assigning in post-conditionals is a fairly common in Ruby.
Is it?... -
03:54 PM Bug #20748 (Closed): Issue with defined? given method call with block in prism compiler
- Applied in changeset commit:git|1e52dde82af10f2a2ec648b34dce30bec4154245.
----------
[PRISM] Match defined behavior ... -
03:29 PM Bug #20748: Issue with defined? given method call with block in prism compiler
- I agree it's weird but it could cause an incompatibility I guess, `defined?()` is a weird one for sure.
-
03:16 PM Bug #20748: Issue with defined? given method call with block in prism compiler
- I have opened a PR for this to match the behavior exactly, but I will say I think Prism's behavior is actually correc...
-
01:59 PM Bug #20748 (Closed): Issue with defined? given method call with block in prism compiler
- test.rb
```ruby
puts defined?(undefined_method(){})
```
```
./ruby --parser=parse.y -I../ruby/lib -I. -I.ext/x... -
03:53 PM Revision 1e52dde8 (git): [PRISM] Match defined behavior for explicit block
- Fixes [Bug #20748]
-
02:41 PM Bug #20237 (Closed): Unable to unshare(CLONE_NEWUSER) in Linux because of timer thread
-
06:42 AM Bug #20237: Unable to unshare(CLONE_NEWUSER) in Linux because of timer thread
- Thank you @ko1 for sharing the current situation. I'm fine with closing this ticket as it is due to the design decisi...
-
02:16 PM Bug #20749 (Closed): Error message not shown in output with prism
- test.rb:
```ruby
p = Proc.new
```
```
./ruby --parser=parse.y -I../ruby/lib -I. -I.ext/x86_64-linux -I.ext/com... -
01:27 PM Revision 50564f88 (git): ASAN unpoison whole heap page after adding to size pool
-
01:27 PM Revision 46ba3752 (git): Don't return inside of asan_unpoisoning_object
-
01:27 PM Revision c5a782df (git): Replace with asan_unpoisoning_object
-
01:13 PM Revision f4f46af9 (git): Complete spec
- Co-authored-by: Vít Ondruch <[email protected]>
-
01:13 PM Revision 2bfeedc0 (git): [rubygems/rubygems] Simplify handling default gem caching
- By the time `cached_gem` is called, default gem cache has already been
handled. So no need to try redownload it again... -
12:44 PM Revision d57bc870 (git): [PRISM] Remove snapshot testing from Prism sync
-
11:38 AM Misc #20746: Request to migrate the json gem from flori/json repository to ruby/json
- +1, as I wrote in https://github.com/flori/json/issues/591 I think this is important for many reasons.
-
08:02 AM Misc #20746 (Closed): Request to migrate the json gem from flori/json repository to ruby/json
- ### Context
The `json` gem, which is part of Ruby's default gems, is the only default gem (aside from `rubygems` i... -
11:37 AM Revision fab01b15 (git): [rubygems/rubygems] Remove temporary `.lock` files left around by gem installer
- https://github.com/rubygems/rubygems/commit/edbb2e3475
-
11:37 AM Revision 7411caa1 (git): [rubygems/rubygems] Make sure implementations of `Gem.open_file_with_flock` match
- https://github.com/rubygems/rubygems/commit/174a8e5284
-
06:51 AM Bug #20745: IO::Buffer#copy triggers UB when src/dest buffers overlap
- `#set_string` in combination with `.for` with a block has the same problem.
```shell-session
% docker run --platf... -
06:33 AM Bug #20745 (Closed): IO::Buffer#copy triggers UB when src/dest buffers overlap
- The current implementation of `IO::Buffer#copy` uses `memcpy` to copy data between the two memory regions. `memcpy` h...
-
01:35 AM Feature #20738: Removing a specific entry from a hash literal
- It would be better to explain the motive. This is an appropriate code.
``` ruby
{
foo: 1
bar: 2
}
```
... -
01:19 AM Feature #20738: Removing a specific entry from a hash literal
- I would like to offer that as I used a simple grep pattern, I could only find simple examples. I wanted to show that ...
09/15/2024
-
07:15 PM Bug #20726: Issue with hash without braces when assigned to constant with ractor literals
- This problem was not reproduced with `--parser=prism`, but with `--parser=parse.y`.
```ruby
# shareable_constant_... -
06:07 PM Bug #20743: ruby doesn't properly split RUBY_DEBUG_LOG_FILTER into items
- Apparently introduced in the following commit:
https://github.com/ruby/ruby/commit/5a4f997b2e8e819ed40731cd769826112... -
05:58 PM Bug #20743 (Assigned): ruby doesn't properly split RUBY_DEBUG_LOG_FILTER into items
- ```
$ docker run --rm alpine:3.20.3 sh -euxc '
apk add git build-base autoconf ruby yaml-dev zlib-dev openssl-d... -
06:06 PM Feature #20738: Removing a specific entry from a hash literal
- > There are several Rails codes that can be improved with this feature.
As one of the maintainer of the code you ... -
04:32 PM Feature #20738: Removing a specific entry from a hash literal
- ursm (Keita Urashima) wrote in #note-9:
> There are several Rails codes that can be improved with this feature. In m... -
12:36 PM Feature #20738: Removing a specific entry from a hash literal
- Eregon (Benoit Daloze) wrote in #note-8:
> I don't think it's very frequent to need this to warrant a syntax change ... -
05:52 PM Feature #20742: Trying to assign to a variable in statement modifier should emit a warning
- Assigning in post-conditionals is a fairly common in Ruby. If this is to be a warning, it would have to be limited t...
-
05:42 PM Feature #20742 (Open): Trying to assign to a variable in statement modifier should emit a warning
- There is an example in Control Expressions documentation:
```
p a if a = 0.zero? # raises NameError “undefined lo... -
10:25 AM Bug #20736: prism emits wrong warnings in syntax-error code
- I think good error recovery is key to have helpful error messages when writing Ruby code.
Maybe one way here is to... -
12:51 AM Bug #20736: prism emits wrong warnings in syntax-error code
- https://github.com/ruby/ruby/pull/11626
-
12:46 AM Bug #20736: prism emits wrong warnings in syntax-error code
- I wonder if error recovery is needed in the interpreter's parser. It might be a benefit to be able to output almost a...
-
09:10 AM Bug #20741: RubyVM::InstructionSequence.compile emits a wrong warning (prism?)
- > prism?
Yes:
```
$ ./miniruby --parser=parse.y -we 'p RubyVM::InstructionSequence.compile("42").eval'
42
$ ... -
01:05 AM Bug #20741 (Closed): RubyVM::InstructionSequence.compile emits a wrong warning (prism?)
- ```
$ ./local/bin/ruby -we 'p RubyVM::InstructionSequence.compile("42").eval'
<compiled>:1: warning: possibly usele... -
01:06 AM Revision 532af89e (git): Prevent warnings: the block passed to ... may be ignored
-
01:05 AM Revision bc13ec73 (git): Prevent warnings: assigned but unused variable
09/14/2024
-
04:34 PM Feature #20738: Removing a specific entry from a hash literal
- I don't think it's OK to magically drop entries from a literal based on some value, it's way too surprising.
Notably ... -
05:24 AM Feature #20738: Removing a specific entry from a hash literal
- I believe that the following two points will prevent the same problems as in the past:
1. Use a value that is neve... -
04:53 AM Feature #20738: Removing a specific entry from a hash literal
- History. Long ago in Ruby, such a special value actually existed. It was `nil`.
```ruby
# ruby 1.4.6
h = { 1 => ... -
07:54 AM Bug #20730: LoadError if Rakefile has shebang
- `ruby` command handles a shebang, but it is not a part of the Ruby syntax.
Parsers should not consider shebang lines.
09/13/2024
-
08:58 PM Bug #20736: prism emits wrong warnings in syntax-error code
- Right now Prism is lexing `9a` as an integer and then an identifier. So it's effectively parsing it as `1; 2; 9; a`. ...
-
07:51 PM Bug #20736: prism emits wrong warnings in syntax-error code
- Although I can understand the technical reason, I still feel a bit uncomfortable when the warning says “use of a lite...
-
05:02 PM Bug #20736 (Feedback): prism emits wrong warnings in syntax-error code
-
03:32 PM Bug #20736: prism emits wrong warnings in syntax-error code
- This is because Prism recovers from the syntax error. For example:
```ruby
eval("1; 2; 9a; 3; 4; 5; 9b")
```
... -
03:23 AM Bug #20736 (Feedback): prism emits wrong warnings in syntax-error code
- ```
$ ./local/bin/ruby -w --parser=parse.y -e 'begin eval("0a"); rescue SyntaxError; end'
$ ./local/bin/ruby -w --p... -
07:30 PM Revision ddbd6440 (git): [ruby/prism] Stat file first to check directory
- https://github.com/ruby/prism/commit/4ed7de537b
-
07:16 PM Bug #20473: Ractor array/hash literals
- Okay, makes sense. Maybe if/when ractors are used more I'll take a look at this again.
-
07:13 PM Revision f85efc97 (git): [ruby/prism] Expose main_script in serialization API
- https://github.com/ruby/prism/commit/0b527ca93f
-
06:13 PM Bug #20735 (Closed): prism emits "ambiguous `&`" warning
-
04:49 PM Bug #20735: prism emits "ambiguous `&`" warning
- I have opened https://github.com/ruby/ruby/pull/11622 to fix this.
-
02:40 AM Bug #20735 (Closed): prism emits "ambiguous `&`" warning
- ```
$ ./local/bin/ruby -w --parser=parse.y -e 'def foo(&) = nil; foo &:bar'
$ ./local/bin/ruby -w --parser=prism -e... -
06:09 PM Bug #20730 (Closed): LoadError if Rakefile has shebang
- Applied in changeset commit:git|9afc6a981deae6e23d938cf5c2c4baadfeaafdb1.
----------
[PRISM] Only parse shebang on m... -
03:23 PM Bug #20730: LoadError if Rakefile has shebang
- I have opened https://github.com/ruby/ruby/pull/11617 to fix this.
-
01:19 AM Bug #20730 (Closed): LoadError if Rakefile has shebang
- `LoadError` exception will be raised when invoke the rake task with latest ruby 3.4-dev.
### Reproduce code
Here ... -
06:09 PM Revision 77521afa (git): [PRISM] Do not warn ambiguous ampersand when symbol literal
- Fixes [Bug #20735]
-
05:44 PM Feature #20309: Bundled gems for Ruby 3.5
- Regarding `irb`, I find it concerning that we need to add code like this: https://github.com/ruby/ruby/blob/9afc6a981...
-
05:16 PM Bug #20737: Accidentally changed warning target on Ruby 3.3
- Agreed, I didn't expect new warnings in 3.3.5 when 3.3.4 did not warn, and extra warnings can break CI (e.g. #20713).
-
05:57 AM Bug #20737 (Closed): Accidentally changed warning target on Ruby 3.3
- https://github.com/ruby/ruby/pull/11613
-
04:10 AM Bug #20737: Accidentally changed warning target on Ruby 3.3
- Makes sense. Let's revert that back to the Ruby 3.3.4 one in Ruby 3.3.6.
-
04:03 AM Bug #20737 (Closed): Accidentally changed warning target on Ruby 3.3
- I heard that concern from yhonda.
I request to backport bundled_gems.rb that is same version of the current master... -
05:12 PM Misc #20739: Test suite does not carry over CLI options
- I think it's a real issue and sometimes valuable to fix (it hurts the coverage of tests * flags).
#6648 could be help... -
01:37 PM Misc #20739 (Open): Test suite does not carry over CLI options
- I'm not sure if anything needs to change here, but I wanted to report this in case anyone had any particular ideas. W...
-
05:01 PM Bug #20731 (Closed): warning: mismatched indentations at 'when' appears with prism enabled ruby
-
04:08 PM Bug #20731: warning: mismatched indentations at 'when' appears with prism enabled ruby
- I have opened https://github.com/ruby/ruby/pull/11620 to fix this.
-
02:42 AM Bug #20731 (Assigned): warning: mismatched indentations at 'when' appears with prism enabled ruby
-
01:37 AM Bug #20731: warning: mismatched indentations at 'when' appears with prism enabled ruby
- @mame
Thanks! -
01:34 AM Bug #20731: warning: mismatched indentations at 'when' appears with prism enabled ruby
- The wrong warning with `rss` gem is a different issue. I have created a separate ticket #20732.
-
01:24 AM Bug #20731: warning: mismatched indentations at 'when' appears with prism enabled ruby
- I also have similar issues with `rss`.
```
/Users/hsbt/Documents/github.com/ruby/ruby/gems/src/rss/lib/rss/1.0.rb... -
01:20 AM Bug #20731 (Closed): warning: mismatched indentations at 'when' appears with prism enabled ruby
- ### Steps to reproduce
1. Create a `case_sample.rb` file
```
foo = :bar
case foo
when :bar
p 'foo is :bar... -
04:51 PM Revision 9afc6a98 (git): [PRISM] Only parse shebang on main script
- Fixes [Bug #20730]
-
04:51 PM Revision d42d1905 (git): [PRISM] Allow case/when to be indented with no warning
- Fixes [Bug #20731]
-
04:45 PM Bug #20740: prism_compile coding issue for PM_FORWARDING_SUPER_NODE
- PR here: https://github.com/ruby/ruby/pull/11621
-
04:44 PM Bug #20740 (Closed): prism_compile coding issue for PM_FORWARDING_SUPER_NODE
- I found a coding issue in prism_compile.c but I can't find a bug that would result from it.
The `current_block` is... -
04:09 PM Bug #20732 (Closed): prism emits "mismatched indentations" warning in eval
- Applied in changeset commit:git|74f315c3f5908512dfdeeab2dd76d93e98149769.
----------
[PRISM] Turn off mismatched ind... -
03:26 PM Bug #20732: prism emits "mismatched indentations" warning in eval
- I have opened https://github.com/ruby/ruby/pull/11618 to fix this.
-
01:28 AM Bug #20732 (Closed): prism emits "mismatched indentations" warning in eval
- ```ruby
eval(<<-EOC)
if @check
end
EOC
```
```
$ ruby --parser=parse.y -w t.rb
$ ruby --parser=prism -w t... -
04:08 PM Revision 74f315c3 (git): [PRISM] Turn off mismatched indentation warnings in eval
- Fixes [Bug #20732]
-
03:05 PM Revision 353997dd (git): [ruby/prism] Refactor and move common node flags count into a constant to reuse in templates
- https://github.com/ruby/prism/commit/c20bf05ecc
-
03:05 PM Revision 38f8f42e (git): [ruby/prism] Unify code style of flags generation in the nodes templates
- https://github.com/ruby/prism/commit/dbb7e0a44e
-
02:58 PM Feature #20738: Removing a specific entry from a hash literal
- With the previous idea, I can't have both removing entries and returning nil depending on the condition.
``` ruby
... -
01:17 PM Feature #20738: Removing a specific entry from a hash literal
- nobu (Nobuyoshi Nakada) wrote in #note-1:
> "A special value" doesn't feel like a good idea to me.
Hmmm, does tha... -
12:16 PM Feature #20738: Removing a specific entry from a hash literal
- Yes, I sometimes do that as well. However, I am not happy that the shape of the resulting hash is unclear.
-
11:59 AM Feature #20738: Removing a specific entry from a hash literal
- How about using `**`?
```ruby
def bar? = false
{
foo: 1,
**(bar? ? { bar: 2 } : {})
}
# => {:foo=>1}
... -
07:57 AM Feature #20738: Removing a specific entry from a hash literal
- "A special value" doesn't feel like a good idea to me.
-
07:33 AM Feature #20738 (Rejected): Removing a specific entry from a hash literal
- Sometimes I want to decide whether or not to add a particular entry to a hash depending on a condition. If the entire...
-
02:06 PM Revision c996f409 (git): Ignore -Wdangling-pointer in rb_gc_set_stack_end
- Fixes this compiler warning:
thread.c:4530:18: warning: storing the address of local variable ‘stack_end’ in ‘*s... -
01:17 PM Revision f0dcbbe9 (git): [ruby/prism] Reverse-sync numbered reference range handling
- https://github.com/ruby/prism/commit/a2f57ef6e3
-
12:42 PM Revision 8e2d971b (git): [rubygems/rubygems] Remove redundant arguments passed to `bundle` helper
- They are used by default.
https://github.com/rubygems/rubygems/commit/0b7f7d879f -
12:42 PM Revision 36b2fea6 (git): [rubygems/rubygems] Remove `BUNDLER_IGNORE_DEFAULT_GEM`
- As long as we use a high enough test version, the default version of
Bundler should never get in the middle.
https:/... -
12:42 PM Revision 64252851 (git): [rubygems/rubygems] Make sure test does not load system version of Bundler
- https://github.com/rubygems/rubygems/commit/d850ea1d95
-
10:37 AM Bug #20725 (Closed): Inconsistent handling of doubly-unbounded ranges in Range#overlap?
- Applied in changeset commit:git|24493779b79bb57fd2e71bf6e0ababe95448a9d6.
----------
[Bug #20725] Should not call co... -
01:56 AM Bug #20725: Inconsistent handling of doubly-unbounded ranges in Range#overlap?
- https://github.com/ruby/ruby/pull/11609
-
09:23 AM Revision 24493779 (git): [Bug #20725] Should not call compare on `nil`-endpoint
- It means unbounded, always inclusive of other ranges.
-
07:52 AM Revision 0f3dc2f9 (git): Prevent warnings "the block passed to ... may be ignored"
-
07:45 AM Bug #20723: `IO#close` is broken on Ruby 3.3+ when using the Fiber scheduler.
- Sorry about this. I think https://github.com/ruby/ruby/pull/11614 is the smallest diff that will fix the issue (and t...
-
06:49 AM Revision b6c7226f (git): Put typeprof.gemspec
-
06:49 AM Revision f090d1fa (git): Try to find bundled gem version from lib/*/version.rb
-
06:49 AM Revision cf5b9658 (git): Use the development version of typeprof in test-bundled-gems
- 05:35 AM Revision 58942023 (git): typo otherBasis -> orthoBasis
- The original function name in ao.c was orthoBasis.
I guess the function is generating orthonormal basis (https://en.w... -
04:19 AM Revision 3146cbbb (git): Dont't warn reline called from irb, reline is already declared at irb gemspec
-
02:39 AM Revision 6ae05584 (git): [ruby/net-http] Prevent warnings
- ```
/home/chkbuild/chkbuild/tmp/build/20240913T003003Z/ruby/test/net/http/utils.rb:32: warning: assigned but unused v... -
02:34 AM Revision 5e3f1b6a (git): Prevent a warning: assigned but unused variable - exp_events
-
02:32 AM Revision d1d0c50c (git): Prevent a warning: assigned but unused variable - t0
-
02:30 AM Bug #20734 (Closed): Test failure at FreeBSD 14.1
- FreeBSD 14.1 build is also failure with ruby master. This is different error from #20733
```
[hsbt@freebsd ~/rub... -
02:29 AM Bug #20733 (Open): Build failure OpenSSL extension with FreeBSD 13.3
- FreeBSD 13.3 build on Ruby CI was failure from 1 week ago. I manually build ruby master on FreeBSD 13 and got the fol...
-
01:39 AM Misc #20728: Propose Eileen Uchitelle as a core committer
- I thought she was a committer long ago.
-
12:47 AM Bug #20729 (Closed): Test failure with 0fc8422a05 and native mswin environment
- I got the following failure with mswin environment.
```
1) Failure:
TestRubyOptions#test_command_line_progname... -
12:28 AM Revision d80a81c1 (git): Constify `struct getpwnam_r_args::login`
09/12/2024
-
10:44 PM Misc #20728: Propose Eileen Uchitelle as a core committer
- +1
-
08:48 PM Misc #20728: Propose Eileen Uchitelle as a core committer
- +1
-
08:25 PM Misc #20728: Propose Eileen Uchitelle as a core committer
- +1
-
08:17 PM Misc #20728: Propose Eileen Uchitelle as a core committer
- +1, I think Eileen would make a great addition, especially as a maintainer on the Prism parser / compiler. She's also...
-
07:18 PM Misc #20728 (Closed): Propose Eileen Uchitelle as a core committer
- I'd like to propose Eileen Uchitelle (@eileencodes) as a core committer. Now that Prism ([Feature #20564]) is merged,...
-
09:36 PM Feature #20564 (Open): Switch default parser to Prism
- >Is there the criteria for reverting this until Ruby 3.4 release?
I'm still waiting this answer. -
05:43 PM Feature #20564 (Closed): Switch default parser to Prism
- Per this ticket, I have merged https://github.com/ruby/ruby/pull/11497 to switch the default parser on master. The ca...
-
08:03 PM Revision 0fc8422a (git): Move checks for heap traversal to rb_gc_mark_weak
- If we are during heap traversal, we don't want to call rb_gc_impl_mark_weak.
This commit moves that check from rb_gc_... -
08:03 PM Revision 92b7b78e (git): Assert that we are during GC when marking
-
08:03 PM Revision 661f64e8 (git): Add variable objspace in RB_GC_MARK_OR_TRAVERSE
-
08:03 PM Revision 606db2c4 (git): Move special const checks to rb_gc_mark_weak
-
07:49 PM Revision 2d495300 (git): [PRISM] Fix up pm_compile_branch_condition issue with single insn iseqs
-
07:19 PM Revision 0960c8aa (git): [DOC] Tweaks for Array#fetch_values (#11603)
-
07:18 PM Revision ce5fd35b (git): [DOC] Tweaks for Array#fetch (#11602)
-
07:07 PM Revision 05e02783 (git): [PRISM] Ignore test_parse_directory if error is nil
-
06:55 PM Bug #20473: Ractor array/hash literals
- Truthfully it might not be worth adding these optimizations. It's a lot to maintain in both compilers, and this kind ...
-
06:40 PM Bug #20473: Ractor array/hash literals
- I added back the array literal optimizations here: https://github.com/luke-gru/ruby/tree/bug20473
I didn't send a ... -
06:09 PM Bug #20727 (Assigned): YJIT segmentation fault inside of invalidate_block_version
- For a while we've been seeing an occasional segfault in production inside of YJIT's invalidation code. It seems to ha...
-
05:43 PM Bug #20586 (Closed): Some filesystem calls in dir.c are missing error handling and can return incorrect results if interrupted
- Applied in changeset commit:git|f2919bd11c570fc5f5440d1f101be38f61e3d16b.
----------
Add error checking to readdir, ... -
05:43 PM Revision 9c461cd1 (git): [PRISM] Check error type for parsing directory
-
05:43 PM Revision 38ba15be (git): [ruby/prism] Check errno for parsing directory
- https://github.com/ruby/prism/commit/d68ea29d04
-
05:43 PM Revision ca61729f (git): Fix opening multibyte character filepath on Windows
-
05:43 PM Revision d4af38ec (git): Fix FILE_SHARE_* permissions for Windows in read_entire_file
-
05:43 PM Revision d5232fd7 (git): Temporarily exclude some TestRubyOptions test for parse.y
- The description has been updated when running with Prism to have
+PRISM, which means that tests asserting against the... -
05:43 PM Revision f59b908e (git): [PRISM] Omit some TestAST tests when Prism is enabled
-
05:43 PM Revision d4ab1e44 (git): [PRISM] Move compile scope node to its own function
-
05:43 PM Revision c4b43692 (git): [PRISM] Move case node compilation into its own function
-
05:43 PM Revision ea2af578 (git): Switch the default parser from parse.y to Prism
- This commit switches the default parser to Prism. There are a
couple of additional changes related to this that are a... -
05:04 PM Revision f2919bd1 (git): Add error checking to readdir, telldir, and closedir calls in dir.c
- Raise SystemCallError exception when these functions return an error.
This changes behavior for the following case (... -
03:50 PM Revision 15135030 (git): [ruby/prism] Do not warn \r in shebang on windows
- https://github.com/ruby/prism/commit/e8c862ca1f
-
03:04 PM Revision a542479a (git): [ruby/irb] Remove KEYWORD_ALIASES which handled special alias name
- of irb_break irb_catch and irb_next command
(https://github.com/ruby/irb/pull/1004)
* Remove KEYWORD_ALIASES which h... -
02:47 PM Revision fcb05830 (git): Accept version range
- Single `Integer` argument means an exact match to the major version.
-
02:33 PM Revision d8aa8f41 (git): Related for Array#eql?
-
02:32 PM Revision c147e43b (git): [DOC] Related for Array#empty?
-
02:32 PM Revision 471d3950 (git): [DOC] Tweaks for Array#each_index
-
02:24 PM Revision ad761ad2 (git): Release GVL for get{pwnam,pwuid,grgid,grnam}_r calls in process.c
- Do not release GVL around get{pwuid,pwnam,grgid,grnam} calls,
as doing so is not thread-safe. Another C extension co... -
02:23 PM Bug #20620: singleton_method undefined for module using "extend self"
- I submitted a pull request to implement this: https://github.com/ruby/ruby/pull/11605
In terms of compatibility is... -
02:15 PM Revision b10500b7 (git): Assume VM is locked in rb_vm_ci_free
- The GC always locks the VM, so we don't need to lock it in rb_vm_ci_free.
-
01:30 PM Bug #20726 (Assigned): Issue with hash without braces when assigned to constant with ractor literals
- ```ruby
# shareable_constant_value: literal
a = 'hi'
A = ['hello' => a]
p A
```
gives:
```
./ruby -I../ru... -
01:03 PM Bug #20725 (Closed): Inconsistent handling of doubly-unbounded ranges in Range#overlap?
- The new `Range#overlap?` method does not seem to have a clear definition of how it behaves when passed ranges with ni...
-
12:06 PM Revision f47c057c (git): Remove unnecessary file
-
12:06 PM Revision 885cf350 (git): Lrama v0.6.10
-
07:28 AM Revision 2a1962fc (git): Warn missing irb cases
-
07:28 AM Revision 86fcfcb3 (git): Fixed ensure scope
-
07:28 AM Revision 6c9f0be6 (git): Don't use instance variable
-
07:28 AM Revision ee064d1c (git): Back to Bundler.ui and Bundler::Definition.no_lock
-
07:28 AM Revision 754e15f4 (git): Support bundler/inline mode
-
07:28 AM Revision 70c66137 (git): Use better resolution by Bundler at force_activate
-
03:53 AM Feature #19908: Update to Unicode 15.1
- >I think it's more prudent to do 15.1 first, then 16.0.
Agreed, thanks! -
03:21 AM Feature #19908: Update to Unicode 15.1
- hsbt (Hiroshi SHIBATA) wrote in #note-8:
> Unicode 16.0 has been released.
> Should we move this instead of 15.1?... -
01:56 AM Feature #19908: Update to Unicode 15.1
- Unicode 16.0 has been released.
https://www.unicode.org/versions/Unicode16.0.0/
Should we move this instead of ... -
03:20 AM Feature #20724 (Closed): Update to Unicode 16.0
- Unicode 16.0 has been released (see https://www.unicode.org/versions/Unicode16.0.0/). We should update to 16.0 after ...
09/11/2024
-
08:41 PM Bug #20720 (Closed): prism incorrectly marks SuperNode as forwarding in some cases
- Applied in changeset commit:git|5d358b660d41e64de301f428dc0300a52a6f9566.
----------
Fix issue with super and forwar... -
08:41 PM Revision 5d358b66 (git): Fix issue with super and forwarding arguments in prism_compile.c
- Fixes [Bug #20720]
-
07:17 PM Revision d4d6f1de (git): [ruby/prism] UTF-8 characters in file name
- https://github.com/ruby/prism/commit/487f0ffe78
-
07:03 PM Bug #20722: curious search result order on docs.ruby-lang.org
- You might have more luck reporting this at the RDoc repository:
https://github.com/ruby/rdoc -
05:07 AM Bug #20722 (Closed): curious search result order on docs.ruby-lang.org
- If you search for "String" on https://docs.ruby-lang.org/en/3.3/ the first four results returned are obscure:
1. G... -
06:14 PM Revision 12d7ead0 (git): [rubygems/rubygems] Small simplification in Definition class
- https://github.com/rubygems/rubygems/commit/03ddfd7610
Co-authored-by: Jonathan Hefner <[email protected]> -
06:14 PM Revision 364cc958 (git): [rubygems/rubygems] Uncomment and possibly fix spec on JRuby
- This was commented out almost 10 years ago, but I think it passes now!
https://github.com/rubygems/rubygems/commit/4... - 05:19 PM Revision efc77d53 (git): [ruby/psych] Ensure strings with only underscores are not processed as Integer
- A string similar to "0x____" should be treated as a string.
Currently it is processed as an Integer.
This alters the... -
05:15 PM Revision 818e2035 (git): [DOC] Tweaks for Array#each
-
05:14 PM Revision 18fb11aa (git): [DOC] Tweaks for Array#difference (#11593)
-
05:14 PM Revision c7faffd1 (git): [DOC] Tweaks for Array#drop_while
-
04:35 PM Revision 1be9a998 (git): [ruby/prism] Add a flag for arguments that contain forwarding
- https://github.com/ruby/prism/commit/ebd2889bee
-
03:39 PM Revision 886fc69b (git): [ruby/prism] Parse tempfile
- https://github.com/ruby/prism/commit/31154a389a
-
12:49 PM Revision 7facf232 (git): [DOC] Related for Array#compact
-
12:48 PM Revision 0906b162 (git): [DOC] Tweaks for Array#drop
-
12:47 PM Revision 309362d6 (git): [DOC] Tweaks for Array#dig
-
12:36 PM Revision c7e18621 (git): [DOC] Tweaks for Array#delete_at
-
12:33 PM Revision 3aeb9c75 (git): [DOC] Related for Array#delete_if
-
11:28 AM Revision e52d4d46 (git): [rubygems/rubygems] Fix `bundle exec rake install` failing when local gem has extensions and `gemspec` DSL is being used
- In a `bundle exec` context, the local specification will actually be
part of the known specifications, so RubyGems wi... -
11:28 AM Revision 89eba507 (git): [rubygems/rubygems] Only raise DSLError during Gemfile parsing when it's actually useful
- DSLError prints the specific line in a Gemfile where the error was
raised. That's helpful when the error was explicit... -
11:28 AM Revision 1d72b3bd (git): [rubygems/rubygems] Don't rescue Exception when evaluating Gemfile
- Things like OOM, or StackOverflow should be raised immediately.
https://github.com/rubygems/rubygems/commit/11691ce492 -
11:28 AM Revision f0b9baa2 (git): [rubygems/rubygems] Refactor setting current gemfile in DSL
- https://github.com/rubygems/rubygems/commit/b4ecb66224
-
11:28 AM Revision 1d768ebd (git): [rubygems/rubygems] The `dsl_path` parameter in DSLError is documented as a string
- https://github.com/rubygems/rubygems/commit/ab44fa9ee4
-
10:49 AM Bug #20723: `IO#close` is broken on Ruby 3.3+ when using the Fiber scheduler.
- I've added the following work-around: <https://github.com/socketry/io-stream/commit/7d1546fa829d3fe046f66f559d9a77449...
-
09:44 AM Bug #20723: `IO#close` is broken on Ruby 3.3+ when using the Fiber scheduler.
- It may be related to https://github.com/ruby/ruby/commit/66871c5a06d723f8350935ced1e88d8cc929d809
-
09:42 AM Bug #20723 (Closed): `IO#close` is broken on Ruby 3.3+ when using the Fiber scheduler.
- The following program seems to work okay on Ruby 3.2 but hangs on Ruby 3.3:
```ruby
#!/usr/bin/env ruby
requir... -
09:35 AM Feature #20594: A new String method to append bytes while preserving encoding
- I agree with @Dan0042, the new API should not have this error-prone behavior, it should raise if out of bounds instea...
-
09:20 AM Feature #20594: A new String method to append bytes while preserving encoding
- Dan0042 (Daniel DeLorme) wrote in #note-31:
> Ironically, HexaPDF now uses an explicit modulo 256, so it would actua... -
02:34 AM Feature #20594: A new String method to append bytes while preserving encoding
- Ironically, HexaPDF now uses an explicit modulo 256, so it would actually be fine if #setbyte raised an out-of-bound ...
-
01:54 AM Feature #20594: A new String method to append bytes while preserving encoding
- Dan0042 (Daniel DeLorme) wrote in #note-29:
> I understand the idea of keeping things consistent. But why does `setb... -
01:32 AM Feature #20594: A new String method to append bytes while preserving encoding
- I understand the idea of keeping things consistent. But why does `setbyte` have this behavior in the first place? A f...
-
09:13 AM Revision baac5376 (git): Use macos? helper
-
09:13 AM Revision 74c3259c (git): macOS 10.13(High Sierra) is already EOL
-
09:01 AM Revision 0b11e039 (git): Fix wrong NODE name
-
09:01 AM Revision d03e0d1c (git): Implement BREAK, NEXT and REDO NODE locations
-
05:13 AM Revision f7ffa763 (git): Clean up clean only extensions
- The clean targets should clean up all extensions, including those have
nothing to build for any reason, e.g., platfor... -
05:09 AM Revision cb576c13 (git): Fix duplicate dependency lines
- exts.mk should deal with cleanings of extensions, including bundled
gems. - 04:49 AM Revision 6c16598a (git): [ruby/pathname] use delete_prefix instead of sub in find method
- delete_prefix with a string is easier to read than a regular expression
also it should be faster. It is available sin... -
04:41 AM Revision c37b6677 (git): [rubygems/rubygems] Make an exe file executable when generating new gems
- Currently, an exe file isn't executable when generating new gems
because it doesn't have the correct permission.
This... -
12:44 AM Bug #20721 (Closed): Gem executables have a .lock file in Ruby 3.3.5
- With Ruby 3.3.5, every gem executable under `$prefix/bin` has a `.lock` file. This was [an unintended change](https:/...
-
12:38 AM Revision 55ddfd58 (git): Fixes [Bug #20718] (#11576)
- Fixes [Bug #20718]
Allow objects that are not of type `RTypedData` to use the default free function, as `RTYPEDDATA_... -
12:28 AM Revision 4e6091ce (git): Implement WHILE and UNTIL NODE locations
Also available in: Atom