libpng16 fails in make test on aarch64

Brought to you by: cosmin, glennrp

#286 libpng16 fails in make test on aarch64

Milestone: libpng_code

Status: open

Owner: nobody

Labels: None

Priority: 5

Updated: 2019-01-28

Created: 2019-01-14

Creator: Guillaume Gardet

Private: No

Failing tests are:
[ 125s] FAIL: tests/pngvalid-gamma-expand16-transform
[ 154s] FAIL: tests/pngvalid-transform

1 Attachments

pngvalid-gamma-expand16-transform.log.txt

Discussion

Guillaume Gardet - 2019-01-14

Add pngvalid-transform.log

pngvalid-transform.log.txt

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Petr Gajdos - 2019-01-28

There is

#ifdef PNG_READ_EXPANDED_SUPPORTED png_free(png_ptr, png_ptr->riffled_palette); png_ptr->riffled_palette = NULL; #endif

in pngwrite.c nevertheless I have two doubts:

why the free is in pngwrite.c; the png_ptr->riffled_palette structure is allocated in png_do_read_transformations() from pngrtran.c and called only from pngread.c

why PNG_READ_EXPANDED_SUPPORTED is used in the preprocessor condition; the structure is allocated only only if PNG_ARM_NEON_INTRINSICS_AVAILABLE is defined and this is iff PNG_ARM_NEON_IMPLEMENTATION == 1.

These two doubts resulted in
https://build.opensuse.org/package/view_file/graphics/libpng16/libpng-arm-free.patch?expand=1
and the build now succedes:
https://build.opensuse.org/package/show/graphics/libpng16

Please look at the patch more thoroughly.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Petr Gajdos - 2019-01-28

See for detailed analysis:
https://bugzilla.suse.com/show_bug.cgi?id=1121829

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.