Fix PR debug/33155: Don't add DW_AT_MIPS_linkage_name for C functions
Mark Mitchell
mark@codesourcery.com
Wed May 7 17:25:00 GMT 2008
Daniel Jacobowitz wrote:
> On Sun, Apr 27, 2008 at 10:26:47AM +1200, Danny Smith wrote:
>> The attached fixes GCC bug
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33155
>>
>> by preventing the addition of DW_AT_MIPS_linkage_name for C functions.
>> On MS Windows targets, the external assembler name of __stdcall functions are
>> mangled in C as well as C++ by the addition of an '@n' suffix.
>> GDB however does not appear to handle DW_AT_MIPS_linkage_name for C functions.
>>
>> Should this be addressed in gdb sources rather than in GCC?
>
> GDB's reliance on DW_AT_MIPS_linkage_name is somewhat dubious in
> general. The way GCC is using it sounds correct, or as close to that
> as you get for something with no written specification. I have
> patches to improve GDB's behavior but meanwhile I don't see any harm
> in this patch.
Has this patch been tested by running the GDB testsuite on a non-Windows
target? (For example, an embedded simulator target, or x86 GNU/Linux?)
If there are no regressions, then this is OK.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
More information about the Gdb
mailing list