Rename Runtime.exec to Runtime.run #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmacdo
added a commit
to asmacdo/molecule
that referenced
this pull request
May 1, 2023
asmacdo
added a commit
to asmacdo/molecule
that referenced
this pull request
May 8, 2023
asmacdo
added a commit
to asmacdo/molecule
that referenced
this pull request
May 8, 2023
asmacdo
added a commit
to asmacdo/molecule
that referenced
this pull request
May 8, 2023
4.0.2 dropped the use of `run`, needs to be replaced with `exec` Fixes ansible#3903 ansible/ansible-compat#256
openstack-mirroring
pushed a commit
to openstack/kayobe
that referenced
this pull request
May 10, 2023
Molecule job failed with an error: AttributeError: 'Runtime' object has no attribute 'exec' since 4.x ansible-compat were bring the breaking changes [1]. so we pin the 3.x version for molecule. 1. ansible/ansible-compat#256 Change-Id: I5f0b97fec565036fb48654113d356cc947e1bbb8 Signed-off-by: Maksim Malchuk <[email protected]>
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
May 10, 2023
* Update kayobe from branch 'master'
to 805414ef9d29deddd432fd3f591734a5f05da174
- CI: fix molecule job
Molecule job failed with an error:
AttributeError: 'Runtime' object has no attribute 'exec'
since 4.x ansible-compat were bring the breaking changes [1].
so we pin the 3.x version for molecule.
1. ansible/ansible-compat#256
Change-Id: I5f0b97fec565036fb48654113d356cc947e1bbb8
Signed-off-by: Maksim Malchuk <[email protected]>
asmacdo
added a commit
to asmacdo/molecule
that referenced
this pull request
May 16, 2023
4.0.2 dropped the use of `exec`, needs to be replaced with `run` Fixes ansible#3903 ansible/ansible-compat#256
zhan9san
pushed a commit
to ansible/molecule
that referenced
this pull request
Jun 7, 2023
* Use run, not exec, for ansible-compat 4.0.2 4.0.2 dropped the use of `exec`, needs to be replaced with `run` Fixes #3903 ansible/ansible-compat#256 * bump ansible-compat 4.1.2 ansible-compat 4.0.1 included a breaking change. If we want to use latest, minimum version must be at least 4.0.1. ansible-compat < 4.1.2 has an issue that causes an unhandled exception for certain log levels. ansible/ansible-lint#3522 Since this issue caused CI trouble, we go ahead and bump to 4.1.2. * fixup * [DATALAD RUNCMD] recompile requirements.lock.txt === Do not change lines below === { "chain": [], "cmd": "pip-compile --no-annotate --output-file=.config/requirements-lock.txt --resolver=backtracking --strip-extras --unsafe-package=ruamel-yaml-clib pyproject.toml", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^ * fix tests for command init role and init scenario Currently the tests fail for `test_command_init_role` and `test_command_init_scneario`. The tests execute `ansible-lint` on the newly-created roles and the linter recently got more restrictive, so we now have to adapt. * [DATALAD RUNCMD] recompile requirements.txt === Do not change lines below === { "chain": [], "cmd": "pip-compile --extra=docs --extra=test --no-annotate --output-file=.config/requirements.txt --resolver=backtracking --strip-extras pyproject.toml", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^ * Fake 3.9 for autogenerated files I used 3.10, but CI will run this on 3.9, and fail if there is a diff. This means it is safe to change this by hand, since it will be checked. --------- Co-authored-by: Daniel Ziegenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.