Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

feat: do not use legacy grpc loadObject#477

Merged
alexander-fenster merged 1 commit into
masterfrom
no-legacy-load
May 1, 2019
Merged

feat: do not use legacy grpc loadObject#477
alexander-fenster merged 1 commit into
masterfrom
no-legacy-load

Conversation

@alexander-fenster
Copy link
Copy Markdown
Contributor

Finally, loadPackageDefinition just works for both grpc versions we have.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 30, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2019

Codecov Report

Merging #477 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
+ Coverage   82.83%   82.95%   +0.12%     
==========================================
  Files          50       50              
  Lines        3198     3192       -6     
  Branches       82       81       -1     
==========================================
- Hits         2649     2648       -1     
+ Misses        536      532       -4     
+ Partials       13       12       -1
Impacted Files Coverage Δ
src/grpc.ts 88.88% <ø> (+4.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e7073...6c90473. Read the comment docs.

Copy link
Copy Markdown

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, deleting code is the best.

@alexander-fenster alexander-fenster merged commit 0ed2084 into master May 1, 2019
@alexander-fenster alexander-fenster deleted the no-legacy-load branch May 1, 2019 03:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants