xds: Squelch ADS reconnection error logs (1.45.x backport) #8942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for grpc#8886, as we wait on a real fix. The regular load balancing disconnections are confusing users and will train users to start ignoring gRPC warnings. At present, it is better to have no log than excessively log.
sergiitk
approved these changes
Feb 24, 2022
erikjoh
approved these changes
Feb 24, 2022
Contributor
erikjoh
left a comment
There was a problem hiding this comment.
Can also confirm that the warnings disappear after this change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #8886, as we wait on a real fix. The regular load
balancing disconnections are confusing users and will train users to
start ignoring gRPC warnings. At present, it is better to have no log
than excessively log.
CC @YifeiZhuang, @erikjoh
Backport of #8941