This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Conversation
Contributor
|
Thanks @jimmywarting. I'm happy to ship this if CI is happy. |
Contributor
|
Pretty sure these failures are expected. |
Contributor
Author
|
Not entierly sure what failed with |
nschonni
approved these changes
May 25, 2021
Contributor
nschonni
left a comment
There was a problem hiding this comment.
I think the Alpine thing is unrelated. Not sure but I remember it being flakey initially after the previous major, and the current one anyway
Contributor
|
Appreciate all your effort. This is released in 6.0.1. |
Contributor
Author
|
Np. Do you want me to make a PR that uses Node's new |
Contributor
|
Totally up to you. It's not something we plan to do but we're happy to look at a PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3003