Skip to content
This repository was archived by the owner on Nov 14, 2023. It is now read-only.

feat: move to typescript code generation#332

Merged
xiaozhenliu-gg5 merged 20 commits into
masterfrom
move_to_ts
Mar 6, 2020
Merged

feat: move to typescript code generation#332
xiaozhenliu-gg5 merged 20 commits into
masterfrom
move_to_ts

Conversation

@xiaozhenliu-gg5
Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 5, 2020
@xiaozhenliu-gg5
Copy link
Copy Markdown
Contributor Author

docs-test runs successfully locally, while fails in circleCI test, and it complains about the following links which can be clickable :(

[0] https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-automl&page=editor&open_in_editor=samples/delete_model.js,samples/README.md
[0] https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-automl&page=editor&open_in_editor=samples/get_dataset.js,samples/README.md
[0] https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-automl&page=editor&open_in_editor=samples/get_model_evaluation.js,samples/README.md
[0] https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-automl&page=editor&open_in_editor=samples/get_model.js,samples/README.md
[0] https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-automl&page=editor&open_in_editor=samples/get_operation_status.js,samples/README.md
[0] https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-automl&page=editor&open_in_editor=samples/export_dataset.js,samples/README.md
[0] https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-automl&page=editor&open_in_editor=samples/deploy_model.js,samples/README.md

@alexander-fenster
Copy link
Copy Markdown
Contributor

@JustinBeckwith This is weird, they do fail on Actions:

[0] https://googleapis.dev/nodejs/automl/latest
[0] https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/nodejs-automl&page=editor&open_in_editor=samples/deploy_model.js,samples/README.md

Would you be fine with ignoring those in synth.py and linkinator.json here and filing an issue for linkinator?

Comment thread linkinator.config.json Outdated
Comment thread linkinator.config.json Outdated
Comment thread package.json
Comment thread synth.py
Comment thread synth.py
@xiaozhenliu-gg5
Copy link
Copy Markdown
Contributor Author

xiaozhenliu-gg5 commented Mar 5, 2020

More links start to fail according to the test outcome:

[0] https://support.google.com/cloud/answer/6293499
[0] https://console.cloud.google.com/project
[0] https://console.cloud.google.com/flows/enableapi?apiid=automl.googleapis.com
[0] https://cloud.google.com/terms/launch-stages

but I reran the docs-test locally, no failure at all. Can I get some suggestion? @JustinBeckwith @alexander-fenster It looks wired for me.

Comment thread linkinator.config.json Outdated
@xiaozhenliu-gg5
Copy link
Copy Markdown
Contributor Author

Great news! seems 'concurrency: 10' solves the problem, thank you! Can we leave it there in linkinator.config.json? I will set it through synth.py, does it sound reasonable to you? @JustinBeckwith

@xiaozhenliu-gg5
Copy link
Copy Markdown
Contributor Author

Created an issue here: JustinBeckwith/linkinator#156 if we want to clean the synth.py someday, this is for reference. Thank you!

@JustinBeckwith
Copy link
Copy Markdown
Contributor

Awesome. Go ahead and use concurrency: 10 in the config. I am going to send a hammer PR to update this everywhere so we don't run into trouble.

@xiaozhenliu-gg5 xiaozhenliu-gg5 merged commit 17f0d7a into master Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants