This repository was archived by the owner on Jul 13, 2023. It is now read-only.
fix: do not modify options object, use defaultScopes#231
Merged
Conversation
Regenerated the library using gapic-generator-typescript v1.2.1.
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
========================================
Coverage 98.92% 98.92%
========================================
Files 5 5
Lines 5839 5975 +136
Branches 204 201 -3
========================================
+ Hits 5776 5911 +135
- Misses 62 63 +1
Partials 1 1
Continue to review full report at Codecov.
|
bcoe
approved these changes
Nov 6, 2020
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Dec 2, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.2](https://www.github.com/googleapis/nodejs-datalabeling/compare/v2.1.1...v2.1.2) (2020-11-25) ### Bug Fixes * **browser:** check for fetch on window ([#236](https://www.github.com/googleapis/nodejs-datalabeling/issues/236)) ([a861cd0](https://www.github.com/googleapis/nodejs-datalabeling/commit/a861cd0671cb04baf0f2b40f376fcb974e4c7159)) * do not modify options object, use defaultScopes ([#231](https://www.github.com/googleapis/nodejs-datalabeling/issues/231)) ([6bcb17b](https://www.github.com/googleapis/nodejs-datalabeling/commit/6bcb17b6cc40cbc2448e8722e8918324ae2261e4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated the library using
gapic-generator-typescript
v1.2.1.