This repository was archived by the owner on Jul 13, 2023. It is now read-only.
fix: update analyze.v1.js#306
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 2 2
Lines 7 7
=======================================
Hits 5 5
Misses 2 2Continue to review full report at Codecov.
|
leahecole
approved these changes
Oct 2, 2019
leahecole
left a comment
There was a problem hiding this comment.
LGTM as long as all of the checks are passing
|
@nnegrey One test failed - it did not like the commit message (haha). |
Contributor
Author
|
idk what its problem is or what a subject / type are. |
|
Both the commit message and the title of the PR need to be in conventional commits format - for you, it will be something like "fix: update analyze.v1.js" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: snippet