feat: adds the v1 API surface#134
Conversation
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 57.61% 58.62% +1.01%
==========================================
Files 2 2
Lines 13786 18841 +5055
Branches 1 1
==========================================
+ Hits 7943 11046 +3103
- Misses 5843 7795 +1952
Continue to review full report at Codecov.
|
JustinBeckwith
left a comment
There was a problem hiding this comment.
LGTM w/ nits. Do we know if v1 / v1beta1 has breaking changes in it?
| node: [8, 10, 12, 13] | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
Could I trouble you for a hammer PR on this one? We shouldn't be rename/merging this 80 times :)
There was a problem hiding this comment.
this PR has already gone out to all repositories, and is the one Alex is working on landing as we speak.
| // For compatibility with JavaScript libraries we need to provide this default export: | ||
| // tslint:disable-next-line no-default-export | ||
| export default {v1beta1, WebRiskServiceV1Beta1Client}; | ||
| export default {v1, v1beta1, WebRiskServiceV1Beta1Client}; |
There was a problem hiding this comment.
I don't understand what this line of code does. Do you have a good grip on why/if this is needed?
There was a problem hiding this comment.
This approach is necessary to ensure that the module has the same export signature as the JavaScript library did prior to the TypeScript conversion:
{
TextToSpeechClient: [Function: TextToSpeechClient],
v1beta1: { TextToSpeechClient: [Function: TextToSpeechClient] },
v1: [Circular],
default: {
TextToSpeechClient: [Function: TextToSpeechClient],
v1beta1: { TextToSpeechClient: [Function: TextToSpeechClient] },
v1: [Circular]
}
}|
the v1 and v1beta surfaces are identical, I learned talking with @bsurmanski. So I've updated samples accordingly. |
runs the generator with the v1 API surface.