From: jean.boussier@... Date: 2020-11-18T15:34:26+00:00 Subject: [ruby-core:100935] [Ruby master Feature#13381] [PATCH] Expose rb_fstring and its family to C extensions Issue #13381 has been updated by byroot (Jean Boussier). After trying to use the new functions in `json` and `messagepack` I realized we overlooked something entirely. The internal `rb_fstring_*` will build new strings with `str_new_static`, so will directly re-use the string pointer that was provided. That's pretty much unusable, and unsafe. I submitted another pull request to fix this: https://github.com/ruby/ruby/pull/3786 ---------------------------------------- Feature #13381: [PATCH] Expose rb_fstring and its family to C extensions https://bugs.ruby-lang.org/issues/13381#change-88589 * Author: eagletmt (Kohei Suzuki) * Status: Closed * Priority: Normal ---------------------------------------- https://github.com/ruby/ruby/pull/1559 Currently, C extensions cannot use fstrings. I'd like to use `rb_fstring_cstr` instead of `rb_str_new_cstr` for static strings in C extensions to avoid excess allocation. I think there's several use cases. - https://github.com/k0kubun/hamlit/blob/v2.8.0/ext/hamlit/hamlit.c#L508-L512 - https://bitbucket.org/ged/ruby-pg/src/e5eb92cca97abc0c6fc168acfad993c2ad314589/ext/pg_connection.c?at=v0.20.0&fileviewer=file-view-default#pg_connection.c-3679 - https://bitbucket.org/ged/ruby-pg/src/e5eb92cca97abc0c6fc168acfad993c2ad314589/ext/pg_copy_coder.c?at=v0.20.0&fileviewer=file-view-default#pg_copy_coder.c-38 -- https://bugs.ruby-lang.org/ Unsubscribe: