From: "byroot (Jean Boussier) via ruby-core" <ruby-core@...>
Date: 2022-12-19T17:14:25+00:00
Subject: [ruby-core:111337] [Ruby master Bug#19150] pack/unpack silently ignores unknown directives

Issue #19150 has been updated by byroot (Jean Boussier).

Status changed from Closed to Open

Reopening so we remember to make it raise in 3.3

----------------------------------------
Bug #19150: pack/unpack silently ignores unknown directives
https://bugs.ruby-lang.org/issues/19150#change-100711

* Author: Eregon (Benoit Daloze)
* Status: Open
* Priority: Normal
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
----------------------------------------
But I believe it should be an error instead.
Typically when a parser sees a syntax error it should fail not continue silently.

For instance `[1].pack('<L')` succeeds and only emits a warning if `$VERBOSE` is true.
This behavior caused confusion in https://github.com/oracle/truffleruby/issues/2791

I think it should fail with an `ArgumentError` instead.

Extracted from https://bugs.ruby-lang.org/issues/19108#note-3



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/