From: "jeremyevans0 (Jeremy Evans) via ruby-core" <ruby-core@...>
Date: 2023-01-17T21:37:40+00:00
Subject: [ruby-core:111864] [Ruby master Bug#11230] Should rb_struct_s_members() be public API?

Issue #11230 has been updated by jeremyevans0 (Jeremy Evans).


I submitted a pull request to remove the prototype from the public header files: https://github.com/ruby/ruby/pull/7141

`rb_struct_s_members` is still an exported symbol as it is used internally by `marshal.c`.

One of reasons stated to remove this method is that it returns a hidden Array.  However, `rb_struct_members` appears to return the same hidden Array (that method is also used internally by `marshal.c`).  Should we consider removing `rb_struct_members` from the public API as well?

----------------------------------------
Bug #11230: Should rb_struct_s_members() be public API?
https://bugs.ruby-lang.org/issues/11230#change-101278

* Author: Eregon (Benoit Daloze)
* Status: Open
* Priority: Normal
* ruby -v: ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
rb_struct_s_members() is declared in include/ruby/intern.h.

However it seems this is a fairly internal API as it returns an hidden Array.

For instance, there was a try to specify the behavior in
https://github.com/rubinius/rubinius/commit/2642a30c57973987d2a7b7e85b3ce1e78100a31b
but that produces only erratic behavior on MRI because that usage is not intended.

A valid usage might be:

    static VALUE get_struct_member(VALUE self, VALUE obj, VALUE i) {
        return RARRAY_AREF(rb_struct_s_members(obj), NUM2INT(i));
    }

    p get_struct_member(Struct.new(:a, :bb), 1)
    

But do we need such access and is it worth exposing a potentially dangerous function like this?



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/