From: "ferrous26 (Mark Rada)" <markrada26@...>
Date: 2012-03-29T05:22:40+09:00
Subject: [ruby-core:43812] [ruby-trunk - Bug #6203] Array#values_at does not handle ranges with end index past the end of the array


Issue #6203 has been updated by ferrous26 (Mark Rada).


marcandre (Marc-Andre Lafortune) wrote:
> The patch from Mark Rada never made it through, but I concur that the problem is in rb_range_beg_len.

Hello Marc,

Sorry for not linking to the pull request here, though I did open a pull request on Github here: https://github.com/ruby/ruby/pull/109

Though I think your solution is much nicer. Perhaps the tests I added are still useful.

----------------------------------------
Bug #6203: Array#values_at does not handle ranges with end index past the end of the array
https://bugs.ruby-lang.org/issues/6203#change-25318

Author: ferrous26 (Mark Rada)
Status: Open
Priority: Normal
Assignee: marcandre (Marc-Andre Lafortune)
Category: core
Target version: 2.0.0
ruby -v: trunk


=begin
When I use Array#values_at I expect that it would be the same as successive calls to (({Array#[]})).

There is one case where this does not hold:

    a = [0,1,2,3,4,5]
    a[4..6] # => [4, 5]
    a.values_at(4..6) # => [4,5,nil]

I think this is an inconsistency in the design of (({Array#values_at})). We can look at a more extreme case:

    a[4..100] # => [4, 5]
    a.values_at 4..100 # => [4, 5, nil]

And now it doesn't make any sense.

I think the best solution would be to make (({Array#values_at})) be equivalent to successive calls to (({Array#[]})). I have patched (({rb_range_beg_len()})) to handle the extra case and opened a pull request on github.
=end


-- 
http://bugs.ruby-lang.org/