From: "vo.x (Vit Ondruch)" <v.ondruch@...>
Date: 2012-12-19T22:07:07+09:00
Subject: [ruby-core:50984] [ruby-trunk - Bug #7586] Useless sourceline in DTrace parse__begin and parse__end probes


Issue #7586 has been updated by vo.x (Vit Ondruch).


kosaki (Motohiro KOSAKI) wrote:
> I think we don't pass 1 when no line information. 0 or -1 is better. and need to be documented when such special line number is happen.

May be it could be worth of own issue?
----------------------------------------
Bug #7586: Useless sourceline in DTrace parse__begin and parse__end probes
https://bugs.ruby-lang.org/issues/7586#change-34862

Author: vo.x (Vit Ondruch)
Status: Closed
Priority: Normal
Assignee: tenderlovemaking (Aaron Patterson)
Category: 
Target version: 
ruby -v: ruby 2.0.0dev (2012-12-17 trunk 38422) [x86_64-linux]


I am not 100% sure, but isn't the 'parser->parser_ruby_sourceline' at https://github.com/ruby/ruby/blob/trunk/parse.y#L5322 always '1'? Does it make sense to pass this information to DTrace  parse__begin(const char *, int) and parse__end(const char *, int) probes?


-- 
http://bugs.ruby-lang.org/