From: "jsc (Justin Collins)" <redmine@...>
Date: 2013-11-24T12:42:25+09:00
Subject: [ruby-core:58545] [ruby-trunk - Feature #9145][Open]	Queue#pop(true) return nil if empty instead of raising ThreadError


Issue #9145 has been reported by jsc (Justin Collins).

----------------------------------------
Feature #9145: Queue#pop(true) return nil if empty instead of raising ThreadError
https://bugs.ruby-lang.org/issues/9145

Author: jsc (Justin Collins)
Status: Open
Priority: Normal
Assignee: 
Category: lib
Target version: 


I propose the non-blocking form of Queue#pop behave like Array#pop and return nil when empty.

Current behavior is to raise a ThreadError, with a message indicating the queue is empty.

For example:

q = Queue.new
begin
  loop do
    next_item = q.pop(true)
  end
rescue ThreadError
  # queue is empty...or maybe something bad happened
end

Instead, this could be

q = Queue.new
while next_item = q.pop(true)
end

Alternatively, raise an exception that is a subclass of ThreadError with a more specific name, such as "QueueEmpty". This would be a small improvement while remaining compatible with existing code.


-- 
http://bugs.ruby-lang.org/