From: shugo@...
Date: 2015-03-05T02:52:54+00:00
Subject: [ruby-core:68419] [Ruby trunk - Bug #10818] Extrange behaviour when apliying a refinement inside eval

Issue #10818 has been updated by Shugo Maeda.

Assignee changed from Yukihiro Matsumoto to Shugo Maeda

Shugo Maeda wrote:
> I'd like to hear Matz's opinion.

I talked with Matz, and he said that a binding should keep refinements activation
information and the refinements should be activated in subsequent eval calls with
the binding.

So I'll change the behavior of eval as follows:

```ruby
module M
  refine String do
    def foobar; puts 'foobar'; end
  end
end

some_binding = class A; binding; end

str1 = <<EOF
using M
'str'.foobar
EOF

str2 = <<EOF
'str'.foobar
EOF

eval str1, some_binding # foobar
eval str2, some_binding # foobar (No exception is raised)
```


----------------------------------------
Bug #10818: Extrange behaviour when apliying a refinement inside eval
https://bugs.ruby-lang.org/issues/10818#change-51764

* Author: Pablo Herrero
* Status: Assigned
* Priority: Normal
* Assignee: Shugo Maeda
* ruby -v: ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
When you activate a refinement inside an a string using `eval` with a binding, the refinement is sill active the next time you call `eval` with the same binding.
Strangely enough, this will only happen if there is an assignment at the code evaluated the first time. If you delete the assignment everything works as expected.

```ruby
module M
  refine String do
    def foobar; puts 'foobar'; end
  end
end

some_binding = class A; binding; end


str1 = <<EOF
a = 'something' # Without this everything works as expected
using M
'str'.foobar # Works fine
EOF

str2 = <<EOF
'str'.foobar # This time should fail but it doesn't
EOF

eval str1, some_binding
eval str2, some_binding
```

Acording to the [RefinmentsSpec](https://bugs.ruby-lang.org/projects/ruby-trunk/wiki/RefinementsSpec): "when main.using is invoked in a string given as the first argument of Kernel#eval, Kernel#instance_eval, or Module#module_eval, the end of the scope is the end of the string."

Which contradicts with this code's behavior.



-- 
https://bugs.ruby-lang.org/