From: Eric Wong Date: 2015-11-12T09:53:52+00:00 Subject: [ruby-core:71462] Re: [Ruby trunk - Feature #11339] [PATCH] io.c: avoid kwarg parsing in C API Eric Wong wrote: > matz@ruby-lang.org wrote: > > I am OK with the change. I don't really like something like > > __read_nonblock, but acceptable. > > OK, committed as r52541 for now. I don't have a better idea > for hiding other than private + "__" prefix... > > Will followup with other IO/Socket/SSL methods Work-in-progress for rsock_s_recvfrom_nonblock-based methods. Likely to commit tomorrow... Minor nit, this may reduce startup performance slightly more than prelude.rb changes because the RDoc comment stays in socket.rb instead of getting dropped at compile time: http://80x24.org/spew/20151112-avoid-arg-parsing-in-rsock_s_recvfrom_nonblock@1/raw I also noticed I forgot to update some RDoc for r50912; will adjust in a separate commit.