From: eregontp@... Date: 2017-05-27T09:33:37+00:00 Subject: [ruby-core:81415] [Ruby trunk Bug#13591] spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ'] Issue #13591 has been updated by Eregon (Benoit Daloze). Assignee set to Eregon (Benoit Daloze) FWIW the patch looks OK to me, I think we should merge it. This might be a difference between the different configuration of Windows builds. Testing for invalid timezones is rather difficult, some platforms behave differently, and this test had to be refined a couple times to work on all Linux CIs. MSP-Greg (Greg L) wrote: > I'll have a look at your code, see if I can determine whats going on. Believe me, I did a couple of builds, and it kept failing... Could you just post a failing stacktrace here when running the test in isolation? You can do so with $ make test-rubyspec MSPECOPT="-e bad spec/rubyspec/core/time/zone_spec.rb" or $ spec/mspec/bin/mspec -e bad spec/rubyspec/core/time/zone_spec.rb if the built ruby is on $PATH. ---------------------------------------- Bug #13591: spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ'] https://bugs.ruby-lang.org/issues/13591#change-65127 * Author: MSP-Greg (Greg L) * Status: Rejected * Priority: Normal * Assignee: Eregon (Benoit Daloze) * Target version: * ruby -v: ruby 2.5.0dev (2017-05-27 trunk 58911) [x64-mswin64_140] * Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN ---------------------------------------- Windows does not support ENV['TZ'], so it should be removed from rspec tests. See [GitHub PR 1627](https://github.com/ruby/ruby/pull/1627) -- https://bugs.ruby-lang.org/ Unsubscribe: