From: kou@... Date: 2018-04-22T09:43:03+00:00 Subject: [ruby-core:86650] [Ruby trunk Bug#14600] test-all & REXML - fixup Issue #14600 has been updated by kou (Kouhei Sutou). I've enabled almost tests. The tests reveals some XPath related bugs. They are good tests. I've fixed most of the XPath related bugs. Namespace axis related XPath isn't fixed yet. I'll work on it later. ---------------------------------------- Bug #14600: test-all & REXML - fixup https://bugs.ruby-lang.org/issues/14600#change-71607 * Author: MSP-Greg (Greg L) * Status: Closed * Priority: Normal * Assignee: kou (Kouhei Sutou) * Target version: * ruby -v: ruby 2.6.0dev (2018-03-13 trunk 62739) [x64-mingw32] * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN ---------------------------------------- First of all, thanks to @nobu for 62738, a quick look shows that the variance in test count for both Travis & Appveyor is much smaller (or non-existent) than before. Anyway, the main test patch that is still in Ruby-loco is a patch for REXML. A link to the file is https://github.com/MSP-Greg/ruby-loco/blob/master/patches/test-rexml.patch, I've attached also. I did the patch quite a while ago, so it's not quite 'front and center' in my mind. I was active in XML back when it was still being standardized and all the parsers were "don't try this at home". As I recall, the tests and their expectations are embedded in xml docs, idea being that any platform can run them. Something wasn't quite finished, which is why there's a increase in assertions of 215 after the patch is applied. ``` 428 tests, 2650 assertions, 0 failures, 0 errors, 0 skips - Test results before patch 417 tests, 2865 assertions, 0 failures, 0 errors, 0 skips - Test results after ``` Thanks again, Greg ---Files-------------------------------- test-rexml.patch (25.2 KB) rexml_test.txt (23.2 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: