From: nobu@... Date: 2018-11-15T12:44:40+00:00 Subject: [ruby-core:89817] [Ruby trunk Misc#15305] [PATCH] include/ruby/ruby.h (RB_ALLOCV*): remove GC guard Issue #15305 has been updated by nobu (Nobuyoshi Nakada). LGTM. It might be a result by trial&error. ---------------------------------------- Misc #15305: [PATCH] include/ruby/ruby.h (RB_ALLOCV*): remove GC guard https://bugs.ruby-lang.org/issues/15305#change-74878 * Author: normalperson (Eric Wong) * Status: Open * Priority: Normal * Assignee: nobu (Nobuyoshi Nakada) ---------------------------------------- include/ruby/ruby.h (RB_ALLOCV*): remove unnecessary GC guard At least I'm not seeing how it's necessary, as it defeats optimization at allocation time (instead of protecting the VALUE from being GC-ed) Anyways, there's a measurable size reduction: text data bss dec hex filename 3535061 21232 72944 3629237 3760b5 ruby.before 3534141 21232 72944 3628317 375d1d ruby.after I also don't get the point of using atomics in rb_free_tmp_buffer; but that's a separate issue... ---Files-------------------------------- 0001-include-ruby-ruby.h-RB_ALLOCV-remove-unnecessary-GC-.patch (1.24 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: