From: shevegen@... Date: 2019-11-14T16:14:45+00:00 Subject: [ruby-core:95850] [Ruby master Feature#13083] Regexp#{match, match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0 Issue #13083 has been updated by shevegen (Robert A. Heiler). Dan0042 wrote: > Is there a benefit to the change apart from consistency? A concrete benefit I mean. This is only one point of view. Sometimes there are "wrong" use cases or use cases that were not anticipated by the core team. In my opinion, whenever possible, it is best to encourage consistency and clarity, as close as possible to matz' original design consideration (because I think that this way people will not be confused as much; remember the confusion from people thinking that there is a singular "principle of least surprise", but then everyone using their own definition for that - that can not work). To the suggestion itself: I have no particular pro or con opinion either way. None of the code that I use would be affected by the change, should it come. Ruby 3.0 is not so far away so there may be lots of changes coming to ruby past 3.0 anyway. :) ---------------------------------------- Feature #13083: Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0 https://bugs.ruby-lang.org/issues/13083#change-82684 * Author: kachick (Kenichi Kamiya) * Status: Open * Priority: Normal * Assignee: * Target version: 2.7 ---------------------------------------- Just for consistency * patch: https://github.com/ruby/ruby/pull/1506 * spec: https://github.com/ruby/spec/pull/380 Currently behaves as ( ruby --version: ruby 2.5.0dev (2016-12-28 trunk 57228) [x86_64-darwin16] ) ~~~ ruby 'string'.__send__(:=~, nil) #=> nil 'string'.match(nil) #=> TypeError: wrong argument type nil (expected Regexp) 'string'.match?(nil) #=> TypeError: wrong argument type nil (expected Regexp) :symbol.__send__(:=~, nil) #=> nil :symbol.match(nil) #=> TypeError: wrong argument type nil (expected Regexp) :symbol.match?(nil) #=> TypeError: wrong argument type nil (expected Regexp) /regex/.__send__(:=~, nil) #=> nil /regex/.match(nil) #=> nil /regex/.match?(nil) #=> false ~~~ Expected to ~~~ruby 'string'.__send__(:=~, nil) #=> nil 'string'.match(nil) #=> nil 'string'.match?(nil) #=> false :symbol.__send__(:=~, nil) #=> nil :symbol.match(nil) #=> nil :symbol.match?(nil) #=> false /regex/.__send__(:=~, nil) #=> nil /regex/.match(nil) #=> nil /regex/.match?(nil) #=> false ~~~ -- https://bugs.ruby-lang.org/ Unsubscribe: