From: kamipo@... Date: 2020-04-07T01:16:07+00:00 Subject: [ruby-core:97737] [Ruby master Bug#16669] Rails Action Text unit tests fail since b9007b6c548f91e88fd3f2ffa23de740431fa969 Issue #16669 has been updated by kamipo (Ryuta Kamizono). https://bugs.ruby-lang.org/projects/ruby-master/repository/git/revisions/2943ff9d4441485a18773aa745bab7f47767dde2 fixes some of failures in Rails CI, but "undefined method `root' for Rails:Module" still exist I explained above. https://buildkite.com/rails/rails/builds/68064#d28cc26f-cdc1-4eb7-8795-41c9a2dc6f04/6-31 https://github.com/rails/rails/blob/834f5414c3b879a3a50c5cac128c9d9b007fa569/actionview/lib/action_view/template.rb#L194 ---------------------------------------- Bug #16669: Rails Action Text unit tests fail since b9007b6c548f91e88fd3f2ffa23de740431fa969 https://bugs.ruby-lang.org/issues/16669#change-84946 * Author: yahonda (Yasuo Honda) * Status: Closed * Priority: Normal * Assignee: ko1 (Koichi Sasada) * ruby -v: ruby 2.8.0dev (2020-02-22T00:58:59Z master b9007b6c54) [x86_64-darwin19] * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- This issue has been reported at Rails repository https://github.com/rails/rails/issues/38613 It always reproduces since https://github.com/ruby/ruby/commit/b9007b6c548f91e88fd3f2ffa23de740431fa969 but I do not know how to create minimum test cases without Rails repository yet. * Steps to reproduce > 1. Install `ruby 2.8.0dev` b9007b6c54 or newer > 2. Install required OS packages to run Rails refer https://guides.rubyonrails.org/development_dependencies_install.html#install-additional-tools-and-services > 3. git clone https://github.com/rails/rails.git > 4. cd rails/actiontext > 5. bundle install > 6. bin/test "test/template/form_helper_test.rb" "test/unit/model_test.rb" -n "/^(?:ActionText::ModelTest#(?:test_embed_extraction|test_embed_extraction_only_extracts_file_attachments))$/" * Expected result: All of tests should pass as they pass with f2286925f08406bc857f7b03ad6779a5d61443ae or older version of `ruby 2.8.0dev`, Ruby 2.7.0 or older versions of Ruby. * Actial behavior: These tests always fail as below. ```ruby % cd rails/actiontext % bin/test "test/template/form_helper_test.rb" "test/unit/model_test.rb" -n "/^(?:ActionText::ModelTest#(?:test_embed_extraction|test_embed_extraction_only_extracts_file_attachments))$/" /Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#taint is deprecated and will be removed in Ruby 3.2 /Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#tainted? is deprecated and will be removed in Ruby 3.2 /Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#taint is deprecated and will be removed in Ruby 3.2 /Users/yahonda/.rbenv/versions/2.8.0-dev/lib/ruby/gems/2.8.0/gems/tzinfo-1.2.6/lib/tzinfo/ruby_core_support.rb:163: warning: Object#tainted? is deprecated and will be removed in Ruby 3.2 Run options: -n "/^(?:ActionText::ModelTest#(?:test_embed_extraction|test_embed_extraction_only_extracts_file_attachments))$/" --seed 25661 # Running: E Error: ActionText::ModelTest#test_embed_extraction_only_extracts_file_attachments: NoMethodError: undefined method `runnables' for ActiveJob::Base:Class bin/test /Users/yahonda/Desktop/rails/actiontext/test/unit/model_test.rb:38 E Error: ActionText::ModelTest#test_embed_extraction: NoMethodError: undefined method `runnables' for ActiveStorage::BaseJob:Class bin/test /Users/yahonda/Desktop/rails/actiontext/test/unit/model_test.rb:32 Finished in 0.191237s, 10.4582 runs/s, 0.0000 assertions/s. 2 runs, 0 assertions, 0 failures, 2 errors, 0 skips % ``` -- https://bugs.ruby-lang.org/ Unsubscribe: