From: Greg.mpls@... Date: 2020-04-10T13:41:31+00:00 Subject: [ruby-core:97799] [Ruby master Bug#16770] Commit: RUBY3_HAS_BUILTIN: fix for nonexistent builtin - large increase in MinGW & mswin compile times Issue #16770 has been updated by MSP-Greg (Greg L). @Eregon I apologize for the possible confusion. When I opened the issue, I woke up, and all three builds (Actions - mingw & mswin, AppVeyor - mingw) took much longer for both build & test. I mentioned the CI logs that showed when it occurred, but CI isn't done on every commit. I should have made clear that I didn't bisect the issue, I just determined a good/bad range of commits. Regardless, as of 2020-04-10 master 878e21c6cd, all three builds have returned to normal build & test times. @shyouhei Thank you. I may be a little sensitive about master, as I try to encourage external repos/gems to test with it. Doing so allows them to know that it's very likely their code will work with new Ruby releases. It also provides a good feedback loop of info for ruby/ruby. Ok to close. ---------------------------------------- Bug #16770: Commit: RUBY3_HAS_BUILTIN: fix for nonexistent builtin - large increase in MinGW & mswin compile times https://bugs.ruby-lang.org/issues/16770#change-85016 * Author: MSP-Greg (Greg L) * Status: Open * Priority: Normal * Assignee: shyouhei (Shyouhei Urabe) * ruby -v: ruby 2.8.0dev (2020-04-08T04:28:13Z master 9e6e39c351) [x64-mingw32] * Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN ---------------------------------------- Inspecting logs both here and in ruby-loco, the following commit greatly increased compile time in MinGW builds: https://github.com/ruby/ruby/commit/6163a4e1b33ed7df27d0c37e835ce04407857a16 In ruby-loco, the make/compile time jumped from 9:23 to 34:43. Here: ``` after 32:22 - https://github.com/ruby/ruby/runs/569706642 before 11:11 - https://github.com/ruby/ruby/runs/569624968 [win32] Moved `MSC_VER` to verconf.mk... -- https://bugs.ruby-lang.org/ Unsubscribe: