Failed to instantiate [org.dromara.dynamictp.core.executor.DtpExecutor] Constructor threw exception

一、问题描述

今天开发好的功能上到测试环境测试，服务启动后报错，开发环境启动正常，报错如下：

org.springframework.beans.factory.BeanCreationException: Error creating bean with name ‘itemNoticeExecutor’: Failed to instantiate [org.dromara.dynamictp.core.executor.DtpExecutor]: Constructor threw exception
at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:318)
at org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:306)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:1375)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1212)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:562)
at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:522)
at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:337)
at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:335)
at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:200)
at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:975)
at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:971)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:625)
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebSe
rverApplicationContext.java:146)
at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:754)
at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:456)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:335)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1363)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1352)
at ■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at org.springframework.boot.loader.launch.Launcher.launch(Launcher.java:102)
at org.springframework.boot.loader.launch.Launcher.launch(Launcher.java:64)
at org.springframework.boot.loader.launch.JarLauncher.main(JarLauncher.java:40)
Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.dromara.dynamictp.core.executor.DtpExecutor]: Constructor threw exception
at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:221)
at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:117)
at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:315)
… 24 common frames omitted
Caused by: java.lang.IllegalArgumentException: null
at java.base/java.util.concurrent.ThreadPoolExecutor.(ThreadPoolExecutor.java:1311)
at org.dromara.dynamictp.core.executor.DtpExecutor.(DtpExecutor.java:178)
at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:208)
… 26 common frames omitted

二、问题排查

首先根据报错可以知道是dynamic-tp动态线程池相关的报错，这次开发也确实用到了动态线程池，配置如下：

再结合报错日志中ThreadPoolExecutor.java类的第1311行

通过抛这个异常的if条件，可知大概率是满足了 maximumPoolSize < corePoolSize 这个条件，导致抛了异常，由于配置中未配置 maximumPoolSize，所以 maximumPoolSize 取的默认值

在dynamic-tp的配置类 TpExecutorProps 中可以找到如下代码

再到常量类 DynamicTpConst 中找到如下代码：

最后可以知道取值为 Runtime.getRuntime().availableProcessors()

这是获取java虚拟机的可用处理器数，而开发机器这个值是16

测试环境k8s只分配了1核，所以这个值是1

三、解决问题

所以原因就是 corePoolSize 配的太大了，超过了maximumPoolSize，把测试环境核心线程池大小 core-pool-size 改为1，可以正常启动了

四，后续

吐槽：为什么报错不直接告诉我原因是 corePoolSize 比 maximumPoolSize 大啊