Closed Bug 1977078 Opened 4 months ago Closed 4 months ago

Translations are broken without the Gecko Profiler (When Firefox is built with `--disable-gecko-profiler`)

Categories

(Firefox :: Translations, defect, P5)

All
Android
defect

Tracking

()

RESOLVED FIXED
142 Branch
Tracking Status
firefox142 --- fixed

People

(Reporter: celenity, Assigned: celenity)

Details

Attachments

(1 file)

Steps to reproduce

  1. Build Firefox without the Gecko Profiler (using --disable-gecko-profiler).
  2. Attempt to use Firefox Translations (I used this article for testing: Spanish -> English).
  3. Translating will always fail, with the browser console throwing:
TypeError: can't access property "IsActive", Services.profiler is undefined
    #scheduleMoreTranslationRequests chrome://global/content/translations/translations-document.sys.mjs:5460
translations-document.sys.mjs:5419:24
    maybeScheduleMoreTranslationRequests chrome://global/content/translations/translations-document.sys.mjs:5419

Any additional information?

I filed this under Android, since that's where we (IronFox) are encountering this; but I imagine this might also impact other platforms.

Thanks for filing a bug! I'm redirecting this to Desktop, where the platform folks triage.

The error originating from toolkit makes me think that this is more related to the platform. (Could also just be we need a guard against Android or have a branch for that call. I'm not familiar enough with the profiler to say definitively, however.)

Product: Firefox for Android → Firefox

Since this isn't a configuration in the official Firefox builds, I'd accept a patch to fix this with Services.profiler?.IsActive(), but it looks like this kind of thing will be hit across the codebase quite a bit:

https://searchfox.org/mozilla-central/search?q=Services.profiler&path=&case=false&regexp=false

Severity: -- → S4
Priority: -- → P5

Fair enough, I'll see if I can submit a patch.

We haven't yet had any other issues reported by users due to the Profiler missing, but I'll do some testing and investigation with the other instances that you linked above, thanks for mentioning that.

Assignee: nobody → celenity
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch

Thanks for submitting a patch celenity!

QA Whiteboard: [qa-triage-done-c143/b142]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: