Translations are broken without the Gecko Profiler (When Firefox is built with `--disable-gecko-profiler`)
Categories
(Firefox :: Translations, defect, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox142 | --- | fixed |
People
(Reporter: celenity, Assigned: celenity)
Details
Attachments
(1 file)
Steps to reproduce
- Build Firefox without the Gecko Profiler (using
--disable-gecko-profiler). - Attempt to use Firefox Translations (I used this article for testing: Spanish -> English).
- Translating will always fail, with the browser console throwing:
TypeError: can't access property "IsActive", Services.profiler is undefined
#scheduleMoreTranslationRequests chrome://global/content/translations/translations-document.sys.mjs:5460
translations-document.sys.mjs:5419:24
maybeScheduleMoreTranslationRequests chrome://global/content/translations/translations-document.sys.mjs:5419
Any additional information?
I filed this under Android, since that's where we (IronFox) are encountering this; but I imagine this might also impact other platforms.
Comment 1•4 months ago
|
||
Thanks for filing a bug! I'm redirecting this to Desktop, where the platform folks triage.
The error originating from toolkit makes me think that this is more related to the platform. (Could also just be we need a guard against Android or have a branch for that call. I'm not familiar enough with the profiler to say definitively, however.)
Comment 2•4 months ago
|
||
Since this isn't a configuration in the official Firefox builds, I'd accept a patch to fix this with Services.profiler?.IsActive(), but it looks like this kind of thing will be hit across the codebase quite a bit:
| Assignee | ||
Comment 3•4 months ago
|
||
Fair enough, I'll see if I can submit a patch.
We haven't yet had any other issues reported by users due to the Profiler missing, but I'll do some testing and investigation with the other instances that you linked above, thanks for mentioning that.
| Assignee | ||
Comment 4•4 months ago
|
||
Updated•4 months ago
|
Comment 6•4 months ago
|
||
| bugherder | ||
Updated•4 months ago
|
Description
•