Publish DEPS for Chromium 41.0.2252.2

• .DEPS.git[Added - diff]
• DEPS[diff]

Incrementing VERSION to 41.0.2252.2

Cr-Commit-Position: refs/branch-heads/2252@{#2}
Cr-Branched-From: 8074902d32c9f36d3be05610229f4041d1bc5b80-refs/heads/master@{#308772}

• chrome/VERSION[diff]

Incrementing VERSION to 41.0.2252.1

Cr-Commit-Position: refs/branch-heads/2252@{#1}
Cr-Branched-From: 8074902d32c9f36d3be05610229f4041d1bc5b80-refs/heads/master@{#308772}

• chrome/VERSION[diff]

Allows OnAppTerminating at AshTestBase::TearDown().

Adding OnAppTerminating causes some failures. This CL also includes
the fixes for them.

OverlayEventFilterTest.CancelAtActivating:
- OverlayEventFilter::Cancel() is called, but that does not cleanup
  |delegate_|, therefore further OnAppTerminating() invokes Cancel()
  to already canceled delegate_.

PartialScreenshotViewTest.DontStartOverOverlay:
- delegate should be deactivated before it's removed.

RootWindowControllerTest.DontDeleteWindowsNotOwnedByParent:
- this test case explicitly invokes CloseAllChildWindows(), therefore
  it cleans up all of the containers.
- SessionStateAnimatorImpl assumed containers still exist when
  OnAppTerminating() is invoked.

WindowManagerTest.TestCursorClientObserver:
- observer_a is added to cursor_manager, but not destructed without
  calling RemoveObserver().

BUG=None
[email protected]
TEST=ash_unittests

Review URL: https://codereview.chromium.org/809603008

Cr-Commit-Position: refs/heads/master@{#308772}

• ash/test/ash_test_base.cc[diff]
• ash/wm/overlay_event_filter.cc[diff]
• ash/wm/partial_screenshot_view_unittest.cc[diff]
• ash/wm/session_state_animator_impl.cc[diff]
• ash/wm/window_manager_unittest.cc[diff]

Credential Manager: Pipe federated credentials through to UI layer.

This patch adjusts the credential manager dispatcher's filters for responses
to 'request()' which attempt to grab federated credentials, and lays the
groundwork for doing something useful with them in the UI layer.

Currently that groundwork just consists of piping the values around and
ensuring that nothing explodes. Future CLs will adjust the UI to ensure
that users can make a meaningful choice.

BUG=400674
[email protected],[email protected]

Review URL: https://codereview.chromium.org/809693002

Cr-Commit-Position: refs/heads/master@{#308771}

• chrome/browser/password_manager/chrome_password_manager_client.cc[diff]
• chrome/browser/password_manager/chrome_password_manager_client.h[diff]
• chrome/browser/ui/passwords/manage_passwords_ui_controller.cc[diff]
• chrome/browser/ui/passwords/manage_passwords_ui_controller.h[diff]
• chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc[diff]
• components/password_manager/content/browser/content_credential_manager_dispatcher.cc[diff]
• components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc[diff]
• components/password_manager/core/browser/password_manager_client.h[diff]
• components/password_manager/core/browser/stub_password_manager_client.cc[diff]
• components/password_manager/core/browser/stub_password_manager_client.h[diff]

Fixed StyledLabel size caching

StyledLabel size caching was not really working due to width check
did not take control insets into account. So any call to
GetHeightForWidth or Layout caused full layout recalculation.
When view with StyledLabel is created CalculateAndDoLayout that
does all layouting job is called for five or six times with same
arguments. And each call caused StyledLabel reset and controls removal

[email protected]

Review URL: https://codereview.chromium.org/734923003

Cr-Commit-Position: refs/heads/master@{#308770}

• ui/views/controls/styled_label.cc[diff]
• ui/views/controls/styled_label.h[diff]
• ui/views/controls/styled_label_unittest.cc[diff]

Revert "Pass through the CONVERT/NONCONVERT/HANKAKU_ZENKAKU keys."

I followed Windows's behavior but it does not make sense to Chrome OS and this
causes a regression: Zenkaku_Hankaku key on browser tab unexpectedly triggered
twice.

This reverts commit f5be2173f9794fdf121d80646740d6deced63c10.

BUG=438089
TEST=N/A
[email protected]
[email protected]
[email protected]

Review URL: https://codereview.chromium.org/813683003

Cr-Commit-Position: refs/heads/master@{#308769}

• ash/accelerators/accelerator_controller.cc[diff]
• ash/accelerators/accelerator_controller_unittest.cc[diff]

ServiceWorker: Remove unused functions from ServiceWorkerHandle

BUG=437677
TEST=compile

Review URL: https://codereview.chromium.org/795933004

Cr-Commit-Position: refs/heads/master@{#308768}

• content/browser/service_worker/service_worker_handle.cc[diff]
• content/browser/service_worker/service_worker_handle.h[diff]

Fix sandbox target in Windows GN build and enable it.

Re-land of https://codereview.chromium.org/804993003/ .

Review URL: https://codereview.chromium.org/808513005

Cr-Commit-Position: refs/heads/master@{#308767}

• BUILD.gn[diff]
• sandbox/win/BUILD.gn[diff]

Update WebGL CTS expectations; enable tex-image-and-sub-image-2d-with-webgl-canvas-* on Win.

tex-image-and-sub-image-2d-with-webgl-canvas-* were marked because of
BlitFramebufferANGLE restriction of color conversion.
http://src.chromium.org/viewvc/blink?view=revision&revision=187151 changes
WebGL not to use BlitFramebufferANGLE anymore. So unmark them.

BUG=420357

Review URL: https://codereview.chromium.org/807603005

Cr-Commit-Position: refs/heads/master@{#308766}

• content/test/gpu/gpu_tests/webgl_conformance_expectations.py[diff]

Update autofill CC icons.

Also remove diners and jcb

BUG=440592

Review URL: https://codereview.chromium.org/803223002

Cr-Commit-Position: refs/heads/master@{#308765}

• chrome/browser/android/resource_id.h[diff]
• chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc[diff]
• chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc[diff]
• chrome/browser/ui/autofill/autofill_popup_controller_impl.cc[diff]
• components/autofill/core/browser/credit_card.cc[diff]
• components/autofill/core/browser/credit_card_unittest.cc[diff]
• components/resources/autofill_scaled_resources.grdp[diff]
• components/resources/default_100_percent/common/autofill/amex.png[diff]
• components/resources/default_100_percent/common/autofill/cc-generic.png[diff]
• components/resources/default_100_percent/common/autofill/diners.png[Deleted - diff]
• components/resources/default_100_percent/common/autofill/discover.png[diff]
• components/resources/default_100_percent/common/autofill/jcb.png[Deleted - diff]
• components/resources/default_100_percent/common/autofill/mastercard.png[diff]
• components/resources/default_100_percent/common/autofill/visa.png[diff]
• components/resources/default_200_percent/common/autofill/amex.png[diff]
• components/resources/default_200_percent/common/autofill/cc-generic.png[Added - diff]
• components/resources/default_200_percent/common/autofill/discover.png[diff]
• components/resources/default_200_percent/common/autofill/mastercard.png[diff]
• components/resources/default_200_percent/common/autofill/visa.png[diff]

metrics: Move cryptohome histograms into chromium repo.

BUG=None
TEST=pretty_print, validate_format

Review URL: https://codereview.chromium.org/807883003

Cr-Commit-Position: refs/heads/master@{#308764}

• tools/metrics/histograms/histograms.xml[diff]

Fixing OWNERS email address.

[email protected]
BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/806163002

Cr-Commit-Position: refs/heads/master@{#308763}

• chrome/browser/media/OWNERS[diff]

Update V8 to version 3.31.60 (based on 978f41a1da57132f97fbfd9b6592cc99689e18ed).

[email protected]

Review URL: https://codereview.chromium.org/811563007

Cr-Commit-Position: refs/heads/master@{#308762}

• DEPS[diff]

Files.app: Stop to cache data: URL in ImageLoderClient.

BUG=442614
TEST=ImageLoaderJsTest.ImageLoaderClientTest
[email protected]

Review URL: https://codereview.chromium.org/802373003

Cr-Commit-Position: refs/heads/master@{#308761}

• chrome/browser/chromeos/file_manager/image_loader_jstest.cc[diff]
• chrome/browser_tests.isolate[diff]
• ui/file_manager/image_loader/image_loader_client.js[diff]
• ui/file_manager/image_loader/image_loader_client_unittest.html[Added - diff]
• ui/file_manager/image_loader/image_loader_client_unittest.js[Added - diff]

Pull out a base class from DumpAccessibilityTree

This is in preparation for the following change that will add
DumpAccessibilityEvents tests, sharing a lot of common code.

BUG=440579

Review URL: https://codereview.chromium.org/787813006

Cr-Commit-Position: refs/heads/master@{#308760}

• content/browser/accessibility/dump_accessibility_browsertest_base.cc[Added - diff]
• content/browser/accessibility/dump_accessibility_browsertest_base.h[Added - diff]
• content/browser/accessibility/dump_accessibility_tree_browsertest.cc[diff]
• content/content_tests.gypi[diff]

Automated Commit: Committing new LKGM version 6588.0.0 for chromeos.

Cr-Commit-Position: refs/heads/master@{#308759}

• chromeos/CHROMEOS_LKGM[diff]

Update the upstream version of asan_symbolize.py to r222535,
which introduces support for the --dsym-hint option.

Add a dSYM hint producer to tools/valgrind/asan/asan_symbolize.py,
which builds paths to .dSYM files for executables and frameworks inside the
.app bundles, assuming the dSYM files are in the product dir.

BUG=148383, 242503, 170739, 166857
[email protected]
NOTRY=true

Review URL: https://codereview.chromium.org/797253002

Cr-Commit-Position: refs/heads/master@{#308758}

• tools/valgrind/asan/asan_symbolize.py[diff]
• tools/valgrind/asan/third_party/README.chromium[diff]
• tools/valgrind/asan/third_party/asan_symbolize.py[diff]

vda/vea_unittest - Support hangout scenario performance test.

1. Add a switch "num_play_throughs" to vda_unittest to play the video
   for the specified times.

2. Add a switch "num_frames_to_encode" to vea_unittest to specify the
   number of frames to be encoded. We will loop the input stream if
   frames are not enough.

3. Override the number of concurrent decoders/encoders to the number
   of input stream unless there is only one input stream.

BUG=350255
TEST=Run the test on peach-pit

Review URL: https://codereview.chromium.org/775123003

Cr-Commit-Position: refs/heads/master@{#308757}

• content/common/gpu/media/video_decode_accelerator_unittest.cc[diff]
• content/common/gpu/media/video_encode_accelerator_unittest.cc[diff]

Exclude ComponentLoaderTest which is causing crash on other tests

BUG=442834
[email protected]
NOTRY=true

Review URL: https://codereview.chromium.org/806393003

Cr-Commit-Position: refs/heads/master@{#308756}

• tools/valgrind/gtest_exclude/unit_tests.gtest_linux.txt[diff]

Remove hard-coded font families in WebUI.

This is done by the following steps:

1) Remove hard-coded font-family from all css/html files in chrome/browser/resources, except 'monospace', 'Courier New, monospace' and 'inherit' font types.

2) Add <link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> to all html files in chrome/browser/resources which not include chrome_shared.css file, and removed all the i18n-content="fontFamily:fontfamily;fontSize:fontSize" inside of the <body> and <html> tags.

BUG=303849

Review URL: https://codereview.chromium.org/786023002

Cr-Commit-Position: refs/heads/master@{#308755}

• chrome/browser/resources/about_conflicts.html[diff]
• chrome/browser/resources/about_credits.tmpl[diff]
• chrome/browser/resources/about_flash.html[diff]
• chrome/browser/resources/about_invalidations.css[diff]
• chrome/browser/resources/about_invalidations.html[diff]
• chrome/browser/resources/about_memory.html[diff]
• chrome/browser/resources/about_memory_linux.html[diff]
• chrome/browser/resources/about_memory_mac.html[diff]
• chrome/browser/resources/about_nacl.html[diff]
• chrome/browser/resources/about_stats.html[diff]
• chrome/browser/resources/about_sys/about_sys.css[diff]
• chrome/browser/resources/about_sys/about_sys.html[diff]
• chrome/browser/resources/about_version.css[diff]
• chrome/browser/resources/about_version.html[diff]
• chrome/browser/resources/about_voicesearch.html[diff]
• chrome/browser/resources/app_list/start_page.html[diff]
• chrome/browser/resources/bookmark_manager/js/bmm_test.html[diff]
• chrome/browser/resources/bookmark_manager/main.html[diff]
• chrome/browser/resources/chromeos/about_os_credits.html[diff]
• chrome/browser/resources/chromeos/choose_mobile_network.html[diff]
• chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.html[diff]
• chrome/browser/resources/chromeos/cryptohome.html[diff]
• chrome/browser/resources/chromeos/drive_internals.html[diff]
• chrome/browser/resources/chromeos/first_run/app/main.html[diff]
• chrome/browser/resources/chromeos/first_run/first_run.html[diff]
• chrome/browser/resources/chromeos/guest_session_tab.html[diff]
• chrome/browser/resources/chromeos/keyboard_overlay.css[diff]
• chrome/browser/resources/chromeos/keyboard_overlay.html[diff]
• chrome/browser/resources/chromeos/login/demo_user_login.html[diff]
• chrome/browser/resources/chromeos/login/login.html[diff]
• chrome/browser/resources/chromeos/login/oobe-screen.html[diff]
• chrome/browser/resources/chromeos/login/oobe.html[diff]
• chrome/browser/resources/chromeos/login/oobe_screen_controller_pairing.css[diff]
• chrome/browser/resources/chromeos/login/oobe_screen_host_pairing.html[diff]
• chrome/browser/resources/chromeos/merge_session_load.html[diff]
• chrome/browser/resources/chromeos/mobile_setup.html[diff]
• chrome/browser/resources/chromeos/mobile_setup_portal.html[diff]
• chrome/browser/resources/chromeos/network_ui/network_ui.html[diff]
• chrome/browser/resources/chromeos/nfc_debug.html[diff]
• chrome/browser/resources/chromeos/offline_app_load.html[diff]
• chrome/browser/resources/chromeos/offline_net_load.html[diff]
• chrome/browser/resources/chromeos/power.html[diff]
• chrome/browser/resources/chromeos/provided_file_systems.css[diff]
• chrome/browser/resources/chromeos/provided_file_systems.html[diff]
• chrome/browser/resources/chromeos/salsa.html[diff]
• chrome/browser/resources/chromeos/sim_unlock.html[diff]
• chrome/browser/resources/chromeos/slow.css[diff]
• chrome/browser/resources/chromeos/slow.html[diff]
• chrome/browser/resources/chromeos/wallpaper_manager/main.html[diff]
• chrome/browser/resources/components.html[diff]
• chrome/browser/resources/contextual_search/promo.css[diff]
• chrome/browser/resources/contextual_search/promo.html[diff]
• chrome/browser/resources/crashes.html[diff]
• chrome/browser/resources/domain_reliability_internals.html[diff]
• chrome/browser/resources/extensions/extension_info.css[Added - diff]
• chrome/browser/resources/extensions_infobar.css[diff]
• chrome/browser/resources/extensions_infobar_mac.css[diff]
• chrome/browser/resources/feedback/html/default.html[diff]
• chrome/browser/resources/flags.html[diff]
• chrome/browser/resources/gaia_auth/main.html[diff]
• chrome/browser/resources/gaia_auth/offline.html[diff]
• chrome/browser/resources/gaia_auth/success.html[diff]
• chrome/browser/resources/gcm_internals.html[diff]
• chrome/browser/resources/gesture_config.css[diff]
• chrome/browser/resources/hangout_services/background.html[diff]
• chrome/browser/resources/hotword_audio_verification/main.html[diff]
• chrome/browser/resources/hotword_audio_verification/style.css[diff]
• chrome/browser/resources/identity_internals.html[diff]
• chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.html[diff]
• chrome/browser/resources/inline_login/inline_login.html[diff]
• chrome/browser/resources/inline_login/new_inline_login.html[diff]
• chrome/browser/resources/inspect/inspect.css[diff]
• chrome/browser/resources/inspect/inspect.html[diff]
• chrome/browser/resources/instant/instant.css[diff]
• chrome/browser/resources/instant/instant.html[diff]
• chrome/browser/resources/local_ntp/local_ntp.css[diff]
• chrome/browser/resources/local_state/local_state.html[diff]
• chrome/browser/resources/media/webrtc_logs.html[diff]
• chrome/browser/resources/memory_internals/memory_internals.html[diff]
• chrome/browser/resources/net_export/net_export.css[diff]
• chrome/browser/resources/net_export/net_export.html[diff]
• chrome/browser/resources/net_internals/events_view.css[diff]
• chrome/browser/resources/net_internals/index.html[diff]
• chrome/browser/resources/notification_1line.html[diff]
• chrome/browser/resources/notification_2line.html[diff]
• chrome/browser/resources/notification_icon.html[diff]
• chrome/browser/resources/ntp4/apps_page.css[diff]
• chrome/browser/resources/ntp4/guest_tab.html[diff]
• chrome/browser/resources/ntp4/incognito_tab.html[diff]
• chrome/browser/resources/ntp4/new_tab.html[diff]
• chrome/browser/resources/omnibox/omnibox.html[diff]
• chrome/browser/resources/pdf/index.html[diff]
• chrome/browser/resources/plugins.html[diff]
• chrome/browser/resources/predictors/predictors.html[diff]
• chrome/browser/resources/print_preview/previewarea/margin_control.css[diff]
• chrome/browser/resources/print_preview/print_preview_page.html[diff]
• chrome/browser/resources/profile_signin_confirmation.html[diff]
• chrome/browser/resources/profiler/profiler.html[diff]
• chrome/browser/resources/quota_internals/main.html[diff]
• chrome/browser/resources/reader_out_of_date.html[diff]
• chrome/browser/resources/security_warnings/interstitial_v2.html[diff]
• chrome/browser/resources/signin_internals/signin_index.html[diff]
• chrome/browser/resources/suggestions_internals/suggestions_internals.html[diff]
• chrome/browser/resources/supervised_user_block_interstitial.css[diff]
• chrome/browser/resources/supervised_user_block_interstitial.html[diff]
• chrome/browser/resources/sync_file_system_internals/main.css[diff]
• chrome/browser/resources/sync_file_system_internals/main.html[diff]
• chrome/browser/resources/sync_internals/about.css[diff]
• chrome/browser/resources/sync_internals/index.html[diff]
• chrome/browser/resources/translate_internals/translate_internals.html[diff]
• chrome/browser/resources/user_actions/user_actions.html[diff]
• chrome/browser/resources/user_manager/user_manager.html[diff]
• chrome/browser/resources/whispernet_proxy/background.html[diff]

Mac: Enable compositor thread elastic overscroll for main thread events

This patch has no effects because the feature is behind a flag.

When an input wheel event is passed to the main thread to be handled,
observe the result of Blink's handleInputEvent, and pass the event and
its result back to the InputScrollElasticityController (aka troll) on
the compositor thread. Do this passing via the InputHandlerManager,
which can reach the InputHandlerProxy for a renderer, and its
InputScrollElasticityController.

For now, construct an artifical scroll result based on whether or not
the event was handled.

Also, fix two bugs that were noticed. First, add the missed
rubber_banding_on_compositor_thread to content::WebPreferences'
IPC. Second, make ScrollElasticityHelper damage the root layer of
the LayerTreeHostImpl, so its frames aren't skipped.

BUG=133097

Review URL: https://codereview.chromium.org/806473002

Cr-Commit-Position: refs/heads/master@{#308754}

• cc/input/scroll_elasticity_helper.cc[diff]
• content/public/common/common_param_traits_macros.h[diff]
• content/renderer/input/input_handler_manager.cc[diff]
• content/renderer/input/input_handler_manager.h[diff]
• content/renderer/input/input_handler_proxy.h[diff]
• content/renderer/render_widget.cc[diff]
• content/renderer/render_widget.h[diff]

webui: make action link focus behavior more correcter.

tl;dr - I was totally wrong, <a href> does get focused when the mouse is
pressed, it just inconveniently doesn't show a focus outline in this case.

This CL actually focuses action links on mouse press, but hides the outline if
focus is initiated via mouse press. It also adds behavior to prevent text
selection when the mouse is dragged (to match more odd <a href> behavior).

[email protected]
BUG=441233

Review URL: https://codereview.chromium.org/805423003

Cr-Commit-Position: refs/heads/master@{#308753}

• ui/webui/resources/css/widgets.css[diff]
• ui/webui/resources/js/action_link.js[diff]

Introduction of DevToolsBridgeServiceBase based on MultiplexingGcmListener.

MultiplexingGcmListener used in Chrome for several features an this should use it as well.
Moreover it solves the problem with GDCReceiver. Because MultiplexingGcmListener is a GDCReceiver
and does it's work this service doesn't have to handle messages it is not interested in. It
could be done in a Service (not necessary a IntentService with it's lifetime complications).

BUG=383418

Review URL: https://codereview.chromium.org/806913005

Cr-Commit-Position: refs/heads/master@{#308752}

• components/devtools_bridge.gyp[diff]
• components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/DevToolsBridgeServer.java[diff]
• components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/DevToolsBridgeServiceBase.java[Added - diff]
• components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/GCDNotificationHandler.java[diff]
• components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/apiary/ApiaryClientFactory.java[diff]
• components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/apiary/BlockingGCMRegistrar.java[diff]
• components/devtools_bridge/android/javatests/AndroidManifest.xml[diff]
• components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/tests/TestApplication.java[diff]
• components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/GCDHostService.java[Deleted - diff]
• components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/TestDevToolsBridgeService.java[Added - diff]
• components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/apiary/TestApiaryClientFactory.java[diff]

Chromecast: IPC messages for browser-based media pipeline.

[email protected],[email protected],[email protected]
BUG=408189

Review URL: https://codereview.chromium.org/797793004

Cr-Commit-Position: refs/heads/master@{#308751}

• chromecast/chromecast.gyp[diff]
• chromecast/common/media/DEPS[Added - diff]
• chromecast/common/media/OWNERS[Added - diff]
• chromecast/common/media/cma_message_generator.cc[Added - diff]
• chromecast/common/media/cma_message_generator.h[Added - diff]
• chromecast/common/media/cma_messages.h[Added - diff]
• chromecast/common/media/cma_param_traits.cc[Added - diff]
• chromecast/common/media/cma_param_traits.h[Added - diff]
• chromecast/common/media/cma_param_traits_macros.h[Added - diff]
• ipc/ipc_message_start.h[diff]

Combine resources at gallery/js/compiled_resources.gyp for Closure Compiler.

Previously javascript files are combined at gallery_scripts.js, and the compiler used the file to check types. But in the file, scripts of gallery are included inside an anonymous function to enable strict mode for them, and it causes some problems with closure compiler.
In order to remove anonymous function for type checking, thic CL changes to combile resources at compiled_resources.gyp for type checking.

BUG=432728
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/806393002

Cr-Commit-Position: refs/heads/master@{#308750}

• ui/file_manager/gallery/js/compiled_resources.gyp[diff]

Tweak style of button preference.

BUG=414438

Review URL: https://codereview.chromium.org/807173004

Cr-Commit-Position: refs/heads/master@{#308749}

• chrome/android/java/res/drawable/btn_default_preferences_disabled.xml[diff]
• chrome/android/java/res/drawable/btn_default_preferences_enabled.xml[diff]
• chrome/android/java/res/drawable/btn_default_preferences_pressed.xml[diff]
• chrome/android/java/res/layout/preference_button.xml[diff]
• chrome/android/java/res/values-v21/dimens.xml[diff]
• chrome/android/java/res/values/dimens.xml[diff]

Fix RenderWidgetHostViewAuraTest.Resize with Surfaces

https://crrev.com/4660fe0284ce27d8501364e0df450516f9f9625d changed the behavior to ack earlier, so fix this test.

Review URL: https://codereview.chromium.org/796193005

Cr-Commit-Position: refs/heads/master@{#308748}

• content/browser/renderer_host/render_widget_host_view_aura_unittest.cc[diff]

Initialize metrics_service in CastMetricsServiceClient::Initialize().

metrics_service ctor calls CastMetricsServiceClient::IsReportingEnabled() which calls PlatformIsReportingEnabled(cast_service).

BUG=

Review URL: https://codereview.chromium.org/798063003

Cr-Commit-Position: refs/heads/master@{#308747}

• chromecast/browser/metrics/cast_metrics_service_client.cc[diff]
• chromecast/browser/metrics/cast_metrics_service_client.h[diff]

[Video Player] Replace background page with BackgroundBase class

BackgroundBase is the common class for background page of Files.app related apps. The Files.app and the audio player already use it.

This patch makes the video player use it.

BUG=442212
TEST=browser test passes

Review URL: https://codereview.chromium.org/800393004

Cr-Commit-Position: refs/heads/master@{#308746}

• ui/file_manager/integration_tests/video_player/test_helper_on_ui_page.js[Deleted - diff]
• ui/file_manager/integration_tests/video_player/test_util.js[diff]
• ui/file_manager/video_player/js/background.js[diff]
• ui/file_manager/video_player/js/cast/media_manager.js[diff]
• ui/file_manager/video_player/js/video_player.js[diff]
• ui/file_manager/video_player/js/video_player_scripts.js[diff]
• ui/file_manager/video_player/manifest.json[diff]

Add avi as OWNER for Cocoa stuff in components/bookmarks

Specifically, for bookmarks/browser/bookmark_pasteboard_helper_mac.*

NOTRY=true

Review URL: https://codereview.chromium.org/812593003

Cr-Commit-Position: refs/heads/master@{#308745}

• components/bookmarks/browser/OWNERS[Added - diff]

Add a ForkWithFlags wrapper using the libc clone wrapper.

sys_clone directly invokes the syscall, which does not update
libc's PID cache in the child. Although the libc wrapper function
updates the PID cache, it unfortunately requires that the child run on a
different stack, even if CLONE_VM is not specified. We work around this
by briefly switching stacks in the child, then using longjmp to switch
back. This gives us a version of clone with fork-like behavior, which is
what we need for starting processes in new namespaces.

This is a 2nd attempt at crrev.com/801033002, which caused failures
under valgrind and FORTIFY_SOURCE.

BUG=312380, 442817, 442912

Review URL: https://codereview.chromium.org/800183004

Cr-Commit-Position: refs/heads/master@{#308744}

• sandbox/linux/services/syscall_wrappers.cc[diff]
• sandbox/linux/services/syscall_wrappers.h[diff]
• sandbox/linux/services/syscall_wrappers_unittest.cc[diff]

app_list: Added test suite for OmniboxResult.

In particular, tests that it correctly performs its special behaviour
regarding voice queries.

BUG=442593

Review URL: https://codereview.chromium.org/807083002

Cr-Commit-Position: refs/heads/master@{#308743}

• chrome/browser/ui/app_list/search/omnibox_result.cc[diff]
• chrome/browser/ui/app_list/search/omnibox_result_unittest.cc[Added - diff]
• chrome/browser/ui/app_list/test/test_app_list_controller_delegate.cc[diff]
• chrome/browser/ui/app_list/test/test_app_list_controller_delegate.h[diff]
• chrome/chrome_tests_unit.gypi[diff]

Switch MediaImportHandler over to use TaskQueue.

This CL does the following:
- transition the Task over to an Observer model, which allows clients more flexibility in tracking tasks.
- make the ImportTask a subclass of TaskQueue.Task
- switch the MediaImportHandler over to use the TaskQueue
- fix all unit tests.

BUG=420680

Review URL: https://codereview.chromium.org/809563004

Cr-Commit-Position: refs/heads/master@{#308742}

• ui/file_manager/file_manager/background/js/media_import_handler.js[diff]
• ui/file_manager/file_manager/background/js/media_import_handler_unittest.html[diff]
• ui/file_manager/file_manager/background/js/media_import_handler_unittest.js[diff]
• ui/file_manager/file_manager/background/js/task_queue.js[diff]
• ui/file_manager/file_manager/background/js/task_queue_unittest.js[diff]
• ui/file_manager/file_manager/manifest.json[diff]
• ui/file_manager/file_manager_resources.grd[diff]

[Ozone-DRI] Make sure to reply to all configuration requests

If we're not replying the browser side will continue waiting for responses
delaying other configuration requests.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/811633005

Cr-Commit-Position: refs/heads/master@{#308741}

• ui/ozone/platform/dri/dri_gpu_platform_support.cc[diff]

Reland: [Ozone-Demo] Extract rendering parts into separate renderer classes

Makes it easier to abstract the part that renders to buffers and add
new ones.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/808833002

Cr-Commit-Position: refs/heads/master@{#308740}

• ui/ozone/demo/BUILD.gn[diff]
• ui/ozone/demo/gl_renderer.cc[Added - diff]
• ui/ozone/demo/gl_renderer.h[Added - diff]
• ui/ozone/demo/ozone_demo.cc[diff]
• ui/ozone/demo/ozone_demos.gyp[diff]
• ui/ozone/demo/renderer.h[Added - diff]
• ui/ozone/demo/renderer_base.cc[Added - diff]
• ui/ozone/demo/renderer_base.h[Added - diff]
• ui/ozone/demo/software_renderer.cc[Added - diff]
• ui/ozone/demo/software_renderer.h[Added - diff]

cc: Adding a CommitEarlyOutReason enum to replace bool in BeginMainFrameAbort method.

The bool is confusing and has meant a bunch of tests have ended up not testing
what they thought they were testing. The new enum clearly delineates between
cases were we abort without handing the commit and when we abort because the
commit was an effective nop.

This also allows new early out reasons to be easily added.

Using a C++ "enum class" to make sure all BeginMainFrameAborted cases are
converted by preventing implicit conversion to bool. Allowed on;
https://chromium-cpp.appspot.com/

BUG=416749

Review URL: https://codereview.chromium.org/793243006

Cr-Commit-Position: refs/heads/master@{#308739}

• cc/BUILD.gn[diff]
• cc/cc.gyp[diff]
• cc/scheduler/commit_earlyout_reason.h[Added - diff]
• cc/scheduler/scheduler.cc[diff]
• cc/scheduler/scheduler.h[diff]
• cc/scheduler/scheduler_state_machine.cc[diff]
• cc/scheduler/scheduler_state_machine.h[diff]
• cc/scheduler/scheduler_state_machine_unittest.cc[diff]
• cc/test/layer_tree_test.cc[diff]
• cc/test/layer_tree_test.h[diff]
• cc/trees/layer_tree_host_impl.cc[diff]
• cc/trees/layer_tree_host_impl.h[diff]
• cc/trees/layer_tree_host_unittest.cc[diff]
• cc/trees/single_thread_proxy.cc[diff]
• cc/trees/single_thread_proxy.h[diff]
• cc/trees/thread_proxy.cc[diff]
• cc/trees/thread_proxy.h[diff]

ui/wm: Cleanup usage of scoped_ptr.

* Return nullptr whenever possible.
* Use make_scoped_ptr() when possible (less typing/noise).

Entries found with the following command line:

$ git grep -E '(=|\breturn)\s*scoped_ptr<.*?>([^)]+)' ui/wm

BUG=None
[email protected]

Review URL: https://codereview.chromium.org/792603003

Cr-Commit-Position: refs/heads/master@{#308738}

• ui/wm/core/nested_accelerator_dispatcher_linux.cc[diff]
• ui/wm/core/nested_accelerator_dispatcher_win.cc[diff]
• ui/wm/core/shadow_unittest.cc[diff]

Remove disabled tests session_restore.cold.startup_urls and session_restore.warm.startup_urls.

These are adding to the maintenance burden. If they need to be brought back to life, the measurement will need a substitute for CanRunForPage because that method is going away. https://codereview.chromium.org/808893002/

The CL that disabled the tests: https://codereview.chromium.org/738663002

BUG=389142,405386,440101

Review URL: https://codereview.chromium.org/809653004

Cr-Commit-Position: refs/heads/master@{#308737}

• tools/perf/benchmarks/session_restore.py[diff]
• tools/perf/measurements/session_restore_with_url.py[Deleted - diff]

ui/base: Mark DataPack's ctor explicit.

BUG=318840
TEST=ui_base_unittests
[email protected]

Review URL: https://codereview.chromium.org/798143003

Cr-Commit-Position: refs/heads/master@{#308736}

• ui/base/resource/data_pack.h[diff]

Remove unnecessary arithmetic operations.

It is not necessary to subtract the remainder before an integer
division.

Add the delay < 0 check back, so that we don't rely on the fact that
static_cast<snd_pcm_uframes_t>(-1) is a huge positive value.

[email protected]
BUG=none

Review URL: https://codereview.chromium.org/807973003

Cr-Commit-Position: refs/heads/master@{#308735}

• media/audio/alsa/alsa_output.cc[diff]

Trace the TimeoutMonitor

Instrument the TimeoutMonitor with trace events and switch the time base
from Time::Now() to TimeTicks::Now().

BUG=436379

Review URL: https://codereview.chromium.org/806343002

Cr-Commit-Position: refs/heads/master@{#308734}

• content/browser/renderer_host/input/timeout_monitor.cc[diff]
• content/browser/renderer_host/input/timeout_monitor.h[diff]

Blink roll 994eb22650691379d1a14137f567ba8473d22aaa:eabe8e63be5972a48f0b7f1f63dce19caf839bf1

[email protected]
BUG=

Review URL: https://codereview.chromium.org/813633002

Cr-Commit-Position: refs/heads/master@{#308733}

• DEPS[diff]

Don't return a favicon for native pages.

The default favicon that chrome returns is not necessarily the one we want to use on Android
for native pages.

BUG=411155

Review URL: https://codereview.chromium.org/797083002

Cr-Commit-Position: refs/heads/master@{#308732}

• chrome/android/java/src/org/chromium/chrome/browser/Tab.java[diff]
• chrome/browser/android/tab_android.cc[diff]
• chrome/browser/android/tab_android.h[diff]

Rename the hardware_params constructor argument.

Make the constructor argument name in match the member name and the
argumet's name in the .cc file.

[email protected]
BUG=none

Review URL: https://codereview.chromium.org/801193003

Cr-Commit-Position: refs/heads/master@{#308731}

• media/filters/audio_renderer_impl.h[diff]

build: make about:credits have proper inputs.

[email protected]
BUG=none
TEST=touch about_credits.tmpl && rebuild  # actually works

Review URL: https://codereview.chromium.org/807713003

Cr-Commit-Position: refs/heads/master@{#308730}

• chrome/browser/BUILD.gn[diff]
• chrome/chrome_resources.gyp[diff]

Revert of [telemetry] - Tear down replay server when browser is lost. (patchset #1 id:1 of https://codereview.chromium.org/808803002/)

Reason for revert:
Didn't fix tests :(

Original issue's description:
> [telemetry] - Tear down replay server when browser is lost.
>
> Speculative fix for crbug.com/439598. When browser is lost/crashes mid test, we don't unmap all the forwarded ports, and host_forwarder seems to get into a state where it can't communicate with the device anymore.
>
> BUG=439598
>
> Committed: https://crrev.com/b8135064c7535c42949a7e7e05962b78d87a5cdb
> Cr-Commit-Position: refs/heads/master@{#308652}

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=439598

Review URL: https://codereview.chromium.org/812753002

Cr-Commit-Position: refs/heads/master@{#308729}

• tools/telemetry/telemetry/core/browser.py[diff]
• tools/telemetry/telemetry/core/platform/platform_backend.py[diff]

Clip quads in surfaces to the SurfaceDrawQuad's clip_rect and visible_rect.

They should be clipped to the clip_rect for correctness, and to the visible_rect for performance in the case of partially-overlapping surfaces.

BUG=439933,339260

Review URL: https://codereview.chromium.org/787763012

Cr-Commit-Position: refs/heads/master@{#308728}

• cc/surfaces/surface_aggregator.cc[diff]
• cc/surfaces/surface_aggregator.h[diff]
• cc/surfaces/surface_aggregator_unittest.cc[diff]

Convert EventRouter to use ProcessMap::GetMostLikelyContextType rather than
implementing its own process checking logic, and (double) check on event
dispatch that the context has permission to receive the event. Currently we
only check on event registration.

BUG=441789
[email protected]

Review URL: https://codereview.chromium.org/802653003

Cr-Commit-Position: refs/heads/master@{#308727}

• chrome/common/extensions/api/extension_api_unittest.cc[diff]
• extensions/browser/event_router.cc[diff]
• extensions/common/extension_api.cc[diff]
• extensions/common/extension_api.h[diff]

ui/gfx: Complete the list of unit tests for GN version of gfx_unittests target.

GYP version of gfx_unittests contains 535 test cases on Linux.

Now with this change GN version of gfx_unittests also contains 535 test
cases.

BUG=None
TEST=gn gen out_gn/Debug && ninja -C out_gn/Debug gfx_unittests && out_gn/Debug gfx_unittests
[email protected]

Review URL: https://codereview.chromium.org/797823004

Cr-Commit-Position: refs/heads/master@{#308726}

• ui/gfx/BUILD.gn[diff]

Disabling AX test for html br element temporarily.

After blink changes for html br element is merged, then it'd be enabled.

BUG=116181

Review URL: https://codereview.chromium.org/812513002

Cr-Commit-Position: refs/heads/master@{#308725}

• content/browser/accessibility/dump_accessibility_tree_browsertest.cc[diff]

Introduce Property Trees

Based of Andrew's work: crrev.com/642833002

This patch creates a transform and a clip tree and computes
visual content rects based on those.

BUG=386786

Review URL: https://codereview.chromium.org/687873004

Cr-Commit-Position: refs/heads/master@{#308724}

• cc/BUILD.gn[diff]
• cc/cc.gyp[diff]
• cc/cc_tests.gyp[diff]
• cc/layers/layer.cc[diff]
• cc/layers/layer.h[diff]
• cc/layers/layer_impl.h[diff]
• cc/layers/tiled_layer_unittest.cc[diff]
• cc/test/fake_layer_tree_host.cc[diff]
• cc/test/layer_tree_test.cc[diff]
• cc/trees/draw_property_utils.cc[Added - diff]
• cc/trees/draw_property_utils.h[Added - diff]
• cc/trees/layer_tree_host.cc[diff]
• cc/trees/layer_tree_host_common.cc[diff]
• cc/trees/layer_tree_host_common.h[diff]
• cc/trees/layer_tree_host_common_perftest.cc[diff]
• cc/trees/layer_tree_host_common_unittest.cc[diff]
• cc/trees/layer_tree_host_unittest_no_message_loop.cc[diff]
• cc/trees/layer_tree_impl.cc[diff]
• cc/trees/layer_tree_settings.cc[diff]
• cc/trees/layer_tree_settings.h[diff]
• cc/trees/property_tree.cc[Added - diff]
• cc/trees/property_tree.h[Added - diff]
• cc/trees/property_tree_builder.cc[Added - diff]
• cc/trees/property_tree_builder.h[Added - diff]
• cc/trees/property_tree_unittest.cc[Added - diff]
• ui/gfx/transform.h[diff]

Don't consider JWK's {"use": "enc"} as allowing key derivation.

BUG=442007

Review URL: https://codereview.chromium.org/809613002

Cr-Commit-Position: refs/heads/master@{#308723}

• content/child/webcrypto/jwk.cc[diff]
• content/child/webcrypto/test/ecdh_unittest.cc[diff]
• content/test/data/webcrypto/ecdh.json[diff]

aria-pressed on a button should expose checked on android.

When aria-pressed is defined as {true/mixed} on button, then class android.widget.togglebutton is
exposed, and its state on should be checked.

BUG=171625

Review URL: https://codereview.chromium.org/795233004

Cr-Commit-Position: refs/heads/master@{#308722}

• content/browser/accessibility/browser_accessibility_android.cc[diff]
• content/test/data/accessibility/aria-button-expected-android.txt[diff]
• content/test/data/accessibility/aria-pressed-expected-android.txt[diff]

ozone: suppress TTC when the cursor is hidden

The CL temporarily disables the tap-to-click feature when the cursor
is hidden no matter whether it is enabled or not. This is to improve
the user experience in some use cases (e.g., typing, watching video).

Contributed by [email protected]

BUG=440656
TEST=link_freon ChromeOS build

Review URL: https://codereview.chromium.org/790583003

Cr-Commit-Position: refs/heads/master@{#308721}

• ash/host/DEPS[diff]
• ash/host/ash_window_tree_host_ozone.cc[diff]
• ui/aura/window_tree_host_ozone.cc[diff]
• ui/events/ozone/evdev/input_controller_evdev.cc[diff]
• ui/events/ozone/evdev/input_controller_evdev.h[diff]
• ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc[diff]
• ui/ozone/public/input_controller.cc[diff]
• ui/ozone/public/input_controller.h[diff]

net: add HSTS preload for login.(ubuntu.com|launchpad.net) by request.
Cr-Commit-Position: refs/heads/master@{#308720}

• net/http/transport_security_state_static.h[diff]
• net/http/transport_security_state_static.json[diff]

Fixing initialization order of |MemoryPressureObserverChromeOS|

Due to some overlapping CL's the initialization order required to be changed so that the message_loop exists before the MemoryPressureObserver gets created.

BUG=-
TEST=upcoming test revealed this. Will be in next CL.

Review URL: https://codereview.chromium.org/805383002

Cr-Commit-Position: refs/heads/master@{#308719}

• content/browser/browser_main_loop.cc[diff]

Roll src/third_party/skia e1869ca:a86a233

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e1869ca..a86a233

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]

Review URL: https://codereview.chromium.org/808703003

Cr-Commit-Position: refs/heads/master@{#308718}

• DEPS[diff]

net: add batch of HSTS preloads.
Cr-Commit-Position: refs/heads/master@{#308717}

• net/http/transport_security_state_static.h[diff]
• net/http/transport_security_state_static.json[diff]

ozone: evdev: Plumb keyboard repeat settings into KeyboardEvdev

This allows ChromeOS settings to disable repeat & change the rate.

BUG=441856
TEST=adjust settings on link_freon & check rate changes

Review URL: https://codereview.chromium.org/800203002

Cr-Commit-Position: refs/heads/master@{#308716}

• ui/events/ozone/evdev/event_factory_evdev.cc[diff]
• ui/events/ozone/evdev/input_controller_evdev.cc[diff]
• ui/events/ozone/evdev/input_controller_evdev.h[diff]
• ui/events/ozone/evdev/keyboard_evdev.cc[diff]
• ui/events/ozone/evdev/keyboard_evdev.h[diff]

GuestView: Cleanup Zoom

This CL does the following:

1. Update the zoom observation when owner_web_contents changes.
2. Disable Zoom Propogation for MIME Handlers.
3. Cleanup zoom code a bit in GuestViewBase.

BUG=442861

Review URL: https://codereview.chromium.org/806223003

Cr-Commit-Position: refs/heads/master@{#308715}

• extensions/browser/guest_view/guest_view_base.cc[diff]
• extensions/browser/guest_view/guest_view_base.h[diff]
• extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc[diff]
• extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h[diff]

ARIA state/property aria-autocomplete should expose IA2_STATE_SUPPORTS_AUTOCOMPLETION.

According to specs http://rawgit.com/w3c/aria/master/core-aam/core-aam.html
aria-autocomplete {"inline", "list","both"} set IA2_STATE_SUPPORTS_AUTOCOMPLETION.
aria-autocomplete {"none"} Not Mapped

Also, expose object attribute autocomplete: <value>.

This CL depends on https://codereview.chromium.org/779513007/

BUG=169559, 169563

Review URL: https://codereview.chromium.org/785943002

Cr-Commit-Position: refs/heads/master@{#308714}

• content/browser/accessibility/browser_accessibility_win.cc[diff]
• content/renderer/accessibility/blink_ax_tree_source.cc[diff]
• content/test/data/accessibility/aria-autocomplete-expected-android.txt[diff]
• content/test/data/accessibility/aria-autocomplete-expected-win.txt[diff]
• content/test/data/accessibility/aria-autocomplete.html[diff]
• ui/accessibility/ax_enums.idl[diff]
• ui/accessibility/ax_node_data.cc[diff]

Plumb maximum rectangle texture size into TextureManager.

This allows MaxSizeForTarget() to return correct values for
GL_TEXTURE_RECTANGLE targets, which is necessary for copying large
rectangle textures (such as those produced by the new Mac hardware
decoder).

BUG=425708

Review URL: https://codereview.chromium.org/797843002

Cr-Commit-Position: refs/heads/master@{#308713}

• content/common/gpu/media/gpu_video_decode_accelerator.cc[diff]
• gpu/command_buffer/service/context_group.cc[diff]
• gpu/command_buffer/service/framebuffer_manager_unittest.cc[diff]
• gpu/command_buffer/service/test_helper.cc[diff]
• gpu/command_buffer/service/test_helper.h[diff]
• gpu/command_buffer/service/texture_manager.cc[diff]
• gpu/command_buffer/service/texture_manager.h[diff]
• gpu/command_buffer/service/texture_manager_unittest.cc[diff]
• media/filters/gpu_video_decoder.cc[diff]

Linux: Change the RPM installer to use XZ compression.

This results in a 20% smaller file vs BZ compression.
The RPM package is then approximately the same size as the DEB package.
Tested on OpenSUSE 12.2, and Fedora claims support since F12.

Review URL: https://codereview.chromium.org/809703004

Cr-Commit-Position: refs/heads/master@{#308712}

• chrome/installer/linux/rpm/build.sh[diff]

Fix few targets in UI during GN build on Windows.

BUG=None
TEST=gn gen out_gn/Debug && ninja -C out_gn/Debug
[email protected]
[email protected]

Review URL: https://codereview.chromium.org/806183002

Cr-Commit-Position: refs/heads/master@{#308711}

• BUILD.gn[diff]
• ui/aura/BUILD.gn[diff]
• ui/base/BUILD.gn[diff]
• ui/views/BUILD.gn[diff]

Fix EasyUnlockTpmKeyManager test leaks

BUG=442600
TEST=Run EasyUnlockTpmKeyManagerTest under valgrind

Review URL: https://codereview.chromium.org/789683003

Cr-Commit-Position: refs/heads/master@{#308710}

• chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc[diff]
• chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc[diff]
• chrome/browser/chromeos/platform_keys/platform_keys_nss.cc[diff]
• tools/valgrind/memcheck/suppressions_linux.txt[diff]

Fix ChromeRenderViewObserver::DidStopLoading to be OOPIF compatible.

BUG=442955

Review URL: https://codereview.chromium.org/807583006

Cr-Commit-Position: refs/heads/master@{#308709}

• chrome/renderer/chrome_render_view_observer.cc[diff]

Add comment to RendererFrameManager

BUG=None

Review URL: https://codereview.chromium.org/798513003

Cr-Commit-Position: refs/heads/master@{#308708}

• content/browser/renderer_host/renderer_frame_manager.h[diff]

Move make_javascript_deterministic to UserStory.

BUG=439512,439700

Review URL: https://codereview.chromium.org/806513002

Cr-Commit-Position: refs/heads/master@{#308707}

• content/test/gpu/gpu_tests/maps.py[diff]
• tools/perf/benchmarks/dromaeo.py[diff]
• tools/perf/benchmarks/jetstream.py[diff]
• tools/perf/benchmarks/maps.py[diff]
• tools/perf/benchmarks/octane.py[diff]
• tools/perf/benchmarks/robohornet_pro.py[diff]
• tools/perf/benchmarks/speedometer.py[diff]
• tools/perf/benchmarks/sunspider.py[diff]
• tools/perf/page_sets/alexa1-10000.py[diff]
• tools/perf/page_sets/service_worker.py[diff]
• tools/perf/page_sets/service_worker_micro_benchmark.py[diff]
• tools/perf/page_sets/top_desktop_sites_2012Q3.py[diff]
• tools/perf/page_sets/top_desktop_sites_2012Q3_stress.py[diff]
• tools/telemetry/telemetry/page/__init__.py[diff]
• tools/telemetry/telemetry/page/page_set.py[diff]
• tools/telemetry/telemetry/page/shared_page_state.py[diff]
• tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py[diff]
• tools/telemetry/telemetry/user_story/__init__.py[diff]
• tools/telemetry/telemetry/user_story/user_story_unittest.py[diff]

Don't reset ended_cb_ after ending in the MojoRendererImpl.

It's still valid for a client to seek to the beginning and restart
playback without reinitializing the renderer.

BUG=none
TEST=pipeline_integration_tests \o/

Review URL: https://codereview.chromium.org/809603006

Cr-Commit-Position: refs/heads/master@{#308706}

• media/mojo/services/mojo_renderer_impl.cc[diff]

MacViews: Make clipboard simplified string data for bookmarks consistent with other platforms

Note the unflattened "BookmarkDictionaryListPboardType" clipboard format
which preserves folder hierarchies is not changed.

This is covered by BookmarkNodeDataTest.* which is not currently run at
all on Mac. The tests have a toolkit-views dependency.

Currently on Mac BookmarkNodeData::WriteToClipboard descends into
folders when writing "simple" formats and emits no simple string data
for folders.

This changes Mac to emit only top-level data when creating the NSString
pasteboard format, and to include folder titles, making it consistent
with other platforms (i.e. with BookmarkNodeData::WriteToClipboard()
defined !OS_MACOSX in bookmark_node_data.cc )

After this CL, BookmarkNodeDataTest.* all run (and pass) in a
toolkit-views build on Mac. (3 of these tests would previously fail).

BUG=412234
TEST=components_unittests BookmarkNodeDataTest.*

Review URL: https://codereview.chromium.org/804813003

Cr-Commit-Position: refs/heads/master@{#308705}

• components/bookmarks/browser/bookmark_pasteboard_helper_mac.mm[diff]

Move DidChangeScrollOffset to RenderFrameObserver

BUG=433486

Review URL: https://codereview.chromium.org/812663002

Cr-Commit-Position: refs/heads/master@{#308704}

• components/autofill/content/renderer/autofill_agent.cc[diff]
• components/autofill/content/renderer/autofill_agent.h[diff]
• content/public/renderer/render_frame_observer.h[diff]
• content/public/renderer/render_view_observer.h[diff]
• content/renderer/render_frame_impl.cc[diff]
• content/renderer/render_view_impl.cc[diff]

Fix broken config change handling in the mojo demuxers.

The null buffers were not handled correctly.  The config change
queue system was also incorrect.  OnBufferReady() may be in the
process of handling a Read() call, so the read_cb_ can't be reset
immediately once the OnXXXConfigChanged() message is received, it
must wait for the kConfigChange status buffer.

BUG=none
TEST=pipeline integration tests \o/

Review URL: https://codereview.chromium.org/791983004

Cr-Commit-Position: refs/heads/master@{#308703}

• media/mojo/interfaces/demuxer_stream.mojom[diff]
• media/mojo/services/media_type_converters.cc[diff]
• media/mojo/services/mojo_demuxer_stream_adapter.cc[diff]
• media/mojo/services/mojo_demuxer_stream_impl.cc[diff]

Instrumenting opening password database to find jank.

This database opening happens in UI thread. Checking what jankiness this causes.

Background: one of jankiness investigations (crbug.com/426272) came to a conclusion that the jank is actually caused by this issue. Instrumenting to get the numbers.

BUG=138903

Review URL: https://codereview.chromium.org/807263003

Cr-Commit-Position: refs/heads/master@{#308702}

• components/password_manager/core/browser/login_database.cc[diff]

Roll src/third_party/skia 41b4d77:e1869ca

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/41b4d77..e1869ca

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]

Review URL: https://codereview.chromium.org/807163004

Cr-Commit-Position: refs/heads/master@{#308701}

• DEPS[diff]

ozone: evdev: Implement key repeat internally

Ignore repeated kernel events & do it internally. This prevents each
keyboard from having its own repeat.

Parameters are 500ms initial delay and 50ms repeat, same as CrOS
defaults. Using prefs is a followup.

BUG=441856
TEST=manual on link_freon

Review URL: https://codereview.chromium.org/798193002

Cr-Commit-Position: refs/heads/master@{#308700}

• ui/events/ozone/evdev/event_converter_evdev_impl.cc[diff]
• ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc[diff]
• ui/events/ozone/evdev/keyboard_evdev.cc[diff]
• ui/events/ozone/evdev/keyboard_evdev.h[diff]

ozone: layout: Export USE_XKBCOMMON to dependents

We're using this define in the dri & gbm platforms to create the correct
layout engine. Also some deps fixes in the GN build.

BUG=430194

Review URL: https://codereview.chromium.org/808873002

Cr-Commit-Position: refs/heads/master@{#308699}

• ui/events/ozone/BUILD.gn[diff]
• ui/events/ozone/events_ozone.gyp[diff]
• ui/ozone/platform/dri/BUILD.gn[diff]

Linux Video Capture: small cleanup

I took the liberty to bundle a bunch of cleanups:

- Some loops of the form while(...){... increment_variable} are passed to
for loops, this IMHO brings closer the loop-specific actions.

- Const added to many local variables.

- 1 Const auto and range based loop.

- GetListOfUsableFourCCs -> changed to return a std::list<int>
instead of filling up a pointer parameter; IMHO this reflects
better the method name.

- Renamed V4l2ColorToVideoCaptureColorFormat() ->
V4l2FourCcToChromiumPixelFormat() to reflect better what is doing.

- Removed superfluous comments and added refs to crbug.coms.

BUG=441836

Review URL: https://codereview.chromium.org/804473007

Cr-Commit-Position: refs/heads/master@{#308698}

• content/browser/media/media_internals_unittest.cc[diff]
• media/video/capture/linux/video_capture_device_factory_linux.cc[diff]
• media/video/capture/linux/video_capture_device_linux.cc[diff]
• media/video/capture/linux/video_capture_device_linux.h[diff]
• media/video/capture/video_capture_types.cc[diff]

Supports layout switch in Ozone by xkbcommon library.

BUG=430194

Review URL: https://codereview.chromium.org/811523003

Cr-Commit-Position: refs/heads/master@{#308697}

• ui/base/ime/chromeos/ime_keyboard_ozone.cc[diff]
• ui/base/ui_base.gyp[diff]
• ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc[diff]

Extending the memory pressure system by adding one more state to denote a lack of memory pressure.

This CL is adding one more state to the resource pressure states to allow a system state query to use the pressure value.

Please see go/chromeosresourcepressure for more information.

BUG=439493
TEST=Since there are no users of the new state, this cannot be "tested" yet.

Review URL: https://codereview.chromium.org/782053002

Cr-Commit-Position: refs/heads/master@{#308696}

• base/memory/memory_pressure_listener.cc[diff]
• base/memory/memory_pressure_listener.h[diff]
• content/common/host_discardable_shared_memory_manager.cc[diff]

[Extensions Toolbar Mac] Fix style mistakes in BrowserActionsContainerView

[email protected]

Review URL: https://codereview.chromium.org/787313003

Cr-Commit-Position: refs/heads/master@{#308695}

• chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm[diff]

Remove temp file should not fail if file is not on the device.

On post-ICS versions of Android 'rm -f' accomplishes this, but the -f option
does not exist on ICS leading to this error on the bots:
'rm failed for -f, No such file or directory'
Thus, instead of using -f, the script will let the rm fail and ignore it if the
file does not exist.

BUG=433143

Review URL: https://codereview.chromium.org/813543002

Cr-Commit-Position: refs/heads/master@{#308694}

• build/android/pylib/utils/device_temp_file.py[diff]

Make grit <include> de-duping clearer.

[email protected]
BUG=none
TEST=code is easier to read and more thoroughly tested
NOTRY=true

Review URL: https://codereview.chromium.org/800043003

Cr-Commit-Position: refs/heads/master@{#308693}

• third_party/closure_compiler/processor.py[diff]
• third_party/closure_compiler/processor_test.py[diff]

Reenable the CryptoToken extension in guest mode.

BUG=442783

Review URL: https://codereview.chromium.org/807663004

Cr-Commit-Position: refs/heads/master@{#308692}

• chrome/browser/resources/cryptotoken/manifest.json[diff]

clang/win: Fix two "expression which evaluates to zero treated as a null pointer constant" warnings

They were caused by https://codereview.chromium.org/725723002

BUG=432550
[email protected]
[email protected]

Review URL: https://codereview.chromium.org/807293002

Cr-Commit-Position: refs/heads/master@{#308691}

• content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc[diff]
• content/common/gpu/gpu_memory_buffer_factory_unittest.cc[diff]

Delete dead PushMessaging code.

BUG=389194

Review URL: https://codereview.chromium.org/811483004

Cr-Commit-Position: refs/heads/master@{#308690}

• content/browser/push_messaging/push_messaging_message_filter.cc[diff]
• content/browser/push_messaging/push_messaging_message_filter.h[diff]
• content/common/push_messaging_messages.h[diff]
• content/renderer/push_messaging_dispatcher.cc[diff]
• content/renderer/push_messaging_dispatcher.h[diff]

Accumulate content_to_target_transform for nested Surfaces.

All the transforms need to be combined together if there are multiple layers in the nesting.

Review URL: https://codereview.chromium.org/804903007

Cr-Commit-Position: refs/heads/master@{#308689}

• cc/surfaces/surface_aggregator.cc[diff]
• cc/surfaces/surface_aggregator.h[diff]
• cc/surfaces/surface_aggregator_unittest.cc[diff]

Instrumenting QuicStreamFactory::Job::DoLoop and HttpCache::Transaction::DoLoop for jank.

Prior instrumentations showed that:
QuicStreamFactory::Job::DoLoop = 38 jph
HttpCache::Transaction::DoLoop = 8 jph

Instrumenting further

BUG=422516

Review URL: https://codereview.chromium.org/803073003

Cr-Commit-Position: refs/heads/master@{#308688}

• net/http/http_cache_transaction.cc[diff]
• net/quic/quic_stream_factory.cc[diff]

Update handling of easy unlock icon tooltip for error state

Error state tooltips should be automatically shown (i.e. even if user
does not hover over the icon) with 1 second delay. Also, they should be
hidden after 5 seconds. Though, tooltip state caused by user hovering
over the icon should override the 'autoshow' state. The tooltip is
considered autoshown only if user was not already hovering over the icon
when the icon tooltip was set.

The tooltip state handling is refactored so the hover and autoshow states
are handled separately (though, autoshow state changes depend on hover
state, specifically on whether the tooltip is already shown due to hover
state).
Also, to simplify cleanup for timeouts, different private UserPodCustomIcon
class members are used for tracking timeouts set for hover state and
autoshow state changes.

BUG=422004

Review URL: https://codereview.chromium.org/807583004

Cr-Commit-Position: refs/heads/master@{#308687}

• chrome/browser/signin/easy_unlock_screenlock_state_handler.cc[diff]
• chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc[diff]
• ui/login/account_picker/user_pod_row.js[diff]

Fix compilation error.

BUG=

Review URL: https://codereview.chromium.org/811893002

Cr-Commit-Position: refs/heads/master@{#308686}

• chromecast/browser/metrics/cast_metrics_service_client.cc[diff]

Enabling Auth browser test for Chromoting on Windows.

I have tried running the Windows build of the Auth test
locally and on a swarming bot and it consistently passes
(both for v1 and v2 webapp).  Therefore, as discussed with Anand
I will enable Auth test for Windows, for v2 webapp.

In the long-term we should extend coverage to v1 webapp,
but this requires refactoring how parameters are passed to the tests
(and is tracked by chromium issue here:
https://code.google.com/p/chromium/issues/detail?id=423581).

BUG=431488

Review URL: https://codereview.chromium.org/809803002

Cr-Commit-Position: refs/heads/master@{#308685}

• testing/chromoting/chromoting_integration_tests.isolate[diff]

Add dontUseSummaryAsTitle attribute to ChromeSwitchPreference.

This attribute prevents the summary text from being styled like title
text in the case that the title is empty. Normally, we want the summary
text to be styled like title text, but this allows us to disable that
behavior in certain cases.

BUG=442845

Review URL: https://codereview.chromium.org/807273002

Cr-Commit-Position: refs/heads/master@{#308684}

• chrome/android/java/res/values/attrs.xml[diff]
• chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromeSwitchPreference.java[diff]

Add logging, fix double-logging, fix uirobot results

Add more logging messages.
Remove appurifys logging handler after it is added.
Have uirobot parse its results to return simple pass/fail.

BUG=428729

Review URL: https://codereview.chromium.org/792663005

Cr-Commit-Position: refs/heads/master@{#308683}

• build/android/pylib/remote/device/appurify_sanitized.py[Added - diff]
• build/android/pylib/remote/device/remote_device_environment.py[diff]
• build/android/pylib/remote/device/remote_device_gtest_run.py[diff]
• build/android/pylib/remote/device/remote_device_test_run.py[diff]
• build/android/pylib/remote/device/remote_device_uirobot_run.py[diff]

Roll WebRTC 7905:7914, Libjingle 7905:7908

WebRTC 7905:7914
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/25834b8..3b44b3c

Libjingle 7905:7908
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/f99af5c..33d17ee

[email protected]

Review URL: https://codereview.chromium.org/796363004

Cr-Commit-Position: refs/heads/master@{#308682}

• DEPS[diff]
• third_party/libjingle/README.chromium[diff]

Changed macros to UMA and updating histograms file.
First patch of LOCAL_ was to be safe, where the histograms are only stored locally.  Switching to UMA_ macros to start uploading the data.

BUG=439529

Review URL: https://codereview.chromium.org/794313003

Cr-Commit-Position: refs/heads/master@{#308681}

• content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc[diff]
• tools/metrics/histograms/histograms.xml[diff]

Upstream DocumentTabModelImpl and related classes

Moves the DocumentTabModelImpl and its associated tests/utility classes upstream
from the downstream directories.

Updates the findbugs to remove obsolete ones and add
temporary new ones (until more is upstreamed).

Setting NOTRY to true to get around findbugs changes.

BUG=415747
TEST=DocumentTabModelImplTest, OffTheRecordDocumentTabModelTest
NOTRY=true

Review URL: https://codereview.chromium.org/802343003

Cr-Commit-Position: refs/heads/master@{#308680}

• build/android/findbugs_filter/findbugs_known_bugs.txt[diff]
• chrome/android/BUILD.gn[diff]
• chrome/android/java/src/org/chromium/chrome/browser/document/DocumentMetricIds.java[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/document/OWNERS[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/document/PendingDocumentData.java[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/ActivityDelegate.java[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/OWNERS[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/OffTheRecordDocumentTabModel.java[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/StorageDelegate.java[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java[Added - diff]
• chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImplTest.java[Added - diff]
• chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/document/OWNERS[Added - diff]
• chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/document/OffTheRecordDocumentTabModelTest.java[Added - diff]
• chrome/chrome.gyp[diff]
• chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockActivityDelegate.java[Added - diff]
• chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockStorageDelegate.java[Added - diff]
• chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockTabDelegate.java[Added - diff]
• chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/OWNERS[Added - diff]
• chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/TestInitializationObserver.java[Added - diff]

Mark PrefServiceBridge.isAcceptCookiesEnabled @VisibleForTesting.

BUG=149400
[email protected]
[email protected]

Review URL: https://codereview.chromium.org/791633009

Cr-Commit-Position: refs/heads/master@{#308679}

• chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java[diff]

Organize source lists in chrome_browser_ui.gypi

This make chrome_browser_ui.gypi use the same organizational structure
for sources lists as chrome_browser.gypi now uses, with an alphabetical
list of platform-y lists, followed by an alphabetical list of feature-y
lists (ignoring 'non_' when alphabetizing).

BUG=None

Review URL: https://codereview.chromium.org/811573003

Cr-Commit-Position: refs/heads/master@{#308678}

• chrome/chrome_browser_ui.gypi[diff]

Roll src/third_party/skia 3f801cb:41b4d77

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3f801cb..41b4d77

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]

Review URL: https://codereview.chromium.org/807103003

Cr-Commit-Position: refs/heads/master@{#308677}

• DEPS[diff]

Upstream components/translate/ios

Review URL: https://codereview.chromium.org/809693003

Cr-Commit-Position: refs/heads/master@{#308676}

• components/components_tests.gyp[diff]
• components/translate.gypi[diff]
• components/translate/ios/DEPS[Added - diff]
• components/translate/ios/browser/ios_translate_driver.h[Added - diff]
• components/translate/ios/browser/ios_translate_driver.mm[Added - diff]
• components/translate/ios/browser/js_language_detection_manager.h[Added - diff]
• components/translate/ios/browser/js_language_detection_manager.mm[Added - diff]
• components/translate/ios/browser/js_translate_manager.h[Added - diff]
• components/translate/ios/browser/js_translate_manager.mm[Added - diff]
• components/translate/ios/browser/js_translate_manager_unittest.mm[Added - diff]
• components/translate/ios/browser/language_detection_controller.h[Added - diff]
• components/translate/ios/browser/language_detection_controller.mm[Added - diff]
• components/translate/ios/browser/language_detection_controller_unittest.mm[Added - diff]
• components/translate/ios/browser/resources/language_detection.js[Added - diff]
• components/translate/ios/browser/resources/translate_ios.js[Added - diff]
• components/translate/ios/browser/translate_controller.h[Added - diff]
• components/translate/ios/browser/translate_controller.mm[Added - diff]
• components/translate/ios/browser/translate_controller_unittest.mm[Added - diff]
• ios/ios_tests_unit.gyp[diff]
• ios/web/ios_web.gyp[diff]
• ios/web/public/test/js_test_util.h[Added - diff]
• ios/web/public/test/js_test_util.mm[Added - diff]
• ios/web/public/url_scheme_util.h[Added - diff]
• ios/web/url_scheme_util.mm[Added - diff]
• ios/web/url_scheme_util_unittest.mm[Added - diff]

Use rect-circle hit testing for touch selection handles

Using a rect for the touch contact point can result in false positive
intersections with the touch selection handle. Instead, use a circular
representation of the touch contact point when hit testing.

Review URL: https://codereview.chromium.org/806303002

Cr-Commit-Position: refs/heads/master@{#308675}

• content/browser/android/composited_touch_handle_drawable.cc[diff]
• content/browser/android/composited_touch_handle_drawable.h[diff]
• content/browser/android/popup_touch_handle_drawable.cc[diff]
• content/browser/android/popup_touch_handle_drawable.h[diff]
• content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java[diff]
• ui/touch_selection/touch_handle.cc[diff]
• ui/touch_selection/touch_handle.h[diff]
• ui/touch_selection/touch_handle_unittest.cc[diff]
• ui/touch_selection/touch_selection_controller_unittest.cc[diff]

Add a license for third_party/ply/__init__.py.

Review URL: https://codereview.chromium.org/810633002

Cr-Commit-Position: refs/heads/master@{#308674}

• mojo/public/third_party/ply/README.chromium[diff]
• mojo/public/third_party/ply/__init__.py[diff]
• mojo/public/third_party/ply/license.patch[Added - diff]
• third_party/ply/README.chromium[diff]
• third_party/ply/__init__.py[diff]
• third_party/ply/license.patch[Added - diff]
• tools/checklicenses/checklicenses.py[diff]

More explicit thread checking in SafeBrowsingDatabase.

As part of trying to understand threading rules for SafeBrowsingDatabase
I added these explicit checks which helps documenting the expected flow.

Also replaced old checks with modern Chromium synchronization constructs
and explicitly mark SafeBrowsingStoreFile non-thread-safe.

These new checks helped catch issue 438754 and issue 442891.

More robust thread safety coming in https://codereview.chromium.org/790703003/

BUG=438754, 440517, 338486

Review URL: https://codereview.chromium.org/744183002

Cr-Commit-Position: refs/heads/master@{#308673}

• chrome/browser/safe_browsing/database_manager.cc[diff]
• chrome/browser/safe_browsing/safe_browsing_database.cc[diff]
• chrome/browser/safe_browsing/safe_browsing_database.h[diff]
• chrome/browser/safe_browsing/safe_browsing_database_unittest.cc[diff]
• chrome/browser/safe_browsing/safe_browsing_store_file.cc[diff]
• chrome/browser/safe_browsing/safe_browsing_store_file.h[diff]

Fix a race condition in SafeBrowsingDatabaseNew::IsCsdWhitelistKillSwitchOn()

Extracted from https://codereview.chromium.org/744183002/

TBR=mattm
BUG=442891

Review URL: https://codereview.chromium.org/793663003

Cr-Commit-Position: refs/heads/master@{#308672}

• chrome/browser/safe_browsing/safe_browsing_database.cc[diff]

cc: Stop passing layer bounds to PictureLayerTilingSet

Get the bounds from the RasterSource directly.

R=enne, vmpstr
BUG=387116

Review URL: https://codereview.chromium.org/810853002

Cr-Commit-Position: refs/heads/master@{#308671}

• cc/layers/picture_layer_impl.cc[diff]
• cc/resources/picture_layer_tiling.cc[diff]
• cc/resources/picture_layer_tiling.h[diff]
• cc/resources/picture_layer_tiling_set.cc[diff]
• cc/resources/picture_layer_tiling_set.h[diff]

Changed identification level to anonymous for windows IPC channel

This patch makes some changes to impersonation levels for pipes used
in IPC. It changes the default level for the IPC channel client to
use SECURITY_ANONYMOUS and also modified the sandbox's file policy
code to always pass a SecurityAnonymous QOS structure to all file
creations and opens. This was done to avoid modifying the IPC calls
themselves to add the QOS information. The aim of the patch is to
reduce the possibility of impersonation tokens leaking to less trusted
processes during normal operation.

This is a counterpart to CL 799943002

BUG=440694

Review URL: https://codereview.chromium.org/811763002

Cr-Commit-Position: refs/heads/master@{#308670}

• ipc/ipc_channel_win.cc[diff]

Windows 10/ MetroUI - Added validation for ui_channel during size change event.

With new StartChromeOSMode function we keep on retrying channel connection in
posted/delayed task. Meanwhile metro enviroment sends us size change, which we try
to pass-on ui_channel_ without validating.

BUG=440475
R=cpu, ananta

Review URL: https://codereview.chromium.org/809653002

Cr-Commit-Position: refs/heads/master@{#308669}

• win8/metro_driver/chrome_app_view_ash.cc[diff]

Move virtual setSurfaceReady to non-virtual StartCompositor.

This method is no longer part of the blink APIs that
RenderWidgetCompositor implements, so make it non-virtual and follow
chromium style.

Review URL: https://codereview.chromium.org/812553003

Cr-Commit-Position: refs/heads/master@{#308668}

• content/renderer/gpu/render_widget_compositor.cc[diff]
• content/renderer/gpu/render_widget_compositor.h[diff]
• content/renderer/render_widget.cc[diff]
• content/test/web_layer_tree_view_impl_for_testing.cc[diff]
• content/test/web_layer_tree_view_impl_for_testing.h[diff]
• mojo/services/html_viewer/weblayertreeview_impl.cc[diff]
• mojo/services/html_viewer/weblayertreeview_impl.h[diff]

session: Add callback-based notification for session restore

Part of the effort to remove NotificationService.

For now, the only observer of the notification that is
updated is perf_provider_chromeos. The other observers will
be updated later, and the old notification will be removed
at that point.

BUG=chromium:268984
TEST=none

Signed-off-by: Simon Que <[email protected]>

Review URL: https://codereview.chromium.org/795143003

Cr-Commit-Position: refs/heads/master@{#308667}

• chrome/browser/metrics/perf_provider_chromeos.cc[diff]
• chrome/browser/metrics/perf_provider_chromeos.h[diff]
• chrome/browser/sessions/session_restore.cc[diff]
• chrome/browser/sessions/session_restore.h[diff]

Change CHECK to DCHECK for crash due to touch exploration with eager GR.

TEST=manual testing to make sure no crash occurs.
BUG=442773

Review URL: https://codereview.chromium.org/805353002

Cr-Commit-Position: refs/heads/master@{#308666}

• ui/events/gesture_detection/touch_disposition_gesture_filter.cc[diff]

Changed YUV decoding enable flag to disable flag

GPU YUV decoding will now be ON by default, when GPU Rasterization is enabled. The most recent benchmarks show little to no difference on desktop, but significant improvements on Android, so this should be worth it. Also, currently, this change will only affect Android, on pages with the appropriate 'meta' tag.

BUG=413001,419718

Review URL: https://codereview.chromium.org/799463004

Cr-Commit-Position: refs/heads/master@{#308665}

• chrome/browser/chromeos/login/chrome_restart_request.cc[diff]
• content/browser/renderer_host/render_process_host_impl.cc[diff]
• content/child/runtime_features.cc[diff]
• content/public/common/content_switches.cc[diff]
• content/public/common/content_switches.h[diff]
• tools/perf/benchmarks/smoothness.py[diff]

Upstream Protected Content settings.

BUG=428869

Review URL: https://codereview.chromium.org/787133003

Cr-Commit-Position: refs/heads/master@{#308664}

• chrome/android/java/res/layout/preference_button.xml[Added - diff]
• chrome/android/java/res/xml/protected_content_preferences.xml[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/preferences/ButtonPreference.java[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentPreferences.java[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/preferences/ProtectedContentResetCredentialConfirmDialogFragment.java[Added - diff]
• chrome/android/java/src/org/chromium/chrome/browser/preferences/TextMessagePreference.java[Added - diff]
• chrome/android/java/strings/android_chrome_strings.grd[diff]

[Android] Add AppMenu touch duration metric.

We want to monitor touch duration on AppMenu to decide optimal timeout
for single tap vs dragging.

BUG=434501

Review URL: https://codereview.chromium.org/763253005

Cr-Commit-Position: refs/heads/master@{#308663}

• chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java[diff]
• chrome/browser/android/appmenu/app_menu_drag_helper.cc[Added - diff]
• chrome/browser/android/appmenu/app_menu_drag_helper.h[Added - diff]
• chrome/browser/android/chrome_jni_registrar.cc[diff]
• chrome/chrome_browser.gypi[diff]
• tools/metrics/histograms/histograms.xml[diff]

Fix race between SetVisible and CreateOutputSurface

If SetVisible(false) happens before a posted CreateOutputSurface, then
it can end up deferencing a null LayerTreeHost.  An early out avoids
this.

[email protected]
BUG=442359

Review URL: https://codereview.chromium.org/806053004

Cr-Commit-Position: refs/heads/master@{#308662}

• content/browser/renderer_host/compositor_impl_android.cc[diff]

Instrumenting URLRequestJob::ReadRawDataHelper for jank.

We know that URLRequestJob::ReadRawDataHelper causes 22.3 jph.
Instrumenting further.

BUG=423948

Review URL: https://codereview.chromium.org/808483004

Cr-Commit-Position: refs/heads/master@{#308661}

• net/url_request/url_request_job.cc[diff]

Revert of Make grit <include> de-duping clearer. (patchset #1 id:20001 of https://codereview.chromium.org/800043003/)

Reason for revert:
http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/9077

Original issue's description:
> Make grit <include> de-duping clearer.
>
> [email protected]
> BUG=none
> TEST=code is easier to read and more thoroughly tested
> NOTRY=true
>
> Committed: https://crrev.com/8963f1b0fa101c1bd3fea60c8bca46da2cf44d30
> Cr-Commit-Position: refs/heads/master@{#308658}

[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/803173005

Cr-Commit-Position: refs/heads/master@{#308660}

• third_party/closure_compiler/processor.py[diff]
• third_party/closure_compiler/processor_test.py[diff]

Instrumenting InitializeInternal to find jank.

Prior instrumentations showed that ProfileIOData::Init's jank happens in the call to InitializeInternal (8.6 jph).

Instrumenting InitializeInternal.

BUG=436671

Review URL: https://codereview.chromium.org/790853007

Cr-Commit-Position: refs/heads/master@{#308659}

• chrome/browser/profiles/off_the_record_profile_io_data.cc[diff]
• chrome/browser/profiles/profile_impl_io_data.cc[diff]

Make grit <include> de-duping clearer.

[email protected]
BUG=none
TEST=code is easier to read and more thoroughly tested
NOTRY=true

Review URL: https://codereview.chromium.org/800043003

Cr-Commit-Position: refs/heads/master@{#308658}

• third_party/closure_compiler/processor.py[diff]
• third_party/closure_compiler/processor_test.py[diff]

Revert of Suppress uninitialized read in drmemory bot (patchset #1 id:1 of https://codereview.chromium.org/802983003/)

Reason for revert:
The suppression will suppress almost all errors, and make Dr.Memory bots useless.
The bad callstack is caused by the VS producing corrupted pdb, clobber to builder.

Original issue's description:
> Suppress uninitialized read in drmemory bot
>
> BUG=442850
> [email protected]
> NOTRY=true
>
> Committed: https://crrev.com/2a589da939ba026ff87559885c1dc17ed236f89d
> Cr-Commit-Position: refs/heads/master@{#308648}

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=442850

Review URL: https://codereview.chromium.org/802983004

Cr-Commit-Position: refs/heads/master@{#308657}

• tools/valgrind/drmemory/suppressions_full.txt[diff]

easy-unlock: Use a dedicated UMA for missing screenlock state handler.

Password sign-in with service-not-active UMA number is too high. It is
currently counted with two events: service-not-active and missing screenlock
state handler. This CL use a dedicated UMA for the later case.

BUG=none.

Review URL: https://codereview.chromium.org/812633002

Cr-Commit-Position: refs/heads/master@{#308656}

• chrome/browser/chromeos/login/easy_unlock/easy_unlock_metrics.h[diff]
• chrome/browser/signin/easy_unlock_service_signin_chromeos.cc[diff]
• tools/metrics/histograms/histograms.xml[diff]

Roll src/third_party/WebKit 002ccb2:994eb22 (svn 187276:187283)

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/002ccb2..994eb22

[email protected],[email protected]

Review URL: https://codereview.chromium.org/804943004

Cr-Commit-Position: refs/heads/master@{#308655}

• DEPS[diff]

[Extensions Toolbar Mac] Fix BrowserActionsContainerView animationEndFrame.

It looks like, in completely undocumented behavior, the animator proxy for
NSViews does return the frame at the end of the animation for some systems, but
not others. Change the BrowserActionsContainerView to use a NSViewAnimation
instead to solve this.

BUG=442225

Review URL: https://codereview.chromium.org/798693005

Cr-Commit-Position: refs/heads/master@{#308654}

• chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h[diff]
• chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm[diff]
• chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm[diff]

Componentize AutocompleteSyncableService

Move AutocompleteSyncableService into autofill component and fix the
WebDataServiceWrapper initialization to start the syncable services
since it can now depend on them.

BUG=437508

Review URL: https://codereview.chromium.org/781793002

Cr-Commit-Position: refs/heads/master@{#308653}

• chrome/browser/sync/glue/autofill_data_type_controller.cc[diff]
• chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc[diff]
• chrome/browser/sync/profile_sync_components_factory_impl.cc[diff]
• chrome/browser/sync/profile_sync_service_autofill_unittest.cc[diff]
• chrome/browser/webdata/web_data_service_factory.cc[diff]
• chrome/browser/webdata/web_data_service_factory.h[diff]
• chrome/chrome_browser.gypi[diff]
• chrome/test/base/testing_profile.cc[diff]
• components/autofill.gypi[diff]
• components/autofill/core/browser/BUILD.gn[diff]
• components/autofill/core/browser/DEPS[diff]
• components/autofill/core/browser/webdata/autocomplete_syncable_service.cc[Renamed from chrome/browser/webdata/autocomplete_syncable_service.cc - diff]
• components/autofill/core/browser/webdata/autocomplete_syncable_service.h[Renamed from chrome/browser/webdata/autocomplete_syncable_service.h - diff]
• components/webdata_services.gypi[diff]
• components/webdata_services/BUILD.gn[diff]
• components/webdata_services/DEPS[diff]
• components/webdata_services/web_data_service_wrapper.cc[diff]
• components/webdata_services/web_data_service_wrapper.h[diff]

[telemetry] - Tear down replay server when browser is lost.

Speculative fix for crbug.com/439598. When browser is lost/crashes mid test, we don't unmap all the forwarded ports, and host_forwarder seems to get into a state where it can't communicate with the device anymore.

BUG=439598

Review URL: https://codereview.chromium.org/808803002

Cr-Commit-Position: refs/heads/master@{#308652}

• tools/telemetry/telemetry/core/browser.py[diff]
• tools/telemetry/telemetry/core/platform/platform_backend.py[diff]

Another attempt to fix the ContentAutofillDriver::DidNavigateFrame crash.

Since 2bab69317231378 didn't work, my theory is that some use of frame_driver_map_[] created a null entry. Eliminate the two places where that could occur.

Also expand the scope of the paper-over fix. If the crash disappears after this patch, we can try removing the paper-over.

BUG=438951
[email protected]

Review URL: https://codereview.chromium.org/793073004

Cr-Commit-Position: refs/heads/master@{#308651}

• components/autofill/content/browser/content_autofill_driver_factory.cc[diff]
• components/password_manager/content/browser/content_password_manager_driver_factory.cc[diff]

Switch calls of PageSet.AddPage to AddUserStory in DRP telemetry tests

After https://codereview.chromium.org/800863003/, PageSet.AddPage has
been removed in favor of PageSet.AddUserStory. This sudden removal
caused all the chrome-proxy tests to fail.

This change makes the DRP telemetry tests use PageSet.AddUserStory
instead of AddPage.

BUG=442820

Review URL: https://codereview.chromium.org/801783005

Cr-Commit-Position: refs/heads/master@{#308650}

• tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py[diff]
• tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/bypass.py[diff]
• tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/client_type.py[diff]
• tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/corsbypass.py[diff]
• tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/explicit_bypass.py[diff]
• tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/fallback_viaheader.py[diff]
• tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/http_to_direct_fallback.py[diff]
• tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py[diff]
• tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/smoke.py[diff]
• tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/synthetic.py[diff]
• tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/top_20.py[diff]

Fix releasing capture in Ozone

In CrOS Ozone, WindowTreeHost::SetCapture() is not a no-op (unlike CrOS X11).
This CL makes CaptureController::SetCapture() release capture on the
WindowTreeHost which has native capture regardless of which WindowTreeHost
the aura::Window with capture is currently in.

BUG=423383
TEST=None

Review URL: https://codereview.chromium.org/780273003

Cr-Commit-Position: refs/heads/master@{#308649}

• ui/views/views.gyp[diff]
• ui/wm/BUILD.gn[diff]
• ui/wm/core/capture_controller.cc[diff]
• ui/wm/core/capture_controller.h[diff]
• ui/wm/core/capture_controller_unittest.cc[Renamed from ui/views/corewm/capture_controller_unittest.cc - diff]
• ui/wm/wm.gyp[diff]

Suppress uninitialized read in drmemory bot

BUG=442850
[email protected]
NOTRY=true

Review URL: https://codereview.chromium.org/802983003

Cr-Commit-Position: refs/heads/master@{#308648}

• tools/valgrind/drmemory/suppressions_full.txt[diff]

[NetInfo] Add a MaxBandwidthChangeObserver and Android implementation

* Add a MaxBandwidthChangeObserver to NetworkChangeNotifier
* Android notifies of max bandwidth changes at two points:
 1. On connection type change (if the bandwidth changes)
 2. On wifi signal strength change

BUG=433370

Review URL: https://codereview.chromium.org/780293003

Cr-Commit-Position: refs/heads/master@{#308647}

• net/android/java/src/org/chromium/net/NetworkChangeNotifier.java[diff]
• net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java[diff]
• net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java[diff]
• net/android/network_change_notifier_android.cc[diff]
• net/android/network_change_notifier_android.h[diff]
• net/android/network_change_notifier_android_unittest.cc[diff]
• net/android/network_change_notifier_delegate_android.cc[diff]
• net/android/network_change_notifier_delegate_android.h[diff]
• net/base/network_change_notifier.cc[diff]
• net/base/network_change_notifier.h[diff]

Temporarily disable the flaky PasswordManagerBrowserTest.ReCreatedFormsGetFilled

This test has been reported as flaky on all platforms.

BUG=442704
[email protected]

Review URL: https://codereview.chromium.org/809813002

Cr-Commit-Position: refs/heads/master@{#308646}

• chrome/browser/password_manager/password_manager_browsertest.cc[diff]

Put screenshot.py back to work

build/android/screenshot.py does not work anymore if you have only one
device attached and do not specify device id.

Review URL: https://codereview.chromium.org/804963003

Cr-Commit-Position: refs/heads/master@{#308645}

• build/android/screenshot.py[diff]

Disable service_worker.service_worker_micro_benchmark

This test has been causing the waterfall on chromium.perf to go red. I couldn't
narrow it down to any CLs in the revision range.

BUG=442752
NOTRY=true
TBR=

Review URL: https://codereview.chromium.org/807843004

Cr-Commit-Position: refs/heads/master@{#308644}

• tools/perf/benchmarks/service_worker.py[diff]

Push API: Persist Sender ID to enable registration from workers

Unfortunately, until https://crbug.com/437677 is fixed, it's not possible to
actually register from a worker, so adding tests (and marking
https://crbug.com/437298 as fixed) is blocked on that.

BUG=437298

Review URL: https://codereview.chromium.org/807043003

Cr-Commit-Position: refs/heads/master@{#308643}

• chrome/browser/services/gcm/push_messaging_browsertest.cc[diff]
• content/browser/push_messaging/push_messaging_message_filter.cc[diff]
• content/browser/push_messaging/push_messaging_message_filter.h[diff]

Make about:credits' code a little bit spiffier.

[email protected]
BUG=none
TEST=no console errors nor eye burning

Review URL: https://codereview.chromium.org/803743002

Cr-Commit-Position: refs/heads/master@{#308642}

• chrome/browser/resources/about_credits.js[diff]
• chrome/browser/resources/about_credits.tmpl[diff]
• chrome/browser/ui/webui/about_ui.cc[diff]

Instrumenting TransportConnectJobHelper::DoLoop for jank

This TransportConnectJobHelper::DoLoop causes 9.1 jps, hence we need to instrument it.

BUG=436634

Review URL: https://codereview.chromium.org/811653002

Cr-Commit-Position: refs/heads/master@{#308641}

• net/socket/transport_client_socket_pool.cc[diff]

Roll src/third_party/skia 478dd72:3f801cb

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/478dd72..3f801cb

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]

Review URL: https://codereview.chromium.org/807153003

Cr-Commit-Position: refs/heads/master@{#308640}

• DEPS[diff]

ozone: layout: Add exports to layout_util

Some of these functions are used from the xkb unit test and need to be
exported.

BUG=none
TEST=build events_unittests with use_xkbcommon=1

Review URL: https://codereview.chromium.org/808823002

Cr-Commit-Position: refs/heads/master@{#308639}

• ui/events/ozone/layout/layout_util.h[diff]

[Extension Toolbar] Refactor and finish pop out logic for actions

* Pull out the logic to "pop out" actions when they want to act
  into a separate inner class of ToolbarActionsBar.
* Make unit tests for ToolbarActionsBar also test the overflow
  container.
* Turn off "popping out" actions by default.

UI has decided that, for the time being, we want to hold off
on popping out actions. Since this is still in heavy flux,
keep it in the code base (and tested) to prevent code rot.

BUG=417441

Review URL: https://codereview.chromium.org/766263003

Cr-Commit-Position: refs/heads/master@{#308638}

• chrome/browser/ui/cocoa/extensions/browser_actions_controller.h[diff]
• chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm[diff]
• chrome/browser/ui/cocoa/extensions/test_toolbar_actions_bar_helper_cocoa.mm[diff]
• chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm[diff]
• chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm[diff]
• chrome/browser/ui/toolbar/OWNERS[Added - diff]
• chrome/browser/ui/toolbar/test_toolbar_actions_bar_helper.h[diff]
• chrome/browser/ui/toolbar/toolbar_actions_bar.cc[diff]
• chrome/browser/ui/toolbar/toolbar_actions_bar.h[diff]
• chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc[diff]
• chrome/browser/ui/views/toolbar/OWNERS[Added - diff]
• chrome/browser/ui/views/toolbar/browser_actions_container.cc[diff]
• chrome/browser/ui/views/toolbar/test_toolbar_actions_bar_helper_views.cc[diff]

Move Syzygy build related things to their own directory with an OWNERS file, and add an allocation filter file.

BUG=

Review URL: https://codereview.chromium.org/773253004

Cr-Commit-Position: refs/heads/master@{#308637}

• chrome/chrome_syzygy.gypi[diff]
• chrome/tools/build/win/OWNERS[diff]
• chrome/tools/build/win/syzygy/OWNERS[Added - diff]
• chrome/tools/build/win/syzygy/instrument.py[Renamed from chrome/tools/build/win/syzygy_instrument.py - diff]
• chrome/tools/build/win/syzygy/reorder.py[Renamed from chrome/tools/build/win/syzygy_reorder.py - diff]
• chrome/tools/build/win/syzygy/syzyasan-allocation-filter.txt[Added - diff]
• chrome/tools/build/win/syzygy/syzyasan-instrumentation-filter.txt[Renamed from chrome/tools/build/win/win-syzyasan-filter.txt - diff]
• content/content_shell.gypi[diff]
• pdf/pdf.gyp[diff]

Revert "Use the libc clone wrapper in sys_clone."

This reverts commit d8a593bceaf0a4b38d06a8c13b948202d205f1b6.
Reason for revert: see crbug.com/442817

> Previously, we directly invoked the syscall, which would not update
> libc's PID cache in the child. Although the libc wrapper function
> updates the PID cache, it unfortunately requires that the child run on a
> different stack, even if CLONE_VM is not specified. We work around this
> by briefly switching stacks in the child, then using longjmp to switch
> back. This gives us a version of clone with fork-like behavior, which is
> what we need for starting processes in new namespaces.
>
> BUG=312380
> Committed: https://crrev.com/d8a593bceaf0a4b38d06a8c13b948202d205f1b6
> Cr-Commit-Position: refs/heads/master@{#308510}

BUG=312380, 442817
[email protected]

Review URL: https://codereview.chromium.org/807213002

Cr-Commit-Position: refs/heads/master@{#308636}

• sandbox/linux/services/syscall_wrappers.cc[diff]
• sandbox/linux/services/syscall_wrappers.h[diff]
• sandbox/linux/services/syscall_wrappers_unittest.cc[diff]

Move IDS_PASSWORD_MANAGER_EMPTY_LOGIN to component resources

The string "(No username)" is currently used in the password manager bubble, but became useful also for password-field suggestions introduced by https://codereview.chromium.org/773573004/.

This CL ensures, that when a user gets a suggestions pop-up in a password field, and has an empty username saved with a password, the suggestion explicitly mentions the username is missing, instead of displaying a blank suggestion. This is consistent with the bubble.

As a side-effect, the corresponding string is moved from chrome to components resources.

BUG=442191,410963
[email protected]

Review URL: https://codereview.chromium.org/785233009

Cr-Commit-Position: refs/heads/master@{#308635}

• build/ios/grit_whitelist.txt[diff]
• chrome/app/generated_resources.grd[diff]
• chrome/browser/ui/cocoa/passwords/manage_password_item_view_controller.mm[diff]
• chrome/browser/ui/views/passwords/manage_password_items_view.cc[diff]
• components/components_strings.grd[diff]
• components/password_manager.gypi[diff]
• components/password_manager/core/browser/DEPS[diff]
• components/password_manager/core/browser/password_autofill_manager.cc[diff]
• components/password_manager_strings.grdp[Added - diff]

Exclude failing DisplayInfoProviderChromeosTest on chromeos bot

BUG=442834
[email protected]
NOTRY=true

Review URL: https://codereview.chromium.org/810863002

Cr-Commit-Position: refs/heads/master@{#308634}

• tools/valgrind/gtest_exclude/unit_tests.gtest_linux.txt[diff]

[Extensions] Improve access safety for injecting extension scripts.

Since extension scripts can block and cause a nested message loop, it's possible
for the list of pending injections to be modified while we're traversing it (if,
e.g., an extension is reloaded). Protected against this.

BUG=401701

Review URL: https://codereview.chromium.org/807693002

Cr-Commit-Position: refs/heads/master@{#308633}

• extensions/renderer/script_injection_manager.cc[diff]
• extensions/renderer/script_injection_manager.h[diff]
• extensions/renderer/user_script_set.h[diff]
• extensions/renderer/user_script_set_manager.h[diff]

[chromedriver] testDownloadDirectoryOverridesExistingPreferences is flaky
BUG=chromedriver:992

Review URL: https://codereview.chromium.org/805913003

Cr-Commit-Position: refs/heads/master@{#308632}

• chrome/test/chromedriver/test/run_py_tests.py[diff]

Wait for cryptohomed before showing enable-dev-features UI.

Enabling debug features requires cryptohomed to be ready so wait
on it as well.

BUG=440506

Review URL: https://codereview.chromium.org/797053003

Cr-Commit-Position: refs/heads/master@{#308631}

• chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc[diff]
• chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.h[diff]

[Hotword, Audio] Remove bad include that was not needed and caused compile error.

BUG=442640
[email protected]

Review URL: https://codereview.chromium.org/805333002

Cr-Commit-Position: refs/heads/master@{#308630}

• media/audio/cras/cras_input.cc[diff]

Revert of [Ozone-Demo] Extract rendering parts into separate renderer classes (patchset #1 id:1 of https://codereview.chromium.org/805843003/)

Reason for revert:
Broke Linux compile (unused vbl): http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/8640/steps/compile/logs/stdio

FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ui/ozone/demo/ozone_demo.ozone_demo.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=223108 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_OZONE=1 -DUSE_DEFAULT_RENDER_THEME=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DUSE_UDEV -DDONT_EMBED_BUILD_METADATA -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_TEXTRENDERMODE -DSK_IGNORE_GPU_LAYER_HOISTING -DSK_SUPPORT_LEGACY_NewRasterPMColor -DSK_LEGACY_ENCODE_BITMAP -DSK_USE_POSIX_THREADS -DMESA_EGL_NO_X11_HEADERS -DUSE_LIBPCI=1 -DUSE_NSS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -Igen/ui/gl -I../../third_party/mesa/src/include -Werror -pthread -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ChromiumOS_Ozone_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11  -c ../../ui/ozone/demo/ozone_demo.cc -o obj/ui/ozone/demo/ozone_demo.ozone_demo.o
../../ui/ozone/demo/ozone_demo.cc:25:11: error: unused variable 'kAnimationSteps' [-Werror,-Wunused-const-variable]
const int kAnimationSteps = 240;
          ^
1 error generated.
ninja: build stopped: subcommand failed.

Original issue's description:
> [Ozone-Demo] Extract rendering parts into separate renderer classes
>
> Makes it easier to abstract the part that renders to buffers and add
> new ones.
>
> BUG=none
> NOTRY=true
>
> Committed: https://crrev.com/c0411a00aebc99400e293fd9beca14d1acb6d4af
> Cr-Commit-Position: refs/heads/master@{#308613}

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/808553005

Cr-Commit-Position: refs/heads/master@{#308629}

• ui/ozone/demo/BUILD.gn[diff]
• ui/ozone/demo/gl_renderer.cc[Deleted - diff]
• ui/ozone/demo/gl_renderer.h[Deleted - diff]
• ui/ozone/demo/ozone_demo.cc[diff]
• ui/ozone/demo/ozone_demos.gyp[diff]
• ui/ozone/demo/renderer.h[Deleted - diff]
• ui/ozone/demo/renderer_base.cc[Deleted - diff]
• ui/ozone/demo/renderer_base.h[Deleted - diff]
• ui/ozone/demo/software_renderer.cc[Deleted - diff]
• ui/ozone/demo/software_renderer.h[Deleted - diff]

Mac: Fix for key up events not getting forwarded to web contents.

This was broken by https://codereview.chromium.org/740533003.
It only keeps track of the last key code, so it doesn't properly handle the case
where multiple keys are down simultaneously.
Fixed by keeping track of all key down codes using a set.

BUG=439934

Review URL: https://codereview.chromium.org/805823003

Cr-Commit-Position: refs/heads/master@{#308628}

• content/browser/renderer_host/render_widget_host_view_mac.h[diff]
• content/browser/renderer_host/render_widget_host_view_mac.mm[diff]

No longer do the libudev loading hack in MSan builds.

Our LKGR builders have been upgraded to Trusty, so we no longer need this.

BUG=438427
[email protected]

Review URL: https://codereview.chromium.org/807203002

Cr-Commit-Position: refs/heads/master@{#308627}

• device/udev_linux/udev0_loader.cc[diff]
• device/udev_linux/udev_loader.cc[diff]

Pass CastMetricsServiceClient to CastService instead of OptIn callback.

1) Split ctor and init of CastMetricsServiceClient.
2) Specify CastService's dependency on CastMetricsServiceClient clearly.
3) Call FinalizeInternal in CastService::Stop.

BUG=

Review URL: https://codereview.chromium.org/807603004

Cr-Commit-Position: refs/heads/master@{#308626}

• chromecast/browser/cast_browser_main_parts.cc[diff]
• chromecast/browser/metrics/cast_metrics_service_client.cc[diff]
• chromecast/browser/metrics/cast_metrics_service_client.h[diff]
• chromecast/browser/metrics/platform_metrics_providers.h[diff]
• chromecast/browser/metrics/platform_metrics_providers_simple.cc[diff]
• chromecast/browser/service/cast_service.cc[diff]
• chromecast/browser/service/cast_service.h[diff]
• chromecast/browser/service/cast_service_android.cc[diff]
• chromecast/browser/service/cast_service_android.h[diff]
• chromecast/browser/service/cast_service_simple.cc[diff]
• chromecast/browser/service/cast_service_simple.h[diff]

Autofill - Add (failing) test case for mobile LL Bean checkout.

BUG=442552

Review URL: https://codereview.chromium.org/805713007

Cr-Commit-Position: refs/heads/master@{#308625}

• chrome/browser/autofill/form_structure_browsertest.cc[diff]
• chrome/test/data/autofill/heuristics/input/25_checkout_m_llbean.com.html[Added - diff]
• chrome/test/data/autofill/heuristics/output/25_checkout_m_llbean.com.out[Added - diff]

Add device policy to disallow shutdown

This CL introduces a new boolean device policy kDeviceShutdownIsReboot.

BUG=312541
TESTS=unit_tests

Review URL: https://codereview.chromium.org/776093004

Cr-Commit-Position: refs/heads/master@{#308624}

• ash/metrics/user_metrics_recorder.cc[diff]
• ash/metrics/user_metrics_recorder.h[diff]
• ash/test/test_lock_state_controller_delegate.cc[diff]
• ash/test/test_lock_state_controller_delegate.h[diff]
• ash/wm/lock_state_controller.cc[diff]
• ash/wm/lock_state_controller.h[diff]
• ash/wm/lock_state_controller_unittest.cc[diff]
• ash/wm/power_button_controller.cc[diff]
• chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc[diff]
• chrome/browser/chromeos/policy/proto/chrome_device_policy.proto[diff]
• chrome/browser/chromeos/power/session_state_controller_delegate_chromeos.cc[diff]
• chrome/browser/chromeos/power/session_state_controller_delegate_chromeos.h[diff]
• chrome/browser/chromeos/settings/device_settings_provider.cc[diff]
• chrome/browser/ui/ash/system_tray_delegate_chromeos.cc[diff]
• chrome/browser/ui/webui/chromeos/login/shutdown_policy_observer.cc[Added - diff]
• chrome/browser/ui/webui/chromeos/login/shutdown_policy_observer.h[Added - diff]
• chrome/browser/ui/webui/chromeos/login/shutdown_policy_observer_unittest.cc[Added - diff]
• chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc[diff]
• chrome/chrome_browser_ui.gypi[diff]
• chrome/chrome_tests_unit.gypi[diff]
• chrome/test/data/policy/policy_test_cases.json[diff]
• chromeos/settings/cros_settings_names.cc[diff]
• chromeos/settings/cros_settings_names.h[diff]
• components/policy/resources/policy_templates.json[diff]
• tools/metrics/actions/actions.xml[diff]
• tools/metrics/histograms/histograms.xml[diff]

Roll src/third_party/WebKit 41076b8:002ccb2 (svn 187267:187276)

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/41076b8..002ccb2

[email protected],[email protected]

Review URL: https://codereview.chromium.org/798383004

Cr-Commit-Position: refs/heads/master@{#308623}

• DEPS[diff]

Move mojo gypfiles to toplevel mojo

These files are owned by chromium now. It would not only be weird
to inject them into the rolled mojo directory structure, but doing
so would unnecessarily complicate the mojo up-rev procedure.

BUG=None

[email protected]

Review URL: https://codereview.chromium.org/807773002

Cr-Commit-Position: refs/heads/master@{#308622}

• build/all.gyp[diff]
• chrome/chrome_browser.gypi[diff]
• chrome/chrome_browser_ui.gypi[diff]
• chrome/chrome_tests_unit.gypi[diff]
• chrome/chrome_web_ui_mojo_bindings.gyp[diff]
• content/content.gyp[diff]
• content/content_app.gypi[diff]
• content/content_browser.gypi[diff]
• content/content_common.gypi[diff]
• content/content_common_mojo_bindings.gyp[diff]
• content/content_renderer.gypi[diff]
• content/content_tests.gypi[diff]
• device/battery/battery.gyp[diff]
• device/device_tests.gyp[diff]
• device/serial/serial.gyp[diff]
• device/vibration/vibration.gyp[diff]
• extensions/extensions.gyp[diff]
• extensions/shell/app_shell.gyp[diff]
• ipc/mojo/ipc_mojo.gyp[diff]
• mojo/edk/mojo_edk.gyp[Deleted - diff]
• mojo/edk/mojo_edk_system_impl.gypi[Deleted - diff]
• mojo/edk/mojo_edk_tests.gyp[Deleted - diff]
• mojo/mojo.gyp[diff]
• mojo/mojo_base.gyp[diff]
• mojo/mojo_edk.gyp[Added - diff]
• mojo/mojo_edk_system_impl.gypi[Added - diff]
• mojo/mojo_edk_tests.gyp[Added - diff]
• mojo/mojo_geometry_converters.gyp[diff]
• mojo/mojo_input_events_converters.gyp[diff]
• mojo/mojo_nacl.gyp[diff]
• mojo/mojo_public.gyp[Added - diff]
• mojo/mojo_services_public.gyp[Added - diff]
• mojo/mojo_variables.gypi[diff]
• mojo/mojom_bindings_generator.gypi[Renamed from mojo/public/tools/bindings/mojom_bindings_generator.gypi - diff]
• mojo/mojom_bindings_generator_explicit.gypi[Renamed from mojo/public/tools/bindings/mojom_bindings_generator_explicit.gypi - diff]
• mojo/mojom_bindings_generator_variables.gypi[Renamed from mojo/public/tools/bindings/mojom_bindings_generator_variables.gypi - diff]
• mojo/public/mojo_public.gyp[Deleted - diff]
• mojo/services/public/mojo_services_public.gyp[Deleted - diff]
• ui/keyboard/keyboard.gyp[diff]

Disable MediaSource renderer

MediaSource rendering is not reliable in the remoting client.
The plan is to replace it with a new renderer that uses
Pepper decode API. This CL disables it, I'm going to remove
it completely later.

BUG=440922
[email protected]

Review URL: https://codereview.chromium.org/803523004

Cr-Commit-Position: refs/heads/master@{#308621}

• remoting/webapp/crd/js/client_session.js[diff]

Move Chromium Ozone tests to swarming.

BUG=chromium:440882
TEST=None

Review URL: https://codereview.chromium.org/789373003

Cr-Commit-Position: refs/heads/master@{#308620}

• testing/buildbot/chromium.chromiumos.json[diff]

Revert of Report PasswordManager.OsPasswordStatus on a background thread with a delay. (patchset #1 id:1 of https://codereview.chromium.org/800723004/)

Reason for revert:
Reverting because DCHECK is hit 40s after startup.

Original issue's description:
> Report PasswordManager.OsPasswordStatus on a background thread with a delay.
>
> The histogram was revived in https://codereview.chromium.org/772413004/ but caused jankiness on the UI thread.
>
> BUG=441428
>
> Committed: https://crrev.com/08cd707154a8b1ca7869c5b410d98acb8a6ed3e7
> Cr-Commit-Position: refs/heads/master@{#308128}

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=441428

Review URL: https://codereview.chromium.org/802923003

Cr-Commit-Position: refs/heads/master@{#308619}

• chrome/browser/password_manager/chrome_password_manager_client.cc[diff]
• chrome/browser/password_manager/password_store_factory.cc[diff]

Isolate ui_touch_selection_unittests

It was added to ui/ while I isolated all other unittests in ui/

BUG=98637
[email protected]

Review URL: https://codereview.chromium.org/794903004

Cr-Commit-Position: refs/heads/master@{#308618}

• testing/buildbot/chromium.linux.json[diff]
• testing/buildbot/chromium_trybot.json[diff]
• ui/touch_selection/ui_touch_selection.gyp[diff]
• ui/touch_selection/ui_touch_selection_unittests.isolate[Added - diff]

Using chromium API keys in DevTools bridge.

In DevTools bridge API keys and secrets used to be hardcoded (as a temporary solution for simplicity).
Now we need to use regular API key retreiving mechaninsm to be able to make the DevTools bridge working in Clank.

Hardcoded keys will be revoked after commiting this CL.

BUG=383418

Review URL: https://codereview.chromium.org/806803002

Cr-Commit-Position: refs/heads/master@{#308617}

• components/devtools_bridge.gyp[diff]
• components/devtools_bridge/DEPS[diff]
• components/devtools_bridge/android/apiary_client_factory.cc[Added - diff]
• components/devtools_bridge/android/apiary_client_factory.h[Added - diff]
• components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/apiary/ApiaryClientFactory.java[diff]
• components/devtools_bridge/test/android/javatests/jni/jni_onload.cc[diff]
• components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/apiary/TestApiaryClientFactory.java[diff]
• google_apis/google_apis.gyp[diff]

Catch failure to capture collection information from IOHIDDevice.

This is another case where OS X can report failure and we do not
properly check the return code from an IOHIDDevice function before using
the value.

BUG=442360

Review URL: https://codereview.chromium.org/807063002

Cr-Commit-Position: refs/heads/master@{#308616}

• device/hid/hid_service_mac.cc[diff]

Introduce CompositorDependencies for RenderWidgetCompositor.

This interface provides whatever RenderWidgetCompositor requires
instead of going directly to RenderThreadImpl which may or may not
exist in tests.

[email protected]
BUG=384381

Review URL: https://codereview.chromium.org/801973002

Cr-Commit-Position: refs/heads/master@{#308615}

• cc/BUILD.gn[diff]
• cc/cc_tests.gyp[diff]
• cc/resources/resource_provider.cc[diff]
• cc/test/fake_external_begin_frame_source.cc[Added - diff]
• cc/test/fake_external_begin_frame_source.h[Added - diff]
• cc/test/layer_tree_test.cc[diff]
• cc/test/layer_tree_test.h[diff]
• content/content_renderer.gypi[diff]
• content/content_tests.gypi[diff]
• content/public/test/render_view_test.cc[diff]
• content/public/test/render_view_test.h[diff]
• content/renderer/gpu/compositor_dependencies.h[Added - diff]
• content/renderer/gpu/compositor_external_begin_frame_source.cc[diff]
• content/renderer/gpu/compositor_external_begin_frame_source.h[diff]
• content/renderer/gpu/render_widget_compositor.cc[diff]
• content/renderer/gpu/render_widget_compositor.h[diff]
• content/renderer/gpu/render_widget_compositor_unittest.cc[diff]
• content/renderer/render_frame_impl.cc[diff]
• content/renderer/render_thread_impl.cc[diff]
• content/renderer/render_thread_impl.h[diff]
• content/renderer/render_view_impl.cc[diff]
• content/renderer/render_view_impl.h[diff]
• content/renderer/render_widget.cc[diff]
• content/renderer/render_widget.h[diff]
• content/renderer/render_widget_fullscreen.cc[diff]
• content/renderer/render_widget_fullscreen.h[diff]
• content/renderer/render_widget_fullscreen_pepper.cc[diff]
• content/renderer/render_widget_fullscreen_pepper.h[diff]
• content/test/fake_compositor_dependencies.cc[Added - diff]
• content/test/fake_compositor_dependencies.h[Added - diff]
• content/test/fake_renderer_scheduler.cc[Added - diff]
• content/test/fake_renderer_scheduler.h[Added - diff]

cc: Remove the PostCommitInitialization from PictureLayerImpl.

This code no longer does anything at all, except track a bool that says
if we should do it. So let's remove it!

BUG=387116

Review URL: https://codereview.chromium.org/807193002

Cr-Commit-Position: refs/heads/master@{#308614}

• cc/layers/picture_image_layer_impl_unittest.cc[diff]
• cc/layers/picture_layer_impl.cc[diff]
• cc/layers/picture_layer_impl.h[diff]
• cc/layers/picture_layer_impl_perftest.cc[diff]
• cc/layers/picture_layer_impl_unittest.cc[diff]
• cc/resources/tile_manager_perftest.cc[diff]
• cc/resources/tile_manager_unittest.cc[diff]
• cc/test/fake_picture_layer_impl.h[diff]
• cc/trees/layer_tree_host_impl_unittest.cc[diff]

[Ozone-Demo] Extract rendering parts into separate renderer classes

Makes it easier to abstract the part that renders to buffers and add
new ones.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/805843003

Cr-Commit-Position: refs/heads/master@{#308613}

• ui/ozone/demo/BUILD.gn[diff]
• ui/ozone/demo/gl_renderer.cc[Added - diff]
• ui/ozone/demo/gl_renderer.h[Added - diff]
• ui/ozone/demo/ozone_demo.cc[diff]
• ui/ozone/demo/ozone_demos.gyp[diff]
• ui/ozone/demo/renderer.h[Added - diff]
• ui/ozone/demo/renderer_base.cc[Added - diff]
• ui/ozone/demo/renderer_base.h[Added - diff]
• ui/ozone/demo/software_renderer.cc[Added - diff]
• ui/ozone/demo/software_renderer.h[Added - diff]

Password Manager: Fix 'Show' button margin.

Blink r176850 [1] removed intrinsic margin for form controls without explit
sizes. The 'Show' button relied on the intrinsic margin.

[1] http://src.chromium.org/viewvc/blink?revision=176850&view=revision

BUG=430022

Review URL: https://codereview.chromium.org/806723002

Cr-Commit-Position: refs/heads/master@{#308612}

• chrome/browser/resources/options/password_manager_list.css[diff]

app_shell: Move chrome.audio extensions API to //extensions

This allows app_shell to use chrome.audio. Extend the stub PrefHandler
to support get/set of volume so the audio API tests still pass. In a
later CL the audio code will be refactored to allow app_shell to use the
real AudioDevicePrefHandler.

BUG=442401
TEST=app_shell_browsertests AudioApiTest

Review URL: https://codereview.chromium.org/804173003

Cr-Commit-Position: refs/heads/master@{#308611}

• chrome/browser/extensions/BUILD.gn[diff]
• chrome/browser/extensions/api/audio/audio_apitest.cc[Deleted - diff]
• chrome/browser/extensions/browser_context_keyed_service_factories.cc[diff]
• chrome/chrome_browser_extensions.gypi[diff]
• chrome/chrome_tests.gypi[diff]
• chrome/common/extensions/api/_api_features.json[diff]
• chrome/common/extensions/api/_permission_features.json[diff]
• chrome/common/extensions/api/schemas.gypi[diff]
• chrome/common/extensions/permissions/chrome_api_permissions.cc[diff]
• extensions/browser/BUILD.gn[diff]
• extensions/browser/DEPS[diff]
• extensions/browser/api/audio/OWNERS[Renamed from chrome/browser/extensions/api/audio/OWNERS - diff]
• extensions/browser/api/audio/audio_api.cc[Renamed from chrome/browser/extensions/api/audio/audio_api.cc - diff]
• extensions/browser/api/audio/audio_api.h[Renamed from chrome/browser/extensions/api/audio/audio_api.h - diff]
• extensions/browser/api/audio/audio_apitest.cc[Added - diff]
• extensions/browser/api/audio/audio_service.cc[Renamed from chrome/browser/extensions/api/audio/audio_service.cc - diff]
• extensions/browser/api/audio/audio_service.h[Renamed from chrome/browser/extensions/api/audio/audio_service.h - diff]
• extensions/browser/api/audio/audio_service_chromeos.cc[Renamed from chrome/browser/extensions/api/audio/audio_service_chromeos.cc - diff]
• extensions/browser/api/audio/audio_service_linux.cc[Renamed from chrome/browser/extensions/api/audio/audio_service_linux.cc - diff]
• extensions/browser/browser_context_keyed_service_factories.cc[diff]
• extensions/common/api/_api_features.json[diff]
• extensions/common/api/_permission_features.json[diff]
• extensions/common/api/audio.idl[Renamed from chrome/common/extensions/api/audio.idl - diff]
• extensions/common/api/schemas.gypi[diff]
• extensions/common/permissions/extensions_api_permissions.cc[diff]
• extensions/extensions.gyp[diff]
• extensions/shell/app_shell.gyp[diff]
• extensions/shell/browser/shell_audio_controller_chromeos.cc[diff]
• extensions/shell/browser/shell_audio_controller_chromeos.h[diff]
• extensions/shell/browser/shell_browser_main_parts.cc[diff]
• extensions/test/data/api_test/audio/manifest.json[Renamed from chrome/test/data/extensions/api_test/audio/manifest.json - diff]
• extensions/test/data/api_test/audio/test.js[Renamed from chrome/test/data/extensions/api_test/audio/test.js - diff]

cc: Only show GPU status if fps or paint time is up

The GPU status is currently showing if "Show paint rectangles" or
"Show potential scroll bottlenecks" is up, but was only meant to
be displayed for the fps and paint time meters.

This was caused by my previous change:
https://codereview.chromium.org/774943005

BUG=

Review URL: https://codereview.chromium.org/805293002

Cr-Commit-Position: refs/heads/master@{#308610}

• cc/layers/heads_up_display_layer_impl.cc[diff]

Roll src/third_party/skia 9a5380d:478dd72

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9a5380d..478dd72

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]

Review URL: https://codereview.chromium.org/807163002

Cr-Commit-Position: refs/heads/master@{#308609}

• DEPS[diff]

Revert of Revert of telemetry: Clean up SurfaceFlinger statistics (patchset #1 id:1 of https://codereview.chromium.org/809753002/)

Reason for revert:
Relanding, this patch was not the culprit. Sorry.

Original issue's description:
> Revert of telemetry: Clean up SurfaceFlinger statistics (patchset #8 id:140001 of https://codereview.chromium.org/765773004/)
>
> Reason for revert:
> Perf sheriff here, speculatively reverting due to crbug.com/442752, it shows up in many blamelists (but not all as the test wasn't running due to another bug). Sorry if unrelated.
>
> Original issue's description:
> > PERF-SHERIFFS: This patch will change all smoothness and SurfaceFlinger metrics on Android. Some metrics may go up or down significantly, with the new values being more accurate.
> >
> > This patch cleans up the integration of SurfaceFlinger statistics by pulling the
> > raw timestamps into the timeline and calculating all metrics in
> > SmoothnessMetric. This approach also improves the metrics, because the
> > timeline ranges can now be properly bounded (no more percentiles!) and the
> > existing smoothness metrics can also use the more accurate SurfaceFlinger
> > timestamps.
> >
> > BUG=351916
> >
> > Committed: https://crrev.com/ebae600f54ed1e77eeba916635310fb176c0fb6c
> > Cr-Commit-Position: refs/heads/master@{#308488}
>
> [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
> NOTREECHECKS=true
> NOTRY=true
> BUG=351916
>
> Committed: https://crrev.com/3dfc4e90757197efe0855fd4889d32bc52cb4cf9
> Cr-Commit-Position: refs/heads/master@{#308594}

[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=351916

Review URL: https://codereview.chromium.org/804413002

Cr-Commit-Position: refs/heads/master@{#308608}

• build/android/pylib/perf/surface_stats_collector.py[diff]
• build/android/surface_stats.py[Deleted - diff]
• tools/perf/measurements/smoothness_controller.py[diff]
• tools/perf/measurements/smoothness_unittest.py[diff]
• tools/telemetry/telemetry/core/platform/__init__.py[diff]
• tools/telemetry/telemetry/core/platform/android_platform_backend.py[diff]
• tools/telemetry/telemetry/core/platform/cros_platform_backend.py[diff]
• tools/telemetry/telemetry/core/platform/ios_platform_backend.py[diff]
• tools/telemetry/telemetry/core/platform/linux_platform_backend.py[diff]
• tools/telemetry/telemetry/core/platform/linux_platform_backend_unittest.py[diff]
• tools/telemetry/telemetry/core/platform/mac_platform_backend.py[diff]
• tools/telemetry/telemetry/core/platform/platform_backend.py[diff]
• tools/telemetry/telemetry/core/platform/win_platform_backend.py[diff]
• tools/telemetry/telemetry/timeline/model.py[diff]
• tools/telemetry/telemetry/timeline/surface_flinger_importer.py[Added - diff]
• tools/telemetry/telemetry/timeline/surface_flinger_timeline_data.py[Added - diff]
• tools/telemetry/telemetry/web_perf/metrics/rendering_stats.py[diff]
• tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py[diff]
• tools/telemetry/telemetry/web_perf/metrics/smoothness.py[diff]
• tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py[diff]

Replaced @benchmark.Enabled/Disabled and @test.Enabled/Disabled with @decorators.Enabled/Disabled in all unit tests

BUG=

Review URL: https://codereview.chromium.org/797003002

Cr-Commit-Position: refs/heads/master@{#308607}

• tools/perf/measurements/oilpan_gc_times_unittest.py[diff]
• tools/perf/measurements/rasterize_and_record_micro_unittest.py[diff]
• tools/perf/measurements/record_per_area_unittest.py[diff]
• tools/perf/measurements/repaint_unittest.py[diff]
• tools/perf/measurements/skpicture_printer_unittest.py[diff]
• tools/perf/measurements/smoothness_unittest.py[diff]
• tools/perf/measurements/thread_times_unittest.py[diff]
• tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py[diff]
• tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder_unittest.py[diff]
• tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py[diff]
• tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory_unittest.py[diff]
• tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_network_unittest.py[diff]
• tools/telemetry/telemetry/core/bitmap_unittest.py[diff]
• tools/telemetry/telemetry/core/browser_unittest.py[diff]
• tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py[diff]
• tools/telemetry/telemetry/core/platform/cros_interface_unittest.py[diff]
• tools/telemetry/telemetry/core/platform/mac_platform_backend_unittest.py[diff]
• tools/telemetry/telemetry/core/platform/platform_backend_unittest.py[diff]
• tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py[diff]
• tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py[diff]
• tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py[diff]
• tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler_unittest.py[diff]
• tools/telemetry/telemetry/core/platform/profiler/vtune_profiler_unittest.py[diff]
• tools/telemetry/telemetry/core/tab_unittest.py[diff]
• tools/telemetry/telemetry/core/video_unittest.py[diff]
• tools/telemetry/telemetry/page/actions/action_runner_unittest.py[diff]
• tools/telemetry/telemetry/page/actions/scroll_unittest.py[diff]
• tools/telemetry/telemetry/page/page_test_unittest.py[diff]
• tools/telemetry/telemetry/unittest_util/disabled_cases.py[diff]
• tools/telemetry/telemetry/unittest_util/test.py[Deleted - diff]
• tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py[diff]

Roll src/third_party/WebKit 90948d3:41076b8 (svn 187257:187267)

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/90948d3..41076b8

[email protected],[email protected]

Review URL: https://codereview.chromium.org/804393002

Cr-Commit-Position: refs/heads/master@{#308606}

• DEPS[diff]

Parse stdout results of gtest run on remote device

BUG=428729

Review URL: https://codereview.chromium.org/802203003

Cr-Commit-Position: refs/heads/master@{#308605}

• build/android/pylib/remote/device/remote_device_gtest_run.py[diff]
• build/android/pylib/remote/device/remote_device_test_run.py[diff]

[Installer] Moving GetRegistrationDataCommandKey() to setup_util.

This is a small refactoring that's needed for removal of legacy App Launcher
installer code (will need to use GetRegistrationDataCommandKey outside of
install_workers.cc).

Review URL: https://codereview.chromium.org/800353002

Cr-Commit-Position: refs/heads/master@{#308604}

• chrome/installer/setup/install_worker.cc[diff]
• chrome/installer/setup/setup_util.cc[diff]
• chrome/installer/setup/setup_util.h[diff]
• chrome/installer/setup/setup_util_unittest.cc[diff]

Filtering devtools bridge instances.

Device filtering was postponed task in https://codereview.chromium.org/784523002/

Previoudly we showed all GDC instances as remote chrome instances. This CL adds filtering based
on exposed commands. Only devices capable of establishing WebRTC session for remote debugging
comes to the list.

BUG=383418

Review URL: https://codereview.chromium.org/803503002

Cr-Commit-Position: refs/heads/master@{#308603}

• chrome/browser/devtools/BUILD.gn[diff]
• chrome/browser/devtools/device/webrtc/devtools_bridge_client.cc[diff]
• chrome/browser/devtools/device/webrtc/devtools_bridge_client.h[diff]
• chrome/browser/devtools/device/webrtc/devtools_bridge_instances_request.cc[Added - diff]
• chrome/browser/devtools/device/webrtc/devtools_bridge_instances_request.h[Added - diff]
• chrome/browser/devtools/device/webrtc/devtools_bridge_instances_request_unittest.cc[Added - diff]
• chrome/chrome_debugger.gypi[diff]
• chrome/chrome_tests_unit.gypi[diff]
• chrome/test/data/devtools/webrtc_device_provider/devtools_bridge_instances_response.json[Added - diff]

Fix URL constants deps in Renderer ContentSettingsObserver

The file #includes chrome/common/url_constants.h while it only needs url/ and content/public/common url_constants.h. This CL fixes that.

BUG=384874

Review URL: https://codereview.chromium.org/799923002

Cr-Commit-Position: refs/heads/master@{#308602}

• chrome/renderer/content_settings_observer.cc[diff]

Add johnme to content/browser/push_messaging/OWNERS

Review URL: https://codereview.chromium.org/791723005

Cr-Commit-Position: refs/heads/master@{#308601}

• content/browser/push_messaging/OWNERS[diff]

Migrate DeviceUtils.StartActivity to adb_wrapper

The implementation runs an 'am' shell command with the
relevant options and the args of the given intent.
Output is parsed to check for any errors.

BUG=267773

Review URL: https://codereview.chromium.org/802323002

Cr-Commit-Position: refs/heads/master@{#308600}

• build/android/pylib/device/device_utils.py[diff]
• build/android/pylib/device/device_utils_test.py[diff]
• build/android/pylib/device/intent.py[diff]

Use Blink's flag to prevent fling boosting.

This flag prevents the flingCancel event from being used
as a part of a fling boost event sequence.
The synthetic FlingCancel method works properly now and cancels flings
instantly, without deferring flingCancel event.

See: https://codereview.chromium.org/789223002

BUG=440886

Review URL: https://codereview.chromium.org/792833002

Cr-Commit-Position: refs/heads/master@{#308599}

• content/browser/android/content_view_core_impl.cc[diff]
• content/renderer/input/input_handler_proxy.cc[diff]
• content/renderer/input/input_handler_proxy_unittest.cc[diff]

Fallback to app_name_ when app_id_ is empty, which could happen before
UpdateCurrentAppInfo or in AndroidTV builds.

Review URL: https://codereview.chromium.org/794213003

Cr-Commit-Position: refs/heads/master@{#308598}

• chromecast/base/metrics/cast_metrics_helper.cc[diff]

Adjust "git cl try" to not consider remote devtools sources as android-specific.

There are several files in src/chrome/browser/devtools/device that have "android" in their name although they are meant to be built on desktop platforms.

BUG=

Review URL: https://codereview.chromium.org/811833002

Cr-Commit-Position: refs/heads/master@{#308597}

• PRESUBMIT.py[diff]

Roll src/third_party/skia bc02bf0:9a5380d

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/bc02bf0..9a5380d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]

Review URL: https://codereview.chromium.org/811843002

Cr-Commit-Position: refs/heads/master@{#308596}

• DEPS[diff]

Roll src/third_party/WebKit 0574d22:90948d3 (svn 187252:187257)

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0574d22..90948d3

[email protected],[email protected]

Review URL: https://codereview.chromium.org/810793002

Cr-Commit-Position: refs/heads/master@{#308595}

• DEPS[diff]

Revert of telemetry: Clean up SurfaceFlinger statistics (patchset #8 id:140001 of https://codereview.chromium.org/765773004/)

Reason for revert:
Perf sheriff here, speculatively reverting due to crbug.com/442752, it shows up in many blamelists (but not all as the test wasn't running due to another bug). Sorry if unrelated.

Original issue's description:
> PERF-SHERIFFS: This patch will change all smoothness and SurfaceFlinger metrics on Android. Some metrics may go up or down significantly, with the new values being more accurate.
>
> This patch cleans up the integration of SurfaceFlinger statistics by pulling the
> raw timestamps into the timeline and calculating all metrics in
> SmoothnessMetric. This approach also improves the metrics, because the
> timeline ranges can now be properly bounded (no more percentiles!) and the
> existing smoothness metrics can also use the more accurate SurfaceFlinger
> timestamps.
>
> BUG=351916
>
> Committed: https://crrev.com/ebae600f54ed1e77eeba916635310fb176c0fb6c
> Cr-Commit-Position: refs/heads/master@{#308488}

[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=351916

Review URL: https://codereview.chromium.org/809753002

Cr-Commit-Position: refs/heads/master@{#308594}

• build/android/pylib/perf/surface_stats_collector.py[diff]
• build/android/surface_stats.py[Added - diff]
• tools/perf/measurements/smoothness_controller.py[diff]
• tools/perf/measurements/smoothness_unittest.py[diff]
• tools/telemetry/telemetry/core/platform/__init__.py[diff]
• tools/telemetry/telemetry/core/platform/android_platform_backend.py[diff]
• tools/telemetry/telemetry/core/platform/cros_platform_backend.py[diff]
• tools/telemetry/telemetry/core/platform/ios_platform_backend.py[diff]
• tools/telemetry/telemetry/core/platform/linux_platform_backend.py[diff]
• tools/telemetry/telemetry/core/platform/linux_platform_backend_unittest.py[diff]
• tools/telemetry/telemetry/core/platform/mac_platform_backend.py[diff]
• tools/telemetry/telemetry/core/platform/platform_backend.py[diff]
• tools/telemetry/telemetry/core/platform/win_platform_backend.py[diff]
• tools/telemetry/telemetry/timeline/model.py[diff]
• tools/telemetry/telemetry/timeline/surface_flinger_importer.py[Deleted - diff]
• tools/telemetry/telemetry/timeline/surface_flinger_timeline_data.py[Deleted - diff]
• tools/telemetry/telemetry/web_perf/metrics/rendering_stats.py[diff]
• tools/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py[diff]
• tools/telemetry/telemetry/web_perf/metrics/smoothness.py[diff]
• tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py[diff]

Removed discrepancy in low-end-device-mode flag

Removed the flag low-end-device-mode and added two flags enable-low-end-device-mode and disable-low-end-device-mode. This removes discrepancies between the flag values (integers) when used in different platforms and makes it simple to use with the just the flags and no values passed.

BUG=437778

Review URL: https://codereview.chromium.org/761783004

Cr-Commit-Position: refs/heads/master@{#308593}

• base/android/java/src/org/chromium/base/BaseSwitches.java[diff]
• base/android/java/src/org/chromium/base/SysUtils.java[diff]
• base/base_switches.cc[diff]
• base/base_switches.h[diff]
• base/sys_info.cc[diff]
• content/browser/gpu/gpu_process_host.cc[diff]
• content/browser/renderer_host/render_process_host_impl.cc[diff]

Rename --app-shell-host-window-bounds commandline switch to --app-shell-host-window-size.

The keyword "bounds" doesn't make sense because this switch is used to change only the size of the host window.

Similar CL had landed[1] for content_shell with --content-shell-host-window-size as a switch name.

[1] https://codereview.chromium.org/783203002/

Review URL: https://codereview.chromium.org/805203002

Cr-Commit-Position: refs/heads/master@{#308592}

• extensions/shell/browser/shell_desktop_controller_aura.cc[diff]
• extensions/shell/common/switches.cc[diff]
• extensions/shell/common/switches.h[diff]