Publish DEPS for 86.0.4240.110
Incrementing VERSION to 86.0.4240.110
[email protected]
Change-Id: I16737e0d5b57fd49ed8afa1ea83c3ca65a0fb213
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485681
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1287}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll src/third_party/freetype/src/ 20186d1be6415d1..d7caaf8517fa6d (1 commit)
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f9f6adb625c4..b977dff8c99b1
git log f9f6adb625c4..b977dff8c99b1 --date=short --no-merges --format='%ad %ae %s'
2020-10-19 [email protected] Test early to prevent overflow.
Change-Id: Ibb0c37644aa14e06a72dde21617bdfce5c4ecb75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486093
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1286}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Hardcode default apps to not have protected storage.
This fixes an issue I introduced in m85 here:
https://chromium-review.googlesource.com/c/chromium/src/+/2181827
during our migration of all "bookmark apps" off of the extensions system
and onto the WebAppProvider system.
Making YouTube no longer a 'bookmark app' (and back to a hosted app)
had the side effect of making its storage protected, because apparently
all hosted apps have their storage protected.
This change marks all potential default hosted apps as no longer
receiving protected storage.
The long term fix for this issue is to have the WebAppProvider system
support default apps, and migrate these old hosted apps (which is a
double-deprecated system) onto the WebApp platform:
https://bugs.chromium.org/p/chromium/issues/detail?id=1140122
R=[email protected]
(cherry picked from commit f800edbd1b50ecc13a0d3391f5f45ba9c84625be)
(cherry picked from commit 954e0815dff6f929a9d7c3f251a7143ed1a5a436)
Bug: 1139902
Change-Id: I0d09eed3bf232407192fd07e621b82bcac4263f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485436
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Chase Phillips <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#818570}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485049
Reviewed-by: Krishna Govind <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4296@{#7}
Cr-Original-Branched-From: 348f473375481bbae653524aad76d79cb8285fd7-refs/heads/master@{#818242}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485843
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1285}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.108-r1 to 86-4240.77-1603108500-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib68e101e8423e4c71b791a974ff24593dab99e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485610
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1284}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.68-1602501261-benchmark-86.0.4240.108-r1 to 86-4240.77-1603101048-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I33e52a7bd809d915b4908442632af46bbbc772c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486137
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1283}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.108-r1 to 86-4240.77-1603112082-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I3b70e94988efc6f836bf4e518b9c55f72cd50e01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486134
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1282}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Merge to M86: Disable caret browsing toggle on Mac when web contents isn't focused.
This is a follow-up to http://crrev.com/c/2472897 - it turns
out that it's not sufficient to make the caret browsing toggle
do nothing, we have to actually disable the command in order for
it not to interfere with Japanese IMEs.
This required a bit of extra work to ensure that the command
enabled status is updated when focus changes.
Test in follow-up: https://crrev.com/c/2476910
(cherry picked from commit 14aea1a8a4defbfb4c40351c9fce4fb6ceb744d2)
Bug: 1138475
AX-Relnotes: Pressing F7 to toggle caret browsing no longer interferes with Japanese IMEs
Change-Id: I0497b377ee74f1916e0dd2ca9a5c4f1d24f1d332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476906
Commit-Queue: Dominic Mazzoni <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817814}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485137
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1281}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Apply edits when closing the bookmarks bubble
Fixes regression where the dialog had to be explicitly accepted to apply
pending updates.
(cherry picked from commit 417603ce00e6dc879b85400d833e26f82fd867d6)
Bug: 1137491
Change-Id: I9c8166aa013714b08280eaf1d51c7831dcd6b9a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476719
Commit-Queue: Peter Boström <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Auto-Submit: Peter Boström <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817628}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485835
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1280}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Merge to M86: Don't toggle caret browsing on Mac unless web contents has focus.
Pressing F7 to toggle caret browsing was interfering with a Japanese
IME on Mac, but only when the omnibox has focus. There were no
conflicts when focus is in a web page. So to work around this issue,
ignore the F7 shortcut when focus is
It turns out Firefox has the same behavior: it ignores the F7 toggle
when focus is in its address bar. So that's good motivation that this
is the right fix.
There hasn't been any feedback about a similar issue on other
platforms, so scoping the fix to just Mac.
(cherry picked from commit 624eb0c056f51c70f16cbcf3a244b485f3a77a3f)
Bug: 1138475
Change-Id: I19b5ccaf9aec0b46c76e241887af60b0180a7338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472897
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817162}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485433
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1279}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Download: Fix a crash for removable SD card on Android R.
Only call DownloadManager.addCompletedDownload on Android version below
Q, since it's deprecated. On R it will cause a crash.
(cherry picked from commit 6fcac9a226e802cc99e31c025efc41c40f2512c1)
Bug: 1120233
Change-Id: I19951e2fcdd71b9de9facbc551c95fd275f46170
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425168
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#809605}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485097
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1278}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Validate input of MediaStreamDispatcherHost::OpenDevice()
This method forwards to MediaStreamManager::OpenDevice(), which
DCHECKs for the stream type to be device video or audio capture
(i.e., webcam or mic). However, MSDH admits other stream types,
which cause MSM::OpenDevice to hit this DCHECK.
This CL ensures that a message containing an incorrect stream type,
which could be sent by a malicious renderer, results in killing the
renderer process.
(cherry picked from commit 229fdaf8fc05e0eeadad380d401c191afd822d92)
Bug: 1135018
Change-Id: I3884dde95d92c41f44966a8ab1dd7bdfd4b23b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472397
Auto-Submit: Guido Urdaneta <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817151}
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485092
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1277}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Fix AtomicStringTable lowercase translator.
It was erroneously checking if a candidate entry in the atomic string
table was an existing lowercase version of the provided string by
comparing the two strings for lower-ASCII equality, but this doesn't
imply that the string found in the atomic string table is lowercase
ASCII.
For urgent merging to release branches, this is a minimal fix.
A followup CL will land a more efficient version of this.
(cherry picked from commit 2f19541f156707c517f8bd2b3bdf9d8f729e2587)
(cherry picked from commit 486c4092effb4d632d3bef8f35b7d2832fb88552)
Bug: 1138487
Change-Id: I3af7411879ea831c9210e43cee16bca607b51b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480844
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Jeremy Roman <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#818060}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480731
Reviewed-by: Krishna Govind <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4294@{#8}
Cr-Original-Branched-From: 945a64b5e6cd310d9fb6863165edf69d808e0c74-refs/heads/master@{#817614}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481466
Reviewed-by: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1276}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.77-1602499230-benchmark-86.0.4240.103-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: If5e0b183ebd2f030d9204a6483e159d4691f6b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485595
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1275}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.109
[email protected]
Change-Id: I8d3d7693f6c7d0b3a470a9beb0a88435d390996b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484042
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1274}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.68-1602501261-benchmark-86.0.4240.107-r1 to 86-4240.68-1602501261-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I2613c7ddee7d3451c634feec2515a9a2e220cb87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483651
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1273}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.107-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I0d56185cfbfbcf1cd368ce40c6ac2e6d9d24e9b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483650
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1272}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.107-r1 to 86-4240.68-1602506744-benchmark-86.0.4240.108-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I381ae01f001f6fdec5d12b5f0cd18961246629e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483493
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1271}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.68-1602501261-benchmark-86.0.4240.103-r1 to 86-4240.68-1602501261-benchmark-86.0.4240.107-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ie9f1af087aa515051166a9b724b5556951a26f73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481692
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1270}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.103-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.107-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I80281af92fa82fd03ea7afbf168fade2d3ea990f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481739
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1269}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.103-r1 to 86-4240.68-1602506744-benchmark-86.0.4240.107-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I87ed9c19cce8237b62ab6c760fe7929e414ac652
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482453
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1268}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.108
[email protected]
Change-Id: I837f3efd6d43449f6728dc89aeeaf44466ca6e41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483042
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1267}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Fix NGLineBreaker hang
This is a regression in r796465 crrev.com/c/2344431 but the
issue reproduces only in M86.
This CL minimizes the change to make the merge easier. Clean
up CL will follow.
Bug: 1139513
Change-Id: Ie55ebd286534f27df245587f11f03b108b50305c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482623
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1266}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.77-1602499230-benchmark-86.0.4240.102-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.103-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I54dc3947c287b71f1f28e64193e30c25b3787d68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482053
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1265}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.107
[email protected]
Change-Id: I30adaa055e13105aa8014069e2a1f8679d0e40c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482203
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1264}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
bind-gen: Fix HTML{Embed,Object}Element's named definer
For a historical reason, HTML{Embed,Object}Element's named
definer depends on a fallback logic of the definer and also
the named property setter.
This patch fixes the bug with a minimal change so that it's
easy to backport it.
(cherry picked from commit 7895d48b4faf51d22ece2f75ff021c484e61e1cb)
(cherry picked from commit 1de53ad456499c03f57df16e005a7b9fd2368858)
Bug: 1137541
Change-Id: Ic3af70604a379814fae24970317868ab89f7c4c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467744
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#816597}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473320
Reviewed-by: Yuki Shiino <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4280@{#405}
Cr-Original-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481462
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1263}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.68-1602501261-benchmark-86.0.4240.101-r1 to 86-4240.68-1602501261-benchmark-86.0.4240.103-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I9fbe2ed22ede54c0ff9aa695a2d2e70292fd0d8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480620
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1262}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.102-r1 to 86-4240.68-1602506744-benchmark-86.0.4240.103-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I3ba460a4c46fe79cfa4d53da04f50d2839545d98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481564
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1261}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.102-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.103-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I4b35e1db862564a4c71d0e004ce1806cc9e97b3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481421
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1260}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Revert "Remove TS_SS_TRANSITORY flag from TSF"
This reverts commit 5d66d2641816deb4aa942de069a7b2e0d6ee696f.
[email protected],[email protected]
(cherry picked from commit c581014e8ec5c7f5732fa4f6bf75649f88c625aa)
Bug: 1137267, 148355
Change-Id: Iba8a3cb59a12ddd4310849ee1cf877cb7ea8a019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471881
Commit-Queue: Anupam Snigdha <[email protected]>
Reviewed-by: Anupam Snigdha <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817109}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480885
Cr-Commit-Position: refs/branch-heads/4240@{#1259}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Add workaround to avoid crashing when calling LocalBorderBoxProperties
In the presence of rare bugs, it is apparently possible to have a
graphics layer but no LocalBorderBoxProperties.
Bug: 1137883
(cherry picked from commit f907f3506b4b95d73d4363859eb5dfdb7dcc9e25)
Change-Id: I17d65c6ca04d15254efe9b2d13e3de905b59567e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474918
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817565}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480702
Reviewed-by: Chris Harrelson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1258}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.77-1602499230-benchmark-86.0.4240.101-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.102-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic554ef2f1c48f1ecc1d44cdad1aa8398cec13b67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480925
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1257}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.77-1602499230-benchmark-86.0.4240.100-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.101-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I3790aeb94c78d6fdb9351fe73940c8362fdebe45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478068
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1256}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Setting version to 86.0.4240.106
[email protected]
Change-Id: I19d626736ee1b0a6b4e415ac032842a2554d1eaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476838
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1255}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.103
[email protected]
Change-Id: I3ae03be9472533c36145a709959b650dc7908f75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476960
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1254}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Should notify input service about focus change for same input type.
We should call |ITfThreadMgr::SetFocus| to notify input service about
focus change even if the input type has not changed.
This issue is introduced by crrev.com/810350.
Bug: 1133474
Bug: 1124612
(cherry picked from commit 84c57c995bac4e942c9f56462f38aa74383a44c2)
Change-Id: I219fb624fb649b870bc081fbdac56373c1102d66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438478
Reviewed-by: Siye Liu <[email protected]>
Reviewed-by: Yohei Yukawa <[email protected]>
Commit-Queue: Siye Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812203}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477598
Cr-Commit-Position: refs/branch-heads/4240@{#1253}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Revert change to notify input method about type change in omnibox during CJK tip.
The change to notify input method about type change in omnibox during
CJK TIP[1] causes regression that switching to a new tab will change JPN
TIP to English mode instead of Hiragana mode. The reason is that when
input method is notified about the text input type change, Windows input
service is also notified about the change. Therefore, the input mode is
changed from hiragana mode to English mode in JPN TIP.
We should only notify input service if the input type is changed to a
different value. We should also use the cached input type to find the
associated TSF document.
[1]: I0266d9617277696ccb8bfa42ad76f9cbc3d802f3
fe7e213cecb91264a3bd1f6aed8da3495e158963
Bug: 1108845
Bug: 1124612
(cherry picked from commit b941cb149d9d8e9621f077b66ad7fe0e454d7564)
Change-Id: I9ec643c7d2058695e8bc396d764ba598d6235b88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392415
Reviewed-by: Michael Wasserman <[email protected]>
Reviewed-by: Siye Liu <[email protected]>
Reviewed-by: Yohei Yukawa <[email protected]>
Commit-Queue: Siye Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#810350}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477419
Cr-Commit-Position: refs/branch-heads/4240@{#1252}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.101-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.102-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Idc167c9dc279e930ba2501ac03a5f868e5a888d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477280
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1251}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.101-r1 to 86-4240.68-1602506744-benchmark-86.0.4240.102-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Iaf7cf5c045a196d9c950d29f887603e2d2a165c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477276
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1250}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Views: Fix tab controls to sit flush with the top of the tab strip
This CL updates the tab strip's UpdateNewTabButtonBorder() method to
apply the vertical border insets to the tab control buttons rather
than the tab controls container.
This is necessary as the NewTabButton will extend its targetable
area to the top of its bounds when the tab strip is in a condensed
state (i.e. the window is maximized). This is done to ensure the
tab strip controls comply with Fitt's law expectations.
(cherry picked from commit 022d70c762cc57f7037f84719be1bca368c2d165)
(cherry picked from commit ca6b4380d9b765a7fd6e47d4863ab1f073cfc5c2)
Bug: 1136557
Change-Id: I8b312363bdabbef358ec2689321bb30d7680953b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463994
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#815821}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472602
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4280@{#388}
Cr-Original-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476393
Cr-Commit-Position: refs/branch-heads/4240@{#1249}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[Reland] [Merge to M86] [XProto] Temporarily use libXkb to translate key events
This is a reland of [1] with [2] applied.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2473498
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2476716
> The current key translation code doesn't look at the XKB group encoded
> in the modifiers. This is causing an issue where accelerators don't
> work in environments that use groups to support multiple layouts.
>
> This is a minimal fix so that it can be merged back to M87 and M86. It
> temporarily reintroduces an Xlib function.
>
> R=sky
>
> Bug: 1125886, 1136265, 1136248, 1136206
> Change-Id: Ic6ac82e2918482652f79b35c5a046f56bf5da760
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462490
> Commit-Queue: Thomas Anderson <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#815900}
R=sky
Bug: 1125886, 1136265, 1136248, 1136206
Change-Id: I719a3331e09b45550570e0745349f73131f9ccca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476562
Reviewed-by: Thomas Anderson <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1248}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Revert "[Merge to M86] [XProto] Temporarily use libXkb to translate key events"
This reverts commit 65e39fbbead33eaeede9af7467678c19c82ca7df.
Reason for revert: Broke compile on over a dozen Linux, Fuschia and Android M86 branch builders. A sample:
https://ci.chromium.org/p/chromium-m86/builders/ci/linux-lacros-builder-rel/763
https://ci.chromium.org/p/chromium-m86/builders/ci/Fuchsia%20x64/702
https://ci.chromium.org/p/chromium-m86/builders/ci/Android%20arm64%20Builder%20%28dbg%29/313
Original change's description:
> [Merge to M86] [XProto] Temporarily use libXkb to translate key events
>
> > The current key translation code doesn't look at the XKB group encoded
> > in the modifiers. This is causing an issue where accelerators don't
> > work in environments that use groups to support multiple layouts.
> >
> > This is a minimal fix so that it can be merged back to M87 and M86. It
> > temporarily reintroduces an Xlib function.
> >
> > R=sky
> >
> > Bug: 1125886, 1136265, 1136248, 1136206
> > Change-Id: Ic6ac82e2918482652f79b35c5a046f56bf5da760
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462490
> > Commit-Queue: Thomas Anderson <[email protected]>
> > Reviewed-by: Scott Violet <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#815900}
>
> TBR=sky
>
> NOTRY=true
> NOPRESUBMIT=true
> NOTREECHECKS=true
>
> Bug: 1125886, 1136265, 1136248, 1136206
> Change-Id: I8923a25a8ea08c0e195388a7b242808e8db91be4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473498
> Reviewed-by: Thomas Anderson <[email protected]>
> Cr-Commit-Position: refs/branch-heads/4240@{#1244}
> Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[email protected],[email protected]
Change-Id: I943547230aeaf3cbbad3307fadd22abeb816b5a2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1125886
Bug: 1136265
Bug: 1136248
Bug: 1136206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476677
Reviewed-by: Justin Donnelly <[email protected]>
Commit-Queue: Justin Donnelly <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1247}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[WebLayer] Cherry pick MediaSession service fix.
Original description:
MediaSession service should abort if WebLayer isn't inited.
Currently, we crash.
[email protected]
(cherry picked from commit 9321a99a1a1ffd5898ac1b22653299ec6149ec58)
Bug: 1136823
Change-Id: Iceb2d113071cff1de54106577354af2827102a57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462262
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Mugdha Lakhani <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816289}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475816
Reviewed-by: Mugdha Lakhani <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1246}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Cherry-pick of this original change:
Abort rather than crashing when MediaSessionService is started w/o WL.
When an intent attempts to start MediaSessionService but WebLayer has
not been loaded, the service will no-op instead of throwing an
exception.
(cherry picked from commit 52da2312555b0ad0d03eeb5ee86f69861cfdce98)
Bug: b/167388918
Change-Id: I0f191d0f620016c8ee072e0953d10ad1c257fa15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388404
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#803594}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474786
Reviewed-by: Mugdha Lakhani <[email protected]>
Commit-Queue: Mugdha Lakhani <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1245}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[Merge to M86] [XProto] Temporarily use libXkb to translate key events
> The current key translation code doesn't look at the XKB group encoded
> in the modifiers. This is causing an issue where accelerators don't
> work in environments that use groups to support multiple layouts.
>
> This is a minimal fix so that it can be merged back to M87 and M86. It
> temporarily reintroduces an Xlib function.
>
> R=sky
>
> Bug: 1125886, 1136265, 1136248, 1136206
> Change-Id: Ic6ac82e2918482652f79b35c5a046f56bf5da760
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462490
> Commit-Queue: Thomas Anderson <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#815900}
TBR=sky
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 1125886, 1136265, 1136248, 1136206
Change-Id: I8923a25a8ea08c0e195388a7b242808e8db91be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473498
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1244}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.102
[email protected]
Change-Id: I87b9b6c0f06007d5220ce86c421bfc2596e8206b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473539
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1243}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.68-1602501261-benchmark-86.0.4240.100-r1 to 86-4240.68-1602501261-benchmark-86.0.4240.101-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I01dcc5085c6de40d314cac2eb19ae260670a3092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472632
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1242}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.100-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.101-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I1b715579d758ffa4af704651c6c37f4e6d1ff9ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472628
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1241}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.100-r1 to 86-4240.68-1602506744-benchmark-86.0.4240.101-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I0d811d5fa727fd41b9aafac614bc146ffa66b3f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472633
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1240}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.77-1602499230-benchmark-86.0.4240.95-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.100-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I7009a8732ad15740bdae2e09840af4e4b3ff8e52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472077
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1239}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[IntentHandling] Add metrics to record the preferred apps entry count.
This CL adds the metrics to record the preferred apps entry count that
was recorded in the disk. This value should be able to represent the
largest entry number before the user session stopped.
This CL also fixed a mistake I made for existing preferred apps metrics.
When I created "Apps.PreferredApps.UpdateAction" and
"Apps.PreferredApps.FileIOAction" metrics, I updated the scope in
the histograms.xml file, but forgot to update the scope in the UMA
recording function, causing a mismatch of the metrics name.
BUG=1134082, 853604
(cherry picked from commit 8117f92b5cc5104a8ec6d7cbb0fa8cb263235b22)
Change-Id: Ic00c7c78cdaba7268182122ead1877433c1fae61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442398
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Maggie Cai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815486}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469917
Reviewed-by: Maggie Cai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1238}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
[Image-Orientation] Implement WebGL image-orientation
M-86 merge.
When creating textures for WebGL, always orient images
with EXIF orientation data.
This change also corrects the transposed size reported by
ImageBitmap. And it removes superfluous arguments from
CopyImageData.
(cherry picked from commit f373458c504c2d115c42f31b29ff5c19674acbbc)
Bug: 1100470, 1125337
Change-Id: I79aa798327a3582939aa574723926b3325c80e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459400
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Stephen Chenney <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815359}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469776
Reviewed-by: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1237}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.101
[email protected]
Change-Id: I4148cfba501fc80635a280d962ae16a8dfb0e346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469876
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1236}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
M86: Prevent double deletion in PrintRenderFrameHelper.
(cherry picked from commit 6c2b1efa3d1ead8584489194a21183b954a3d184)
Tbr: [email protected]
Bug: 1134960
Change-Id: I765cc3f1463fce4b8d7c2ca99f429031566a4645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454732
Reviewed-by: Jesse Schettler <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814756}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469219
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1235}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Silvermont AFDO profile from 86-4240.77-1602499230-benchmark-86.0.4240.95-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.100-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ibbf58b6f018adfa5fa8e3ec7a77df36ac887b8c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468285
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1234}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Broadwell AFDO profile from 86-4240.68-1602501261-benchmark-86.0.4240.95-r1 to 86-4240.68-1602501261-benchmark-86.0.4240.100-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Icee4f4603fcaa41860b217d02bf0dd9697894694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468711
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1233}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Airmont AFDO profile from 86-4240.68-1602506744-benchmark-86.0.4240.95-r1 to 86-4240.68-1602506744-benchmark-86.0.4240.100-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-stable
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I5ca2d545e3282dd4614b54c094dd5e08aeb23c62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468385
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1232}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Roll ChromeOS Orderfiles from 86-4240.68-1601891844-benchmark-86.0.4240.93-r1 to 86-4240.77-1602499230-benchmark-86.0.4240.95-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I290db27a7bcc929d45f1295cdc2ec8237286ffe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468279
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4240@{#1231}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
Incrementing VERSION to 86.0.4240.100
[email protected]
Change-Id: I970afd353d82002b86f7c4adab6fda96e2c279e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466937
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4240@{#1230}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}
