Publish DEPS for 87.0.4280.20
Incrementing VERSION to 87.0.4280.20
[email protected]
Change-Id: I5e4d315785b6d6d7103e42794b6fd423fe82005e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469957
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#355}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] [SCT Auditing] Only audit SCTs for certs issued from known roots
This is an initial solution for crbug.com/1129197 -- the full solution
is implemented in crrev.com/c/2422435 but requires changes to allow
mocking CT results in order to land.
This prevents logging private certificates, and adds a test explicitly
exercising this case. It also makes the browser tests a bit more robust
by tracking the last report seen by the test server and adding a step to
flush a new report through for negative tests.
(cherry picked from commit 9091cacbf921e51bfe5a0ad6a0c916777484a140)
Bug: 1129197
Change-Id: I7e1d4010b2666db7f98194aa1e3ba80df1e0a493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453777
Reviewed-by: Emily Stark <[email protected]>
Reviewed-by: David Schinazi <[email protected]>
Reviewed-by: Nick Harper <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Commit-Queue: Kinuko Yasuda <[email protected]>
Auto-Submit: Chris Thompson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815086}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468184
Commit-Queue: Chris Thompson <[email protected]>
Reviewed-by: Chris Thompson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#354}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
GestureNav: Adjust edge width for triggering navigation
This CL reduces the width of the area used for triggering
gesture navigation. The reported conflicts with other UI
can be alleviated.
Bug: 1128629
TBR: [email protected]
(cherry picked from commit 245022d0f27873e9a51de5be1ba304f83a50acaf)
Change-Id: I726453adc3dfd1848332ee668d11662c44afdb55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448070
Commit-Queue: Jinsuk Kim <[email protected]>
Reviewed-by: Theresa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814586}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469416
Reviewed-by: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#353}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] More infinite loop prevention in AXPosition::AsValidDOMPosition
This is a speculative fix, as I haven't been able to reproduce this
overflow. There also is not a unit test, because I haven't been able
to reproduce this overflow by tweaking the unit test from
https://chromium-review.googlesource.com/c/chromium/src/+/2426490
However, this is still causing crashes, even after the CL 2426490 has
gone in. And all of the overflows that I've seen after that CL
loop forever in the kMoveRight scenario, so I am confident that this
change will provide the complete mitigation.
(cherry picked from commit 813c55e8bad8543395cf399c24ac2d75cf2367b9)
Bug: 1124394
Change-Id: Ife9293f2fa26a34c17d1aace03b38b3592f387d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464003
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Kurt Catti-Schmidt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816199}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468699
Reviewed-by: Kurt Catti-Schmidt <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#352}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
M87: Prevent double deletion in PrintRenderFrameHelper.
(cherry picked from commit 6c2b1efa3d1ead8584489194a21183b954a3d184)
Tbr: [email protected]
Bug: 1134960
Change-Id: I765cc3f1463fce4b8d7c2ca99f429031566a4645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454732
Reviewed-by: Jesse Schettler <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814756}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468293
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#351}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add //printing:printing as a traits deps to printing_backend_mojo
Currently print_backend_mojom_traits.h includes printing/backend/print_backend.h"
so without this deps this target can't be built by itself.
[email protected]
(cherry picked from commit 02b02434765bb26e9c685e6126774e5978ef0f00)
Bug: 1135263
Change-Id: Ic597468dcdaefbb83e145ef82bb4f4d6b93ef6c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449916
Reviewed-by: Chris Sharp <[email protected]>
Commit-Queue: Chris Sharp <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813908}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469227
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Alan Screen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#350}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Restore classic page switcher colors.
This CL addresses changes in:
https://chromium-review.googlesource.com/c/chromium/src/+/2416763
(cherry picked from commit 7253c6cc85e623d737f77ea197229a2d0aaf53ca)
Bug: 1134800
Change-Id: Id31abaf88693fc6bdfd834033800e80eb6fb1f4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462622
Reviewed-by: Yulun Wu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815830}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469222
Cr-Commit-Position: refs/branch-heads/4280@{#349}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] ambient: close ui when images fail to load
After 3 consecutive failures to load an image, notify observers of
failure.
BUG=b:169591750
TEST=ash_unittests --gtest_filter=AmbientBackendModelTest*
(cherry picked from commit 8bbd512e3960ef6fd3c9150adc632035ada37e7b)
Change-Id: I7a9302e65fc58d3272a0da31f13c6a44efe1cc58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449937
Commit-Queue: Jeffrey Young <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Tao Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816733}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468500
Cr-Commit-Position: refs/branch-heads/4280@{#348}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Location suggestion] Update UI to show not enough space.
This CL changes the UI behavior when a storage that doesn't have enough space for the download is chosen, a "not enough space" error text will be prompted below the storage name. All implementations are wrapped in feature flag.
(cherry picked from commit 49c3c63631b17f3f177a3e16a7c0b7cc4218989c)
Bug: 1118207
Change-Id: I6e9e6c497d4b2b97dbda32faa98314731c6244f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436312
Commit-Queue: Hung Vu <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814489}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465871
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#347}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add DownloadDialogUtils unit tests.
This CL handles unit test for shouldSuggestDownloadLocation in DownloadDialogUtils.
(cherry picked from commit f98f2cf9613c7147afba4f6c1f671def026c3ac3)
Change-Id: I39442ffe032550631c8f47f6ecc49529b489903c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446518
Commit-Queue: Hung Vu <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813418}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466656
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#346}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge M87] Fix crash restoration to restore all windows correctly.
Also make sure that the restore prompt doesn't show if the user already
restored.
(cherry picked from commit 26fff17cad58cfb0ce6b1cb21bb73cc2439e3071)
Bug: 1136307
Change-Id: I733202c348923224c20d5e8728cbab9cd21466d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459804
Commit-Queue: Mark Cogan <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815155}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468259
Reviewed-by: Mohammad Refaat <[email protected]>
Commit-Queue: Mohammad Refaat <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#345}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[cc/metrics] Fix ownership of shared memory for ukm data.
The shared memory used for transporting ukm smoothness data is owned on
the main-thread, but the write happens on the compositor thread. It is
possible for the main-thread to discard the shared memory, and the
compositor thread may still write to it in inopportune moments. To avoid
this race, transfer the ownership of the shared memory to the compositor
thread.
BUG=1134659
(cherry picked from commit 8feb9b9f6b687f409b6328c1b240852060496503)
Change-Id: I71df7ecc1393a0779c36b7d27a3496efb3bf2827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467356
Commit-Queue: Jonathan Ross <[email protected]>
Auto-Submit: Sadrul Chowdhury <[email protected]>
Reviewed-by: Jonathan Ross <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816572}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468241
Reviewed-by: Sadrul Chowdhury <[email protected]>
Commit-Queue: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#344}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Restore classic login shelf kiosk app button color.
This addresses a change in this CL
https://chromium-review.googlesource.com/c/chromium/src/+/2382222
(cherry picked from commit 1475b2a429aa4887d3f494bf702309f27339b0d7)
Bug: 1134854
Change-Id: I3970a260b534dabed6dd8bbba849812f5edfaddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462053
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Yulun Wu <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815687}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468379
Cr-Commit-Position: refs/branch-heads/4280@{#343}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Restore classic zero state search box text colors.
This CL addresses changes in:
https://chromium-review.googlesource.com/c/chromium/src/+/2425623
(cherry picked from commit 2c5a1a069fcb1386acd0e39e551b94aebbe73a34)
Bug: 1134800
Change-Id: I95d8508a817e2b2d32885db84c5ce5129eee52d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464443
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816397}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468381
Reviewed-by: Yulun Wu <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#342}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Restore classic search box icon colors.
This addresses changes from:
https://chromium-review.googlesource.com/c/chromium/src/+/2417653
Note that SearchIcon and Assistant buttons are different colors in
classic UI.
(cherry picked from commit 6f4a3ec8c4230f96babdd5ecd6f52ba228335f0b)
Bug: 1134800
Change-Id: I409bc4bde13331766dc8aa8c54dfeda082c653d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462044
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Yulun Wu <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815689}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468380
Cr-Commit-Position: refs/branch-heads/4280@{#341}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4277.0-1602506009-benchmark-87.0.4280.18-r1 to 87-4277.0-1602506009-benchmark-87.0.4280.19-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I148f1aedb20dae6025d00796056c9c8e5760c52c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468286
Commit-Queue: Chrome Release Autoroll <[email protected]>
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#340}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Add flag for SCT auditing
Adds an entry to chrome://flags for enabling SCT auditing and a set of
variations to pick from for different sampling rates (0%, 0.01%, or
0.1%). This will allow for manual testing and fishfooding without
needing to specify parameters on the command line.
(cherry picked from commit 657d5c8b6478cc01a97fb53afad9913be44d3aae)
Bug: 1136620
Change-Id: I3d8c0e3f6dbe5d77704b1d64dd40b5243c20182f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462237
Reviewed-by: Mustafa Emre Acer <[email protected]>
Commit-Queue: Chris Thompson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815369}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468260
Reviewed-by: Chris Thompson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#339}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Remove CHECK for same-document provisional frames for M87 beta.
TBR=[email protected]
NOTRY=true
(cherry picked from commit 47c81eeb780a17e833c608439aa50f30f3e085d2)
Bug: 1125106
Change-Id: If05f064715add137e16118a08da153d1d5ed0e3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465809
Reviewed-by: Nasko Oskov <[email protected]>
Commit-Queue: danakj <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816752}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469096
Reviewed-by: danakj <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#338}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge M87] Dont show restore prompt on openURL user activity for new window.
This fixes the problem when crash happens as there is no active webstate
when the new window opens. Also this is consistent with the behavior of
single window/multi-window when we don't show the restore prompt when
there is external intent (opening chrome from another app with url
parameter).
(cherry picked from commit d1938285dd48161e8a07e3fd33b53591e5140c84)
Bug: 1135459
Change-Id: Ia979db92f3d938f57a7b7a5f4821075a82b396fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454250
Commit-Queue: Mark Cogan <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815152}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468956
Reviewed-by: Mohammad Refaat <[email protected]>
Commit-Queue: Mohammad Refaat <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#337}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: I987cc810963e7f646019a6dcd441933cbb1b337e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468441
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#336}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4277.0-1602501961-benchmark-87.0.4280.18-r1 to 87-4277.0-1602501961-benchmark-87.0.4280.19-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic1d852498a04fb78a4556cf46180c44cf0b387cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468719
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#335}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[cc/metrics] Gracefully handle shared-memory allocation failure.
If shared-memory allocation for smoothness-ukm data fails, then
handle that error gracefully, rather than crashing out.
BUG=1134659
(cherry picked from commit 4adfc23bee93a3d33752e3e242068e71d00eccbc)
Change-Id: I309e478ce112d9e0303d7aea6619260abac0cfe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446929
Reviewed-by: Daniel Cheng <[email protected]>
Auto-Submit: Sadrul Chowdhury <[email protected]>
Commit-Queue: Sadrul Chowdhury <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813405}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468638
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#334}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Do not show mixed form warning for javascript urls
Forms that set their target to a javascript: scheme URL were being
tagged as mixed content, this CL fixes that.
Bug: 1135173
Change-Id: I1b185bef9e1dc41d97736f3a1c96de510fb7eef9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451510
Commit-Queue: Carlos IL <[email protected]>
Commit-Queue: Dominic Battré <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Auto-Submit: Carlos IL <[email protected]>
Cr-Commit-Position: refs/heads/master@{#815752}
(cherry picked from commit b88f7241559c94b46bbbb2578ddaa700d7e9161d)
[email protected]
Change-Id: I1b185bef9e1dc41d97736f3a1c96de510fb7eef9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468782
Reviewed-by: Carlos IL <[email protected]>
Commit-Queue: Carlos IL <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#333}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
ServiceWorker: Record histograms for install events using fetch().
In order to support throttling network requests in install events we
would like to run a trial that measures changes in install time and
success rate. We have existing histograms for these measures, but they
cover all install events. We suspect that there are many install events
that do not fetch any resources at all; e.g. push notifications scripts.
This dilutes the signal we get from looking at these histograms in the
trial.
This CL adds separate histograms to measure install time and success
rate for only events where the script performs a network fetch. It
also adds a histogram to measure how many fetches are performed for
each install event.
To support this histogram we plumb a count of fetches from the
GlobalFetch::ScopedFetcher to the service_workers_metrics.cc utility
code.
(cherry picked from commit d5307bec557a0673b3118977598c706f76540d43)
Bug: 1035448
Change-Id: Id6eb4a553452b01d71c0a42b88a8c9df56819c34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443044
Commit-Queue: Ben Kelly <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Makoto Shimazu <[email protected]>
Reviewed-by: Liquan (Max) Gu <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Reviewed-by: Rayan Kanso <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814661}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468736
Reviewed-by: Ben Kelly <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#332}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Restore classic app list folder view colors.
This CL addresses changes in:
https://chromium-review.googlesource.com/c/chromium/src/+/2417241
(cherry picked from commit 1322c4995d2a449af29947b7e90f8f717e8cf5c6)
Bug: 1134800
Change-Id: I9ce7301dcdfe9940a10f3920e2901a051ff0f0e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462556
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Yulun Wu <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815686}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468702
Cr-Commit-Position: refs/branch-heads/4280@{#331}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Context menu] Add null check in mOnMenuClosed
This is the second attempt at fixing the NPE.
(cherry picked from commit c58027465464256f2da6bbb1693c3073058e2753)
Bug: 1133172
Change-Id: Iabe5faf1814147d3069ae5815fe0c4f1ea441f83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453442
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Sinan Sahin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814459}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468307
Reviewed-by: Sinan Sahin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#330}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4277.0-1602498224-benchmark-87.0.4280.18-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.19-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Id01bc792b6de7d034caf235d3081609b9f65cc21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468384
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#329}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge-87][Sh-Blink] Variable used for range selector should be reset
(cherry picked from commit 224f96bce21673f2e266febf2feec0e01b15cb01)
Bug: 1136464
Change-Id: Ibfae772d5d289a74b1cffdb83f74ba8a370c08b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461118
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: Gayane Petrosyan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815373}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468676
Reviewed-by: Gayane Petrosyan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#328}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Copy Link To Text: Replace refs in current page's URL
This CL replaces everything after the '#' if it exists in a URL to
avoid chaining multiple refs such as #anchor#:~:text=selected%20text.
(cherry picked from commit 712cbe9871eef8587ec4da37792b3387085b78be)
Bug: 1136468
Change-Id: I22583af358c1169a2b97bfad12d2e75a2d8e172c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460797
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815427}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468704
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#327}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Partially restore classic launcher.
This addresses changes in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2400240
Other functions in app_list_color_provider_impl will be updated later.
(cherry picked from commit 3a9cd9db019dcd8dcabb0a042c4a95773cb386d5)
Bug: 1134800
Change-Id: I21b7448cc5a9805a6991622f912041b7ffb04258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459310
Reviewed-by: Yulun Wu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815382}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468378
Cr-Commit-Position: refs/branch-heads/4280@{#326}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
PDF Viewer: Confirm zoom value only on enter/blur (M87)
Bug: 1136703
Change-Id: If1370e61db35049f12e22beb6219651056b326ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461801
Commit-Queue: Rebekah Potter <[email protected]>
Reviewed-by: dpapad <[email protected]>
Cr-Commit-Position: refs/heads/master@{#815768}
(cherry picked from commit e7afbcecb7674c6a55876ef45c42ec1e0d895a74)
[email protected]
Change-Id: I7910aa8f92aab6d8b49f1f56ee030625d587d14d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468298
Reviewed-by: Rebekah Potter <[email protected]>
Reviewed-by: dpapad <[email protected]>
Commit-Queue: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#325}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge M87] Feature to conditionally enable logging in Feed V2
(cherry picked from commit f69841348e2a1c1ff4836048385a72150fc7684a)
Bug: 1137414
Change-Id: Ibfc667c96b595292d8118bf5e46455221ad8c274
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424839
Commit-Queue: Vincent Boisselle <[email protected]>
Reviewed-by: Dan H <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815788}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468636
Reviewed-by: Vincent Boisselle <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#324}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Copy Link To Text: Surround selected text with quotes
(cherry picked from commit 1c55ded397b9dbaa334410e6a18d39dcdc28ccf0)
Bug: 1105862
Change-Id: Ia3b9cb7d06a88005321806c78f1dbcf93d4ba544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438929
Reviewed-by: Scott Violet <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812888}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468697
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#323}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[bfcache] Delete loader when restarting navigation.
Delete URLLoader (which in this case is CachedNavigationURLLoader) when
restarting a back-forward cache navigation as a non-cached one to
cancel associated tasks and prevent to-be-cancelled navigation from
making further progress.
R=[email protected],[email protected]
BUG=1122935
(cherry picked from commit 27ea6737d8b16a74062966ded77bbf74c694f9f6)
Change-Id: Ice6a9ada33e575517bbbe8da07e3034e5c371b6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461328
Commit-Queue: Alexander Timin <[email protected]>
Reviewed-by: Arthur Sonzogni <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815362}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464271
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#322}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] - OOBE - Marketing - Combine marketing metrics
Generate an additional metric that combines data from
all countries for the Chromebook marketing opt-in.
(cherry picked from commit f5479bbcab37f4a77eed69cfa2c9669896e162c3)
Fixed: 1136816
Change-Id: I521824b2b5f7d5c06402dad5ccbe1719dd1c197d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463613
Commit-Queue: Renato Silva <[email protected]>
Commit-Queue: Denis Kuznetsov [CET] <[email protected]>
Auto-Submit: Renato Silva <[email protected]>
Reviewed-by: Denis Kuznetsov [CET] <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816168}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467864
Cr-Commit-Position: refs/branch-heads/4280@{#321}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 Merge] ambient: avoid restart lock timer if it's running
(cherry picked from commit 051b2c527d305c241323e032fd6969f07ac56f64)
Bug: b:170509871
Test: unittests and manually on nocturne
Change-Id: Ib59a1c9e00056a5fdd13e5ee94cac51c365cf9b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462025
Reviewed-by: Tao Wu <[email protected]>
Commit-Queue: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816206}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461144
Cr-Commit-Position: refs/branch-heads/4280@{#320}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[iOS] Fix showing edit menu on long-press in location bar
The edit menu was being shown inside a DCHECK.
(I.e DCHECK([self methodWithSideEffects]). This meant that it was
stripped out in release builds, but not in debug, which is why this
didn't reproduce locally.
(cherry picked from commit eac89721742297a0c50418fa9276bd03f4230a97)
Bug: 1134647
Change-Id: Idbe1a48d0f9c82543cffcc3f79d05128e9589470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462266
Commit-Queue: Robbie Gibson <[email protected]>
Commit-Queue: Stepan Khapugin <[email protected]>
Auto-Submit: Robbie Gibson <[email protected]>
Reviewed-by: Stepan Khapugin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815615}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467999
Reviewed-by: Robbie Gibson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#319}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[fuchsia][a11y] Converts AxRole to Fuchsia Semantic Roles.
The Fuchsia Semantics API changed, so this change converts the new added
roles.
Note that this change is not converting the added roles related to
lists, which will be solved in a future change.
(cherry picked from commit 0e8e56f18b82ebae157fc3aac4fd62228a261b66)
Test: AXTreeConverterTest.ConvertRoles
Bug: fuchsia:60180,1136536
Change-Id: I23e8b0dc02e2e9f85cae16be81c400744831905a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461954
Commit-Queue: Lucas Radaelli <[email protected]>
Reviewed-by: Sharon Yang <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816302}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467016
Commit-Queue: Sharon Yang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#318}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Don't composite SVG element animating unsupported property by the compositor
[email protected]
(cherry picked from commit b647ada1ad2f56a3655707d05f4b25647e858659)
Bug: 1136764
Change-Id: Id909f6ef11c914ca8ff4c468c669a60d0f04dd31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464015
Reviewed-by: Fredrik Söderquist <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816207}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465215
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#317}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Autofill] Fix returning identified street & house number fields
As part of AutofillEnableSupportForMoreStructureInAddresses feature several new field types were introduced. Proior this change they were identified using regex but never counted as found because AddressField::Parse returned nullptr.
Bug: 1137796
Change-Id: Idaa8d6d62faed5c593ca447739ecff3819fdc151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467859
Reviewed-by: Matthias Körber <[email protected]>
Commit-Queue: Elizabeth Popova <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#316}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[ntp][modules] Log histogram for module visibility
The new NewTabPage.Modules.Visible lets us track the ratio of NTP loads
with modules visible.
(cherry picked from commit b13aa4a24c73481c27ce7e257814d8ec9de6e985)
Bug: 1135393
Change-Id: I15a9fd064b7e189420e2eac2e9cecc72587f8fc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454733
Commit-Queue: Tibor Goldschwendt <[email protected]>
Auto-Submit: Tibor Goldschwendt <[email protected]>
Reviewed-by: Weilun Shi <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815244}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466485
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#315}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge to release branch: Add UKM collection to OffscreenCanvas readbacks
and RenderingContext creations.
(cherry picked from commit 05f9c6b067c53c6b35db2814387c3da2b4b81a09)
Bug: 973801, 1135701
Change-Id: I3e3837b1aef4b4d27ac9418247172ab36f2b0e42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344625
Commit-Queue: Chris Fredrickson <[email protected]>
Reviewed-by: Kai Ninomiya <[email protected]>
Reviewed-by: Fernando Serboncini <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814341}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459388
Cr-Commit-Position: refs/branch-heads/4280@{#314}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[WebOTP] Add UMA/UKM to record SMS parsing status
This patch adds SmsFetcher::Subscriber::OnFailure(FailureType) to
capture SMS parsing failures (this patch) and prompt timeout/cancelled
failures (follow up).
We also record the reason why an SMS is not parsed. The metrics can help
us to quantify the level of unexpected SMSes.
UKM collection review:
https://docs.google.com/document/d/15orQiLx06QSuZr4ShBaozY0dvPzXiTWwJZ9Xk5cgzAA/edit?usp=sharing
(cherry picked from commit 9621ff9c9a0809b4974ad7b12737d2b7a0d3b8ae)
Bug: 1126266
Change-Id: I59214e2be64677dae1c9f0b47c2154eefeb1207a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424542
Commit-Queue: Yi Gu <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Sam Goto <[email protected]>
Reviewed-by: Majid Valipour <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815021}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465212
Reviewed-by: Yi Gu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#313}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
SkiaRenderer: Fix RGB and RGB565 formats
This CL fixes color type that we pass to the skia for the
FBO0. It changes two things:
* Use RGB565 if the surface uses 16 bit format .
* Fallback to RGBA is skia doesn't support rgb color type.
Bug: 1126490
(cherry picked from commit a3fdaed239e22fe568fd7798eedec154cafa05ba)
Change-Id: I6f5342ac7bb128134afc2c5182a6c6b99600c7a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441311
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Jonathan Backer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813787}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466522
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#312}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Profiles] Log more info about profiles being deleted
This CL adds more logging to understand the circumstances of a profile
being deleted. In particular, it adds a metric
Profile.DeleteProfileContext and a histogram suffix
Profile.State.*_UponDeletion.
(cherry picked from commit 9186bb4a7d8ae4390939c4574b31dda3a0c2aa95)
Bug: 1136483
Change-Id: I10204a435012ad64b67061e5050d9eec2c28da84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461230
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: David Roger <[email protected]>
Commit-Queue: Mark Pearson <[email protected]>
Auto-Submit: Jan Krcal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815743}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466762
Reviewed-by: Jan Krcal <[email protected]>
Commit-Queue: Jan Krcal <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#311}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Profiles] Log the sync status of profiles
This CL adds another information to the Profile.Status.* collection of
histograms, namely the is-sync-enabled boolean.
(cherry picked from commit 3a3ed1e459aacb509eb69189598edebd7e6c4cc3)
Bug: 1136483
Change-Id: Ibd589d9f6fb75b3732abcf83279f6f2345f39969
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461274
Commit-Queue: David Roger <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: David Roger <[email protected]>
Auto-Submit: Jan Krcal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815525}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466280
Reviewed-by: Jan Krcal <[email protected]>
Commit-Queue: Jan Krcal <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#310}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android][WebSignin] Fix crash when bottomSheetController is null
This CL dismisses the account picker bottom sheet when the bottom
sheet controller is null.
(cherry picked from commit d910f8292f551edad96cfaeda88eaf0e4e72df48)
Bug: 1136799
Change-Id: I9814c10f6becb07c3e95ab93f0d81b69af936853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463307
Commit-Queue: Alice Wang <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815676}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463575
Reviewed-by: Alice Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#309}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fetch the user info when the account info in invalid.
This CL removes some Android-only logic that avoided downloading the
account info when the account info was invalid. This ensures that the
account info is correctly updated when the user signs in to Chrome.
This CL also fixes a subtle bug that lead to the avatar image not being
downloaded on start-up if the previous attempt to download the avatar
image failed.
(cherry picked from commit 08b77943e1e037a9c795ec82642cafc421d58e62)
Bug: 1135958
Change-Id: Ia31993f969aac2fc6b7c6f1ed325eb012ad33dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461310
Commit-Queue: Mihai Sardarescu <[email protected]>
Reviewed-by: Alice Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815632}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463574
Reviewed-by: Mihai Sardarescu <[email protected]>
Commit-Queue: Alice Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#308}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge 4280: Add early return to NGBoxFragmentPainter::HitTestLineBoxFragment
When |NGBoxFragmentPainter::HitTestLineBoxFragment| ported
the logic from |InlineFlowBox::NodeAtPoint()|, it missed the
early return by using |InkOverflow()|. This patch adds this.
Test case: blink_perf/layout/culled-inline-hittest
Before r793989: 420ms
Before r807114: 9,064ms
ToT: 374ms
ToT (PaintFragment): 421ms
ToT (legacy): 4.5ms
This patch: 2.9ms
crbug.com/1127976 added a heuristic switch, which is effective
when there are many lines (and therefore |IsDescendantsCursor|
is very small subset), but it may have negative effects in
other cases. The root problem is NG calls it too much because
of the lack of this early return. I'll remove the heuristic
switch in a separate patch because it is probably no longer
necessary with this numbers.
(cherry picked from commit 5cb87631082064b382733dba206551769c1f4bd0)
Bug: 1128937, 1127976
Change-Id: Icb26007d90461c0e763d5af424704e56489e626f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463086
Commit-Queue: Koji Ishii <[email protected]>
Reviewed-by: Yoshifumi Inoue <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815524}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467047
Reviewed-by: Koji Ishii <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#307}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[base] Add function GetGraphicsMemoryInfo
Before this patch, GetSystemMemoryInfo() reads both /proc/meminfo and
/run/debugfs_gpu/i915_gem_objects (for x86 CPU family). Reading
/run/debugfs_gpu/i915_gem_objects could take more than 500 ms under
memory pressure on Intel platform with kernel 5.4, while reading
/proc/meminfo only takes about 1 ms. Add GetGraphicsMemoryInfo() to read
the gpu memory info, GetSystemMemoryInfo() reads /proc/meminfo only.
GetGraphicsMemoryInfo() would return false on Intel platform with kernel
5.4 to avoid the slow i915_gem_objects access.
(cherry picked from commit 7cc65fc4c97210143ccf8d17c6cb77abb4c22481)
Bug: b/170150180, 1134131
Change-Id: I0a0cfb868826b59f508a478d3db69ec089f5d4d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449519
Commit-Queue: Kuo-Hsin Yang <[email protected]>
Reviewed-by: Wez <[email protected]>
Reviewed-by: Cheng-Yu Lee <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Brian Geffon <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816143}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467042
Reviewed-by: Kuo-Hsin Yang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#306}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add UMA for updating web app window/tab user preference
This CL adds two new UMAs for when the user sets a web app to open in a
window or a browser tab:
- WebApp.SetWindowMode.Window
- WebApp.SetWindowMode.Tab
This is includes adding the new variable |is_user_action| to
WebAppRegistryController::SetAppUserDisplayMode(), which allows the
metric to be recorded only if the switch was triggered by a
user action (and not, say, migration code).
This CL also removes the bookmark apps variant of
AppServiceShelfContextMenuWebAppBrowserTest because the new tests fail
under bookmark apps which we no longer support anyway
(https://crbug.com/1065748).
(cherry picked from commit d5540e96b7d2afdd605c15e58c6e5510bc772dc9)
Bug: 1135941, 1065748
Change-Id: Ib32e0996a2c126d5ca622e6292593edb57f6c559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454436
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Nancy Wang <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Alan Cutter <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815386}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465891
Reviewed-by: Alan Cutter <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#305}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[ntp][modules] Add setting to hide modules
Offers a toggle in the customize dialog that hides modules on the NTP.
Screenshot (shown): https://screenshot.googleplex.com/BKvcrirTE6quvdi
Screenshot (hidden): https://screenshot.googleplex.com/AxMQ6DZa3MrHopf
Upon closing the customize dialog the visibility will be applied to the
current NTP and saved to prefs.
(cherry picked from commit 53ca78bb191ba469e633c73acb6594960318e790)
Bug: 1135393
Change-Id: I1dde6109ab3b8acccee5a4c57681a42302fbec76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454329
Auto-Submit: Tibor Goldschwendt <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814816}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466499
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#304}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Omnibox] Adds feature to disable local ZPS for signed-in users
(cherry picked from commit f6cdd7d70d9286a99e385f0c4e5b150c11d7440f)
Fixed: 1136649
Change-Id: Ie48f7b52c40fd040a23b16c63ec0bb970c8585b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463804
Commit-Queue: Moe Ahmadi <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815865}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466200
Cr-Commit-Position: refs/branch-heads/4280@{#303}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Change the color of the enhanced protection link in SSL interstitials.
The color of "turn on enhanced protection" should be consistent with the
color of "Learn more".
light mode
before: http://screen/8WidHUNBBQmzKgi
after: http://screen/3NR2qbG2f2P9zTq
dark mode
before: http://screen/BN2CLeG6XCyuqPU
after: http://screen/KraWTSsegRer2Zq
(cherry picked from commit c8b006aa4aebe6de028b8f5d8148426927d94e3d)
Bug: 1130721
Change-Id: I761731b565253cf800ef54999959ede0fc67c6ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463592
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Varun Khaneja <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815770}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467076
Reviewed-by: Xinghui Lu <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#302}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] ambient: fix dcheck blocking error saving backup photos
Perform disk operations in SequencedTaskRunner
BUG=b:170346308
TEST=activate ambient mode, lock screen
(cherry picked from commit ddadb4220d53154ac339a1e34954dc129c5e0089)
Change-Id: I5faefd46e74e6ec8ae7061d56e7f6abd0c80326f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460796
Commit-Queue: Jeffrey Young <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Tao Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815959}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464789
Cr-Commit-Position: refs/branch-heads/4280@{#301}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87]Update the Enhanced Protection deep link.
After clicking on the Enhanced Protection
promo on desktop, the Security settings page
should open with the Enhanced Protection section
expanded.
[email protected]
(cherry picked from commit 9f8042b4660bf36d2570b3ee7ea53cabbdc9246c)
Bug: 1130722
Change-Id: I646566199755862055e8be0fba00259ecf48d704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454404
Reviewed-by: Mustafa Emre Acer <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Bettina Dea <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815066}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461145
Reviewed-by: Bettina Dea <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#300}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Log metrics when ESB message is shown or opened in interstitials.
Add two new enum values in MetricsHelper::Interaction:
SHOW_ENHANCED_PROTECTION
OPEN_ENHANCED_PROTECTION
SHOW_ENHANCED_PROTECTION is logged when the enhanced protection message
is shown in the interstitial. OPEN_ENHANCED_PROTECTION is logged when
the enhanced protection link is clicked. We can get the engagement rate
of this new UI from the new enum values.
(cherry picked from commit 4d0e4b9b50d7267e7c6582ac36b30e0417460416)
Bug: 1130721
Change-Id: Iecd0a08eaac1b1448bbe6a43a9c8290e27b1be18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459073
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815782}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466214
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#299}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Enable Print Save To Drive flag by default
Update the tests to expect Save to Drive being a default destination on
Chrome OS.
(cherry picked from commit 0b92f457d04785d9d4928c6c99c1583bc27a413e)
Bug: 1112416
Change-Id: I548cb97b1fa07a43d5fd4553786f05a56fb08a45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440986
Commit-Queue: Gavin Williams <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815043}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462638
Reviewed-by: Jimmy Gong <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#298}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.19
[email protected]
Change-Id: I6756b5f1f4be2c62527520c809d9485318b9d7c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466737
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#297}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Add icon and background color in enhanced-protection-message.
Mocks: http://slides/1YgDDFKSXoIFreM19fBQZx71Kfa1Gh7Tmywqhmo-pkLY/view#
slide=id.g97a0aac007_0_43
Screenshots:
Desktop SB: http://screen/3LzbFP3BhJcH8jt
Desktop SSL: http://screen/AqReWuvxFPxzYdh
Android SB: http://screen/9v4wQeCtqWsmteC
Android SSL: http://screen/AWJekyhEeHu94ds
(cherry picked from commit 9daabe40359441fb305156cff179326f7cbb88d5)
Bug: 1130721
Change-Id: Ifc63a24b280410bccec13ec06bf13e5022242c28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434767
Reviewed-by: Carlos IL <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814959}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466213
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#296}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Implement OpenEnhancedProtectionSettings on Android.
This method is called when users click the enhanced protection link in
security interstitials. Also add a new access point named
kSecurityInterstitial for logging metrics.
(cherry picked from commit b5a365f349a455cc1a3d2fff3eaa82a3eca0e312)
Bug: 1130721
Change-Id: I02725db2c9557a7d6440584b8f9145a696affff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434089
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Natalie Chouinard <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814786}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466495
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#295}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] Fix tab grid layout issue on drag.
Resetting the grid view controller's |reorderingLayout| to a
GridReorderingLayout (instead of a TabSwitcherReorderingLayout, which
subclasses TabSwitcherLayout instead of a GridLayout) fixed
the issue.
(cherry picked from commit 2bdc83a23ff5d5fbeb4fea5bee5f1fc766107c53)
Bug: 1135507
Change-Id: I35f9faa1bdb5962709bef528f9ec849fb499895f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454709
Commit-Queue: Roberto Moura <[email protected]>
Reviewed-by: edchin <[email protected]>
Auto-Submit: Roberto Moura <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815459}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462127
Commit-Queue: edchin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#294}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[privacy view] Fix a11y bugs in the launcher notice.
This CL does the following:
- Remove the default focus action. This allows ChromeVox to immediately
select and read out the notice when the search box is opened.
- Make all of the text behave as one entity for ChromeVox, which can
also activate it as the link.
- Use the AppListColorProvider to get the correct shading color when
the close button is focused. This ensures that the color will still
contrast with the background in dark mode.
(cherry picked from commit 17172936b3e8393d0dfa5e076be9c154e9baf768)
Bug: 1112714
Change-Id: I798d532a030a0f331845ab440b8f6aabced46af0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463024
Commit-Queue: Rachel Wong <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815885}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465889
Reviewed-by: Rachel Wong <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#293}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Restore shelf app indicator color for light mode.
This CL addresses the changes in:
https://chromium-review.googlesource.com/c/chromium/src/+/2392949
(cherry picked from commit dec5cec34b68204b29dc335db74e3f48f77080d9)
Bug: 1134854
Change-Id: Ie8f39aa562595bed9f66006b68e3b20b2e29b538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460307
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Yulun Wu <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815380}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466210
Cr-Commit-Position: refs/branch-heads/4280@{#292}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Record when prefs blocklists affect hrefTranslate translations.
This CL adds metrics recording which prefs blocklists affect
hrefTranslate translations, even if those blocklists don't end up
preventing translation from happening.
This CL also splits the kNotAutoTranslated enum value that can be
recorded for Translate.HrefHint.Status into the two separate values
kUiShownNotAutoTranslated and kNoUiShownNotAutoTranslated.
(cherry picked from commit fbd7e0df954f702fca0b0d1a4b5ed0247667de0e)
Bug: 1131240
Change-Id: Ibeb9adffe4452419559ba0fe451eb7e31e664c0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450847
Reviewed-by: Megan Jablonski <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Commit-Queue: Scott Little <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814516}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466506
Reviewed-by: Scott Little <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#291}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[fuchsia][a11y] Advertise more nodes with default action
This change expands the set of AxNodes that the bridge considers
to support default actions for the purpose of advertising that
support to the Fuchsia a11y-manager. This will let the screen
reader interact with many more nodes.
R=[email protected], [email protected], [email protected]
(cherry picked from commit 52905e20890d61a05f7a0cd93fad24c8615c4ac7)
Test: AccessibilityBridgeTest.PerformDefaultAction
Bug: fuchsia:57669
Change-Id: I6b0858179a6b9ff44fc3c927caa9e517f8ad47e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459933
Commit-Queue: Tess Eisenberger <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Reviewed-by: Sharon Yang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815397}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466206
Cr-Commit-Position: refs/branch-heads/4280@{#290}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Restore classic login shelf ink drop.
This addresses changes in:
https://chromium-review.googlesource.com/c/chromium/src/+/2406934
not addressed in:
https://chromium-review.googlesource.com/c/chromium/src/+/2459206
(cherry picked from commit f0dc8e2240ef43aec3b6fc3d189d3a3b54327600)
Bug: 1134854
Change-Id: I44dc9cf7782f7dbe692d95659e84dd00062df19a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460248
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Yulun Wu <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815360}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466209
Cr-Commit-Position: refs/branch-heads/4280@{#289}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Remove isDriveMounted from destination select
|driveDestinationKey| now triggers whether to show the Save to Drive
destination in the dropdown on Chrome OS.
(cherry picked from commit 5bbd46dcf135dce6ec72f82ce31d5fef0d56cfd0)
Bug: 1112416
Change-Id: I2cb61425796fe80dac4e862f048da5addea3c46a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441954
Commit-Queue: Gavin Williams <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814935}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463502
Reviewed-by: Jimmy Gong <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#288}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Implement CanShowEnhancedProtectionMessage.
The goal is to replace the SBER checkbox with the enhanced protection
message. Enhanced protection message is shown when:
1 Not in incognito mode
2 kEnhancedProtectionMessageInInterstitials flag is enabled.
3 Safe Browsing pref is not managed by policies.
4 Enhanced protection is not already turned on.
(cherry picked from commit 5e41e7152844d3326e12401e27ac82bf5cc30dfa)
Bug: 1130721
Change-Id: Ic7175c6210023ebe23e5cd7aedacadf39091528a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430826
Commit-Queue: Xinghui Lu <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813990}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466662
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#287}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
usb: Prevent parallel calls to UsbDevice::Open
This change adds a check to prevent a Mojo client from calling Open()
multiple times while the open is in progress.
(cherry picked from commit 1ed869ad4bb34e9868933cd2b20dc22ab83a5021)
Bug: 1135857
Change-Id: Ib467de9129673710b883d9e186c32c359f8592d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454846
Auto-Submit: Reilly Grant <[email protected]>
Reviewed-by: Matt Reynolds <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814940}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466346
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#286}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Handle transferred channels in ConvolverNode
If any channel of an AudioBuffer is transferred (detached) when given
to a ConvolverNode, we treat it as if no buffer were given[1] and reset
the internal reverb to null so that the output is all zeroes.
[1] The spec on acquiring the contents of an AudioBuffer says if any
buffer is acquired, treat it as if all are.
(cherry picked from commit 710f745e6bcb7709e687e4b6a7840aeb8b1a458c)
Bug: 1134930
Change-Id: I413b9acf38bdf2efe2a466968ae9074df6956fd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450350
Commit-Queue: Raymond Toy <[email protected]>
Reviewed-by: Hongchan Choi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814670}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466343
Reviewed-by: Raymond Toy <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#285}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Implement DeviceFamilyLinkAccountsAllowed policy
This policy allows adding Family Link accounts additionally to
accounts listed in DeviceUserAllowlist policy and is dedicated
for school use.
(cherry picked from commit aa95dfdff6b4f1105c99ef2217a5edc5a9363fa0)
Bug: 1126155
Change-Id: Ia0f34b97b31dd143db3a0c2d839e2b4a314ac086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448671
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Commit-Queue: Aga Wronska <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815535}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465748
Reviewed-by: Aga Wronska <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#284}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Avoid TabGroupModelFilter casting exception(2)
This is a follow up of crrev.com/c/2442479. This CL early returns when
TabModelFilterProvider().getTabModelFilter() is not a
TabGroupModelFilter to avoid the casting exception in
TabGroupUiCoordinator.recordSessionCount().
This CL is gated by Finch parameter "enable_launch_polish" under flag
"enable-tab-grid-layout", with gate function
TabUiFeatureUtilities#isLaunchPolishEnabled.
(cherry picked from commit 8dbcfb66710c833bcf92998a60219141c060e344)
Bug: 1133922
Change-Id: I830b6721e15b6ca558e79b66dcd7a1b783186f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443395
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Commit-Queue: Mei Liang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812903}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466163
Reviewed-by: Mei Liang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#283}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] Reland "ambient: start when two images loaded"
This is a reland of 581c91ec3cd79a1b88d161276aadd144771d012e
Original change's description:
> ambient: start when two images loaded
>
> Construct ambient widget when two images are in memory to prevent burn
> in.
>
> BUG=b:167332126
>
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Change-Id: I520ada00429125d35bda9ef66089ca9a9c8d4440
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440306
> Commit-Queue: Jeffrey Young <[email protected]>
> Reviewed-by: Tao Wu <[email protected]>
> Reviewed-by: Xiaohui Chen <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#814711}
(cherry picked from commit 01cf328d5f1824d7e11d3f4c407c3b41084e9dac)
Bug: b:167332126
Change-Id: I7fe0cca3ecb15262666eee1067f57bc21b150468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459399
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Jeffrey Young <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815206}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465064
Reviewed-by: Tao Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#282}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Screenshots] add histograms upstream for clank screenshot feature
Downstream CL https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3314008
Bug: 1093386
Change-Id: I03a48bfc29cdb2ccdaae4e854cc08dc39b2ca3ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451570
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Kristi Park <[email protected]>
Commit-Queue: Jeffrey Cohen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#815421}
(cherry picked from commit b4b03cb8f00cc647f082dcaeee8fb656423c2962)
tbr: [email protected]
Change-Id: I03a48bfc29cdb2ccdaae4e854cc08dc39b2ca3ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466202
Reviewed-by: Jeffrey Cohen <[email protected]>
Commit-Queue: Jeffrey Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#281}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] ambient: enable personal photos by default
Useful for testing ambient mode on development builds.
BUG=none
(cherry picked from commit 5e8512975784343f1da74ee30fa5bfa49b22ecba)
Change-Id: I014797dcce9a2ffe62e80e6df196f50d243de8c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443510
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Jeffrey Young <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812899}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465063
Reviewed-by: Tao Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#280}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Ship navigator.scheduling.isInputPending()
Intent to ship approved here:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8Vt2atMrNNs
(cherry picked from commit a31a92bca7f841e137d28eae5a864caaa492ae16)
Bug: 910421
Change-Id: Ie399046d6a0116d76e86b0daa2bddce306f1c24a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443493
Reviewed-by: Philip Rogers <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Andrew Comminos <[email protected]>
Auto-Submit: Andrew Comminos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812973}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461716
Reviewed-by: Andrew Comminos <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#279}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[fuchsia][a11y] Accessibility Bridge forwards valid updates.
This change refactors parts of the Accessibility Bridge to solve the
following bugs: * Previously, it was deleting nodes that were marked as
reparented or a subtree that was reparented. This assumed that nodes
marked this way would appear in the list of updates sent by the
AxTreeObserver in the final atomic update, but this assumption is not
correct. This fixes the problem where parents were pointing to children
no longer in the tree.
* Allow trees of size 1 to be sent. Previously, the loop that dealt with
sending updates started from the second item, which would not send
anything if the tree had only one element.
* Simplifies the order of updates: first deletions and then
updates. Because atomic updates always finish with the list of nodes
added / changed, we can use this property to simplify the code to
always follow this order.
Todos: There are some todos left in the code which I opted to follow-up
in a future cl so that I can split work among people and parallelize.
(cherry picked from commit d952f8e9487990829bc0e2bc17eeeae73bdb4014)
Test: AccessibilityBridgeTest.*
Bug: 1134384,fuchsia:58989,fuchsia:50187,fuchsia:61155
Change-Id: I6ec09a5d6fa5d5ad37fb42a059d0d0f122d39d97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446358
Commit-Queue: Lucas Radaelli <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Reviewed-by: Sharon Yang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815346}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465519
Commit-Queue: Tess Eisenberger <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#278}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add a min score for new front tiles
If the first tile is not frequently clicked, other tiles may be displayed
before it. And those tiles, even if they are not clicked for many days,
will stay before the first.
This may cause new front tiles, such as the trending tiles, to have a
lower score than those not clicked tiles. And will not show up in the
front. This CL fixes that issue
BUG=1136306
(cherry picked from commit 6821ef76966a60fea75905e01e3b7e5214bae663)
Change-Id: I2f5aa7d3a64450b23375b2df2647265ed9c70c22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459941
Commit-Queue: Min Qin <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Reviewed-by: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815277}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463921
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#277}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add Andtroid Q gate to wide color gamut
Right now, we first check if the user is in the enabled feature group when
enabling wide color gamut. After that, we check if they are on a version
of Android that supports wide color gamut. This results in users in the
enabled group who aren't actually seeing wide colors.
This CL checks if the user is on a supported version of Android before
checking which group they are in. That should give us more accurate
results when looking at the effect of the experiment.
(cherry picked from commit ea5c2db183c6423a819fd9a2a5c79dfd260da721)
Bug: 1136572
Change-Id: Ied060b1036bba67a0c90a45f1f8e1dc106af4aea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462218
Commit-Queue: Chris Blume <[email protected]>
Commit-Queue: Khushal <[email protected]>
Reviewed-by: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815324}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465911
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Chris Blume <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#276}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Clear fast_ink GpuMemoryBuffer
The buffer contents may be uninitialized on some platforms. Ensure that
it is cleared before being displayed.
(cherry picked from commit 99835f16f61a424c5abde7d41360c416b17182e8)
Change-Id: I55007e0728852d38911515019a2a7a3640ef613c
Bug: b:168735625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413179
Commit-Queue: Drew Davenport <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813182}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463545
Cr-Commit-Position: refs/branch-heads/4280@{#275}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Image-Orientation] Implement WebGL image-orientation
M-87 merge.
When creating textures for WebGL, always orient images
with EXIF orientation data.
This change also corrects the transposed size reported by
ImageBitmap. And it removes superfluous arguments from
CopyImageData.
(cherry picked from commit f373458c504c2d115c42f31b29ff5c19674acbbc)
Bug: 1100470, 1125337
Change-Id: I79aa798327a3582939aa574723926b3325c80e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459400
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: Stephen Chenney <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815359}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464430
Reviewed-by: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#274}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Reland "[fuchsia][a11y] Sends full semantic tree when semantics are enabled."
Reland explanation: A test I wrote tested specific size values for the semantic
tree. The chrome a11y code that creates the tree for us is non-deterministic, so
we can't check for a specific tree size. I updated the tests to only test for a
minimum threshold, which is fine in this case here.
This is a reland of fdae2298518693c507d7c1e0adf3f11150017722
Original change's description:
> [fuchsia][a11y] Sends full semantic tree when semantics are enabled.
>
> This change fixes the bug where chrome was sending the full semantic tree only for the first time that semantics were enabled. This happened because the semantic tree was not getting cleared on the chrome side when disabled. when semantic were disabled / enabled, the events fired on the tree included only the diffs from the previous state of the tree.
>
> Test: web_engine_browsertests
>
> Bug: fuchsia:59680, 1134147
> Change-Id: I8266d6436f9bfb9ee9e89a0f46c0916bac7a5e75
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442646
> Commit-Queue: Lucas Radaelli <[email protected]>
> Reviewed-by: Sergey Ulanov <[email protected]>
> Reviewed-by: Sharon Yang <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#813771}
(cherry picked from commit 475b49a95f22071147d8ebfb50be35e9b4c167ce)
Bug: fuchsia:59680
Bug: 1134147
Change-Id: I606b7628c480b775c04d84894faaba73f74789c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450704
Commit-Queue: Lucas Radaelli <[email protected]>
Auto-Submit: Lucas Radaelli <[email protected]>
Reviewed-by: Sharon Yang <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813962}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466267
Commit-Queue: Tess Eisenberger <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#273}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[ntp][modules] Add strings for modules customize tab
This new tabs will allow users to disable NTP modules.
(cherry picked from commit 3175686af910882e8d9ffef5aa7518be1a7f8998)
Bug: 1135393
Change-Id: I734742fe098010dbb57c6b3ec3f703fac01c6ba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451526
Commit-Queue: Tibor Goldschwendt <[email protected]>
Auto-Submit: Tibor Goldschwendt <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814254}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465512
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#272}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4265.0-1601892862-benchmark-87.0.4280.17-r1 to 87-4277.0-1602501961-benchmark-87.0.4280.18-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Idc5977447fb81dfac3737ddd4b96d442612db9e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466342
Commit-Queue: Chrome Release Autoroll <[email protected]>
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#271}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Fix AAudio crash on device change
Currently, when using AAudio, we treat device changes like any other
error, which causes video playback to fail when plugging in headphones.
This CL changes this so we intercept device disconnection errors, and
report them as kDeviceChange errors to the OutputController, which
forces the graceful creation of a new stream.
(cherry picked from commit 42f255d543e50f19e8b8ed2e4d57bc0e050bafe0)
TBR: [email protected]
Bug: 1136559
Change-Id: I7969ad3edac2b7bbc9a3e2271f423cf7a029e7f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462340
Commit-Queue: Thomas Guilbert <[email protected]>
Commit-Queue: Dale Curtis <[email protected]>
Auto-Submit: Thomas Guilbert <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815438}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466393
Reviewed-by: Thomas Guilbert <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#270}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Open security page when enhanced protection link is clicked.
Implement OpenEnhancedProtectionSettings() in controller_client. Create
an interface named settings_page_helper at component/ level and an
implementation class named chrome_settings_page_helper at chrome/ level.
The interface is injected to controller_client.
Add Safe Browsing enhanced protection page in chrome_pages. The URL
path is "security?q=enhanced". During navigation, it opens
"chrome://settings/security" and expands the enhanced protection section.
(cherry picked from commit 4ada215142fd8bf16cd98909ed3a3c526f52d3ff)
Bug: 1130721
Change-Id: I27b9b938d47c8ea4caed2b4da6e9b374086366e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429440
Commit-Queue: Xinghui Lu <[email protected]>
Reviewed-by: Nate Fischer <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Livvie Lin <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813879}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466366
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#269}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601895675-benchmark-87.0.4280.17-r1 to 87-4277.0-1602506009-benchmark-87.0.4280.18-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I57321f6236c131be46656774e073a59e6b515fc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466330
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#268}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Break out isFramePending into its own feature
Ensure that when shipping isInputPending, we don't ship isFramePending as collateral.
(cherry picked from commit d008dc582ee0de97dc18924f9d298d128ad7b8ae)
Bug: 910421
Change-Id: Iddfc0ba927a9b61a90e99da18e12bb7513c93b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443213
Commit-Queue: Andrew Comminos <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Auto-Submit: Andrew Comminos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812966}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466164
Reviewed-by: Andrew Comminos <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#267}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix TabGroupModelFilter casting exception
TabUiFeatureUtilities.isTabGroupsAndroidEnabled() does not guarantee
TabModelFilterProvider().getTabModelFilter() returns
TabGroupModelFilter. It can return null before
TabModelSelectorBase#initialize() is called. This CL early returns when
TabModelFilterProvider().getTabModelFilter() is not a
TabGroupModelFilter to avoid the casting exception.
This CL is gated by Finch parameter "enable_launch_polish" under flag
"enable-tab-grid-layout", with gate function
TabUiFeatureUtilities#isLaunchPolishEnabled.
(cherry picked from commit bdbeca365c145f292174a50a8f02c42fffa14f92)
Bug: 1133922
Change-Id: I9766d4f0f54c954f8205866aa0c514b508d7a5a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442479
Commit-Queue: Mei Liang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812865}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466162
Reviewed-by: Mei Liang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#266}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[SH] Create the basic infrastructure for link-to-text on Bling.
Adds a link-to-text button when clicking on selected text in the
browser container.
Creates and hooks up a mediator and tab helper to handle the click
on the new link-to-text button.
(cherry picked from commit c54722330574818dc09514fd40ecf4ab9788698f)
Bug: 1134703
Change-Id: I72196fc7a95b81ea32700414c70a645af16bfc52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446202
Commit-Queue: sebsg <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Reviewed-by: Sebastien Lalancette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814253}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464098
Reviewed-by: sebsg <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#265}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: Ie82a44e896437816971cb6d6bea2cd14b0946aff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466456
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#264}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge m87] Fix buffer queue swap size in landscape
Buffer queue may not change orientation on rotation, and the swap size
would have the width and height swapped for code that expects the swap
size to be in landscape.
This fixes the surfaceRedrawNeededAsync timeout when rotating from
portrait to landscape.
This also fixes 1136033 where on initial launch in landscape, android
side does not have a timeout for surfaceRedrawNeededAsync like it does
for rotation.
(cherry picked from commit 305a60d532048e5422d6d970ac14f5be205c4b4a)
Bug: 1136033
Change-Id: I91b3d81252f3e02fb3d85bf1ac91d5d802544490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459569
Reviewed-by: Peng Huang <[email protected]>
Reviewed-by: Khushal <[email protected]>
Commit-Queue: Bo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815332}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464784
Reviewed-by: Bo <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#263}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] Reland "ambient: cache two backup photos"
This is a reland of a81c26884bde81a386ffb2dcbdb7a12f0ecd1215
Original change's description:
> ambient: cache two backup photos
>
> Handle failure cases better by having backup photos on disk.
> Refresh these images after user logs in.
>
> BUG=b:167332126
>
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Change-Id: I7046a20ed9606638e851247f8c213d112af6c30b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429585
> Commit-Queue: Jeffrey Young <[email protected]>
> Reviewed-by: Xiaohui Chen <[email protected]>
> Reviewed-by: Tao Wu <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#813904}
(cherry picked from commit 2c34160725973ce93507b98fde9dfda735fcb565)
Bug: b:167332126
Bug: b:170312454
Change-Id: If5306f627e1a6dfb5e4eb37842a470d17968ad4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458894
Commit-Queue: Jeffrey Young <[email protected]>
Reviewed-by: Tao Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814968}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464073
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#262}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601890590-benchmark-87.0.4280.17-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.18-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I816b66aba63255a336d4360ecaa8dc96d5e0c9bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466328
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#261}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Disable BookmarkPersonalizedPromoRenderTest
Two tests has been flaky on multiple bots
(cherry picked from commit 5540f5e7f6ec4b3b5dc8c204d007a8fd1a59eaa2)
Bug: 1136534
Change-Id: I761a0e2e3e77d8a4e7a1b04e0b4d684569513845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462155
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Commit-Queue: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815394}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463831
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#260}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Enable kCompositeCrossOriginIframes by default
Cherry-picked from:
https://chromium-review.googlesource.com/c/chromium/src/+/2443630
BUG=930987
TBR=dcheng,pdr,[email protected]
Change-Id: I3b8ba70606e4f92e6b4507843161244f09fb6d88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466265
Reviewed-by: Stefan Zager <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#259}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87]If SigninPromo is not visible, show EP promo.
|mSignInPromo| may not be null but can be not
visible. If the SigninPromo is either not null
or visible, the Enhanced Protection promo should
show.
(cherry picked from commit 7699248957c3c52c50e174e4c0fcf663f3d50776)
TBR=twellington
Bug: 1136272
Change-Id: Ib159dbbb3d40b6420bbd670321913b12b283e12f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459395
Reviewed-by: Wenyu Fu <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Bettina Dea <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815361}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466262
Reviewed-by: Bettina Dea <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#258}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Fuchsia] Implement timeout for Cast Streaming
* Kill the Session after 10s of no activity in the audio or video
stream.
* Kill the Session after 5s if no offer message is received.
* Fix reporting of messages from unknown namespaces in the Cast
Streaming MessagePort.
Bug: 1087528, 1134441
Change-Id: I69b44bea3b142e7cf12c32106a279ef37710c56b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451525
Reviewed-by: Kevin Marshall <[email protected]>
Commit-Queue: Fabrice de Gans-Riberi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#815876}
(cherry picked from commit 274ebeda8528cb28b23a3a54a50bd57d185d25fd)
[email protected]
Change-Id: Ie94bcff8ea2417205cd09a1d248d038055700d7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466496
Reviewed-by: Fabrice de Gans-Riberi <[email protected]>
Commit-Queue: Fabrice de Gans-Riberi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#257}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Cast MRP] Changed IsCastInternalNamespace to match legacy impl.
(cherry picked from commit 43001197d26d86d7d59bdb48928fc2dbf3a64fe0)
Bug: 1136545, b/168822921
Change-Id: I683aeee86f06a157255eae0c9db3948509ebcbf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438749
Commit-Queue: John Williams <[email protected]>
Reviewed-by: mark a. foltz <[email protected]>
Reviewed-by: Takumi Fujimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814806}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463560
Cr-Commit-Position: refs/branch-heads/4280@{#256}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
FontAccess: Page Info string matches UI recommendation
This changes the page info string to match the UI recommendation as
necessary to ship in Origin Trial.
(cherry picked from commit 406dacf330e8e2b310efcc9ec23d1528d36fd3e8)
Bug: 1043306
Change-Id: I77133f0a3e95c87d1a261043d596f669bbde62c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441955
Auto-Submit: Olivier Yiptong <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Commit-Queue: Olivier Yiptong <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812860}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466337
Reviewed-by: Olivier Yiptong <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#255}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Media Router] Fixed crash when dismissing media notification.
This change fixes a crash caused by trying to show the same
supplemental notification twice when dismissing a media notification.
Showing the notification once causes a different problem, where
instead of closing, the dialog stays open with the closed notification
replaced by the previously-hidden supplemental notification.
The fix is to only show supplemental notifications when they are
created, and thereafter only hide them in response to the creation of
a non-supplemental notification. The original design for supplemental
notifications was based on the idea of supplementatal notifications
being persistent in order to trigger the display of the media control
icon in the toolbar. In the course of the code review, the design was
changed to create supplemental notifications in a just-in-time manner
to avoid showing the media control icon, so there is no longer any
need to show a supplemental notification that was previously hidden.
(cherry picked from commit dea5a77063c4295bf9732320acee22ed8c789db2)
Bug: 1107164, b/161612881
Change-Id: I9a9b60b1e1023ef4d8085ca4df949645f999efdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453440
Reviewed-by: Tommy Steimel <[email protected]>
Reviewed-by: Takumi Fujimoto <[email protected]>
Commit-Queue: John Williams <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814787}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463844
Cr-Commit-Position: refs/branch-heads/4280@{#254}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Destroy ...ExtensionURLLoaderFactory in OnBrowserContextDestroyed
ExtensionURLLoaderFactory's and CastExtensionURLLoaderFactory's lifetime
cannot exceed the lifetime of the associated BrowserContext.
This CL should fix https://crbug.com/1136214 and is likely to also fix
https://crbug.com/1134050.
(cherry picked from commit 5f364bfbb3d6152e842a5cca6bf86b65f1f92101)
Fixed: 1136214
Bug: 1134050
Change-Id: I06b0c17ebe308ec86f0341c7fa7b7bbdc1ffde4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461222
Commit-Queue: Łukasz Anforowicz <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Auto-Submit: Łukasz Anforowicz <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Sean Topping <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815871}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465936
Reviewed-by: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#253}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Cast MRP] Remove null fields for Cast-protocol messages.
(cherry picked from commit 6b9eac03845eb0fc0f6471a2b93bdb04f4caf841)
Bug: 1129217
Change-Id: Ic9300541ba56cddcb75524af07dd8afe9a4f35c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427124
Auto-Submit: John Williams <[email protected]>
Reviewed-by: mark a. foltz <[email protected]>
Reviewed-by: Takumi Fujimoto <[email protected]>
Commit-Queue: John Williams <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813328}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463845
Cr-Commit-Position: refs/branch-heads/4280@{#252}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Reland "[fuchsia][a11y] Refactors convert node ID logic."
This is a reland of c14fae86cc43220727d673fb2c04b42ae28a2754
Original change's description:
> [fuchsia][a11y] Refactors convert node ID logic.
>
> This change refactors the logic to convert an ax node ID to a fuchsia semantic node ID.
>
> It also fixes the bug where if a regular ax node had ID == 0, it would conflict with the root ID.
>
> R=yangsharon
>
> TEST: web_engine_unittests
> Change-Id: Ie4ee52c65fbd5ad623986e015ad521e66c5e67fe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430264
> Reviewed-by: Kevin Marshall <[email protected]>
> Reviewed-by: Sharon Yang <[email protected]>
> Commit-Queue: Lucas Radaelli <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#811926}
(cherry picked from commit 3c9a29646bb052a1ff47fb5e272191cb23e5f2c9)
Change-Id: I8b89cb69007c7e7557660ef70e71d28807fff436
Bug: 1136988, fuchsia:60803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441278
Auto-Submit: Lucas Radaelli <[email protected]>
Reviewed-by: Sharon Yang <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Sergey Ulanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813820}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466258
Commit-Queue: Tess Eisenberger <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#251}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge to M87] [XProto] Temporarily use libXkb to translate key events
> The current key translation code doesn't look at the XKB group encoded
> in the modifiers. This is causing an issue where accelerators don't
> work in environments that use groups to support multiple layouts.
>
> This is a minimal fix so that it can be merged back to M87 and M86. It
> temporarily reintroduces an Xlib function.
>
> R=sky
>
> Bug: 1125886, 1136265, 1136248, 1136206
> Change-Id: Ic6ac82e2918482652f79b35c5a046f56bf5da760
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462490
> Commit-Queue: Thomas Anderson <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#815900}
TBR=sky
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: 1125886, 1136265, 1136248, 1136206
Change-Id: I6b6a1f9e28dbe31ab35a18fca89ca9dafd2e18c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466161
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#250}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
m87: merge fixes for native tts
This is a rebased change from trunk which was not able to be automatically merged through the Gerrit UI from
https://chromium-review.googlesource.com/c/chromium/src/+/2464067
and
https://chromium-review.googlesource.com/c/chromium/src/+/2465564
Bug: 1134289
Change-Id: I65cffdd85cd855707b51b30ff6de2c3464487579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466399
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#249}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Fix render tests testRenderDifferentSignedInStates*
See the failure in https://crbug.com/1135290#c1. Explicitly enable
the SAFE_BROWSING_SECURITY_SECTION_UI flag to show "Privacy and
security".
(cherry picked from commit bc6b6a7f9c8054fa5d1b7c583eaf8c45f38e3c37)
Bug: 1135290
Change-Id: I28d4656e8df987d79312dad2e00d67f861465c3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450665
Reviewed-by: Natalie Chouinard <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814784}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466259
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#248}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[printing] Reuse AwPrintManager with introducing UpdateParam()
This CL introduces AwPrintManager::UpdateParam() which updates
|settings_|, |fd_|, and |pdf_writing_done_callback_| in order
to reuse AwPrintManager avoiding creating it every time.
It fixes a regression issue by crrev.com/c/2326857. The
problem is that WebContentsFrameReceiverSet is created always
along with AwPrintManager but WebContentsImpl::AddReceiverSet()
expects that it's called once for an each interface. So, this
CL doesn't create AwPrintManager always like other print
managers such as PrintViewManager or HeadlessPrintManager.
(cherry picked from commit 296bf0c33fad795257038482dad37ba57287a093)
(cherry picked from commit c4b2c26af2a405baa404fcd55e9bcf786e0fe1af)
Bug: 1137016
Change-Id: I11c176009ccdad643ebf495cc4b983209ba8b1c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463270
Reviewed-by: Bo <[email protected]>
Commit-Queue: Julie Kim <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#816141}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466101
Reviewed-by: Ben Mason <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4290@{#3}
Cr-Original-Branched-From: bd0384ad8c56398b073fd362c68b6be977531874-refs/heads/master@{#816033}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466199
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#247}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add about://flags entry for IPH snooze
(cherry picked from commit 113c2ebd95f144e51f4000a63cd95d2f43a5f04c)
Fixed: 1136181
Change-Id: Iaa1049d67195d1292749dbe30b3e2a2da6bd4fc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458586
Commit-Queue: Collin Baker <[email protected]>
Commit-Queue: Wei Li <[email protected]>
Auto-Submit: Collin Baker <[email protected]>
Reviewed-by: Wei Li <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814889}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465937
Reviewed-by: Collin Baker <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#246}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[fuchsia] Add support for a11y sliders
* Add sliders to role conversions
* Add increment and decrement actions
* Update data structures in FakeSemanticTree
* Add waits for node updates in FakeSemanticTree
* Add test only action/event pair in browsertests so waiting for actions
is more reliable
(cherry picked from commit 53a16cf1df91a19c839336d92338124ce0471d24)
Test: AccessibilityBridgeTest.Slider
Bug: fuchsia:56295, 1122806, 1136974
Change-Id: Id0658ada5b15da1c128b69c1346aee1d39f2a6f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314758
Commit-Queue: Sharon Yang <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812919}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466320
Reviewed-by: Sharon Yang <[email protected]>
Commit-Queue: Tess Eisenberger <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#245}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
WV Autofill: Use latest datalist suggestion
Previously, the internal class which extends AutofillPopup uses a copy
of suggestions when it is created, the copy one won't be changed
when suggestions changed.
This patch adds the suggestion array as data member, so the internal
class will always refer the latest suggestions.
(cherry picked from commit 125aefddf14425df5d080f8edd1be89064b4bd26)
Bug: 949555, 1136585
Test: verified manually
Change-Id: I4f300be648af4038c7b26f115161d8e56b9575b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462336
Reviewed-by: Dominic Battré <[email protected]>
Commit-Queue: Michael Bai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815716}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466257
Reviewed-by: Michael Bai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#244}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix issue in which stale downloads were added to holding space.
Previously downloads were being observed prior to download manager
initialization. When the download manager updated, these downloads
were then being added to holding space despite being stale.
(cherry picked from commit bf65024f1630c29ee292da4ae632f52f91f52018)
Bug: 1137035
Change-Id: Icc53367f5d0d00248da2e29a2ee53a562687b22d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464262
Reviewed-by: Ahmed Mehfooz <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815918}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466198
Reviewed-by: David Black <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#243}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
m87: Native audio tts playback
Moves text-to-speech playback from js-based web audio to C++.
See bug for more details.
Depends on
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/2456208/1
(cherry picked from commit 47754cf116c52133739b0aa033c5c850b2533732)
Fixed: 1134289
Change-Id: I7ecfa800f6b688f6a3d0d655f557e86efa73188a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435919
Commit-Queue: David Tseng <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814980}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466339
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#242}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: I24c0f14711dbd6ee17bc7c8887cf2d9982f6cc56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466136
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#241}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Passwords] Show weak passwords audit - Implementation review fixes
This change shows proper string when user is signed out and there are no
weak passwords.
(cherry picked from commit 5ea94beaba635587d1353c453f60ae4d1ea4bca4)
Bug: 1135155
Change-Id: I46da38d75f48bc230058cf9f6f36b3effd0cd45f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448373
Commit-Queue: Viktor Semeniuk <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814157}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463572
Reviewed-by: Viktor Semeniuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#240}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix chip animation for same request in another tab
If you request a permission, then open another tab and request the same
permission, the chip appears without animating and the origin in the
omnibox disappears. This patch fixes this behaviour.
If request was already shown to user and user switches back to a tab
with a pending request, request stays collaped and won't reanimate.
(cherry picked from commit 70546721fde5f6d257e2760211d2739d6776377d)
Bug: 1019129
Change-Id: I9d46f1fbe479de584bcce988d7a20deb4e7e76a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445774
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Bret Sepulveda <[email protected]>
Commit-Queue: Olesia Marukhno <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814635}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462270
Reviewed-by: Olesia Marukhno <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#239}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "Add webapk site settings category"
This reverts commit abbc3f13c89bc16989661a49b9a108e98a99a626.
Reason for revert: Disable the site settings feature for Chromium 87
Original change's description:
> Add webapk site settings category
>
> A WebApk checks for this category to display
> a site settings shortcut. This category is therefore
> a switch to turn site settings on/off.
>
> Bug: 1128985
> Change-Id: Id2678b957bd3f21e8cafa47ca2c10a2b269b3621
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434326
> Commit-Queue: Pavol Drotár <[email protected]>
> Reviewed-by: Peter Conn <[email protected]>
> Reviewed-by: Boris Sazonov <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#811196}
[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 1128985
Change-Id: Ie79358fbfb83a9213cebc5daec460d9939dec1ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452671
Reviewed-by: Peter Conn <[email protected]>
Commit-Queue: Peter Conn <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#238}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
MGS needn't enter immersive mode when it is set as fullscreen
Previously, we decided to force Managed Guest Sessions (MGS) into
immersive mode to avoid security concern for those auto-launch
applications. But actually all applications in MGS can only be launched
manually.
Such a special logic also leads to inconsistent behavior in MGS and user
session that confuses customers. After discussion with PM and original
author, we plan to remove it.
(cherry picked from commit c50341bed5d4a727fecebec7385f334e6309fb25)
Bug: 1128725
Change-Id: Ic1b8d9caea9bfcf2517628eb068a65989a9d184b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445014
Reviewed-by: Trent Apted <[email protected]>
Reviewed-by: Bret Sepulveda <[email protected]>
Reviewed-by: Sergey Poromov <[email protected]>
Commit-Queue: Anqing Zhao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815573}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462269
Reviewed-by: Anqing Zhao <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#237}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[identity] Implement clearAllCachedAuthTokens() API
clearAllCachedAuthTokens() cleans up the Identity API state allowing
the extension to implement the sign-out functionality.
clearAllCachedAuthTokens() removes the following data associated with
the extension:
- Gaia id of an account used in getAuthToken()
- All entries in the token cache
- Cookies in the web auth flow storage partitions
(cherry picked from commit 4f5cf7a02126c17363e10dc76666bd0ab671446d)
Bug: 1125847
Change-Id: I95173b0f264d45c5c1222e709594ebc7062d0ac4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398919
Reviewed-by: Devlin <[email protected]>
Reviewed-by: David Roger <[email protected]>
Commit-Queue: David Roger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813098}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462092
Cr-Commit-Position: refs/branch-heads/4280@{#236}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[identity] Enable the latest features by default
This CL enables the following chrome.identity features that are going
to be launched together:
- ReturnScopesInGetAuthToken
- SelectedUserIdInGetAuthToken
- IdentityClearAllCachedAuthTokensEnabled
The flags are kept in code as kill switches and should be removed in
the next milestone.
(cherry picked from commit 10b6f5a94af9616609c3de9d47bbe944bf6ea5fe)
Bug: 1100535, 1125847
Change-Id: Iff75297b1bbb7c4932e1bd9aa311e3d6b6d6a4d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418952
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Alex Ilin <[email protected]>
Commit-Queue: David Roger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814832}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465742
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#235}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android][WebSignin] Hide incognito row when incognito disabled
This CL hides the incognito row when incognito mode is disabled by
the policy IncognitoModeAvailability.
(cherry picked from commit bd984b814fb1af9774340dac42fa21121ba0b8e6)
Bug: 1136777
Change-Id: I44c004870d6cd51b67951bbcbd853a8b11636c95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461319
Commit-Queue: Alice Wang <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815634}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463607
Reviewed-by: Alice Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#234}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4265.0-1601892862-benchmark-87.0.4280.16-r1 to 87-4265.0-1601892862-benchmark-87.0.4280.17-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I4c1d9e11ce469fcb5c52dc546d884fc4f9fd9f23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462736
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#233}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601895675-benchmark-87.0.4280.16-r1 to 87-4265.0-1601895675-benchmark-87.0.4280.17-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I1c29824692f984a723a8aa2c625817027af55c9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465241
Commit-Queue: Chrome Release Autoroll <[email protected]>
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#232}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601890590-benchmark-87.0.4280.16-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.17-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I288a80084c1dbf8f586cd3eb97dc66b87bc5a4db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465722
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#231}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Don't dispatch unload if we've dispatched pagehide with persisted == true
If we've dispatched the 'pagehide' event with the 'persisted' property
set to true, we should not dispatch the unload event after that. This is
because the 'persisted' property is set to the 'salvageable' status of
the page, which also determines whether the unload event is fired.
If 'salvageable' is true, 'persisted' will be true and 'unload' won't
be dispatched. If 'salvageable' is false, 'persisted' will be false
and 'unload' should be dispatched.
Relevant spec PR: https://github.com/whatwg/html/pull/5889
More context: https://groups.google.com/a/google.com/g/chrome-bfcache/c/L-ZreZDY4n0/m/jna_jQJkCQAJ
(cherry picked from commit 67d49f2adf8c7b9dbe6166b152a7901addb02d5c)
Bug: 1110744
Change-Id: I54b44cfdcb6c2922ca57071d695df6c4c2d77d77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455510
Commit-Queue: Rakina Zata Amni <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815898}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463279
Reviewed-by: Rakina Zata Amni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#230}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.18
[email protected]
Change-Id: Ia58283952be7ed8d1c0780575930d4f7821dd52c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465304
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#229}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4265.0-1601892862-benchmark-87.0.4280.15-r1 to 87-4265.0-1601892862-benchmark-87.0.4280.16-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I872d619ccb2756a2de3dd216808f08d275ffca63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464644
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#228}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601895675-benchmark-87.0.4280.15-r1 to 87-4265.0-1601895675-benchmark-87.0.4280.16-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I4a3dd0856766ae8526fde194d67904dda75d6261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465048
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#227}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601890590-benchmark-87.0.4280.15-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.16-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I7cf80faef9bdc7d6bb79e2fdb50b12f3465fefea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465047
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#226}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.17
[email protected]
Change-Id: I3e1b28284ada0261f6b4b1cfd0bf5d5ca25a3ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464905
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#225}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[AppMenu] Custom views highlight their sub view when needed
Lets custom view binders check if their sub view needs to be
highlighted.
This CL needs to be merged to M87 because the CL caused this bug is in
M87.(put R.id.downloads_menu_id into a submenu.)
https://chromium-review.googlesource.com/c/chromium/src/+/2420256
There is also an issue with ChipView, but since ChipView in AppMenu
will be enabled in M88, so we will fix it later.
(cherry picked from commit 312f7ed09dbc071febb7af517e2a2a4c4e5437a3)
Bug: 1133105
Change-Id: I7cce43ff0a2c5ce32222141d54ae8ece09bfc3ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458447
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815173}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464753
Reviewed-by: Gang Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#224}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Passwords] Username editing with b4p
This change makes username editing compliant with Butter for passwords
feature. Account and profile passwords storage are treated as separate
entities for the already used username checkup.
(cherry picked from commit 4046287ce51507f7d701a1f50740e8301d19e7da)
Bug: 1135181
Change-Id: Idac7d0188e16c4053fb52c746a793469a50a0116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450310
Commit-Queue: Viktor Semeniuk <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815120}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463564
Reviewed-by: Viktor Semeniuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#223}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] ambient: Close UI when unlock screen
When the secondary user logs in, the OnLockStateChanged() was returned
due to the Ambient mode is not allowed, therefore the ambient UI is not
closed. This patch moves the close ui logic before the ambient enabled
check.
[email protected]
(cherry picked from commit a2420700b5fe76027115950d18c0619d8951150c)
Bug: 1136302
Test: Added new unittest
Change-Id: I2d9c93087b8e8139936271db2a797f6322bb55ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462246
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: Tao Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815463}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462577
Reviewed-by: Tao Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#222}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 Merge] ambient: check enabled when dismissing UI
(cherry picked from commit 12a341d45031396b8048a4bfa5b990d519ccdf21)
Bug: b:168817491
Change-Id: I4269b354c686613cc172b2e5ffdac6acd27ab780
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464008
Commit-Queue: Xiaohui Chen <[email protected]>
Reviewed-by: Tao Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815842}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464086
Commit-Queue: Tao Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#221}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] [branch only!] Disable use_dawn
Disable ContextLost_WebGPUContextLostFromGPUProcessExit which is not
expected to pass without use_dawn.
Change-Id: I3ac338ba69f8780eb355af4887a63dfbad5c9095
Bug: 985142
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446515
Commit-Queue: Kai Ninomiya <[email protected]>
Reviewed-by: Kai Ninomiya <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#220}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge to M87] Disable cfi-icall for generated stubs
> The generated stubs use dlsym()ed functions, so must not be instrumented
> with CFI-icall.
>
> BUG=1136413
> R=sky
>
> Change-Id: I698e6b3ed96349a2bb477767d54aeb9b3ad9096f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462216
> Commit-Queue: Scott Violet <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Auto-Submit: Thomas Anderson <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#815379}
BUG=1136413
TBR=sky
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Change-Id: I3f0dde34431ca5058930ae063517163f0450e6c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464347
Reviewed-by: Thomas Anderson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#219}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] weblayer: fixs possible NPE if a11y enabled during Tab creation
If a11y is enabled, then Tab creation may trigger calling some
code paths that assume mBrowser was non-null.
BUG=1136596
TEST=TabPrivateTest.testCreateTabWithAccessibilityEnabledCrashTest
(cherry picked from commit 42745534dcdb1a92f4a3b8ecd52ebae7068a0af9)
Change-Id: I500fd70cb56b7d16c22284acb677c06ec57b536d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461714
Reviewed-by: Bo <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815357}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464053
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#218}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.16
[email protected]
Change-Id: I1d24143cbfe77336c25dbdd8418b21d18473306a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464089
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#217}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "Change the location of chrome_renderers cgroup"
This reverts commit 31fcacb34e3c5f3d0be439de2008dac95dc13d81.
Reason for revert: An edge cause for platforms without ARC++ was not handled correctly.
Original change's description:
> Change the location of chrome_renderers cgroup
>
> This changes the location of the chrome_renderers freezer cgroup to
> match pending changes.
>
> /sys/fs/cgroup/freezer/early_freezer/chrome_renderers/to_be_frozen/tasks
> file
>
> Bug: b/134792837
> Test: suspend_stress_test and check for PIDs in
> Change-Id: Ibf76f4e2f6cbb527dd738194f3baea506447f8d1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337546
> Commit-Queue: Derek Basehore <[email protected]>
> Reviewed-by: Achuith Bhandarkar <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#811894}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit 7e63e50f6ec635343e4c54430c61004e05fb76f0)
Bug: b/134792837
Change-Id: I6a35a64b577695ed6406aacaea2834b3d15afcb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451630
Reviewed-by: Achuith Bhandarkar <[email protected]>
Commit-Queue: Derek Basehore <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814850}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464204
Reviewed-by: James Cook <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#216}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "Disable unmount-on-suspend for FUSE"
This reverts commit 436c119d042f7298482f189956d3bc0c7a3b336c.
Reason for revert: An edge case for platforms without ARC++ was not handled correctly.
Original change's description:
> Disable unmount-on-suspend for FUSE
>
> This removes the code for unmounting the FUSEs (filesystem in userspace)
> on suspend. Instead of unmounting to resolve the FUSE/freeze on suspend
> race condition, we will be using powerd code that orders freeze using
> freezer cgroups.
>
> Crostini still has some work left to do before this can be done for it,
> so unmount on suspend for its FUSE, sshfs, will be done in a later
> patch.
>
> Test: "suspend_stress_test -c 2500" on device
> Bug: b/134792837
> Change-Id: Icb8f9e309f6780e6f935be550c6c4e048a44b1fd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336869
> Commit-Queue: Derek Basehore <[email protected]>
> Reviewed-by: Joel Hockey <[email protected]>
> Reviewed-by: Sergei Datsenko <[email protected]>
> Reviewed-by: James Cook <[email protected]>
> Reviewed-by: David Munro <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#811950}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit d0312acf02335caec3670ea6f22244173da276e0)
Bug: b/134792837
Change-Id: Ia50e43dceeb0eea448d6fdf7232af328a9a1fd1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451400
Reviewed-by: David Munro <[email protected]>
Reviewed-by: Sergei Datsenko <[email protected]>
Reviewed-by: Joel Hockey <[email protected]>
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Derek Basehore <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814910}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462232
Cr-Commit-Position: refs/branch-heads/4280@{#215}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
WebUI Tab Strip: Show context menu on right click
The default contextmenu event is prevented because touch drag and drop
on Windows does not interact well with the contextmenu events. Since on
Windows, a mouse can be attached to a tablet and have the UI still be
in tablet mode, a pointerup event is added to determine if a user
actually right-clicks on a tab to invoke the context menu.
(cherry picked from commit 3c3b4c666af77356f65a4074e931a874f77ba7fa)
Bug: 1134282
Change-Id: I92dca4d194905437b6396f42a7be1b6a272ea9e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447091
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814043}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463890
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#214}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Tab Search] Add metrics for tabs with same domains.
Logging the number of tabs in a particular domain along with a rough
estimate of the total number of tabs across all windows.
(cherry picked from commit 22ab811a74c5eb906d8b1132d8710c73008c8c58)
Bug: 1136644
Change-Id: I7c88cc6693b41d34b671342697b20772ef377f88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441285
Commit-Queue: Charlene Yan <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813252}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463988
Reviewed-by: Charlene Yan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#213}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix crash when constructing ClientSideDetectionService
We are seeing crash stacks when constructing the
ClientSideDetectionService since the SafeBrowsingService has not yet
been notified of the creation of the Profile. This is because in
certain circumstances (e.g.
https://crash.corp.google.com/browse?reportid=defdca17c66310c3) a
renderer is created for this Profile before ProfileManagerObservers are
notified. We can solve this by checking for the
DisableClientSidePhishingDetection flag explicitly, instead of calling
into ClientSideDetectionServiceFactory, which has the side effect of
creating a ClientSideDetectionService if it does not yet exist.
(cherry picked from commit 33506f9f4980dfdef94548d5ab68e94a6d1837b1)
Bug: 1131885
Change-Id: If9116613f1914ab1beee25296847840f91c52e78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451523
Reviewed-by: Bettina Dea <[email protected]>
Commit-Queue: Daniel Rubery <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814472}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461064
Reviewed-by: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#212}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
WebUI Tab Strip: Set keyboard focus when opening via keyboard
If the tab strip was opened using a keyboard (and not touch), the view
now tells the UI handler to inform the front-end that keyboard focus
has moved into the tab strip. The front-end will automatically focus the
first tab and add the focus indicators.
(cherry picked from commit f2280797db20582ff3d5c334bc7f406b2be2640e)
Bug: 1135358
Change-Id: I3524e186638c61c128af9d1041d5573774ba14bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449941
Reviewed-by: Collin Baker <[email protected]>
Commit-Queue: John Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814022}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463750
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#211}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Auto expand enhanced protection section when the parameter is set.
(cherry picked from commit 95d24127e78d95ec0c936133a64d844d87b4993e)
Bug: 1130728
Change-Id: I9549b464abedb6e06b706a2923ccf613a99f02ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434884
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814298}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461751
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#210}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add drive mounted check to print preview initialization
Adding |isDriveMounted| to the init functions allows us to prevent the
creation of the Save to Drive destination on Chrome OS when necessary.
(cherry picked from commit 432b8c12127a6d9f3981087a37dc0cf71e3cc693)
Bug: 1112416
Change-Id: I509c5354bf07134b6cce5a9298f9624059a3c37e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441729
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Gavin Williams <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814868}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462171
Reviewed-by: Jimmy Gong <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#209}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Media Controls] Prevent showing dummy media notifications.
This change prevents a blank media notification from being shown (due
to a partially implemented feature) unless the appropriate feature
flags are enabled.
(cherry picked from commit 523480dd9993967b1b1793b7058220d4008825f5)
Bug: 1134356, b/169946872
Change-Id: I54a0575a302e4215f9d3fd98cd39af4d38f944ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453893
Reviewed-by: Tommy Steimel <[email protected]>
Reviewed-by: Takumi Fujimoto <[email protected]>
Commit-Queue: John Williams <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814358}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463927
Cr-Commit-Position: refs/branch-heads/4280@{#208}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Disable KaleidoscopeModule flag
This flag is turned on because originally Kaleidoscope + NTP modules
were launching at the same time. Now NTP modules is launching earlier
which means we need to turn this flag off.
BUG=1136904
(cherry picked from commit 4a9a49638274bba690c3c3b599ca2da66a4cec59)
Change-Id: Ie20a8650f9621dfa85803a397d55a0873f54496d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463330
Commit-Queue: Becca Hughes <[email protected]>
Commit-Queue: Tommy Steimel <[email protected]>
Auto-Submit: Becca Hughes <[email protected]>
Reviewed-by: Tommy Steimel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815692}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463738
Reviewed-by: Becca Hughes <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#207}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Native Cast MRP] Fix the VirtualConnectionType in connection requests
Establish a strong virtual connection in the following cases:
- Launching a session without the invisibleSender field set in its
presentation URL
- Making a connection to receiver-0
Otherwise create an invisible virtual connection, including cases where
we're requesting media status to show in the global media controls.
This is consistent with the behavior in virtual_connection_manager.js
and presentation_url.js in the component extension.
(cherry picked from commit 36670d0e162c07f475ed7957f998089743a42fd7)
Bug: 1133502, b/168566028
Change-Id: I9b7c9c3937bb4ac1f2a95fa2f8aa42a16616971a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439012
Commit-Queue: Takumi Fujimoto <[email protected]>
Reviewed-by: mark a. foltz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814460}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462727
Reviewed-by: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#206}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[m87 merge] Reduce 3d Engine Work for Steady State Video Playback
When DirectCompositionChildSurfaceWin::EnqueuePendingFrame is called if
swap_rect_ is non-empty a d3d11 query is created resulting in 3d engine
work.
Due to an optimization in DirectRenderer::DrawFrame (see
https://source.chromium.org/chromium/chromium/src/+/master:components/v
iz/service/display/direct_renderer.cc;drc=be67975e8044611cc91a8dc5f138e
bd6cf67bbe1;l=402) we are not however currently clearing swap_rect_ by
calling DirectCompositionChildSurfaceWin::SetDrawRectangle with an
empty rect when there is no damage to the root.
As a result after the first SetDrawRectangle call 3d engine work is
performed for each queued frame.
To help reduce the amount of 3d engine work we'll reset swap_rect_ at
the end of SwapBuffers; allowing the d3d11 query to be skipped until
the next new SetDrawRectangle occurs.
(cherry picked from commit b005a9a89d99c78df4c2d99f0a67a7b72e532910)
Bug: 1133916
Change-Id: I84ccf81d18a8e45e1ce871484a763c20e5bb6418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443489
Commit-Queue: William Carr <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812886}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461056
Commit-Queue: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#205}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Don't force close holding space bubble.
We originally force closed the holding space bubble because the view
hierarchy was being destroyed asynchronously which caused a crash when
views attempted to notify HoldingSpaceViewDelegate of their destruction.
That code has been transitioned to use scoped ViewObservers so this is
no longer an issue.
By allowing the holding space bubble to async close, we allow it to run
its default window animation.
(cherry picked from commit 1b397c8b714482a3058e6f5157e9f3522e57423e)
Bug: 1134374
Change-Id: I2211373c7519163619f7be3988c8ddcfa7e1b8bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449832
Reviewed-by: Ahmed Mehfooz <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814350}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461057
Reviewed-by: David Black <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#204}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
ios: Speculative workaround for WebKit dispatchIncomingMessages crash.
Preload appears to trigger an edge-case crash in WebKit when a restore
is triggered and cancelled before it can complete. This isn't specific
to preload, but is very easy to trigger in preload. As a speculative
fix, if a preload is in restore, don't destroy it until after restore
is complete. This logic should really belong in WebState itself, so any
attempt to destroy a WebState during restore will trigger this logic.
Even better, this edge case crash should be fixed in WebKit:
https://bugs.webkit.org/show_bug.cgi?id=217440.
The crash in WebKit appears to be related to IPC throttling. Session
restore can create a large number of IPC calls, which can then be
throttled. It seems if the WKWebView is destroyed with this backlog of
IPC calls, sometimes WebKit crashes.
See crbug.com/1032928 for an explanation for how to trigger this crash.
Note the timer should only be called if for some reason session
restoration fails to complete -- thus preventing a WebState leak.
(cherry picked from commit 8b215cc6f3668926de36b0600e24ca08621c21e9)
Bug: 1032928
Change-Id: I217918437d5cdc6f610f3331634791699dd678ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461571
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Ali Juma <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Auto-Submit: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815667}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462393
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#203}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: I31e5f6c010ded0c10552b424855bd50542c4849d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463591
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#202}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4265.0-1601892862-benchmark-87.0.4280.14-r1 to 87-4265.0-1601892862-benchmark-87.0.4280.15-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I4426cc373ca4638fd695f5146b9fb9a17d3646ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463737
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#201}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601895675-benchmark-87.0.4280.14-r1 to 87-4265.0-1601895675-benchmark-87.0.4280.15-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I1b91aa32c374e04ed616e42cd8c8ece1c6334633
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463786
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#200}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[css-grid] Revert r789122 for performance reasons
r789122 tried to solve bug 1103592, which actually was a flex problem
unrelated to grid, and was later fixed by r789788.
Therefore, r789122 wasn't actually needed, and caused a perf regression.
So this patch reverts its layout changes. The WPT test is kept, and
still passes.
Tbr: [email protected]
(cherry picked from commit e0bb36e5b8a27c6f074765bd3a95d37ea6336e7f)
Bug: 1136474, 1103592
Change-Id: I3788bee4035a43c99b224d39d6f496b6e3dea4f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461311
Commit-Queue: Oriol Brufau <[email protected]>
Reviewed-by: Javier Fernandez <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815289}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463302
Reviewed-by: Oriol Brufau <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#199}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[fuchsia][a11y] Fuchsia hidden nodes are ignored AxNodes.
This change fixes a bug where an invisible AxNode was being remapped to
a hidden Fuchsia node, where an ignored AxNode actually matches the
expected behavior.
Documentation for invisible:
https://chromium.googlesource.com/chromium/src/+/lkgr/docs/accessibility/offscreen.md
(cherry picked from commit b9be8cb05d2d0b716e8e2caca9269cfc716707d2)
Test: AXTreeConverterTest.*
Bug: 1135817,fuchsia:60693
Change-Id: Ice78a489a16d4edd357a9181d7bf3d23a32ffb28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454092
Reviewed-by: Sharon Yang <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Commit-Queue: Lucas Radaelli <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814514}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462670
Commit-Queue: Sergey Ulanov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#198}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601890590-benchmark-87.0.4280.14-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.15-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ia4550523effefa06b509edee842786673ceeabc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463066
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#197}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601286022-benchmark-87.0.4278.0-r1 to 87-4265.0-1601895675-benchmark-87.0.4280.14-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I7218b7e590ad1a76254e4be2110efd9276518fa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463729
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#196}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601289755-benchmark-87.0.4278.0-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.14-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I72210df4dcfb641268e9b02045d63e68bbf563cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463732
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#195}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Signin][Android] Change title for SignInPreference
Changes the title of SignInPreference in the generic promo state to
"Turn on sync" if MobileIdentityConsistency flag is enabled.
(cherry picked from commit 3be31a2775e90a62bc7a443d4471c60dd41c8a3c)
Bug: 1136064
Change-Id: Iba20ed5b946fa3f5522798b762de25bb77ef0f3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456266
Reviewed-by: Alice Wang <[email protected]>
Commit-Queue: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814675}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462131
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#194}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4258.0-1601290734-benchmark-87.0.4277.0-r1 to 87-4265.0-1601892862-benchmark-87.0.4280.14-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Id5432e2e885ae038073c3100dc45ff99fa5239d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463730
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#193}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
indexeddb: emit metrics for blob files not being found
It is unclear what the rate of blob files missing are as a part of this
bug, and so add some metrics to try to get a handle on the scope of the
problem.
FilesystemProxyFileStreamReader is currently only used for
IndexedDBDataItemReader, but this creates a separate entry point and
metrics boolean in case this class gets reused for something other than
IndexedDB.
(cherry picked from commit a48217a054b9e5b4fd0a1167e0a995cbc09701d9)
Bug: 1131151
Change-Id: I4d0610413534fb40edb95e321b6d58e92fdf23ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446889
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Brian White <[email protected]>
Auto-Submit: enne <[email protected]>
Commit-Queue: enne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814286}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463647
Reviewed-by: enne <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#192}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[ios] Don't resize overlay presentation container if insignificant
Upon layout, the container view of the Infobar banner view is resized
to match the size of the banner. But then a subsequently triggered
relayout may have a new banner frame size that is small enough to cause
an infinite loop. Thus, container resizing is only done if the height
and width of the new calculated banner frame are different by more
than 0.01.
[email protected]
(cherry picked from commit 7c051ee54d889fdc605f3718a15f8b01413cf925)
Bug: 1129761
Change-Id: I0b397c63763c392e021bcf54fb7c7a2df8f872eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432661
Reviewed-by: Mike Dougherty <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814502}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463645
Reviewed-by: Chris Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#191}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
ozone/drm: Restore plane->in_use when necessary
HardwareDisplayPlaneManager::BeginFrame currently iterates all the
planes active on a specific crtc and set in_use to false, so that they
can be used when building up the next frame to commit.
Not all the path of HDPM::AssignOverlayPlanes and HDPM::Commit end up
committing the planes though, this means a pageflip test, or a failing
pageflip, might end up leaving |in_use| set to false, while the crtc is
actually still using those planes.
Bug: 1127487
Test: HardwareDisplayPlaneManagerAtomicTest.{AssignPlanesRestoresInUse,PageflipTestRestoresInUse}
(cherry picked from commit d90bd584640234d6a3af7efd854a29f47d5e6b3b)
Change-Id: Iee7f6b87af7e38f9ac7c6dea0687cc37dc4c6493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446831
Commit-Queue: Daniele Castagna <[email protected]>
Reviewed-by: Mark Yacoub <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813807}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461804
Reviewed-by: Daniele Castagna <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#190}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
WebRTC AGC Hybrid experiment: wire-up AGC2 params
ConfigAutomaticGainControl now supports two additional AGC2 params that
are needed for experimentation.
Tested: checked feature activation via AECdump using appr.tc
$ out/Default/Chromium.app/Contents/MacOS/Chromium \
--enable-features=WebrtcHybridAgc
(cherry picked from commit b94bc46084bf09c9e57c9cc0fcbfe770a64bbbe1)
Bug: chromium:1135177
Change-Id: I81225ebc05a66ca18e5c4b2edc350cd42f19c31a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446052
Commit-Queue: Ale Bzk <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813741}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462085
Cr-Commit-Position: refs/branch-heads/4280@{#189}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Use IPolicyStatus2 to get the updater's policies and state.
Use the new COM interface to show the updater's policies and conflicts.
Use the new interface to get the updater's version and the last time
policies were fetched. Maintain compatibility with IPolicyStatus so
that machine with older versions of the updater still show policies.
(cherry picked from commit 2644fc8db25fa9aa5e26f298208636112c434a47)
Bug: 1032756
Change-Id: Iadb2199bcdc704a426e80e00e2bb8aa5b21e0648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380582
Commit-Queue: Yann Dago <[email protected]>
Reviewed-by: S. Ganesh <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Greg Thompson <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814536}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463442
Reviewed-by: Yann Dago <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#188}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Recognize cycles precise as a CPU cycles event
Updated the microarchitecture based unit tests for default commands to
check that the first two commands are sampling CPU cycles.
BUG=b:170056137
(cherry picked from commit c6c7faf8929e816f06ca3c2c7bee9e8398b79f7f)
Change-Id: I6a1a91e4f1b35cb0c3e6ef77dc6aa8a297f831ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450841
Reviewed-by: Gabriel Marin <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Commit-Queue: Gabriel Marin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814154}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462086
Cr-Commit-Position: refs/branch-heads/4280@{#187}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
WebRTC AGC Hybrid experiment: wire-up AGC2 params (+ refactoring)
ConfigAutomaticGainControl now supports more AGC2 params that are
needed for experimentation.
The CL includes a refactoring to avoid base::Optional boilerplate and
it improves the docstring for `ConfigAutomaticGainControl()`.
Tested: checked feature activation via AECdump using appr.tc
$ out/Default/Chromium.app/Contents/MacOS/Chromium \
--enable-features=WebrtcHybridAgc
(cherry picked from commit bdf52e4e5685e5c71668f05d5dee1b4d394587b6)
Bug: chromium:1135177
Change-Id: I0d226b9e7e6f17acb8408af8ded80d80db7cabe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446149
Commit-Queue: Ale Bzk <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813736}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462082
Cr-Commit-Position: refs/branch-heads/4280@{#186}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: Ifc4eaa86a470e2c513519dc06bbf5db0d1ad9604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462230
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#185}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "Ensure that devtools stays visible when window is made smaller."
This reverts commit 43695198d229c690a117c08503c8fdbc726cf15e.
Reason for revert: <crbug.com/1135885>
Original change's description:
> Ensure that devtools stays visible when window is made smaller.
>
> Original CL - https://chromium-review.googlesource.com/c/chromium/src/+/1665550
>
> (cherry picked from commit bb86e3cd3fa7d7c3fa6967436dee57f5ba44669e)
>
> Bug: 974178
> Change-Id: I5792cbd065d1437de2fa44d43407eb70e7b22960
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447094
> Commit-Queue: David Bienvenu <[email protected]>
> Reviewed-by: Andrey Kosyakov <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#814196}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461787
> Reviewed-by: David Bienvenu <[email protected]>
> Cr-Commit-Position: refs/branch-heads/4280@{#144}
> Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[email protected]
Change-Id: I5ffffe0d325ba8fd88641869a4abbb089dc8b749
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 974178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463443
Reviewed-by: David Bienvenu <[email protected]>
Commit-Queue: David Bienvenu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#184}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[iOS] Fixing a crash in AutofillAgent blocks.
Adding a check for _suggestionHandledCompletion in a block prior to
calling it.
(cherry picked from commit 98ac45f34a3d681e728ba0d28f803060679a1f75)
Bug: 1134005
Change-Id: I8a8fae7abe4567925514bd98841d5866f70c2dab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445010
Reviewed-by: Olivier Robin <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Commit-Queue: Maria Kazinova <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813255}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462264
Commit-Queue: Olivier Robin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#183}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android]: Fix Add to Homescreen crash for CCT.
(cherry picked from commit 1980ae7d57f8de7788c34b790fb3403dbcbd5e6b)
Bug: 1130909
Change-Id: I63bb59f057deffd849469538336f959e2b644d99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454084
Reviewed-by: Peter Conn <[email protected]>
Commit-Queue: Finnur Thorarinsson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814658}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461334
Reviewed-by: Finnur Thorarinsson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#182}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add error message for DeviceFamilyLinkAllowed policy
The code using the message will land separately.
(cherry picked from commit 22e02ba6c623901fa702854c58a6e5f6412d9c63)
Bug: 1126155
Change-Id: If2976b959538dd7dc88b75bcfa483619baedc274
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444735
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Aga Wronska <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813233}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461734
Reviewed-by: Aga Wronska <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#181}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[merge-m87] Turn off Release notes feature.
Suggestion chips have been disabled in m86 as they were not working the
way we expected. We decided to disable this feature in m87, which is
fine since there is no release notes for m87.
Bug: b/170356889
Change-Id: Ied2454de22a7c83b3fcdd2581276614d88b9244e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459515
Reviewed-by: Rachel Carpenter <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Reviewed-by: Nancy Wang <[email protected]>
Commit-Queue: Callistus Tan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#180}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "Check for static initializers on linux-chromeos-rel." again.
This is a manual revert of https://crrev.com/810169. The
linux-chromeos-rel trybots have Clang code coverage enabled. This
causes the static initializers check to generate false positives [1] in
some cases. Since there is no proper immediate solution, stop running
the static initializers check to get it out of the way of landing CLs.
[1] https://crrev.com/c/2450491
(cherry picked from commit 7eb46f079a97af1c6aca66e35540315ca211326e)
Bug: 537099
Change-Id: I6ce647aba388925fcb4ea4622128f2687d909b7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454391
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814406}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462628
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#179}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Stop keeping raw pointer of RenderFrameHost in UrlLoaderFactoryProxyImpl
(cherry picked from commit c1b624807138ec25519a7b1a22b94c55fcf5bf26)
Bug: 1128270
Change-Id: I29d6caaba1093baf46d3ac6086db3aca7a4cb4e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449676
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Commit-Queue: Tsuyoshi Horo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814518}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462750
Reviewed-by: Tsuyoshi Horo <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#178}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Update 'take a while' string for Plugin VM installer
(cherry picked from commit 0b515207fc1b8eac5c4286df140c6e48abe327f5)
Bug: b/170414561
Change-Id: I365f19d33a671db88f5275f68d1a720b24159aa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461907
Reviewed-by: Jason Lin <[email protected]>
Commit-Queue: Jason Lin <[email protected]>
Commit-Queue: Joel Hockey <[email protected]>
Auto-Submit: Joel Hockey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815376}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462568
Reviewed-by: Joel Hockey <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#177}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
WebUI Tab Strip: Show contextmenu on dragend, not drop
A drop event is not fired if a drag interaction did not have any x/y
pointer movement. This CL moves the contextmenu call to the dragend,
as the dragevent is consistently sent at the end of every drag flow.
(cherry picked from commit ce8cb6c863842216bf5da62aa68456931db674b5)
Bug: 1117652
Change-Id: I9e3fc078fcc2843808d3db454feb39084b97794d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446353
Commit-Queue: John Lee <[email protected]>
Reviewed-by: dpapad <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813941}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461253
Reviewed-by: John Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#176}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
AW: fix magnifier icon color in dark theme
No change to logic. This adds a drawableTint attribute for the flag UI's
search icon, to ensure this is not too dark when the user has enabled
dark theme. This seems to have regressed due to
https://crrev.com/c/2389229.
(cherry picked from commit 085a7f286012582c42bee21403a09b2e6168e9ac)
Bug: 1135873
Test: manual - enable dark theme and inspect magnifier icon
Change-Id: I2d1f2ba245dbf8911cda10e8f09e94c7c137e255
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455207
Reviewed-by: Hazem Ashmawy <[email protected]>
Commit-Queue: Nate Fischer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814943}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462569
Reviewed-by: Nate Fischer <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#175}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.15
[email protected]
Change-Id: Ic0b27b88bb34f2ada690fd0822336b6f3c0f5994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462667
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#174}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "[fuchsia] Add unittests for message_port.cc, fix flow control bug."
This reverts commit e9a3e3ec451e6ea3cd62dbd10f677a9071628f30.
Reason for revert: Broke Cast Streaming in CastRunner
Bug: 1134815
Original change's description:
> [fuchsia] Add unittests for message_port.cc, fix flow control bug.
>
> Adds unit tests which verify propagation of messages and channel
> events through FIDL/Blink and Blink/FIDL adapter layers.
>
> Fixes a FIDL flow control bug and adds a regression test for it.
>
> Add test main.cc for tests which depend on an active Mojo instance.
>
> Bug: 1117518
> Bug: 1126571
> Change-Id: Ied814298b82f9e5eef1e99b158b45bfdd9d1fd8e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422476
> Reviewed-by: Ken Rockot <[email protected]>
> Reviewed-by: Sharon Yang <[email protected]>
> Reviewed-by: David Dorwin <[email protected]>
> Commit-Queue: Kevin Marshall <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#810858}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit c316b873aade605883547c4a4901e1dfa16277b2)
Bug: 1117518
Bug: 1126571
Change-Id: I9b3079ecf0ed21cb6dfd0c467e20ed8dfbb78f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447098
Reviewed-by: Fabrice de Gans-Riberi <[email protected]>
Commit-Queue: Fabrice de Gans-Riberi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813470}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461722
Cr-Commit-Position: refs/branch-heads/4280@{#173}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge to M87] Disable lacros for non-google managed users.
(cherry picked from commit dc55cea9edc00e9acf3001d69ca1d61cf24f3f22)
Bug: 1135494
Change-Id: Ife13223dea213e57427803bc6cae97e492608a25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458848
Commit-Queue: Erik Chen <[email protected]>
Auto-Submit: Erik Chen <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814955}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461223
Cr-Commit-Position: refs/branch-heads/4280@{#172}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[fuchsia] Handle inject namespace in Cast Streaming Receiver
This handles messages from the injec namespace in the Cast Streaming
Receiver by returning a "Not supported" message to the sender.
(cherry picked from commit 8e0afeda109cd06b20891e155392a94dd3a6960a)
[email protected]
Bug: 1134435, b/165087393
Change-Id: I866c76a72ba42e127def953563762b095491cc28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441940
Commit-Queue: Fabrice de Gans-Riberi <[email protected]>
Reviewed-by: Kevin Marshall <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813319}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462380
Reviewed-by: Fabrice de Gans-Riberi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#171}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix ContextualSearchManagerTest suite failures.
(cherry picked from commit 07eb09765449749304be72040b3a562d61fbc742)
Bug: 1132948
Change-Id: I48988ab9e0aa9b8f17e93674ad443225b30ef837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446778
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813381}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462346
Reviewed-by: Xi Han <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#170}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge] [Siri Shortcuts] Add metric for Siri Shortcuts count
Adds a metric to record the number of Chrome Siri Shortcuts the user has
created in the Siri Shortcuts app. This is recorded once at startup, as
a delayed startup task on the IO thread (to avoid hangs while querying
iOS for the list of shortcuts).
(cherry picked from commit 1fbba0370b3d85703f5e38c4b2d5dcce4e14b7ac)
Bug: 935211
Change-Id: I70766050ba7faf5fb343e3515c98ff6ddca98bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429306
Commit-Queue: Guillaume Jenkins <[email protected]>
Reviewed-by: Justin Cohen <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813030}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461938
Cr-Commit-Position: refs/branch-heads/4280@{#169}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[ntp][modules] Add NewTabPage.ShoppingTasks.[Product|RelatedSearch]Click
These histograms let us analyze usage of the shopping task module in
more granularity than what NewTabPage.Modules.Usage.shopping_tasks
allows.
(cherry picked from commit 41b76929242c1370b20f9733a60673755225875c)
Bug: 1133904
Change-Id: Id7470f6b2f0cbb7553dba406e57d5f62afd788c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443392
Reviewed-by: Emily Stark <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Auto-Submit: Tibor Goldschwendt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814394}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459253
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#168}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[WebOTP] Record timing related UKMs
There are UMA metrics to measure the duration from when the API is
called to when the SMS is received / a user clicks "Allow" to complete
the flow. We want to add corresponding UKMs to help with the feature
adoption.
Note that the UKM that records the duration from when the API is called
to when a user clicks "Deny" to abort the flow will be added in a
follow up patch after crrev.com/c/2428825.
UKM collection review:
https://docs.google.com/document/d/15orQiLx06QSuZr4ShBaozY0dvPzXiTWwJZ9Xk5cgzAA/edit?usp=sharing
(cherry picked from commit a9fafab17f1d8e5fa26a09c1b19db22ca960c5a9)
Bug: 1127402
Change-Id: I204bd469ca203182eba6a37f3522d7a492cc937d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429236
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Sam Goto <[email protected]>
Reviewed-by: Majid Valipour <[email protected]>
Commit-Queue: Yi Gu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814701}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462315
Reviewed-by: Yi Gu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#167}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Do not bind web_contents directly in OnArcHandled
It seems that web_contents may be destroyed during
RunArcExternalProtocolDialog (See TODO comment in the code).
See crashes in crbug.com/1136237
So rather than bind web_contents directly into OnArcHandled(), we use
render_process_host_id and routing_id to look it up at the end as was
happening in ShowFallbackEternalProtocolDialog() prior to
crrev.com/c/2423067.
(cherry picked from commit 4c77220993014cbb8388c7b13063773678878afe)
Bug: 1136237
Change-Id: If0bc1287f9eedbf2b915cd97e049a19f379254ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460067
Commit-Queue: Xiyuan Xia <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Auto-Submit: Joel Hockey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815200}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461899
Reviewed-by: Joel Hockey <[email protected]>
Commit-Queue: Joel Hockey <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#166}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87]Count ImpressionUntilAction using Linear Histogram.
(cherry picked from commit c238fd2e0b93542d26b786f825f79c891cda0fba)
[email protected]
Bug: 1135838
Change-Id: Ie1c0b2e6c866282b5233edf2b8fbe513d7f2d1ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454730
Reviewed-by: Xinghui Lu <[email protected]>
Commit-Queue: Bettina Dea <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814526}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461211
Reviewed-by: Bettina Dea <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#165}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: Ib52bae5193a1e3ba0e7adb6add2231eaddd06327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461946
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#164}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[LargestContentfulPaint] Add experimental LCP for AMP
UKM privacy review:
https://docs.google.com/document/d/1M1nsLapTIoNgaD8SXtrqEirVQajYKmfmQKHbtI7J6-w/edit#heading=h.k5jx6iluw4yt
(cherry picked from commit 82d1c5d8c7909a8e10dc77b446d63b0c7ff84a5c)
Bug: 1045640
Change-Id: I09e2e779f28d42e3760ed1acaf08c7614e3f9194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450909
Reviewed-by: Annie Sullivan <[email protected]>
Reviewed-by: Bryan McQuade <[email protected]>
Commit-Queue: Nicolás Peña Moreno <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814700}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462098
Reviewed-by: Nicolás Peña Moreno <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#163}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: I84472d28852757db67fa9a5bd3eb2880d14050a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460755
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#162}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[omnibox] Fix several more issues in Pedals language data
This CL includes data fixes for several languages to
improve Pedal triggering. Issues resolved include:
Stray capitalization, duplicate synonyms, synonyms
consisting entirely of a single dash, separators consisting
only of a single dash, empty cell gaps, and synonyms
consisting entirely of ignore group synonyms.
(cherry picked from commit c2aef3a0675d7c25ab0a8f82f898dfc853b2b4d2)
Bug: 1134770
Change-Id: Iabc8099db437e518ef2deea34fd41329985e5b8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446823
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: Orin Jaworski <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813421}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460861
Reviewed-by: Orin Jaworski <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#161}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add histograms for user activation notification types.
We have already classified all NotifyUserActivation callers with a
notification-type to distinguish between actual vs various synthesized
user activations. This CL adds histograms to count the number of times
activation-gated-APIs are actually affected by each notification-type in
the wild. If a synthetic trigger turns out to be unnecessary, we would
blindly remove them. We will then investigate the remaining
ones one-by-one.
For each class of activation-gated-APIs [1], we are counting the number
of "successful" API calls for each notification-type. To be precise:
- For sticky user activation, the very first notification-type is
considered to be the effective trigger.
- For transient user activation, the last (unexpired) "real" user
activation (of type kInteraction) is considered to be the effective
trigger. If there is no such activation, the last (unexpired)
synthetic activation is considered instead.
- For Consuming APIs, the effective trigger is the same as in the
transient case above.
[1] https://html.spec.whatwg.org/multipage/interaction.html#user-activation-gated-apis
(cherry picked from commit 7484fe50d43e55776e6008188b633ce074351d8a)
Bug: 1103249
Change-Id: I6db044125ff93835ce63a00b6e3ca0d9f3499e4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437486
Commit-Queue: Mustaq Ahmed <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Robert Flack <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814891}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461827
Reviewed-by: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#160}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[WebOTP] Rename metrics Outcome.Timeout to Outcome.UnhandledRequest
Currently when an SmsService has unhandled request upon destruction, e.g
navigating away, we record "Timeout" as an outcome. This is misleading
because "Timeout" should refer to the user consent prompt being timeout.
This patch renames Timeout to UnhandledRequest and the follow up patch
crrev.com/c/2427560 records the right Outcome.Timeout.
(cherry picked from commit 3b230450d4e83d5d791f3dcdaad718f7274ca033)
Bug: 1127397
Change-Id: I151d5f087c416136bc042d12086df3185dbf2b60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424894
Reviewed-by: Ken Buchanan <[email protected]>
Reviewed-by: Sam Goto <[email protected]>
Reviewed-by: Majid Valipour <[email protected]>
Commit-Queue: Yi Gu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813419}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460863
Reviewed-by: Yi Gu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#159}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[ntp][modules] Filter out dismissed shopping tasks
(cherry picked from commit 8950ee715ddf6019951adcfbecb9f7ea573d8f39)
Fixed: 1130861
Change-Id: I16f50fadf195a3ae6923e630781c36ba17ce7b1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439558
Commit-Queue: Moe Ahmadi <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Auto-Submit: Moe Ahmadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813304}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460757
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#158}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[remoting host] Enable sending of the RTC event log.
This creates a new FileTransferMessageHandler on a separate data
channel, which can send the host's RTC event log as a file-download.
(cherry picked from commit f050b8dee3e91020d99dffaffd708de2248bcc4e)
Bug: 1122798
Change-Id: Icb76e63a790054c45d540c5f20222edbd2086b4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450891
Commit-Queue: Lambros Lambrou <[email protected]>
Reviewed-by: Erik Jensen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814511}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461489
Reviewed-by: Lambros Lambrou <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#157}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
More PageInfo UX fixes
Fix PageInfoRow alignment. Use equal icon sizes.
Limit dialog height to 90%.
Show faded edge when scrolled content is available.
Remove bottom padding for main page.
(cherry picked from commit f637b4367194796ad3db89a92c77adcc7ab9c22f)
Tbr: [email protected]
Bug: 1135124
Change-Id: I89e36162a9b5348485f7d9c4e4c0ba535b018212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456806
Reviewed-by: Ehimare Okoyomon <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814768}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461370
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#156}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix flakes and re-enable tests in FeaturePromoSnoozeInteractiveTest
The flakes seemed to be caused by
interactive_test_utils::MoveMouseToCenterAndPress() sometimes clicking
the wrong button, or no button at all.
This CL instead simulates clicks by calling View::OnMouseEvent
directly on the target buttons.
(cherry picked from commit 166a2dfd56d3dfefe89a5b9baae02e1a658a2464)
Bug: 1135850
Fixed: 1134534
Change-Id: Ic73acffd2496f8c2fc20b33d8d2553cca97cdb26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454632
Commit-Queue: Collin Baker <[email protected]>
Reviewed-by: Robert Liao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814479}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461982
Reviewed-by: Collin Baker <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#155}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Conditional logging in Feed V1
(cherry picked from commit cac85ac00c0b465743d2ce852ea7a8f7dea5c4c7)
Bug: 1135935
Change-Id: I4378c135745eff9693a7d013d423a6f018dee649
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440907
Commit-Queue: Vincent Boisselle <[email protected]>
Reviewed-by: Henrique Nakashima <[email protected]>
Reviewed-by: Dan H <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813909}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462040
Reviewed-by: Vincent Boisselle <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#154}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Access Context Auditing: Only write cookie accesses in bulk
Improve performance of recording cookie accesses by only writing the
existing in memory cookie store to the database on top level frame
origin change, or on record access.
(cherry picked from commit 84d7e0ed8b079172aafc3df822c0fe8ca8eae675)
Bug: 1136016
Change-Id: I97159f75d4afaea004da00b3a37988816a972f88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450281
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814641}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461015
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#153}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix PageInfo UX issues
Set android:includeFontPadding="false" to better align favicon with URL.
Use padding instead of margin to get the right background color.
Show details link if there is a connection message.
Show red warning triangle if there is a connection security issue.
Also includes some general cleanup for margins.
(cherry picked from commit 1d19072f711fe7fd6c72864322689939ebfd9600)
Bug: 1135124
Change-Id: Iff1f880b51a2a8bd60ef0606afec03fea82e9318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449372
Reviewed-by: Ehimare Okoyomon <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813785}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461233
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#152}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
cfm: Fix feature flags for CfM client services
Build and Feature flags disables CfmHotlineClient dbus registation for
none CfM devices; as such ensure gating logic accurately disables all
CfM specific code paths in chromium.
BUG=b:170262024
TEST="autoninja -C ~/chromium/src/out_excelsior/Release chrome"
(cherry picked from commit 56e3e262fc61c3c01c2683c436aeec85c85ea217)
Change-Id: I6e47187cd667a191333c829494f5088b0df58d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459170
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Kyle Williams <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814951}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461546
Commit-Queue: Xiyuan Xia <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#151}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[ntp][modules] Logs histograms when modules are dismissed or restored
(cherry picked from commit 51260b6f4409f5bfcc90882d5770edc3970889d0)
Fixed: 1130864
Change-Id: I5ca24433cb2892a8a1e8f243b6f280f9389b66ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442092
Commit-Queue: Moe Ahmadi <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Auto-Submit: Moe Ahmadi <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812880}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459169
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#150}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android] Update permissions page info string after subpage change
(cherry picked from commit 96cbd6b2758271041573aad91aff5cd43e537a55)
Bug: 1135107
Change-Id: Ieac6fff15f9a5a2c69ee6e136d481d86b5a71060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449251
Reviewed-by: Christian Dullweber <[email protected]>
Commit-Queue: Christian Dullweber <[email protected]>
Commit-Queue: Ehimare Okoyomon <[email protected]>
Auto-Submit: Ehimare Okoyomon <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813702}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460737
Reviewed-by: Ehimare Okoyomon <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#149}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
m87: Add test coverage for editable events
This change precisely stipulates the events handled for each type of editable
encountered through tests.
TBR=[email protected]
pressing 'e' would also cause sticky mode to turn off.
(cherry picked from commit 788cc609e1a8f386aec22cfbf8d06fe8dc984a5f)
Fixed: 1135118
AX-Relnotes: fixes an issue in Smart Sticky mode where jumping to a text field by
Change-Id: I56de4cebc0a1a942d99c5d0c9445b5b33f9d4e00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448053
Reviewed-by: Akihiro Ota <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814056}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461607
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#148}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge "Stop recreating keychain item for SC private API"
Merge into M87
The chrome.enterprise.reporting_private.getPersistentSecret return
-25300(errSecItemNotFound). It's likely caused by keychain item
recreation. Disable the feature for now to relieve the issue on Stable.
Bug: 1136089
(cherry picked from commit 7697f17e6b7e9beb34e5f2ac0b092d389ca8ca3b)
Change-Id: Icbd96ce81a448e1069c3adee08bfca19a66b4bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456509
Reviewed-by: Julian Pastarmov <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Commit-Queue: Owen Min <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814698}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461975
Cr-Commit-Position: refs/branch-heads/4280@{#147}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Paint Preview] Disable user input during upgrade animation
When upgrading to the live tab, the paint preview can keep flinging.
We need to disable this, among all other user inputs to avoid confusion.
(cherry picked from commit 5e9425e6766b51b6e9e2c4d5e8e8419e0523497c)
Bug: 1135688
Change-Id: Id3f25972f75a00bdbf070986ee0c4a529a6f3f4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453496
Reviewed-by: Calder Kitagawa <[email protected]>
Commit-Queue: Mehran Mahmoudi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814423}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461978
Reviewed-by: Mehran Mahmoudi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#146}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Signin]: Fix for crash in UserManagerProfileDialog::DisplayErrorMessage
The code assumes if no browser exists for the profile where the signin
is happening then the sign in error is related to the user manager. The
previous assumption is not valid if the user decides to close the
profile while the user manager or another profile is open. This CL
compares the profile path with |UserManager::GetSigninProfilePath| and
only in case of equality uses
|UserManagerProfileDialog::DisplayErrorMessage| to show the sign in
error.
(cherry picked from commit cd678f5658aef27bf7b2d54b027da57d19d0235c)
Bug: 1132175
Change-Id: Icccdc44d3927d8750bea9957120d7fef6677c4aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435309
Commit-Queue: David Roger <[email protected]>
Auto-Submit: Monica Basta <[email protected]>
Reviewed-by: David Roger <[email protected]>
Reviewed-by: Mihai Sardarescu <[email protected]>
Reviewed-by: Owen Min <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814147}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461116
Reviewed-by: Monica Basta <[email protected]>
Commit-Queue: Monica Basta <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#145}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Ensure that devtools stays visible when window is made smaller.
Original CL - https://chromium-review.googlesource.com/c/chromium/src/+/1665550
(cherry picked from commit bb86e3cd3fa7d7c3fa6967436dee57f5ba44669e)
Bug: 974178
Change-Id: I5792cbd065d1437de2fa44d43407eb70e7b22960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447094
Commit-Queue: David Bienvenu <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814196}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461787
Reviewed-by: David Bienvenu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#144}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[merge M87][blink scheduler] Enable OptOutZeroTimeoutTimersFromThrottling by default.
setTimeout(..., 0) can be used to schedule a continuation. Opting out
these timers from throttling reduces latency to receive notifications
on some background pages and does not significantly affect speed or
resource usage.
Full cleanup will happen after the 1% Stable Experiment is complete.
Experiment results: https://docs.google.com/document/d/1frGCY_ZCM0VYwThAVAxNRvEDnd5hbAHDgkyA5Tsawts/edit?usp=sharing
(cherry picked from commit ddb94c4251feef1de8b3bd150f57e20b8c054fa3)
Bug: 1075553
Change-Id: I0c1546d13e0aa8891479370ffb1706b75c9c77d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443230
Commit-Queue: François Doray <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Scott Haseley <[email protected]>
Auto-Submit: François Doray <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813925}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461151
Reviewed-by: François Doray <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#143}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: I8e738ef92d130849252a4bbdd9a1614d2e888e26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461706
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#142}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[signin] Add metrics to indicate the OAuth outages in Dice.
(cherry picked from commit c20c4f1610b3d3b8d0e0c01d6d84c60067a970f2)
Bug: 1115247
Change-Id: I021ed4188b4aca948b54df2af0117c6a5ce9f398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445490
Commit-Queue: David Roger <[email protected]>
Reviewed-by: Brian White <[email protected]>
Reviewed-by: Monica Basta <[email protected]>
Reviewed-by: David Roger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814620}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460731
Cr-Commit-Position: refs/branch-heads/4280@{#141}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] Fix "Crash after closing last tab twice" bug.
Call |contentWillAppearAnimated| on the tab grid view controller before
dispatch_async.
(cherry picked from commit 5ca68536b60ad71549df5952fc6602213153186b)
Bug: 1134718, 1134062
Change-Id: Id8c61f596bdf69371f9b126e671d621eac54dbd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449349
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Roberto Moura <[email protected]>
Auto-Submit: Roberto Moura <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814596}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453292
Commit-Queue: Gauthier Ambard <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#140}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix dragging of images out of the browser
When porting StartDragging to Mojo in https://crrev.com/c/2320268, the
image contents weren't being set in the drop data. This resulted in a
link being saved on Windows and an error shown on Linux.
(cherry picked from commit 35b04f213302a76240a199e0b18ff48d8259a10c)
Bug: 1039255, 1132953
Change-Id: I2d21e0424c89306d5df8caf940e93999d16f78f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444996
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Henrique Ferreiro <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813645}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461228
Reviewed-by: Henrique Ferreiro <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#139}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
(Merge): [iOS][Safety Check] Add mediator tests
Added Tests:
StartingCheckPutsChecksInRunningState
CheckStartButtonDefaultUI
ClickingCancelTakesChecksToPrevious
CheckStartButtonCancelUI
TimestampSetIfIssueFound
SafeBrowsingEnabledReturnsSafeState
SafeBrowsingSafeUI
SafeBrowsingDisabledReturnsInfoState
SafeBrowsingUnSafeUI
SafeBrowsingManagedUI
PasswordCheckSafeCheck
PasswordCheckSafeUI
PasswordCheckUnSafeCheck
PasswordCheckUnSafeUI
PasswordCheckErrorCheck
PasswordCheckErrorUI
OmahaRespondsUpToDate
UpdateCheckUpToDateUI
OmahaRespondsOutOfDateAndUpdatesInfobarTime
UpdateCheckOutOfDateUI
OmahaRespondsError
UpdateCheckOmahaErrorUI
UpdateCheckNetErrorUI
UpdateCheckManagedUI
UpdateCheckChannelUI
(cherry picked from commit d7b3298d8b60ef8001d5da4a9f6021dcee727991)
Bug: 1078782, 1135128
Change-Id: I61d155817bc13b96fb581fa4a77426ac56deae6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436530
Commit-Queue: Sean Harrison <[email protected]>
Reviewed-by: Viktor Semeniuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813001}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454074
Reviewed-by: Sean Harrison <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#138}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add Chip to UI dispositions enum for metrics.
This patch adds Chip (under the value LOCATION_BAR_LEFT_CHIP) to the
PermissionPromptDisposition enum in permission_uma_util. Since it's hard
for PermissionRequestManager to determine whether the chip is being
shown as it currently does, this patch also moves the logic for getting
the disposition to PermissionPrompt.
(cherry picked from commit 87d183ab10cdd5ac9464f121785fd74b8990eb74)
Bug: 1019129
Change-Id: I56563d245fdf84a6e5acadb361695a15ae775e33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438389
Auto-Submit: Bret Sepulveda <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Commit-Queue: Bret Sepulveda <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813107}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460887
Reviewed-by: Bret Sepulveda <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#137}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android][WebSignin] Add metric SuppressedSigninNotAllowed for account picker
This CL adds a metric SuppressedSigninNotAllowed to
Signin.AccountConsistencyPromoAction when web sign-in bottom sheet is
not shown due to sign-in not allowed.
(cherry picked from commit b709fc4209f19a2a64f479b05b4891235fc343c8)
Bug: 1135096
Change-Id: Ic2f3334a28c1a46da955ed4bd1069f3d76651e00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450090
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Alice Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814583}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460811
Reviewed-by: Alice Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#136}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
media/gpu/v4l2vea: allocate as many buffers as possible in DMABUF mode
If we are operating in DMABUF mode, then we will try to keep the same
frame assigned to the same V4L2 buffer. However we don't know in advance
how many different frames the encoder will use, only that it is probably
larger than the default 2 we are currently allocating. If we undershoot
then we will spend a lot of time in-kernel unmapping/remapping DMABUFs.
Try to prevent this by allocating as many buffers as allowed by the V4L2
API (32) when operating in DMABUF mode. Since these buffers won't have
backing memory unless we attach a DMABUF to them, they are virtually
free if unused.
BUG=b:159688625
BUG=b:167412992
TEST=video.EncodeAccel.h264_360p_i420 passes on Kukui.
(cherry picked from commit 414e7336564cfaabededbbbc5d265af342dddd8c)
Change-Id: Ia24a6bd8574f5d3894237ca0e563ea4cbff3a631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415911
Commit-Queue: Alexandre Courbot <[email protected]>
Reviewed-by: Fritz Koenig <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813545}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460228
Reviewed-by: Alexandre Courbot <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#135}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
media/gpu/v4l2vea: use buffer affinity tracker
When using DMABUFs, it is preferable to use the same V4L2 buffer with
the same underlying buffer, as failure to do so results in memory
unmappings/remappings in the driver. Use the newly introduced buffer
affinity tracker and V4L2Queue::GetFreeBufferForFrame() method to
achieve this transparently in the video encoder.
BUG=b:159688625
BUG=b:167412992
TEST=video.EncodeAccel.h264_360p_i420 passes on Kukui.
(cherry picked from commit b2a7b0cc4ec6752e1ada55112ceefa2097f3d364)
Change-Id: I050c29ecf8b364869f687c3d8632718aef868144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415910
Commit-Queue: Alexandre Courbot <[email protected]>
Reviewed-by: Fritz Koenig <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813514}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459938
Reviewed-by: Alexandre Courbot <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#134}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
media/gpu/v4l2vd: allocate as many buffers as possible in DMABUF mode
If we are operating in DMABUF mode, then we will try to keep the same
frame assigned to the same V4L2 buffer. However we don't know for sure
how many different frames the decoder will actually use, and if we
undershoot then we will spend a lot of time in-kernel
unmapping/remapping DMABUFs.
Try to prevent this by allocating as many buffers as allowed by the V4L2
API (32) when operating in DMABUF mode. Since these buffers won't have
backing memory unless we attach a DMABUF to them, they are virtually
free if unused.
BUG=b:159688625
BUG=b:167412992
TEST=video.DecodeAccel.h264 passes on Kukui.
TEST=video.DecodeAccel.h264 passes on Trogdor.
(cherry picked from commit 3586760909343160d9bb64e7c11632c5401b636c)
Change-Id: Icd6282c3902654a54958d6346c60affd45555e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434113
Commit-Queue: Alexandre Courbot <[email protected]>
Reviewed-by: Fritz Koenig <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813503}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459699
Reviewed-by: Alexandre Courbot <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#133}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Get supported formats before sandboxing
This CL fixes a bug that will cause camera failed to play the preview.
Bug: b/166850715
Test: Launch Chrome Camera app and preview is shown
(cherry picked from commit 4df0e8baa6c73a960a6a3e34d484135b95ef1d58)
Change-Id: If61d74dc9478bc6138389b9fa6c0dded5a6e8359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454592
Commit-Queue: Wei Lee <[email protected]>
Reviewed-by: Peng Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814705}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459847
Reviewed-by: Wei Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#132}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
media/gpu/v4l2vd: use buffer affinity tracker
When using DMABUFs, it is preferable to use the same V4L2 buffer with
the same underlying buffer, as failure to do so results in memory
unmappings/remappings in the driver. Use the newly introduced buffer
affinity tracker and V4L2Queue::GetFreeBufferForFrame() method to
achieve this transparently in the video decoder.
Furthermore, it is a requirement of the V4L2 stateful decoder interface
that V4L2 buffers are always backed by the same underlying memory, lest
some reference frames lifetime tracking might be incorrect.
BUG=b:159688625
BUG=b:167412992
TEST=video.DecodeAccel.h264 passes on Trogdor.
(cherry picked from commit 2ca56c5955a7fd3acde86a492385e661e3cdaeb1)
Change-Id: I220a321d5584f50406480c105844a82dd96e63c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415909
Commit-Queue: Alexandre Courbot <[email protected]>
Reviewed-by: Fritz Koenig <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813178}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459405
Reviewed-by: Alexandre Courbot <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#131}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] scanning: Add scan button to scanning app
Add a scan button to the scanning app. When the button is clicked, use
the ScanService to perform a scan with the selected scanner and
settings.
(cherry picked from commit d90a982cb13c1465a00b3916c8ab740563ff5b85)
Bug: 1059779
Change-Id: I52231a5a49fa01a2b56e42bcf2f9842fdf54ddf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437103
Auto-Submit: Jesse Schettler <[email protected]>
Reviewed-by: Jimmy Gong <[email protected]>
Commit-Queue: Jesse Schettler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814535}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460127
Reviewed-by: Jesse Schettler <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#130}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
M87: Disable the adaptive icon feature for M87
Fix unit tests when the flag is disabled.
BUG=1083331
(cherry picked from commit 102f1058537fa00f4238eec0d3c0c12538cc1d6b)
Change-Id: Ic4cdc5a089ca672b4a79b345eff18ebcb4ccd82b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442989
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Nancy Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813027}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452272
Cr-Commit-Position: refs/branch-heads/4280@{#129}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
media/gpu/v4l2: add buffer affinity tracker
Add a small tracker that will always return the same V4L2 index when
given the same VideoFrame. This ensures that video buffers are always
assigned to the same V4L2 buffer, avoiding unmappings/remappings in the
kernel.
BUG=b:159688625
TEST=video.DecodeAccel.h264 passes on Kukui.
(cherry picked from commit b25a8522356556a1899e44e0159ceb6e2e7abf8d)
Change-Id: I4c439109891b0c02b607f2b238d21a4cca3a9c67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413945
Commit-Queue: Alexandre Courbot <[email protected]>
Reviewed-by: Fritz Koenig <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813078}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459404
Reviewed-by: Alexandre Courbot <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#128}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
CCA: Prevent chromevox navigate to preview video element
The preview video element is not interactable with chromevox. This CL
prevent chromevox navigate to preview by creating preview video from
template with aria-hide=true.
Bug: 1135052
Test: Manually with chromevox
Test: tast run <DUT> "camera.CCAUI*"
(cherry picked from commit 43be207790e2dec2d1cf182c11cd3a684bc0df2a)
Change-Id: I1dfc87b564dd1db119c10643b587fa254470493a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454913
Auto-Submit: Inker Kuo <[email protected]>
Commit-Queue: Shik Chen <[email protected]>
Reviewed-by: Shik Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814585}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459934
Reviewed-by: Inker Kuo <[email protected]>
Commit-Queue: Inker Kuo <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#127}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] scanning: Replace custom events with data bindings
Instead of firing custom events when dropdown selections are changed,
use data bindings to set the scanning-app element's properties to the
selected values.
(cherry picked from commit 401353ef23bb65ec1bc3f4939fbc8b69e88e4729)
Bug: 1059779
Test: Select a scanner and verify its capabilities are obtained.
Change-Id: If8927a4898dca25720c7f8550fe640fad160178a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448668
Reviewed-by: Jimmy Gong <[email protected]>
Commit-Queue: Jesse Schettler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813959}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460146
Reviewed-by: Jesse Schettler <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#126}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] scanning: Add page number to page callback
Add the page number to the page callback so that ScanService can include
it in filenames when saving scanned images.
(cherry picked from commit 8db6ec01cc43c20c8df8b9e6c4ef6fd6f86e5c44)
Tbr: [email protected]
Bug: 1059779
Change-Id: I3085b6e180d0d60e8afc85be071d6370a08c2573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445670
Commit-Queue: Jesse Schettler <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813825}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459511
Reviewed-by: Jesse Schettler <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#125}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] scanning: Support default source type in scan app
When a scanner reports no source options, lorgnette reports a default
source type in the scanner capabilities. Update the scan app to support
this default source type.
(cherry picked from commit 604098c01768d7c963affc344451493c8d666bfb)
Bug: 1059779
Change-Id: Ib666ea8199404666291b5e8ae9fb43601c3c4774
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443532
Reviewed-by: Jimmy Gong <[email protected]>
Commit-Queue: Jesse Schettler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813464}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459510
Cr-Commit-Position: refs/branch-heads/4280@{#124}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] scanning: Add and implement ScanService::Scan()
Add and implement ScanService::Scan() to allow clients to perform scans.
The ScanService currently saves each scanned image to the user's
"My files" folder, but future changes will allow clients to specify the
file type and save-to location.
(cherry picked from commit f51b8af429aef505d4f6c00a2e1f82c9d6f3a695)
Bug: 1059779
Change-Id: I628571f8663498bc8499e9b7e53d1d6b144a0816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436385
Commit-Queue: Jesse Schettler <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Zentaro Kavanagh <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813480}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458950
Cr-Commit-Position: refs/branch-heads/4280@{#123}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge to M87] Add flags for reverse scrolling
This CL adds a flag for the reverse scrolling features:
- kReverseScrollGestures: enable reverse scroll gestures
(cherry picked from commit 75bb1ae7903b031d27429838340fae6454e79b49)
Bug: 1107183
Change-Id: Id1f918bacbca2726300927e7bf0e680b9237053b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419922
Commit-Queue: Xiaodan Zhu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814922}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459509
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#122}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix flaky UploadClientTest.CreateUploadClient test
The flakiness seems to be a test issue: apparently calling waiter.Signal
by the callback directly sporadically blocks. The fix moves this call
to a threadpool, and after that change 100 runs got no failures under
stress (without the fix about 20 runs out of 100 crash).
I would prefer to move whole callback to the thread in
DmServerUploadService, but all my attempts to do so still ended up with
the test being flaky.
We may need a better fix inside the code rather than the test, but for
now I see no other option.
(cherry picked from commit 2b9f58095ad003bb644ad827d3083cd2de8ffb5f)
Bug: 1133968
Change-Id: I8ecde7f5c65911b75679cae5130985713233016f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448657
Auto-Submit: Leonid Baraz <[email protected]>
Commit-Queue: Zach Trudo <[email protected]>
Reviewed-by: Zach Trudo <[email protected]>
Reviewed-by: Leonid Baraz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813758}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458949
Commit-Queue: Leonid Baraz <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#121}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 Merge] ambient: dismiss on fingerprint detected
(cherry picked from commit 93b380cbbdc4340efb9d8ac43c872ca25d33218e)
Bug: b:168817491
Test: manually on nocturne device
Change-Id: I1880d34622542f4e74a4def22dd012ea92584156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454386
Reviewed-by: Tao Wu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814838}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458785
Cr-Commit-Position: refs/branch-heads/4280@{#120}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] scanning: Remove Optional wrapper from callback
The progress_callback is already nullable, so it doesn't need to be
wrapped with base::Optional.
(cherry picked from commit d7a13f38277b3917ca7d0dbff3ff3a8044163c0a)
Tbr: [email protected]
Bug: None
Change-Id: Ifb43c88ab59b2ec0208225359b11070407fc5912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442571
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Jesse Schettler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813450}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459254
Reviewed-by: Jesse Schettler <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#119}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
cros: Only render img or table tags
For clipboard history, only render img or table tags
when a new flag is enabled. This flag will be enabled via
finch at a later date so we can compare usage.
(cherry picked from commit 0729852ddc32f78474e9232b3c22437d08df7662)
Bug: 1131691
Change-Id: I21aa05c4daa5a80f0037c8507e0e32eda1f04bc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441258
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812904}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459407
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#118}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.14
[email protected]
Change-Id: I650dab7f536c6fd083640b5ec83e90bb5b720ebb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459949
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#117}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Reland "WebUI Modules: shopping tasks, hide elements that do not fit"
Fix flaky test and reland CL.
(cherry picked from commit 10ced8a9df910d4c2d2cc12c21a931b62c764d16)
Bug: 1134274
Change-Id: I58452d5264e36eb838e4e1d413c917496f4b964a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444374
Auto-Submit: Esmael Elmoslimany <[email protected]>
Commit-Queue: Tibor Goldschwendt <[email protected]>
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813208}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459746
Reviewed-by: Esmael Elmoslimany <[email protected]>
Commit-Queue: Esmael Elmoslimany <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#116}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge to M87] Flip the gesture direction of switching desks
The M87 changes the switching desk gesture direction when reverse
scrolling for touchpad is off. This CL flips gesture direction of
switching desks and show a toast when reverse scrolling is off.
(cherry picked from commit 612c2cd09916db1bead1ba1cb49bc98356214222)
Bug: 1107183
Change-Id: I58dc18331bc9f917a571b033b8caac63a3da95bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444438
Commit-Queue: Xiaodan Zhu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813265}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459128
Reviewed-by: Xiaoqian Dai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#115}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Another fix for the issue that made tests flaky.
(cherry picked from commit fc7a29d9b507f02707b73f99a651e40344dfc30f)
Bug: 1133962
Bug: b:169427520
Change-Id: I899a35654fbbc91763b46e54350a447d17834581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446451
Commit-Queue: Leonid Baraz <[email protected]>
Reviewed-by: Zach Trudo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813435}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459208
Reviewed-by: Leonid Baraz <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#114}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Roll src/third_party/cros_system_api/ d5ad6a50d..5df72efed (1 commit)
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/d5ad6a50d168..5df72efed1de
$ git log d5ad6a50d..5df72efed --date=short --no-merges --format='%ad %ae %s'
2020-09-15 fletcherw system_api: add scan dimensions to lorgnette API
Created with:
roll-dep src/third_party/cros_system_api
Also, update the scanning mojom file and type converters to handle the
new enum value in lorgnette_service.proto.
(cherry picked from commit 656e27a96ef1f69ff07c3d0d7e9d826351d0826a)
Bug: None
Change-Id: Ib425f99fdacaa85cd9559b567a2d5b15e61d02e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443271
Auto-Submit: Jesse Schettler <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813050}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457906
Commit-Queue: Jesse Schettler <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#113}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix for test flakiness.
ReportClient creation made fully asynchronous,
and problematic test can now wait for initialization to complete.
(cherry picked from commit 4646621f9d7fe6b3b264281a8869c62ca6cd2686)
Bug: b:169427520
Change-Id: Ic6566e9973dc48de86b36c8b1180d688de84ce76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444409
Reviewed-by: Zach Trudo <[email protected]>
Commit-Queue: Leonid Baraz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813206}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459058
Reviewed-by: Leonid Baraz <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#112}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Autofill Offer] Fixed missing notification when offer data changed
The issue is the offer data is only updated when relaunch (or when
personal_data_manager::refresh() is invoked) and not updated when
new offer reaches client.
The reason is:
The full sync flow should be:
1. Offer sync bridge receive the data and populates to autofill table
if found difference.
2. Notify UI sequence (personal data manager) about the change.
3. Personal data manager sends query to autofill webdata service to
get data from autofill table.
4. Personal data manager gets notified by OnWebDataServiceRequestDone
and refreshes local cache.
5. Autofill Offer Manager being a personal data manager observer
gets notified.
6. Autofill Offer manager updates eligible domain calling
UpdateEligibleMerchantDomains.
Previously I thought the OnWebDataServiceRequestDone would be
automatically invoked when the sync is finished, so we miss step 2
and 3. Here in this CL fix it.
(cherry picked from commit c20eb6ac1db2e94b7975a763be0fb63f866ea2a9)
Bug: 1135790
Change-Id: I38ac61f3d5608eec1c8ac92538e457e566b3f538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444454
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Siyu An <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814321}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459057
Reviewed-by: Siyu An <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#111}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[iOS] Handle BookmarkActivity Within SharingCoordinator
SharingCoordinator will now handle add/edit bookmark commands sent from
the Bookmark Activity, and will make use of the new
BookmarkEditCoordiator to handle showing the Edit Bookmark UI.
(cherry picked from commit b63c5ef2d6e01126b3fe93decf9f0978fb469045)
Bug: 1133294
Change-Id: I7f69f241b49646ffb1853a4a78322f5b941b6cef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441957
Commit-Queue: Sebastien Lalancette <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813754}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458879
Reviewed-by: Sebastien Lalancette <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#110}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Window Placement: Allow requestFullscreen from onscreenschange
Similar to allowing requestFullscreen on screen orientation changes.
Allows sites to requestFullscreen when the user changes screen config
(e.g. when the user connects an external display to a laptop)
Add TransientAllowFullscreen for async support like UserActivationState.
(ScopedAllowFullscreen only supports sync, stack-allocation scopes)
Add a basic unit test for the new class, and an integration test.
(cherry picked from commit db8f4f0a098d52c66855b62234ecec005e1ff572)
Bug: 1077402
Test: window.onscreenschange = async () => { element.requestFullscreen({screen:(await getScreens())[1]}); };
Change-Id: Iffc5bb419e2b016704b923bd8454cb422672b5e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429967
Commit-Queue: Michael Wasserman <[email protected]>
Auto-Submit: Michael Wasserman <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Mustaq Ahmed <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814036}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458777
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#109}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[SH] Add common shared-highlighting metrics file to use on all platforms
(cherry picked from commit dc0b02ec351c62c9d7d341918261eda3c6023200)
Bug: 1135144
Change-Id: I061f9282ce17775b537f10ca2f81917a0b2224d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448055
Reviewed-by: Cait Phillips <[email protected]>
Commit-Queue: sebsg <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814197}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459629
Reviewed-by: sebsg <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#108}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Restore classic shelf button colors.
This addresses the changes in these CLs
https://chromium-review.googlesource.com/c/chromium/src/+/2376417
https://chromium-review.googlesource.com/c/chromium/src/+/2378801
(cherry picked from commit c6d61163edcc139eecca8826394d0ba844dbab4f)
Bug: 1134854
Change-Id: I360e46cc4d0e8247eed799b7f1c7b1d1c4f9da5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447045
Reviewed-by: Yulun Wu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814035}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459526
Cr-Commit-Position: refs/branch-heads/4280@{#107}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android WebView] Fix WebviewLayoutTest
Periodic Background Sync was disabled for WebView here:
https://chromium-review.googlesource.com/c/chromium/src/+/2419579
The layout test needs to be updated, which this CL does.
(cherry picked from commit 94c23ad342cdb9bb5a6bc9ce8b58458319b5eaa9)
Bug: 1131660
Change-Id: Ib10f7c80ee554843c0c4a61693afeaa99a87e3d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442730
Commit-Queue: Mugdha Lakhani <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813203}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459626
Reviewed-by: Donn Denman <[email protected]>
Commit-Queue: Donn Denman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#106}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix PaintLayer::HasNonEmptyChildLayoutObjects() with overflow:visible child
[email protected]
(cherry picked from commit b21c50dc35ffa777c93c094f72d7cd79f27c8138)
Bug: 1128440
Change-Id: I9f64c6d8bbe0228dae3ecf6f49caaed2a785f970
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451849
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814332}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458806
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#105}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[remoting host] Install a watchdog during peer connection teardown
This is a simpler approach to tackle (workaround) the blocked network
thread issue when compared to CL 2436278.
This CL simply creates a base::Watchdog that arms before closing the
peer connection, and disarms after the peer connection is closed. If
thread join takes longer than expected then it will crash the host so
that the daemon process can respawn it.
(cherry picked from commit b495e7ee79f9a4d4586a9fb823af2bef6c630e39)
Bug: 1130090
Change-Id: Ib2400e17b848ed07df902a02b344efbf5e15c588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446840
Reviewed-by: Lambros Lambrou <[email protected]>
Commit-Queue: Yuwei Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813937}
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458048
Reviewed-by: Yuwei Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#104}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Web Payment] Return challenge for secure payment confirmation.
Merge to M87
Before this patch, secure payment confirmation method would return the
signature of the challenge that was generated on the browser using the
JSON stringification. In order to verify the signature, an issuer would
have to stringify JSON as well, but that stringification could be
different from how Chrome did it, thus resulting in a rejected
transaction.
This patch returns Chrome's stringified JSON challenge along with the
payment response for secure payment confirmation. The tests to verify
this behavior revealed that secure payment confirmation app ignored
price changes in modifiers and show promises, so that bug is fixed here
as well.
After this patch, the issuer does not need to generate the JSON string
itself, but instead can verify the values in the JSON string generated
and returned by Chrome.
(cherry picked from commit 94339493104a87b93f0f8565b57f4fe2a925f695)
Bug: 1123054, 1124747
Change-Id: I0fa8974411635e406a9d2f253b7061b892e06949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388271
Commit-Queue: Danyao Wang <[email protected]>
Reviewed-by: Danyao Wang <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813343}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454849
Cr-Commit-Position: refs/branch-heads/4280@{#103}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Restore classic shelf inkdrop colors and opacity.
This addresses the changes in this CL
https://chromium-review.googlesource.com/c/chromium/src/+/2382222
(cherry picked from commit 99e4b2d5ebdca11c6a4fb490b60b482e116c262f)
Bug: 1134854
Change-Id: I193d0d73a44d858a8674f16703696da8bbcf5c24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447431
Reviewed-by: Yulun Wu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814003}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459206
Cr-Commit-Position: refs/branch-heads/4280@{#102}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87]Create controller for Enhanced Protection promo.
This CL creates the actual controller for the
Enhanced Protection promo on the NTP on Android
and hooks it up to the Feed Surface. Also added
metrics to track impressions and dismissal of
the promo. This also creates a max impressions
for SigninPromoController which will be
controlled by an experiment.
The first part was:
https://chromium-review.googlesource.com/c/chromium/src/+/2423165
(cherry picked from commit 1617663ab269400a7a1e74db65dffc230780bb4a)
[email protected]
Bug: 1130739,1130735,1130745
Change-Id: I080e9c93f2f3b9e38dc397d97fee92525c2a0291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430263
Commit-Queue: Bettina Dea <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Brian White <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Reviewed-by: Wenyu Fu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813439}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458647
Reviewed-by: Bettina Dea <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#101}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Report progress to watchdog for allocation/upload.
This CL makes the SharedImageBackingFactoryGLTexture notify the GPU
watchdog that progress is being made around the code that requests
memory allocation or texture upload. This is an attempt to improve the
crash rate due to allocation taking a long time (as opposed to it being
a GPU hang).
(cherry picked from commit 85867c2de312b24ba5e3af1bb795577f752fbb3a)
Bug: 1082197
Test: added unit test coverage.
Change-Id: Ic9530fd53df95d5ce0b675231c0ac52e682c69e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215256
Commit-Queue: Andres Calderon Jaramillo <[email protected]>
Reviewed-by: Maggie Chen <[email protected]>
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813055}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458266
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#100}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge-87][SH-Blink] Adding histograms for Shared Highlights.
Adding histograms to text fragment selector generation logic. Also
adding a histogram that indicates if the origin of a link with text
fragment is a known search engine.
For finding out if a given url is a known search engine,
I am separating template_url_prepopulate_data::GetEngineType and deps
into a separate file to use it from blink/renderer/platform.
Otherwise, template_url_prepopulate_data pulls deps that are also
pulled by deps which somehow triggers
AddressSanitizer: odr-violation(one definition rule) on some targets.
See https://ci.chromium.org/p/chromium/builders/try/linux-libfuzzer-asan-rel/569669
Unit tests for histograms in in a followup.
(cherry picked from commit 2fd5742a51183821b2c7fbe139b962c40e8b99c8)
Change-Id: I9d496b883f32041b5bd612b0cf8e447cc79fa68e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432674
Commit-Queue: Gayane Petrosyan <[email protected]>
Reviewed-by: manuk hovanesian <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: sebsg <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813242}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456948
Reviewed-by: Gayane Petrosyan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#99}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[iOS] Create BookmarkEditCoordinator
This new Coordinator will enable an edit-only scenario, requiring only
a minimal set of dependencies. Without this new Coordinator, the "Edit
Bookmark" flow ended up being dependent on the SharingCoordinator (via
the BookmarkHomeViewController). Since bookmarks can be edited via the
sharing activities ("Edit Bookmark"), we ended up with a cyclic
dependency. The creation of this new Coordinator enables such flow.
e.g. Open a page -> Add it to Reading List -> Add it to Bookmarks ->
Open Reading List -> Long-press on the entry -> Select Share -> Select
"Edit Bookmark".
(cherry picked from commit b9fb744f121ed3f076d25ffb491fbda05679c122)
Bug: 1133294
Change-Id: Ib646a7e79e6c46b5cd4b373417caa447a4365ba1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441956
Commit-Queue: Sebastien Lalancette <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813750}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458626
Reviewed-by: Sebastien Lalancette <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#98}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: I4d4fb742bd24321fc0fd416f3f00e1f8c4209c31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457668
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#97}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Initial commit for enhanced protection message in interstitials.
The goal is to replace the current SBER checkbox with this new enhanced
protection message whenever the user is able to opt-in to enhanced
protection. It applies to SAFEBROWSING, SSL and CAPTIVE_PORTAL
interstitials.
Adds a section named enhanced-protection-message in
interstitial_large.html, and adds a new command named
CMD_OPEN_ENHANCED_PROTECTION_SETTINGS in interstitial_commands.mojom to
handle the callback from js to c++.
Screenshot: http://screen/5AirLStp39i24Gm. To follow the mocks, an icon
and a different background color will be added in a future CL.
Also adds a chrome flag named
safe-browsing-enhanced-protection-message-in-interstitials to control
this feature.
(cherry picked from commit 52abe9087eddd4b43740b8acb93a4ba02a0ca01d)
Bug: 1130721,1130745
Change-Id: Ic5924ae2324a5fed1760b5549cb915c3279f1dbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427548
Commit-Queue: Xinghui Lu <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812960}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457826
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#96}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix corrupt background and text color of IPH buttons on Win and Linux
* Transparent background was used in button and was problematic
on Windows and Linux. See screenshot http://shortn/_PJngbEljUE
Fix using an explicit color.
* Use SetEnabledTextColors to set button text color.
This sets color for NORMAL, PRESSED and HOVERED states.
On Windows and Linux, setting only NORMAL but omitting others
will render text in other states in black, which is not desired.
(cherry picked from commit e3787541457f17efae3af8a0b8600e3d222c7396)
Bug: 1121399
Change-Id: Ica95095855a619220a5dd9cf62c67b87acb6be0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452554
Reviewed-by: Collin Baker <[email protected]>
Commit-Queue: Keren Zhu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814269}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457307
Commit-Queue: Collin Baker <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#95}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Update import_util.py to work from chrome/chrome_cleaner/internal
This prepares for a pending commit to the internal chrome_cleaner repo
which will delete the internal copy of import_util.py:
* Add separate GetChromiumRootDirectory and GetInternalRootDirectory
functions to clarify the ambiguous term "root directory" when called
from the internal repo mounted at //chrome/chrome_cleaner/internal.
* Move all the functions that depend on being called from inside the
chromium source tree to a separate import_paths.py script. (All the
current callers of these functions happen to be in
//chrome/chrome_cleaner/internal.)
* Delete code to find a local copy of find_depot_tools. It's no longer
supported to run this script without calling gclient sync, which will
update depot_tools.
R=proberge
(cherry picked from commit 1673a55ce9dfd635d021fd5b238f8b147d3ccc70)
Bug: 1004848
Change-Id: I829851f332975c950f1dcde59735ee96f34f295e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451810
Reviewed-by: proberge <[email protected]>
Commit-Queue: proberge <[email protected]>
Auto-Submit: Joe Mason <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814390}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458486
Reviewed-by: Joe Mason <[email protected]>
Commit-Queue: Joe Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#94}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Don't cross-compile tools used for creating diff installers.
Diff installer creation runs on the same hosts that the build runs on,
so should create binaries for the same architecture.
BUG=1119472
R=[email protected], [email protected]
(cherry picked from commit 6912cdb0965dc335beed4eb27c41fe8bb58f4184)
Change-Id: I58772ce20b47cf9ce854a095de3aac3cf697d5ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454390
Commit-Queue: Michael Moss <[email protected]>
Auto-Submit: Michael Moss <[email protected]>
Reviewed-by: Mark Mentovai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814475}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454931
Reviewed-by: Michael Moss <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#93}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[iOS] Split Bookmarks UI Target
Splitting the "bookmarks" target further than it previously was. This
will allow the reuse of various components and creation of another
target which will enable an edit-only flow, with reduced dependencies.
(cherry picked from commit 4bc9c4c78fa9cb1aa17e3be345d8a9877ae37f98)
Bug: 1133294
Change-Id: I62469eee5deb06279dc16d6a7a02d56fe48e76a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440310
Commit-Queue: Sebastien Lalancette <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813743}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456628
Reviewed-by: Sebastien Lalancette <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#92}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
M87 merge: Add FamilyUserMetricsProvider for family user types slicing
The FamilyUserMetricsProvider will filter the Family Experiences
team's metrics by family user type of interest. The categories
represent various combinations of supervised and EDU user types as
primary and secondary accounts.
(cherry picked from commit bb2e7e34be0a7fd5eb9d26a88e8fe57688bcb9e8)
[email protected],[email protected],[email protected]
Bug: 1103077
Change-Id: Icd87e553ed02278c77186b7b0ec5bd1a377f619c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417451
Commit-Queue: Toby Huang <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814444}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457747
Reviewed-by: Toby Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#91}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Use padding rather than margins on FrameLayout in recyclerview and disallow
clipping. This fixes clipping for feed header IPH.
(cherry picked from commit 852d96cc306f37fe40417368a21d69c7c37763c8)
Bug: b/168859910, 1130592
Change-Id: I19efd691190f05826c7e1ecfd288f8d6bf4df6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442361
Commit-Queue: Cathy Li <[email protected]>
Reviewed-by: Dan H <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813043}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457746
Reviewed-by: Cathy Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#90}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge-87] Correctly recover focus when collapsing the Panel.
This change fixes a regression that was introduced by adding in-page
link support for ChromeVox. The issue is that when the panel is
collapsed, a scrolled_to_anchor event is fired, which was causing us
to always place focus on the Panel root web area upon collapsing the
menus. To fix the issue, we ignore scrolled_to_anchor events if the
root of the target differs from the root of the current range.
(cherry picked from commit 7843b3b3e314b3f4cd10f70f3ec666a68afb305a)
Fixed: 1133548
AX-Relnotes: N/A
Change-Id: I43e99452ea27cd190bd53c62b5fb06593a5bf6b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442899
Commit-Queue: Akihiro Ota <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813000}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457466
Reviewed-by: Akihiro Ota <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#89}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Reduce get token timeout to 50ms on Android.
Regression is still seen at 50% Stable:
http://uma/p/chrome/variations?sid=a3d201c28d29aab0568c58c18fca2e40.
Currently 85% of get token requests finish within 50ms.
http://uma/p/chrome/histograms?sid=1c472f87b67d1fe3197bdde7cb56db0e
Waiting for a full second for acquiring tokens is too long.
We should use an empty token if the token cannot be acquired in 50ms.
In this CL, reduce the get token timeout to 50ms to see if it mitigates
the issue. If the issue is still there, we will look into other
solutions such as fetching the token in the background.
(cherry picked from commit e862177f2cff030b8a8031683f7e12f9243a85f3)
Bug: 1070324
Change-Id: I744c775e88162b9c8814bf4a4efab98085c94da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442010
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812902}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457786
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#88}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Restore classic login shelf colors.
This addresses the changes in these CLs
https://chromium-review.googlesource.com/c/chromium/src/+/2363799
(cherry picked from commit 13f1e95c017b43d9894fce1e29c05a37ba5d17f0)
Bug: 1134854
Change-Id: I522e5ebe9228bec7e12b9037ee4a4b95b2593c5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446547
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813947}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457766
Reviewed-by: Yulun Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#87}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Webview: Build DownloadCollectionBridge for Android webview.
Currently we didn't build DownloadCollectionBridge for webview.
[email protected]
(cherry picked from commit 71aa19f6ab38b8febd172dc8dab394840ff62fa0)
Bug: 1135162
Change-Id: Id7a2cb3fa263281216304b1c519271c95b44ae37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450721
Commit-Queue: Xing Liu <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814010}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457607
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#86}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[fuchsia] Set an ephemeral debugging port for child contexts
Previously, all contexts would share the same port for remote
debugging, resulting in the main context failing to open the remote
debugging port randomly.
With this change, only the main context uses the default port. All other
contexts use an ephemeral port.
(cherry picked from commit 911b4598e95cd27b7b3f40e201be540ec0dfea89)
Bug: 1076982
Change-Id: I6fa2fee65c10277c5e5e705d051e13f7db62057d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443531
Commit-Queue: Fabrice de Gans-Riberi <[email protected]>
Auto-Submit: Fabrice de Gans-Riberi <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813855}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454731
Cr-Commit-Position: refs/branch-heads/4280@{#85}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Autofill Offer] Fix merchant domain matching logic
(cherry picked from commit 21f15872c7450dc03d97c31c384af2de67f2ec18)
Bug: 1135238
Change-Id: I3137ed5e2bda1a3408b1c08d5f163e159780a7c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444456
Reviewed-by: Jared Saul <[email protected]>
Commit-Queue: Siyu An <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813371}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456294
Reviewed-by: Siyu An <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#84}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "ambient: cache two backup photos"
This reverts commit 57520f4f6c25567d3339cc44852ea41c9861be37.
Reason for revert: causes crash on device b:170312454
Original change's description:
> ambient: cache two backup photos
>
> Handle failure cases better by having backup photos on disk.
> Refresh these images after user logs in.
>
> BUG=b:167332126
>
> (cherry picked from commit a81c26884bde81a386ffb2dcbdb7a12f0ecd1215)
>
> Change-Id: I7046a20ed9606638e851247f8c213d112af6c30b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429585
> Commit-Queue: Jeffrey Young <[email protected]>
> Reviewed-by: Xiaohui Chen <[email protected]>
> Reviewed-by: Tao Wu <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#813904}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451370
> Cr-Commit-Position: refs/branch-heads/4280@{#62}
> Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[email protected],[email protected],[email protected]
Change-Id: I9c2dd1becd3c8591d4115ab4d7b97bb9e5f5875b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:167332126
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457367
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Tao Wu <[email protected]>
Commit-Queue: Jeffrey Young <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#83}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Reland "Exclude no-update frames for jank detection"
This is a reland of bfeec8b79ee82b29b69236648e1971ff40b77c64.
This CL fixes a use-of-uninitialized-value error in the original
change.
Original change's description:
> Exclude no-update frames for jank detection
>
>
> This CL improves the jank metrics by excluding the delays caused by
> frames without intended updates and prevents certain outlier cases
> when a high jank percent is reported on a page with very low percent
> of dropped frames.
>
> Bug: 1133058
> Change-Id: If32576e8b528e22b184a0b549161751fcfd976bf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417211
> Reviewed-by: Jonathan Ross <[email protected]>
> Reviewed-by: Sadrul Chowdhury <[email protected]>
> Commit-Queue: Mingjing Zhang <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#812988}
(cherry picked from commit 0241cc426322fc74d718fb843c83a5f514da9857)
Bug: 1133058
Change-Id: I270ca4ad044468e19136d3ed544c25de8ec3c916
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446530
Reviewed-by: Sadrul Chowdhury <[email protected]>
Reviewed-by: Jonathan Ross <[email protected]>
Commit-Queue: Mingjing Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813377}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456293
Commit-Queue: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#82}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
do not trigger TWA quality enforcement if assetlink failure when debug
We got a large number of digital asset link failure on Beta/Dev/Canary:
https://docs.google.com/document/d/1pbIEGFjvd_En9PQJnO7mhcGZ96CGe3CQsQkOihRDwLs/
This CL makes TWA not close the Activity when failing digital asset link
if the client app has no installer name (is installed from adb instead
of from a store).
Also add an additional UMA metric to record the quality enforcement
violations when a crash actually happened.
(cherry picked from commit 3f7a229606a467c0ddeea2637e8ea7f4a57c99b8)
Bug: 1109609
Change-Id: I09fefde367e804d85063fd35270d547ff3864b67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440290
Reviewed-by: Brian White <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Commit-Queue: Ella Ge <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812971}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456666
Reviewed-by: Ella Ge <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#81}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[SharingHub] Exclude first party apps when the tab is null.
(cherry picked from commit fce916343acb9597d214f0d8ea69cca2668174b5)
Bug: 1133398
Change-Id: Ie8787bd6f5772805a94c972163cd8a4e7735ef03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442097
Reviewed-by: Kyle Milka <[email protected]>
Commit-Queue: Sophey Dong <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812945}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456627
Cr-Commit-Position: refs/branch-heads/4280@{#80}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix regression in dark mode filter creation.
M-87 merge.
There is regression caused by creating dark mode filter in
GraphicsContext ctor. This patch creates dark mode filter
once it is accessed first time.
(cherry picked from commit 5a9ac5706a701b6fc60ffac3aa58083bf24c9023)
Bug: 1134430, 1134476, 1082339
Change-Id: I97521749167fcd1fb7ddfeb1b2fe7e8a7de8846f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449829
Reviewed-by: Stephen Chenney <[email protected]>
Commit-Queue: Prashant Nevase <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813730}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456311
Reviewed-by: Prashant Nevase <[email protected]>
Commit-Queue: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#79}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] weblayer: adds API to know if Browser is restoring and when done
This way embedders have API to know when they can take action
based on whether restore has completed.
BUG=1135278
TEST=covered by tests
(cherry picked from commit 3692e6bb068eed1929257e170110f39fd03a774c)
Change-Id: I72d804a86d8c4eeafdc3b72bbcf16875a78eb477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451550
Commit-Queue: Scott Violet <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814450}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454639
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#78}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge to M87: Protect frame_adapter_ with a lock in WebrtcVideoFrameAdapter
(cherry picked from commit 2f048511e79165713bd45da1983a05c1593a911f)
Bug: webrtc:11485, chromium:1135541
Change-Id: I843b0babbcc5ac1169ab09ea957d5df02bc52f29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449333
Auto-Submit: Ilya Nikolaevskiy <[email protected]>
Reviewed-by: Henrik Boström <[email protected]>
Commit-Queue: Ilya Nikolaevskiy <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813707}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452709
Cr-Commit-Position: refs/branch-heads/4280@{#77}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "[Android] Add logging for AppLocaleUtils"
This reverts commit 78a5b827e46cdc8ad2ab7dbffc56db81305a1999.
Reason for revert: Pinpoint identified startup time increases because of this. Need to put all logging behind flags. https://crbug.com/1134079#c6
Original change's description:
> [Android] Add logging for AppLocaleUtils
>
> This CL adds some simple logging in AppLocaleUtils to observe what
> language splits are available to the application and what the override
> locale should be.
>
> Bug: 1128698
> Change-Id: I925cd84d384602e2f0beedd63ecd551f87c24b09
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440976
> Reviewed-by: Scott Little <[email protected]>
> Commit-Queue: Trevor Perrier <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#812522}
[email protected],[email protected],[email protected]
(cherry picked from commit e302fa52cff6f69d4b140605cb3d8f73ae04d1ad)
Change-Id: I957ab8aeb01ae21b772e332941cb95e06a7f80ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1128698, 1134079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443217
Reviewed-by: Trevor Perrier <[email protected]>
Commit-Queue: Trevor Perrier <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812898}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456966
Cr-Commit-Position: refs/branch-heads/4280@{#76}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: Ice27f2fa76067cd4a99edacbfb5d085a317ab406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456187
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#75}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Instant Start] Disable StartSurfaceTest#testShow_SingleAsTabSwitcher_V2__Instant_Return
(cherry picked from commit 07bb6265d3edf845f202457fe72cede4ab6779f4)
Bug: 1132948, 1076274, 1134267
Change-Id: Ib0047b913bd7a844f7a59b36d6e4e40b097f4a5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443543
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Commit-Queue: Xi Han <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812952}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456286
Reviewed-by: Xi Han <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#74}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[iOS] Add Parameterized Bookmark Command
Created the BookmarkPageCommand which takes a title and URL parameter
in order to create (or trigger edit for) a bookmark.
Added it to a new BookmarksCommands protocol - allowing it to not
be required by BrowserCommands (BVC).
(cherry picked from commit 0d6263e5ae67a569d31181e5f7873ae763ac7057)
Bug: 1133294
Change-Id: If73503350d7d63fd467c45941113bcbafe06ad2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441910
Commit-Queue: Sebastien Lalancette <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813737}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455183
Reviewed-by: Sebastien Lalancette <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#73}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Paint Preview] Fix NullPointerException crash
(cherry picked from commit 53d0ad6a9daf40e62ba936be8b9d7172d517485f)
Bug: 1135054
Change-Id: Idec0ddfab4877137e6a7deca395370b6619a9206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450717
Commit-Queue: Mehran Mahmoudi <[email protected]>
Commit-Queue: Michael Thiessen <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Auto-Submit: Mehran Mahmoudi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813948}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456546
Reviewed-by: Mehran Mahmoudi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#72}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Paint Preview] Add fake progressbar on upgrading to live tab
As per UX review, this CL disables the progressbar when paint preview
is shown. It also fakes a progress fill animation on upgrading to the
live tab.
(cherry picked from commit b17b9e9d47b612d4ab7d74c47157d47ccf37cef7)
Bug: 1131497
Change-Id: I8054f2aacaaea7d76423017b89057f811895e548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441188
Commit-Queue: Mehran Mahmoudi <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812868}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456327
Reviewed-by: Mehran Mahmoudi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#71}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android][WebSignin][UI] Add visial feedback when entry is selected
This CL adds visual feedback when an entry is selected in the expanded
account list.
(cherry picked from commit 790c32c397ee5aa960a8bab673045be3838a60a0)
Bug: 1135141
Change-Id: Idba767ae72a7e9d258a35cf3df1440e6cf35c076
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449989
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Alice Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814177}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455709
Reviewed-by: Alice Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#70}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
(Merge): [iOS][Safety Check] Add UMA metrics to safety check
Add overall interaction metrics (with actions) and individual
metrics for each of the checks.
(cherry picked from commit 80fdc9c2679de95333399d9e1cd8e9f4273c403d)
Bug: 1078782, 1135098
Change-Id: Ic778e9ef54e9f358e28eab5b4b7ac30a7ad5d99d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442531
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Sean Harrison <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812912}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455349
Reviewed-by: Sean Harrison <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#69}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
(Merge): [iOS][Safety Check] Add new default strings for Safety Check
Adds new default strings to safety check so that rows don't resize.
Running state keeps the same detail text as the previous state.
(cherry picked from commit 2a1ff9bef62cfdba2baeadac0fffce43e7baf4b0)
Bug: 1078782, 1135095
Change-Id: Iffa246a5baca2b2cf8051e87cc10a1d6d80f6c2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443729
Reviewed-by: Martin Šrámek <[email protected]>
Commit-Queue: Sean Harrison <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812977}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453739
Reviewed-by: Sean Harrison <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#68}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] OOBE: Make UserSessionManager more robust to shutdown during the login
* Use AsWeakPtr instead of base::Unretained in the WizardController
* Check chrome::IsAttemptingShutdown together with
browser_shutdown::IsTryingToQuit. IsAttemptingShutdown covers call to
chrome::AttemptUserExit() which is common in the Chrome OS login/policy
code.
(cherry picked from commit 13c9a810b7bf1189a53115cfbdfa16c4a42af36e)
Bug: 1132397
Change-Id: I6c0e28138918a998c94f82f5c9e7736df92e5ced
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450051
Reviewed-by: Thomas Tellier <[email protected]>
Commit-Queue: Roman Sorokin [CET] <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813764}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454650
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#67}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Access Context Auditing: Prevent recording repeated cookie accesses
To reduce the number of records pending update in the access context
audit database, an in memory set of previously seen cookie accesses is
added. This set is consulted before attempting database insertion and
is cleared on navigation.
(cherry picked from commit 537f71f250a699f5369110d1df7d9050183499f1)
Bug: 1132947
Change-Id: I87f1b2e1283c8c9a1ee76dc3649ce2f2f598f82b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438391
Commit-Queue: Theodore Olsauskas-Warren <[email protected]>
Reviewed-by: Martin Šrámek <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813646}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454052
Reviewed-by: Theodore Olsauskas-Warren <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#66}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[merge-m87] [CrOS] Update media_app to SKwma2epistNSsheI5mMcAYSgI9BRpLCXbMU27lGDOYC
Cherry-pick of change to fix "Save As" functionality in chrome://media-app
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/SKwma2epistNSsheI5mMcAYSgI9BRpLCXbMU27lGDOYC
Release Notes: http://go/media_app-x20/relnotes/Branch/media_app_202010010800_RC01.html
Bug: b/170170159, b/165769056
Test: See bug.
Change-Id: Ia9b8115e10fe0816e0604a02a6274af8bc954f9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455076
Reviewed-by: Patti <[email protected]>
Commit-Queue: Trent Apted <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#65}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Autofill] Change CreditCard::instrument_id from int to int64
(cherry picked from commit 1f847b3e08a8b18e72056620c404d386c4111426)
Bug: 1135230
Change-Id: I8a24e775c3b3955a86d606d199f6ee966f681ea5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444431
Reviewed-by: Tommy Martino <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Anne Lim <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813360}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455153
Reviewed-by: Siyu An <[email protected]>
Commit-Queue: Siyu An <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#64}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Populate the item tag if offer is present
Currently we're populating the item tag only for the autofill popup.
We'll populate for the autofill keyboard accessory as a follow up after
implementing the UI for the keyboard accessory.
(cherry picked from commit fd364bbd477c56a8efa246e6ed7b6ef90e74d0fc)
Bug: 1093057
Change-Id: I909569e16ccaced0bc3dde01e0f03d9de3204706
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436862
Commit-Queue: Siddharth Shah <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Reviewed-by: sebsg <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812964}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453337
Reviewed-by: Siddharth Shah <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#63}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
ambient: cache two backup photos
Handle failure cases better by having backup photos on disk.
Refresh these images after user logs in.
BUG=b:167332126
(cherry picked from commit a81c26884bde81a386ffb2dcbdb7a12f0ecd1215)
Change-Id: I7046a20ed9606638e851247f8c213d112af6c30b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429585
Commit-Queue: Jeffrey Young <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Tao Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813904}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451370
Cr-Commit-Position: refs/branch-heads/4280@{#62}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge to M87]dark_mode: Light power menu and system toast by default.
(cherry picked from commit 82988ab08c52a9e5f9cf8e8eba7a0d6fff8f276c)
Bug: 1133952
Change-Id: I8c1e3e7ee4d3ea486aa0519693a7a8e066bd7dc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444176
Reviewed-by: Ahmed Fakhry <[email protected]>
Commit-Queue: Min Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813313}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454257
Reviewed-by: Min Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#61}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Reland "Use standard ExternalProtocolDialog in Chrome OS for Guest OS apps"
This reverts commit e739fc504bf09d3eb1bf435a50eff6b82e401e0c.
Reason for revert:
reland with fix for camera.CCAUISettings in crrev.com/c/2454769
Original change's description:
> Revert "Use standard ExternalProtocolDialog in Chrome OS for Guest OS apps"
>
> This reverts commit 4d4f20fc410838c9dc607695c57ee9e349803412.
>
> Reason for revert: https://crbug.com/1132535
>
> Original change's description:
> > Use standard ExternalProtocolDialog in Chrome OS for Guest OS apps
> >
> > Screenshots:
> > http://go/chrome-ss/0a0bc6ca1f1985c5c25a726a8ef123c27c33c7e1
> > http://go/chrome-ss/bd6f5d9d4ef33bd9ae8addb575c88dd2a1d04818
> > http://go/chrome-ss/d4b444ab2d88cb4bd11e21e52b7246de60c8bf71
> >
> > When Chrome OS did not support external protocol handlers, it
> > replaced browser/ui/views/external_protocol_dialog with
> > browser/chromeos/external_protocol_dialog which states that no
> > handlers are available. ARC has added a dialog which is shown
> > when any android apps can handle a link. This CL uses the
> > standard ExternalProtocolDialog for Guest OS apps when ARC does
> > not handle a link, but Guest OS can.
> >
> > * Renamed CrOS version of ExternalProtocolDialog to
> > ExternalProtocolNoHandlersDialog. It is still used when no handlers
> > are found.
> >
> > * Changed ui/views/external_protocol_dialog to now be compiled into
> > CrOS, but leaving out
> > ExternalProtocolHandler::RunExternalProtocolDialog which is provided
> > in the CrOS version: chromeos/external_protocol_dialog.cc.
> >
> > * Replaced platform_util_chromeos OpenExternal to Launch the registered
> > Guest OS app. This function was previously not ever called in CrOS.
> >
> > Bug: b/168506505
> > Change-Id: I89ffd84b9308cb2ce4b7e0691183e0da3402a4cc
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423675
> > Commit-Queue: Joel Hockey <[email protected]>
> > Reviewed-by: Elly Fong-Jones <[email protected]>
> > Reviewed-by: Lei Zhang <[email protected]>
> > Reviewed-by: Xiyuan Xia <[email protected]>
> > Reviewed-by: Jason Lin <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#810381}
>
> [email protected],[email protected],[email protected],[email protected],[email protected]
>
>
> Bug: b/168506505,1132535
> Skip-Translation-Screenshots-Check: True
> Change-Id: I52bfc2a8169a018076790df8a63c253c29ded64c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434014
> Commit-Queue: Jason Lin <[email protected]>
> Reviewed-by: Jason Lin <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#811144}
[email protected],[email protected],[email protected],[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: b/168506505
Bug: 1132535
Change-Id: Iebea2aeaad1cddae89c96fcbefab49c96152927f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454810
Reviewed-by: Joel Hockey <[email protected]>
Commit-Queue: Joel Hockey <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#60}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}