Publish DEPS for 87.0.4280.27
Incrementing VERSION to 87.0.4280.27
[email protected]
Change-Id: Ic354c29fb9c91efe7796d56a54363147b89d90b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488303
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#556}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Copy sub texture, even in non OOP-R
Has become a straightforward revert of this commit.
https://chromium-review.googlesource.com/c/chromium/src/+/2216591
For as yet unknown reasons, not using CopySubTexture can cause rapid
flickering between pixellated and non-pixellated rendering. Considering
this is negatively effecting many users right now, it may be worth
pushing this change through as a quick fix.
(cherry picked from commit 568b4fffeb1f346e9a4ff3805b8836af2b1452d8)
Bug: 1134799
Change-Id: Ia25b312f3755063b1fdeaa39be5057b7654b7548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450842
Reviewed-by: Jonah Chin <[email protected]>
Reviewed-by: Juanmi Huertas <[email protected]>
Reviewed-by: Fernando Serboncini <[email protected]>
Commit-Queue: Aaron Krajeski <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815697}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476497
Reviewed-by: Aaron Krajeski <[email protected]>
Commit-Queue: Juanmi Huertas <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#555}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-master-1601553580-367c6f76c3cbdd1ced1ecc49db85241195c30ea6.profdata to chrome-linux-4280-1603216500-afe1810147a307072a6b5ebcd321eb2ed6c8fcc7.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome-beta
Tbr: [email protected]
Change-Id: I26dbb3cbb4dc1b887d4f324d01c9227dc787e713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488222
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#554}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Make window cloaking and uncloaking trigger occlusion calculation.
This is the right thing to do in general, since we treat cloaked windows
as non-occluding. It also fixes an issue with switching virtual desktops
since that triggers window cloaking and uncloaking events.
(cherry picked from commit f616ef8b645a13a0524645ef26ff7ec277e226b9)
Bug: 1137419
Change-Id: I2b66182bc72c17e69c3f72cd793e2924ba483bb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478082
Commit-Queue: David Bienvenu <[email protected]>
Reviewed-by: Jesse McKenna <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#818031}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487913
Reviewed-by: David Bienvenu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#553}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-master-1601553580-dedfc7e09ce8d42299369759d9da080930ec4031.profdata to chrome-mac-4280-1603216500-a2075ec12db0489ec55700b89a8748bd1924c9ac.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome-beta
Tbr: [email protected]
Change-Id: Id6155309d53ab37260d7fff1c8a02f019d75270d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487943
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#552}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[remoting host] Allow route-changes to have invalid IP addresses.
WebRTC sometimes provides selected-candidate-changed notifications with
invalid IP addresses. The host process normally records these in the
system event log, but only if both IPs are valid. With this CL,
route-change events are generated even if the local or peer IP address
is invalid. These appear in the event log as "unknown".
(cherry picked from commit 6cd55a889f8400942308e76eb5c69bf41d3823ca)
Bug: 1128667
Change-Id: I9329092bdb7f7e4cf6d845303f321bff3eb3177b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485576
Commit-Queue: Lambros Lambrou <[email protected]>
Commit-Queue: Jamie Walch <[email protected]>
Auto-Submit: Lambros Lambrou <[email protected]>
Reviewed-by: Jamie Walch <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#818770}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487813
Reviewed-by: Lambros Lambrou <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#551}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
MakeCurrent when creating WrappedSkImage
Skia may change a bunch of GL state (including active texture unit) when
we create a backend texture. We can't easily restore that state, so do
a full (often virtual) context switch instead. This will avoid damaging
another client's state.
(cherry picked from commit a68d774ea2336dd36267ab2f430e7005a8011448)
Bug: 1095679
Change-Id: I511115f8add6c290fc6a63355cfc4b22a7b1b0c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476899
Commit-Queue: Jonathan Backer <[email protected]>
Commit-Queue: Peng Huang <[email protected]>
Auto-Submit: Jonathan Backer <[email protected]>
Reviewed-by: Peng Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817708}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487833
Reviewed-by: Jonathan Backer <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#550}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Prevent NPE in TabSwitcherModeTTCPhone
Despite asserts to the contrary, the TabModelSelector can evidently be
null at initialization time. Taking a cue from other TabSwitcher
components, we allow for this possibility and move the observer setup to
setTabModelSelector and make the observer safe to trigger when the
underlying view is still null.
(cherry picked from commit 79c2c7b07477bd8de74f1d638adbdee8d19ddaf2)
Bug: 1137994
Change-Id: I9576699235a4f46ff6d28381eaefecea45c150c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477283
Commit-Queue: Patrick Noland <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Yue Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817964}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487690
Reviewed-by: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#549}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge>87: Fix remaining crashes where main frame is likely null
- Add null check for MainFrame() similar to elsewhere in
VisualViewport::UpdatePaintPropertyNodesIfNeeded()
(cherry picked from commit b79ce46d6ad3bbfc1133396fd00e2da6a77edc1b)
Bug: 1134597
Change-Id: Iaaf6d91788051c650f8ed270787cf47782649053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468737
Auto-Submit: Aaron Leventhal <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Chris Harrelson <[email protected]>
Commit-Queue: Aaron Leventhal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816814}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488004
Reviewed-by: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#548}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4280.17-1603104938-benchmark-87.0.4280.25-r1 to 87-4280.17-1603104938-benchmark-87.0.4280.26-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I7f46296b948f2f8e7136b15ac5e323b487ab17ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488582
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#547}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4280.20-1603111242-benchmark-87.0.4280.25-r1 to 87-4280.20-1603111242-benchmark-87.0.4280.26-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib7f0c98592e50429b2cdd34e8c0d38ae981c3e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488580
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#546}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Remove texture size limit for software compositing
It's preferred to have the occasional OOM crash instead of truncating
screenshot output at 8192 pixels.
Also reenabled NoGPUCaptureScreenshotTest.LargeScreenshot since it's
fixed. The test needs to be disabled on Android (in addition to CrOS)
since they lack software compositing support.
(cherry picked from commit 80ead12d16b197c05be1cdfa336ec8a0416231e6)
TBR: [email protected]
Bug: 1137291
Change-Id: I0889a842f17d9ddf7ab9980fd307d7c32285e851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468738
Commit-Queue: kylechar <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817038}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487830
Commit-Queue: Andrey Kosyakov <[email protected]>
Reviewed-by: kylechar <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#545}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: Ic8d6aac668601257eefb48c21f1a5f983838a755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488002
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#544}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4277.0-1603101389-benchmark-87.0.4280.25-r1 to 87-4277.0-1603101389-benchmark-87.0.4280.26-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I254c15f2700388a4475040ed0b73a227558a02ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487906
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#543}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Disable a set of DumpAccessibilityTree tests
Disables a set of tests that are failing on M87 on Android.
We plan to land on Master, merge into M87, revert on Master (since it
has been addressed on Master).
BUG=1137967
(cherry picked from commit 87336cbd1a813d564c4516122c51fddb20ea279d)
Change-Id: I6f38149b21df33d1354394322b7bad9ff492dad9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481629
Commit-Queue: Dominic Mazzoni <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#818691}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488400
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Donn Denman <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#542}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[ntp][modules] Add variation headers to shopping tasks request
This is necessary to trigger the shopping tasks experiment.
(cherry picked from commit b2d302e093769111df046ba7f66056f7b2d194a7)
Bug: 1135401
Change-Id: I030f073dd9c4b69bed037fa8f7923d8860249b83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451575
Commit-Queue: Tibor Goldschwendt <[email protected]>
Auto-Submit: Tibor Goldschwendt <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814290}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487722
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#541}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[ntp][modules] Update triggering IDs for shopping tasks module
The new IDs are submitted to GWS and are in range to be Finch-eligible.
(cherry picked from commit e6082f5d038c1d4ebb4ab0e162999417bea5d098)
Bug: 1135401
Change-Id: Idc92402627fe73d2560783faa7268784708c9c41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480814
Commit-Queue: Tibor Goldschwendt <[email protected]>
Commit-Queue: Moe Ahmadi <[email protected]>
Auto-Submit: Tibor Goldschwendt <[email protected]>
Reviewed-by: Moe Ahmadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#818058}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487781
Reviewed-by: Tibor Goldschwendt <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#540}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge>87: Speculative fix for crash
No need to update layout if we're just checking if the doc is loaded.
R=[email protected]
(cherry picked from commit ee11821361abc5ad546095b04d6868209600e252)
Bug: 1134597
Change-Id: I27b2a81ada534e614318885387c704fe64799152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459172
Auto-Submit: Aaron Leventhal <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815163}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487600
Reviewed-by: Aaron Leventhal <[email protected]>
Commit-Queue: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#539}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
TabAndroid supports base::SupportUserData
This CL lets TabAndroid supports base::SupportUserData, then
ChromeAutocompleteProviderClient can store stripped urls in TabAndroid
to avoid stripping url over and over again.
(cherry picked from commit 4f474f7c1cfb245a2667b783a2026b73428d7e17)
Bug: 1094056
Change-Id: If0448c825965ddc7f43bd2aacc9c1d868e27b09f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472461
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#818132}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486411
Reviewed-by: Gang Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#538}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge to release branch: Revert "Instrument the UUID properties of BluetoothRemoteGATT interfaces for the"
This reverts commit 5f6a15dfe64ea9265b0624fcc494c13351618e2f.
Reason for revert: This API does not appear to have high usage, so is
unlikely to give us much data for the Identifiability Study. This
instrumentation will, however, make it less likely for us to select
other APIs (from which to collect data) on a given client.
(cherry picked from commit 2b39bbccf938ddc30807dc5ba4515683f14279ed)
Bug: 973801, 1137831
Change-Id: I7c6b07c168dec642b8110297b605cb17091e2a1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464002
Reviewed-by: Asanka Herath <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815832}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475933
Commit-Queue: Reilly Grant <[email protected]>
Auto-Submit: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#537}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
cros: Fix translucent selection background rendering for Textfield.
Currently if a Textfield has a translucent background, the contents of
the textfield contains spaces and a user makes a selection, some areas
are drawn over multiple times making them slightly more opaque.
This CL merges overlapping selection regions when the selection's
background is translucent to fix this bug.
(cherry picked from commit ccab423f0ee27ebd5190d0664da3d8ee6e18c47a)
Test: manual + added test
Change-Id: Ic222ab0fba9e2a36f43851620313308057c60bed
Fixed: 1134440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460953
Commit-Queue: Jeremy Chinsen <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817259}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487442
Reviewed-by: Sammie Quon <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#536}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Paint Preview] Only show upgrade toast when tab is visible
(cherry picked from commit 97a3e0a46af79db846296e091930df2cebabd39f)
Bug: 1138902
Change-Id: If0a8944718004ab56f7e60c532b051ded909ea0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476033
Commit-Queue: Mehran Mahmoudi <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Auto-Submit: Mehran Mahmoudi <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817510}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488221
Reviewed-by: Mehran Mahmoudi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#535}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
DevTools: disable NoGPUCaptureScreenshotTest.LargeScreenshot when sw compositing is not available
(cherry picked from commit e5857fc3bd86704b22fd334c75ee27029d4ac83f)
TBR: [email protected]
Bug: 1137291
Change-Id: Id9ae17cce017e977adac8d6fee3f2d265f6ad89a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468945
Commit-Queue: Dmitry Gozman <[email protected]>
Reviewed-by: Dmitry Gozman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816880}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487681
Reviewed-by: Andrey Kosyakov <[email protected]>
Commit-Queue: Andrey Kosyakov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#534}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Cherry-pick] [Cast MRP] Don't automatically terminate non-local mirroring activities.
(cherry picked from commit bed81479a3b12531ff17e9e6d471cdebeb6cfe2e)
Bug: 1138469
Change-Id: Idcb06541f74c1795abef7725176aa87b7cab0337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472206
Reviewed-by: Takumi Fujimoto <[email protected]>
Commit-Queue: John Williams <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817257}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487068
Commit-Queue: Takumi Fujimoto <[email protected]>
Auto-Submit: John Williams <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#533}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
DevTools: add a test for large screenshot with disabled gpu compositor
(cherry picked from commit 008982df7ef754a1ce794906fb69f53843169cfd)
TBR: [email protected]
Bug: 1137291
Change-Id: Ic715eccbbbc9bd8b7eb8877df786f21c5f54db94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462091
Commit-Queue: Andrey Kosyakov <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816290}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487255
Cr-Commit-Position: refs/branch-heads/4280@{#532}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[grid] Relayout grid items when definiteness changes.
Previously LayoutGrid performed a simple logical-height change check
to determine if a grid-item needed relayout.
This wasn't correct as when setting an override logical-height the
definiteness can change causing %-height children to resolve
differently.
This became troublesome after we moved relative-positioning into NG
as %-block-start, %-block-end offsets weren't resolving correctly.
This however also fixes other issues such as test:
percentage-size-subitems-002.html
Where LayoutGrid wasn't performing a relayout causing grandchild to size
incorrectly.
This may have a performance hit for any legacy children being having
layout performed by a LayoutGrid, however should be fine for an NG child
as we have much more precise cache logic for this case.
The following tests have been marked as failing:
virtual/layout-ng-grid/external/wpt/css/css-grid/relative-grandchild.html
virtual/layout-ng-grid/external/wpt/css/css-grid/grid-items/percentage-size-subitems-002.html
as GridNG doesn't correctly set up the constraint spaces yet.
(cherry picked from commit 0d91e5143c34032d324be0e18e8bfa1f6dbb5c74)
Bug: 1138504, 1018439
Change-Id: Iac2484f1b175f152e491f421449fb7b555c9e125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474917
Commit-Queue: Ian Kilpatrick <[email protected]>
Reviewed-by: Morten Stenshorne <[email protected]>
Reviewed-by: Christian Biesinger <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817631}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487066
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#531}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Orderfiles from 87-4277.0-1602498224-benchmark-87.0.4280.24-r1 to 87-4280.20-1603111242-benchmark-87.0.4280.25-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic51cbfcebd12dd0907204cb9a0dc46c1b484bc9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485458
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#530}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Paint Preview] Fix failed assertion in PseudoTab
This assertion can fail because this path is now also accessible if
PAINT_PREVIEW_SHOW_ON_STARTUP flag is enabled.
It was added here: crrev.com/c/2472432
(cherry picked from commit 157c155ba04ccf127cdd943686406dfec93927ad)
Bug: 1134752
Change-Id: I20d8937b24de77c366a8bf552a68ff787d488959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485395
Commit-Queue: Mehran Mahmoudi <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#818561}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485584
Reviewed-by: Mehran Mahmoudi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#529}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Paint Preview] Fix startup bug with Start Surface enabled
When StartSurface experiment is enabled, it will either:
1. Be shown on startup if a certain condition is met, or
2. Not be shown on startup.
Currently, paint preview is not displayed on startup if StartSurface
is enabled, regardless of whether StartSurface will be actually shown or
not (1 or 2 above).
This CL will display paint preview on startup if StartSurface is enabled
AND it won't be shown on startup (scenario 2 above). This is done by
making sure that ReturnToChromeExperimentsUtil#getTotalTabCount works
correctly when it's called pre-native and PAINT_PREVIEW_SHOW_ON_STARTUP
experiment is enabled.
(cherry picked from commit a87b527fbf41fce57368ba7c1cc726942b3a0357)
Bug: 1134752
Change-Id: I4d51396d82bee837184db038198770905a7f972c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472432
Commit-Queue: Mehran Mahmoudi <[email protected]>
Reviewed-by: Mehran Mahmoudi <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Auto-Submit: Mehran Mahmoudi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817215}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485304
Cr-Commit-Position: refs/branch-heads/4280@{#528}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: Ibd04956d0f8f9b9dc3522dcfdcfb6f145360e388
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485579
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#527}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Passwords] Include Link in Password Check Removal Confirmation
This change adds a link to the origin to the dialog shown when removing
a compromised credential. Since injecting links to insecure domains is
not allowed due to the risk of XSS, this is limited to HTTPS origins.
(cherry picked from commit 4e93b4cd0a66f9ee663c01f5cce1c8475c025efe)
Fixed: 1066790
Change-Id: I297c3e49b4388bed5c229959345741565b1d2092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133966
Reviewed-by: dpapad <[email protected]>
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817525}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485266
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#526}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Passwords] Show n weak credentials in weakness check
This change replaces "Found n security issues" with "Found n weak
passwords" in the case where the user is signed out and has no
compromised credentials.
Translation Screenshot:
https://storage.cloud.google.com/chromium-translation-screenshots/8f393f395ae0dda9238b4f170c9d9940cd2a60a9
(cherry picked from commit 0861e761bcbe2207df07aa7111d555e48d15b3ce)
Bug: 1138468
Change-Id: I0cb563ee35f60f63bfd4dd503efe955c8876b80b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475913
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Reviewed-by: Viktor Semeniuk <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817619}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485502
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#525}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Mark for compositing inputs update after unthrottling.
A previous CL (*) made PaintLayerCompositor::CanBeComposited
depend on throttling state. CanBeComposited in turn affects compositing
inputs. Therefore when throttling state changes, compositing inputs
need to be re-computed.
(*) https://chromium-review.googlesource.com/c/chromium/src/+/2277332
Bug: 1139116
(cherry picked from commit 96f3048eb9194d8ab5ed157c46f549084bd103bb)
(cherry picked from commit 81eed342a1201a90a691dee3691ab79d299bf4fc)
Change-Id: I1152e447ade9f2f848707f992f9c4fc1574bba7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485438
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Stefan Zager <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#818625}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485625
Reviewed-by: Krishna Govind <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4296@{#11}
Cr-Original-Branched-From: 348f473375481bbae653524aad76d79cb8285fd7-refs/heads/master@{#818242}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486545
Reviewed-by: Chris Harrelson <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#524}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add finch kill switch for removal of default app protected storage
Release team strongly prefers a kill switch for merges to stable.
R=[email protected]
(cherry picked from commit 662a284aad5265de159f48e967e3343f66e09240)
(cherry picked from commit 55ce93c57c1d42bd0f816974481a892aad736b0c)
Bug: 1139902
Change-Id: I6b7f98c3d1032c1cf9098d2ded87413e89bdd530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486396
Commit-Queue: Daniel Murphy <[email protected]>
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Auto-Submit: Daniel Murphy <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#818737}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486621
Reviewed-by: Krishna Govind <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4296@{#14}
Cr-Original-Branched-From: 348f473375481bbae653524aad76d79cb8285fd7-refs/heads/master@{#818242}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486669
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#523}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[fuchsia] Switch base_unittests to use archivist-for-embedding.cmx
Update base_unittests.cmx to inject archivist-for-embedding.cmx instead
of archivist.cmx, which has been removed in Fuchsia.
(cherry picked from commit faadfc480b3746b7348758988c3dccda265a2a4a)
Bug: 1139075
Change-Id: Id5d30e5c9be7b14e9c5c7f4633ceb5ef4a032ca6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477423
Auto-Submit: David Dorwin <[email protected]>
Commit-Queue: Sharon Yang <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Sharon Yang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817724}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486782
Reviewed-by: David Dorwin <[email protected]>
Commit-Queue: David Dorwin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#522}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[OsSettingsLanguages] Enable flag by default
OS tests need the flag to be disabled because some routes are
conditionally created in os_route and loadTimeData needs to
be overridden even before the test suite is started.
Browser tests work with just a change in loadTimeData value.
(cherry picked from commit 9b28a79079c8d3a283332ecb5666506730686649)
Bug: 1097328, 1109431
Change-Id: If3e1f5914764016ccc96238461ed9ea9923600ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469337
Reviewed-by: Regan Hsu <[email protected]>
Commit-Queue: My Nguyen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817233}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472678
Reviewed-by: My Nguyen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#521}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Screenshot] make clear string accessible to android for A11y
Bug: 1137985
Change-Id: I9172e311c43f8bf7a8aa8af9b9eed3bcd343ecac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472533
Reviewed-by: Jeffrey Cohen <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Reviewed-by: Kristi Park <[email protected]>
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Jeffrey Cohen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#817746}
(cherry picked from commit 04b5f37f035f0268f307f026b9495e30d17abf46)
[email protected]
Change-Id: I9172e311c43f8bf7a8aa8af9b9eed3bcd343ecac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486547
Reviewed-by: Jeffrey Cohen <[email protected]>
Commit-Queue: Jeffrey Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#520}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Handle more cases of display changes for output protection
Originally the observer was only listening on DisplayMetricsChanged, but
in testing I noticed that was not sufficient as it didn't cover the case
of display removal. I've also added handling display added/removed so it
should catch all cases of display change now.
BUG=b:170780507,b:153111783
TEST=Display plug/unplug repeatedly is now handled for HDCP
(cherry picked from commit da82bf1bea37ee5ce7f17ebb19ac117b856ec7ce)
Change-Id: Ie2ecbe2d494908dc51b4efd7bf4acf93555c09ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472020
Auto-Submit: Jeffrey Kardatzke <[email protected]>
Commit-Queue: Xiaohan Wang <[email protected]>
Reviewed-by: Xiaohan Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817156}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485627
Reviewed-by: Jeffrey Kardatzke <[email protected]>
Commit-Queue: Jeffrey Kardatzke <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#519}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.26
[email protected]
Change-Id: I88fc6344a2a8237d29d4cb51537dbb4e943691e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485525
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#518}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll src/third_party/freetype/src/ 20186d1be6415d1..d7caaf8517fa6d (1 commit)
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/20186d1be6415d1..d7caaf8517fa6d
git log 20186d1be6415d1..d7caaf8517fa6d --date=short --no-merges --format='%ad %ae %s'
2020-10-19 [email protected] Test early to prevent overflow.
Change-Id: I5e9cc59be24a72a5f2fbe81d8f1bb0405b5aa37a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486253
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#517}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Hardcode default apps to not have protected storage.
This fixes an issue I introduced in m85 here:
https://chromium-review.googlesource.com/c/chromium/src/+/2181827
during our migration of all "bookmark apps" off of the extensions system
and onto the WebAppProvider system.
Making YouTube no longer a 'bookmark app' (and back to a hosted app)
had the side effect of making its storage protected, because apparently
all hosted apps have their storage protected.
This change marks all potential default hosted apps as no longer
receiving protected storage.
The long term fix for this issue is to have the WebAppProvider system
support default apps, and migrate these old hosted apps (which is a
double-deprecated system) onto the WebApp platform:
https://bugs.chromium.org/p/chromium/issues/detail?id=1140122
R=[email protected]
(cherry picked from commit f800edbd1b50ecc13a0d3391f5f45ba9c84625be)
(cherry picked from commit 954e0815dff6f929a9d7c3f251a7143ed1a5a436)
Bug: 1139902
Change-Id: I0d09eed3bf232407192fd07e621b82bcac4263f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485436
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Chase Phillips <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Commit-Queue: Daniel Murphy <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#818570}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485049
Reviewed-by: Krishna Govind <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4296@{#7}
Cr-Original-Branched-From: 348f473375481bbae653524aad76d79cb8285fd7-refs/heads/master@{#818242}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485139
Reviewed-by: Daniel Murphy <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#516}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Migrate broad identifiability study settings use to more specific calls
Many uses of IdentifiabilityStudySettings::Get()->IsActive() and
IsUserInIdentifiabilityStudy() are converted to more specific calls that
check whether the corresponding type or surface is allowed. This will
allow for the individual types or surfaces to be disabled via finch,
instead of relying on an all-or-nothing approach.
All users of the deprecated IsUserInIdentifiabilityStudy() method are
migrated in this cl, so we also remove the method. Additionally,
IdentifiabilityStudySettings::IsWebFeatureAllowed() is added as a
convenience method.
(cherry picked from commit 0b436f0349dba39f4b47581d18e3c2410ab62717)
Bug: 973801, 1136938
Change-Id: I9b20a4f1c10154f2dd8ac6fa104e31197b2e0e95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469258
Reviewed-by: Jeremy Roman <[email protected]>
Reviewed-by: Asanka Herath <[email protected]>
Commit-Queue: Alex Turner <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817183}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485535
Cr-Commit-Position: refs/branch-heads/4280@{#515}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Lens Controller - add a queryImage method to support passing back app intent key from Lens Prime SDK.
The app intent key will be used when generate the Lens deeplink intent in LensUtils.java.
Cherry pick of https://chromium-review.googlesource.com/c/chromium/src/+/2450709
for the M87 branch which was approved here:
https://bugs.chromium.org/p/chromium/issues/detail?id=1099982
(cherry picked from commit b10bf33a7da56dfe5062f568588fe02ffc4f0bea)
Change-Id: I40a58eaabaadb23a3113825400c3be95396aa4f0
Bug: 170126006
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450709
Commit-Queue: Yu Su <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Ben Goldberger <[email protected]>
Reviewed-by: Sinan Sahin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814967}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485622
Cr-Commit-Position: refs/branch-heads/4280@{#514}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Use correct Surface::Type for font lookups by unique name only
Currently, such lookups are accidentally recorded under
kLocalFontLookupByUniqueOrFamilyName due to a typo. This affects the
metrics recording for the identifiability study
(cherry picked from commit 7a5a9f5996cc2aaec80705507d561fa439d9c46f)
Bug: 1136921
Change-Id: Ibf4a28a6edfabff0a570bd35c09686b5b020957d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463702
Reviewed-by: Asanka Herath <[email protected]>
Reviewed-by: Dominik Röttsches <[email protected]>
Commit-Queue: Alex Turner <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816675}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485673
Commit-Queue: Asanka Herath <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#513}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Window Placement: Fix cross-screen fullscreen exit on Mac V2
Post the task to restore bounds after the exit transition completes.
(as opposed to when the fullscreen exit transition starts)
See crrev.com/c/1990137 for the original fix.
Plumb *Start and *Complete signals through NativeWidgetMac.
Plumb as *Changing and *Changed signals to BrowserView.
Continue running other BrowserView logic in *Start/*Changing.
Update ImmersiveModeControllerAsh to call the intended function.
TODO: Refine naming and/or move all BrowserView logic to *Changed.
(cherry picked from commit d18ea8bb2c8089e74838b8f781ba5f08420b8516)
Bug: 1134705
Test: jsfiddle.net/cterefinko/rwo08as4 Enter->Swap->Exit WAI
Change-Id: If81438181dd4454a975fcc9198d57136b9137044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468345
Reviewed-by: ccameron <[email protected]>
Commit-Queue: Michael Wasserman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817098}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485443
Reviewed-by: Michael Wasserman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#512}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Add UMA logging for Lens Chip
Cherry pick of
https://chromium-review.googlesource.com/c/chromium/src/+/2442009
for the M87 branch which was approved here:
https://bugs.chromium.org/p/chromium/issues/detail?id=1099982
(cherry picked from commit 8c3b9377fa65aad94818eb8ed5ec00ea43997bba)
Change-Id: I3ef5e2dece7f02adef016d41ceb0330f59871e53
Bug: b/164245846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442009
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Sinan Sahin <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Ben Goldberger <[email protected]>
Commit-Queue: Yu Su <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814013}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485339
Cr-Commit-Position: refs/branch-heads/4280@{#511}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Instrument MediaCapabilities::decodingInfo() for identifiability study
This will help determine whether the API leaks any cross-site entropy
about users and, if so, how much.
(cherry picked from commit 10add1d97267e69ab2083e3dd6177b1552e4935b)
Bug: 973801
Change-Id: I244130bfd50b0b745a7c215d3a01490b1443cd05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436620
Reviewed-by: Jeremy Roman <[email protected]>
Reviewed-by: Mounir Lamouri <[email protected]>
Reviewed-by: Asanka Herath <[email protected]>
Commit-Queue: Alex Turner <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817082}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485533
Cr-Commit-Position: refs/branch-heads/4280@{#510}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Allow for disabling of font identifiability metrics recording via finch
Currently, FontMatchingMetrics uses the broader
IdentifiabilityStudySettings::IsActive() call for its early returns.
This ensures that unnecessary computation is not performed for users not
participating in the study. We update these methods to use more specific
checks that allow for server-side disabling of font metrics recording.
(cherry picked from commit e420c0a2b88ab3bab2aa38110e2982c8711bbed0)
Bug: 1136938
Change-Id: I12bdbd47e8bc0e6567f796fd3b058f02f4dd105a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466143
Reviewed-by: Dominik Röttsches <[email protected]>
Reviewed-by: Asanka Herath <[email protected]>
Commit-Queue: Alex Turner <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817019}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485672
Cr-Commit-Position: refs/branch-heads/4280@{#509}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4277.0-1602506009-benchmark-87.0.4280.24-r1 to 87-4280.17-1603104938-benchmark-87.0.4280.25-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I05fd9f65027d5497771c0804a3c9dd085d33f030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486138
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#508}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: I990884d936d2b36aac4da711dff483818dfb1141
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485396
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#507}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4277.0-1602501961-benchmark-87.0.4280.24-r1 to 87-4277.0-1603101389-benchmark-87.0.4280.25-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Iadab47f8f0528a5b3a633db3762b708ba10fb078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485693
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#506}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4277.0-1602498224-benchmark-87.0.4280.24-r1 to 87-4280.20-1603111242-benchmark-87.0.4280.25-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic254df52c4eae3ce454aa731c1e3bcc8906ac74f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485606
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#505}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Download later: Add a Finch param to check lite mode.
If require_lite_mode is set to true, download later dialog will show
only when lite mode(data saver) is enabled.
[email protected]
(cherry picked from commit d64a4f38348f3b7d7b17c5c756e2a74aa557ad8f)
Bug: 1137925
Change-Id: I8655750cac482fa65cd848b4a688fe97366f634e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469457
Reviewed-by: David Trainor <[email protected]>
Commit-Queue: Xing Liu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#818180}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485038
Reviewed-by: Xing Liu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#504}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[SharingHub] Call cancel callback when the sharesheet is destroyed.
(cherry picked from commit c8a032c55751c724e54bc40d69285d428f0f8159)
Bug: 1138750
Change-Id: I0cf69bfad56ed24704d0e2e02050537c2fbea73e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473804
Reviewed-by: Kyle Milka <[email protected]>
Commit-Queue: Sophey Dong <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817550}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485832
Cr-Commit-Position: refs/branch-heads/4280@{#503}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Autofill] Update suggestion UI to include offer message.
Includes a third line in the autofill popup suggestion UI, which will
include credit card offer data.
(cherry picked from commit edf32f6bbc794ea0da259eca8c6c9983406a3aba)
Bug: 1138956
Change-Id: I26b2c647a6dbe81ec367ff75dbdcc2074375b7fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436849
Reviewed-by: Vasilii Sukhanov <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Dominic Battré <[email protected]>
Commit-Queue: Manas Verma <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817528}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485135
Reviewed-by: Manas Verma <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#502}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
ios: Fix crash in RestoreItemsState.
GetNavigationItemImplAtIndex() appears to return a nil |cached_item|
sometimes, perhaps due to a mismatch in WKWebView's backForwardList.
Returning early when this happens in RestoreItemsState() may break
some restore state features, but should not put the user in a broken
state.
(cherry picked from commit 3a7192d2d14db799801af485da6202b30d567b6c)
Bug: 1134096
Change-Id: I47a2f1316375860b223fa988e7aca9e4557057d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454291
Reviewed-by: Ali Juma <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Commit-Queue: Justin Cohen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815204}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485572
Reviewed-by: Justin Cohen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#501}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Apply edits when closing the bookmarks bubble
Fixes regression where the dialog had to be explicitly accepted to apply
pending updates.
(cherry picked from commit 417603ce00e6dc879b85400d833e26f82fd867d6)
Bug: 1137491
Change-Id: I9c8166aa013714b08280eaf1d51c7831dcd6b9a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476719
Commit-Queue: Peter Boström <[email protected]>
Commit-Queue: Elly Fong-Jones <[email protected]>
Auto-Submit: Peter Boström <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817628}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485836
Reviewed-by: Peter Boström <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#500}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge M87] Fix bug where upload of clicks/views is disabled on feed stream destroy
Other related changes:
> Added a gate for the feature in the action manager that would have prevented the problem on not spreading on clients that don't have the feature enabled
> Added test coverage.
(cherry picked from commit 2d5b7d1cfef8d65f40422d27c9296adb06848812)
Bug: 1139904
Change-Id: Ib9105b038f506e897fdca7fb99a987bd473e1a2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481302
Reviewed-by: Dan H <[email protected]>
Commit-Queue: Vincent Boisselle <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#818176}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485193
Reviewed-by: Vincent Boisselle <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#499}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: Idfb3d9d7c0734b55366538b5ac9d482d6fe1a604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485191
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#498}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Properly hide 'advance-override' behind flag
crrev.com/c/2415244 introduced a new runtime flag for 'advance-override'
but didn't properly handle it in the parser. As a result, the descriptor
is leaked to web.
This patch fixes the parser to make sure it's properly hidden behind the
flag.
(cherry picked from commit 1378e492df2669fabece417164c25862aa13b7f1)
Bug: 1137624
Change-Id: I69f161932aede553b1cb31b181187e687eba1df0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466979
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816628}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485236
Reviewed-by: Xiaocheng Hu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#497}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: Idf8c750ca226ece875a3aceb94741da109f6536d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484266
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#496}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge-87][SH-Clank] Add histograms for cases when tab becomes unavailable.
(cherry picked from commit 1ef9f56f7daca1ce928e1fc6d9e1a56998123ea5)
Bug: 1129652
Change-Id: I02b0ce1774df6c552fa5154df765135d6c81441a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472262
Reviewed-by: Kyle Milka <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: sebsg <[email protected]>
Commit-Queue: Gayane Petrosyan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817551}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485631
Reviewed-by: Gayane Petrosyan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#495}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge M87][WebLayer] Allow GoogleAccountsCallback to be called in incognito
This allows a client to block signin in incognito.
[email protected]
(cherry picked from commit 9e94105a6190238ed5e5a2aaeb0f903800929b12)
Bug: 1138458
Change-Id: I724a4dace1cdb6fc1c38f0640c344a12d4482021
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470467
Commit-Queue: Clark DuVall <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817087}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485432
Reviewed-by: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#494}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Validate input of MediaStreamDispatcherHost::OpenDevice()
This method forwards to MediaStreamManager::OpenDevice(), which
DCHECKs for the stream type to be device video or audio capture
(i.e., webcam or mic). However, MSDH admits other stream types,
which cause MSM::OpenDevice to hit this DCHECK.
This CL ensures that a message containing an incorrect stream type,
which could be sent by a malicious renderer, results in killing the
renderer process.
(cherry picked from commit 229fdaf8fc05e0eeadad380d401c191afd822d92)
Bug: 1135018
Change-Id: I3884dde95d92c41f44966a8ab1dd7bdfd4b23b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472397
Auto-Submit: Guido Urdaneta <[email protected]>
Commit-Queue: Guido Urdaneta <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817151}
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485055
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#493}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Cryptids] Fix Doodle overlap bug
Cryptid rendering should be disabled whenever a Doodle is displayed.
Currently, this condition is occasionally violated due to caching: we
sometimes receive a cached response that there is no logo, followed
by a fresh indication that actually there is one, but the first will have
triggered cryptid rendering, causing overlapping.
This CL solves this bug by invoking the OnLogoAvailable callback in the
LogoService in the Revalidated case (which corresponds to a confirmation
from the server that no logo is available), and tightening the
conditions in NewTabPageLayout to pick up this new invocation.
Bug: 1125889
(cherry picked from commit 8d90c018c167216ba02bc28259b044f45a6b6134)
Change-Id: Iceb36ebd5aa6eaebe6ec4064951eac4c3510feb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443890
Commit-Queue: Tommy Martino <[email protected]>
Reviewed-by: Marc Treib <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814415}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485511
Reviewed-by: Tommy Martino <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#492}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Instrument PostScript name to typeface mapping for identifiability study
Currently, local font lookups are instrumented with a digest of the
lookup value and a digest of the resulting typeface being recorded. We
expand this recording for successful local font lookups: we now also
record a digest of the resulting typeface's PostScript name with the
typeface digest. This will allow the identifiability study to measure
the diversity of installed typeface files with the same PostScript name
(for example, differing versions of the same typeface) and thus
evaluate the privacy impact of that variation.
(cherry picked from commit fffc6331d8120fe5d4390af6fdfb711f139d7258)
Bug: 1136210
Change-Id: Id7ac6229db287af776474f43abd200c51319992e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453439
Reviewed-by: Dominik Röttsches <[email protected]>
Reviewed-by: Asanka Herath <[email protected]>
Commit-Queue: Alex Turner <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815773}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477042
Cr-Commit-Position: refs/branch-heads/4280@{#491}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 Merge] [Paint Preview] Refactor player integeration + core player callback interface
This CL cleans up the player integeration logic with Chrome, which mostly
lived in TabbedPaintPreviewPlayer. That class is now divided in two:
One is responsible of showing a paint preview in a tab, and the other controls
the logic related to the show-on-startup experiment.
This CL also gets rid of most of the logic related to the demo mode. Demo mode
now also uses the TabbedPaintPreview for displaying a paint preview.
Finally, this CL organizes the various callbacks that PlayerManager needs into
one interface.
(cherry picked from commit f7fb04eca368c9bcce33c46a3119c9da2ecb1732)
Bug: 1132451
Change-Id: I748b6bb43d78d174c1a4f79ce8f4325cd2970e2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432752
Commit-Queue: Mehran Mahmoudi <[email protected]>
Auto-Submit: Mehran Mahmoudi <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Reviewed-by: Calder Kitagawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815633}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485771
Reviewed-by: Mehran Mahmoudi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#490}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Classify UMA data for extension messaging user activation triggering.
Split the UMA entry for extension messaging user activation triggering
into four classes, based on whether the script contexts of the sender
and the receiver are privileged or not.
(cherry picked from commit 15f771dc66ec67b2f1f311dbbf8035b975b2666d)
Bug: 1103249, 1047473
Change-Id: Ib23bf2e9427d2b836cdc21c1cf9ebbd685e27299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461251
Commit-Queue: Mustaq Ahmed <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Mustaq Ahmed <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817247}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485012
Cr-Commit-Position: refs/branch-heads/4280@{#489}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix AtomicStringTable lowercase translator.
It was erroneously checking if a candidate entry in the atomic string
table was an existing lowercase version of the provided string by
comparing the two strings for lower-ASCII equality, but this doesn't
imply that the string found in the atomic string table is lowercase
ASCII.
For urgent merging to release branches, this is a minimal fix.
A followup CL will land a more efficient version of this.
(cherry picked from commit 2f19541f156707c517f8bd2b3bdf9d8f729e2587)
(cherry picked from commit 486c4092effb4d632d3bef8f35b7d2832fb88552)
Bug: 1138487
Change-Id: I3af7411879ea831c9210e43cee16bca607b51b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480844
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Commit-Queue: Jeremy Roman <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#818060}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480731
Reviewed-by: Krishna Govind <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4294@{#8}
Cr-Original-Branched-From: 945a64b5e6cd310d9fb6863165edf69d808e0c74-refs/heads/master@{#817614}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480732
Reviewed-by: Jeremy Roman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#488}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Orderfiles from 87-4277.0-1602498224-benchmark-87.0.4280.23-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.24-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I6be1c81b530cd3594f04769a20f7ab553c8a7b54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485335
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#487}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix crash in WasTargetForLastMouseEvent
The frame could be null, ensure if it is we return early.
BUG=1130991
(cherry picked from commit 789a7a446a2e5ab21edb85e51632cf562a1d0035)
Change-Id: I8ced1223f4beb281adcb06c99d9b0fc4b761333e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468237
Reviewed-by: Mustaq Ahmed <[email protected]>
Commit-Queue: Dave Tapuska <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816763}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484952
Reviewed-by: Dave Tapuska <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#486}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android][WebSignin] Add metric for the dismissal button
This CL adds metric for the dismissal button in the web sign-in bottom
sheet.
(cherry picked from commit b453f4d531e356a4bdd27beb7fd90ab5ecd06150)
Bug: 1139309
Change-Id: Idc381b3a79c77aa471b9b1a0b19bcc8fb731a4ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479426
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Alice Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817988}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484447
Reviewed-by: Alice Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#485}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Autofill Assistant] Fix LiteScriptStarted UKM metric.
This was erroneously reported on every start of autofill_assistant, not
just lite-script starts.
(cherry picked from commit 678eb60afd40d458bb41548ca11a867571f9935e)
Bug: 1139251
Bug: b/170952445
Change-Id: I952c7f7aafce879ad7fd8ef7c268b42c5b4fd101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475916
Reviewed-by: Sandro Maggi <[email protected]>
Reviewed-by: Marian Fechete <[email protected]>
Commit-Queue: Clemens Arbesser <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817524}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484791
Auto-Submit: Clemens Arbesser <[email protected]>
Commit-Queue: Sandro Maggi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#484}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix WebStateListMetricsBrowserAgent to observe WebState
The metrics "Tabs.TabCountPerLoad", "Tab.PageLoadInPortrait" and
"Tab.PageLoadInPortrait" stopped being reported in M87 after the
refactoring introducing WebStateListMetricsBrowserAgent.
Change WebStateListMetricsBrowserAgent to observer WebState in
order to properly report the metrics when navigation event occur.
Unit test to prevent such regression will be added in a separate
CL to simplify cherry-picking this CL in M87 branch.
(cherry picked from commit b1a6f2c12897cff3fe0eb907a7e17beae2ff7387)
Bug: 1135129
Change-Id: I589aeabdcc058e8dcd6547c44080aebe4d8a8fed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461332
Reviewed-by: David Jean <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815291}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484694
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#483}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android][WebSignin] Add dismiss button to bottom sheet
This CL adds a dismiss button on the collapsed screen of the web
sign-in bottom sheet.
(cherry picked from commit 0bc5240a719127fe86214cf0470c9cf7ffba45d2)
Bug: 1137322
Change-Id: I0fd7f53e3caa6905ddca334e8a282bca47fa48d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466759
Commit-Queue: Alice Wang <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817854}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484655
Reviewed-by: Alice Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#482}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android][WebSignin] Record error metrics for web sign-in flow
This CL records two error metrics for the web sign-in flow.
(cherry picked from commit 6e3508ec0c228c58c64ebb1401a7a5b31e7028a0)
Bug: 1138925
Change-Id: Ieb5e5b04b1593e1f4e22ffdd9afd7ad0229fbd75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479163
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Alice Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817895}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484695
Reviewed-by: Alice Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#481}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Passwords] Conditionally link to Password Generation in Weak Check
This change conditionally changes the weak password help message and
link depending on whether the user is syncing or not.
Furthermore, it fixes a few other strings by removing an explicitly
included line break tag in the English version.
Translation Screenshots:
https://storage.cloud.google.com/chromium-translation-screenshots/9d058b2be59cb36ced1289875e8249a7204a9674
https://storage.cloud.google.com/chromium-translation-screenshots/335512ad95a0dfe5c36c8d11e8e088d54782c592
(cherry picked from commit 73b9c6f2ca0d5e005726a6f5e3da6fffd0d34eb0)
Fixed: 1138220
Change-Id: I2ce8a0b564fe5bb25b6806288fdfe56383552853
Bug: 1138220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471516
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817171}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484653
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#480}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Passwords] Use dom-repeat in Password Check
This change replaces the usage of iron-list with dom-repeat in Password
Check, which gets rid of unintended resizing effects when clicking some
of the links (see e.g. screenshot in linked bug).
(cherry picked from commit badd264c1d94c314aa6bce4fff70890c610cc1a6)
Fixed: 1138910
Change-Id: I15fbf2910c26dc8749e78cb362975d2f347d9d6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476433
Reviewed-by: Viktor Semeniuk <[email protected]>
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817851}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484594
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#479}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[ios] Fix recording of "Session.*" metrics
With recent change to Multi-Window, the metrics were recorded per
window instead of being recorded per BrowserState. Moreover, only
the currently displayed window's metrics were sent when the app
was backgrounded.
To fix this, add a new base::SupportsUserData::Data object that is
attached to the ChromeBrowserState. This object, SessionMetrics,
stores the session metrics which are updated from events happening
in all of the windows.
In preparation of adding metrics that are only recorded for the
off-the-record ChromeBrowserState, pass a set of flags to the
method recording the session metrics to choose exactly which one
should be recorded.
Add a call to SessionMetrics::RecordAndClearSessionMetrics() for
both the main and off-the-record ChromeBrowserState on application
background event, and when the off-the-record ChromeBrowserState is
destroyed.
(cherry picked from commit a1e355fa5a2d12b9f9f813462d297431d8045331)
Bug: none
Change-Id: Idee8ef1a1fb0be7153d4ceb78d0a795d589a9848
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450052
Commit-Queue: Sylvain Defresne <[email protected]>
Reviewed-by: Mark Cogan <[email protected]>
Auto-Submit: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814730}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484691
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#478}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Ensure embedding token gets always propagated to parent frame
Currently, the code in RFHI::SetEmbeddingToken() (which gets called as
the result of a document being loaded in a renderer's RenderFrame for
the first time) takes care of locating the correct RenderFrameProxyHost
representing the parent frame remotely to send it the embedding token,
so that the parent-child relationship can get established.
However, there is a race condition for the particular case of inner web
contents in that such propagation will only work if SetEmbeddingToken()
gets called *after* the inner web contents are attached to the outer
one. In that case, since the outer delegater proxy has not been created
yet, SetEmbeddingToken() will fail to find the RenderFrameProxyHost and
the remote frame representing the parent frame in one renderer will not
have its embedding token properly set, breaking things such as the
accessibility tree, for instance.
To fix that, this CL splits RFHI::SetEmbeddingToken() in two parts: one
that actually sets the embedding token and another one that takes care
of propagating it to the parent frame. And with that in place, this CL
does also make sure that such propagation is requested also after inner
web contents get attached, so that the parent-child relationship is
always guaranteed to be set.
(cherry picked from commit 989aeb7a42c6f2d2ae972173c2b5153b45e6ed20)
Bug: 1135691, 1094150
Change-Id: Ie3ddd24acb3ad224a08a31c622e319cd69affba8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462128
Commit-Queue: Mario Sanchez Prada <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816499}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478945
Reviewed-by: Mario Sanchez Prada <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#477}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.25
[email protected]
Change-Id: I860771659c60c3e5b8146d52bbe7cccf8b5d996f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484044
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#476}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
M87 merge: Fix the IconLoadingPipeline::OnReadWebAppIcon crash issue.
CL:2454920 could fix the issue. This CL is used to make it better,
because SkBitmap could be empty:
https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/web_applications/web_app_icon_manager.cc;drc=a450ab794839b63f9c2ba982f738945f90e9fee2;l=422
So for the empty SkBitmap, we can return an empty imageskia, and don't
need to resize or add the ImageSkiaRep.
BUG=1137484
[email protected]
(cherry picked from commit cbdba99985f803e37b3940805d29c875d311d36c)
Change-Id: I0f27c75885a9ced8fbc2f086729b0d58b42be725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470821
Commit-Queue: Nancy Wang <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817245}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482564
Reviewed-by: Nancy Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#475}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4277.0-1602506009-benchmark-87.0.4280.23-r1 to 87-4277.0-1602506009-benchmark-87.0.4280.24-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I68f51a223befec64272e203e594aef48e6ec58ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483494
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#474}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4277.0-1602501961-benchmark-87.0.4280.23-r1 to 87-4277.0-1602501961-benchmark-87.0.4280.24-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic7d6627bfc7b2ff079eaee2c67e44da849ccf780
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483495
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#473}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4277.0-1602498224-benchmark-87.0.4280.23-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.24-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Iea895a4757c1a80a2e229b626e08686402b1a3ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483492
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#472}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Orderfiles from 87-4277.0-1602498224-benchmark-87.0.4280.22-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.23-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I24fde10ad3ca402a24b66ecafddbca1549feef17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483522
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#471}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.24
[email protected]
Change-Id: I0c2a7eb9a05cecf6dc3996975ef4c01b3f23fd27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483043
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#470}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4277.0-1602506009-benchmark-87.0.4280.22-r1 to 87-4277.0-1602506009-benchmark-87.0.4280.23-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ie64ebe304da355bf9df168e79ce85be14329f3be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482061
Commit-Queue: Chrome Release Autoroll <[email protected]>
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#469}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4277.0-1602501961-benchmark-87.0.4280.22-r1 to 87-4277.0-1602501961-benchmark-87.0.4280.23-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I70d14c8da87cac666fd08bc83c300346fbf76cbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482033
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#468}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4277.0-1602498224-benchmark-87.0.4280.22-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.23-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I7b79b9ac187c9a821a46fda5f79f5ba77bb0f132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482942
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#467}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Use tab storage to track insecure form interstitial proceed actions
crrev.com/c/2451549 broke the proceed action on interstitials. This
adds a tab storage class that stores when we are in the middle of a
proceed, and we no longer show an interstitial if that is the case.
This also fixes the "reload is proceed" bug (crbug.com/1093955).
Bug: 1134466, 1093955
Change-Id: Ibe6f6eab757cf8ea58def940793ffb7a7f68d1f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454387
Auto-Submit: Carlos IL <[email protected]>
Reviewed-by: Mugdha Lakhani <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Commit-Queue: Carlos IL <[email protected]>
Cr-Commit-Position: refs/heads/master@{#816292}
(cherry picked from commit 0541245e97579b7836b04641403244ab83a08015)
TBR: [email protected]
Change-Id: Ibe6f6eab757cf8ea58def940793ffb7a7f68d1f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482842
Commit-Queue: Carlos IL <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#466}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
m87: Do not set input focus for combo boxes when SA focus moves to them
This was done back in
https://chromium-review.googlesource.com/c/chromium/src/+/2231660
likely to support sending arrow keys in a prior iteration to support combo
boxes.
R=[email protected]
(cherry picked from commit f9c17f09ea525fd0f15eb681cf66cf132fb865a4)
Fixed: 1137612
Change-Id: Iaa974ae8eecafc16612df092a5ebba36031a7d1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472529
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817217}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482093
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#465}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Orderfiles from 87-4277.0-1602498224-benchmark-87.0.4280.21-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.22-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I29349a1f81bd63385a72e3864b0facd8a2f249f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481756
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#464}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge to M87: Guard VideoCaptureDeviceAVFoundationFrameReceiver
The class VideoCaptureDeviceAVFoundationFrameReceiver cannot handle
concurrent calls. Make VideoCaptureDeviceAVFoundation guard all access
like VideoCaptureDeviceAVFoundationLegacy does.
[email protected]
(cherry picked from commit eafed0bb7242b0dd0cbc6e9b25807329fb81950a)
Bug: 1135246
Change-Id: I6ae5a810ed2df9af4de0b4412b3dfe906b666b41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454426
Reviewed-by: Markus Handell <[email protected]>
Commit-Queue: ccameron <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814884}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479702
Reviewed-by: ccameron <[email protected]>
Commit-Queue: Markus Handell <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#463}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
M87: Disable AVFoundationCaptureV2ZeroCopy by default.
The Mac zero-copy path through Chrome in M87 isn't quite ready for prime
time yet, as performance reports from downstream project show.
This CL disables AVFoundationCaptureV2ZeroCopy by default. The effect
is that we supply video samples the legacy way.
TESTED=local manual test with Facetime HD camera, presubmit
Bug: 1127791, 1125879, 1139275
Change-Id: I24a9f8362cd55592ba01489ff3a2b81ad3064e47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479132
Reviewed-by: Guido Urdaneta <[email protected]>
Reviewed-by: ccameron <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: Markus Handell <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#462}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Change colors in the enhanced protection block.
screenshots:
http://dr/corp/drive/folders/1oBaL1kn0atceglGP02LWFVUPPxLLsqx9, files
start with v2*.
(cherry picked from commit afeaea10cf561b8b8410261e37f94555ae31a9b6)
Bug: 1137616
Change-Id: I9e90d6a94fd37b12cade3b60d2ff174416b2a2b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469176
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Varun Khaneja <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816817}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482090
Reviewed-by: Xinghui Lu <[email protected]>
Commit-Queue: Xinghui Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#461}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Demote CompositeSVG to experimental
We still have several bugs about transform animation to fix.
[email protected]
(cherry picked from commit 914c047313f7dbb8122aa27158dbba9b30140975)
Bug: 1101002
Change-Id: I8ca37e70fd0391ee3b43c5e63e3436b810e169c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471817
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817219}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482325
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#460}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Show mixed form warning for mixed forms that submit to new tab
Previously forms on secure sites that submit to an insecure target, but
that submitted on a new tab (with target=_blank) showed the on form
warning but not the on-submit one. This CL fixes it.
Pending work: Like other interstitials for navigations on new tabs,
this will go back to the NTP if Go Back is selected, it might make
more sense to close the new tab in this case, but in the interest of
keeping the CL simple for merging, this will be done on a separate CL,
which won't be merged.
Bug: 1134466
Change-Id: I6169fef6bd368f9c8ca054d7bbd8f96e50490956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451549
Commit-Queue: Carlos IL <[email protected]>
Commit-Queue: Emily Stark <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Auto-Submit: Carlos IL <[email protected]>
Cr-Commit-Position: refs/heads/master@{#814059}
(cherry picked from commit 2f64d2afed25c2a549874342e2186f4447253312)
TBR: [email protected]
Change-Id: I6169fef6bd368f9c8ca054d7bbd8f96e50490956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482324
Commit-Queue: Carlos IL <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#459}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Safety Tips] Make interaction metrics more granular.
This CL breaks out three of the most common kUnspecified safety tip
interactions into their own interactions.
(cherry picked from commit 959dbe242853b1a71549e720de70c476af932b52)
Fixed: 1137854
Change-Id: I7735b66a855230af43075717e9581587e0d13a9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468937
Commit-Queue: Joe DeBlasio <[email protected]>
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817053}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482183
Reviewed-by: Joe DeBlasio <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#458}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.23
[email protected]
Change-Id: I9c7fd0b0b7143b1cdb7b64377abca9fe3c252487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482004
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#457}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
4280: Add ozone_unittests filter file to beta & stable betty testers.
The filter file exists on both branches:
https://chromium.googlesource.com/chromium/src/+/refs/branch-heads/4240/testing/buildbot/filters/chromeos.ozone_unittests.filter
https://chromium.googlesource.com/chromium/src/+/refs/branch-heads/4280/testing/buildbot/filters/chromeos.ozone_unittests.filter
So just needs the cmd-line arg specified.
(cherry picked from commit bce9b2a97965d0628e85e239731df18ad474cbeb)
Bug: 968349
Change-Id: Idf88d88e11f1bf03ab6d93e354c14844b1b43482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472208
Reviewed-by: Achuith Bhandarkar <[email protected]>
Commit-Queue: Ben Pastene <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817538}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481903
Auto-Submit: Ben Pastene <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#456}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[CherryPick][SH] Handle Empty Referrer Case
The Search Engine check DCHECK's on empty URL. Empty Referrers exist,
so it's better to handle that case than DCHECK on it.
(cherry picked from commit 0f9227259bdc6e3a5538f6b2e93e181291f31389)
Bug: 1131107
Change-Id: Ic238ff86ccc6cee912baea37d8f549b99b685f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480963
Reviewed-by: sebsg <[email protected]>
Commit-Queue: Sebastien Lalancette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#818048}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480629
Reviewed-by: Sebastien Lalancette <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#455}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "Remove TS_SS_TRANSITORY flag from TSF"
This reverts commit 5d66d2641816deb4aa942de069a7b2e0d6ee696f.
[email protected],[email protected]
(cherry picked from commit c581014e8ec5c7f5732fa4f6bf75649f88c625aa)
Bug: 1137267, 148355
Change-Id: Iba8a3cb59a12ddd4310849ee1cf877cb7ea8a019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471881
Commit-Queue: Anupam Snigdha <[email protected]>
Reviewed-by: Anupam Snigdha <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817109}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481066
Cr-Commit-Position: refs/branch-heads/4280@{#454}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: I2b53f30b9237ced4770b183ae0e030bfd7b1c008
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481244
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#453}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Disable glFlush workaround on Apple silicon
This workaround is based on data gathered on Intel Macs. While it has
a performance impact, it significantly reduces the GPU crash rate. The
performance impact on ARM is more significant, and there is no evidence
that this is needed (yet).
[email protected]
(cherry picked from commit 52ff08a31c488a549510e827eec3eb0701188346)
Bug: 1131312
Change-Id: Ibd4b3940172820e17d0dc7607842118aba75c038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447044
Commit-Queue: ccameron <[email protected]>
Reviewed-by: Daniele Castagna <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814097}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481052
Reviewed-by: ccameron <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#452}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4277.0-1602506009-benchmark-87.0.4280.21-r1 to 87-4277.0-1602506009-benchmark-87.0.4280.22-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I6b38c4ad6f388caf4ff380fc59777749e19127b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480713
Commit-Queue: Chrome Release Autoroll <[email protected]>
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#451}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4277.0-1602501961-benchmark-87.0.4280.21-r1 to 87-4277.0-1602501961-benchmark-87.0.4280.22-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Iddd4b96c309bd6bc2d798b69c392bee51c5e4583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481419
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#450}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4277.0-1602498224-benchmark-87.0.4280.21-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.22-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Idf31a054d1557fbfac551418067585450eb9e1e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481409
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#449}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
MacPWAs: Re-create app shims when arch changes
In crbug.com/353047, we encountered the problem where Chrome
would upgrade itself from 32-bit to 64-bit, but app shims
would be stuck on 32-bit. A mechanism was added to upgrade
the shims "when needed", based on a kAppShortcutsVersion local
preference. This number has been incremented several times for
various incompatibilities.
Add a separate kAppShortcutsArch preference which saves the
architecture that apps have been being created in. Whenever
this does not match base::SysInfo::OperatingSystemArchitecture,
re-create all shims.
This will fix the situation whereby a user data dir, including
all of its local prefs, is copied from an Intel mac to an ARM
mac.
A few caveats:
- This will only re-create PWA shims. Legacy apps will need to
be re-launched from Chrome.
- This only fixes the issue if the user launches Chrome before
launching a PWA. The PWA shim copied from x86, if it succeeds
in running, will start Chrome with the start URL for the PWA.
[email protected]
(cherry picked from commit 5eec1b658e90a9acc5de1474ab5bd491d48c23be)
Bug: 1117599
Change-Id: I4d9e1a87e91c1d461b592b0a8250b22120368d94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444130
Commit-Queue: ccameron <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813631}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481067
Reviewed-by: ccameron <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#448}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Remove unsafe access in dtor
Oilpan destruction order is non-deterministic, and it is unsafe to
access other on-heap objects from a dtor.
This CL removes such accesses, in favor of letting Oilpan clear out
WeakMembers automatically.
If threading issues or other crashes happen, the USING_PRE_FINALIZER
macro should be used for cleanup instead.
(cherry picked from commit d2cbd805a004c37c9321989299d52d9c899f0525)
TBR: [email protected]
Bug: 1137555, 1137557, 1137588
Change-Id: I97fed30743f7000e296b94a29d02e2cfa5c034b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468188
Commit-Queue: Thomas Guilbert <[email protected]>
Commit-Queue: Klaus Weidner <[email protected]>
Auto-Submit: Thomas Guilbert <[email protected]>
Reviewed-by: Klaus Weidner <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816720}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481046
Reviewed-by: Thomas Guilbert <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#447}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87]Revert "Multipaste: Adjust the clipboard nudge bounds when hotseat is shown"
This reverts commit d1b3da5abdca2855ea6d6d02d82543a073e4bf72.
Reason for revert: Breaks tests:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20930
Original change's description:
> Multipaste: Adjust the clipboard nudge bounds when hotseat is shown
>
> This change has the clipboard nudge observe the hotseat state and will
> animate the bounds of the clipboard nudge so that the nudge is always
> placed above the hotseat.
>
> Bug: 1137019
> Change-Id: If00afa1585e0382d7aa41789eca2a981b1323f1d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469364
> Commit-Queue: Matthew Mourgos <[email protected]>
> Reviewed-by: Alex Newcomer <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#817235}
[email protected],[email protected]
(cherry picked from commit 8eff5b05f52f3dbe2de6ef515f7e8e82bf3f46a2)
Change-Id: I9ada14cf0e126d129c5e99b28b6405fbf64457c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1137019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473782
Reviewed-by: Alexey Baskakov <[email protected]>
Commit-Queue: Alexey Baskakov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817377}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481286
Reviewed-by: Matthew Mourgos <[email protected]>
Commit-Queue: Matthew Mourgos <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#446}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Update 4280 DEPS for M87 branching
[email protected]
Change-Id: I7b34c93fe5270dde86700aade1f89c21c03eb787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481007
Reviewed-by: Michael Moss <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#445}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add workaround to avoid crashing when calling LocalBorderBoxProperties
In the presence of rare bugs, it is apparently possible to have a
graphics layer but no LocalBorderBoxProperties.
Bug: 1137883
(cherry picked from commit f907f3506b4b95d73d4363859eb5dfdb7dcc9e25)
Change-Id: I17d65c6ca04d15254efe9b2d13e3de905b59567e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474918
Commit-Queue: Chris Harrelson <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817565}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480806
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#444}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Orderfiles from 87-4265.0-1601289755-benchmark-87.0.4275.0-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.21-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I2ae0a528384e129dd2abfae37e0dde0171389a6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480926
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#443}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87] Chrome OS - Fix double pod issue & MGS
A minor glitch in the UI was causing both user pods to be active
at the same time showing authentication methods. This glitch was
only present in real devices since OnSetTpmLockedState is only
called when a TPM is available.
This CL also fixes a very old bug in the public session pod.
When not active, the public session pod shows an arrow that
appears when the user hovers on it. When the pod is active, the
same arrow is always visible. Clicking on the arrow without the pod
being active violates an invariant in the code that requires the
pod to be active. With this fix, the public session pod will first
simulate a user tap on itself, if it isn't the current active pod.
The first issue, coupled with the preexisting public session pod
issue made logging in into a managed guest session impossible when
there is a user pod in addition to the public session pod.
(cherry picked from commit 09133ca6958f10c38dca7f53ff311907322e9002)
Fixed: 1131704, 1127156, 1127161, 1133926
Change-Id: I0bd0d5d29b0b99c267f2f30283a598955379666a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443291
Commit-Queue: Renato Silva <[email protected]>
Reviewed-by: Denis Kuznetsov [CET] <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816966}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474113
Reviewed-by: Roman Aleksandrov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#442}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[CherryPick][SH] Record metrics from JS response.
(cherry picked from commit 261f3da0c21934eb482969238cc3adf06a6be7c1)
Bug: 1131107
Change-Id: I2a0de73ed846b100a549429888dabeb8ffe2db6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461217
Commit-Queue: sebsg <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Sebastien Lalancette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817023}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480622
Reviewed-by: sebsg <[email protected]>
Commit-Queue: Sebastien Lalancette <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#441}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Sh-Blink] Adjust selection if it starts/ends with non text node
(cherry picked from commit 0228400255408c7e76dee2f778aa30df102e9c15)
Bug: 1133910
Change-Id: Ie7c7758e939c0ff6bee6d64ae03ed0b7c13ea808
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464044
Commit-Queue: Gayane Petrosyan <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817200}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480063
Reviewed-by: Gayane Petrosyan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#440}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[CherryPick][SH] Add common logging functions.
(cherry picked from commit 758d8fd89f3430283bf70a3d51aad5031d86759c)
Bug: 1131107
Change-Id: Ib7b047409a42fe5a4ad5b33ecf10825214c9089d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456126
Commit-Queue: sebsg <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Reviewed-by: Cait Phillips <[email protected]>
Reviewed-by: Sebastien Lalancette <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817004}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472337
Reviewed-by: sebsg <[email protected]>
Commit-Queue: Sebastien Lalancette <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#439}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[fuchsia] Grant web permissions to Frame contents regardless of origin.
Temporarily allow the default permissions granted to each Frame to be
configured by passing a wildcard origin to SetPermissionState().
(cherry picked from commit 0c5037ad7c2712ffe08910b949b9c01d40ab3d26)
Bug: b/170198665, 1136994, 1138916
Change-Id: I653622a5bbe8d8f7d08bc4f1c0fa6da94dc207cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452633
Commit-Queue: Wez <[email protected]>
Reviewed-by: David Dorwin <[email protected]>
Auto-Submit: Wez <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817118}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479169
Reviewed-by: Wez <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#438}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android][WebSignin] Record metrics when bottom sheet is dismissed
This CL records metrics when the web sign-in bottom sheet is dismissed
for different reasons.
(cherry picked from commit 440c0eb31f980735de95b2f3062af6a14ae7f3ed)
Bug: 1138435
Change-Id: I237e20cad5f1a7d14b163150baf72b7d42b8ce1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475233
Reviewed-by: Matthew Jones <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Alice Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817503}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478948
Reviewed-by: Alice Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#437}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Disable RecordPendingOriginCount
This test failed a few times recently in linux-chromeos-rel, which
blocked chromium.chromiumos. Disable it now.
TEST=autoninja build content_browsertests successfully
(cherry picked from commit 6eb0eb373934d7b918554f4b57918575a6362846)
Bug: 1134455
Tbr: [email protected]
Change-Id: I10b6d7e6648491a9d1b3bc9ebe4724044ee7bb0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444610
Commit-Queue: Leo Zhang <[email protected]>
Reviewed-by: Leo Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#813070}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472926
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#436}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android] Don't show sign out dialog in GoogleServicesSettings
If the user has only signed in without giving sync consent then toggling
"Allow Chrome sign in" off should not show the sign out dialog. Instead
it will sign the user out directly without deleting data saved on device
(cherry picked from commit 07bbbb57981eeace48b7babb1ef95cda0cfe354b)
Bug: 1136075
Change-Id: I7d8a75a9c2474759f67fbb0018fa68ad3fa16163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460729
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Tanmoy Mollik <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816969}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479463
Reviewed-by: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#435}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android] Don't show sign out dialog in AccountManagement page
If the user has only signed in without giving sync consent then the
sign out button in account management page should not show the sign out
dialog. Instead it will sign the user out directly without deleting
data saved on device.
(cherry picked from commit 6a61803341412150ef69d574bc99e718bba46552)
Bug: 1136075
Change-Id: Ie2485e2896518113d62cec4a1c9fd57bfbaef2b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460817
Commit-Queue: Tanmoy Mollik <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816150}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479363
Reviewed-by: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#434}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: Icc20a92610d87487d951a5be0557e1d5c41d62dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478223
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#433}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Autofill Offers] Updating text for cards with offers.
Text now includes "Cashback linked" instead of including
the percentage or dollar amount.
(cherry picked from commit 20de10a837134d37880918a2bb7156cf30717bad)
Bug: 1138158
Change-Id: I53e046a6a495cc4b6cabbf35a8876e940f280b49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466142
Commit-Queue: Manas Verma <[email protected]>
Reviewed-by: Siyu An <[email protected]>
Reviewed-by: Jared Saul <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816903}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476912
Reviewed-by: Manas Verma <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#432}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.22
[email protected]
Change-Id: Ica26a9ba11ac92954e85596feb35680374c913ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477458
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#431}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge M-87][Web Payment] Hold GlobalFrameRoutingId
Before this patch, multiple locations in Web Payment, e.g.,
PaymentAppServiceBridge, contained WebContents and
RenderFrameHost pointers that could become invalid and be used
after free.
This patch makes Web Payment store GlobalFrameRoutingId and
always retrieve and null check the RenderFrameHost from it. If
WebContents is needed and the RenderFrameHost is
current, then WebContents is retrieved from the
RenderFrameHost.
After this patch, Web Payment holds a GlobalFrameRoutingId, so the
RenderFrameHost and WebContents can be checked for validity before use.
(cherry picked from commit 8d385ac2244e1d1e733af5b3e23e2bc95b8c91f0)
Bug: 1125614
Change-Id: I084a062c2a7cad100a6d2d0994c1b0cc9b9efc5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422178
Commit-Queue: Rouslan Solomakhin <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Reviewed-by: Danyao Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815307}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476778
Reviewed-by: Rouslan Solomakhin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#430}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix incorrect default coloring.
(cherry picked from commit 501ca7e71662841a2f3f1cb4ebf0c75138b496a9)
Bug: 1137355
Change-Id: Iab0b1a6b8991c9a39da0dbb2d06b227c242a5c62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473137
Reviewed-by: Toni Baržić <[email protected]>
Reviewed-by: Yulun Wu <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Auto-Submit: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817342}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474674
Cr-Commit-Position: refs/branch-heads/4280@{#429}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Fix default search box colors.
(cherry picked from commit c7a81956d29839e8acc0bd7201760ec45bc2dc21)
Bug: 1134721
Change-Id: I50136df0e71e647e4f6629457da13104a7431422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473140
Reviewed-by: Toni Baržić <[email protected]>
Reviewed-by: Yulun Wu <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Auto-Submit: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817339}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474673
Cr-Commit-Position: refs/branch-heads/4280@{#428}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4277.0-1602501961-benchmark-87.0.4280.20-r1 to 87-4277.0-1602501961-benchmark-87.0.4280.21-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I816f6c289881689b21b5a9a3be03de64962e9072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477313
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#427}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4277.0-1602506009-benchmark-87.0.4280.20-r1 to 87-4277.0-1602506009-benchmark-87.0.4280.21-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I7f44011922249c239a3b91355e63199d7f8ffab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477273
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#426}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
cros: Fix crash on multiprofile switch
If the profile being left had a folder, we kept a reference to that
folder in AppListModel's ScopedObserverList.
But when profiles are swapped, we delete everything in the
AppListModel::top_level_item_list_. This means the folder is deleted.
Remove the item from the ScopedObserverList if it is a folder.
(cherry picked from commit fb3b013d94f236594313e6e4db1f0abbbed35804)
Bug: 1130901
Change-Id: I1d6ab268739f81904debcc4654e5663ddf768013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464151
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816300}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466668
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#425}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
cros: Add simple render flag to chrome flags
Just add the about flags entry so it shows up in chrome flags.
Bug: 1138694
(cherry picked from commit 29e0d133506fac44c3e172ecc11e84314736834d)
Change-Id: I6275533df40a2d1f46fdd6898f38e638531eec87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473798
Commit-Queue: Alex Newcomer <[email protected]>
Reviewed-by: Andrew Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817369}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476620
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#424}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: I62fee1a99e7a3f17b1e0b2fe4e4eea1500ea5bc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477153
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#423}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Cros: Use same criteria for added and removed
Just check for whether something can be rendered in HTML using
the same criteria. Forgot to update this line when I changed
the criteria on OnClipboardHistoryItemAdded.
(cherry picked from commit 1293c05491009c1d9eecbc00182ba36821820eed)
Bug: 1138665
Change-Id: Ic50fcec0bd78a1ab5d6090024fb54de79141bec5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473165
Reviewed-by: Andrew Xu <[email protected]>
Commit-Queue: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817289}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476718
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#422}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4277.0-1602498224-benchmark-87.0.4280.20-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.21-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Id31fbf58ebd6352e2d9ae876891d51d5bac811d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477224
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#421}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge M87] About flags for conditional logging in Feed V1 and V2
(cherry picked from commit 5c4e4d0e42c41c8d2aa3a920f7a07b4ba1f25b3f)
Bug: 1138034
Change-Id: Ie695a12b14ec58a240ec3242a5c27958ad4e4405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463717
Commit-Queue: Vincent Boisselle <[email protected]>
Reviewed-by: Dan H <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816798}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476776
Reviewed-by: Vincent Boisselle <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#420}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Safety Tips] Better handle same-document navigations.
This CL prevents same-document navigations such as history.pushState and fragment navigations from resulting in a closed Safety Tip.
(cherry picked from commit 8521a09f519d40a3f47dab4bfe133b01543c7435)
Fixed: 1137661
Change-Id: Id0125055147d50c936c26a8763839e1f47244f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468189
Reviewed-by: Mustafa Emre Acer <[email protected]>
Commit-Queue: Joe DeBlasio <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816832}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476560
Reviewed-by: Joe DeBlasio <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#419}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 Merge][Metrics] Disable FamilyUserMetricsProvider
FamilyUserMetricsProvider currently causes a crash bug in guest mode.
Disable the feature flag and browser test while looking into a fix.
(cherry picked from commit 6e5972c83955129cd02bae8dc321b3f1b2a4c1d1)
Bug: 1137352
Change-Id: Ia327e39754f2bd48c9e9bfec11e4b1e6d47c447a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472263
Auto-Submit: Toby Huang <[email protected]>
Reviewed-by: Aga Wronska <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Alexei Svitkine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817167}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472906
Reviewed-by: Toby Huang <[email protected]>
Commit-Queue: Toby Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#418}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[iOS] Add NTP to BVC view hierarchy for Discover feed IPH
Adds the content suggestions collection view to the VC hierarchy from
the BVC. The named guide for the Discover feed IPH was not usable since
it could not make its way up to the BVC through its view hierarchy.
(cherry picked from commit 218310560b16c3df1ab5e03a042110607728badf)
Bug: 1131571
Change-Id: I97d6f4d9e0dc8642b93b040c2c1003f3588f853d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414613
Commit-Queue: Adam Trudeau-Arcaro <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816297}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471256
Reviewed-by: Sergio Collazos <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#417}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Avoid use-after-free of InfoBarAndroid from pointer in InfoBar.java
InfoBar.java has a native reference to InfoBarAndroid which should be
cleared before InfoBarAndroid is destroyed. Calls to
java_info_bar_.Reset() without corresponding onNativeDestroyed() or
setNativeInfobar() allow scenarios where java InfoBar still has non-null
pointer after native object was destroyed. This results in occasional
use-after-free.
This CL:
- renames onNativeDestroyed method to resetNativeInfoBar to indicate
that it is not necessarily called when native is destroyed, but in
general when native-java association changes.
- adds a call to reset native infobar into CloseJavaInfoBar to prevent
java infobar from referring potentially destroyed native object.
- removes unused ReassignJavaInfoBar().
BUG=1135130
R=[email protected]
(cherry picked from commit eec1d10023f3c39c830a6f9df5fdc4f90f937749)
Change-Id: I1329ed6a78cc589d8f23df883a8fcb60689230a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459268
Reviewed-by: Colin Blundell <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Pavel Yatsuk <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816281}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476714
Reviewed-by: Pavel Yatsuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#416}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 merge] ambient: change attribution text
Concatenate metadata_line_{1,2} with spaces.
Ignore metadata_line_3.
BUG=b:170360468
(cherry picked from commit a7e57da9a26a7c21f6cf73b92112b8454b14688d)
Change-Id: I3151728baac2d3b44330a54b1684844d83562def
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468839
Reviewed-by: Xiaohui Chen <[email protected]>
Reviewed-by: Tao Wu <[email protected]>
Reviewed-by: Meilin Wang <[email protected]>
Commit-Queue: Jeffrey Young <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817354}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475975
Cr-Commit-Position: refs/branch-heads/4280@{#415}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Ignore NetworkChangeNotifierAutoDetect#register strict mode violations
This strict mode violation is caused by a strict mode in
com.samsung.android.feature.SemCscFeature#isUseOdmProduct() on Samsung
devices
BUG=1121181
(cherry picked from commit 161b150aac12e21d79d47617c6b1b5b557cc3870)
Change-Id: If76dff59f26b26b65e0ca71ecf76fb3d7a2df4a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415277
Commit-Queue: Peter Kotwicz <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812928}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476375
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#414}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87][Metrics] Fix DCHECK failure in FamilyUserMetricsProvider
Sometimes ProvideCurrentSessionData() gets called at a bad time when
the user has finished logging in but the user profile has not finished
loading. This scenario causes a DCHECK failure. This CL returns
prematurely if the user profile has not finished loading, and
retrieves the primary profile manually.
(cherry picked from commit 16bb182fd6e5e7b9804463587b8ae6a8b2ae6bf1)
Bug: 1136561
Change-Id: Ibd4845b92c3284bd856f0a152618bb7abe5c44bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462632
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Toby Huang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816758}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476194
Reviewed-by: Toby Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#413}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[WebLayer] CherryPick: Abort Mediasession if WebLayer isn't inited.
Original description:
MediaSession service should abort if WebLayer isn't inited.
Currently, we crash.
(cherry picked from commit 9321a99a1a1ffd5898ac1b22653299ec6149ec58)
Bug: 1136823
Change-Id: I4570e8edaab9f95d81eaed2ae2f22570444b6659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462262
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Mugdha Lakhani <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816289}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475696
Reviewed-by: Mugdha Lakhani <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#412}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[CherryPick][iOS] Handle JavaScript Responses in CRWTextFragmentsHandler
Set-up response creation in JavaScript and handling in
CRWTextFragmentsHandler, allowing the collection of success/failure
metrics and measurement of the JavaScript library's rate of success.
(cherry picked from commit ff013a43d963dcc357eb8b67c1a448fc689629d8)
Bug: 1131107
Change-Id: I01eea5d85e2827a496b011d116592bebb74bd92e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448683
Commit-Queue: Sebastien Lalancette <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814791}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475573
Reviewed-by: Sebastien Lalancette <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#411}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[CherryPick][iOS] Create the TextFragmentsHandler Class
Moving some of the logic that used to live in utils into a new handler
class. This class will be used to receive asynchronous JavaScript
responses in a subsequent CL, hence the requirement to use an instance
rather than utility functions.
(cherry picked from commit fcc4e7066e34f5bd10fdec69ef41febb239617c1)
Bug: 1131107
Change-Id: I6752d1532bc5e64d40f327b7506e298d136e78a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446816
Commit-Queue: Sebastien Lalancette <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814304}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470466
Reviewed-by: Sebastien Lalancette <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#410}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android][WebSignin] Add SignedInWithAddedAccount metric
This CL adds the metric SignedInWithAddedAccount for the web sign-in
flow when a user added an account and signed in with the account.
(cherry picked from commit f7da4a8c0fbff0e264c03484e7b187aa707cebaa)
Bug: 1136776
Change-Id: Icb79b2a8cd187aa85e82928692575a351946b888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464266
Commit-Queue: Alice Wang <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816947}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474779
Reviewed-by: Alice Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#409}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[IntentHandling] Add metrics to record the preferred apps entry count.
This CL adds the metrics to record the preferred apps entry count that
was recorded in the disk. This value should be able to represent the
largest entry number before the user session stopped.
This CL also fixed a mistake I made for existing preferred apps metrics.
When I created "Apps.PreferredApps.UpdateAction" and
"Apps.PreferredApps.FileIOAction" metrics, I updated the scope in
the histograms.xml file, but forgot to update the scope in the UMA
recording function, causing a mismatch of the metrics name.
BUG=1134082, 853604
(cherry picked from commit 8117f92b5cc5104a8ec6d7cbb0fa8cb263235b22)
Change-Id: Ic00c7c78cdaba7268182122ead1877433c1fae61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442398
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Commit-Queue: Maggie Cai <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815486}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473881
Reviewed-by: Maggie Cai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#408}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Do not recreate rm watcher if already exists
ChromeOS apparently might send 2 mount events for the same path without
unmount event in between. Apparently this cause trouble in the map
assignment:
map[x] = CreateWatcher(x)
Because there, the operation order is:
1. A new watcher is created
2. The old watcher is removed
And the old watcher is associated with the same underlying
filesystem inotify object with the newly created watcher, causing
problem.
Therefore, the assignment to the map entry should only happen when
there were no old entry.
This should solve the crash that happen only when 2 mount events for the
same path happens without unmount event in between. When there is no
such repeated mount events, this CL is not needed, which explain the
random occurrence of the crash that is fixed by this CL.
BUG=b:169910596
TEST=Login multiple times and observe no crash.
(cherry picked from commit b53e1ee6b22e82f5b344acd344e3c12d6d4d3bdd)
Change-Id: Ibfc2ae15a367aa3ef4b2544fcd4ad570d0ee977f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451930
Commit-Queue: Risan <[email protected]>
Reviewed-by: Ryo Hashimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814561}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473880
Commit-Queue: Kazuhiro Inaba <[email protected]>
Reviewed-by: Kazuhiro Inaba <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#407}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87]Multipaste: Adjust the clipboard nudge bounds when hotseat is shown
This change has the clipboard nudge observe the hotseat state and will
animate the bounds of the clipboard nudge so that the nudge is always
placed above the hotseat.
(cherry picked from commit d1b3da5abdca2855ea6d6d02d82543a073e4bf72)
Bug: 1137019
Change-Id: If00afa1585e0382d7aa41789eca2a981b1323f1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469364
Commit-Queue: Matthew Mourgos <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817235}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473765
Reviewed-by: Matthew Mourgos <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#406}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
bind-gen: Fix HTML{Embed,Object}Element's named definer
For a historical reason, HTML{Embed,Object}Element's named
definer depends on a fallback logic of the definer and also
the named property setter.
This patch fixes the bug with a minimal change so that it's
easy to backport it.
(cherry picked from commit 7895d48b4faf51d22ece2f75ff021c484e61e1cb)
Bug: 1137541
Change-Id: Ic3af70604a379814fae24970317868ab89f7c4c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467744
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: Yuki Shiino <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816597}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473320
Reviewed-by: Yuki Shiino <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#405}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[webcodecs] Replace frame sync token in VideoFrame.createImageBitmap()
1. Attach a new sync token to the frame, so it's not destroyed before
the resulting image is fully created.
2. Introduce WaitAndReplaceSyncTokenClient to avoid duplicating
code from paint_canvs_video_renderer.cc
(cherry picked from commit 93fbade35c80745277ae5ccce3546fec690193a8)
Bug: 1136410
Test: https://webcodecs-blogpost-demo.glitch.me/ doesn't crash
Change-Id: I62d091776424f2ee3d550c8c5ef98f99f6720e9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465504
Commit-Queue: Eugene Zemtsov <[email protected]>
Reviewed-by: Frank Liberato <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816234}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472916
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#404}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge to M87: Fix automation event listeners in ChromeVox
Fixes a regression caused by http://crrev.com/c/2424854 ("Refactor
chrome.automation.EventType")
See http://crrev.com/c/2450663 for more context.
(cherry picked from commit 2ae57260cf44fa0ce985e9707ff80a67da5122aa)
Bug: 1110367, 1135248
Change-Id: I64de7e85f47ec1920c37e2730fbebdca4efaca3b
AX-Relnotes: none because this just fixes a regression
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454420
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814699}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473257
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#403}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge to M87: Fix automation event listeners in Select-to-speak
Fixes a regression caused by http://crrev.com/c/2424854 ("Refactor
chrome.automation.EventType"), it could have manifested as
select-to-speak not updating when the page scrolls.
See http://crrev.com/c/2450663 for more context.
(cherry picked from commit 8f2546436e53c0e123f87e8aae23b59bea4bdde9)
Bug: 1110367, 1135248
Change-Id: I12e62a18093a0fc2837ec0be312d4f7261c5dc42
AX-Relnotes: none because this just fixes a regression
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454633
Reviewed-by: David Tseng <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814738}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472914
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#402}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Merge to M87: Fix automation event listeners in Switch Access
In http://crrev.com/c/2424854 ("Refactor chrome.automation.EventType"),
we simplified the mappings from ax.mojom.Event and EventGenerator
events.
However, a minor oversight was that the previous code mapped some
generated events into automation events with different names. With
the new code, they map to an automation event with the same name -
but the old names still exist so they didn't generate a compile
error.
To ensure this was comprehensive, I wrote some code to log all of
the event mappings before and after the patch, and did a diff to
look for discrepancies. The diff is here -
https://paste.googleplex.com/6408048659660800 - but the only
relevant ones are:
- ariaAttributeChanged
- expandedChanged
- scrollPositionChanged
This patch fixes any instances of those three events in
Switch Access in particular. This fixes at regressions
with combo boxes and the virtual keyboard.
(cherry picked from commit e876cba52c989cf508f099edaeb1016ef2dccaad)
Bug: 1110367, 1135248
AX-Relnotes: none because it just fixes a regression
Change-Id: I5e3a3b98edb8d9fcdc3ad55b28ad2ce476da7e14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450663
Commit-Queue: Dominic Mazzoni <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814732}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472915
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#401}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87]Multipaste: Add keyboard shortcut icon inline with text.
This CL adds text to the nudge view and an inline icon to represent the
key to press to activate the keyboard shortcut. The icon shows as either
a search icon or a launcher icon, depending on what the device supports.
If the launcher icon is to be shown, then the icon is changed depending
on if assistant is available.
(cherry picked from commit 650ccc13876da3c8e63cdfd06dc5abffdecf401d)
Bug: 1105541
Change-Id: Ieaad19c899af545f38410350ece2d30a48409a11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463869
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Matthew Mourgos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816375}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472924
Reviewed-by: Matthew Mourgos <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#400}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Incrementing VERSION to 87.0.4280.21
[email protected]
Change-Id: I28b64c0e827d1bd769b1d36778fb0c0ab44e1dee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473441
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4280@{#399}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Dont start explanatory string animation until permission is determined
There is a period of time before macOS gives us a signal of our
location permission status. During this time we mostly assume that we
do not have permission. This is mostly not even noticed by the user as
it happens to quickly. However, if we dont have permission for location
we start an animation to let the user know. This animation does not
stop once permission is determined so it is very noticeable. This change
only starts that animation once permission is actually determined.
(cherry picked from commit 69a1223a698a27e2179abea00f4f88232f89a7e3)
Bug: 1134741
Change-Id: I3af75da2b5fcfc80aa5f42d9e5aa88e8ee74d829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446023
Reviewed-by: James Hollyer <[email protected]>
Reviewed-by: Balazs Engedy <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: James Hollyer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814407}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472907
Cr-Commit-Position: refs/branch-heads/4280@{#398}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Omnibox] Adds feature to disable remote ZPS caching
Fixed: 1136654
Change-Id: I55f7cb4ca34332a33d81421a9a21475279e6fa08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463335
Reviewed-by: Tomasz Wiszkowski <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#816202}
(cherry picked from commit d9379587734c44089bb8be4278fa5e6a7de12fa5)
[email protected]
Change-Id: Ibe4ce9d810e8667ef7d096efeb3d21135e254e85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472441
Reviewed-by: Moe Ahmadi <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: Moe Ahmadi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#397}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
LiteVideo: Fix throttling to stop permanently on rebuffer event
Currently throttling is temporaily stopped, i.e., new requests will get
throttled, on too much rebuffer events. This CL changes it to stop
permanently.
(cherry picked from commit f70102260f556c0023d63af04c9042f7284b5306)
Bug: 1137505
Change-Id: Iae6453c3799229939415bac5205450b82c4a4ae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466605
Reviewed-by: Michael Crouse <[email protected]>
Commit-Queue: rajendrant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816315}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473158
Reviewed-by: rajendrant <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#396}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Disable sampling on cycles precise on all microarchitectures.
We see a large fraction of unmapped samples with cycles precise.
Disable sampling on cycles precise while we investigate the root
cause of unmapped samples.
BUG=b:170558957,b:168312716
(cherry picked from commit 7f450ac3a422174bd016d71b753120ce4acb742d)
Change-Id: Ie566e8e870e0bebc8db8355222f4cbf8cc61e055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471579
Reviewed-by: George Burgess <[email protected]>
Reviewed-by: Gabriel Marin <[email protected]>
Commit-Queue: Gabriel Marin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817107}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472925
Cr-Commit-Position: refs/branch-heads/4280@{#395}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Revert "[CrOS Customization] Update app icons"
This reverts commit dc1d693f33736a3d6ca88adb7dacb048374d65ae.
Reason for revert: No longer wanted in M-87
Original change's description:
> [CrOS Customization] Update app icons
>
> Includes icons for the Settings, Wallpapers, and Keyboard Shortcuts
> apps.
>
> Screenshot: https://screenshot.googleplex.com/7KdMiBkMFH7fuxh.png
>
> Change-Id: I6cf1d45d78f36caeb1429629cc0067b1cbd57daa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429395
> Auto-Submit: Kyle Horimoto <[email protected]>
> Commit-Queue: Kyle Horimoto <[email protected]>
> Commit-Queue: James Cook <[email protected]>
> Reviewed-by: James Cook <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#810376}
(cherry picked from commit 411f55ec69256ff2b8f8b6d8089455cea895381f)
Fixed: 1138609
Change-Id: Iaa04c22814b3d8cd1ddc06ceb7a7beb14ad8d030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472346
Commit-Queue: Kyle Horimoto <[email protected]>
Commit-Queue: James Cook <[email protected]>
Auto-Submit: Kyle Horimoto <[email protected]>
Reviewed-by: James Cook <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817236}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473079
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#394}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87 Merge] Quick Answers: Filter invalid query text for current model
The current text annotation model we are using is not good at
concatenated words like "SampleClassName" and words contains special
characters like "test_example(". Since it takes time for us to roll up
to the v2 model, filter such kind of queries for now to improve the
quality.
(cherry picked from commit 7c206ad4f5d177ec931752a73bb1bb5ab3c302c3)
Bug: b/159664194
Test: Manual Test
Change-Id: I203388766b160fa7f3368702e1c75683a3e148ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440832
Commit-Queue: Yue Li <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812947}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472911
Reviewed-by: Yue Li <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#393}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87]Multipaste: Add a contextual nudge view
This change adds a nudge view that is triggered to show after copy and
pasting twice. The nudge is only shown for 6 seconds before being
automatically dismissed. The nudge should only be shown 3 times total.
(cherry picked from commit 4262b7b6810f7c703666a71006d531164cdb199f)
Bug: 1105541
Change-Id: Ic31863e1bab23ca50a298e22848611168bd17dca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417978
Commit-Queue: Matthew Mourgos <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815835}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472921
Reviewed-by: Matthew Mourgos <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#392}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Reland "Rewrite scroll interruption tests into browser tests"
After we finish the scroll unification, the scrolls happens mainly on
the compositor thread, and the scroll code in the main thread will be
removed. eventSender sends the scroll events to main thread, so it
would not work after the scroll unification. We rewrite below tests
fast/scroll-behavior/main-frame-interrupted-scroll.html,
fast/scroll-behavior/overflow-interrupted-scroll.html and
fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests
because we cannot guarantee that the scroll arrives before the animation
completes.
[email protected], [email protected]
Bug: 1047176
(cherry picked from commit f453f2d2bf2cb912690dc091b35a057e5ff571e4)
Change-Id: I46a6cb0697b8a74ff260aafbc2fc60a7d65ae1a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446534
Reviewed-by: Lan Wei <[email protected]>
Commit-Queue: Lan Wei <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814707}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472703
Cr-Commit-Position: refs/branch-heads/4280@{#391}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Don't attempt to cast holding space item view during destruction.
When `OnViewIsDeleting` is called, the holding space item view is
already well into its destruction sequence. We shouldn't attempt to cast
from `views::View` back to `HoldingSpaceItemView` at this time and we
have no need to.
(cherry picked from commit 974b58c842d7b20a2e5f66295565984809aa3d2a)
Bug: 1137461
Change-Id: I3c431af03b692d15b4e83de25d9ffcaa2b35d148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472584
Reviewed-by: Toni Baržić <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#817149}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472439
Reviewed-by: David Black <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#390}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
M87: PDF Viewer Update: Display find-in-page tickmarks.
To make this work with the new layout, where the PDF plugin now lives in
a <div>, make some PDF Viewer changes:
1) The PDF plugin element gets an attribute to mark it as having the new
UI.
2) PepperPluginInstanceImpl looks for the attribute in PDF plugins, and
calls the newly added blink::WebElement::SetTickmarks() on the PDF
Viewer's "scroller" element.
And make several Blink changes to accommodate this new need:
3) Some find-in-page tickmarks override code moves from
blink::LayoutView up the class hierarchy to blink::LayoutBox. The
tickmarks override data member moves to
blink::PaintLayerScrollableAreaRareData.
4) blink::WebLocalFrame::SetTickmarks() is extended with a target
blink::WebElement parameter. If non-null, SetTickmarks() finds the
WebElement's LayoutBox for scrolling, and overrides the tickmarks
using the code in (3), instead overrides the tickmarks in the
blink::LayoutView.
5) PaintLayerScrollableArea looks at its tickmarks override rare data
member and uses it if it is non-empty. Then they get painted as
normal.
(cherry picked from commit 0d039e86851e85685a057d23fb2237549f7d0b31)
Tbr: [email protected]
Bug: 1135457
Change-Id: I211510a7b09544823d960219bda7128f8694aae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462167
Reviewed-by: Rebekah Potter <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Reviewed-by: Raymes Khoury <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Matt Falkenhagen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816555}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472917
Reviewed-by: Lei Zhang <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#389}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Views: Fix tab controls to sit flush with the top of the tab strip
This CL updates the tab strip's UpdateNewTabButtonBorder() method to
apply the vertical border insets to the tab control buttons rather
than the tab controls container.
This is necessary as the NewTabButton will extend its targetable
area to the top of its bounds when the tab strip is in a condensed
state (i.e. the window is maximized). This is done to ensure the
tab strip controls comply with Fitt's law expectations.
(cherry picked from commit 022d70c762cc57f7037f84719be1bca368c2d165)
Bug: 1136557
Change-Id: I8b312363bdabbef358ec2689321bb30d7680953b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463994
Commit-Queue: Thomas Lukaszewicz <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815821}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472602
Reviewed-by: Thomas Lukaszewicz <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#388}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87]Highlight the Enhanced Protection section.
If the Safe Browsing settings was reached to
from the Enhanced Protection promo from the
new tab page on Android, then the enhanced
protection radio button section should be
highlighted in Blue50.
Screenshot: http://screen/5MRDafWDYScPBac
Dark Mode: http://screen/AznVfBwK8AD8rN3
(cherry picked from commit 951d0abbdb03d1ee083abd446c1e3b82dddd6425)
[email protected]
Bug: 1135808
Change-Id: Ia8dc98624a394e0a8fe38711c8f4c108cf72a85b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454490
Reviewed-by: Lijin Shen <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Reviewed-by: Natalie Chouinard <[email protected]>
Commit-Queue: Bettina Dea <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816698}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472607
Reviewed-by: Bettina Dea <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#387}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Airmont AFDO profile from 87-4277.0-1602506009-benchmark-87.0.4280.19-r1 to 87-4277.0-1602506009-benchmark-87.0.4280.20-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: If2e47e3add83fcaf1d4f1c18af41a041ea9562ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472627
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#386}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Broadwell AFDO profile from 87-4277.0-1602501961-benchmark-87.0.4280.19-r1 to 87-4277.0-1602501961-benchmark-87.0.4280.20-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I603b33f4dcc16ca43a759f7a63a702a63004a931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472630
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#385}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Roll ChromeOS Silvermont AFDO profile from 87-4277.0-1602498224-benchmark-87.0.4280.19-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.20-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ib6207a60f7526c3b30cd796e0901e110e93b4aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472621
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#384}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
M87: PDF: Prevent a NOTREACHED() in HandleUpdateScrollMessage().
In OutOfProcessInstance::HandleUpdateScrollMessage(), the messages
received from JS sometimes contain integers and sometimes contain
doubles. As such, check validate them with is_number() rather than
is_int().
(cherry picked from commit df50432c5a621aa579ab7fbc560cb7b178a05498)
Tbr: [email protected]
Bug: 1136983
Change-Id: Id3112e660a96d596b9da92c453caa5f697e5a5f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466514
Reviewed-by: Rebekah Potter <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816405}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472898
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#383}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: I81e3f05af7652f198b0443f3c617e31d570cef5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472482
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#382}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Restore classic ink drop highlights.
This addresses changes in:
https://chromium-review.googlesource.com/c/chromium/src/+/2442354
Note that the restoration is not exact as we are maintaining a fix to
unify launcher inkdrop highlights due to this related bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=1051167
(cherry picked from commit f79c2974247a1337c11c44c4f4cc8f37a742cabb)
Bug: 1134800
Change-Id: Ie7f70b30bf4ec5fc646cb77e8b18578b96392024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464364
Reviewed-by: Yulun Wu <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816346}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472421
Cr-Commit-Position: refs/branch-heads/4280@{#381}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Handle default accessible action on holding space views.
This handles the case where ChromeVox users attempt to "click" holding
space item views via Search + Space.
(cherry picked from commit b62c9cb21172373ced9a473238baddfe4449e678)
Bug: 1137039
Change-Id: Ia4772195a4aba92ed405f74a8ac7c179643a82c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468338
Reviewed-by: Toni Baržić <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816708}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472499
Reviewed-by: David Black <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#380}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
exo: temporarily clamp display scale factor to 2
Version of QT currently in use by Parallels Desktop does not render
correctly when display scale factor is above 2, so let's use 2 as the
upper bound until they switch to a newer version of QT (5.15 should
have the fix).
(cherry picked from commit a96ef56cae28cd8c0680ce94b702fdd5c7a04f4d)
Bug: b/169984627
Change-Id: Idd31b9a737833fa48ab6b20ae8da5f1bf951b3ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446720
Commit-Queue: Dmitry Torokhov <[email protected]>
Reviewed-by: Mitsuru Oshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816020}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469371
Cr-Commit-Position: refs/branch-heads/4280@{#379}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add number of NTP tabs on start and resume histograms
(cherry picked from commit 0e84a572c5483bd285803e5f2770f74f8ead0269)
Bug: 1136539
Change-Id: I1bd58115d0d2c0f4502049040181227bcee85d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461709
Commit-Queue: Ganggui Tang <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Auto-Submit: Ganggui Tang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816587}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471820
Reviewed-by: Ganggui Tang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#378}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87]Get max EP promo impressions from server-side.
Max EP promo impressions should be defined
in the server-side experiment and not hard-coded.
SigninPromo max impressions will also be defined
in the same experiment as it is introduced only
when the Enhanced Protection promo has started
its experiment.
[email protected]
(cherry picked from commit 7c2d94ef1fb2105fe156bf3514080c7132bb81b2)
Bug: 1136612
Change-Id: I5ecf4f60ed01af7dcf493a9c2ab24674df05553c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461994
Commit-Queue: Bettina Dea <[email protected]>
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816447}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472483
Reviewed-by: Bettina Dea <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#377}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge-87][Sh-Clank] Custom toast for error messages
On Android 11, setGravity is deprecated. For text toasts is noop.
Therefore, create toast from a custom view, for which setGravity still
works. This is a short term solution.
(cherry picked from commit 81c9fe43535abe55037ba925a07509f560572b75)
Bug: 1135597
Change-Id: I8b382bb3dbe112601300bc0d8405591393da080e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471597
Reviewed-by: Gayane Petrosyan <[email protected]>
Commit-Queue: Gayane Petrosyan <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#376}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Decouple IsolatedPrerender from Lite Mode and its config
Adds a experiment param to require the user to have Lite Mode enabled,
default true for the time being.
Also removes the integration with the Data Saver config to get the proxy
tunnel hosts and chrome-proxy header.
Now, the tunnel host will be given through experiment param or cmd line
and uses a tunnel header with the Google API key.
Also fixes some flakiness in the new probing tests.
(cherry picked from commit 3d6bd6b539b7c56a26b6d7eab46712f3df928eda)
Bug: 1135213
Change-Id: I23802a5c9787abe669759be0f782b3d586afd7dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449912
Commit-Queue: Robert Ogden <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815239}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471578
Reviewed-by: Robert Ogden <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#375}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Activate holding space bubble when opening w/ ChromeVox enabled.
When ChromeVox is enabled, the holding space bubble should be activated
on open so as to announce itself and so as to move ChromeVox focus into
the bubble.
(cherry picked from commit daa06ec14fe59bd25fa1eb9273f57bc4cfb58e1c)
Bug: 1137067
Change-Id: I454813ad1116a2ddb1d27e6ff6251849d5d96dcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468341
Reviewed-by: Toni Baržić <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816707}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471802
Reviewed-by: David Black <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#374}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Null check before getInstallerPackageName
The crash report shows the IllegalArgumentException is because of
package name is null.
Add a null check before getting the installer package name.
(cherry picked from commit edce258f08cadaffa74cc97dc1334e77f3d06e86)
Bug: 1136018
Change-Id: I90f38bfcf67cf5de41996b3bf463633e2db2bca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457369
Commit-Queue: Ella Ge <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815659}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470468
Reviewed-by: Ella Ge <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#373}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Merge-M87][Passwords] Use |PwdScriptsFetching| instead of |PwdChangeInSettings|
This CL fixes two issues. Both issues occurred when
|PasswordChangeInSettings| was splitted into two flags
|PasswordChangeInSettings| and |PasswordScriptsFetching|
(https://chromium-review.googlesource.com/c/chromium/src/+/2436339), but
some uses of |PasswordChangeInSettings| were not replaced with
|PasswordScriptsFetching|. The change is supposed to be merged to M87
Beta.
1. The param |scripts_list_url| should be read from
|PasswordScriptsFetching|
Scripts fetching is controlled by |PasswordScriptsFetching| flag, not
|PasswordChangeInSettings| flag. The latter might be disabled while
scripts need to be fetched. So, it makes sense to read the param from
the relevant feature - |PasswordScriptsFetching|.
To be on the safe side, the Finch config can provide the param for
both features, but the param names must be unique even in separate
features. So, this CL renames the param (the param value was not
used yet, so we don't need to update any configs).
2. Scripts prewarming should be controlled by |PasswordScriptsFetching|,
not |PasswordChangeInSettings|.
This issue was not severe and therefore it was hard to notice: even if
scripts were not prefetched in advance, scripts were requested when a
password check page was shown (|PasswordCheckManager::RefreshScripts|).
That method used the correct flag.
Bug: 1095627
Change-Id: Ic7b4062ed51a8a472c1f45a5227210aa89fcb722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465913
Commit-Queue: Maxim Kolosovskiy <[email protected]>
Reviewed-by: Andrey Zaytsev <[email protected]>
Reviewed-by: Ioana Pandele <[email protected]>
Cr-Commit-Position: refs/heads/master@{#816549}
[email protected],[email protected]
Change-Id: Ic7b4062ed51a8a472c1f45a5227210aa89fcb722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471457
Reviewed-by: Maxim Kolosovskiy <[email protected]>
Commit-Queue: Maxim Kolosovskiy <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#372}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Limit minimum scale of PaintedScrollbarLayer to 1
This is to avoid too low scale when animating scale above the
scrollbar layer.
This is not ideal. In the future we should move rasterization of
scrollbar layers to impl-side to better handle scales
(crbug.com/1009291).
[email protected], [email protected]
(cherry picked from commit a383d2923ba0f69d58ddb6092c6238b7a2914244)
Bug: 1133997, 1137871
Change-Id: I7719f62f9b23f31f9c35094ac3c1de2a73dfdef0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459137
Reviewed-by: Xianzhu Wang <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815240}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468706
Cr-Commit-Position: refs/branch-heads/4280@{#371}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Metrics] Improved cold start detection when start surface enabled
Improve detection of if a true cold start is happening. If start surface
is shown then we should omit cold start metrics as in that case these
metrics don't accurately reflect performance regressions. See bug for
UMA histograms showing the effect.
(cherry picked from commit e57cc990faf16aff5858420ad7617c7f260021d7)
Bug: 1135566, 1135651
Change-Id: I99bab63f4e4fa3e34133bbe73718520164ff6355
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450921
Commit-Queue: Calder Kitagawa <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Reviewed-by: Xi Han <[email protected]>
Reviewed-by: Mehran Mahmoudi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815295}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471257
Reviewed-by: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#370}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android] Change ManageSyncSettings page title
Change ManageSyncSettings title to "Sync".
Screenshot: https://crbug.com/1135923#c6
(cherry picked from commit 8b2168ee07fa7cf13c2f88dc05cf05674c33785e)
Bug: 1135923
Change-Id: I4a4c732b5149ae78476186c07893a1b61b0ad7b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461341
Reviewed-by: Marc Treib <[email protected]>
Commit-Queue: Tanmoy Mollik <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816147}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470533
Reviewed-by: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#369}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Android] Change color of sync_off icon in Main settings page
Change color to grey_500 for both light mode and dark mode.
Screenshot: https://crbug.com/1135915#c4
(cherry picked from commit 63b8c5ba75bb9af9e37e5b4dfe6780bae0dcc6d6)
Bug: 1135915
Change-Id: I29e790195a4f6d276dceb32aab1d19ba5dc7744e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456527
Reviewed-by: Boris Sazonov <[email protected]>
Commit-Queue: Tanmoy Mollik <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815624}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471278
Reviewed-by: Tanmoy Mollik <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#368}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add UMA to record whether the extension is from cache or not
We want to investigate why the force installed extensions fail to
install with error CRX_HEADER_INVALID. This CL adds UMA statistics
to record whether the extension is downloaded from cache or not when
extension fails with CRX_HEADER_INVALID error to get more details
about it.
New histogram added:
"Extensions.ForceInstalledFailureWithCrxHeaderInvalidIsFromCache"
(cherry picked from commit 1e01124fa9f126d3d4e8b61397ec931db0ff8863)
Bug: b/170087934
Change-Id: I843e4a1c2cce87b3975e2ad426f9b8177a744878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460734
Reviewed-by: Saurabh Nijhara <[email protected]>
Reviewed-by: Brian White <[email protected]>
Reviewed-by: Oleg Davydov <[email protected]>
Commit-Queue: Swapnil Gupta <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816786}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471057
Reviewed-by: Swapnil Gupta <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#367}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Paint Preview] Fix positioning on Android M and earlier
Found out that setMatrix() is broken, but concat() is a viable
alternative.
https://stackoverflow.com/questions/17100355/canvas-is-offset-by-setting-identity-matrix-in-ondraw-of-custom-view
(cherry picked from commit d11be2adb9bbdea5642ed1be72feeba2fc0b5a5a)
Bug: 1126541
Change-Id: I30f4e37dd488385c2f024ac9ae8aa0de8277aa6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461214
Reviewed-by: Mehran Mahmoudi <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815354}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470461
Reviewed-by: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#366}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[M87][Signin][Android] Use 'Turn on sync' as button text in promo
Changes the text used for the primary button in sync promo that is shown
in the signed out state. The text is changed from "Continue as ..." to
"Turn on sync". Applied only if MobileIdentityConsistency flag is
enabled.
Screenshot: https://crbug.com/1136905#c1.
(cherry picked from commit 6786c0a783f32164304550c73f2f779c0bf24560)
Bug: 1136905
Change-Id: I967768061e26a01a4d34cdedee463fd8276dc969
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462267
Commit-Queue: Boris Sazonov <[email protected]>
Reviewed-by: Tanmoy Mollik <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816526}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470635
Reviewed-by: Boris Sazonov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#365}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[Paint Preview] More gracefully handle OOM in allocating bitmap
More gracefully handle OOM in allocating bitmaps by replying with an
error rather than crashing.
(cherry picked from commit e09cc7e768522b4ff0167e8156ff31229dcc098a)
Bug: 1136929
Change-Id: Ic1c47089623e813415cf270bd506b1aab12509a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461805
Reviewed-by: Mehran Mahmoudi <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: Calder Kitagawa <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815728}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469260
Reviewed-by: Calder Kitagawa <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#364}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
crostini: Fix a disk resizing bug
Now that we round sizes to human-friendly numbers (e.g. nearest 0.1GiB),
and we round down the top of the range of allowed sizes, it's possible
to end up with a disk that's allocated a legal amount, but which is
beyond the slider range. Now we ensure that we always include whatever
size disk the user currently has in the range.
Bug: chromium:1126705
Test: Run new unit test that hits this case.
(cherry picked from commit bff26532a551629f1213d065c41919244bba21a1)
Change-Id: I7f8fb7bfe652b596da0763693699d74c6c61d39d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459133
Commit-Queue: David Munro <[email protected]>
Auto-Submit: David Munro <[email protected]>
Reviewed-by: Fergus Dall <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815466}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469338
Reviewed-by: David Munro <[email protected]>
Commit-Queue: Fergus Dall <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#363}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
(Merge): [iOS][Omaha][Safety Check] Move userdefault update status to Omaha
Update the isUpToDate util function to use userdefaults update status
instead of verifying off version and version discrepancy.
Move userdefault update status recording to Omaha as regular update
checks will never record an up to date status.
(cherry picked from commit 1f3c13b0a620b9acb45f8ec5780eb96078f78e9d)
Bug: 1078782, 1137797
Change-Id: Ibe2692b573efb3180ef0f255530545d75ab3248b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462256
Commit-Queue: Sean Harrison <[email protected]>
Reviewed-by: Javier Ernesto Flores Robles <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816165}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467938
Reviewed-by: Sean Harrison <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#362}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Updating XTBs based on .GRDs from branch 4280
[email protected]
Change-Id: I3288c6d5fedbc399a81c555e6e6a7d0bce7739bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470458
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#361}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Opt in to CompositeSVG based on descendants rather than paint
This patch updates GraphicsLayer::ShouldCreateLayersAfterPaint during
the CompositedLayerMapping update based on
LayoutSVGRoot::HasDescendantWithCompositingReason, rather than doing
this after paint based on the painted output. This is both simpler and
avoids unnecessary compositing.
(cherry picked from commit 994221afc4e6d1e12216a36f14ef03a79cc84a05)
Bug: 1132598
Change-Id: I11b6d2a32b7dc3b7f9a1b068a4806382d2cd6443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461429
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815236}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468696
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#360}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Add UMA to record whether the extension is from CWS
We want to investigate why the force installed extensions fail to
install with error CRX_HEADER_INVALID. This CL adds UMA statistics
to record whether the extension is from Chrome Web Store or not when
extension fails with CRX_HEADER_INVALID error to
get more details about it.
New histogram added:
"Extensions.ForceInstalledFailureWithCrxHeaderInvalidIsCWS"
(cherry picked from commit 3f4a6b7209515758dce0e350673c32dc7395062f)
Bug: b/170080693
Change-Id: I5cbaef996151fa75aa5716c985c5ce2035a04ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449334
Commit-Queue: Swapnil Gupta <[email protected]>
Reviewed-by: Oleg Davydov <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#815097}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469652
Reviewed-by: Swapnil Gupta <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#359}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
media/gpu/vaapi: Don't reuse VASliceData on VP9 decoding
When the VASliceData buffer is re-used, decoded frames randomly
have artifacts. This is a workaround of the issue. VASliceData
is always created on submitting each frame.
(cherry picked from commit 51294a2a2d3e6c2b8e1ad295522a649f6197ab34)
Bug: b:166646505, b:169725321
Test: Play swirl_128x128_vp9.webm on eve-kernelnext
Change-Id: I85d9b7902496b84fd905da0e80dd604298db0bd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448272
Commit-Queue: Hirokazu Honda <[email protected]>
Auto-Submit: Hirokazu Honda <[email protected]>
Reviewed-by: Andres Calderon Jaramillo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#814005}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470057
Reviewed-by: Hirokazu Honda <[email protected]>
Commit-Queue: Kazuhiro Inaba <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#358}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
Restore classic launcher backgrounds.
This CL addresses changes in:
https://chromium-review.googlesource.com/c/chromium/src/+/2421441
(cherry picked from commit 685d1940a45c1688f02b748bedd00df7624d1675)
Bug: 1134800
Change-Id: Idfe0c66caa4c3e9219a7bdc5c61f91a0bb77856c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464343
Reviewed-by: Yulun Wu <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#816824}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469472
Cr-Commit-Position: refs/branch-heads/4280@{#357}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
[css-flex] Disable replaced item aspect ratio fixes in Chrome 87
There was an unintentional regression that I have a fix for in
https://chromium-review.googlesource.com/c/chromium/src/+/2462574 , but
that patch needs baking time on ToT, I don't want to merge it to 87.
So I want to disable these changes just on the 87 branch, which this CL
does.
Bug: 1132627
Change-Id: Ie7fcf244dd32f1cb7a40dfa7a3343280d2b794f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460207
Commit-Queue: David Grogan <[email protected]>
Reviewed-by: Christian Biesinger <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Reviewed-by: Lakshmana Pamarthy <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#356}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}