Browser process does not try to create RemoteDebuggingServer again if it is already created anymore.

Browser process does not try to create RemoteDebuggingServer again if it is already created anymore.

BUG=143890
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153275

[vsevik, 2012-08-21 09:27:27]

Could you please review this?

We should probably consider adding Ensure... or ...IfNeeded to the name of this
method.

[pfeldman, 2012-08-21 09:39:22]

https://chromiumcodereview.appspot.com/10827438/diff/1/chrome/browser/browser...
File chrome/browser/browser_process_impl.cc (right):

https://chromiumcodereview.appspot.com/10827438/diff/1/chrome/browser/browser...
chrome/browser/browser_process_impl.cc:474: void
BrowserProcessImpl::InitDevToolsHttpProtocolHandler(
CreateDevToolsHttpProtocolHandler ?

[vsevik, 2012-08-21 09:56:23]

Please take another look.

[pfeldman, 2012-08-24 10:10:08]

lgtm

[commit-bot: I haz the power, 2012-08-24 10:16:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10827438/4001

[commit-bot: I haz the power, 2012-08-24 10:16:40]

Presubmit check for 10827438-4001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome/browser/ui
    chrome/test

Presubmit checks took 1.0s to calculate.

[vsevik, 2012-08-24 10:28:07]

Scott, could you please review this?

[sky, 2012-08-24 17:31:42]

LGTM - in the future feel free to TBR this sort of thing.

[commit-bot: I haz the power, 2012-08-24 19:11:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/10827438/4001

[commit-bot: I haz the power, 2012-08-24 20:50:38]

Change committed as 153275