Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10875019: [Android] Fix some linker errors from browser startup. (Closed)

Created:
8 years, 4 months ago by Yaron
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, Torne
Visibility:
Public.

Description

[Android] Fix some linker errors from browser startup. A step towards actually using BrowserMainPartsAndroid BUG=138184 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152881

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : thakis nits #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A + chrome/browser/ui/android/status_tray_android.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yaron
8 years, 4 months ago (2012-08-22 20:16:31 UTC) #1
Nico
lgtm http://codereview.chromium.org/10875019/diff/5001/chrome/browser/browser_process_impl.cc File chrome/browser/browser_process_impl.cc (right): http://codereview.chromium.org/10875019/diff/5001/chrome/browser/browser_process_impl.cc#newcode556 chrome/browser/browser_process_impl.cc:556: DCHECK(CalledOnValidThread()); Can you keep the DCHECK above the ...
8 years, 4 months ago (2012-08-22 20:38:35 UTC) #2
Yaron
Thanks http://codereview.chromium.org/10875019/diff/5001/chrome/browser/browser_process_impl.cc File chrome/browser/browser_process_impl.cc (right): http://codereview.chromium.org/10875019/diff/5001/chrome/browser/browser_process_impl.cc#newcode556 chrome/browser/browser_process_impl.cc:556: DCHECK(CalledOnValidThread()); On 2012/08/22 20:38:36, Nico wrote: > Can ...
8 years, 4 months ago (2012-08-22 20:45:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/10875019/3002
8 years, 4 months ago (2012-08-22 20:45:52 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-23 00:02:50 UTC) #5 
Change committed as 152881

Powered by Google App Engine
This is Rietveld 408576698