Opened 4 months ago

Closed 3 months ago

Last modified 3 months ago

#36446 closed Bug (fixed)

Django 5.2.2 incompatibly removed q from MediaType.params

Reported by: Anders Kaseorg Owned by: Natalia Bidart
Component: HTTP handling Version: 5.2
Severity: Release blocker Keywords:
Cc: Anders Kaseorg Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

​https://github.com/django/django/pull/19507#discussion_r2130422564

Between Django 5.2.1 and 5.2.2, the q entry was removed from the MediaType.params dict. Even though MediaType is not documented as a public API, it does have users (such as Zulip). This seems like an unnecessary breaking change, especially for a stable patch release. I was asked to file a ticket for this, so here it is.

Change History (6)

comment:1 by Natalia Bidart, 3 months ago

Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted

Hello Anders, thank you for creating this ticket. Accepting based on the PR conversation.

Regression in c075508b4de8edf9db553b409f8a8ed2f26ecead.

comment:2 by Natalia Bidart, 3 months ago

Owner: set to Natalia Bidart
Status: new → assigned

comment:3 by Natalia Bidart, 3 months ago

Has patch: set

comment:4 by nessita <124304+nessita@…>, 3 months ago

Resolution: → fixed
Status: assigned → closed

In cf5f36b:

Fixed #36446 -- Restored "q" in internal MediaType.params property.

The "q" key was removed while addressing ticket #36411. Despite
MediaType.params is undocumented and considered internal, it was used
in third-party projects (Zulip reported breakage), so this work restored
the q key in params.

Thanks Anders Kaseorg for the report.

Regression in c075508b4de8edf9db553b409f8a8ed2f26ecead.

comment:5 by Natalia Bidart, 3 months ago

Triage Stage: Accepted → Ready for checkin

comment:6 by Natalia <124304+nessita@…>, 3 months ago

In cc50797:

[5.2.x] Fixed #36446 -- Restored "q" in internal MediaType.params property.

The "q" key was removed while addressing ticket #36411. Despite
MediaType.params is undocumented and considered internal, it was used
in third-party projects (Zulip reported breakage), so this work restored
the q key in params.

Thanks Anders Kaseorg for the report.

Regression in c075508b4de8edf9db553b409f8a8ed2f26ecead.

Backport of cf5f36bf903a2854f5e395149cee707115b83744 from main.

Note: See TracTickets for help on using tickets.
Back to Top